The previous patch didn't work because the helper running as the unelevated
user is the only one that can read the pref out of its user registry hive,
which is where Firefox has to write it, but then since it's limited it can't
write to either the shortcut log or to HKLM. So everything has to happen in
HKCU so that the unelevated helper can both read and write where it needs to
read and write to.
Differential Revision: https://phabricator.services.mozilla.com/D53113
--HG--
extra : moz-landing-system : lando
My initial idea of using the shortcuts log to store this information didn't
work out because the helper, when run by an updater which was run by the
maintenance service, doesn't get write permissions on that file.
Differential Revision: https://phabricator.services.mozilla.com/D52276
--HG--
extra : moz-landing-system : lando
The minidump-analyzer tool was originally conceived to be used from the crash
report client and as such was installed in the crash reporter client
application bundle on macOS. It was later adapted to work from Firefox itself
but this caused linking problems when invoked from the Firefox app bundle.
This patch moves the minidump-analyzer into the Firefox app bundle and adapts
the relevant code to find it there.
The minidump-analyzer was also not signed like the rest of our executables and
this patch addresses that issue too.
Differential Revision: https://phabricator.services.mozilla.com/D52910
--HG--
extra : moz-landing-system : lando
Spoof dom/dom.properties, layout/xmlparser.properties,
layout/MediaDocument.properties to en-US if needed.
Differential Revision: https://phabricator.services.mozilla.com/D46034
--HG--
extra : moz-landing-system : lando
Spoof dom/dom.properties, layout/xmlparser.properties,
layout/MediaDocument.properties to en-US if needed.
Differential Revision: https://phabricator.services.mozilla.com/D46034
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41145
--HG--
extra : moz-landing-system : lando
At least for now, this behavior is behind a hidden pref. The intent is to
experiment with the feature and determine that way whether enabling it
permanently is a good idea, and if so the pref gate will be removed in a
separate bug.
This patch depends on bug 1567247 and will fail to build without it.
Differential Revision: https://phabricator.services.mozilla.com/D41100
--HG--
extra : moz-landing-system : lando
We intentionally only clean out the prefs registry key during uninstall, unlike
the other registry keys that the installer creates, because we might want to do
experiments that involve the procedures that normally clean out registry keys.
This leaves open the possibility that an experiment causes some problem that
by its nature makes it difficult to disable the experiment, since it wouldn't
be disabled by either a normal update or a paveover install, but it's
necessary to make sure that experiments persist for longer than e.g. a single
update cycle.
Depends on D40327
Differential Revision: https://phabricator.services.mozilla.com/D40328
--HG--
extra : moz-landing-system : lando
This makes prefs definition simpler, more consistent, and less error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D41324
--HG--
extra : moz-landing-system : lando
MANUAL PUSH: This is mhowell manually combining a new contributor's patch stack.
Differential Revision: https://phabricator.services.mozilla.com//D41477
--HG--
extra : source : 7219965f391ab9b548ea0e9305ef5acafd2640d5
extra : amend_source : 9a7c03a5e8a7c6a2ec7ca005cda08336846ec977
When privacy.spoof_english = 2, we should hide the user's
locale in content. So we use en-US default strings for HTML
form elements, such as a Submit button.
We also force GetLocalizedEllipsis() to always return the
ellipsis used by en-US.
Differential Revision: https://phabricator.services.mozilla.com/D35815
--HG--
extra : moz-landing-system : lando
This was kept to support old xul addons. All mozilla-central usages
have been removed and now uses Loader.jsm to get access to this module.
Differential Revision: https://phabricator.services.mozilla.com/D38321
--HG--
extra : moz-landing-system : lando
The installer for aarch64 Windows has exceeded the current limit. This new one
(150 MB) should allow enough breathing room while still being reasonable.
Differential Revision: https://phabricator.services.mozilla.com/D38246
--HG--
extra : moz-landing-system : lando
This patch copies over the same fix that was used for the profile cleanup page
to the installing page, since in some locales it can run into the same problem
of the header string being so long that it causes the next control to get cut
off by the bottom of the window.
Differential Revision: https://phabricator.services.mozilla.com/D36523
--HG--
extra : moz-landing-system : lando
We can use MUI_BGCOLOR to change the background color, but there's no way to
globally override the text color, so we additionally need to set that on every
affected control in the Show functions (we have to wait until Show because
that's the earliest point that the controls have been created and we can get
handles to them).
This patch fixes both the full installer and the uninstaller.
Differential Revision: https://phabricator.services.mozilla.com/D33189
--HG--
extra : moz-landing-system : lando
Our uninstaller currently calls the NSIS RMDir instruction on the `defaults`
directory with the /REBOOTOK flag set, which means that NSIS will register
the directory for deletion during the next reboot if it can't be removed
immediately for any reason. The problem here is that "any reason" includes
"the directory wasn't empty", and setting the reboot flag is not at all
the right thing to do in that situation. It won't help resolve the problem,
and those directories are expected to be empty at that point in the uninstall,
because we've already removed all the files that we know we put there, so
anything left is something we don't know about and shouldn't try to delete.
So the right thing to do here is just to remove the /REBOOTOK and allow the
RMDir to fail, so that any user files are never touched and we don't show
an unnecessary reboot prompt at the end of the wizard.
I also removed the FileExists checks, because the RMDir instruction does that.
Differential Revision: https://phabricator.services.mozilla.com/D34938
--HG--
extra : moz-landing-system : lando
I named the INI file parameter "FallbackPage" so that people building these
configurations can quickly understand what this URL is for and don't have to
figure out what "manual download" means.
Differential Revision: https://phabricator.services.mozilla.com/D34359
--HG--
extra : moz-landing-system : lando
In the preSummary function TmpVal was being checked before it could be set
causing the test to always fail.
Differential Revision: https://phabricator.services.mozilla.com/D18601
--HG--
extra : moz-landing-system : lando
Molly Howell
Gabriele Svelto
xueli
Alex Catarineu
Mihai Alexandru Michis
Nicolas Chevobbe
Dana Keeler
Daniel Varga
harry
Julian Descottes
Robert Helmer
Brindusan Cristian
Dorel Luca
Nicholas Nethercote
Mike Hommey
mcrawford
Oana Pop Rus
preyunk
Ehsan Akhgari
Sebastian Hengst
Ciure Andrei
Alexandre Poirot
Petr Sumbera
Chris Manchester
June Wilde
Zibi Braniecki
Andreea Pavel