Csoregi Natalia
ba58e936bd
Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE
2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5
Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE
2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Byron Campen [:bwc]
c33b5e6569
Bug 1490658: Support RTCIceCandidate.usernameFragment. r=mjf,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D21803
--HG--
extra : moz-landing-system : lando
2019-03-08 15:24:27 +00:00
Sylvestre Ledru
41d1d79094
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D19663
--HG--
extra : moz-landing-system : lando
2019-02-15 08:15:57 +00:00
Byron Campen [:bwc]
b9265f3fe2
Bug 1526477
- Part 0: Test role for ice-lite cases. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D19232
--HG--
extra : moz-landing-system : lando
2019-02-11 16:09:24 +00:00
Byron Campen [:bwc]
68bc15c3ce
Bug 1494311: Making the mtransport API a little more IPC friendly, and establishing a proper base-class. r=mt,mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D17272
--HG--
extra : moz-landing-system : lando
2019-01-29 14:56:19 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Nils Ohlmeier [:drno]
a04d4e00bd
Bug 1510487: allow DTLS connection w/o SRTP extension. r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D14692
--HG--
extra : moz-landing-system : lando
2019-01-17 14:16:01 +00:00
Paolo Amadini
ffa6503244
Bug 983187 - Test that downloads fail when an RST packet is received. r=mayhemer
...
This adds a way to simulate failed network connections, allowing the addition of test coverage that would otherwise not be available. This is used in the Downloads tests to ensure that failures at the network level are handled correctly.
Differential Revision: https://phabricator.services.mozilla.com/D15522
--HG--
extra : rebase_source : 2597b27de5213b0322520cefafe10a197d0d3b83
2019-01-09 11:48:23 +00:00
Sylvestre Ledru
6f45c666bc
Bug 1513205 - Also update the tests to match the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D14595
--HG--
extra : moz-landing-system : lando
2018-12-14 18:10:35 +00:00
Paul Vitale
34ca854b9d
Bug 1194010
- Block webrtc socket creation on restricted ports r=drno
...
Port restriction is delegated to the io service. Port 0 is explicitly
unrestricted.
NS_CheckPortSafety emits a warning which pollutes the gtests a bit. It is only
tested if the port is not 0.
Differential Revision: https://phabricator.services.mozilla.com/D13187
--HG--
extra : moz-landing-system : lando
2018-11-29 15:40:44 +00:00
Nils Ohlmeier [:drno]
1319a0b5d5
Bug 1507700: allow incoming STUN requests. r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D12384
--HG--
extra : moz-landing-system : lando
2018-11-28 20:13:17 +00:00
Paul Vitale
09f4c06235
Bug 1203503 - part 2. replace proxy tunnel with new ipc-based tunnel r+bwc, r+mayhemer
...
This replaces the tunnel using a new nr_socket implementation. Proxy detection
code is still done in the peer connction. However, the result is only used to
detect a proxy. The result is unused. Address resolution is done by necko code
in the parent process. The new socket wraps a WebrtcProxyChannel which uses
necko to handle proxy negotiation. This has a happy side effect of enabling all
authentication modes that necko already supports for http proxies.
This adds a protocol for Necko to manage, WebrtcProxyChannel. This new protocol
serves as a pipe for a CONNECT tunnel. It is only used in WebRtc and not built
in no WebRtc builds.
--HG--
extra : rebase_source : a951841f95eaaa0562886cf76b405b01f1adf70e
extra : intermediate-source : 5c3da21957fc80b07188bc8a405437b858027a22
extra : source : 594a32883463ab051677ba06e22fa6d062b4b4a9
2018-06-05 12:10:16 -05:00
Byron Campen [:bwc]
41541e64f6
Bug 1494301: Single API for mtransport. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D7212
--HG--
extra : moz-landing-system : lando
2018-10-26 00:39:07 +00:00
Nils Ohlmeier [:drno]
dedc2f2c81
Bug 1498068: fixed SRTP key length assertion for GCM 128 bit. r=mt
...
Differential Revision: https://phabricator.services.mozilla.com/D8324
--HG--
extra : moz-landing-system : lando
2018-10-16 03:30:57 +00:00
Byron Campen [:bwc]
93985b16c9
Bug 1486012: Rework ICE restart. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D5897
--HG--
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalAndRemoteRollbackNoSubsequentRestart.html
rename : dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollback.html => dom/media/tests/mochitest/test_peerConnection_restartIceLocalRollbackNoSubsequentRestart.html
extra : moz-landing-system : lando
2018-09-20 16:07:51 +00:00
Nils Ohlmeier [:drno]
3dab079c7c
Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
...
add GCM ciphers to SrtpFlow
Differential Revision: https://phabricator.services.mozilla.com/D5731
--HG--
extra : moz-landing-system : lando
2018-09-14 03:12:05 +00:00
Cosmin Sabou
984ac63e0f
Backed out changeset 1a7771d373ff (bug 1479665) for causing build bustages. CLOSED TREE
2018-09-13 23:52:48 +03:00
Nils Ohlmeier [:drno]
77d354dda1
Bug 1479665: add GCM ciphers to SrtpFlow. r=bwc
...
add GCM ciphers to SrtpFlow
Differential Revision: https://phabricator.services.mozilla.com/D5731
--HG--
extra : moz-landing-system : lando
2018-09-13 17:38:50 +00:00
Nils Ohlmeier [:drno]
e88a043618
Bug 1480869: define SRTP ciphers suites inside mtransport r=mt
...
define SRTP cipher suites inside mtransport
Differential Revision: https://phabricator.services.mozilla.com/D5490
--HG--
extra : moz-landing-system : lando
2018-09-11 03:58:34 +00:00
Martin Thomson
1d41c9edcb
Bug 1485883 - Handle use_srtp extension in gecko, r=drno
...
Summary:
This implements the SRTP extension in TransportLayerDtls. My hope is
that we can expunge the SRTP code from NSS in a few releases.
Reviewers: drno
Subscribers: ekr
Tags: #secure-revision
Bug #: 1485883
Differential Revision: https://phabricator.services.mozilla.com/D4188
MozReview-Commit-ID: Cwjrn9wsCQr
2018-09-07 11:50:21 +10:00
Byron Campen [:bwc]
2a2903b7fe
Bug 1483338: Stop using level as the identifier for media transports. r=mjf
...
Differential Revision: https://phabricator.services.mozilla.com/D3448
--HG--
extra : moz-landing-system : lando
2018-08-28 19:45:58 +00:00
Byron Campen [:bwc]
777bf8b996
Bug 1455647 - Part 4: Make a place to live for context about media packets, to fix packet dump hooks. r+drno r=drno
...
MozReview-Commit-ID: 1HMF93mLa7r
--HG--
rename : media/mtransport/transportlayersrtp.cpp => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.cpp
rename : media/mtransport/transportlayersrtp.h => media/webrtc/signaling/src/mediapipeline/TransportLayerPacketDumper.h
extra : rebase_source : 062814836325b69da17e8f592774f006e29905ad
2018-05-09 17:13:35 -05:00
Byron Campen [:bwc]
148a322296
Bug 1455647 - Part 3: Move SRTP into a TransportLayer. r=drno
...
MozReview-Commit-ID: LWZFPVDYZKb
--HG--
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp => media/mtransport/SrtpFlow.cpp
rename : media/webrtc/signaling/src/mediapipeline/SrtpFlow.h => media/mtransport/SrtpFlow.h
extra : rebase_source : 16e1e38c0c6f9153375735b7cb93a8286364df5f
2018-04-23 13:14:30 -05:00
Byron Campen [:bwc]
ab2913f71d
Bug 1455647 - Part 2: Allow TransportLayers to be arranged in trees. r=drno
...
MozReview-Commit-ID: BQgNbCsmkke
--HG--
extra : rebase_source : f21dbdd6f5477786f200a3336240d724aa8cc9b8
2018-04-27 16:57:28 -05:00
Byron Campen [:bwc]
cb8df81f4c
Bug 1455647 - Part 1: Simplify TransportFlow. r+drno r=drno
...
MozReview-Commit-ID: 1jJuln4WAw9
--HG--
extra : rebase_source : e5d9cba95e7e79815e9842edac2fc5eec54aac06
2018-04-27 12:14:40 -05:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Jan Keromnes
88a09b356c
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r=jya
...
Summary:
These automated fixes were generated like so:
./mach configure --enable-clang-plugin
./mach build-backend --backend=CompileDB
run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *
Reviewers: jya
Reviewed By: jya
Subscribers: jya
Bug #: 1464162
Differential Revision: https://phabricator.services.mozilla.com/D1381
--HG--
extra : amend_source : 648dc48989c5af122a33f8d50c98c0f1efcf3874
2018-05-31 14:52:59 +03:00
Byron Campen [:bwc]
d2641f7ceb
Bug 1461904: Make sure to call disconnect_all on STS. r=drno
...
MozReview-Commit-ID: 2WZxajc4FZz
--HG--
extra : rebase_source : 042476cea953c8abeaba9b208dfbba0ab84c8b2e
2018-05-16 15:53:15 -05:00
Sebastian Hengst
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Michael Froman
a9c9593126
Bug 1436759 - Release NrIceMediaStreams on sts thread in transport_unittests.cpp. r=bwc
...
MozReview-Commit-ID: BLasqfQJxw
--HG--
extra : rebase_source : bca09672917ce5fc4a5450864c9f461952847b3f
2018-02-14 14:24:50 -06:00
David Keeler
0375f07548
bug 1432923 - fix a leak in some TransportTests r=drno
...
Before this patch, TransportTest::Reset would assign to p1_ and p2_ without
releasing their resources first. Since they're not RAII types, they would just
leak. This fixes the leak by a) explicitly initializing them to nullptr in the
constructor and b) deleting them if they previously had a non-null value.
MozReview-Commit-ID: 20U6sqRWg06
--HG--
extra : rebase_source : e304c7636a9b31df53d3ff0e8d7e0042f7e82494
2018-01-25 16:56:56 -08:00
Chris Peterson
37efe4d0e6
Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
...
MozReview-Commit-ID: DCPTnyBooIe
--HG--
extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13
extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec
extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
2017-11-05 19:37:28 -08:00
Sylvestre Ledru
9bfe27d903
Bug 1394734 - Replace CONFIG['GNU_C*'] by CONFIG['CC_TYPE'] r=glandium
...
MozReview-Commit-ID: 7duJk2gSd4m
--HG--
extra : rebase_source : 7312fe276e561e8c034a5f6749774ae812727f9c
2017-12-07 22:09:15 +01:00
Byron Campen [:bwc]
9fed82e6f6
Bug 1290948 - Part 6: Remove some unused code. r+drno r=drno
...
MozReview-Commit-ID: G1uxg77wO78
--HG--
extra : rebase_source : bb8f7238bebb48251967cc453257ea6665095535
2017-08-23 16:15:11 -05:00
Andreea Pavel
449023b47c
Backed out 8 changesets (bug 1290948) for failing mochitest dom/tests/mochitest/general/test_interfaces.html r=backout on a CLOSED TREE
...
Backed out changeset 97a271bf671e (bug 1290948)
Backed out changeset 8ff38e646037 (bug 1290948)
Backed out changeset 314675023cd5 (bug 1290948)
Backed out changeset 1a5f090502b0 (bug 1290948)
Backed out changeset ffb6e6da955f (bug 1290948)
Backed out changeset 56c169018ceb (bug 1290948)
Backed out changeset 49878c508ce6 (bug 1290948)
Backed out changeset bbe53fb92e21 (bug 1290948)
2017-11-14 21:02:11 +02:00
Byron Campen [:bwc]
6771ce65da
Bug 1290948 - Part 6: Remove some unused code. r+drno r=drno
...
MozReview-Commit-ID: G1uxg77wO78
--HG--
extra : rebase_source : 565120ee7722ac357b682aa2689517f2898e5c7a
2017-08-23 16:15:11 -05:00
Kris Maglione
9184710ae5
Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn
...
MozReview-Commit-ID: 3ydSj5HfYzZ
--HG--
extra : rebase_source : 6d38da71d3c82b900b46e69c12ceb81202dd965d
2017-10-15 23:14:33 -07:00
Sylvestre Ledru
d938e24c4c
Bug 1387002 - Replace .size() by .empty() when applicable in webrtc & mtransport r=jesup
...
MozReview-Commit-ID: 4DyftBRDEcU
--HG--
extra : rebase_source : 92b00b313060c0631e087216c6a30b421b58199d
2017-08-04 09:36:19 +02:00
Jan Keromnes
5257fdad8c
Bug 1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc
2017-06-28 15:38:00 -04:00
Dan Minor
a9df96e992
Bug 1355947 - Use TestNrSocket to build a fake ICE implementation for testing; r=drno
...
MozReview-Commit-ID: GhSX9t8DmTO
--HG--
extra : rebase_source : 8fea1934f88b378606b4af96d96c27560906fd88
extra : histedit_source : 4d6fc904c79c74ba8c24e816d70368ee3a850769
2017-04-18 06:54:34 -04:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Chris Peterson
7dd51821f3
Bug 1373525 - media/mtransport: Remove unused member functions and unused member variable trickled_. r=drno
...
media/mtransport/test/ice_unittest.cpp:353:12 [-Wunused-member-function] unused member function 'Stream'
media/mtransport/test/ice_unittest.cpp:1394:7 [-Wunused-member-function] unused member function 'trickled'
media/mtransport/test/ice_unittest.cpp:1867:8 [-Wunused-member-function] unused member function 'SetExpectedTypes'
media/mtransport/test/transport_unittests.cpp:917:8 [-Wunused-member-function] unused member function 'InitIce'
MozReview-Commit-ID: 70PNtdc92mg
--HG--
extra : source : 5dc220c3efd5bd2f8f844eb85887a4bcfabb3990
extra : intermediate-source : 0751fb1b9b19a8451c5aba7e021bcb386962ce5d
2017-06-11 00:09:42 -07:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00