criss
c6b2c5db61
Backed out 9 changesets (bug 1772006) causing build bustages on nsTString.cpp. CLOSED TREE
...
Backed out changeset f17c7565707b (bug 1772006)
Backed out changeset c725fe1f5882 (bug 1772006)
Backed out changeset d19663161261 (bug 1772006)
Backed out changeset b6611ab002d9 (bug 1772006)
Backed out changeset 790f42b64af9 (bug 1772006)
Backed out changeset 79a734b4e4d9 (bug 1772006)
Backed out changeset 42730aae16ea (bug 1772006)
Backed out changeset b2542aef3054 (bug 1772006)
Backed out changeset 962bfea4a309 (bug 1772006)
2022-06-11 01:13:42 +03:00
Nika Layzell
b3c13bf114
Bug 1772006 - Part 6: Simplify and move the string searching APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,eeejay,dragana,barret
...
The biggest set of APIs from ns[T]StringObsolete which are still heavily used
are the string searching APIs. It appears the intention was for these to be
replaced by the `FindInReadable` APIs, however that doesn't appear to have
happened.
In addition, the APIs have some quirks around their handling of mixed character
widths. These APIs generally supported both narrow strings and the native
string type, probably because char16_t string literals weren't available until
c++11. Finally they also used easy-to-confuse unlabeled boolean and integer
optional arguments to control behaviour.
These patches do the following major changes to the searching APIs:
1. The ASCII case-insensitive search method was split out as
LowerCaseFindASCII, rather than using a boolean. This should be less
error-prone and more explicit, and allows the method to continue to use
narrow string literals for all string types (as only ASCII is supported).
2. The other [R]Find methods were restricted to only support arguments with
matching character types. I considered adding a FindASCII method which would
use narrow string literals for both wide and narrow strings but it would've
been the same amount of work as changing all of the literals to unicode
literals.
This ends up being the bulk of the changes in the patch.
3. All find methods were re-implemented using std::basic_string_view's find
algorithm or stl algorithms to reduce code complexity, and avoid the need to
carry around the logic from nsStringObsolete.cpp.
4. The implementations were moved to nsTStringRepr.cpp.
5. An overload of Find was added to try to catch callers which previously
called `Find(..., false)` or `Find(..., true)` to set case-sensitivity, due
to booleans normally implicitly coercing to `index_type`. This should
probably be removed at some point, but may be useful during the transition.
Differential Revision: https://phabricator.services.mozilla.com/D148300
2022-06-10 21:12:08 +00:00
Kagami Sascha Rosylight
f08333eddf
Bug 1768189 - Part 45: Apply modernize-concat-nested-namespaces to dom/xhr/XMLHttpRequest.cpp ... r=andi
...
Depends on D145780
Differential Revision: https://phabricator.services.mozilla.com/D145781
2022-05-09 20:41:21 +00:00
Jan Rio Krause
057785b6d5
Bug 1519200 - Remove `NS_ERROR_FILE_TARGET_DOES_NOT_EXIST` in favor of `NS_ERROR_FILE_NOT_FOUND`. r=xpcom-reviewers,nika,dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D77575
2022-04-05 15:17:03 +00:00
Randell Jesup
703bd76404
Bug 1744043: Clean up nsJAR r=nika,valentin,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D132794
2022-03-24 13:54:56 +00:00
Gijs Kruitbosch
0dbedb88cc
Bug 1760328, r=nika,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D141544
2022-03-21 14:10:19 +00:00
Marian-Vasile Laza
7852c208be
Backed out 2 changesets (bug 1754063
, bug 1744043) for causing xpcshell failures on test_ext_clear_cached_resources.js. CLOSED TREE
...
Backed out changeset faf305b1b14d (bug 1754063
)
Backed out changeset 24ee1c0756ae (bug 1744043)
2022-03-08 09:08:23 -08:00
Randell Jesup
da56412fd6
Bug 1744043: Clean up nsJAR r=nika,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D132794
2022-03-08 13:57:56 +00:00
Sylvestre Ledru
98949ee751
Bug 1754767 - Remove duplicate includes r=media-playback-reviewers,padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D138441
2022-02-11 10:01:15 +00:00
Jens Stutte
fe88e4a9c2
Bug 1751535: Add CanSend to XHRMainThread and check it before touching our state. r=dom-worker-reviewers,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D136871
2022-01-26 14:40:03 +00:00
Matthew Gaudet
bc10b96605
Bug 1748888
- Add ErrorResult parameter to PromiseNativeHandler callbacks r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D136423
2022-01-20 19:11:39 +00:00
Olli Pettay
f3d8d04ae4
Bug 1723281, mark XHR load being an error load when send() fails, r=kershaw
...
Noticed similar issue with the blob uri, so fixed that in this patch too.
Tests are in the next patch.
InitiateFetch() call a bit later handles the marking for some other error cases.
Differential Revision: https://phabricator.services.mozilla.com/D130201
2021-11-08 18:36:45 +00:00
ssummar
0992acc367
Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-08 08:14:00 +00:00
Cristian Tuns
71486b8924
Backed out changeset 7e8e3747c3f8 (bug 1603127) for causing toolchains build bustages (Bug 1739589). CLOSED TREE
2021-11-05 07:23:45 -04:00
ssummar
508562cc85
Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-05 05:33:58 +00:00
ssummar
51c0ff21e5
Bug 1626517 - Replaced mozilla::Unused with mozilla::Ignore in mozilla::Decoder/mozilla::Encoder calls. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D129022
2021-10-25 12:31:41 +00:00
Jens Stutte
2c7cda331d
Bug 1731564: Use motivated SpinEventLoopUntil inside dom/*. r=smaug
...
Depends on D126714
Differential Revision: https://phabricator.services.mozilla.com/D126957
2021-10-07 08:06:11 +00:00
Marian-Vasile Laza
18fb16c542
Backed out 18 changesets (bug 1731564) for causing build bustages on SpinEventLoopUntil. CLOSED TREE
...
Backed out changeset 0464dbdc8584 (bug 1731564)
Backed out changeset 0d996df13545 (bug 1731564)
Backed out changeset 5630a0e7a109 (bug 1731564)
Backed out changeset 37b41d187cdb (bug 1731564)
Backed out changeset d37700fa60b6 (bug 1731564)
Backed out changeset b0ce7db44b99 (bug 1731564)
Backed out changeset aa5ec3aa1535 (bug 1731564)
Backed out changeset 73b648f1fa70 (bug 1731564)
Backed out changeset bb8fb0f9833e (bug 1731564)
Backed out changeset 0d8905144f5d (bug 1731564)
Backed out changeset 2cfb094a1ec3 (bug 1731564)
Backed out changeset 78d3b0257a6a (bug 1731564)
Backed out changeset e9d32926e93c (bug 1731564)
Backed out changeset 874cab520ce5 (bug 1731564)
Backed out changeset d8071cc32bd9 (bug 1731564)
Backed out changeset 283c5393cbbc (bug 1731564)
Backed out changeset 317bc38e3de5 (bug 1731564)
Backed out changeset 53e3f4862439 (bug 1731564)
2021-10-07 00:09:19 +03:00
Jens Stutte
f764763e98
Bug 1731564: Use motivated SpinEventLoopUntil inside dom/*. r=smaug
...
Depends on D126714
Differential Revision: https://phabricator.services.mozilla.com/D126957
2021-10-06 19:45:12 +00:00
Cosmin Sabou
e2e44b6376
Backed out changeset c6819fdea3a5 (bug 1695216) for causing XMLHttpRequestWorker related crashes. CLOSED TREE
2021-09-23 20:25:21 +03:00
Nihanth Subramanya
b3c27b86d4
Bug 1695216 - XMLHttpRequest should reset response upon network errors. r=annevk,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D124989
2021-09-23 16:28:23 +00:00
Marian-Vasile Laza
6cd781871d
Backed out changeset 914436169022 (bug 1695216) for causing build bustages.
2021-09-23 16:04:34 +03:00
Nihanth Subramanya
9f3565b9fb
Bug 1695216 - XMLHttpRequest should reset response upon receiving a bad chunk. r=annevk,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D124989
2021-09-23 12:02:09 +00:00
Edgar Chen
e016ae9d81
Bug 1730117 - Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D125187
2021-09-22 14:50:55 +00:00
Sandor Molnar
8bb72e737f
Backed out 2 changesets (bug 1730117) for causing wpt failures in no_window_open_when_term_nesting_level_nonzero. CLOSED TREE
...
Backed out changeset bafc4ddc87f6 (bug 1730117)
Backed out changeset 27a1d92e550c (bug 1730117)
2021-09-21 18:00:06 +03:00
Edgar Chen
e0ba65d8f8
Bug 1730117 - Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D125187
2021-09-21 11:39:45 +00:00
Butkovits Atila
a3bbc4c745
Backed out 2 changesets (bug 1730117) for causing failures at test_suppressed_events_nested_iframe.html. CLOSED TREE
...
Backed out changeset 649984f4a939 (bug 1730117)
Backed out changeset 37a35b6b54b4 (bug 1730117)
2021-09-21 00:38:17 +03:00
Edgar Chen
d10e28e072
Bug 1730117 - Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D125187
2021-09-20 19:23:52 +00:00
criss
26582cd2d7
Backed out changeset 70e4ed1cfc05 (bug 1725876) for causing failures on navigating-across-documents/010.html. CLOSED TREE
2021-09-20 14:45:10 +03:00
Kershaw Chang
413d4417d9
Bug 1725876 - Make sure mFlagSyncLooping be cleared in XMLHttpRequestMainThread::OnStopRequest, r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D125822
2021-09-20 10:38:06 +00:00
Kershaw Chang
690f2ebcaf
Bug 1714224 - Cancel sync timeout timer after mFlagSyncLooping is set to false, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D118350
2021-06-23 21:00:06 +00:00
Landry Breuil
1a9dbc0daa
Bug 1714022 - add missing ScopeExit header r=edgar
...
Fixes build failure on Tier3:
src/m-c/dom/xhr/XMLHttpRequestMainThread.cpp:3050:22: error: use of undeclared identifier 'MakeScopeExit'
auto scopeExit = MakeScopeExit([&] {
regressed by bug 1712930
Differential Revision: https://phabricator.services.mozilla.com/D116560
2021-06-02 07:46:55 +00:00
Edgar Chen
c80e2f09d3
Bug 1712930 - Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D116081
2021-06-01 13:10:48 +00:00
Edgar Chen
8effa3808d
Bug 1712930 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116080
2021-06-01 13:10:48 +00:00
Edgar Chen
b4a690870e
Bug 1712930 - Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116079
2021-06-01 13:10:47 +00:00
Edgar Chen
2f19ad2de5
Bug 1712930 - Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116078
2021-06-01 13:10:47 +00:00
Edgar Chen
79a3f4a3a1
Bug 1712930 - Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116077
2021-06-01 13:10:46 +00:00
Edgar Chen
bededd95ac
Bug 1712930 - Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116076
2021-06-01 13:10:46 +00:00
Sandor Molnar
7b1d598d24
Backed out 7 changesets (bug 1712930) for causing damp failures. CLOSED TREE
...
Backed out changeset 4a03c8b2aa1a (bug 1712930)
Backed out changeset 311ccf17a01d (bug 1712930)
Backed out changeset c42f2270b5f8 (bug 1712930)
Backed out changeset b117c37b1e7e (bug 1712930)
Backed out changeset dd0ab5fc70a0 (bug 1712930)
Backed out changeset ab9bb2ee0c98 (bug 1712930)
Backed out changeset ec01575cb276 (bug 1712930)
2021-05-31 20:29:32 +03:00
Edgar Chen
529a31571f
Bug 1712930 - Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116081
2021-05-31 12:57:18 +00:00
Edgar Chen
bd505df613
Bug 1712930 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116080
2021-05-31 12:57:17 +00:00
Edgar Chen
71290465e8
Bug 1712930 - Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116079
2021-05-31 12:57:17 +00:00
Edgar Chen
8fdabf5210
Bug 1712930 - Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116078
2021-05-31 12:57:16 +00:00
Edgar Chen
fa6e0c0091
Bug 1712930 - Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116077
2021-05-31 12:57:16 +00:00
Edgar Chen
a55011f761
Bug 1712930 - Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116076
2021-05-31 12:57:16 +00:00
Noemi Erli
e1fde28a85
Backed out 7 changesets (bug 1712930) for causing Android mochitest failures in test_onerror_message.html
...
Backed out changeset 4b93e808e72f (bug 1712930)
Backed out changeset f1cb609c78a0 (bug 1712930)
Backed out changeset 36e48f6e43ae (bug 1712930)
Backed out changeset b2da173c9337 (bug 1712930)
Backed out changeset d2eb6df1ec5f (bug 1712930)
Backed out changeset 78e1d6847f0a (bug 1712930)
Backed out changeset 6f842a2bf026 (bug 1712930)
2021-05-29 01:30:47 +03:00
Edgar Chen
7b47184b2c
Bug 1712930 - Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116081
2021-05-28 21:12:13 +00:00
Edgar Chen
18ac9679bb
Bug 1712930 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116080
2021-05-28 21:12:13 +00:00
Edgar Chen
5b4acdb4c5
Bug 1712930 - Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116079
2021-05-28 21:12:12 +00:00
Edgar Chen
a60d37c138
Bug 1712930 - Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D116078
2021-05-28 21:12:12 +00:00