Use application context for delayed callbacks to prevent leaking the
BrowserApp instance. Also, use application context for accessing
Distribution, to prevent leaking old BrowserApp instances, and to avoid
using a destroyed Context. Finally, attach AudioFocusAgent to the
application context instead of the BrowserApp context to avoid leaking
BrowserApp.
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
Additionally, added WeakReferences to the SEM in its callbacks so we can
GC ASAP if the Activity (and thus the SEM) gets GC'd. This is important
since we hold a reference to Context which can be a rather large object.
Furthermore, I added some related thread annotations where I felt they
were useful.
MozReview-Commit-ID: KaWlw14uOoN
--HG--
extra : rebase_source : 71e8363985179834aaa21b9885a66bd46ae1a361
We want to reuse this code for the main Activity.
MozReview-Commit-ID: BZxIrgmJI2r
--HG--
rename : mobile/android/search/java/org/mozilla/search/providers/SearchEngine.java => mobile/android/base/java/org/mozilla/gecko/search/SearchEngine.java
rename : mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java => mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java
extra : rebase_source : 0a4cd7c64ecfbb5270fa2811924b7d22a87741cb
NineOldAndroids is a backport of the animation API that was introduced with Honeycomb.
Since we stopped supporting Gingerbread we do not need this library anymore and can
just use the system API.
MozReview-Commit-ID: Fv6ALlIktt5
--HG--
extra : rebase_source : 1b0b40303edb985361a23536921de38d5295604a
The new API for onReceivedError() has just been introduced in API 23 / Android 6.0.
However our minSdkVersion is 9 currently.
--HG--
extra : commitid : 7fnyh1z1PeS
extra : rebase_source : e3d2682b357a66027c9a33546c929b6bf7106255
extra : amend_source : c4545b7b0cb8fbf3866a53d1753849f0cdf5c10a
This avoids the "HandlerLeak" Android Lint warning.
--HG--
extra : commitid : 3sLO4YQ6Gjk
extra : rebase_source : 84cd05b1c4848895271e7f577ffa94b72de0281a
The function is required for a greasemonkey script and the code is expected to
be secure.
--HG--
extra : commitid : 4pQfBCCYBoK
extra : rebase_source : c952a45c6bad183e036b8557cdd7747993ae805d
extra : histedit_source : 9acabb865440c606cedd02d8cc7a02fe5c82dbb4
Rather than hardcoding the following classes in AppConstants.java.in and AndroidManifest.xml, they are set in
confvars.sh:
org.mozilla.gecko.GeckoApplication (Specified using MOZ_ANDROID_APPLICATION_CLASS)
org.mozilla.gecko.BrowserApp (Specified using MOZ_ANDROID_BROWSER_INTENT_CLASS)
org.mozilla.search.SearchActivity (Specified using MOZ_ANDROID_SEARCH_INTENT_CLASS)
In addition to keying off of the IME_ACTION_SEARCH, we also key of of IME_ACTION_UNSPECIFIED which is what is sent by the android emulator hardware keyboard.
--HG--
extra : rebase_source : 2a522a3a2dd8e9c5e8ab53900ff2312084d7bacf
This is the approach we already take everywhere else we make a jar🫙 URI.
I've unified those places into GeckoJarReader, cleaned up imports, fixed a
typo, and wrote a trivial test for this case.
I made a few utility methods static to facilitate testing and future refactoring.
This is the approach we already take everywhere else we make a jar🫙 URI.
I've unified those places into GeckoJarReader, cleaned up imports, fixed a
typo, and wrote a trivial test for this case.
I made a few utility methods static to facilitate testing and future refactoring.
This patch fixes all testSearchSuggestions intermittent failures, except for those that appear to be caused by update checks on 2.3.
It also replaces all waitForTest (deprecated) calls with waitForCondition.