e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
804b8b8883
Bug 1204606 - Reformat of dom/media r=jya
...
# skip-blame
Differential Revision: https://phabricator.services.mozilla.com/D12251
--HG--
extra : moz-landing-system : lando
2018-11-19 13:25:37 +00:00
f85e9dfabc
Bug 1503132 add wait/wake-up support to OfflineAudioContext r=padenot
...
Depends on D10162
Differential Revision: https://phabricator.services.mozilla.com/D10163
--HG--
extra : moz-landing-system : lando
2018-10-30 09:48:08 +00:00
40589e9304
Bug 1503132 remove unnecessary SystemClockDriver::mWaitState r=padenot
...
mWaitState is only ever tested against WAITSTATE_WAITING_INDEFINITELY and so
the other values are equivalent. It is never WAITSTATE_WAITING_INDEFINITELY
on leaving (or entering) WaitForNextIteration and so there is no need to set
it in WakeUp().
Differential Revision: https://phabricator.services.mozilla.com/D10162
--HG--
extra : moz-landing-system : lando
2018-10-31 00:54:14 +00:00
a2cc4c6476
Bug 1503132 remove unnecessary monitor notify for AudioCallbackDriver r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D10161
--HG--
extra : moz-landing-system : lando
2018-10-30 23:51:49 +00:00
28fa83d1b5
Bug 1404977 - Part 10 - Make logging uniform, and consistently use GraphImpl() to access the graph impl. r=pehrsons
...
MozReview-Commit-ID: DZ7zhQsBtvy
--HG--
extra : rebase_source : d44599587cc11dccaecf6672fc4ffbaad1a5c14f
2018-04-17 17:11:13 +02:00
6622a3551d
Bug 1404977 - Part 9 - Propagate the changes to the GraphDrivers, simplifying them, and brokering all access through the MSG. r=pehrsons
...
For an AudioCallbackDriver, the number of input channels is immutable, and
passed at construction, so that it's less necessary to rely on global state.
MozReview-Commit-ID: F9TL1H92z3W
--HG--
extra : rebase_source : 5193488592ca97273eb2b6f43d4c7a0e4beb0a33
2018-04-30 16:01:56 +02:00
22e47fbddd
bug 1472925 keep a strong reference to MediaStreamGraph from GraphDriver r=padenot
...
--HG--
extra : rebase_source : 1db73541027a7b8f40365c6dc7977eb6be88c567
2018-07-03 17:23:09 +12:00
8b700896f3
Bug 1460346 - Verify that AudioMixer'callback is removed before the destruction of GraphDriver. r=padenot
...
MozReview-Commit-ID: Jd0PVw7xHDV
--HG--
extra : rebase_source : 2e50404b08778ceadd76691312861d134d7c1a42
2018-06-29 10:05:56 +02:00
cd6f5298c4
Bug 1460346 - Fix a case that ThreadedDriver is started when it is already working. r=padenot
...
MozReview-Commit-ID: 6R6WH3ITw03
--HG--
extra : rebase_source : 0762f709b7b82714f7c3a47ad59984e5bde49238
2018-05-25 11:58:58 +03:00
7ab72fe907
Bug 1460346 - Assert that GraphDriver methods are called from graph thread. r=padenot,pehrsons
...
MozReview-Commit-ID: Kkl7ENMXlJq
--HG--
extra : rebase_source : ccc79b8cfcb1d6d86ced5bc2a5a2931eccd7ff72
2018-05-25 11:58:45 +03:00
d3b6626bf0
Bug 1460346 - Create a method to check whether GraphDriver's thread is running. r=pehrsons
...
MozReview-Commit-ID: 8hOXvxDWOIG
--HG--
extra : rebase_source : 838637720c24e08769ea59204bb55da6678e71b4
2018-05-22 19:51:42 +03:00
2b26626333
Bug 1460346 - Move checks for NextDriver member in the setter method. r=pehrsons
...
MozReview-Commit-ID: 906AyL0tEwG
--HG--
extra : rebase_source : 4359724926d9d06919fc911336125f308dfb1d07
2018-05-22 19:31:56 +03:00
3148644625
Bug 1457427 - Change the assert in SetInputListener of GraphDriver to verify that the driver is not started. r=padenot
...
With the updated OnThread method SetInputListener method cannot continue asserting for being in audio callback. This check is not realistic since it is used on a newly created driver before being started.
MozReview-Commit-ID: 5gntuHm3fnr
--HG--
extra : rebase_source : e3bc17e9d8c83c4d61686889af41edfb3ef3902f
2018-05-07 19:36:45 +02:00
7271873512
Bug 1457427 - Improve OnThread method of AudioCallbackDriver to track the thread id of the audio thread so be more accurate. r=padenot
...
The class has been enhanced to store the thread id at the beginning of the callback and use it in order to compare with the current thread id when OnThread method is called. The old mechanism which includes the mInCallback flag has been removed.
MozReview-Commit-ID: DWSbFQfvKzX
--HG--
extra : rebase_source : e6c011da563b8f1d562ca7a394433e1e53fcffa4
2018-05-07 19:36:14 +02:00
196c05c507
Bug 1457427 - Create a new GraphDriver method which performs the switching to next driver. r=padenot
...
Restructuring of the existing code no functional change.
MozReview-Commit-ID: JWaa8LgG4MR
--HG--
extra : rebase_source : 97190b870172549a0cd2453078c0511887059b73
2018-05-07 19:35:56 +02:00
c3c3a90bcb
bug 1457058 remove unused GraphDriver::RemoveCallback() r=padenot
...
MozReview-Commit-ID: 3ZWfWEJ7bko
--HG--
extra : rebase_source : 2bd9b8fd0f87f87905606f5550c9645fbe68b465
2018-04-26 17:50:59 +12:00
0129d900f3
Bug 1436263 - Part 2: Replace `override final` virtual function specifiers with just `final`. r=froydnj
...
MozReview-Commit-ID: 70gt5SUu4Dv
--HG--
extra : rebase_source : 71912c6bde22aaed01e70615a4ee794a36e70d0e
extra : source : 1c22d4c65d70b797ee3e963ec426c90e1f89b5e3
2018-02-05 22:50:00 -08:00
a8f33facb2
Backed out changeset db713228c8e3 (bug 1425150) for wpt failures on core/platform.cpp r=abackout on a CLOSED TREE
2017-12-14 23:23:20 +02:00
17ca0b45f8
Bug 1425150 - Register AudioCallbackDriver to the Gecko Profiler. r=jya
...
MozReview-Commit-ID: 3rJbF8Kq0zx
--HG--
extra : rebase_source : 49719ea92da9c1c556b1c3d10a06d3f2cdc3b08f
2017-12-13 17:10:14 -06:00
758db182f3
Bug 1419378 - Fail before stream init when output number of channels is zero. r=padenot
...
MozReview-Commit-ID: G2bjXhAXiqz
--HG--
extra : rebase_source : 21cf22e4afd4065835a5323ed0ab44a55035f0db
2017-11-28 12:57:02 +02:00
2f98789374
bug 1382366 disable AudioCallback -> SystemClockDriver fallback before disowning graph f=pehrsons r=padenot
...
MozReview-Commit-ID: ESr6yxjPVWf
--HG--
extra : histedit_source : eb60aa28970548a65b31e79ba0c7efaaf27268cc
2017-11-04 19:00:46 +13:00
ef7235b44f
bug 1382366 move declaration of mWaitState to SystemClockDriver f=pehrsons r=padenot
...
MozReview-Commit-ID: IBqJRjL2Ruk
--HG--
extra : histedit_source : bf467862aa715292c446fa037958338993096441
2017-11-04 11:02:52 +13:00
9aec4911f8
bug 1408276 remove unused GraphDriver::Destroy() r=padenot
...
MozReview-Commit-ID: 1eonMAWKubq
--HG--
extra : amend_source : bc4193e7041b25407422d49e4e12c81d24c66e72
2017-10-09 22:09:00 +13:00
a7bb0b6a26
bug 1406830 store the AsyncCubeTask SharedThreadPool reference on the AudioCallbackDriver r=jesup,padenot
...
The first AsyncCubebTask dispatch from AudioCallbackDriver::Start() may either
be from MediaStreamGraphImpl::RunInStableState() on the main thread or
ThreadedDriver::RunThread() on a threaded driver thread.
These could potentially occur concurrently when there are multiple
MediaStreamGraphs.
This change removes the race around setting sThreadPool.
SharedThreadPool::Get() would have returned the same pointer, and so
that race was probably mostly benign apart from the potential to add an
extra reference and so hang on shutdown in SharedThreadPool::SpinUntilEmpty().
Storing the reference to the SharedThreadPool on the object using it is the
typical way to use SharedThreadPool. It lets the thread pool be released when
not in use, and lets SharedThreadPool deal with multi-thread access and
shutdown.
MozReview-Commit-ID: 8WutVsAMfJo
--HG--
extra : rebase_source : a3d0ce75d65889fff47389ccd80640c3f1150244
2017-09-26 17:28:17 +13:00
7299e56b0b
bug 1406830 reimplement Shutdown() as virtual separately on each driver r=padenot
...
moving Stop() to AudioCallbackDriver only.
MozReview-Commit-ID: 9atG8R4wAsY
--HG--
extra : rebase_source : 0addeae733c001f4e5c6cd2d55cbb0b069863864
2017-09-28 15:05:36 +13:00
4f358ada69
bug 1406830 remove unused GraphDriver::Resume() r=padenot
...
MozReview-Commit-ID: IPpyxOHESLW
--HG--
extra : rebase_source : 404e86e6db9c42df64d306697e13b6da1f0c793c
2017-09-28 14:55:20 +13:00
ec46b8ffb1
Bug 1403041 - Fix typo in AudioCallbackDriver member. r=kinetik
...
s/mOuputChannelCount/mOutputChannelCount/
MozReview-Commit-ID: Kv03aSKnfQa
2017-09-26 12:05:01 +02:00
3e7a54981e
Bug 1360334 - Improve error handling. r=padenot
...
MozReview-Commit-ID: 5tIXzzisg0V
--HG--
extra : source : 0dc85355af3d166038ccf6e0fd161bd614b0ead2
2017-09-08 16:41:36 +02:00
3a76476175
Backed out changeset a3eabb355005 (bug 1360334) for build bustaget at dom/media/GraphDriver.cpp:200: cannot pass non-trivial object of type 'RefPtr<mozilla::GraphDriver>' to variadic function. r=backout on a CLOSED TREE
2017-09-09 18:00:49 +02:00
0bdbb7d2aa
Bug 1360334 - Improve error handling. r=padenot
2017-09-08 16:41:36 +02:00
097de34e5b
Bug 1395593 - Don't query the maximum channel count in ::PlayAudio using cubeb. r=achronop
...
MozReview-Commit-ID: 97ri5vhzsRF
--HG--
extra : rebase_source : 56bc0f44566dfc3e271444f8dfc9f89e12a1a0a1
2017-08-31 17:14:34 +02:00
b0e140e2a2
Bug 1392930 - part 3: Make AudioCallbackDriver inherit from DeviceChangeListener; r=padenot
...
--HG--
extra : rebase_source : a6d87257004fe4954044c0ccd70ca4b4f597099a
2017-08-29 17:45:44 +08:00
c9d4805a3f
Bug 1378070 - Implement multichannel WebAudio. r=padenot
...
* * *
[mq]: rebase
MozReview-Commit-ID: KJwH3ZeJn55
--HG--
extra : rebase_source : 0e9866c8dc5ccb98a9654c1e18b0bcef1ef5afa8
2017-08-28 17:16:20 +03:00
2f8cc7804c
Bug 1388236 - Remove B2G-only AudioChannel code from MSG. r=padenot
2017-08-10 13:00:08 +12:00
e55c008768
Bug 1372247 - Make the AudioOutputObserver a member of the MediaEngineWebRTCMicrophoneSource so it's not a global singleton anymore. r=jesup
...
MozReview-Commit-ID: 3yC1PvG3sW7
--HG--
extra : rebase_source : 950c1633d127ee0b6670b112bb31637a8851a583
2017-06-12 17:14:26 +02:00
d6affd5261
Bug 1365098 - Convert NS_GetCurrentThread uses in dom/media (r=cpearce)
...
MozReview-Commit-ID: DUPt6xj49zz
2017-06-12 20:20:08 -07:00
d5608e0a47
Bug 1277037 - Make AudioCallbackDriver::StartStream fallible. r=jesup
...
Avoid crashing in the case that cubeb stream start fails and report
an error instead.
MozReview-Commit-ID: 75M392POyHo
--HG--
extra : rebase_source : 2c083cf129f12ad1e18d9065152cfee13987b071
2017-01-11 11:51:23 -08:00
b4146d6b6d
Bug 1289678 - Fix warning as errors on a CLOSED TREE.
2016-07-28 13:17:46 +02:00
0cb3352625
Bug 1289678 - Don't count audio stream creation failures when retrying on Telemetry. r=kinetik
...
When failing to create an audio stream, we fallback to a SystemClockDriver
marked as being a "fallback driver". When failing again to open an audio stream
after re-trying, we can check whether we came from a fallback driver, and not
report the failure again to telemetry.
MozReview-Commit-ID: FAdQ0pCtC3m
2016-07-27 15:18:17 +02:00
b15368cfcb
Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky
2016-06-07 21:10:18 +01:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
8fda7f21b4
Bug 1266438 - Remove workaround on OSX when switching device, not necessary with duplex mode. r=jesup
...
MozReview-Commit-ID: 7IontuEuiQj
2016-04-22 16:24:19 +02:00
b3adcea90b
Bug 1266438 - Reset the AEC and other processing when audio devices change. r=jesup
...
MozReview-Commit-ID: Jrr9E9ZSukv
2016-04-22 16:24:17 +02:00
ca7a35732f
Bug 1264195: Re-add SetMicrophoneActive() calls into the GraphDriver r=padenot
...
With bustage fix for warnings as errors
2016-04-13 14:31:35 -04:00
85f3c6a92d
Bug 1245216: Fix getUserMedia input in full_duplex mode coming from the wrong place r=padenot
...
Also cleanup of an leftover overrridden interface, and re-add a line lost in merges
MozReview-Commit-ID: 7sjtbbtq1RG
2016-02-17 13:19:02 -05:00
d7371d07d0
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
d381b4bca6
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
373593275e
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
577bce0291
Bug 1221587: stall MSG final shutdown until AudioCallbackDriver shutdown has finished r=pehrsons
...
--HG--
extra : commitid : JidvC1L3ZGw
2016-01-22 02:39:42 -05:00
Ehsan Akhgari
Sylvestre Ledru
Karl Tomlinson
Paul Adenot
Alex Chronopoulos
Chris Peterson
Narcis Beleuzu
Andreas Pehrson
Sebastian Hengst
Chun-Min Chang
Matthew Gregan
Bill McCloskey
Ralph Giles
Jonathan Watt
Kyle Huey
Randell Jesup
Birunthan Mohanathas
Phil Ringnalda