50895a5db7
Bug 1571339 - Don't use nsTextFragment::AppendTo to get string in TextNodeContainsDOMWordSeparator. r=masayuki
...
Actually, spellchecker always allocates the heap to get text from text node. But it is unnecessary to allocate another heap here since `WordSplitState` walks text only and it is stack class.
If text is in '<textarea>', text node may be too large, so we shouldn't allocate memory to walk character in `WordSplitState` if possible. Because `TextNodeContainsDOMWordSeparator` will be called per input.
And `mWordUtil` is unused, so we should remove it.
Differential Revision: https://phabricator.services.mozilla.com/D42257
--HG--
extra : moz-landing-system : lando
2019-09-09 03:42:45 +00:00
d922064696
Bug 1547519 - Rename NS_STRINGIFY to MOZ_STRINGIFY, move to mfbt, and unify stragglers r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D39961
--HG--
extra : moz-landing-system : lando
2019-09-04 02:40:32 +00:00
9f71be1805
Bug 1572191 - Prevent nsPermissionManager from persisting certain permissions to disk under GeckoView. r=snorp,Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D43759
--HG--
extra : moz-landing-system : lando
2019-08-30 21:41:47 +00:00
c771ae8334
Bug 1572240 - Part 6: Remove nsIPermissionManager.testPermissionOriginNoSuffix; r=baku
...
This is now dead code which will be kept alive by the vtable,
and introduces needless overhead inside the permission manager.
Differential Revision: https://phabricator.services.mozilla.com/D42207
--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:47 +00:00
9a123fb597
Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE
2019-08-19 13:00:44 +03:00
240771fa29
Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D40614
--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
f2675da6d6
Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D41028
--HG--
extra : moz-landing-system : lando
2019-08-15 14:32:46 +00:00
b454daea7a
Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail CLOSED TREE
...
Backed out changeset 87305e83174e (bug 1531303)
Backed out changeset 0c75c3bac00b (bug 1531303)
Backed out changeset 865c2a5d40da (bug 1531303)
2019-08-14 13:07:55 +03:00
160cf2c1df
Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D41028
--HG--
extra : moz-landing-system : lando
2019-08-14 08:36:41 +00:00
0e913c22c4
Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D40677
--HG--
extra : moz-landing-system : lando
2019-08-07 19:49:40 +00:00
c3430326e6
Backed out changeset ca88862d6b63 (bug 1558915) for causing build bustages on StartupCacheUtils. CLOSED TREE
2019-08-07 13:20:32 +03:00
8bc1f5ada8
Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D40677
--HG--
extra : moz-landing-system : lando
2019-08-07 09:36:56 +00:00
eedbf1137f
Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE
2019-08-07 01:04:43 +03:00
03c7998ef2
Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D40677
--HG--
extra : moz-landing-system : lando
2019-08-06 20:19:41 +00:00
79bf4210ee
Bug 1565919 - Don't separate words by contextual-based character. r=Ehsan
...
Original regression was by bug 1362858, and bug 1418629 wasn't enough to fix.
By bug 1362858, we use `CHAR_CLASS_SEPARATOR` in additional to DOM word separator. But some characters such as single quote, `@` and etc are `CHAR_CLASS_SEPARATOR`, so we may check spell by incomplete word.
We shouldn't separate word by characters that is email part, URL part or conditional punctuation.
And I also update test cases for this situation. `<textarea>` is better for spell checking since it can has multiple anonymous text nodes.
Differential Revision: https://phabricator.services.mozilla.com/D39829
--HG--
extra : moz-landing-system : lando
2019-08-03 13:44:56 +00:00
864c351bc8
Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki
2019-08-02 10:49:17 +02:00
0962c2b731
Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
...
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.
There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.
Differential Revision: https://phabricator.services.mozilla.com/D38247
--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
21df1f7413
Merge inbound to mozilla-central. a=merge
2019-07-17 06:48:50 +03:00
8135a5859f
Bug 1566046: move `nsContentUtils::ContentIsShadowIncludingDescendantOf` to `nsINode::IsShadowIncludingInclusiveDescendantOf`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D38079
2019-07-16 09:25:02 +02:00
af897e281a
Merge inbound to mozilla-central. a=merge
2019-07-16 00:42:51 +03:00
2f40f072ab
Bug 1565584: move `nsIContentUtils::ContentIsDescendantOf` to `nsINode::IsInclusiveDescendantOf`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D37880
2019-07-15 10:02:21 +02:00
c1d06a6c0c
Bug 1289211 - Rename InfallibleTArray to nsTArray in extensions/spellcheck/ r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D36952
--HG--
extra : moz-landing-system : lando
2019-07-10 03:28:47 +00:00
5062731c15
Bug 1565688. Remove unused IOService arg from NS_NewURI. r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D37968
--HG--
extra : moz-landing-system : lando
2019-07-15 13:39:51 +00:00
e77bfc655d
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D38057
--HG--
extra : moz-landing-system : lando
2019-07-16 07:33:44 +00:00
d4d246dca3
Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D15652
--HG--
extra : moz-landing-system : lando
2019-07-03 16:18:23 +00:00
31441f82ea
Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D35504
--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
dbce01f2ff
Bug 467035 - Add new internal DTD content types r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D35232
--HG--
extra : moz-landing-system : lando
2019-07-03 17:28:25 +00:00
fc2eb5393c
Bug 1562642 - Part 2 - Add missing MPL2 headers r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D37146
--HG--
extra : moz-landing-system : lando
2019-07-08 09:27:47 +00:00
5af464dcc4
Bug 1561435 - Format extensions/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35902
--HG--
extra : source : 31cb194f2a6651332aa71a41c0f06a29daf8a186
2019-07-05 10:46:07 +02:00
6b67de025f
Bug 1562876: rename `Selection::RemoveRange` to `Selection::RemoveRangeAndUnselectFramesAndNotifyListeners`. r=smaug
...
The name of the corresponding webidl interface of course remains unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D36607
2019-07-03 13:26:14 +02:00
63b4627d28
Bug 1562876: rename `Selection::AddRange` to `Selection::AddRangeAndSelectFramesAndNotifyListeners`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D36602
2019-07-03 13:26:13 +02:00
da61ea3112
Bug 1444847 - part 3: Create `RangeUtils` to place public static methods of `nsRange` r=smaug
...
Some `nsRange` static methods are useful in `StaticRange` and some of them
are used in a lot of places but not related to `nsRange` directly. This
patch moves them into new static method only class, `mozilla::RangeUtils`.
Differential Revision: https://phabricator.services.mozilla.com/D35142
--HG--
extra : moz-landing-system : lando
2019-06-28 07:48:07 +00:00
5f9abd3366
Bug 1444847 - part 1: Create `mozilla::dom::AbstractRange` r=smaug
...
This patch is based on the patch created by Makoto Kato-san.
`Range` and `StaticRange` have common base interface, `AbstractRange`.
https://dom.spec.whatwg.org/#abstractrange
This interface has simply returns `startContainer`, `endContainer`,
`startOffset`, `endOffset` and `collapsed`.
Different from the original patch's approach, this patch moves related
members in `nsRange` to `AbstractRange` since this approach avoids
virtual call cost. Additionally, this patch makes them not throw as
declared by the spec. As far as I know, the destruction cost of
`ErrorResult` may appear in profile so that we should avoid creating
the instance if we can avoid it.
Unfortunately, the instance size of `nsRange` becomes larger with this
patch. The size is changed from 176 to 184. I.e., now, `nsRange`
requires bigger chunk.
Differential Revision: https://phabricator.services.mozilla.com/D35140
--HG--
extra : moz-landing-system : lando
2019-06-28 07:46:35 +00:00
cb97dec989
Bug 1560517 - Update LICENSE, README and license.hunspell to 1.6.1 r=RyanVM
...
No one includes `license.hunspell`, so we don't need our custimze block (`#include "config.h"`)
Also, some files isn't updated to 1.6.1, so we should update it.
Depends on D35516
Differential Revision: https://phabricator.services.mozilla.com/D35517
--HG--
extra : moz-landing-system : lando
2019-06-21 14:26:53 +00:00
e20f6f80c7
Bug 1560517 - Add update script and patch files for hunspell library r=masayuki
...
Add `update.sh` script and patch files to update hunspell library easily.
Differential Revision: https://phabricator.services.mozilla.com/D35516
--HG--
extra : moz-landing-system : lando
2019-06-21 18:57:35 +00:00
9de72a3ac6
Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
...
Differential Revision: https://phabricator.services.mozilla.com/D34196
--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
dc2b7685d7
Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D33908
--HG--
extra : moz-landing-system : lando
2019-06-06 06:59:37 +00:00
d0cff2d0c6
Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D33744
--HG--
extra : moz-landing-system : lando
2019-06-05 12:57:32 +00:00
bfd87b53d8
Bug 1556925 part 1. Stop using [array] in mozISpellCheckingEngine.suggest. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D33743
--HG--
extra : moz-landing-system : lando
2019-06-05 12:50:13 +00:00
9b956f652d
Bug 1556922. Stop using [array] in nsIEditorSpellCheck. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D33742
--HG--
extra : moz-landing-system : lando
2019-06-05 04:07:28 +00:00
e13e0af55b
Merge mozilla-inbound to mozilla-central. a=merge
2019-06-03 19:01:53 +03:00
3c70419a2b
Bug 1543077 part 3 - Remove the old Japanese detector from the tree. r=emk.
...
Differential Revision: https://phabricator.services.mozilla.com/D27794
2019-06-03 15:30:41 +03:00
0a9fe4ff98
Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D32364
--HG--
extra : moz-landing-system : lando
2019-06-03 11:14:38 +00:00
482c1fdb41
Backed out 2 changesets (bug 1554527, bug 1553867) as requested by Sylvestre for causing huge perf regressions. a=backout
...
Backed out changeset 1e85291f97de (bug 1554527)
Backed out changeset daf113171d63 (bug 1553867)
2019-05-29 09:57:29 +03:00
1dd6cb6ee5
Backed out 6 changesets (bug 1543077) for causing bc failures at docshell/test/browser/browser_bug1543077.js
...
Backed out changeset f593045cc48f (bug 1543077)
Backed out changeset 25449ba8aceb (bug 1543077)
Backed out changeset ccc438262e29 (bug 1543077)
Backed out changeset 4573c25b1ce0 (bug 1543077)
Backed out changeset 1cbaafb9373a (bug 1543077)
Backed out changeset 1a0e7ced8e47 (bug 1543077)
--HG--
extra : rebase_source : f04bf405303fe03776f0e70b03db076c0a41ae45
2019-05-27 12:00:21 +03:00
1447a771cc
Bug 1543077 part 3 - Remove the old Japanese detector from the tree. r=emk
...
Depends on D27793
Differential Revision: https://phabricator.services.mozilla.com/D27794
--HG--
extra : moz-landing-system : lando
2019-05-27 07:55:25 +00:00
5b28bc4e4b
Bug 1330467 - part 7. Confirm FPI in permission manager tests; r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D19928
--HG--
extra : moz-landing-system : lando
2019-05-17 13:23:02 +00:00
c42628e988
Bug 1330467 - part 1. Don't strip first party domain from permissions key; r=johannh,Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D19922
--HG--
extra : moz-landing-system : lando
2019-05-17 13:23:16 +00:00
c926d65d2f
Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D32364
--HG--
extra : moz-landing-system : lando
2019-05-24 19:05:35 +00:00
6971980f49
Bug 1554121 - Enable most ESLint rules for extensions/permissions, extensions/spellcheck and extensions/universalchardet. r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D32450
--HG--
extra : moz-landing-system : lando
2019-05-24 17:17:02 +00:00
Makoto Kato
Tom Ritter
Dylan Roeh
Ehsan Akhgari
Ciure Andrei
Moritz Birghan
Paul Zuehlcke
Tom Schuster
Cosmin Sabou
Razvan Maries
Jorg K
Kris Maglione
Gurzau Raul
Mirko Brodesser
Noemi Erli
Barret Rennie
Boris Zbarsky
Sylvestre Ledru
Ryan VanderMeulen
Jonathan Kingston
Alex Catarineu
Victor Porof
Masayuki Nakano
Henri Sivonen
Andrea Marchesini
Mihai Alexandru Michis
Liang-Heng Chen
Mark Banner