Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#11145 (github issue number if applicable).
Either:
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Source-Repo: https://github.com/servo/servo
Source-Revision: d6509dc4c6a1ec0a0c48c0e5a669a93334407f29
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it doesn't affect the code
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9e766f4d6eb373ebc2c44550077d47a4c6fc0171
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only update dependencies
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Source-Repo: https://github.com/servo/servo
Source-Revision: 3990191431f990b94f2d809c31cdac02a3b262be
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because no functional change
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Source-Repo: https://github.com/servo/servo
Source-Revision: ea84601bf08618254200b3faca055c36e9ff29b4
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix#11152 (github issue number if applicable).
Either:
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Fixes#11152
Source-Repo: https://github.com/servo/servo
Source-Revision: 221db56b08e01157c97f5adba43799eeaee32f64
The cursor in Firefox and Chrome for labels is always the default cursor rather than changing to the text cursor on text. In Edge, however, this only applies to the text of the actual label element.
This PR changes Servo to match Firefox and Chrome.
A convenient example of an element that this style applies to (and has different behavior between Firefox and Edge) is the "This repository" label for the search input at the top on Github.
Source-Repo: https://github.com/servo/servo
Source-Revision: 03465ad8c77f03ae2f538d046ae1e1dc86f04723
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only add debug info.
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
One of these two unwraps is the one that is causing most occurrences
of #8815.
I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2e049a85330ebc71212b4629119d561652ac9bef
So that we don't clobber the drop flags.
This is a regression from #11121.
Source-Repo: https://github.com/servo/servo
Source-Revision: c2beb55c0f039d096241d677fb93bfa0a3b18e56
r? @mbrubeck @metajack
Should fix regression in #11123 that caused build-cef to rebuild again.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9189b9ee63df682a2fc2a57677a8197a69123696
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are just the PR template
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
r? @jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: ef3c4102cf8edab962a950373f88bad5f71e2a90
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#11117 (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only impact webdriver
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1a834b5b83fba29a4e2f89161ae9734f5f60aff3
The whitespace range was not properly shifted which caused us to adjust the fragment's inline size by the advance of a different set of characters.
This was causing justified text lines to be too long or too short.
Source-Repo: https://github.com/servo/servo
Source-Revision: 4a274cf58028267b7cbfbcadebf9504eceb14a4a
This causes a panic (debug) or incorrect results (release) when initializing a work queue with thread_count = 1.
Source-Repo: https://github.com/servo/servo
Source-Revision: 695a2559a835b2a753b8c9a3f3401dc7eceeb20d
Previously the commented out code was not working because there was a deadlock situation where `res_body` is being locked and borrowed to read the inner `body` if it is a `ResponseBody::Receiving` variant, and then locked and borrowed mutably to change `res_body` to `ResponseBody::Done`.
r? @jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: e2a5b1cb710b4c5d19d0493e2a304152c42feabe
We don't yet support the 'unsafe' keyword, which isn't in a spec yet, and which would require slightly more complex parsing.
Source-Repo: https://github.com/servo/servo
Source-Revision: f12869d2a75081eefeacbe4afe50e870bf0c07cb
r? @pcwalton
Fixes#11102.
CC @alexcrichton, @nmatsakis - basically, `codegen-units` is nice for local compilation speedups but results in too many perf regressions to keep it for release builds.
Source-Repo: https://github.com/servo/servo
Source-Revision: cf2b9401ef3ae2aa70768c6b70c54db26332a8b7
Fixes#11031.
`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.
This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.
r? @jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 685dc99e3ef9cf6c88487704709dc13a26812889
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they change only compilation
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
Source-Repo: https://github.com/servo/servo
Source-Revision: f8b7e1c6ae66a0198e38fb959cd959a6ef69b84c
This PR fixes#10886. The -p option can be followed by either an interval number or a CSV filename.
* In the interval profiling, the profiler output would be spitted out to the terminal periodically.
Example usage: **./mach run -p 1 http://www.google.com** will print the time-profiling output to the terminal every second.
* In the CSV file profiling, a CSV file will be generate upon termination of servo.
Example usage: **./mach run -x -o out.png -p out.csv http://www.google.com** will generate out.csv upon termination of Servo.
Source-Repo: https://github.com/servo/servo
Source-Revision: d4315855aaddb9d9ed26cd730e9b75e15500c3bd
Addresses issue #10702
the tidy self-test doesn't seem to catch the `member_name:"Foo"` line like it should. the regex follows similar pattern in the file and works in my regex tester tool, so not really sure what is going on there.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8c2c0bd964bfbf1a2d7494bd8fbbdd263173ef7d
This avoids unncessary build script runs caused by changes to unrelated files.
Note: Adds a dependency on https://crates.io/crates/walkdir which is MIT licensed and maintained by BurntSushi.
r? @metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: a85db48623d8f5b5dbddbcc1f1ba0eaa0b531249
* Remove unnecessary dependencies and features from top-level Cargo.tomls. The features for each crate will be computed based on the union of features specified in the dependency graph. Specifying the same ones again just adds more ways for them to get out of sync.
* Move all cargo build environment variables into CommandBase
Fixes#11112. r? @metajack
(Not included: CI test to make sure #11112 doesn't regress again.)
Source-Repo: https://github.com/servo/servo
Source-Revision: 7f76e3ba74a11f1f4bb46f12e17c06270175908f
This preserves the fix from #11097 in the situation where `$CARGO_HOME` and `cargo-home-dir` in `.servobuild` are both present: `.servobuild` should win.
But it changes the behavior when `$CARGO_HOME` is present and `.servobuild` is not: Then `$CARGO_HOME` should be used.
We now check the following values in order of priority and use the first one that is found:
1. `cargo-home-dir` in `.servobuild`
2. `CARGO_HOME` in the environment
3. default value (`<servo-repo>/.cargo`)
r? @larsbergstrom
Source-Repo: https://github.com/servo/servo
Source-Revision: fcebfcc1130b7b3e74f14c8375f825f148e0f152
* Rewrite constructors of `Blob` and `File` with `DataSlice` as argument
* Update WebIDL of `Blob` and `File`
* Implement missing interfaces of `File` (However, due to lack of working `ArrayBuffer/ArrayBufferView` in `Blob`, so it still differs from spec)
* Update WPT test `File-constructor.html`
Source-Repo: https://github.com/servo/servo
Source-Revision: 392135bd0c2f512a0d632a7d76e667bc9af8f4a7
This is a prerequisite for merging #11044, and is an important correctness fix on its own.
r? @Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: 91cabf8427ae8a7693a56c11abfd32b5058c21de
This is intended to support the File API implementation. Basically an event loop with three kinds of messages:
+ Select a file
+ Read a file with ID
+ Delete the ID from manager-owned map
The design decision in this PR is not the final (or best I think) version, welcome reviews :)
TODOs:
- [x] Add multiple file selection
Source-Repo: https://github.com/servo/servo
Source-Revision: b61ad4190f7fb7d4fa32e01a0e3db77a912cb7cf
While here, we make border-*-width round to pixels like Gecko does.
Source-Repo: https://github.com/servo/servo
Source-Revision: 190103a7d7dee0925bb66341d9bc2387a1572a75
<s>Because of the way Gecko stores outline-width in nsStyleOutline::mOutlineWidth (i.e., as its specified value for keywords) we need separate property implementations for servo/gecko products.</s>
The -moz-outline-radius parsing is a bit of a hack; I was just avoiding the effort of factoring out the parsing into a separate method. Let me know if I should do that.
<s>Gecko-side changes are https://bugzilla.mozilla.org/show_bug.cgi?id=1271168.</s>
Source-Repo: https://github.com/servo/servo
Source-Revision: a834bc1ec700ca6447ee13bda9714f78381f2f80
Currently `--profile-trace-path` has no effect if `-p` isn't also passed, because the time profiler doesn't start.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8fab68d6a9543248b1e798dfe53036e33654e8cd
Fixes#4954. r? @jdm
This is based on hyperium/hyper#472, though it doesn't re-use that code directly because Servo configures its own OpenSSL context.
Source-Repo: https://github.com/servo/servo
Source-Revision: 40be84df26ce3ce80851e751374154c015506921
This series of commits fixes#9487, and improves the look of nytimes.com among others.
r? @metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: 1fd9c5583455b873fca1c95b2784f969870073bd
Delete session is needed by the web platform test `webdriver/navigation.py`.
Source-Repo: https://github.com/servo/servo
Source-Revision: 0c673ef3a2adb3ffd8c3181ee4ec5546d610db5b
This use always `cargo-home-dir` in `/.servobuild` even if you set `CARGO_HOME` in your shell.
If you use [racer][racer] with [rustup (multirust.rs)][rustup], you may set `CARGO_HOME` env variable to your shell. Then the previous code would be a problem which does not use `cargo-home-dir` in `/.servobuild`.
[racer]: https://github.com/phildawes/racer
[rustup]: https://github.com/rust-lang-nursery/rustup.rs
Source-Repo: https://github.com/servo/servo
Source-Revision: 0617727f5b58d1c4ebb10cf081f5952b7961fbf4
Part of making the trace-dump.js code unit testable was moving it out to another
repo. This brings in all the changes made while writing unit tests, and making
the code more unit testable.
Unfortunately, there are a lot of whitespace changes; here is the diff ignoring whitespace: https://pastebin.mozilla.org/8870346Fixes#10905.
r? @jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 835f443865fbaa8784722ad6f950a2c8879fab31
mrmiywj
Jack Moffitt
Matt Brubeck
Connor Imes
Ms2ger
Emilio Cobos Álvarez
Zaggy1024
Bobby Holley
Anthony Ramine
Keith Yeung
Lars Bergstrom
Connor Brewster
Alan Jeffrey
Ulf Nilsson
Cameron McCormack
Martin Broesamle
Rohit Zambre
aeischeid
Zhen Zhang
Josh Matthews
Patrick Walton
Shing Lyu
Fabrice Desré
Tetsuharu OHZEKI
Nick Fitzgerald