499ca20f31
Bug 1421968 - Enable ESLint rule mozilla/use-services by default, but whitelist it for various directories still to be fixed. r=mossop
...
MozReview-Commit-ID: KOZWr7FiDQZ
--HG--
extra : rebase_source : 92c9bc236c9043f6ce25cc2ba45264918eb2ac15
2017-11-28 19:24:12 +00:00
54088f8c9e
Bug 1422115 - Remove storageserver.js from services/. r=markh,tcsc
...
MozReview-Commit-ID: 4UGCq6SolY1
--HG--
extra : rebase_source : 49e8a5d072d1cb15d0942e7fbc39c7a2c8c08c6f
2017-11-30 15:11:19 -05:00
ae62aef149
Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
...
MozReview-Commit-ID: 5vBKH9NejVV
--HG--
extra : rebase_source : c160a5a1d7753d41c7afec3a822aefa9461684e6
2017-11-17 16:48:17 -05:00
e5e82c8496
Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE
2017-11-30 18:44:16 +02:00
016b5734e5
Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
...
MozReview-Commit-ID: 5vBKH9NejVV
--HG--
extra : rebase_source : e8628aba338b19142dc63add9bb380042096053f
2017-11-17 16:48:17 -05:00
cb71a3c4fe
Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE
2017-11-30 12:55:54 +02:00
403ad27bae
Bug 1420802 - Remove NetworkLinkService from offline check. r=tcsc
...
Summary: Remove NetworkLinkService from offline check.
Reviewers: tcsc
Reviewed By: tcsc
Bug #: 1420802
Differential Revision: https://phabricator.services.mozilla.com/D300
2017-11-29 15:15:28 -05:00
0dd353e7d5
Bug 1421850 - ensure Sync is fully initialized before syncing. r=tcsc
...
MozReview-Commit-ID: 7hS3fttgqqr
--HG--
extra : rebase_source : b9a342c1a977699c3c4c42e9bca86ee087a51260
2017-11-30 14:03:57 +11:00
788c2ca211
Bug 1421817 - Send a sync ping on shutdown if we have events but no syncs. r=markh
...
MozReview-Commit-ID: ExxN6UXs2Ip
--HG--
extra : rebase_source : 356d2f7bbfc856859e7b6246939b785f0984fa82
2017-11-29 17:41:59 -05:00
302308a0a1
Bug 1336257 - Use HTTPS for mozqa url in TPS. r=markh
...
MozReview-Commit-ID: Admw1iKeW24
--HG--
extra : rebase_source : 836f3efb3aea6eb2a089c5aecd0f7a10a0bd6787
2017-11-29 18:35:28 -05:00
4b66d38dd6
Bug 1420810 - record why we are syncing for most syncs initiated by the scheduler. r=eoger
...
MozReview-Commit-ID: 1ntqG5yQi7q
--HG--
extra : rebase_source : 73b479ac7e602f5f491f63939a4425af17d6ce25
2017-11-27 17:32:05 +11:00
39bf8149a6
Bug 1416788 - limit number of visits we pass to PlacesUtils.history.insertMany to prevent shutdown hangs. r=kitcambridge
...
MozReview-Commit-ID: AU9AMUAD1Rw
--HG--
extra : rebase_source : 205ec0f17f94bd399f4663e552bd75e7b63f7da5
2017-11-23 16:18:55 +11:00
dc2fe37c66
Bug 1421452 - Fix deprecation warning in test_bookmark_engine by passing an osfile path instead of nsifile. r=markh
...
MozReview-Commit-ID: 4XrzA0kUXzE
--HG--
extra : rebase_source : bed7a594b854969dd1932449f43ade4dc068ffeb
2017-11-28 17:35:51 -05:00
a004052a6e
Bug 1421044 - Make TPS await sync initialization before trying to run r=markh
...
MozReview-Commit-ID: JSBXKHRXjc0
--HG--
extra : rebase_source : f18047d5a71d92acb9712244266909fc9e09dd0f
2017-11-28 13:56:48 -05:00
6e7fbdc912
Bug 1420349 - Instantiate the sync scheduler in the service's constructor, instead of in onStartup. r=eoger
...
MozReview-Commit-ID: 3bOnRH5jR9e
--HG--
extra : rebase_source : 63eb169666e6b5694e7324f5eb01349189a895ec
2017-11-28 11:48:10 -05:00
7822b14bda
Bug 1346072 - Remove accounts.firefox.com from the whitelist of domains allowed to send objects over webchannels. r=markh
...
MozReview-Commit-ID: 4ts3uBPuXom
--HG--
extra : rebase_source : 0dced36f4c14f8fb4f7633f3b265ac22d95ecfd7
2017-11-24 20:24:42 +00:00
efaca11893
Bug 1420422 - Enable ESLint rule mozilla/use-services for services/. r=markh
...
MozReview-Commit-ID: LQiMr3ppDuG
--HG--
extra : rebase_source : f509b5360e92db58f14b0f6a41c06e10fe7dd170
2017-11-24 14:46:33 +00:00
9f071e2083
Bug 1409534 - Replace Resource impl by fetch. r=kitcambridge,markh,tcsc
...
MozReview-Commit-ID: 5mmVeHeMQKf
--HG--
extra : rebase_source : 84c20e3b90b5bed43e511158270761e2e1da6b15
2017-11-06 16:24:40 -05:00
438ca97ce7
Bug 1419990 - Only sync the tabs collection on sleep if there are changes. r=markh
...
MozReview-Commit-ID: GC0KMmQPqqD
--HG--
extra : rebase_source : 2039c7f644b3510dda07839c1e561786ad8c0ba1
2017-11-23 11:24:41 -05:00
0154c0f443
Bug 1416320 - Do a quick sync before going to sleep. r=markh
...
MozReview-Commit-ID: I36uvEFlEz5
--HG--
extra : rebase_source : 93812879d3ea19042356e51672f7f464e30e9ee5
2017-11-10 14:09:44 -05:00
959009f1a8
Backed out changeset 23fbfd83e957 (bug 1416320) for ESlint failure at gecko/services/sync/modules/policies.js:558:71 on a CLOSED TREE
2017-11-21 07:26:51 +02:00
ab35b46c98
Bug 1416320 - Do a quick sync before going to sleep. r=markh
...
MozReview-Commit-ID: I36uvEFlEz5
--HG--
extra : rebase_source : 1910ac25084f6a8c37a6d21accf17da974d56493
2017-11-10 14:09:44 -05:00
b2e847755c
Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
...
MozReview-Commit-ID: GrlcOI9K2hJ
--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
2017-05-28 19:57:46 +01:00
afa6330a25
Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep. r=markh
...
MozReview-Commit-ID: 2vzmj3UkvtD
--HG--
extra : rebase_source : a152684365627cf1ea68efe10f5e27ad15577135
2017-11-16 13:12:31 -05:00
0648f86b7f
Bug 1304898 - Include why in sync ping. r=tcsc
...
MozReview-Commit-ID: G9WnHhuWD7Z
--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
2017-11-15 17:10:45 -05:00
fbd7ca1890
Bug 1416807 - Don't schedule syncs while we're behind to a captive portal. r=markh
...
MozReview-Commit-ID: 2CrO3CfKgC3
--HG--
extra : rebase_source : 460fb20172e325a154a4848e6a5ed0bacefd4b77
2017-11-15 16:01:48 -05:00
d6c28d0200
Bug 1417590 - Check for client duplicates in the Sync collection validator. r=tcsc
...
MozReview-Commit-ID: LcPnTEDhbis
--HG--
extra : rebase_source : 5070eebbb1495ac14cc140862dd78d46e638615f
2017-11-10 22:27:30 -08:00
43771ba19d
Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
...
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.
MozReview-Commit-ID: 5TUueknq3ng
--HG--
extra : rebase_source : 1892edfcaa7b6afd29ce794a93d6ab3d46c48895
2017-11-07 12:01:53 -08:00
9e62cc5726
Bug 1416313 - Drop old or low priority commands rather than failing to sync the clients engine if too many commands are sent. r=eoger,markh
...
MozReview-Commit-ID: 6BJGmUL28hp
--HG--
extra : rebase_source : 894cafb34f193b802c90052142174ea3187b8396
2017-11-10 15:57:33 -05:00
892f157456
Bug 1416902 - Fix missing await in test_service_sync_updateEnabledEngines and test_interval_triggers r=kitcambridge
...
MozReview-Commit-ID: 6rFOWPsxxxj
--HG--
extra : rebase_source : 62e37062876d4dd38cc43f532df622c09b94cf1b
2017-11-13 16:53:15 -05:00
8a3dc70885
Bug 1416321 - Do a sync after we successfully connect to a captive portal. r=markh
...
MozReview-Commit-ID: HuXyJ8IrNwA
--HG--
extra : rebase_source : b1171a1235011d5393dcd90a950b55320302c254
2017-11-10 14:55:19 -05:00
93a711ae04
Bug 1416374 - Handle getting an abortincoming error in sync telemetry r=markh
...
MozReview-Commit-ID: LFmbkGa4ypu
--HG--
extra : rebase_source : 93e7e9fcfbdf141c86cede055b58d82985fea370
2017-11-10 18:02:58 -05:00
177a5a8bdc
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
...
--HG--
extra : histedit_source : 46923056fd09298724464a4df4466357821a361f
2017-11-12 21:22:25 -05:00
31aa407113
Bug 1383623 - Remove synchronous Places API usage from the Sync unit tests. r=tcsc
...
MozReview-Commit-ID: Cip7LSSi2fE
--HG--
extra : rebase_source : deaff010d15d7ae9812d1d38f3b39c1100c62cf3
2017-11-09 15:46:27 -08:00
b16410f51c
Merge inbound to m-c. a=merge
2017-11-10 16:13:15 -05:00
cbb956e0c3
Bug 1407679 - Merge nsIIOService and nsIIOService2; r=nwgh
2017-11-10 07:03:36 -07:00
96b3be2c0d
Bug 1415957 - Remove MozMill from TPS: Fix merge conflict. r=conflict-fix a=conflict-fix on a CLOSED TREE
...
--HG--
extra : amend_source : fd6fe1681aa192ed44675bd52cd46e954ffad9b8
2017-11-10 13:45:48 +02:00
7e070192d7
Merge inbound to mozilla-central r=merge a=merge
2017-11-10 11:55:43 +02:00
f4dd5e2636
Bug 1414096 (attempt 2) - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
...
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
--HG--
extra : rebase_source : b885ee784704819e181430200af5ef762e269d14
2017-11-10 09:07:48 +11:00
207b8d909e
Bug 1347515 - Get rid of nsIJSON.decodeFromStream, r=qdot
2017-11-10 00:27:22 +01:00
1873a289f7
Bug 1415957 - Remove MozMill from TPS. r=tcsc
...
MozReview-Commit-ID: HyBXrNqhzIf
--HG--
extra : rebase_source : da197fa045f70621d5549e961876cfc6ce15264b
2017-11-09 15:34:06 -05:00
315a813f56
Bug 1415343 - Remove useless check for target window from FxAccountsWebChannel.jsm. r=markh
...
MozReview-Commit-ID: 4rFCNbMSF0a
--HG--
extra : rebase_source : 5d9ff600453d47afb4791a43bc6b043677c70cdb
2017-11-09 08:10:37 +00:00
c9b01d9a02
Bug 1415345 - Fix undefined variable in error message in FxAccountsStorageManager#getAccountData. r=markh
...
MozReview-Commit-ID: 4mCdPfKX5lz
--HG--
extra : rebase_source : 898771109c879f950d607273bc469734a9a0f99d
2017-11-07 23:00:26 +00:00
be730a069d
Bug 1414438 - Use `getBatched` instead of `get` to backfill records r=kitcambridge
...
MozReview-Commit-ID: LLTg0ae5BbW
***
Bug 1414438 - Use `getBatched` instead of `get` in sync
--HG--
extra : rebase_source : b9b057160470ec5bc5544a1a4d5d429bee460452
2017-11-08 09:05:11 +01:00
21b6b18b0b
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
2017-11-10 13:47:59 +02:00
d93840902b
Bug 1382937 - Rewrite Sync's master password functions to use the `nsILoginManagerCrypto` wrappers. r=MattN
...
Using `nsISecretDecoderRing` directly bypasses
`nsILoginManagerCrypto.uiBusy` and the observer notifications, so other
consumers might not be aware we're already showing the dialog. We also
bail early if the UI is busy, to avoid showing multiple dialogs.
MozReview-Commit-ID: I7xzUWZkyPH
--HG--
extra : rebase_source : 91cef140cc54d1c81fe5c1986ffd2b8983ddd575
2017-10-23 10:40:56 -07:00
edeaf1bc14
Bug 1415012 - Don't trigger a resync if the previous sync wasn't completely successful r=kitcambridge
...
MozReview-Commit-ID: DcNsFUxXR1O
--HG--
extra : rebase_source : 2632aa8d6db8e9e101e949c237b559015444f808
2017-11-06 20:56:57 -05:00
af670f4147
merge mozilla-central to mozilla-inbound. r=merge a=merge
2017-11-07 02:47:30 +02:00
53383c5b3f
Bug 1408108 - Rename "Sync ID" to "record ID" in the bookmarks engine and `PlacesSyncUtils`. r=kitcambridge
...
--HG--
extra : rebase_source : da3acfc4f7393a615c44f238c624bb826ff5b766
2017-11-06 12:17:07 -08:00
935734388d
Bug 1412351 - Make sync behave better during shutdown r=kitcambridge
...
MozReview-Commit-ID: 4zWNph8Zdld
--HG--
extra : rebase_source : 12e9f82222a4bcfe2161ad02669619b57f0442fe
2017-10-27 13:37:49 -04:00
d61954557d
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: Ai6Y5GGfkfT
2017-11-04 10:58:24 +01:00
b9c6a1d730
Bug 1413413 (part 2) - Remove support for extensions having their own prefs file. r=glandium,kmag.
...
It's no longer needed, now that legacy extensions aren't supported.
Pieces removed include the following.
- The "load-extension-default" observer notification.
- The code for reading defaults/preferences/*.js from extensions.
- The unit test for this stuff.
- A crash reporter annotation relating to very long prefs set by add-ons.
- All references to "ExtPrefDL".
MozReview-Commit-ID: KMBoYn3uZ3x
--HG--
extra : rebase_source : 4dc8ffd425c6cdf06806409090c4f9d04a64930b
2017-10-31 16:34:57 +11:00
e4007fdbe7
Bug 1375223 - Remove Async.querySpinningly. r=kitcambridge
...
MozReview-Commit-ID: bMo1jyIY5g
--HG--
extra : rebase_source : ac69fde2cb8216300bdb9e7d19528c15cdceb7c8
2017-10-31 18:50:31 -04:00
604673b3d3
Bug 1366067 - Use `JSONFile.jsm` to persist the backlog and previously failed IDs. r=tcsc
...
MozReview-Commit-ID: DAwMrtWI8eh
--HG--
extra : rebase_source : f6713745b09de2e6b0993539cce9ed4e8226dbbf
2017-11-01 11:10:47 -07:00
4a77d5a93f
Bug 1388224 - Remove SyncStorageRequest HTTP wrapper class, which is no longer used r=kitcambridge
...
MozReview-Commit-ID: EgExfizNll5
--HG--
extra : rebase_source : 85a6098a5b985990bd3a8483936bf6cf768f1f0b
2017-11-01 17:17:46 -04:00
064ed56076
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
...
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : f382f0a883c5aa1f6a4466fefe22ad1a88ab6d20
2017-11-01 11:09:57 -07:00
96593594d3
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
...
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:
* First, we fetch all records changed since the last sync, up to the
download limit, and without an explicit sort order. This happens to
work correctly now because the Python server uses "newest" by
default, but can change in the future.
* If we reached the download limit fetching records, we request
IDs for all records changed since the last sync, also up to the
download limit, and sorted by index. This is likely to return IDs
for records we've already seen, since the index is based on the
frecency. It's also likely to miss IDs for other changed records,
because the number of changed records might be higher than the
download limit.
* Since we then fast-forward the last sync time, we'll never download
any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.
MozReview-Commit-ID: 7uQLXMseMIU
--HG--
extra : rebase_source : 719ee2d9e46102195251b410f093da3247095c22
2017-10-27 17:54:48 -07:00
432850c0aa
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
...
MozReview-Commit-ID: 6YI1OEE8x7R
--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
2017-10-27 17:55:30 -07:00
3e7662202d
Bug 1413685 - Unify AsyncResource and Resource. r=tcsc
...
MozReview-Commit-ID: 1yEeAwpbGxJ
--HG--
extra : rebase_source : 8c87b0d16138acf2b55be70767fe0547f4ac1d42
2017-11-02 14:30:59 -04:00
1b5408583f
Backed out 3 changesets (bug 1368209)xpcshell failures services/sync/tests/unit/test_syncengine_sync.js on CLOSED TREE
...
Backed out changeset 1b868efa368f (bug 1368209)
Backed out changeset b88c681ccdc1 (bug 1368209)
Backed out changeset 4b8e56844ae9 (bug 1368209)
2017-11-03 11:40:06 +02:00
4105f1cb3a
Bug 1368209 - Refactor `Engine::_processIncoming` into three stages. r=eoger,tcsc
...
* In the first stage, we fetch changed records, newest first, up to the
download limit. We keep track of the oldest record modified time we
see.
* Once we've fetched all records, we reconcile, noting records that
fail to decrypt or reconcile for the next sync. We then ask the store
to apply all remaining records. Previously, `applyIncomingBatchSize`
specified how many records to apply at a time. I removed this because
it added an extra layer of indirection that's no longer necessary,
now that download batching buffers all records in memory, and all
stores are async.
* In the second stage, we fetch IDs for all remaining records changed
between the last sync and the oldest modified time we saw in the
first stage. We *don't* set the download limit here, to ensure we
add *all* changed records to our backlog, and we use the `"oldest"`
sort order instead of `"index"`.
* In the third stage, we backfill as before. We don't want large deltas
to delay other engines from syncing, so we still only take IDs up to
the download limit from the backlog, and include failed IDs from the
previous sync. On subsequent syncs, we'll keep fetching from the
backlog until it's empty.
Other changes to note in this patch:
* `Collection::_rebuildURL` now allows callers to specify both `older`
and `newer`. According to :rfkelly, this is explicitly and
intentionally supported.
* Tests that exercise `applyIncomingBatchSize` are gone, since that's
no longer a thing.
* The test server now shuffles records if the sort order is
unspecified.
MozReview-Commit-ID: 4EXvNOa8mIo
--HG--
extra : rebase_source : 13605dd3a43569a6d83dc2eb15a578a7bbd5c1ca
2017-11-01 11:09:57 -07:00
481bdb6dd6
Bug 1368209 - Add a test for fetching backlogged history records. r=tcsc
...
The test captures the existing logic in `_processIncoming`, even though
it's not quite correct:
* First, we fetch all records changed since the last sync, up to the
download limit, and without an explicit sort order. This happens to
work correctly now because the Python server uses "newest" by
default, but can change in the future.
* If we reached the download limit fetching records, we request
IDs for all records changed since the last sync, also up to the
download limit, and sorted by index. This is likely to return IDs
for records we've already seen, since the index is based on the
frecency. It's also likely to miss IDs for other changed records,
because the number of changed records might be higher than the
download limit.
* Since we then fast-forward the last sync time, we'll never download
any remaining changed records that we didn't add to our backlog.
* Finally, we backfill previously failed and backlogged records.
MozReview-Commit-ID: 7uQLXMseMIU
--HG--
extra : rebase_source : 5742474889845b934c3d2e8b479d26d719cd03c0
2017-10-27 17:54:48 -07:00
8f60eeed17
Bug 1368209 - Add support for `sortindex` and `older` to the mock Sync server. r=tcsc
...
MozReview-Commit-ID: 6YI1OEE8x7R
--HG--
extra : rebase_source : 2f0da0cd2a1554685fff5af3de100e4b01564447
2017-10-27 17:55:30 -07:00
4ee948935f
Bug 1408176 - Use trace logs when logging PII in sync passwords engine r=kitcambridge
...
MozReview-Commit-ID: KueHgdTH02Z
--HG--
extra : rebase_source : a8f5814c5d9baf8e6c370c65da8472f9c7c6213e
2017-10-27 11:32:22 -04:00
4de6bf22b1
Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
...
MozReview-Commit-ID: H5YVp3rnzGo
--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
3b78d2f449
Bug 1412139 - Prepare existing bookmark engine tests for new buffered engine. r=kitcambridge
...
MozReview-Commit-ID: 2HIkdPOuWOy
--HG--
extra : rebase_source : 6c8108f707f59e8d795dfd489453c614f00fd096
2017-09-11 14:17:24 -07:00
76547f53cc
Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
...
MozReview-Commit-ID: APdGc9avJDw
--HG--
extra : rebase_source : aaa788be5251607ebedcb5b690da0e2a1a64e2cb
2017-10-24 14:05:52 -04:00
93903f0306
Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE
...
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
2017-10-26 23:33:04 +02:00
58876ecbe9
Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
...
MozReview-Commit-ID: APdGc9avJDw
--HG--
extra : rebase_source : 9da1cea9fb6494c057bc6587a7bcbdb4ac127448
2017-10-24 14:05:52 -04:00
1225809c1d
Bug 1411690 - Floor the repair advance and most recent repair timestamps. r=tcsc
...
The timestamps are automatically truncated when they're stored in
prefs, which is fine because we don't need millisecond precision.
However, the truncation raises a warning, so we need to explicitly
floor the values.
MozReview-Commit-ID: BRflL6s0b1
--HG--
extra : rebase_source : 6724a1ad05cb8aee4ab8c666545784960c23a0f3
2017-10-25 13:54:44 -07:00
4a0a0ce970
Bug 1411714 - Handle action=email in about:accounts. r=tcsc
...
MozReview-Commit-ID: 5U6Qy78S1Nl
--HG--
extra : rebase_source : 69368eca5243d418c9705959be81f724351291c6
2017-10-25 16:41:37 -04:00
1ead0a96a9
Backed out changeset dab1c5badddb (bug 1407679) for failing server startup in mochitests on Android. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 3dc4cb2bbaf55f3f6329687ce64d4e862fc3800b
2017-10-24 21:18:26 +02:00
9dd47ebf50
Bug 1407679 - Merge nsIIOService and nsIIOService2 r=nwgh
...
Removes deprecated nsIIOService2.newChannelFromURIWithProxyFlags
MozReview-Commit-ID: Gr3nA25kcre
--HG--
extra : rebase_source : 3407b5ed0f8f7067523abee28c137db3cac86b14
2017-10-20 16:41:07 +02:00
c31dc99e96
Bug 890217 - Add a test for syncing bookmarks with IMAP URLs. r=tcsc
...
MozReview-Commit-ID: KBVInzYk1Rr
--HG--
extra : rebase_source : 9ba1b55c154a9a19f24dcf8b859189123abcad1c
2017-10-20 08:55:52 -07:00
0a687f249e
Bug 1404577: Actually disable loading blocklist dump in test_cert_blocklist.js. r=leplatrem
...
The dump file isn't in the expected location in firefox tests, but is in
thunderbird tests, so the preference to disable loading wasn't originally
implemented.
MozReview-Commit-ID: HvFqfC69yMQ
--HG--
extra : rebase_source : 1d358292f0ab94299e444f4d3e3454a2259d1a64
2017-10-19 21:26:20 -06:00
7caa92d5d8
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
2c51427c6d
Bug 1408180 - Ensure LoginRec.toString doesn't contain the password. r=kitcambridge
...
MozReview-Commit-ID: 5mV0g9LH4vE
--HG--
extra : rebase_source : 33a9c246053448450e6107c3b244d0bf86f7decb
2017-10-12 18:15:48 -04:00
87cd48824a
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
2017-10-13 00:53:56 +02:00
f7efb5fc2c
Merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
2017-10-12 12:03:15 +02:00
d8c3cc3c0b
Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc
...
MozReview-Commit-ID: DhrZ1oFY2WG
--HG--
extra : rebase_source : d8d35bdb08edbad9412d6953a671c3e38e75711c
2017-10-03 14:45:11 -04:00
87b8d9ecb9
Bug 1406488 - Use a set instead of array to store current visits in `_recordToPlaceInfo` r=kitcambridge
...
MozReview-Commit-ID: LW6Gg7i5lun
2017-10-11 19:06:10 -04:00
30ccd917b0
Backed out changeset 8d5cc47b248f (bug 1401700) for failing xpcshell services/sync/tests/unit/test_bookmark_repair.js on OS X 10.10 opt. r=backout
2017-10-11 23:44:26 +02:00
51d18ff941
Bug 1401700 - Prevent incoming tabs from opening multiple times if client sync fails. r=tcsc
...
MozReview-Commit-ID: DhrZ1oFY2WG
--HG--
extra : rebase_source : e98e4ee0a3e376840ce89f0908d7210b167154fa
2017-10-03 14:45:11 -04:00
4397201c90
Bug 1407726 - Add reason field to push messages sent with /notify. r=tcsc
...
MozReview-Commit-ID: 3sRpheND9Wa
--HG--
extra : rebase_source : 23f7dffb920f9f9f14ccdd16f171c489f36745cc
2017-10-11 14:58:21 -04:00
7555b605f1
Bug 1407082 - Handle more kinds of errors in SyncTelemetry.transformError. r=kitcambridge
...
MozReview-Commit-ID: CjwY7w7vUqs
--HG--
extra : rebase_source : 4030ab88c3eccd755272499ff0527e9e316998b1
2017-10-10 12:31:42 -04:00
da5797466a
Bug 1403276 - Dedupe sync devices with the same fxaDeviceId by picking the one with the newer last modified date r=eoger
...
MozReview-Commit-ID: 3Lq7vuPpF6
--HG--
extra : rebase_source : f16c5fe0d29551ab829ba8f0c8c92e78109ace07
2017-10-10 13:41:32 -04:00
83f6879b5d
Bug 1052247 - Enforce that OAuth is done over HTTPS in FxAccountsOAuthClient. r=markh
...
It now follows the setting of the identity.fxaccounts.allowHttp preference.
MozReview-Commit-ID: 9646Xi48QMP
--HG--
extra : rebase_source : 630e65bebc00e755ca3be1d159e08fec738d590f
2017-10-04 16:22:45 -04:00
0c48a189bc
Bug 1405833 - Ensure SyncEngine uses CommonUtils.namedTimer properly. r=kitcambridge
...
MozReview-Commit-ID: 6YnhcSjKW9U
--HG--
extra : rebase_source : 3e0e520516f06efa50aa8e3fccb77214daca419a
2017-10-04 17:26:20 -04:00
e9d579fe2a
Bug 1405566 - Clamp future and far past synced history visit dates. r=markh
...
MozReview-Commit-ID: Gs0DpTTu1Ab
--HG--
extra : rebase_source : b836f4ae366eaf127935dee593dc51d2222e3aca
2017-10-04 14:16:29 -07:00
c42f57923a
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : e20ec54eabb5ecb2cc0b85efb687dbed06f1d16a
2017-10-02 18:41:20 -07:00
e6050e53aa
Bug 1401990 - Use max_request_bytes instead of max_post_bytes if sync server provides both r=markh
...
MozReview-Commit-ID: GJadUIuSGKt
--HG--
extra : rebase_source : be8da0b14c0e1522bc1dc025871fc34830d9ae58
2017-10-02 16:42:22 -04:00
bd61777c6b
Backed out changeset fe9b8761d51f (bug 1348981)
2017-10-04 15:43:46 +02:00
8d488926ef
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 9ad775a652affc0d8d6c7ce4153dddc8a13c4ca4
2017-10-02 18:41:20 -07:00
d8e232c88a
Backed out changeset 8dda8bbcf385 (bug 1348981)
2017-10-04 01:00:09 +02:00
c8714b1c7d
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 058e6011c8ce953059e674eea032ba79c19f8eb8
2017-10-02 18:41:20 -07:00
d39e820403
Bug 1403052 - Limit tab sync max_record_payload_size to 512k. r=markh
...
Also fixes an issue where we wouldn't encode to utf8 when comparing the actual
size to the limit after the first time.
MozReview-Commit-ID: Cf3byjI1FTZ
--HG--
extra : rebase_source : 272ec3b3ad85f8b44c4d69950be83419054abdab
2017-10-02 19:27:54 -04:00
ae55f5a197
Bug 1359428 - Remove preference to select OneCRL update mechanism r=keeler,leplatrem,rhelmer
...
MozReview-Commit-ID: A6CwZrIDmTn
--HG--
extra : rebase_source : 41e17d29f982d23f30f48a6f85ad20fc84b018c6
2017-09-29 10:47:27 +01:00
9f708fd861
Bug 1400467 - Ensure services/common/logmanager.js awaits it's cleanup function r=markh
...
MozReview-Commit-ID: thQph1UUA0
--HG--
extra : rebase_source : 705cdd9d07a1a26b568554e07638c0415789b404
2017-09-22 11:57:13 -04:00
76a3991796
Bug 1400467 - Make WeaveCrypto use promises instead of spinning event loops r=eoger,markh
...
MozReview-Commit-ID: 64dewKKaAOJ
--HG--
extra : rebase_source : e8d48e05ad8dac214358b0a9979b011a65ed07a8
2017-09-15 19:21:31 -07:00
1df9d06245
Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc
...
MozReview-Commit-ID: 3oUBqLuHpoG
--HG--
extra : rebase_source : 303c40b6fc5a41a7b2f2e9edc9f275228ccbbe47
2017-09-22 15:19:44 -04:00
60aea23a2c
Bug 1395427 p3 - Allow form history items to be created with a specific guid. r=markh
...
This allows us to have the same form history GUIDs across devices, which is mandatory
if we want tombstones to actually do something.
MozReview-Commit-ID: Hw6ahbVA5lB
--HG--
extra : rebase_source : 5289322dea430f364790026470ff844f754dd570
2017-09-22 15:08:48 -04:00
6cbbf769ee
Backed out changeset d7876bfd8bfc (bug 1395427)
2017-09-27 17:10:21 +02:00
e08e4f2f41
Backed out changeset d86f2704b27a (bug 1395427)
2017-09-27 17:10:15 +02:00
7d0ecfa428
Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc
...
MozReview-Commit-ID: 3oUBqLuHpoG
--HG--
extra : rebase_source : 19f4c4c21c35d9d604e17d3e1df862bc700773bd
2017-09-22 15:19:44 -04:00
8dcfa9de4f
Bug 1395427 p3 - Allow form history items to be created with a specific guid. r=markh
...
This allows us to have the same form history GUIDs across devices, which is mandatory
if we want tombstones to actually do something.
MozReview-Commit-ID: Hw6ahbVA5lB
--HG--
extra : rebase_source : 39f9cc5553f44f149abc0ed9715268c538fc27ba
2017-09-22 15:08:48 -04:00
216b709c48
Backed out 4 changesets (bug 1348981) for Linux debug timeouts in test_system_update.js
...
Backed out changeset b1fe39ea6d5c (bug 1348981)
Backed out changeset 47866f942752 (bug 1348981)
Backed out changeset 5e93d8760487 (bug 1348981)
Backed out changeset 58431e2c37d7 (bug 1348981)
MozReview-Commit-ID: 2WjZKztxyVs
2017-09-23 06:20:56 -07:00
70071e128b
Bug 1348981 - only load system add-ons from a built-in list r=kmag
...
MozReview-Commit-ID: A6c5kaLmNPP
--HG--
extra : rebase_source : 8a98ba4a36f2717c1b733b661e9d8621a9bbfec0
2017-09-14 00:36:04 -07:00
27eb845182
Bug 1401590 - Mock FxAccounts#newAccountState in push service tests. r=markh
...
MozReview-Commit-ID: 8kVtWbPKp65
--HG--
extra : rebase_source : cb970e68e7be85ea53723207b91c7981b84d41a4
2017-09-21 13:27:46 -04:00
ddbf9d22ec
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
...
MozReview-Commit-ID: Equ8FrTJpTj
2017-09-21 16:42:31 +02:00
b627373bca
Bug 1401686 - Handle cases where max_post_bytes is less than max_record_payload_bytes. r=kitcambridge
...
MozReview-Commit-ID: AAiF2rD075A
--HG--
extra : rebase_source : 657bf67186ebeb2e962c2b515d1fea47a95a677e
2017-09-20 16:18:20 -04:00
c278109711
Bug 1401382 - Make it safe to await inside async TPS handlers r=markh
...
This patch also makes all the remaining synchronouns TPS handlers async, since
it seems likely that this issue could happen again.
MozReview-Commit-ID: DSlrX3pgeJI
--HG--
extra : rebase_source : b55a54e51787398dc55d4359dd749be2c5900d6c
2017-09-19 18:40:19 -04:00
6348cd2190
Bug 1393659 - Fix inconsistent handling of max_post_bytes and max_request_bytes r=markh
...
MozReview-Commit-ID: 4jwpAYNuoQj
--HG--
extra : rebase_source : f32ecbd9740f7d8647fdf37ad6bbb53e332320ac
2017-09-13 18:02:41 -07:00
dc3b62bea0
Bug 1383663 part 3 - Update FxA local state on profile email change. r=markh
...
MozReview-Commit-ID: 5epKjoT4TF3
--HG--
extra : rebase_source : 3c9737d304d2a4a4448e43c1f4a13e738716453e
2017-08-21 17:01:57 -04:00
daf87f8b3b
Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh
...
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.
MozReview-Commit-ID: FuCMewhO20z
--HG--
extra : rebase_source : cbeb2b30a425020e2379d3f5d21affabe610a20b
2017-08-21 17:06:06 -04:00
e6c038d6ee
Backed out 3 changesets (bug 1383663) for timeouts in browser_aboutAccounts.js and failures in test_web_channel.js
...
Backed out changeset f384a524cac6 (bug 1383663)
Backed out changeset 9d26a627e2f8 (bug 1383663)
Backed out changeset c7d46e2e8ddc (bug 1383663)
MozReview-Commit-ID: 88xbdeVJtK2
2017-09-16 10:40:00 -07:00
3d91da7159
Bug 1383663 part 3 - Update FxA local state on profile email change. r=markh
...
MozReview-Commit-ID: 5epKjoT4TF3
--HG--
extra : rebase_source : 437b8d56d48898b347ecaf3d9ca0f6cc3176d2e2
2017-08-21 17:01:57 -04:00
11875727be
Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh
...
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.
MozReview-Commit-ID: FuCMewhO20z
--HG--
extra : rebase_source : f071fe7d8b67d84a0b2836b7dae3883e8c85c46a
2017-08-21 17:06:06 -04:00
95856672f4
Bug 1400394 - Remove `TestingUtils.deepCopy`. r=markh
...
MozReview-Commit-ID: 3ZZpA3inWSF
--HG--
extra : rebase_source : 506d1bb5bba484e65bcd5abed196c3ecc751fb1b
2017-09-15 13:46:21 -07:00
3a3834f7a8
Bug 1400075 - Cleanup async handling for tab engine in TPS. r=markh
...
MozReview-Commit-ID: BQ0aJodErWy
--HG--
extra : rebase_source : 4f74acd21f64559b9a7215638672f6952283a4fe
2017-09-14 16:59:11 -07:00
be553422dd
merge mozilla-central to autoland. r=merge a=merge
2017-09-13 11:30:55 +02:00
80aa14098f
Bug 1399191 - Use an arrow function to avoid an undefined this value when calling namedTimer. r=markh
...
MozReview-Commit-ID: 2VwzGtAIYz7
--HG--
extra : rebase_source : 8ac4f5b5aba9891a82f2f6777d8c1fc55d26d41e
2017-09-12 10:12:37 -07:00
f829523282
Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/ r=Mossop
...
MozReview-Commit-ID: 4ewrbY0FS09
--HG--
extra : rebase_source : 390256a9eb0d303d8582c24d69fff189b0e0ab4d
2017-09-08 18:16:50 -07:00
d6cced9ca1
Bug 1394525 - Reset tracker scores before syncing. r=markh
...
MozReview-Commit-ID: 1wHdOeiZOyl
--HG--
extra : rebase_source : 765094feecdbe79cfa30f5c5a2886f8113890077
2017-08-28 11:24:26 -07:00
0d29ca233e
Bug 1393904 - Ensure `insertTree` removes Sync tombstones for restored bookmarks. r=mak
...
MozReview-Commit-ID: EbGybRbhWKJ
--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
2017-08-25 12:04:22 -07:00
614d92ab8f
Bug 1186409 - Fix code that tries to get the global by using |this|. r=kmag
...
MozReview-Commit-ID: C5ixngtvzWU
--HG--
extra : rebase_source : 65507b2d1f58a8f1f1e36e2153ed1d490f4a86dc
2017-05-25 14:12:12 -07:00
5317324bec
Bug 1397537 - check FxA has a session token and enter a needs-reauth state even when the user is unverified. r=eoger
...
MozReview-Commit-ID: KuldXySDvt4
--HG--
extra : rebase_source : 9b33265b341e7fcd5be9dc6e3b01d218ce1aabca
2017-09-07 11:13:53 +10:00
5cff6fa2da
Bug 1397530 - report all exceptions checking the account status. r=eoger
...
MozReview-Commit-ID: ClCaDhgdQ0a
--HG--
extra : rebase_source : 615b32fbe5a7b7dd86191e66985c08905edb2c52
2017-09-07 09:35:47 +10:00
3136ed3935
Bug 1396967 - Fix undeclared assignments in MozMill. r=tcsc
...
MozReview-Commit-ID: 7C5zFAHmRQQ
--HG--
extra : rebase_source : f6b0d5e1cac37ec1031176f291a13953f5af4e83
2017-09-05 12:32:36 -07:00
27afdd11e1
Bug 1396544 - don't schedule syncs when Sync isn't configured. r=rnewman
...
MozReview-Commit-ID: AM0G43vFyty
--HG--
extra : rebase_source : 9888cfd079f4761debb710d1bbe064956aec1093
2017-09-05 12:40:53 +10:00
1e1c59dfa4
Bug 1396740 - declare waitForEvents object in TPS's mozmill extension. r=tcsc
...
MozReview-Commit-ID: AFWuHR7JgCp
--HG--
extra : rebase_source : dd886f33d5e427e046c2004bd5e993748bfc3caa
2017-09-05 17:57:47 +10:00
5f4d03ee95
Bug 1391488 - catch and ignore errors fetching the hostname from the DNS service. r=kitcambridge
...
MozReview-Commit-ID: 5hTDNmzTXdQ
--HG--
extra : rebase_source : 4565d13941fd167d81420e639e7ebc37f94a3a8f
2017-09-01 16:48:24 +10:00
b4905330e7
Bug 1377533 - Remove scattered references to Kinto and Sqlite in blocklist clients r=glasserc,mgoodwin
...
MozReview-Commit-ID: FExozSDHgNN
--HG--
extra : rebase_source : 892c1c5825ac20243ce74118d4df437ec99cfe2c
2017-06-30 12:07:28 -07:00
2dad858a21
Bug 1375635 - Add telemetry for how often and long users are in bad authentication states. r=Dexter,rweiss+418169,tcsc
...
MozReview-Commit-ID: BW8ixM3wmxJ
--HG--
extra : rebase_source : 6872e86fbd6ff00c4ab65ef4bf8c6195e06de54b
2017-07-27 11:59:24 +10:00
e16b402acf
Bug 1395148 - Run some services/sync xpcshell tests sequentially; r=markh
...
These tests normally pass when run sequentially but often timeout when run
in parallel, especially on debug builds.
2017-08-31 07:50:25 -06:00
8b415f700f
Bug 1394556: Part 1 - Fix strict mode errors in JSM scripts. r=Mossop
...
MozReview-Commit-ID: 4LmJQql7Y2c
--HG--
extra : rebase_source : f18b5547a5a57db4e8b990bfc34f06690ac9da7a
extra : histedit_source : 7281bafbde4bf231752d9d868ec8ca1d2f55a2f9
2017-08-30 01:50:27 -07:00
a8e6d0bd2c
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: 7XpmaFg1k8N
2017-08-29 16:17:13 -07:00
e200863a26
Bug 1298930 - Remove the eRestarti386 and eRestartx86_64 constants. r=spohl
...
--HG--
extra : amend_source : 303c9a9df47398ad87d86ba6522cbdddbfe647a7
2017-08-29 05:50:00 -04:00
51f7139dc5
Bug 1390644 - Change the mid-sync state of "Syncing…" to "Syncing Tabs…". r=eoger
...
MozReview-Commit-ID: Ef1aWhWEnZh
--HG--
extra : rebase_source : 458685d94d16acfb21d080287484869c93d7a091
2017-08-28 21:38:49 -04:00
5a0bb50ea8
Bug 1392148 - Remove aliases to CommonUtils in util.js r=markh
...
MozReview-Commit-ID: 1fv6AN0TMNW
--HG--
extra : rebase_source : 083c73e50bfdb2dd121aa483e5aa53ae0e35768d
2017-08-24 22:41:44 -07:00
c204098ad4
Bug 1392409 - set engine.lastModified to avoid intermittent orange. r=tcsc
...
MozReview-Commit-ID: 4kPzk9nSWxw
--HG--
extra : rebase_source : 6f4ef917001e2565dd00eefa12876fc897705ca1
2017-08-23 13:59:16 +10:00
5b02cef919
Backed out changeset 0f63d6c1f3c6 (bug 1377533) for frequently failing xpcshell's toolkit/components/extensions/test/xpcshell/test_ext_api_permissions.js. r=backout
2017-08-24 18:34:43 +02:00
5361ecfb8d
Bug 1377533 - Remove scattered references to Kinto and Sqlite in blocklist clients r=glasserc,mgoodwin
...
MozReview-Commit-ID: FExozSDHgNN
--HG--
extra : rebase_source : 3c02d9d13ed9d417171305bf7aa3523b69b8a3fb
2017-06-30 12:07:28 -07:00
a53020d022
Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
...
MozReview-Commit-ID: 35MaseieNUk
--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
2017-08-20 18:52:05 +01:00
34e7a1eb17
Bug 1355766 - don't treat a 412 response as a sync error. r=kitcambridge
...
MozReview-Commit-ID: 4IL6RJcP9PC
--HG--
extra : rebase_source : 2e0c3143da1f01eaeb5a30efab2becd367ded36c
2017-08-08 12:02:28 +10:00
fa4625acc7
Bug 1368951 - add x-if-unmodified-since support to the sync test server. r=tcsc
...
MozReview-Commit-ID: FF7smwdeQ0k
--HG--
extra : rebase_source : 82f8706d6a27f1bf93b95b93572a2fa37b268b3d
2017-05-31 18:42:45 +10:00
b242392e7d
Bug 1353217 - importing bookmarks from html doesn't need to reset the bookmarks engine. r=markh
...
MozReview-Commit-ID: 4F7KF5ZkNuX
--HG--
extra : rebase_source : 521510fe074fa0f84f28212fa8a230a74dfd2ce8
2017-08-11 00:19:01 +00:00
95c51b495b
Bug 1383622 (part 2) - update TPS to use the async bookmark API. r=tcsc
...
MozReview-Commit-ID: CnTx1stPyCY
--HG--
extra : rebase_source : 3123392bd8089c32d228f224baa7aca286f0d75d
2017-08-15 12:44:50 +10:00
c2aeb7a464
Bug 1383622 (part 1) - convert most of TPS to async/await. r=tcsc
...
MozReview-Commit-ID: F6kBw1vPBPh
--HG--
extra : rebase_source : 1bd302f66e35a7f078b5dfdc7d9b075e6bfe89f5
2017-08-12 14:09:48 +10:00
0ce9a00f9a
Backed out 2 changesets (bug 1383622) for eslint failures a=backout
...
Backed out changeset 60005e2d9ea5 (bug 1383622)
Backed out changeset d229587489da (bug 1383622)
MozReview-Commit-ID: J7N7iCBLsGZ
2017-08-16 16:25:30 -07:00
7f2a621327
Bug 1383622 (part 2) - update TPS to use the async bookmark API. r=tcsc
...
MozReview-Commit-ID: CnTx1stPyCY
--HG--
extra : rebase_source : 31cc8b3952d1d5e52ea84afa72d0b4aaa69c8d4c
2017-08-15 12:44:50 +10:00
4b462aadc9
Bug 1383622 (part 1) - convert most of TPS to async/await. r=tcsc
...
MozReview-Commit-ID: F6kBw1vPBPh
--HG--
extra : rebase_source : 1bd302f66e35a7f078b5dfdc7d9b075e6bfe89f5
2017-08-12 14:09:48 +10:00
a13adeddc4
Bug 1377944 - Converts the history engine to use 'PlacesUtils.history.insertMany'. r=kitcambridge
...
MozReview-Commit-ID: 61IoSuLE5cr
--HG--
extra : source : 26831e829c5a5d5e3026bb97518066f1764482c5
2017-07-31 00:53:50 -03:00
5b94d1f0b3
Bug 1389717 - Ensure `HistoryStore#changeItemID` waits for `fetchURLInfoForGuid`. r=markh,tcsc
...
MozReview-Commit-ID: CAVdgurQxPj
--HG--
extra : rebase_source : 45c3812ffd1782781a0e6ea8ab72b3fb0a32fcd6
2017-08-11 19:08:04 -07:00
2b29093c50
Bug 684121 - Don't access Services.appinfo at import time r=kitcambridge
...
As stated by Philipp, the prefs engine (PREFS_GUID) accesses Services.appinfo at import time.
Changed code to use a lazy getter on the global object instead.
changed services/sync/modules/engines/prefs.js
MozReview-Commit-ID: 1MAGKM9r1OM
--HG--
extra : rebase_source : 37f3112383f8073d1afa220ff7e8ac4d7fc38ec5
2017-08-13 05:08:48 +03:00
5a4357c768
Merge inbound to central, a=merge
...
MozReview-Commit-ID: GArkKmOFIVH
2017-08-11 13:15:33 -07:00
472098beec
Bug 1386171 - log urls for synced tabs at trace level. r=eoger
...
MozReview-Commit-ID: 2veccAv2Bpn
--HG--
extra : rebase_source : 3487ad6937913c663bb81d7f6c99f1deca7d5af7
2017-08-11 14:26:29 +10:00
3e1366bdf6
Bug 1388149 - Make PlacesUtils.history.insertMany respect provided GUIDs r=markh
...
MozReview-Commit-ID: 7g6uABtHKg2
--HG--
extra : rebase_source : 0b43e026ad3de514d2ffbc56568bf3f4e3e17126
2017-08-07 16:01:10 -04:00
7651bde05c
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: 9Abf0fILvvK
2017-08-08 15:16:00 -07:00
7eae341db9
Bug 1386825 - Part 6: Remove FxAccountsManager now that MOZ_B2G is removed. r=markh
...
MozReview-Commit-ID: 8ldrMrPqhsV
2017-08-08 14:41:12 -07:00
fe18bf0131
Bug 1386825 - Part 4: Remove remaining instances of MOZ_B2G. r=froydnj
...
MozReview-Commit-ID: 8r4eMwiZ4Vg
2017-08-08 14:41:09 -07:00
635b24e121
Merge mozilla-central to autoland
2017-08-08 13:25:29 +02:00
0f16d437cc
merge mozilla-inbound to mozilla-central a=merge
2017-08-08 13:18:14 +02:00
a51f7dc64c
Backed out changeset 26831e829c5a (bug 1377944) at markh's request
...
MozReview-Commit-ID: 526HN6OCn1A
2017-08-07 20:42:50 -07:00
d4398e95f2
Bug 1385820 - Enable the ESLint no-new-wrappers rule across mozilla-central; r=markh,standard8
...
MozReview-Commit-ID: FvJO3ibeiwg
--HG--
extra : rebase_source : 5fc5c6760924da81a6d0708ff0d5586fc62c8c5e
2017-08-07 23:57:51 +05:30
8b713b2b0f
Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
...
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.
MozReview-Commit-ID: 4ecl3RZhOwC
--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
2017-08-04 17:49:22 +09:00
4f08809c1f
Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger
...
MozReview-Commit-ID: 4bmu45qUmFA
2017-08-04 15:00:51 +10:00
5df77c43f9
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: IJRYyJu1sWm
2017-08-02 17:42:10 -07:00
017a9b6e9a
Merge autoland to central, a=merge
...
MozReview-Commit-ID: 38bhUR3fKcF
2017-08-02 15:47:58 -07:00
2b42c50319
Bug 1385440 - Serialize client commands additions. r=markh
...
MozReview-Commit-ID: 3qGcHVhOCeL
--HG--
extra : rebase_source : 3d71a5af631d2dd9be59ce0b1495959552f8c640
2017-08-02 11:33:24 -04:00
f0e4ae5f8c
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2017-08-02 09:12:05 +01:00
f143125cc2
Bug 1326520 - Rename nsIURI.path to pathQueryRef. r=valentin.gosu
...
MozReview-Commit-ID: DqJdTGopR9G
--HG--
extra : rebase_source : e8c9eb03468c075b79013b6e0bd8b367229c24cd
2017-07-29 20:50:21 +09:00
48e6bc2124
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
6b5f784403
Bug 1384818 - flush sync log files on sync reset. r=eoger
...
MozReview-Commit-ID: H6CkvHGxAmx
--HG--
extra : rebase_source : 53bede19ec7766c91c30324668dcca8d11f64197
2017-07-27 14:57:47 +10:00
5f4393ac11
Bug 1371746 - Remove unused variables in constants.js. r=kitcambridge
...
MozReview-Commit-ID: GUQjlWVHPC0
--HG--
extra : rebase_source : 13b127ecf84d8ef5b9a3f99c78960de15eb2a47b
2017-08-01 01:53:56 -03:00
5368b04624
Bug 1374722 - Expand the set of ids requested during the initial repair process r=markh
...
MozReview-Commit-ID: 92SGMd9fJgX
--HG--
extra : rebase_source : 0b6ca2379a03adc4488bf3f679a3f81b18de83b1
2017-06-20 13:40:17 -04:00
4f228db6e2
Bug 1387834 - Remove @deprecated nsIDOMWindowUtils.WHEEL_EVENT_CAUSED_BY_PIXEL_ONLY_DEVICE. r=masayuki
...
MozReview-Commit-ID: 4onWMSGPa4U
--HG--
extra : rebase_source : a5908d04a15fb0e9eb35b7e3c31a050bceafb2e7
2017-08-06 23:44:53 +09:00
3fd6606bcc
Bug 1389141: Clean up trailing newline for 2 files in "services" directory. r=markh
...
DONTBUILD because whitespace-only.
Notes:
* hawkrequest.js has a redundant trailing newline; this patch removes it.
* browser.ini is missing a trailing newline; this patch gives it one.
MozReview-Commit-ID: DYstjpDejgg
2017-08-10 15:55:50 -07:00
b3c6e06245
Bug 1377944 - Converts the history engine to use 'PlacesUtils.history.insertMany'. r=kitcambridge
...
MozReview-Commit-ID: 61IoSuLE5cr
--HG--
extra : rebase_source : e3a84dc40e99b27e1beaa9dd9ceec4c2e41487e8
2017-07-31 00:53:50 -03:00
804a36e668
Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout
2017-07-31 14:44:34 +02:00
22dfa54ef4
Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
...
MozReview-Commit-ID: FadrI2li43G
--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
7a9b4d8b79
Bug 1336518 - Move Sync history queries into PlacesSyncUtils. r=kitcambridge
...
MozReview-Commit-ID: Lood8ivLeJf
--HG--
extra : rebase_source : dcb8207378afc6ce2995acfe4f235f3ed728a188
2017-07-30 17:46:56 -03:00
5c9899d993
Bug 1383621 - Use the async bookmarks API to insert the mobile query. r=markh
...
MozReview-Commit-ID: KaeXwFHEg7K
--HG--
extra : rebase_source : b67f8662e221614041aad391d71bdf381ce4e8b0
2017-07-24 16:45:17 -07:00
8d2320d13f
Bug 1385191 - Prefer email address from the FxA profile over that from the account. r=eoger
...
MozReview-Commit-ID: 78U2RZQ5xfB
--HG--
extra : rebase_source : b79b18ea8c545003998692cd97c7ad5d6606c7f7
2017-07-28 16:35:40 +10:00
892bedca2e
merge mozilla-inbound to mozilla-central a=merge
2017-07-28 15:24:39 +02:00
99daef93ea
Backed out changeset face8d3f9fb9 (bug 1384818) for frequently failing xpcshell's services/sync/tests/unit/test_errorhandler_2.js on Linux. r=backout
2017-07-28 10:48:07 +02:00
c8885211ce
Bug 1385127 - Enable bookmark validation on early Beta. r=markh
...
MozReview-Commit-ID: h1ps0YebkW
--HG--
extra : rebase_source : 76f35b04fd37fbed82f483e526194e8a1a7623ea
2017-07-27 16:07:14 -07:00
4f86008efc
Bug 1384818 - flush sync log files on sync reset. r=eoger
...
MozReview-Commit-ID: H6CkvHGxAmx
--HG--
extra : rebase_source : 4fd55ac857c225e0a7de35f0049e873cc362b2db
2017-07-27 14:57:47 +10:00
3ad4c3d247
Bug 1384936 - Remove weave_version definition and directly replace the constant in modules/constants.js in the gecko migration script, to avoid the need for the preprocessor in modules/constants.js. r=rnewman,rail
...
--HG--
extra : rebase_source : b6f4ed4929ab6405fa726fbc25ea6748f871c07b
2017-07-27 16:22:53 +02:00
250eef68d6
Bug 1375212 - Wrap thrown strings in Error objects r=eoger,markh
...
MozReview-Commit-ID: KquBcbNhBEN
--HG--
extra : rebase_source : 172bcad2eb178092bc7d49940db61e8cb5ad6572
2017-07-22 18:55:43 -07:00
932f724512
Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. r=markh
...
The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.
I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.
MozReview-Commit-ID: Gq16sNm7K2e
--HG--
extra : rebase_source : e597233dae23d7582f34faeb83365896b6c22a75
2017-07-25 11:53:45 -07:00
65bbd0525a
Merge inbound to central, a=merge
...
MozReview-Commit-ID: E4oXfAM1mtd
2017-07-25 19:04:37 -07:00
061209972d
Bug 1368568 - Remove legacy SyncKeyBundle. r=eoger
...
MozReview-Commit-ID: JYiTeQnduto
2017-07-25 11:40:14 -04:00
92f8a06bee
Bug 1383773 - Fix race between browser and TPS initialization. r=markh
...
MozReview-Commit-ID: 7Ie1IzRzEbI
--HG--
extra : rebase_source : 0f113c56ea473273f889ebd0e2f6fc148cd2fe91
2017-07-24 11:10:32 -04:00
89e20571b9
Bug 1383835 - Increase the amount of time TPS waits after a tab sync before continuing r=markh
...
MozReview-Commit-ID: 1cvmtpkjSbX
--HG--
extra : rebase_source : 7b9c022082498c5c901534177ed3441669e05990
2017-07-24 14:01:03 -04:00
dfba49cf8d
Bug 1122443 - Decrease FxA email status polling frequency. r=markh
...
MozReview-Commit-ID: L8QQwgWqsyH
--HG--
extra : rebase_source : 75c1a88b05c788ff32c30f8b4b03513e8f217614
2017-07-19 16:05:34 -04:00
1e3bdd598f
Bug 1382913 - throw an error when a non existing observer is removed from observers.js. r=kitcambridge
...
MozReview-Commit-ID: AR2IPDH0Rpw
--HG--
extra : rebase_source : c533d5a5e086fc43c9c847297c3fba97ed9e25d7
2017-07-25 13:59:44 +10:00
23b85ab316
Bug 1337978 - Unify the multiple notions of 'weak upload' in sync. r=kitcambridge,markh
...
MozReview-Commit-ID: 5vTCAhUfMzm
--HG--
extra : rebase_source : fea6783352868e15481a751923aac2a166ad5506
2017-07-18 14:18:04 -04:00
f3248efb0d
Fix the private browsing mode check in FxAccountsWebChannel.jsm (bug 1378766) r=eoger,markh
...
The private browsing mode check reached into the sendingContext's browser's docShell
for it's check, the Law of Demeter was shattered.
PrivateBrowsingUtils.jsm provides all the functionality needed for the check,
just call PrivateBrowsingUtils.isBrowserPrivate with the sendingContext's browser.
MozReview-Commit-ID: DRIU1fy94ml
***
Bug 1378766 - Remove the `sendingContext.browser` defined check
MozReview-Commit-ID: GWFFggOoItP
--HG--
extra : rebase_source : 1c99ee2ea2cceee185ba20ff54e6e67f86f10766
2017-07-20 10:35:47 +01:00
9a475a45bf
Bug 1382044 - Disable addon validation during some phases of TPS's test_addon_nonrestartless_xpi.js. r=markh
...
MozReview-Commit-ID: 112UJWjF7R4
--HG--
extra : rebase_source : d398e93deb2d5bd7cc43d96eb37580552b8e2d72
2017-07-18 19:56:50 -04:00
8893010bae
Bug 1380835 - Don't check queries with `excludeQueries` for cycles in the bookmark validator. r=tcsc
...
MozReview-Commit-ID: DsPzrCxWWMG
--HG--
extra : rebase_source : 25281ab8f8d53901d960a738212361831b12fc55
2017-07-13 19:52:57 -07:00
Mark Banner
Edouard Oger
Noemi Erli
Margareta Eliza Balazs
Mark Hammond
Thom Chiovoloni
Ryan Leake
Cosmin Sabou
Dan Banner
Kit Cambridge
Doug Thayer
Ryan VanderMeulen
Geoff Brown
Sebastian Hengst
Nicholas Nethercote
Andrea Marchesini
tfe
Manish Kumar
Luciano I
NARCIS BELEUZU
Valentin Gosu
Tom Prince
Kevin Pellet (Ilphrin)
Robert Helmer
Mark Goodwin
Phil Ringnalda
ffxbld
Kris Maglione
Andrew McCreight
Mathieu Leplatre
Wes Kocher
Josh Aas
Steve Armand
Nicolas Ouellet-Payeur
Luciano Italiani
Leni Kadali
Eric Rahm
Carsten "Tomcat" Book
dagasatvik
Masatoshi Kimura
Rajesh Kathiriya
Daniel Holbert
tiago
Marco Castelluccio
Rob Cutmore
Shane Tomlinson