45039bb033
Bug 1494386 - Uplift u2f-hid-rs 0.2.2, Windows aarch64 fix r=keeler
...
See https://github.com/jcjones/u2f-hid-rs/pull/67
Differential Revision: https://phabricator.services.mozilla.com/D7795
--HG--
extra : moz-landing-system : lando
2018-10-05 00:05:04 +00:00
ede1418858
Merge mozilla-central to inbound. a=merge CLOSED TREE
2018-10-02 19:08:39 +03:00
837f0af066
Bug 1493737 - Fix many trivial calls to do_QueryInterface r=smaug
...
If class A is derived from class B, then an instance of class A can be
converted to B via a static cast, so a slower QI is not needed.
Differential Revision: https://phabricator.services.mozilla.com/D6861
--HG--
extra : moz-landing-system : lando
2018-10-01 21:38:01 +00:00
3d31cfbfef
bug 1483905 - ensure the WebAuthnManager stays alive while WebAuthnTransactionChild is using it r=qdot
...
Differential Revision: https://phabricator.services.mozilla.com/D5305
--HG--
extra : rebase_source : 1c05f0cd33954fe0127e295b4c76eed40f75e6ef
2018-09-07 09:17:19 -07:00
e9fe8be654
Backed out changeset a653a439a39b (bug 1483905)for build bustages on webauthn/WebAuthnTransactionChild.cpp:35 CLOSED TREE
2018-10-01 14:11:57 +03:00
6012e76803
Bug 1483905 - Ensure the WebAuthnManager stays alive while WebAuthnTransactionChild is using it. r=qdot
...
Differential Revision: https://phabricator.services.mozilla.com/D5305
2018-10-01 06:58:34 -04:00
c603d5f53f
Bug 1492973 - Update u2f-hid-rs to 0.2.1 r=froydnj
...
Moves winapi dependency to 0.3.5 and updates rust-fmt
Differential Revision: https://phabricator.services.mozilla.com/D6436
--HG--
extra : moz-landing-system : lando
2018-09-20 22:04:15 +00:00
150199f6f8
Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs
...
This is a follow up to Bug 1482667. The list of callers was gathered by instrumenting
the webidl calls to these methods and dumping JS stack when they are called in browser.xul.
Differential Revision: https://phabricator.services.mozilla.com/D5185
--HG--
extra : moz-landing-system : lando
2018-09-07 15:31:38 +00:00
2dd8d57be4
Bug 1480365: WebAuthManager doesn't need to keep alive AbortSignal, r=smaug
2018-08-06 21:01:53 +02:00
a52a8495f9
Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D2725
Differential Revision: https://phabricator.services.mozilla.com/D2860
--HG--
extra : rebase_source : 189c13c2a3104c106fcabad5998af6cb2e20d4a5
2018-10-02 14:59:34 +02:00
4f7b2378dc
Bug 1474273 - Add xpc::CurrentNativeGlobal and use it instead of NativeGlobal(JS::CurrentGlobalOrNull(cx)). r=bz
2018-07-11 14:07:02 +02:00
5b753da289
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
e3dc094a76
bug 1468909 - enforce that all given RP IDs be valid domain strings in webauthn r=qdot
...
The webauthn spec mandates that relying party identifiers (RP IDs) are valid
domain strings. This enforces that by ensuring that any passed-in RP IDs parse
correctly when set as the host portion of a URL.
https://w3c.github.io/webauthn/#relying-party-identifier
--HG--
extra : rebase_source : 6be22c9be660db3062f4e8119051cd122bc24a12
2018-06-19 14:29:45 -07:00
6efd24a566
Bug 1468349 - Web Authentication - Add FreeBSD Support r=jcj
...
Summary:
Upstream PR: https://github.com/jcjones/u2f-hid-rs/pull/62
* Extract hidproto module from linux::hidraw
Make the protocol parts independent of Linux code, in preparation for
adding FreeBSD support.
* Add FreeBSD (uhid + devd) support
Tested with a YubiKey 4.
Tags: #secure-revision
Bug #: 1468349
Differential Revision: https://phabricator.services.mozilla.com/D1636
MozReview-Commit-ID: 8NNWRgTEMn2
--HG--
extra : rebase_source : edf774f0a993a18b59b5f8aa10e0977d94ea1de8
2018-06-12 09:55:30 -07:00
f93bd1a2dd
Backed out changeset 80190d88549c (bug 1468349) for build bustages on a CLOSED TREE
2018-06-12 20:18:58 +03:00
ee92007fde
Bug 1468349 - Web Authentication - Add FreeBSD Support
...
Upstream PR: https://github.com/jcjones/u2f-hid-rs/pull/62
* Extract hidproto module from linux::hidraw
Make the protocol parts independent of Linux code, in preparation for
adding FreeBSD support.
* Add FreeBSD (uhid + devd) support
Tested with a YubiKey 4.
Differential Revision: https://phabricator.services.mozilla.com/D1636
2018-06-12 16:59:10 +00:00
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
2a252e45a4
Bug 1464015 - Web Authentication - Rework IPC layer for future Android/Windows support r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Subscribers: mgoodwin
Bug #: 1464015
Differential Revision: https://phabricator.services.mozilla.com/D1378
2018-05-30 16:06:09 +02:00
9ca7fca83d
Bug 1463170 - Set AuthenticatorAssertionResponse.userHandle to null r=ttaubert r=smaug
...
Summary:
The WebAuthn spec says to set `AuthenticatorAssertionResponse.userHandle` to
null when the authenticator returns no user handle (e.g., when allowList is set),
but we return an empty ArrayBuffer. This is because of the defaults in
AuthenticatorAssertionResponse.h, as the field is itself unset.
We missed this change to the spec that happened in December [2], so this also
has a corresponding WebIDL update. I don't see any other instances of WebIDL
differences.
[1] https://w3c.github.io/webauthn/#ref-for-dom-authenticatorassertionresponse-userhandle%E2%91%A0
[2] 3b2a1d141chttps://treeherder.mozilla.org/#/jobs?repo=try&revision=59a2ab255ef14e935c1aa9f457276f8e61e5d779
Reviewers: smaug, ttaubert
Bug #: 1463170
Differential Revision: https://phabricator.services.mozilla.com/D1337
--HG--
extra : amend_source : 966dcd24050585e745078648e1d7995b3beaf9ca
extra : transplant_source : h%3E%B7COQ%F3%05%A9%95%1C%5D%CD%E1XZ%06Z%8D%83
2018-05-21 09:04:50 -07:00
2b5e4e52b4
Bug 1462324 - Remove unused WebAuthnTransaction::mDirectAttestation r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1462324
Differential Revision: https://phabricator.services.mozilla.com/D1301
2018-05-17 18:32:53 +02:00
37ab4344d8
Bug 1460301 - Web Authentication - Don't use U2F_PING to initialize tokens r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1460301
Differential Revision: https://phabricator.services.mozilla.com/D1270
2018-05-14 17:37:47 +02:00
b1cbda2eea
Bug 1460767 - Return device ineligible when appropriate for U2F r=ttaubert
...
Summary:
FIDO U2F's specification says that when the wrong security key responds to a
signature, or when an already-registered key exists, that the UA should return
error code 4, DEVICE_INELIGIBLE. We used to do that, but adjusted some things
for WebAuthn and now we don't. This changes the soft token to return that at
the appropriate times, and updates the expectations of U2F.cpp that it should
use InvalidStateError as the signal to reutrn DEVICE_INELIGIBLE.
Also, note that WebAuthn's specification says that if any authenticator returns
"InvalidStateError" that it should be propagated, as it indicates that the
authenticator obtained user consent and failed to complete its job [1].
This change to the Soft Token affects the WebAuthn tests, but in a good way.
Reading the WebAuthn spec, we should not be returning NotAllowedError when there
is consent from the user via the token (which the softtoken always deliveres).
As such, this adjusts the affected WebAuthn tests, and adds a couple useful
checks to test_webauthn_get_assertion.html for future purposes.
[1] https://w3c.github.io/webauthn/#createCredential section 5.1.3 "Create a new
credential", Step 20, Note 2: "If any authenticator returns an error status
equivalent to "InvalidStateError"..."
Test Plan: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2fc930f7fc8eea69b1ebc96748fe95e150a92a4
Reviewers: ttaubert
Bug #: 1460767
Differential Revision: https://phabricator.services.mozilla.com/D1269
--HG--
extra : transplant_source : M%5B%93%81%29%7E%B2%E8%24%05%A6%96%8BUN%C9%FB%3E%B3h
2018-05-10 16:36:18 -07:00
e966f910ac
Bug 1459558 - Sync u2f-hid-rs changes r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1459558
Differential Revision: https://phabricator.services.mozilla.com/D1145
--HG--
rename : third_party/rust/core-foundation/.cargo-checksum.json => third_party/rust/core-foundation-0.5.1/.cargo-checksum.json
rename : third_party/rust/core-foundation/Cargo.toml => third_party/rust/core-foundation-0.5.1/Cargo.toml
rename : third_party/rust/core-foundation/src/array.rs => third_party/rust/core-foundation-0.5.1/src/array.rs
rename : third_party/rust/core-foundation/src/base.rs => third_party/rust/core-foundation-0.5.1/src/base.rs
rename : third_party/rust/core-foundation/src/bundle.rs => third_party/rust/core-foundation-0.5.1/src/bundle.rs
rename : third_party/rust/core-foundation/src/dictionary.rs => third_party/rust/core-foundation-0.5.1/src/dictionary.rs
rename : third_party/rust/core-foundation/src/filedescriptor.rs => third_party/rust/core-foundation-0.5.1/src/filedescriptor.rs
rename : third_party/rust/core-foundation/src/lib.rs => third_party/rust/core-foundation-0.5.1/src/lib.rs
rename : third_party/rust/core-foundation/src/propertylist.rs => third_party/rust/core-foundation-0.5.1/src/propertylist.rs
rename : third_party/rust/core-foundation/src/runloop.rs => third_party/rust/core-foundation-0.5.1/src/runloop.rs
rename : third_party/rust/core-foundation/src/set.rs => third_party/rust/core-foundation-0.5.1/src/set.rs
rename : third_party/rust/core-foundation/tests/use_macro_outside_crate.rs => third_party/rust/core-foundation-0.5.1/tests/use_macro_outside_crate.rs
rename : third_party/rust/core-foundation-sys/.cargo-checksum.json => third_party/rust/core-foundation-sys-0.5.1/.cargo-checksum.json
rename : third_party/rust/core-foundation-sys/Cargo.toml => third_party/rust/core-foundation-sys-0.5.1/Cargo.toml
rename : third_party/rust/core-foundation-sys/src/array.rs => third_party/rust/core-foundation-sys-0.5.1/src/array.rs
rename : third_party/rust/core-foundation-sys/src/base.rs => third_party/rust/core-foundation-sys-0.5.1/src/base.rs
rename : third_party/rust/core-foundation-sys/src/bundle.rs => third_party/rust/core-foundation-sys-0.5.1/src/bundle.rs
rename : third_party/rust/core-foundation-sys/src/data.rs => third_party/rust/core-foundation-sys-0.5.1/src/data.rs
rename : third_party/rust/core-foundation-sys/src/date.rs => third_party/rust/core-foundation-sys-0.5.1/src/date.rs
rename : third_party/rust/core-foundation-sys/src/dictionary.rs => third_party/rust/core-foundation-sys-0.5.1/src/dictionary.rs
rename : third_party/rust/core-foundation-sys/src/error.rs => third_party/rust/core-foundation-sys-0.5.1/src/error.rs
rename : third_party/rust/core-foundation-sys/src/filedescriptor.rs => third_party/rust/core-foundation-sys-0.5.1/src/filedescriptor.rs
rename : third_party/rust/core-foundation-sys/src/lib.rs => third_party/rust/core-foundation-sys-0.5.1/src/lib.rs
rename : third_party/rust/core-foundation-sys/src/messageport.rs => third_party/rust/core-foundation-sys-0.5.1/src/messageport.rs
rename : third_party/rust/core-foundation-sys/src/number.rs => third_party/rust/core-foundation-sys-0.5.1/src/number.rs
rename : third_party/rust/core-foundation-sys/src/propertylist.rs => third_party/rust/core-foundation-sys-0.5.1/src/propertylist.rs
rename : third_party/rust/core-foundation-sys/src/runloop.rs => third_party/rust/core-foundation-sys-0.5.1/src/runloop.rs
rename : third_party/rust/core-foundation-sys/src/set.rs => third_party/rust/core-foundation-sys-0.5.1/src/set.rs
rename : third_party/rust/core-foundation-sys/src/string.rs => third_party/rust/core-foundation-sys-0.5.1/src/string.rs
rename : third_party/rust/core-foundation-sys/src/timezone.rs => third_party/rust/core-foundation-sys-0.5.1/src/timezone.rs
rename : third_party/rust/core-foundation-sys/src/url.rs => third_party/rust/core-foundation-sys-0.5.1/src/url.rs
rename : third_party/rust/core-foundation-sys/src/uuid.rs => third_party/rust/core-foundation-sys-0.5.1/src/uuid.rs
2018-05-08 10:04:52 +02:00
368a1dde38
Bug 1458755 - Web Authentication - Copy flag bits 0 & 1 for Sign operations r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1458755
Differential Revision: https://phabricator.services.mozilla.com/D1114
--HG--
extra : amend_source : 349a05210460beefbfe0dcc3e3f36885bb02246c
2018-05-07 11:23:10 +02:00
c9c8df1225
Bug 1459174 - Web Authentication - Use sha2 crate instead of rust-crypto for example/main r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1459174
Differential Revision: https://phabricator.services.mozilla.com/D1116
--HG--
extra : amend_source : bbd971da279930b9689dd282804f5f14e9d65991
2018-05-04 14:33:46 +02:00
c6c270b3f6
Bug 1459173 - Web Authentication - rustfmt u2f-hid-rs r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1459173
Differential Revision: https://phabricator.services.mozilla.com/D1115
--HG--
extra : amend_source : a23a6a2a00f31b8cb3b14c323917aec7b9a660b7
2018-05-04 14:28:20 +02:00
a1b2e5070a
Bug 1455885: Inline and make document casts fatally assert. r=bz
...
For consistency with AsElement / AsContent / AsDocumentFragment, etc.
MozReview-Commit-ID: 8GSj8R9hLBe
2018-04-26 17:05:12 +02:00
4643230674
Bug 1455055 part 6. Clean up HandleEvent implementations in dom. r=masayuki
...
MozReview-Commit-ID: Ht7HQEhVS8E
2018-04-20 00:49:30 -04:00
2b6097ae6d
Bug 1455055 part 1. Convert nsIDOMEventListener to taking an Event, not an nsIDOMEvent. r=masayuki
...
This does no cleanup other than what's needed to compile. Cleanup coming up in
later patches.
MozReview-Commit-ID: 3sOnkj71n09
2018-04-20 00:49:29 -04:00
219ed0cc06
Bug 1454813: Part 2b - Rename SpawnTask.js to AddTask.js. r=florian
...
The old name no longer makes sense, since it no longer exports an spawn_task
symbol, and add_task is what we really care about.
MozReview-Commit-ID: IE7B8Czv8DH
--HG--
rename : testing/mochitest/tests/SimpleTest/SpawnTask.js => testing/mochitest/tests/SimpleTest/AddTask.js
extra : rebase_source : 03bca5aa69a7625a49b4455a6c96ce4c59de3a5a
2018-04-18 11:43:45 -07:00
7a4b9a3f56
Merge mozilla-inbound to mozilla-central. a=merge
...
--HG--
extra : rebase_source : 66bd87105d99036ada5008499ff0eaea579b531a
2018-04-06 13:20:21 +03:00
1dce94cf16
Bug 1449631 part 2. Remove nsIDOMEventTarget::RemoveEventListener. r=smaug
...
We can't have a null content in
ScrollbarActivity::StopListeningForScrollAreaEvents, because only viewport
frames have a null GetContent().
MozReview-Commit-ID: 9iAg0ivVqqG
2018-04-05 13:42:40 -04:00
4aa522320e
Bug 1451825 - Update to env_logger 0.5. r=ted
...
MozReview-Commit-ID: CqKdONY1NMT
--HG--
extra : rebase_source : 29f9c7a40cf71847a6f5e5e3f33e8695e9bd0b64
2018-04-05 10:08:05 -07:00
61e9479fbb
Bug 1449034 - Update Rust crates to use lazy_static 1.0. r=ted
...
MozReview-Commit-ID: 4u4OQFBaURV
--HG--
extra : rebase_source : f7a4f89d275777a036ca08dad42b0a17e9c7eb8e
2018-03-26 15:12:56 -07:00
1adba8c1fc
Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao
2018-03-19 11:16:45 +09:00
dd4d724d5b
Bug 1444547 - Propagate proper error codes from u2f-hid-rs to WebAuthn r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1444547
Differential Revision: https://phabricator.services.mozilla.com/D717
2018-03-14 14:09:02 +01:00
141cb3849c
Bug 1444756 - Rewrite browser_webauthn_telemetry.js r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1444756
Differential Revision: https://phabricator.services.mozilla.com/D703
--HG--
extra : amend_source : 991801bfb48a6e3262c1d2a77c8734defae2406d
2018-03-13 08:16:52 +01:00
2bd0ff9c93
Bug 1430150 - Disable browser_webauthn_telemetry.js on TV runs for now r=bustage
2018-03-11 20:23:07 +01:00
6ded2cf370
Bug 1430150 - Implement WebAuthentication permission prompts r=jcj,johannh
...
Reviewers: jcj, johannh
Reviewed By: jcj, johannh
Bug #: 1430150
Differential Revision: https://phabricator.services.mozilla.com/D638
--HG--
rename : dom/webauthn/tests/cbor/cbor.js => dom/webauthn/tests/cbor.js
extra : amend_source : f137c2aebea5797cd07d4500cb71c2b9be4e4844
2018-03-11 18:47:14 +01:00
afe259f21f
Bug 1409202 - Web Authentication - Restrict to selected tabs in the active window r=jcj
...
Summary:
This patch restricts any calls to navigator.credentials.* methods to selected
tabs. Any active WebAuthn request will be aborted when the parent chrome
window loses focus, or the <browser> is backgrounded.
Reviewers: jcj
Reviewed By: jcj
Bug #: 1409202
Differential Revision: https://phabricator.services.mozilla.com/D688
--HG--
extra : amend_source : 112378a1ab2e883d7603e8a28ff3f8e944d57b5f
2018-03-10 06:43:20 +01:00
1fbdfd78ef
Bug 1444097 - Clean up env_logger dependencies. r=ted
...
For the "js" crate, disable the "regex" feature to reduce binary size.
For the "u2fhid" crate, it's used only in examples. Make it a dev-dependency
so it won't be part of the Firefox build.
MozReview-Commit-ID: DY9indMqrRw
--HG--
extra : rebase_source : aa66fe1effaeca0ae35ec5dd20b33724eb3fac48
2018-03-08 07:35:11 -08:00
54c488c132
Bug 1443248 - Update u2fhid to core-foundation-sys 0.5. r=ttaubert
...
MozReview-Commit-ID: 4xTSQpvHHAV
--HG--
extra : rebase_source : 9f6234a05ab1b8a0bc47482a2a745edfa0bd2f68
2018-03-05 11:13:13 -08:00
789cd3bd6f
Bug 1442557 - [u2f-hid-rs] Keep polling excluded devices when creating credentials r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1442557
Differential Revision: https://phabricator.services.mozilla.com/D670
--HG--
extra : amend_source : 95eb9f67cd6308cb9be6be2b6f520a7d20fb2516
2018-03-02 16:03:33 +01:00
3879951466
Bug 1442562 - Sync u2f-hid-rs rustfmt changes r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1442562
Differential Revision: https://phabricator.services.mozilla.com/D669
2018-03-02 16:00:58 +01:00
612a195ccf
Bug 1439856 - U2FTokenTransport interface should use WebAuthn*Info types defined in the .pidl r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1439856
Differential Revision: https://phabricator.services.mozilla.com/D625
2018-02-22 22:09:00 +01:00
0af61da4ec
Bug 1406471 - Web Authentication - Implement FIDO AppID Extension r=jcj,smaug
...
Reviewers: jcj, smaug
Reviewed By: jcj
Bug #: 1406471
Differential Revision: https://phabricator.services.mozilla.com/D595
2018-02-22 10:53:49 +01:00
3e79498113
Bug 1439326 - Add U2FTokenTransport::Drop() to better handle U2FHIDTokenManager destruction r=jcj
2018-02-19 12:45:43 +01:00
8e5d9a4b24
Bug 1437616 - Fix more Windows bustage on a CLOSED TREE r=me
2018-02-12 22:09:38 +01:00
bc18da5fe7
Bug 1437616 - Use proper WebAuthn result types defined in the .pidl r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1437616
Differential Revision: https://phabricator.services.mozilla.com/D582
2018-02-12 21:08:54 +01:00
7cd0f0b36c
Bug 1437487 - [u2f-hid-rs] Allow passing an empty key handles list r=jcj
...
Reviewers: jcj
Reviewed By: jcj
Bug #: 1437487https://phabricator.services.mozilla.com/D580
2018-02-12 16:02:43 +01:00
J.C. Jones
Gurzau Raul
Andrew McCreight
Dana Keeler
arthur.iakab
Brian Grinstead
Andrea Marchesini
Franziskus Kiefer
Jan de Mooij
Jeff Gilbert
Greg V
Andreea Pavel
Emilio Cobos Álvarez
Tim Taubert
Boris Zbarsky
Kris Maglione
Matt Brubeck
Tooru Fujisawa