Граф коммитов

688650 Коммитов

Автор SHA1 Сообщение Дата
Mirko Brodesser 99856824e5 Bug 1609662: part 12) Replace unreachable code with assertions in `Selection::AddRangeAndSelectFramesAndNotifyListeners`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D60227

--HG--
extra : moz-landing-system : lando
2020-01-21 16:01:52 +00:00
Mirko Brodesser ab604ca294 Bug 1609662: part 11) Rename `nsTextFrame::SetSelectedRange` and add `nsIFrame::SelectionStateChanged`. r=emilio,smaug
Differential Revision: https://phabricator.services.mozilla.com/D60157

--HG--
extra : moz-landing-system : lando
2020-01-21 16:01:45 +00:00
Jan Horak 10ddd6b106 Bug 1609732 Ignore window position in the WindowSurfaceWayland::Lock; r=stransky
The window position of the popup can be changed which does not mean that the
screen size changed. Only window dimmensions are relevant there. Also as part of this
fix, don't use HideWaylandWindow when calling gdk_window_move_to_rect because it removes
the popup from gVisibleWaylandPopupWindows which breaks popup hierarchy sometimes.

Differential Revision: https://phabricator.services.mozilla.com/D60419

--HG--
extra : moz-landing-system : lando
2020-01-21 15:46:23 +00:00
Alex Chronopoulos cf314b852f Bug 1610527 - Update cubeb from upstream to 6cdf2fd. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D60518

--HG--
extra : moz-landing-system : lando
2020-01-21 15:32:54 +00:00
Alex Chronopoulos d46188be61 Bug 1610527 - Remove unnecessary patches from import script. r=padenot
`disable-assert.patch` is nor needed because the change has been merged upstream.
`revert-optimization.patch` is not needed because we want to undo the revert since this import attemptts to fix the crash.

Differential Revision: https://phabricator.services.mozilla.com/D60517

--HG--
extra : moz-landing-system : lando
2020-01-21 15:33:02 +00:00
Johann Hofmann bfb55452df Bug 1607499 - Remove the contentblocking.exceptions probe. r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D60492

--HG--
extra : moz-landing-system : lando
2020-01-21 15:35:39 +00:00
Andreea Pavel bd998e0112 Backed out changeset 4639d83e5871 (bug 1507055) for causing the crash in bug 1610485 a=backout
--HG--
extra : amend_source : 8cf2f5ccf0dc884c0d2ccdc3f1c48b3b5e014e1e
2020-01-21 16:46:22 +02:00
shindli 68d14ea795 Backed out changeset 25964226853a (bug 1607204) for causing bug 1610471 which crashes the reviewbot a=backout CLOSED TREE 2020-01-21 15:40:45 +02:00
Sid Vishnoi 6cb1f49f29 Bug 1604688 - Use null for empty slots in Array grip preview. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D60171

--HG--
extra : moz-landing-system : lando
2020-01-21 13:16:04 +00:00
Masayuki Nakano 6ea35a12b9 Bug 1606232 - Make `nsIHTMLEditor::GetSelectedElement()` check whether the found element is followed by `<br>` element deeper r=m_kato
Current `nsIHTMLEditor::GetSelectedElement()` just checks whether the
found element is followed by `<br>` element or not.  However, following
element may start with `<br>` element and if there is end of the range,
`PostContentIterator` does not list up the `<br>` element.

Therefore, it should check whether the found element is followed by
`<br>` element which is starts the next sibling element too.

Differential Revision: https://phabricator.services.mozilla.com/D60385

--HG--
extra : moz-landing-system : lando
2020-01-21 08:16:03 +00:00
Cosmin Sabou 6975d37d43 Bug 1387827 - Delete skip line for browser_browser_toolbox.js and browser_browser_toolbox_fission_inspector.js as they are green on ccov. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D60393

--HG--
extra : moz-landing-system : lando
2020-01-21 11:09:40 +00:00
Boris Zbarsky df14f47c89 Bug 1610422 part 4. Reinstate the changes from bug 1609859 to RTCPeerConnection-createDataChannel.html. r=jgraham
This just reapplies the changes, with some context edits because the whitespace changed.

Differential Revision: https://phabricator.services.mozilla.com/D60471

--HG--
extra : moz-landing-system : lando
2020-01-21 11:17:39 +00:00
Boris Zbarsky af5251e666 Bug 1610422 part 3. Pull in the missing upstream changes for RTCPeerConnection-createDataChannel.html. r=jgraham
The changes are as follows:

1) Add an id (and a change in the test label) in the test that now ends up
reading:

  const channel = pc.createDataChannel('', { negotiated: true, id: 42 });

2) Add some whitespace bits.
3) Removes a bogus test (thus fixing bug 1550497).  The test is bogus because
   `null` converts to 0 when converting to `unsigned short`, and that's a
   perfectly valid id value.

Compared to upstream, that leaves the following local changes:

* Tests for the "id in the unsigned short range, maybe invalid, but
  'negotiated' not set" case.
* A clarification for one of the test descriptions.
* Tests for the "id out of the unsigned short range" case.

These changes are upstreamed in https://github.com/web-platform-tests/wpt/pull/21285

Differential Revision: https://phabricator.services.mozilla.com/D60472

--HG--
extra : moz-landing-system : lando
2020-01-21 11:17:11 +00:00
Boris Zbarsky 563e26b4d2 Bug 1610422 part 2. Revert the bug 1609859 canges to RTCPeerConnection-createDataChannel.html. r=jgraham
This is a clean revert of the changes bug 1609859 made to
RTCPeerConnection-createDataChannel.html.  It's separated out for review ease;
these changes are reinstated 2 changesets later.

Differential Revision: https://phabricator.services.mozilla.com/D60470

--HG--
extra : moz-landing-system : lando
2020-01-21 11:16:59 +00:00
Boris Zbarsky 5f84a2e9df Bug 1610422 part 1. Pull in missing upstream changes for RTCPeerConnection-ondatachannel.html. r=jgraham
It looks like most of the changes from
https://github.com/web-platform-tests/wpt/pull/16038 we have already, except
some whitespace bits.

Differential Revision: https://phabricator.services.mozilla.com/D60469

--HG--
extra : moz-landing-system : lando
2020-01-21 11:16:41 +00:00
shindli 12ffabd93a Backed out changeset 093a40a347df (bug 1597742) for causing perma a11y failures in test_scrollSubstringToPoint.html CLOSED TREE 2020-01-21 12:35:23 +02:00
Andrew Osmond da3cf4fd77 Bug 1610381 - Improve image memory reporting for missing/incomplete surfaces. r=tnikkel
This dumps more information about the surface cache. Each surface has a
flag indicating whether or not it has finished decoding; incomplete
surfaces are now marked as such in the cache reports. We now also have
counters for various insertion errors, as well as the composition of the
cache (total vs locked images, total vs locked surfaces).

Differential Revision: https://phabricator.services.mozilla.com/D60450

--HG--
extra : moz-landing-system : lando
2020-01-21 09:59:15 +00:00
Jan-Erik Rediger 12faa0feec Bug 1610282 - Update glean-preview to include reset-data bugfix. r=chutten
The update includes:

* Upgraded glean-core dependency
    * See full Glean changelog: https://github.com/mozilla/glean/blob/v24.0.0/CHANGELOG.md
* Reset core client metrics when re-enabling upload (https://github.com/mozilla/glean/pull/620)

Updates the glean-preview dependency in toolkit/components/telemetry/fog/Cargo.toml.
glea

Rest is updated with:

    cargo update -p gkrust-shared
    mach vendor rust

Differential Revision: https://phabricator.services.mozilla.com/D60406

--HG--
extra : moz-landing-system : lando
2020-01-21 10:20:42 +00:00
Jonathan Kew 083ae19512 Bug 1293584 - Fix implementation of word-break:keep-all to better follow the spec. r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D60275

--HG--
extra : moz-landing-system : lando
2020-01-21 08:02:20 +00:00
Jonathan Kew 4cd64f80ed Bug 1608100 - Distinguish (in console log messages) between failure to start font download at all vs download that fails. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D59328

--HG--
extra : moz-landing-system : lando
2020-01-21 08:40:12 +00:00
Michal Novotny 7c7d2abfab Bug 1607224 - Data race on CacheFileHandle::mFileSize r=valentin
This patch fixes data race on CacheFileHandle::mFileSize when accessed on main thread by nsHttpChannel::ReportNetVSCacheTelemetry(). All other usages are on cache I/O thread.

Differential Revision: https://phabricator.services.mozilla.com/D60407

--HG--
extra : moz-landing-system : lando
2020-01-21 09:48:11 +00:00
Eric Rahm cfd1cc461f Bug 1610388 - Remove nsAutoPtr usage from gfx/. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D60456

--HG--
extra : moz-landing-system : lando
2020-01-21 01:25:28 +00:00
Toshihito Kikuchi a172471711 Bug 1608645 - Ensure FindExportAddressTableEntry can handle a modified Export Table. r=aklotz
A third-party application can modify the export directory, the export address/name/ordinal
tables, or an entry in those tables.  If that happens, we will see an RVA is located outside
the mapped image and `RVAToPtr` returns null.  This patch makes sure we don't hit null AV
when modification is detected.

`FindExportAddressTableEntry` should not return a pointer to the modified table entry because
we dereference it in another process to cross-process detour.

Differential Revision: https://phabricator.services.mozilla.com/D59738

--HG--
extra : moz-landing-system : lando
2020-01-21 00:44:28 +00:00
Liang-Heng Chen ca2c937269 Bug 1597726 - use storage principal to generate origin key; r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D60350

--HG--
extra : moz-landing-system : lando
2020-01-20 19:58:24 +00:00
Sylvestre Ledru 187e9bafaf Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D60354

--HG--
extra : moz-landing-system : lando
2020-01-21 09:51:27 +00:00
Julian Descottes 8726edbce5 Bug 1609199 - Add RDM test browser_picker_link.js r=mtigley
Depends on D60295

Differential Revision: https://phabricator.services.mozilla.com/D60296

--HG--
extra : moz-landing-system : lando
2020-01-21 09:49:51 +00:00
Julian Descottes 62d3c2a016 Bug 1609199 - Track picker types independantly in devtools touch-simulator.js r=mtigley
Depends on D60294

Differential Revision: https://phabricator.services.mozilla.com/D60295

--HG--
extra : moz-landing-system : lando
2020-01-20 19:29:55 +00:00
Julian Descottes 61db533b46 Bug 1609199 - Remove Emulation Actor r=mtigley
We still need the front and the spec files to talk to older servers.
However we don't maintain forward compatibility, which means the server is not supposed to work with older clients.
So the emulation actor can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60294

--HG--
extra : moz-landing-system : lando
2020-01-20 20:00:18 +00:00
James Teh 4422d3b762 Bug 1597742: Add tests for HyperTextAccessible::ScrollSubstringToPoint. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D60207

--HG--
extra : moz-landing-system : lando
2020-01-21 09:49:10 +00:00
Florin Strugariu 007caefd70 Bug 1609392 - Split Raptor and Browsertime classes from raptor.py r=tarek,AlexandruIonescu,octavian_negru,sparky,perftest-reviewers,alexandru.irimovici
Differential Revision: https://phabricator.services.mozilla.com/D60028

--HG--
rename : testing/raptor/raptor/raptor.py => testing/raptor/raptor/webextension/base.py
extra : moz-landing-system : lando
2020-01-21 09:07:19 +00:00
Alex Chronopoulos 53c369d992 Bug 1608877 - Ignore async transmission start if a new stop has arrived. r=padenot
In `MediaPipelineTransmit::SetTrack()` when a track of different MTG is replaced, the transmission is stopped and restarted asynchronously. This can create a problem if a new stop has arrived in the meantime. The transmission should not be restarted in that case.

This change adds a boolean, to check when an asynchronous start is expected and ignores it if not needed.

Differential Revision: https://phabricator.services.mozilla.com/D59750

--HG--
extra : moz-landing-system : lando
2020-01-21 09:23:43 +00:00
Simon Giesecke 3f5316df28 Bug 1609943 - Improved section on comparison against true/false, and added note on clang-tidy check. r=sylvestre
Depends on D60281

Differential Revision: https://phabricator.services.mozilla.com/D60282

--HG--
extra : moz-landing-system : lando
2020-01-20 12:37:31 +00:00
Simon Giesecke 3e22e77cc5 Bug 1609943 - Merged two mentions of naming nsresult error variables, and improved wording a bit. r=sylvestre
Depends on D60273

Differential Revision: https://phabricator.services.mozilla.com/D60281

--HG--
extra : moz-landing-system : lando
2020-01-18 12:04:36 +00:00
Simon Giesecke 3da8e73cda Bug 1609943 - Move static analysis to its own section, and add notes on a few more clang-tidy checks. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60273

--HG--
extra : moz-landing-system : lando
2020-01-20 12:37:21 +00:00
Simon Giesecke e9e7a0258f Bug 1609943 - Move all string-related rules into one section. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60264

--HG--
extra : moz-landing-system : lando
2020-01-20 10:17:20 +00:00
Simon Giesecke 843989bf9a Bug 1609943 - Refer to UpperCamelCase to remove ambiguity. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60263

--HG--
extra : moz-landing-system : lando
2020-01-18 12:02:39 +00:00
Simon Giesecke 34cd11297e Bug 1609943 - Move mode line section from C++ to general coding style. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60262

--HG--
extra : moz-landing-system : lando
2020-01-18 11:43:19 +00:00
Simon Giesecke 615906c9b7 Bug 1609943 - Split guideline on unary operators into C++ and JavaScript part. r=sylvestre
C++: Remove reference to JavaScript typeof from 'Operators' section and specifically refer to sizeof only.

JavaScript: Added remainder of the guideline referring to typeof.

Differential Revision: https://phabricator.services.mozilla.com/D60261

--HG--
extra : moz-landing-system : lando
2020-01-21 08:19:55 +00:00
Simon Giesecke dfc0fdd507 Bug 1609943 - Cleanup in-line code fragments to use proper encapsulation. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60260

--HG--
extra : moz-landing-system : lando
2020-01-17 15:51:35 +00:00
Nihanth Subramanya dde23c4501 Bug 1609037 - DoH Rollout Extension: Wait until a top-level location change to show the doorhanger. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D59833

--HG--
extra : moz-landing-system : lando
2020-01-21 08:28:25 +00:00
Nihanth Subramanya 7dc0b07882 Bug 1608320 - DoH Rollout Extension: Don't show the doorhanger if the user has seen the post-DoH privacy statement. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D59830

--HG--
extra : moz-landing-system : lando
2020-01-21 08:22:03 +00:00
Nihanth Subramanya 0d2a8199d0 Bug 1600109 - Fix network change handling and test telemetry. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D58196

--HG--
extra : moz-landing-system : lando
2020-01-21 08:22:01 +00:00
Nihanth Subramanya eee7b4fa3c Bug 1600109 - Implement setup function in head.js to set up prefs and telemetry, and call it in all tests. r=dragana,JuniorHsu
Differential Revision: https://phabricator.services.mozilla.com/D58195

--HG--
extra : moz-landing-system : lando
2020-01-21 08:21:59 +00:00
Makoto Kato 452a87b7b0 Bug 1574307 - Part 4. Notify GV of viewport-fit. r=geckoview-reviewers,snorp
`viewport-fit` is hint that browser application can use cutout area. So we should expose it to GeckoView application to set `layoutInDisplayCutoutMode`.

When meta element is found or changed, `ContentDelegate.onMetaviewportFitChange` is called. Even if nothing, it will be called after DOMContentLoaded is fired.

Depends on D57398

Differential Revision: https://phabricator.services.mozilla.com/D55610

--HG--
extra : moz-landing-system : lando
2020-01-20 08:42:05 +00:00
Makoto Kato 7b3ef75994 Bug 1574307 - Part 3. Dispatch DOMMetaViewportFitChanged when viewport-fit is changed. r=smaug,hiro
Actually, we have `DOMMeta*` event for modifying meta element. But GeckoView wants viewport-fit change only.

@hiro suggests new event that is fired by viewport-fit will be changed. This event doesn't need current viewport-fit value since GeckoView doesn't need current value immediately.

Depends on D57397

Differential Revision: https://phabricator.services.mozilla.com/D57398

--HG--
extra : moz-landing-system : lando
2020-01-20 08:41:05 +00:00
Makoto Kato 163a589174 Bug 1574307 - Part 2. Add nsIDOMWindowUtils.getViewportFitInfo r=smaug
Per discussing with @hiro, we should add new method to get viewport-fit
instead of adding parameter of `nsIDOMWindowUtils.getViewportInfo`.

Depends on D55609

Differential Revision: https://phabricator.services.mozilla.com/D57397

--HG--
extra : moz-landing-system : lando
2020-01-20 08:40:20 +00:00
Makoto Kato a94e918a29 Bug 1574307 - Part 1. Parse viewport-fit in meta element. r=smaug
For safe area insets (cutout) support, CSS Round Display Level 1 (https://drafts.csswg.org/css-round-display/#viewport-fit-descriptor) has new viewport value as `viewport-fit`.

To support safe area insets that is notch on display, CSS Environment Variables Module Level 1 (https://drafts.csswg.org/css-env-1/#safe-area-insets) adds `safearea-insets-*` (left, top, right and bottom). Also, `meta` element has `viewport-fit` enum value. (ex `<meta name="viewport" content="viewport-fit=cover>`) whether web browser window cover notch area.

`viewport-fit` has 3 enum value, `auto`, `cover` and `contain`.  GeckoView wants to expose this value to browser application such Fenix. Because Android API (https://developer.android.com/guide/topics/display-cutout) uses window root layout (It is set by Application) to cover notch on display.

Differential Revision: https://phabricator.services.mozilla.com/D55609

--HG--
extra : moz-landing-system : lando
2020-01-20 08:40:05 +00:00
Tarek Ziadé 600d034817 Bug 1568092 - don't ignore tooltool_download() exit code and add a retry r=AlexandruIonescu,Bebe
This patch will check the exit code of the ProcessHandler() that
calls the tooltool script, and will also retry when it fails.

Differential Revision: https://phabricator.services.mozilla.com/D60397

--HG--
extra : moz-landing-system : lando
2020-01-21 07:17:05 +00:00
Mike Hommey 62778417a2 Bug 1609862 - Display more detailed memory info in resource usage report. r=froydnj
Instead of showing percentages, show actual numbers for memory usage,
with caveats:
- On macOS, psutil doesn't seem to be getting anything that would sum up
to the total it reports, so we keep the "percent".
- While the sum of all the fields shown on Linux does sum up to the total,
the visible usage doesn't quite match what the "percent" look like for
the same dataset.
- On Windows, only "used" and "free" are available. They do sum up to
the total.

Differential Revision: https://phabricator.services.mozilla.com/D60226

--HG--
extra : moz-landing-system : lando
2020-01-17 13:25:23 +00:00
Mike Hommey 7bc320e0e3 Bug 1609832 - Install rustfmt when running mach bootstrap. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60213

--HG--
extra : moz-landing-system : lando
2020-01-17 14:45:12 +00:00