76e3cc1538
Bugzilla bug 90906: removed unused variable 'size'. The patch is from
...
Serge GAUTHERIE <gautheri@noos.fr>. r=wtc.
2004-04-21 18:57:51 +00:00
8b8dde7d95
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 22:01:16 +00:00
b2f4a8b199
move cert details code: bug 230655 r=ddrinan sr=jag
2004-04-18 21:20:31 +00:00
642f7ede36
deCOMtaminate nsIScriptObjectPrincipal (bug 240745). This also fixes some code in nsCrypto.cpp that sems to have been mis-braced (I don't think it was working as intended). r+sr=jst.
2004-04-18 00:28:47 +00:00
2cd056deb1
Fix for bug 221619. Tree widget refactoring and enhancement. r=neil sr=bryner
2004-04-17 05:53:38 +00:00
a196934eb6
Bug 240256 Fixing DOCTYPE to match document element p=vberon@mecano.gme.usherb.ca r=me sr=mscott
2004-04-13 09:34:47 +00:00
a69d43c721
Bug 237844 nsSecureBrowserUIImpl::~nsSecureBrowserUIImpl doesn't need to removeObserver
...
r=jgmyers sr=alecf
2004-04-13 05:16:05 +00:00
50d65e5e71
Check trust bits before examining cert fields when classifying certs: bug 178692 r=ssauxh sr=brendan a=asa
2004-04-11 21:03:05 +00:00
542f76a15a
Change ssl test scripts to invoke tstclnt with the server's FQDN.
...
Necessary because of fix to bug 234058.
2004-04-08 03:01:02 +00:00
abe92ad094
Remove code that attempted to compare simple host names in URLs with
...
FQDNs in certificate host names. This was insecure. Bug 234058. r=wtc.
2004-04-08 00:17:46 +00:00
e4ab49876e
Fix missing indexes when fetching lengths (get tinderbox working again).
2004-04-07 19:00:08 +00:00
66be1e00e1
Bug 239827: Fix race condition in unwrap private key (if target key is symetric).
2004-04-07 01:18:46 +00:00
77bd494c63
Bug 238914. r=wchang sr=misterSSL
...
Agressive checks on database data before we actually reference it. This
should prevent crashes because of invalid databases.
2004-04-07 00:58:58 +00:00
a032d5bd44
Bugzilla bug 238565: made the comment match the code. r=nelsonb.
2004-03-27 01:51:25 +00:00
ec68ee33b1
Bugzilla bug 237934: in nss_InitLock, nss_InitMonitor, and
...
NSSRWLock_AtomicCreate, we need to doublecheck the lock/monitor's pointer
after we acquired the spin lock. r=nelsonb,jpierre.
Modified Files: nsslocks.c nssrwlk.c
2004-03-27 01:08:15 +00:00
c0104f0a69
Correct the parsing of certain forms of GeneralName. Bug 233586.
...
r=julien.pierre
2004-03-26 01:15:33 +00:00
7747aca85b
Use the brute force method to override NSS build variables when cross-compiling.
...
Bug #172651 r=darin a=chofmann
2004-03-23 04:15:56 +00:00
dade383614
Fix a regression introduced by rev 1.19, after NSS 3.9 was released.
...
r=julien.pierre. bugscape 56484.
2004-03-23 03:29:56 +00:00
8ebba422fc
Bugzilla bug 237870: link the MinGW build with wsock32.dll (Winsock 1)
...
instead of ws2_32.dll (Winsock 2). Thanks to neil@parkwaycc.co.uk for the
patch. r=wtc.
2004-03-23 01:59:40 +00:00
f06aa9e47c
Bugzilla bug 172651: added a necessary test for MinGW gcc in rules.mk.
...
Do not install 'nsinstall' to avoid overwriting Mozilla's 'nsinstall'.
r=cls.
Modified Files:
rules.mk nsinstall/Makefile
2004-03-23 00:54:36 +00:00
d5abab03d4
Program to decrypt passwords inline from prefs files
2004-03-23 00:46:38 +00:00
70a5776e59
Fix arrays handling strings, and help
2004-03-13 02:44:26 +00:00
b391292c65
Remove unused file
2004-03-11 10:03:24 +00:00
bd1e342f9d
It is not necessary to define _THREAD_SAFE when using pthreads on OpenBSD.
...
(See Bugzilla bug 236599 comment 41).
2004-03-11 02:26:25 +00:00
c1e600678f
enhance certificate categorization: bug 193960 r=ssaux/nelsonb sr=brendan
2004-03-10 07:36:50 +00:00
ca499f96dc
Clean up TLS intolerant restart code: but 191417 p=darin r=kaie sr=bryner
2004-03-10 05:28:39 +00:00
9383b61a6e
Fix for bug 143456 - add -P option for dbprefix to selfserv . r=MisterSSL
2004-03-10 02:47:13 +00:00
558c81f9af
Improve dup serno error message: bug 219980 r=ssaux
2004-03-09 02:21:37 +00:00
89953530a6
Remove stray semicolon.
2004-03-06 17:34:12 +00:00
8e81f7982b
Bustage fix.
2004-03-06 17:22:13 +00:00
545ad9d0ad
Fix for bug 29152 (Cannot do formsigning - crypto.signText). r=kaie, sr=jst.
2004-03-06 15:52:44 +00:00
b621053e6f
Make KEYGEN tag treat KEYTYPE value case insensitively: bug 139473 r=ddrinan sr=jag
2004-03-06 05:41:38 +00:00
c4b2be519c
Add conditionally compiled code for NISCC testing of NSS's SSL library.
...
patch by Ian McGreer. Bugscape bug 53322.
2004-03-05 23:28:57 +00:00
084d164f2e
make two strings localizable bug 178881 r=ssaux sr=blizzard
2004-03-05 05:42:45 +00:00
954ce8f4e0
backout prev checkin
2004-03-05 05:41:45 +00:00
ddaa1c387e
make two strings localizable bug 178881 r=ssaux sr=blizzard
2004-03-05 05:38:58 +00:00
195f404925
adding platform RH_Linux_7.3
2004-03-04 22:47:43 +00:00
fa54334072
adjusting the platform strings as the header file specifies
2004-03-04 20:16:36 +00:00
1dc25eb335
remove 512-bit keygen bug 235972 r=ssaux sr=bienvenu
2004-03-04 07:09:02 +00:00
5f21e877ae
removed old,unused platforms; and added newer used ones
2004-03-04 00:35:09 +00:00
f1a9128ad1
Fix for 235874 - crash in PK11_DigestKey . r=wtc, nelsonb
2004-03-03 03:18:56 +00:00
c380c59f65
landing dbaron's patch for bug 235735 "fix callers that cast away const on result of ns[C]String::get" r+sr=darin
2004-02-28 22:34:07 +00:00
1d17b9b549
fix cert tree view corruption: bug 217082 p=dewildt r=ssaux sr=sspitzer
2004-02-27 03:13:26 +00:00
2c3a905fd4
Clean up string stuff: bug 232812 r=ssaux sr=jag
2004-02-26 04:07:23 +00:00
a74bbe4b09
Detect NULL arguments to CERT_DecodeTrustString instead of crashing.
...
Bug 235617. r=wtc.
2004-02-26 00:05:29 +00:00
c93fcbd840
fix for Bugzilla bug 232481: removed a loop in smime.sh
2004-02-25 23:05:41 +00:00
c0e6a51ba4
added negative cert import function, changed relevant Policies tests accordingly
2004-02-25 22:34:25 +00:00
8d65e087ae
landing string defragmentation patch for bug 231995, r/sr=dbaron,jst,dougt
2004-02-19 02:44:03 +00:00
7debba55ce
Import base64 encoded certificate files with old MAC line endings.
...
Bug 221272. sr=wtc.
2004-02-16 23:52:46 +00:00
46de977590
Removed unused function _OS_SELECT for AIX. Thanks to Philip K. Warren
...
<pkw@us.ibm.com> for reporting this.
2004-02-13 03:13:04 +00:00
d384e9659d
Bugzilla bug 233048: 1. Support doing 64-bit Solaris SPARC builds using
...
gcc. 2. Enable all.sh to work with gcc-compiled NSS tests which require
setting LD_LIBRARY_PATH to point to the directory where libgcc.so resides.
The patch is contributed by Vladim�r Marek <Vladimir.Marek@printsoft.cz>.
r=wtc,nelsonb.
Modified Files: coreconf/SunOS5.mk nss/tests/common/init.sh
2004-02-13 02:47:53 +00:00
42b100808b
Fix strings in SECU_PrintError. bug 233493
2004-02-12 02:08:59 +00:00
43586b3b97
Bugzilla bug 229297: fixed compiler warning "conversion from 'double' to
...
'long', possible loss of data". r=jpierre,relyea.
2004-02-11 19:43:29 +00:00
9d027a18fc
Bugzilla bug 229293: fixed compiler warning "unary minus operator applied
...
to unsigned type". r=relyea,jpierre.
2004-02-11 19:37:18 +00:00
2703a27453
Fix for bug 233605 . Check CRL entry extensions after partial decoding. Also add some new CRL decoding errors. r=nelsonb
2004-02-11 06:05:18 +00:00
560beb63f1
Fix for 233493 . Corrections based on Wan-Teh's feedback.
2004-02-11 05:27:32 +00:00
3f92bc7c25
Fix for 233118 . additional check for CRL signing usage. r=nelsonb
2004-02-11 05:25:01 +00:00
02b77934ff
Bugzilla bug 232742: support Linux/AMD64. The patch is contributed by
...
Henrik Lynggaard Hansen <admin@mozillatranslator.org>. r=wtc.
2004-02-11 02:31:22 +00:00
f8b0c1845d
Bugzilla bug 233321: fixed the problem with building utf8.c as a standalone
...
test program. Fixed byte-order issue on little-endian architecture.
r=nelsonb.
Modified Files: Makefile utf8.c
2004-02-11 02:17:24 +00:00
829b7f1122
checking in 5 sections of Certificate Policies. Need to set
...
NSS_NO_PKITS_POLICIES to run these five sections
2004-02-11 01:31:43 +00:00
13dcfd3e4c
Fix for 233493 - fix symkeyutil build on OS/2. r=relyea
2004-02-10 23:48:37 +00:00
e9572b0dff
removing dependency of a testcase on a previous testcase; i.e. each testcase
...
now imports all the CRLs required for it, and then deletes them at the end
of the test
2004-02-09 23:33:26 +00:00
505c634885
Fixing bug 233307. deCOMtaminating nsIScript* and related interfaces. r+sr=bryner@brianryner.com.
2004-02-09 22:48:53 +00:00
bab3c2af5e
Bugzilla bug 233319: prepend, rather than append, the NSS lib and bin
...
directories to PATH. r=relyea.
2004-02-09 22:39:11 +00:00
c3a3521876
Enable a chain to validate when a perm cert has been issued by a
...
temp cert. Bug 233038. r=ian,relyea
2004-02-07 07:17:31 +00:00
bf2c5e5f16
Bugzilla bug 225808: 1. Use a 32-bit integer type for cert->nsCertType so
...
that it can be safely passed to PR_AtomicSet on all platforms. Note that
we still use an unsigned type to avoid introducing signed/unsigned compiler
warnings. 2. Added a (PRInt32 *) cast to eliminate a pre-existing
signed/unsigned warning. r=nelsonb.
Modified Files: certdb.c certt.h
2004-02-07 01:41:15 +00:00
5c995a5d18
Bugzilla bug 233239: do not include cmd/zlib and cmd/lib headers and
...
libraries in NSS binary releases.
Modified Files:
lib/Makefile lib/manifest.mn makepqg/manifest.mn zlib/Makefile
zlib/manifest.mn
2004-02-07 00:26:02 +00:00
91ad07e7f5
Bugzilla bug 123693: improved the fix for this bug. Maintain the
...
consistency between the slot hash table and slot list when the
creation of a slot fails. r=relyea,nelsonb.
2004-02-06 02:04:48 +00:00
ce288b37c7
Bugzilla bug 233112: fixed a typo: "futuer" -> "future". Thanks to
...
Heikki Toivonen <hjtoi-bugzilla@comcast.net> for the bug report.
2004-02-05 05:56:54 +00:00
03643e5f7d
added a few more missing $ for variable PKITSdb for more accurate log reporting
...
also, minor optimization of crlImport and crlImportn script so that $crls does
not have to be specified on every line
2004-02-04 20:04:14 +00:00
3d12a17e05
bug 232011 - Use the XUL preprocessor for build-time inserting of localeVersion strings, this removes contents*.rdf.in files and resurrects the contents*.rdf files, using preprocessor.pl via the jar.mn definitions
2004-02-04 14:24:38 +00:00
a00bb096af
Fix numerous bugs in CERT_FindCertByKeyID. Bug 233019. r=jpierre
2004-02-04 08:54:06 +00:00
4fbee089ca
Add a feature to disable all use of CRLs with an environment variable.
...
Don't run most vfychain commands after crlutil fails to import the CRL,
when that is the expected result.
Remove one error that caused the HTML output to be invalid.
2004-02-04 04:07:32 +00:00
c381ec2657
Put in missing $, so log output will show actual commands exeuted.
2004-02-04 02:23:40 +00:00
971bc18c70
correcting header of section 4.1, minor edits to make headers more definitive
2004-02-03 20:13:26 +00:00
1e6ed08cc8
Fix some incorrect string usage and improve performance in a few places that show up in an LXR search for the previous pattern. b=232339 r=jshin sr=darin
2004-02-03 18:23:41 +00:00
3462419c4d
Invoke crlImportn instead of crlImport in several places where a
...
negative outcome is expected. More work on this is needed.
crlImportN should return a value that tells us if it actually failed,
so that the script can decide whether or not to proceed with vfychain.
But this change makes the outcome more green, less red.
2004-02-03 07:14:52 +00:00
bcc309b891
Honor key usage extensions, whether they're critical or not.
...
Bug 232738. r=jpiperre.
2004-02-03 07:10:04 +00:00
3f581fae9e
Max crlutil return 0 or 1 correctly, depending on the success of the
...
operation. Bug 232937. r=jpierre.
2004-02-03 06:59:35 +00:00
0789875d7d
Change script so that html output and logfile will be broken up into
...
clearly defined and easy-to-find sections.
2004-02-03 04:15:08 +00:00
abc134f1c0
Make output log file more readable by separating each test case.
2004-02-03 03:07:38 +00:00
3ed803969c
fixed one typo
2004-02-03 01:27:47 +00:00
d95cb37ea2
checking with all latest revew comments addressed
2004-02-03 00:59:53 +00:00
521d560df7
Bug 232186 Remove deprecated nsIPref usage from PKI chrome moa=kaie r=caillon sr=brendan
2004-01-31 21:11:27 +00:00
10b8ef3a20
Extend set of OIDs mapped to text: bug 97406 r=kaie sr=spitzer
2004-01-31 07:10:35 +00:00
328311b1d2
Don't use strcmp() on UTF-16: bug 154121 r=kaie sr=sspitzer
2004-01-31 07:09:21 +00:00
3dcf7f696e
When an attempt to initialize a slot fails, free up the resources
...
right away, rather than waiting until NSS_Shutdown. Bug 123693.
Second try. r=relyea.
2004-01-30 04:15:47 +00:00
df07bc6cf4
Back out rev 1.90. It breaks shlibsign.
2004-01-29 23:34:21 +00:00
371b9d618e
Export SECOID_AddEntry. Bug 132942. r=wtc.
2004-01-29 22:51:55 +00:00
50f63ee713
Invoke SECU_RegisterDynamicOids() so that more OIDs will print out.
...
Bug 132942. a=wtc.
2004-01-29 22:48:58 +00:00
792e8d1e9e
Bug 132942. r=wtc
...
Make the following enhancements to NSS's ASN.1 printing code:
- Print warning messages that are properly indendented.
- PrintAsHex notices when the buffer contains entirely printable characters, and is larger than an int, and prints it as text in that case.
- PrintRawString now indents the string, rather than always printing it on
a separate line.
- now prints decoded bit strings
- now prints BMP (UCS2) strings as strings (not as hex) when they contain only printable ASCII characters.
- now prints Universal (UCS4) Strings as strings (not hex) when they contain only printable ASCII characters.
- Decodes certain encoded data that was previously printed as hex.
- Generically decodes ASN.1 data, rather than merely printing an error, when the ASN.1 data doesn't fit a known template.
- properly handles all optional components of basic constraints extensions.
- Prints the names of the bits in the X509 Key Usage extension.
- Prints General Names.
- Print Auth Key ID extensions
- Print subject and issuer alt name extensions
- Print CRL distribution points extensions
- format and print name constraints extensions
- print Authority Information Access extensions
- Print optional X509v2 subject and issuer Unique ID bit strings
2004-01-29 22:45:20 +00:00
a691eadad9
Change some comments and one variable as suggested in review comments.
...
r=relyea,wtc. Bug 124923.
2004-01-29 21:57:41 +00:00
ea227986af
Make SECOID_AddEntry be thread safe. Export it. Bug 124923. r=relyea.
2004-01-29 21:23:36 +00:00
ee55e2e256
Plug leaks. Bug 123693. r=wtc,relyea
2004-01-29 21:18:24 +00:00
f5d7282963
Fix for 232377 - assertion in vfychain with DSA cert. r=wtc, nelsonb
2004-01-28 23:25:07 +00:00
6d506e4aea
Export cert functions that decode extensions and traverse decoded
...
extensions. Bug 231881. r= relyea, wtc.
2004-01-28 23:23:45 +00:00
978fc338e7
Change program return value to reflect test outcome. Bug 221737. r=wtc
2004-01-28 22:30:27 +00:00
cdec2796b4
Bugzilla bug 232380: deleted CERT_FindExpiredIssuer, which is dead code.
...
In cert_VerifyCertChain, make sure that subjectCert and issuerCert never
point to the same cert to prevent from destroying that cert twice.
r=jpierre,nelsonb.
Modified Files: certdb/cert.h certhigh/certvfy.c
2004-01-28 21:51:10 +00:00
a8dcaab07f
address review comments: bug 231659
2004-01-28 04:29:14 +00:00
c9010119e9
rewrite utf8 parser for strictness: bug 231659 r=MisterSSL
2004-01-28 03:48:43 +00:00
21b30d0cf2
fix charset conversion: bug 185167 r=kaie sr=sspitzer
2004-01-28 03:44:38 +00:00
a5aaee4048
Fix for 231051 - crlutil asserts after deleting CRL. r=wtc, nelsonb
2004-01-28 01:17:13 +00:00
6d8fc90771
Bugzilla bug 231018: use AIX.mk for all AIX versions. Removed the
...
AIXm.n.mk files. Removed support for AIX 3.2, 4.1, and 4.2. Removed
unused make variable EXPORT_RULES. Removed unused macro define -DAIX4_3.
The patch is contributed by Philip K. Warren <pkw@us.ibm.com>. r=wtc.
Modified Files:
AIX.mk config.mk
Removed Files:
AIX3.2.mk AIX4.1.mk AIX4.2.mk AIX4.3.mk AIX5.1.mk AIX5.2.mk
2004-01-27 23:55:38 +00:00
78ce53de23
bug 231698: fix regression in reading SDR data in databases written on 64-bit platforms.
...
r=MisterSSL
2004-01-27 18:31:29 +00:00
b2141fb556
AddRef() the out parameter, and check for OOM.
...
Fixes bug 231709, iframes pointing to signed XUL crashes browser
r+sr=jst
2004-01-27 05:01:48 +00:00
8c43abd07c
Fix for 231051 - crlutil asserts after importing CRL. r=nelsonb, wtc
2004-01-27 00:02:16 +00:00
0df0cbe4cf
Fix crashes that occur when optional policyQualifiers are not present.
...
Bug 230951. r=kinmoz.
2004-01-23 22:50:01 +00:00
d3011eaa97
Bumped version to 1.50 (for NSS 3.10).
2004-01-23 22:15:39 +00:00
77a00800e8
RFC 3280 says Name Constraints do not apply to self-issued CA certs,
...
including self-issued intermediate CA certs (so-called "roll-over" certs).
This fixes an NISCC test failure. Bug 231030. r=wtc.
2004-01-23 06:06:06 +00:00
61d56ab306
When a name attribute's value exceeds the maximum allowed length, display
...
a truncated version of it, followed by ellipsis. Bug 220855. r=wtc
2004-01-22 23:45:30 +00:00
d45b087145
Add -a option for Base64 encoded ASCII input and output.
...
The -i and -o options now understand "-" to mean stdin and stdout.
Usage is displayed when -? or no arguments are given.
Bug 231536. r=relyea.
2004-01-22 22:08:59 +00:00
7709686c56
Correct NSS's key usage tests for certs with non-RSA public keys.
...
Bug 221638. r=relyea.
2004-01-22 22:04:54 +00:00
b99a74cbae
Detect duplicate issuer name and serial number between two temp certs.
...
Bug 230996. r=ian, relyea.
2004-01-22 02:36:53 +00:00
1db7eb8535
Fix name constraints code to pass NIST PKITS test 38. r=wtc. Bug 231223.
2004-01-22 02:33:41 +00:00
ce75f8d873
Move an extern function declaration to the header file where it belongs.
...
Bug 229212. r=relyea.
2004-01-22 02:19:42 +00:00
b45bc04f3b
Fix some erronous code that set SEC_ERROR_NO_MEMORY when there had been
...
no memory failure. r=relyea. Bug 231566
2004-01-22 02:17:26 +00:00
1a1c7cb409
Fix bug in cert path length validation. Bug 221644. r=jpierre
2004-01-21 05:32:18 +00:00
f10a7a4ffd
Support GeneralizedTime in NSS tools. bug 210530. r=wtc
2004-01-21 01:15:01 +00:00
14ff763caa
Use the results from PK11_ProtectedAuthenticationPath(slot) in the
...
password callback function. Bug 229023. r=relyea. verified by submittor.
2004-01-21 00:18:59 +00:00
5963bd156f
Bugzilla bug 229299: fixed unused variable warning. r=nelsonb.
2004-01-20 22:57:40 +00:00
ffbdacaeb8
fix review comment: bug 53133
2004-01-20 19:57:17 +00:00
b35fce94e4
Make this code build on Windows as well as Unix.
2004-01-19 01:05:53 +00:00
0ec6f827c6
Fix two more incorrect cert names that caused erroneous test results.
...
Bug 231221.
2004-01-17 05:55:20 +00:00
d9ccd2ab6f
Correct this script to more accurately report errors. Bug 231221.
2004-01-17 05:04:42 +00:00
d8dc4c1455
Detect absent isCA flags in basic constraints. Detect and reject negative
...
or too large positive path length constraints in basic constraints.
Bug 221644. r=jpierre.
2004-01-16 21:33:16 +00:00
5e140a71db
Fix template for Cert policy extensions. Bug 230951, r=jpierre
2004-01-16 05:36:08 +00:00
ad4476ab50
Fix NSS parsing of Issuer Unique ID and Subject Unique ID fields in
...
certificate. Bug 216116. r=jpierre
2004-01-16 02:11:44 +00:00
5dea4e12cf
Add vfychain to list of NSS cmds being built nightly. r=wtc. Bug 231025
2004-01-16 02:03:08 +00:00
fb8076054e
fix comment per review: bug 53133
2004-01-16 01:04:57 +00:00
30ada30854
Set JSS version to 3.5.
...
Modified Files:
org/mozilla/jss/CryptoManager.java
org/mozilla/jss/util/jssver.h pkg/solaris/Makefile.com
2004-01-16 00:50:21 +00:00
c159a3cec3
Another file, pkg/solaris/Makefile.com, also needs to be updated when we
...
change the JSS version.
2004-01-16 00:48:49 +00:00
dd0e83eb66
Minor change after review of previous checkin. Bug 53133.
2004-01-15 22:34:26 +00:00
30bb314da7
Fix build problems on some platforms.
2004-01-15 16:27:02 +00:00
617cabf1fa
Set NSS version to 3.10 Beta.
2004-01-15 15:08:58 +00:00
a71fdf6c5c
Convert T61String-labeled ISO-8859-1 to UTF-8: bug 53133 r=nelsonb a=wtc
2004-01-15 06:23:14 +00:00
65088fd320
Add 2 additional OIDs to the list of acceptable digestEncryptionAlgIDs,
...
per RFC 3370. r=thayes. Bug 230761.
2004-01-14 22:20:44 +00:00
49152980bd
Tool to manage pkcs 11 module tests.
2004-01-14 21:34:20 +00:00
0a29c7fe2b
Fix double free introduced in rev 1.54. r=wtc. bug 230774.
...
Bug occurs only in NSS utilities that import base64 encoded files, e.g.
with the -a option.
2004-01-14 01:19:26 +00:00
ab1b1d58f9
Bugzilla bug 229289: fixed an unused variable warning. r=relyea.
2004-01-13 01:59:41 +00:00
c000ae86e8
General deCOMtamination of nsIDocument, nsIContent, and nsIFormSubmission. Eliminating nsIAttributeContent, and doing some URL->URI changes. r+sr=peterv@propagandism.org
2004-01-09 23:54:21 +00:00
7bcf0f4ab9
Upgraded to NSPR 4.4.1 and NSS 3.9.
2004-01-09 02:34:14 +00:00
2543d8c8d1
Bugscape bug 54500: made uniqueNamedKeyExists public.
2004-01-08 18:09:15 +00:00
8dc069e8e4
Overload the error code SSL_ERROR_RX_RECORD_TOO_LONG to report SSL2
...
records that are too short. Bugscape bug 54814
2004-01-08 06:52:00 +00:00
8a6338d551
Rename PK11_PubDeriveExtended to PK11_PubDeriveWithKDF
2004-01-08 01:37:46 +00:00
435bc1ad86
Set NSS version to 3.9.
2004-01-08 01:04:56 +00:00
e7036921ca
Rename PK11_FindSlotsByAliases to PK11_FindSlotsByNames
2004-01-07 23:12:01 +00:00
70f0bbf00d
Rename CERT_DecodeTimeChoice/CERT_EncodeTimeChoice to DER_DecodeTimeChoice/DER_EncodeTimeChoice
2004-01-07 23:07:24 +00:00
d0f309943a
Continuing to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 13:37:00 +00:00
274ef7cd49
Beginning to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 01:22:31 +00:00
5d8bd61334
Fix crashes in NSS_CMSSignedData_GetDigestValue and
...
NSS_CMSContentInfo_GetContent that occur when a detached signature is not
accompanied by the data on which the signature was computed. Bug 229242.
Make NSS_CMSContentInfo_GetInnerContent and NSS_CMSMessage_GetContent
more easily debugged, by storing the results returned by function calls
in automatic variables before using them in subsequent calls/switches.
2004-01-07 00:09:17 +00:00
6a63299667
Bug 229193
...
Patch by wtc revied by relyea & ian
2003-12-31 23:19:26 +00:00
c54ac86e5f
Fix the security warning dialogs to work as designed for Firebird:
...
- All dialogs will appear the first time a user encounters them
- The "show every time" checkbox will default to off
- If the user checks the checkbox to see the dialogs every time, the choice will be remembered.
Because of the change in default prefs, this will cause Firebird users to see these dialogs again (but defaulted to not show after that) when upgrading. Bug 172091, r=brendan, sr=ben.
2003-12-31 23:03:08 +00:00
144c518d7a
Set NSS version to 3.9 Beta 6.
2003-12-24 06:22:49 +00:00
1550e4ab3e
Removed unused variable 'val'.
2003-12-23 21:40:52 +00:00
0ea554f2f9
Fixed unused variable compiler warning about 'html'. Declare it inside
...
the same ifdef with which it is used.
2003-12-23 21:37:07 +00:00
34519e6ab3
Removed unused variable 'rawSigLen'.
2003-12-23 21:24:01 +00:00
11c67b98af
Removed unused variable 'attribute'.
2003-12-23 21:21:39 +00:00
60cf880826
Include "nsslocks.h" for nss_InitLock.
2003-12-23 02:09:55 +00:00
5bfcd81514
Declare the argument to SECKEY_ECParamsToKeySize as const.
...
Modified Files: seckey.c pk11skey.c
2003-12-23 02:05:28 +00:00
95e1ce0279
Bugscape bug 54500: trim preceding/trailing whitespace from passed-in
...
String arguments.
2003-12-23 01:19:48 +00:00
09584fb9f9
Return a value of the correct type.
2003-12-23 01:03:39 +00:00
290a965230
Fixed a spelling error.
2003-12-23 00:52:06 +00:00
0433b41c3b
Moved ecl-curve.h from the EXPORTS to the PRIVATE_EXPORTS list.
2003-12-23 00:17:04 +00:00
79387320b7
Renamed SECKEY_ECParams2KeySize as SECKEY_ECParamsToKeySize. Do not export
...
this function from the nss3 shared library.
Modified Files: seckey.c pk11skey.c nss.def
2003-12-22 23:36:40 +00:00
7adfc17d1d
Declare the 'input' argument to CERT_DecodeTimeChoice as 'const'. Removed
...
an extraneous semicolon (;) after the SEC_ASN1_CHOOSER_IMPLEMENT macro.
Modified Files: secder.h sectime.c
2003-12-22 23:33:39 +00:00
4b807fd2b8
Bugzilla bug 228907: added a stub implementation for the obsolete native
...
function Java_org_mozilla_jss_pkcs11_PK11Cert_getNickname, which is listed
in the symbol export file jss.def.
2003-12-20 15:56:11 +00:00
76bb8f646c
Some further cleanup of p12d.c. Bugscape bug 52528. r=wtc.
2003-12-20 01:33:06 +00:00
7905ca6b6f
Set NSS version to 3.9 Beta 5.
2003-12-20 00:35:01 +00:00
9ccb6b87c5
Made wincx the last argument of PK11_PubDeriveExtended. r=relyea.
...
Modified Files: pk11func.h pk11skey.c ssl3con.c
2003-12-19 23:54:29 +00:00
312061509b
Impose new limits on RSA public key sizes. 8k bits for modulus,
...
64 bits for public exponent. This prevents certain attacks on SSL
servers. Bugscape bug 54019. r=wtc,relyea.
2003-12-19 23:50:45 +00:00
010acd81c1
PK11_MoveKey was renamed PK11_MoveSymKey. r=relyea.
...
Modified Files: symkeyutil.c nss.def pk11func.h pk11skey.c
2003-12-19 23:29:43 +00:00
6e767fb4eb
Make database access to the key db thread safe.
2003-12-19 23:24:48 +00:00
8ec4937462
Add keydb lock type. keydb should be locked like the certdb.
2003-12-19 23:24:00 +00:00
5014045f8c
Backed out the previous checkin, which broke our S/MIME QA tests.
2003-12-19 22:54:20 +00:00
fac46295ff
Bugzilla bug 228624: we need to call STAN_ForceCERTCertificateUpdate if
...
the cert's instances changed. r=relyea.
2003-12-19 22:33:12 +00:00
64276531dd
Bugscape bug 54627: made the fix for NSS_CMSSignedData_Encode_BeforeData
...
the same as the code in NSS_CMSSignedData_Decode_BeforeData. r=nelsonb.
2003-12-19 22:08:12 +00:00
c367aa403a
Bugscape bug 54500: Improved the previous checkin: fixed leaks of the
...
return values of PK11_GetSymKeyNickname. Removed unnecessary assignment
statements "symKeyObj = NULL;". Removed an unnecessary else { }.
2003-12-19 19:36:30 +00:00
deb29c8f1f
Import NSPR 4.4.1.
2003-12-19 17:02:57 +00:00
4a54a29151
Bugzilla bug 221133: fixed unused variable warning on some platforms.
...
The patch is contributed by timeless@bemail.org . r=wtc.
2003-12-19 16:35:14 +00:00
ec5678ff34
Bugscape bug 54500: added some new methods to the SecretDecoderRing
...
KeyManager class. The patch is contributed by Matthew Harmsen of AOL.
Modified Files:
lib/jss.def org/mozilla/jss/SecretDecoderRing/KeyManager.c
org/mozilla/jss/SecretDecoderRing/KeyManager.java
2003-12-19 05:33:50 +00:00
546a8a6e87
Set JSS version to 3.5 Beta.
...
Modified Files:
org/mozilla/jss/CryptoManager.java
org/mozilla/jss/util/jssver.h
2003-12-19 05:08:34 +00:00
70470925e0
Don't overwrite pointers to existing message digests if they've been
...
precomputed. Bugscape bug 54627. r=wtc, jpierre.
2003-12-19 03:58:28 +00:00
a08b14e07e
Bugzilla bug 228907: enable PK11Store.getCertificates to return the correct
...
nicknames for certs with multiple instances. This requires adding a new
nickname argument to the constructors of the various cert classes and
passing a nickname better than NSS's cert->nickname where possible.
r=thomask.
Modified Files:
pkcs11/PK11Cert.c
pkcs11/PK11Cert.java
pkcs11/PK11InternalCert.java
pkcs11/PK11InternalTokenCert.java
pkcs11/PK11Store.c
pkcs11/PK11TokenCert.java
pkcs11/pk11util.h
util/java_ids.h
2003-12-19 00:19:57 +00:00
8bfb2f97fd
Set NSS version to 3.9 Beta 4.
2003-12-18 21:45:34 +00:00
991ddf2ba6
Bugzilla bug 228624: made PK11_ListCertsInSlot reach into the Stan layer
...
to obtain the correct nicknames of the cert instances (pk11cert.c). Fixed
the bug that if a cert we want to add the the cache is already in the
cache, we should merge the instances of the cert before destroying the
duplicate cert (tdcache.c). r=jpierre,relyea.
2003-12-18 18:23:17 +00:00
ec4dda5d19
Bugzilla bug 219982: removed an unused local variable. (The function call
...
is needed for its side effect.) Thanks to timeless@bemail.org and
Serge GAUTHERIE <gautheri@noos.fr> for the patch. r=wtc.
2003-12-17 22:43:25 +00:00
634bb98533
Allow NSS_CMSDigestContext objects to be created, even when there are
...
no valid digest algorithm OIDs. This allows "certs only" messages to
be decoded. Bugzilla bug 228707. r=jpierre, wtc.
2003-12-17 03:49:10 +00:00
e3cda94421
Bugzilla bug 228618: fixed an incorrect use of realloc. Fixed an unused
...
variable compiler warning. r=jpierre.
2003-12-16 04:24:57 +00:00
b41986df1b
Fix S/MIME bugs that caused parallel arrays of digest OIDs and digest
...
values to become out of sync. Bugscape bug 54256. r=relyea.
Modified Files: cmd/smimetools/cmsutil.c lib/smime/cmsdigest.c
2003-12-12 23:55:06 +00:00
3331d24ed7
Fix for 54061 . Return SEC_ERROR_INVALID_ARGS and remove assertions . r=wtc,misterssl
2003-12-12 21:42:02 +00:00
cbcce6aa7e
fixes bug 228062 "NTLM authentication fails with mod_ntlm, mod_ntlm reports 'missing/corrupt NTLM header'" r+sr=bryner a=dbaron
2003-12-12 02:58:42 +00:00
ec74b37f9f
fix 227991, nsNSSCertificateDB::AddCertFromBase64 crashes (only used from auto config), r=kaie, sr=mscott, a=sspitzer
2003-12-11 16:02:08 +00:00
fff428a34a
CERT_ImportCerts now returns SECFailure when NONE of the certs was succesfully imported. r=wtc. Bugscape bug 54311.
2003-12-06 06:52:53 +00:00
7ed9720eb2
__CERT_AddTempCertToPerm will now set error SEC_ERROR_ADDING_CERT
...
when attempting to make a cert perm that is already permanent.
Bugzilla bug 227559. r=wtc
2003-12-06 06:46:27 +00:00
87f5c7ded0
NSC_Finalize will now destroy 3 softoken free lists and one more
...
global pointer. Plugs some memory leaks. Bugscape bug 54301. r=wtc
2003-12-06 06:41:51 +00:00
6f425d9730
Add /FIXED:NO argument to linker command line for EXEs. Purify
...
requires this to precisely instrument EXEs. r=wtc
2003-12-06 06:34:20 +00:00
2b4825491c
Add new -k option to NSS QA test program cmsutil. By default, cmsutil
...
will no longer add any decoded certs to the cert db file, which is
useful for reproducibility of results in QA scripts.
Bugscape bug 54293. r=relyea,jpierre,wtc
2003-12-06 06:31:08 +00:00
2483a508a7
Bugzilla bug 227296: fixed the bug that NSS_CMSAttribute_AddValue adds the
...
address of a stack variable to the attr->values array. Added a new
function SECITEM_ArenaDupItem. r=nelsonb.
Modified Files:
nss/nss.def util/secitem.c util/secitem.h smime/cmsarray.c
smime/cmsattr.c
2003-12-06 01:16:50 +00:00
265f6a9b37
Further simplification and improvement of the parsing of UTCTime
...
and GeneralizedTime to avoid UMRs. Bugscape bug 54198. r=wtc
2003-12-05 04:53:28 +00:00
b87fc256c1
NSS_CMSContentInfo_Destroy()
...
- The patch destroys the digest context member of the CMSContentInfo.
It calls the previously unused function NSS_CMSDigestContext_Cancel
to destroy the digest context. Eliminates an object reference leak.
Bugscape bug 54208, r=relyea
2003-12-04 00:39:24 +00:00
697b57f151
In functions NSS_CMSSignedData_Encode_AfterData and
...
NSS_CMSSignedData_Decode_AfterData
- These functions call NSS_CMSDigestContext_FinishMultiple, which
always destroys the digest context, regardless of whether it returns
SECSUccess or SECFailure. So, change these functions to always NULL
out the context pointer regardless of the returned value.
NSS_CMSSignedData_VerifySignerInfo()
- Always call NSS_CMSSignerInfo_Verify() to set the verification status
in the signerinfo object, even if some of the other arguments are NULL,
or other failures have occurred, but avoid NULL pointer dereferences
along the way. Notice that this change is dependent on changes to
NSS_CMSSignerInfo_Verify() (see below.)
NSS_CMSSignedData_SetDigests() - skip over missing digests. Don't fail
the function, and don't crash, if digest pointers are NULL.
Bugscape bug 54208, r=relyea
2003-12-04 00:36:47 +00:00
8a0ca297e4
Functions NSS_CMSDigestedData_Encode_AfterData and
...
NSS_CMSDigestedData_Decode_AfterData
- Since NSS_CMSDigestContext_FinishSingle always destroys the context,
regardless of whether it returns SECSuccess or SECFailure, these
functions have been changed to always NULL out the context pointer
after calling NSS_CMSDigestContext_FinishSingle, regardless of the
outcome.
Bugscape bug 54208, r=relyea
2003-12-04 00:35:02 +00:00
d0960c05d3
There is a lot of "cleanup" in this file, wrapping source at 80 columns.
...
The relevant fixes for this bug include:
NSS_CMSDigestContext_StartMultiple()
- make sure that cmsdigcx->digcxs and cmsdigcx->digobjs are initialized.
- at the "loser" label, be sure to free the digest context itself.
NSS_CMSDigestContext_Cancel()
- after destroying all the objects, free the arrays of pointers to the
objects, and the digest context itself. Previously these items were
leaked by this function.
NSS_CMSDigestContext_FinishMultiple()
- ensure that this function ALWAYS destroys all the NSS digest objects,
and doesn't stop destroying them if it encounters an error. Note that
this is a newer revision of an older patch for that problem.
- always Free the arrays of pointers used in this object.
NSS_CMSDigestContext_FinishSingle()
- simplify this code.
Bugscape bug 54208, r=relyea
2003-12-04 00:32:18 +00:00
f6f1a0d2e4
NSS_CMSSignerInfo_Verify()
...
- This function is changed to explicitly allow some of its input arguments
to be NULL. It will set the verification status in the CMSSignerInfo
object accordingly. Since this is the ONLY function that ever sets the
verification status, it must be able to do so even when problems have
occurred.
- lots of cleanup of this source code.
Bugscape bug 54208, r=relyea
2003-12-04 00:29:31 +00:00
874fa3a93d
Add null pointer checks to nss_cms_after_end and NSS_CMSEnvelopedData_Decode_AfterData. Bugscape bug 54061. r=wtc,relyea
...
Lots of code "cleanup" (reformatting for 80 columns) in cmsdecode.c
2003-12-04 00:14:24 +00:00
e4d53231f8
Avoid UMRs in dertime.c. Bugscape bug 54198. r=wtc.
2003-12-03 04:03:40 +00:00
e6c9ba62d7
Fix for 54061 - null pointer check . r=nelsonb
2003-12-03 02:42:08 +00:00
80462e9cb1
Bugscape bug 54021: in CERT_FindSubjectKeyIDExtension, if PORT_NewArena
...
fails we should return SECFailure. Document that the return values of
CERT_GetCommonName and NSS_CMSSignerInfo_GetSignerCommonName must be freed
with PORT_Free. r=nelsonb.
Modified Files:
certdb/alg1485.c certdb/cert.h certdb/certv3.c smime/cms.h
smime/cmssiginfo.c
2003-12-03 00:09:05 +00:00
d5582721b7
Separate locale version from Mozilla version so we do not have to bump locale version for every release. b=226377 r=kairo, bsmedberg sr=ben a=asa
2003-12-02 23:22:11 +00:00
e5c708bb65
Prevent SMIME crash in the opaque signature test. bugscape 54061. r=nelsonb
2003-12-02 05:46:27 +00:00
7eef555978
Fix for 54088 . Don't try to encode attributes with no value. r=wtc
2003-12-02 05:05:30 +00:00
02198fd686
Bound stan error stack at 16 error codes to limit growth.
...
Bugscape bug 54021. r=wtc.
2003-12-02 02:05:47 +00:00
cb7164249f
Reverted to NSPR 4.3 until Sun has NSPR 4.4.1 binary distributions.
2003-11-28 05:41:42 +00:00
785b886515
Detect invalid input buffer lengths, and return error instead of UMR>
...
Bugscape bug 54021. r=wchang0222
2003-11-27 05:08:20 +00:00
13f3e6fa94
Fix leak in CERT_FindSubjectKeyIDExtension, and use the Quick DER
...
decoder. Bugscape bug 54021. r=jpierre
2003-11-27 05:06:20 +00:00
1731be9206
Upgraded to NSPR 4.4.1.
2003-11-27 01:43:15 +00:00
931071736c
Clean up some arithmetic used for UCS4. Detect when UCS2 and UCS4
...
buffers have invalid lengths. Bugscape bug 54021. r=whang0222, relyea
2003-11-27 01:08:59 +00:00
dcc1fa5880
Bugzilla bug 226861: removed NSS_CMSSignedData_GetDigestByAlgTag, which is
...
a duplicate of NSS_CMSSignedData_GetDigestValue. r=nelsonb.
Modified Files: cms.h cmssigdata.c
2003-11-26 23:50:02 +00:00
1c7b6a8ea4
In NSS_CMSSignedData_VerifySignerInfo(), test all returned pointers
...
for NULL before attempting to dereference them.
Bugscape bug 54057. r=wchang0222
2003-11-26 22:02:38 +00:00
36fc65a627
Performance enhancement. Detect absurdly large modulae in public keys,
...
and don't waste time on them. Bugscape bug 54019. r=relyea.
2003-11-26 06:26:31 +00:00
d596531040
Remove an unnecessary and incorrect assert call.
...
Bugscape bug 54018. r=jpierre
2003-11-26 06:16:01 +00:00
8cc8dfcdf3
This patch reduces the scope of many variables in cmsutil's decode function. It frees the signer's CN string after use.
...
Bugscape bug 54021. r=jpierre
2003-11-25 23:26:39 +00:00
2c0d2708f3
fixes bug 226639 "send NegotiateAlwaysSign in NTLM type 1 message to make NetApp/6.3.3 happy" r+sr=bryner a=dbaron
2003-11-25 02:12:41 +00:00
86e2d2c45d
Bugzilla bug 226470: removed -qarch=com, which is the default for the
...
compiler. r=pkw@us.ibm.com .
2003-11-24 19:45:18 +00:00
034bf93de9
Bugzilla bug 226470: use a C compiler rather than a C++ compiler to compile
...
C code. The patch is contributed by Philip K. Warren <pkw@us.ibm.com>.
2003-11-22 06:45:50 +00:00
20abf0c0aa
Don't invoke PKCS11 with an invalid handle. Bug 226285.
...
r=relyea sr=wchang0222
2003-11-21 22:10:56 +00:00
d3382c6ffe
Remove an overreaching constraing on modulus length. Bug 226285.
...
r=relyea sr=wchang0222
2003-11-21 22:09:27 +00:00
0fa7d0adc8
Implement new "batch mode" (see the -b option). Plug some leaks.
...
Facilitates memory leak testing of the SMIME library.
This revision combines the patches for Bugzilla bug 225513 and
Bugscape bug 53775. r = relyea and wchang0222
2003-11-20 02:33:18 +00:00
52dffd46a8
Don't accept ASN.1 items whose length is 2GB or more.
...
Bugscape bug 53875. r=wchang0222 and r=relyea.
2003-11-20 02:08:34 +00:00
67d78ccfb9
Dont attempt to allocate 2GB or more from an arenapool.
...
Bugscape bug 53875. r=relyea.
2003-11-20 02:06:16 +00:00
511a262edc
Remove as assertion that is triggered by bad data input, but does not
...
indicate a code flaw. Bugscape bug 53875. r=relyea
2003-11-20 02:04:07 +00:00
75ca774270
Be sure not to ask NSS to use an invalid PKCS11 mechanism.
...
Bugscape bug 53875. r=relyea.
2003-11-20 02:00:04 +00:00
b79aed8a42
Plug a leak that occurs when code asks NSS to use an invalid PKCS11
...
mechanism. Bugscape bug 53875. r=relyea
2003-11-20 01:59:07 +00:00
d7ce33ed84
fix two "might be used uninitialized" warnings from NTLM patch, bug=224653.
2003-11-19 05:00:43 +00:00
eb21d36254
near total rewrite of PK11_ParamFromAlgid to eliminate leaks.
...
Partial fix for Bugscape bug 53875.
2003-11-19 03:23:41 +00:00
c7610ca80e
Bugzilla bug 222568: fixed a bug introduced in rev. 1.54.
2003-11-19 01:38:26 +00:00
604c4a98c3
Turns out that we can use a space to separate directories in a vpath
...
directive. This works cross platform.
2003-11-19 01:12:31 +00:00
069f394fa8
Fix bugs in the new implementation of URI name constraints.
...
Bugzilla Bug 221616.
2003-11-19 00:56:59 +00:00
f2fe58e2e0
Removed the declaration and a comment about PK11_FreeSlotCerts, which was
...
deleted in NSS 3.4.
Modified Files: pk11func.h pk11slot.c
2003-11-19 00:14:04 +00:00
c4ce0736e8
Fix unnecessary assertion failures occuring in SMIME testing in
...
debug builds only. Partial fix for bugscape bug 53775. r=wchang0222
2003-11-18 06:16:26 +00:00
cf0793aa0b
revert part of last checkin.
2003-11-18 05:57:28 +00:00
a0dd5e04d1
attempting to fix IRIX bustage
2003-11-18 05:56:08 +00:00
157dedc0c2
Most platforms use ':' as path separator, but OS/2 uses ';'. So we use
...
vpath directivies that specify a single directory to avoid dealing with
path separator.
2003-11-18 04:04:05 +00:00
f142a6ea88
fixes bug 224653 "provide cross-platform NTLM auth implementation" r=kaie sr=bryner
2003-11-18 02:20:34 +00:00
c48834ab7e
Set NSS version to 3.9 Beta 3.
2003-11-18 00:57:26 +00:00
25f92109eb
Bugzilla bug 224707: added Linux HPPA support. The patch came from the
...
Debian Mozilla package (maintainer is Takuo KITAME <kitame@debian.org>).
2003-11-16 00:10:16 +00:00
9bc7ce19bb
Removed an extraneous character (`) after #endif.
2003-11-15 16:16:33 +00:00
3569f15993
Removed an extraneous comma (,) at the end of an enum type definition.
2003-11-15 16:15:01 +00:00
e9f81f8499
Detect empty emailAddr strings in CERTCertificate. Bugzilla bug 211540.
2003-11-15 00:15:28 +00:00
b904b47318
Detect empty emailAddr strings in CERTCertificates. Bugzilla bug 211540.
...
Modified Files:
cmd/dbck/dbck.c cmd/signtool/util.c lib/certdb/certdb.c
lib/certdb/stanpcertdb.c lib/pkcs7/p7decode.c lib/pki/certificate.c
lib/pki/pki3hack.c lib/smime/cmssiginfo.c lib/softoken/pkcs11u.c
2003-11-15 00:10:01 +00:00
wchang0222%aol.com
gerv%gerv.net
jgmyers%speakeasy.net
bryner%brianryner.com
varga%nixcorp.com
neil%parkwaycc.co.uk
timeless%mozdev.org
nelsonb%netscape.com
relyea%netscape.com
cls%seawood.org
jpierre%netscape.com
peterv%propagandism.org
bishakhabanerjee%netscape.com
darin%meer.net
jst%mozilla.jstenback.com
kairo%kairo.at
dbaron%dbaron.org
caillon%returnzero.com
bsmedberg%covad.net
bienvenu%nventure.com