The tests do not reflect reality, see the bug for more details.
The content area of the Proton `about:welcome` uses
`var(--in-content-page-color)` and `var(--in-content-page-background)`
for the text and background color. The main background itself already
has colors distinct from the default background. Moreover,
`about:welcome` is part of the onboarding experience, at which point
users will likely not have a custom theme, so it's not necessary to
adjust the colors.
Differential Revision: https://phabricator.services.mozilla.com/D116453
This drops the _old_ API fully and implements support only for the new object-focused API,
regardless of `type` defintions in metrics.yaml.
The new API will look like the following examples:
Rust
let extra = AnEventKeys {
extra1: Some("a-value".into()),
..Default::default()
};
category::an_event.record(extra);
(Note: not optimal yet, but we can extend this with a builder-like
pattern later)
C++
AnEventExtra extra = { .extra1 = Some("value"_ns) };
category::an_event.Record(Some(extra));
JavaScript (actually unchanged!)
let extra = { extra1: "value" };
Glean.category.anEvent.record(extra);
(Note: The JavaScript API accepts strings, booleans and integers for any
extra value and will stringify them regardless of their specified type.)
Differential Revision: https://phabricator.services.mozilla.com/D114498
One can now run the tests with `UPDATE_EXPECT=1` and the code will
update the files, so one can then commit them (after verifying that they
do what they should)
Differential Revision: https://phabricator.services.mozilla.com/D116563
It's not practically make a difference (the flags we end up setting it
to don't do anything when linking all the wasm files into one).
Differential Revision: https://phabricator.services.mozilla.com/D116437
Replaces the `isFinal` bit with a "browser-shutdown-tabstate-updated" observer
notification, which is fired after all frames in the document are flushed.
Differential Revision: https://phabricator.services.mozilla.com/D116146
This patch does change the extension-related special case in SVGContextPaint::IsAllowedForImageFromURI
to check the "internal:svgContextPropertiesAllowed" extension permission, and move the existing
criteria in the Extension class (which takes care of adding the internal permission when those
criteria as met).
This patch does not contain yet a new explicit test case for the new internal permission (which is
part of the patch build on top of this one and attached to the same bugzilla issue), but it does
pass the existing mochitest-chrome (test_chrome_ext_svg_context_fill.html).
Differential Revision: https://phabricator.services.mozilla.com/D115835
Share the concept of a panel content with all other menupopups / panels.
This avoids importing global.css in the shadow tree, and renames the
arrowcontent part to just "content", since we want to introduce a
"content" part for other panels.
This shouldn't change behavior but makes bug 1708136 a matter of
tweaking a couple CSS rules and fixing up test failures.
Differential Revision: https://phabricator.services.mozilla.com/D113990
This patch is to show a warning icon for a module which caused crash
i.e. if `CrashManager` has a record where the crashing address was within
the module's mapped region.
Depends on D109307
Differential Revision: https://phabricator.services.mozilla.com/D112796
This patch adds a new mochitest to verify the content on about:third-party.
As a third-party module to test, this patch adds a new DLL TestShellEx.dll
which works as an Icon Handler Shell Extension.
Differential Revision: https://phabricator.services.mozilla.com/D109307
This patch adds application info (Name and Publisher for now) in the
about:third-party page if a module is a part of an installed application,
which is registered in the registry and shown in Windows Control Panel.
To achieve this, we parse the registry to collect installed applications
in the background task.
Differential Revision: https://phabricator.services.mozilla.com/D109306
This patch adds a feature to mark each module in the about:third-party page
as a shell extension or an IME if it is so. To achieve this, when the page
is loaded, it starts a background task to collect registered shell extensions
from the registry and adds a tag next to a module's name.
Differential Revision: https://phabricator.services.mozilla.com/D109305
This patch implements a frontend part of the about:third-party, showing
third-party module info based on the telemetry ping as we currently do in
the "Third-Party Modules" section in the about:support page (bug 1669036).
Differential Revision: https://phabricator.services.mozilla.com/D109304
This patch adds a blank page about:third-party along with a skeleton XPCOM
object AboutThirdParty which has a method to invoke a background task in C++.
Differential Revision: https://phabricator.services.mozilla.com/D109303
Release 88 users are already enrolling in nimbus onboarding-modal-experiment which uses aboutwelcome feature. Enrollment ends 2021-05-31 and observation will be 4 weeks until 2021-06-28, which ends before 90 reaches release 2021-07-13, so enrolled users will naturally unenroll before upgrading to 90, which would no longer have this feature alias.
Differential Revision: https://phabricator.services.mozilla.com/D116286
Andrew Halberstadt
Dana Keeler
Rob Wu
Jan-Erik Rediger
Harry Twyford
Paul Zuehlcke
Mike Hommey
Kashav Madan
Toshihito Kikuchi
Luca Greco
Mark Banner
Marco Bonardo
Emilio Cobos Álvarez
R. Martinho Fernandes
Henri Sivonen
Chris Peterson
Matt Woodrow
Kartikaya Gupta
Henrik Skupin
Valentin Gosu
Andrei Oprea
Alexandru Michis
Butkovits Atila
Dorel Luca
Michelle Goossens
Sandor Molnar
Kate Hudson
Ed Lee
Noemi Erli