81d936b141
Bug 1683031 - pt 5. Add an assertion and document idle request IDs r=smaug
...
Add assertions and comments to explain the behaviour/use of the idle request
IDs.
Depends on D99330
Differential Revision: https://phabricator.services.mozilla.com/D100300
2020-12-22 17:56:46 +00:00
89090895bb
Bug 1683410 - Make sShutdownComplete atomic r=xpcom-reviewers,mccr8
...
This is changed on the main thread by `nsThreadManager` and should probably just be made atomic.
Differential Revision: https://phabricator.services.mozilla.com/D100161
2020-12-18 20:44:03 +00:00
12424aa6b0
Bug 1662265 - Fix input events handling for sync XHR when both TaskController and e10s are enabled r=smaug
...
There are two issues in our current setup
1) Input events which are occurring in the same tab are going to be lost
because sync XHR. We have event handling suppression for synx XHR, so input
events are going to be discarded.
2) Input events that are happening in another tab (same process as the
synx XHR tab) are not going to be delayed. This is not correct since
sync XHR should block the Javascript execution.
This patches fixes the above cases for when both TaskController and e10s are
enabled by suspending the InputTaskManager during sync XHR, which
delays the input event handling and keeps the events around.
Differential Revision: https://phabricator.services.mozilla.com/D90780
2020-12-15 01:33:24 +00:00
23c25cd32a
Bug 1675073: Manually set the stack size for TaskController pool threads. r=aosmond,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D99611
2020-12-14 01:07:59 +00:00
7d166ee1a3
Bug 1680217 - Allow NewRunnableMethod to move in the this pointer from a RefPtr. r=xpcom-reviewers,KrisWright
...
Differential Revision: https://phabricator.services.mozilla.com/D98440
2020-12-07 21:43:43 +00:00
1c53236b70
Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
d508bddd4f
Bug 1119956 implement IdleRunnableWrapper::OnDiscard() r=sg
...
This causes no behavior changes in the current code because existing runnables
passed to NS_DispatchToThreadQueue() are either run on the main thread where
OnDiscard() is not called or they have only a no-op OnDiscard().
Differential Revision: https://phabricator.services.mozilla.com/D98120
2020-12-06 21:51:01 +00:00
d7db260690
Bug 1680544 - Part 3: Do not log runnables coming from TaskController. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D98646
2020-12-04 18:59:45 +00:00
e9ccb2eec1
Bug 1680544 - Part 2: Specialize LogTaskBase<Task>::Run::Run. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D98645
2020-12-04 19:14:12 +00:00
3f4d736062
Bug 1680544 - Part 1: Introduce a GetName member for Tasks and implement this for RunnableTask. r=smaug,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D98644
2020-12-04 19:54:18 +00:00
6a927752ef
Bug 1678416 - Minor comment fixes r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D90901
2020-12-04 16:03:24 +00:00
68bc625380
Bug 1678416 - Implement IdleTaskRunner::SetBudget() and add some comments. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D97670
2020-12-04 16:02:52 +00:00
016881a724
Backed out 5 changesets (bug 1678416) for build bustages on CCGCScheduler.h. CLOSED TREE
...
Backed out changeset cc5f7ecb3922 (bug 1678416)
Backed out changeset 61d9f960b80e (bug 1678416)
Backed out changeset 882f7ebe33fe (bug 1678416)
Backed out changeset e845a32a60bd (bug 1678416)
Backed out changeset 85f35f5749a0 (bug 1678416)
2020-12-04 04:55:39 +02:00
f5c9716fcb
Bug 1678416 - Minor comment fixes r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D90901
2020-12-04 02:40:29 +00:00
cd97876818
Bug 1678416 - Implement IdleTaskRunner::SetBudget() and add some comments. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D97670
2020-12-04 02:40:00 +00:00
b0be138f26
Bug 1119956 don't pretend to implement nsICancelableRunnable::Cancel() r=gsvelto,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D98119
2020-12-02 06:32:39 +00:00
fd89df3f6d
Backed out changeset 432c83951167 (bug 1662265) for perma failures on test_sync_xhr_event_handling_switch_bcg.html. CLOSED TREE
2020-12-03 23:03:05 +02:00
f521450d39
Bug 1662265 - Fix input events handling for sync XHR when both TaskController and e10s are enabled r=smaug
...
There are two issues in our current setup
1) Input events which are occurring in the same tab are going to be lost
because sync XHR. We have event handling suppression for synx XHR, so input
events are going to be discarded.
2) Input events that are happening in another tab (same process as the
synx XHR tab) are not going to be delayed. This is not correct since
sync XHR should block the Javascript execution.
This patches fixes the above cases for when both TaskController and e10s are
enabled by suspending the InputTaskManager during sync XHR, which
delays the input event handling and keeps the events around.
Differential Revision: https://phabricator.services.mozilla.com/D90780
2020-12-03 03:13:04 +00:00
5e0ca15c1e
Bug 1119956 add CancelableRunnable documentation to clarify expectations r=sg
...
Differential Revision: https://phabricator.services.mozilla.com/D98288
2020-12-01 10:05:21 +00:00
fe53cdd395
Bug 1119956 introduce DiscardableRunnable for tasks that might not run but might not implement cancellation r=asuth,sg
...
Classes that inherit from DiscardableRunnable are only promising that it is OK
for Run() to be skipped, rather than promising that Cancel() is effective.
Differential Revision: https://phabricator.services.mozilla.com/D98117
2020-12-02 09:36:25 +00:00
e0c988cd55
Bug 1626278: Implement MozPromise::AllSettled, based on JS Promise API. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D91467
2020-11-19 18:50:08 +00:00
e1afffcd87
Bug 1676372 - Avoid including PlatformDecoderModule.h in header files. r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D96544
2020-11-26 13:20:59 +00:00
dd80614fa0
Bug 1678062 - Remove unnecessary includes. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D97467
Depends on D96561
2020-11-23 16:12:02 +00:00
d10d03d076
Bug 1676365 - Move SpinEventLoopUntil to separate header. r=#xpcom-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D96556
Depends on D96554
2020-11-23 16:10:41 +00:00
2499964dc8
Bug 1676361 - Clean up profiler includes. r=gerald
...
Differential Revision: https://phabricator.services.mozilla.com/D96539
Depends on D96538
2020-11-23 16:09:13 +00:00
6f7b6986d5
Bug 1673424 - Fix includes around StructuredCloneData.h.
...
Differential Revision: https://phabricator.services.mozilla.com/D94763
Depends on D94762
2020-11-23 16:07:01 +00:00
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
290b2047d2
Bug 1677284 - Avoid using PackingStrategy::Variant fallback for CPUUsageWatcherError. r=nika,emilio
...
This also adds an UnusedZeroEnum template to Result.h, which can be used
for specializing UnusedZero for scoped enum types.
Differential Revision: https://phabricator.services.mozilla.com/D97074
2020-11-23 15:49:02 +00:00
5b03a03156
Merge autoland to mozilla-central. a=merge
2020-11-19 23:43:43 +02:00
eaa940bdeb
Backed out changeset 16291a47acda (bug 1662254) for causing Bug 1677764. a=backout DONTBUILD
2020-11-19 21:43:10 +02:00
26d2cf4e4b
Bug 1671403 - DataMutexBase::Mutex() gives const& access to the mutex - r=sg
...
This permits calling const member functions of the underlying mutex, such as `Mutex::AssertCurrentThreadOwns()`.
Differential Revision: https://phabricator.services.mozilla.com/D96968
2020-11-19 11:47:08 +00:00
46fed8e10f
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-18 21:46:56 +00:00
b7eeb731df
Backed out 23 changesets (bug 1675409) for build bustages on Preferences.cpp. CLOSED TREE
...
Backed out changeset c1a131a55767 (bug 1675409)
Backed out changeset 47d210802a5d (bug 1675409)
Backed out changeset e8ebb1c58d30 (bug 1675409)
Backed out changeset 69a1e9aeff2a (bug 1675409)
Backed out changeset 68f330b387a8 (bug 1675409)
Backed out changeset e4750d9ef5a1 (bug 1675409)
Backed out changeset bb6bb71e5ab3 (bug 1675409)
Backed out changeset 988d7f4716df (bug 1675409)
Backed out changeset ca41382e891c (bug 1675409)
Backed out changeset 90f3fbbbbeda (bug 1675409)
Backed out changeset 9b109d61a6f6 (bug 1675409)
Backed out changeset 3dd66abfdaa2 (bug 1675409)
Backed out changeset 44181df5f0db (bug 1675409)
Backed out changeset bb2603d947fc (bug 1675409)
Backed out changeset 97055cf20a56 (bug 1675409)
Backed out changeset f88fcf09de0d (bug 1675409)
Backed out changeset 7963e1c49786 (bug 1675409)
Backed out changeset 4c379c1061c3 (bug 1675409)
Backed out changeset b8be8ae7da63 (bug 1675409)
Backed out changeset 0b90aa89421e (bug 1675409)
Backed out changeset c10fb46467c9 (bug 1675409)
Backed out changeset 894ac233b290 (bug 1675409)
Backed out changeset 075d1d8e34c2 (bug 1675409)
2020-11-18 20:06:28 +02:00
bebb9f9181
Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
...
It is bringing some minor changes
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D90795
2020-11-18 09:05:59 +00:00
067cad5579
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-17 22:16:16 +00:00
c0d25b01b2
Backed out 24 changesets (bug 1666566, bug 1675409) for causing hazard failures in profiler/core/platform.cpp
...
CLOSED TREE
Backed out changeset 4d8af8533fd4 (bug 1666566)
Backed out changeset f031a3a8a20f (bug 1675409)
Backed out changeset 2b7e1a031921 (bug 1675409)
Backed out changeset bda5a24b2d0a (bug 1675409)
Backed out changeset 4282e2284314 (bug 1675409)
Backed out changeset 0637f1b26e9f (bug 1675409)
Backed out changeset 67ae04c8f607 (bug 1675409)
Backed out changeset 6c7b3f3618ef (bug 1675409)
Backed out changeset 2f325c22d169 (bug 1675409)
Backed out changeset 1e48ff70ad8f (bug 1675409)
Backed out changeset 1dfc32d6871d (bug 1675409)
Backed out changeset 4f1f218a777b (bug 1675409)
Backed out changeset e6ac8722b38e (bug 1675409)
Backed out changeset cf132e15fb57 (bug 1675409)
Backed out changeset a126e6b00ba9 (bug 1675409)
Backed out changeset fbc7fbb04f33 (bug 1675409)
Backed out changeset 554c69681474 (bug 1675409)
Backed out changeset 44d0521c701f (bug 1675409)
Backed out changeset 04653dfe4720 (bug 1675409)
Backed out changeset 41ca2c043a00 (bug 1675409)
Backed out changeset 264ae4c805d4 (bug 1675409)
Backed out changeset 5f3bbdac0d52 (bug 1675409)
Backed out changeset 11311c11a6e8 (bug 1675409)
Backed out changeset 0355fbc44baf (bug 1675409)
2020-11-17 19:31:28 +02:00
ee94544ace
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-17 11:31:04 +00:00
e5edc9c72e
Bug 1676977 - Make DataMutex::AutoLock public r=sg
...
Since it's already possible to use the type if its declaration is auto, this
change just allows us to return it from functions.
Differential Revision: https://phabricator.services.mozilla.com/D96936
2020-11-13 10:04:22 +00:00
d0a1ea34ce
Bug 1662254 - Merge ICCRunner and CCRunner into a single CCRunner r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D90633
2020-11-13 19:38:02 +00:00
3667467db8
Backed out 10 changesets (bug 1662254) for lint failure on generate_static_pref_list.py CLOSED TREE
...
Backed out changeset 972e63387191 (bug 1662254)
Backed out changeset 3a9d6f0aa380 (bug 1662254)
Backed out changeset 4b3ffe7fe1af (bug 1662254)
Backed out changeset 4834b1025611 (bug 1662254)
Backed out changeset ec1f7afe8a2d (bug 1662254)
Backed out changeset c7a6b927b1de (bug 1662254)
Backed out changeset 2427d85b2605 (bug 1662254)
Backed out changeset 979bf4ac97bb (bug 1662254)
Backed out changeset 3e443333c636 (bug 1662254)
Backed out changeset a5261578ebfc (bug 1662254)
2020-11-12 23:59:07 +02:00
c6c29e644b
Bug 1662254 - Minor comment fixes r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D90901
2020-11-12 19:05:08 +00:00
ebe551ba1a
Bug 1662254 - Merge ICCRunner and CCRunner into a single CCRunner r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D90633
2020-11-12 19:05:00 +00:00
7eea7384d6
Bug 1672597 - Part 1: Make EventQueuePriority the primary method of accessing task. r=smaug
...
This provides a cleaner API than using static_casts in code that begins directly using tasks.
Differential Revision: https://phabricator.services.mozilla.com/D94409
2020-10-27 15:29:16 +00:00
d28711aa34
Bug 1637592 - Part 2: Register name of new threads in appropriate places for profiler and debugger. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D94655
2020-10-27 15:29:13 +00:00
c6472cd2fb
Bug 1637592 - Part 1: Integrate off main thread task execution into TaskController. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D75105
2020-10-27 15:29:11 +00:00
02a7b4ebdf
Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
da1098d4aa
Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
...
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
c0cea3b0fa
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
42ea68d66a
Bug 1673026 - Change type of sCurrentTaskSeqNo to Atomic<uint64_t> r=bas
...
Differential Revision: https://phabricator.services.mozilla.com/D94608
2020-10-23 19:28:22 +00:00
1ff59cb7a3
Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE
2020-10-22 03:51:06 +03:00
Paul Bone
Kris Wright
Sean Feng
Bas Schouten
Simon Giesecke
Karl Tomlinson
Steve Fink
Razvan Maries
Byron Campen [:bwc]
Brindusan Cristian
Gerald Squelart
Sylvestre Ledru
Mihai Alexandru Michis
Emily McDonough
Bogdan Tara
Ricky Stewart
Denis Palmeiro
Dorel Luca