Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Nicholas Nethercote
2fcd08a173
Bug 1486690 - Rename NS_str{,}dup and remove unnecessary checks after calls to them. r=glandium
...
The 'x' prefix makes it clearer that these are infallible.
A couple of nsJSID methods are now also infallible.
--HG--
extra : rebase_source : fcce44a00212d6d341afbf3827b31bd4f7355ad5
2018-08-28 15:58:54 +10:00
Henri Sivonen
569510fbdc
Bug 1485289 - Use BeginWriting() instead of GetMutableData() in LateWriteChecks. r=froydnj
...
MozReview-Commit-ID: G64L8b6wnO0
Differential Revision: https://phabricator.services.mozilla.com/D3963
--HG--
extra : moz-landing-system : lando
2018-08-28 14:50:11 +00:00
Nathan Froyd
6026bc4fec
Bug 1471347 - part 2 - store an nsCString for SharedLibrary::mBreakpadId; r=njn
...
Similar to the previous part, we convert mBreakpadId to an nsCString to
avoid issues with locale-dependent std::string operations.
There are a lot of non-profiler changes here because a bunch of things
depend on the SharedLibrary object that the profiler defines.
2018-07-19 10:32:07 -04:00
Masatoshi Kimura
4872102e9d
Bug 1428557 - Stop using GetNativePath in xpcom/. r=froydnj
...
MozReview-Commit-ID: GnSFQ1wprzb
--HG--
extra : rebase_source : 7c25e0361d7f4e8aea730672a931cf78a581e062
extra : intermediate-source : e055aee7306b6636d27abe6fc0b02012b0075260
extra : source : d0831f473c8f85996c106693c9a4ce3783dd9447
2017-12-15 06:53:37 +09:00
Chris Peterson
37efe4d0e6
Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
...
MozReview-Commit-ID: DCPTnyBooIe
--HG--
extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13
extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec
extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
2017-11-05 19:37:28 -08:00
Sylvestre Ledru
d60d69e2cb
Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj
...
MozReview-Commit-ID: DjDkL20wRg0
--HG--
extra : rebase_source : a343d83d1f4e97e4ba56d0f57fec93079df0b5ea
2017-10-23 20:59:55 +02:00
Tom Ritter
701ee70a22
Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
...
MozReview-Commit-ID: 4v6tPF5aMz7
--HG--
extra : rebase_source : fe434db73a8da686391462c12b91648348abcdc9
2017-10-09 15:01:48 -05:00
Sebastian Hengst
ee63f2e30a
Backed out changeset 0317bcff40bc (bug 1406687) for build bustage at testing/gtest/gtest/src/gtest.cc:3871: 'Unused' was not declared in this scope. r=backout
2017-10-09 18:52:39 +02:00
Tom Ritter
22d2cdf063
Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
...
MozReview-Commit-ID: 4v6tPF5aMz7
--HG--
extra : rebase_source : c54b129c6815096035e262322f40aa0884b1ae56
2017-10-09 00:26:16 -05:00
Tom Ritter
c3169de381
Bug 1392630 Remove unused variables r=froydnj
...
MozReview-Commit-ID: eSbnMzdWZm
--HG--
extra : rebase_source : c432a7d08b845fc102251faadeb7200a4991294a
2017-08-22 09:16:31 -05:00
Nicholas Nethercote
08e54b7c13
Bug 1384819 (part 1) - Split MozStackWalk(). r=glandium.
...
MozStackWalk() is different on Windows to the other platforms. It has two extra
arguments, which can be used to walk the stack of a different thread.
This patch makes those differences clearer. Instead of having a single function
and forbidding those two arguments on non-Windows, it removes those arguments
from MozStackWalk, and splits off MozStackWalkThread() which retains them. This
also allows those arguments to have more appropriate types (HANDLE instead of
uintptr_t; CONTEXT* instead of than void*) and names (aContext instead of
aPlatformData).
The patch also removes unnecessary reinterpret_casts for the aClosure argument
at a couple of MozStackWalk() callsites.
--HG--
extra : rebase_source : 111ab7d6426d7be921facc2264f6db86c501d127
2017-07-27 12:46:47 +10:00
Randell Jesup
bafb1e730e
Bug 1344223 error-check mkstemp() r=froyd
...
MozReview-Commit-ID: 1z3cQXioTXP
2017-06-02 15:53:40 -04:00
Marco Castelluccio
732bc992ae
Bug 1341023 - Take module name encoding into account for late writes and hangs. r=Dexter
2017-02-21 22:44:42 +00:00
Tom Tromey
d2667a2b27
Bug 1060419 - make AppendPrintf and nsPrintfCString use Printf.h, r=froydnj
...
MozReview-Commit-ID: 2E8FoiNxU8L
--HG--
extra : rebase_source : 810ac727bef0751f24edea18c52e0ec170bf367d
2016-12-14 09:32:21 -07:00
Eric Rahm
acbdb31633
Bug 1322735 - Remove OBSERVE_LATE_WRITES define. r=glandium
...
OBSERVE_LATE_WRITES is now always defined, we can just remove it.
MozReview-Commit-ID: El6RnzZnXBN
--HG--
extra : rebase_source : 95fe63562b88c61ee5915e28a3a8b89c985042db
2016-12-20 15:29:05 -08:00
Eric Rahm
87cfbc1b65
Bug 1322735 - Remove MOZ_STACKWALKING define. r=glandium
...
With frame pointer omission disabled we should always have usable stacks on Windows. This allows us to remove the MOZ_STACKWALKING define as it will always be enabled.
MozReview-Commit-ID: 54xs3Hf1r4P
--HG--
extra : rebase_source : dfaf13fb4c2185985f4f074c338ccf1fef8f3c94
2016-12-20 15:11:36 -08:00
Phil Ringnalda
1c2d0d367f
Backed out 3 changesets (bug 1322735) for ASan leaks and xpcshell/selftest.py failures
...
CLOSED TREE
Backed out changeset 01cfc71ce542 (bug 1322735)
Backed out changeset 84c729c41230 (bug 1322735)
Backed out changeset b419aaefae95 (bug 1322735)
2017-01-10 20:17:34 -08:00
Eric Rahm
199bcd2df0
Bug 1322735 - Remove OBSERVE_LATE_WRITES define. r=glandium
...
OBSERVE_LATE_WRITES is now always defined, we can just remove it.
MozReview-Commit-ID: El6RnzZnXBN
--HG--
extra : rebase_source : fea565554ada76e489bf70f346993241d8d9c054
2016-12-20 15:29:05 -08:00
Eric Rahm
2e195de610
Bug 1322735 - Remove MOZ_STACKWALKING define. r=glandium
...
With frame pointer omission disabled we should always have usable stacks on Windows. This allows us to remove the MOZ_STACKWALKING define as it will always be enabled.
MozReview-Commit-ID: 54xs3Hf1r4P
--HG--
extra : rebase_source : 5fe27cdeeb464d81fbedc8c02ac187658bd759e7
2016-12-20 15:11:36 -08:00
Tomislav Jurin
348bfffc19
Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj
2016-12-02 13:46:53 -08:00
Benoit Girard
8d6a67f6d3
Bug 1172216 - Move nsStackwalk to mozglue. r=glandium
...
--HG--
rename : xpcom/base/nsStackWalk.cpp => mozglue/misc/StackWalk.cpp
rename : xpcom/base/nsStackWalk.h => mozglue/misc/StackWalk.h
extra : commitid : EMbWGfjKvdq
extra : rebase_source : b7308eb569cc1a019d3b7a92aaff0de7a49b5682
2015-06-10 16:32:45 -04:00
Andrew McCreight
1e0f87e27d
Bug 1151541, part 2 - Fix mode lines in xpcom/. r=froydnj
2015-04-09 10:25:05 -07:00
Aaron Klotz
6d8475512b
Bug 1150684: Remove XPCOM.h from IOInterposer.h; r=froydnj
...
--HG--
extra : rebase_source : a714c7ca5836d5e3a2c1b9da740795e653477cf1
2015-04-02 14:51:18 -06:00
Alessio Placitelli
d19436f3f5
Bug 1134279 - Change Telemetry data producers to use the correct recording flags. r=vladan
2015-03-23 04:39:00 +01:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Nicholas Nethercote
2eb56008e2
Bug 1062709 (part 1, attempt 2) - Add a frame number argument to NS_WalkStackCallback. r=dbaron.
...
--HG--
extra : rebase_source : 4f7060a9ae0bed180899651c50e8ea8857e72d63
2014-09-10 21:47:01 -07:00
Ed Morley
2d0f9579b5
Backed out changeset a0b82c954206 (bug 1062709) for Windows mochitest 5 hangs
2014-10-03 15:06:16 +01:00
Nicholas Nethercote
c9c64de53c
Bug 1062709 (part 1) - Add a frame number argument to NS_WalkStackCallback. r=dbaron.
...
--HG--
extra : rebase_source : 0f9b2d6310433ed56f5552706fcf2a96571aee25
2014-09-10 21:47:01 -07:00
Bob Owen
33eaabbf1f
Bug 1063455 - Define MOZ_STACKWALKING when NS_StackWalk is available and replace other instances of the same #if logic. r=mshal, r=froydnj
2014-09-08 18:25:20 +01:00
Birunthan Mohanathas
1368df8aae
Bug 1046841 - Convert xpcom/build/ to Gecko style. r=froydnj
2014-08-13 11:45:37 -07:00
Ehsan Akhgari
3a6aef3468
Bug 1048280 - Fix more bad implicit constructors in XPCOM; r=froydnj
2014-08-05 09:36:59 -04:00
Ehsan Akhgari
76f262cff3
Bug 950856 - Fail the build if you attempt to use NS_StackWalk on Windows where it won't work; r=froydnj,BenWa
2013-12-18 15:03:11 -05:00
Ryan VanderMeulen
0d91cad5c8
Backed out changeset fc0610680d3b (bug 950856) for Windows bustage.
...
CLOSED TREE
2013-12-18 16:01:44 -05:00
Ehsan Akhgari
54a364d5ac
Bug 950856 - Fail the build if you attempt to use NS_StackWalk on Windows where it won't work; r=froydnj,BenWa
...
--HG--
extra : rebase_source : 914250c939e4666f4a8630f7e9e57e466b669259
2013-12-18 15:03:11 -05:00
Birunthan Mohanathas
02a1314689
Bug 784739 - Switch from NULL to nullptr in miscellaneous directories; r=ehsan
2013-11-11 14:17:14 -05:00
Jonas Finnemann Jensen
41edf8980c
Bug 902587 - Part 2A: Refactor late-write-checks as client of IO Interposer. r=BenWa
...
--HG--
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/LateWriteChecks.h
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/PoisonIOInterposer.h
rename : xpcom/build/mozPoisonWriteBase.cpp => xpcom/build/PoisonIOInterposerBase.cpp
rename : xpcom/build/mozPoisonWriteMac.cpp => xpcom/build/PoisonIOInterposerMac.cpp
rename : xpcom/build/mozPoisonWriteWin.cpp => xpcom/build/PoisonIOInterposerWin.cpp
2013-11-05 07:45:20 -05:00