Граф коммитов

1251 Коммитов

Автор SHA1 Сообщение Дата
Jan Varga 4ad6f0533e Bug 1724895 - QM: Introduce type alias for Result<Ok, QMResult>; r=jari
This patch introduces a new type alias OkOrErr for Result<Ok, QMResult> and also converts some existing occurencies of Result<Ok, QMResult> to OkOrErr.

Differential Revision: https://phabricator.services.mozilla.com/D122206
2021-08-10 13:59:04 +00:00
Jari Jalkanen b2adac0d90 Bug 1711657 - Rename Note to Info in Severity enum and QM_TRY macros. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D121618
2021-08-04 09:39:55 +00:00
Jan Varga 00fa78b012 Bug 1661413 - Improve deleting files in DeleteFileManagerDirectory; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119588
2021-08-03 11:43:50 +00:00
Jan Varga e9546b5acd Bug 1621920 - Convert IDB client to use the new macro for warning about unknown stuff in .files directory and add handling of unknown directories in .files directory; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119586
2021-08-03 10:46:28 +00:00
Jan Varga 064a1e6a2a Bug 1719811 - QM: Replace FirstInitializationAttempt method with WithFirstInitializationAttempt; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119496
2021-08-03 03:24:19 +00:00
Jan Varga 480491b2be Bug 1719811 - QM: Remove FirstInitializationAttemptPending method from FirstInitializationAttempts class; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119495
2021-08-03 03:24:19 +00:00
Jari Jalkanen 131e54eda8 Bug 1722892 - Replace NS_ASSERTION uses in FileStreams.cpp r=janv,dom-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D121554
2021-08-03 02:47:22 +00:00
Jan Rio Krause c003ef765b Bug 1723503 - QM: Restore a blank line in QuotaManager::UpgradeFromPersistentStorageDirectoryToDefaultStorageDirectory r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D121538
2021-08-03 02:46:11 +00:00
Jan Varga 226a68d16d Bug 1718197 - Have a way to set QM_TRY context in ExecuteInitialization; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D118808
2021-07-31 16:32:14 +00:00
Jan Varga a418c56853 Bug 1718197 - Simplify access to FirstInitializationAttempt objects in initialization functions; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119389
2021-07-31 16:32:13 +00:00
Jan Varga e22168a74c Bug 1719281 - QM: Execute initializations in ExecuteInitialization() for real; r=dom-storage-reviewers,asuth
ExecuteInitialization now takes a function argument instead of nsresult so
initializations are executed in the context of ExecuteInitialization. This
patch also removes a temporary overload of ExecuteInitialization.

Differential Revision: https://phabricator.services.mozilla.com/D119263
2021-07-31 12:37:36 +00:00
Jan Varga f269c78d92 Bug 1719281 - QM: Add a generic wrapper for running initializations; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119182
2021-07-31 12:37:36 +00:00
Sandor Molnar 01917ee5ce Backed out 2 changesets (bug 1719281) for causing bc failures in FirstInitializationAttempts. CLOSED TREE
Backed out changeset 58b39579def6 (bug 1719281)
Backed out changeset d6801824d47d (bug 1719281)
2021-07-30 21:53:23 +03:00
Jan Varga 107d5083bc Bug 1719281 - QM: Execute initializations in ExecuteInitialization() for real; r=dom-storage-reviewers,asuth
ExecuteInitialization now takes a function argument instead of nsresult so
initializations are executed in the context of ExecuteInitialization. This
patch also removes a temporary overload of ExecuteInitialization.

Differential Revision: https://phabricator.services.mozilla.com/D119263
2021-07-30 17:51:58 +00:00
Jan Varga 3a089efdf2 Bug 1719281 - QM: Add a generic wrapper for running initializations; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119182
2021-07-30 17:51:58 +00:00
Luca Greco e723364e2c Bug 1720487 - Ensure QuotaManager does not evict PERSISTENT_TYPE_DEFAULT data associated to a WebExtension origin. r=dom-storage-reviewers,asuth
This patch introduce an additional check inside the Helper::GetInactiveOriginInfos static method
used internally by CollectOriginsForEviction to ensure that QuotaManager will not select an
extension origin as an inactive origin to evict non persisted data from.

The rationale is that unlike websites (which may more likely using the locally stored data
as a local cache, but still able to retrieve the same data again from the server side),
extensions do not have a remote counterpart and so evicting their data would result
into potential data loss for the users.

Besides that, the browser extensions (unlike websites) are explicitly installed and uninstalled by
the user and all the data associated to the extension will be completely removed when the
extension is uninstalled.

Differential Revision: https://phabricator.services.mozilla.com/D120470
2021-07-21 19:27:45 +00:00
Gijs Kruitbosch bcbf4ea5cd Bug 1714583 - allow nsIFile::Create to skip creating ancestor directories, to fix IOUtils::makeDirectory, to fix UNC default download folders, r=barret,xpcom-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D120338
2021-07-21 18:38:12 +00:00
Jens Stutte 5c48750ff8 Bug 1702421: *::PrepareOriginDirectory should report GetDirectoryMetadata failures as warning only. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D118811
2021-06-25 10:24:23 +00:00
Jan Varga 28f6cf6f67 Bug 1718190 - QM: Move ScopedLogExtraInfo into own h/cpp files; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118807
2021-06-25 10:21:27 +00:00
Jan Varga 66e7ce052c Bug 1717990 - QM: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118676
2021-06-25 06:27:59 +00:00
Jan Varga b0e742b2d6 Bug 1717990 - QM: Ignore NS_ERROR_ABORT in RecordFirstInitializationAttempt; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118675
2021-06-25 06:27:58 +00:00
Jan Varga 5e3c6d6fc1 Bug 1716570 - LSNG: Add QM_TRY context for PrepareDatastoreOp::DatabaseWork; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118673
2021-06-25 02:46:13 +00:00
Jan Varga 8c85f70a06 Bug 1716569 - Add QM_TRY context for EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D118143
2021-06-24 03:50:17 +00:00
Jan Varga 1e2a90da03 Bug 1716569 - Rename existing QM_TRY contexts; r=dom-storage-reviewers,jstutte
- the dom::quota:: prefix has been added
- it's now clear that the contexts are set only during first initialization
attempts

Differential Revision: https://phabricator.services.mozilla.com/D118142
2021-06-24 03:50:16 +00:00
Jan Varga 614eb7e4fe Bug 1716568 - Add support for origin based first initialization attempts handling to InitializationInfo; r=dom-storage-reviewers,asuth
The existing custom implementation of origin based first initialization
attempts handling has been replaced with the new generic implementation.

Differential Revision: https://phabricator.services.mozilla.com/D118141
2021-06-23 21:26:10 +00:00
Jan Varga e6e7042dab Bug 1716568 - Extract first initialization attempts handling into a generic (templatized) class; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118140
2021-06-23 21:26:10 +00:00
Jan Varga 3fb3dcb5a1 Bug 1716568 - Rename mInitializationAttempts in InitializationInfo to mFirstInitializationAttempts; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118139
2021-06-23 21:26:09 +00:00
Jan Varga 39a2fe3293 Bug 1716568 - Consolidate InitializationInfo::AutoInitializationAttempt class; r=dom-storage-reviewers,jstutte
- the class has been renamed to FirstInitializationAttemptImpl
- the class no longer automatically records first initialization attempts in
its destructor (the auto funcionality has been removed)
- the method names have been shortened
- new methods have been added
- the class is now intended to just forward calls to the owner

Differential Revision: https://phabricator.services.mozilla.com/D118138
2021-06-23 21:26:09 +00:00
Jan Varga b746baa6d7 Bug 1716568 - Rename ResetInitializationAttempts in InitializationInfo to ResetFirstInitializationAttempts; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118135
2021-06-23 21:26:08 +00:00
Jan Varga 3867a0d9b9 Bug 1716568 - Consolidate InitializationInfo::ReportFirstInitializationAttempt; r=dom-storage-reviewers,jstutte
- the method has been renamed to RecordFirstInitializationAttempt
- the second argument has been changed from bool to nsresult
- the method has been made public

Differential Revision: https://phabricator.services.mozilla.com/D118134
2021-06-23 21:26:08 +00:00
Jan Varga 23e78584a2 Bug 1716568 - Add Maybe prefix to InitializationInfo::RecordFirstInitializationAttempt; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118133
2021-06-23 21:26:07 +00:00
Jan Varga b545dac60b Bug 1716568 - Consolidate InitializationInfo::InitializationAttempted; r=dom-storage-reviewers,jstutte
- AssertInitializationAttempted has been removed
- InitializationAttempted has been renamed to FirstInitializationAttemptRecorded
- FirstInitializationAttemptPending has been added

Differential Revision: https://phabricator.services.mozilla.com/D118132
2021-06-23 21:26:07 +00:00
Jan Varga 3a8312aeeb Bug 1716568 - Move implementation details of InitializationInfo to a cpp file; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D118131
2021-06-23 21:26:07 +00:00
Nika Layzell 1aaeb179e2 Bug 1715144 - Part 1: Stop adding /ipc/glue to LOCAL_INCLUDES when including chromium-config.mozbuild, r=ipc-reviewers,necko-reviewers,mccr8,valentin
Differential Revision: https://phabricator.services.mozilla.com/D117103
2021-06-09 04:56:48 +00:00
Jan Varga 5770ce1b8f Bug 1713820 - Never inline LogError if the definition is not empty; r=dom-storage-reviewers,jstutte
MOZ_NEVER_INLINE can't 100% guarantee that all compilers never inline such
functions, but the current combination of MOZ_COLD and MOZ_NEVER_INLINE
produces sane builds with only minor code size increase (max 0.19% increase).

Differential Revision: https://phabricator.services.mozilla.com/D117142
2021-06-08 16:27:32 +00:00
Jan Varga 7bd33c1d2e Bug 1713820 - Enable QM_TRY reporting to the browser console in release builds; r=dom-storage-reviewers,jstutte
Failures are not reported to the browser console until a context information is
available like the storage or temporary storage initialization.

Differential Revision: https://phabricator.services.mozilla.com/D117141
2021-06-08 16:27:32 +00:00
Jan Varga 0c9e2f093f Bug 1713820 - Introduce dedicated identifiers for different types of logging and define QM_LOG_ERROR_ENABLED only when at least one such type is defined; r=dom-storage-reviewers,jstutte
This patch doesn't enable or disable logging in specific builds.

Differential Revision: https://phabricator.services.mozilla.com/D117140
2021-06-08 16:27:32 +00:00
Jan Varga 61f3180e41 Bug 1713820 - Don't report to the browser console if the context string is empty; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117139
2021-06-08 16:27:31 +00:00
Jan Varga ceffdfbfbc Bug 1713820 - Allow to use the context string in other types of logging; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117138
2021-06-08 16:27:31 +00:00
Jan Varga b04b4c5166 Bug 1713820 - Change the order of helper variable defintion in LogError to match the use in log message construction; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117137
2021-06-08 16:27:31 +00:00
Jan Varga 1012045fb5 Bug 1713820 - Use QM_SCOPED_LOG_EXTRA_INFO_ENABLED in CachingDatabaseConnection instead of defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG); r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117136
2021-06-08 16:27:30 +00:00
Jan Varga daa6cfff06 Bug 1713820 - Rename QM_ENABLE_SCOPED_LOG_EXTRA_INFO to QM_SCOPED_LOG_EXTRA_INFO_ENABLED; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117135
2021-06-08 16:27:30 +00:00
Jan Varga b55c49563c Bug 1713820 - Move QM_ENABLE_SCOPED_LOG_EXTRA_INFO definition to Config.h; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117134
2021-06-08 16:27:29 +00:00
Jan Varga 2b16e677f8 Bug 1713820 - Move QM_ERROR_STACKS_ENABLED definition to Config.h; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117133
2021-06-08 16:27:29 +00:00
Jan Varga 74cdcac137 Bug 1713820 - Add dedicated QM_LOG_ERROR_ENABLED identifier for conditional LogError compilation; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D117132
2021-06-08 16:27:28 +00:00
Jens Stutte c306a7c001 Bug 1711703: Ensure we split stacks before errors after warnings. r=dom-storage-reviewers,janv DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D116614
2021-06-03 17:15:51 +00:00
Jan Varga f4a3bc258f Bug 1711848 - Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115465
2021-06-01 13:58:27 +00:00
Jan Varga f7d0092e58 Bug 1711656 - Rename QM_OR_ELSE_LOG to QM_OR_ELSE_LOG_VERBOSE; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115363
2021-06-01 12:12:27 +00:00
Jan Varga 43513f4134 Bug 1708643 - QM: Replace QM_OR_ELSE_(WARN|LOG) with QM_OR_ELSE_(WARN|LOG)_IF in places where the fallback needs to be called conditionally; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D114846
2021-05-30 11:08:02 +00:00
Jan Varga 5977b6fdeb Bug 1708643 - Add generic predicate and fallback functions for QM_OR_ELSE_(WARN|NOTE|LOG)_IF; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D114935
2021-05-30 06:37:28 +00:00
Jan Varga 08cbb7600c Bug 1708643 - Add QM_OR_ELSE_WARN_IF/QM_OR_ELSE_NOTE_IF/QM_OR_ELSE_LOG_IF macros; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D114844
2021-05-30 06:37:27 +00:00
Jan Varga af5c723feb Bug 1708643 - Fix the comment for QM_OR_ELSE_WARN; r=dom-storage-reviewers,jstutte
Changes in the comment:
- specifies the severity passed to HandleError
- specifies that a fallback function produces a new result

Differential Revision: https://phabricator.services.mozilla.com/D114918
2021-05-29 05:05:39 +00:00
Jan Varga 7d1d36d350 Bug 1708643 - Rename orElseFunc argument to fallback in QM_OR_ELSE_REPORT definition; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114843
2021-05-29 05:05:39 +00:00
Jan Varga b05e273b86 Bug 1708643 - Use a common internal macro for definition of QM_OR_ELSE_(WARN|NOTE|LOG); r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114842
2021-05-29 05:05:38 +00:00
Jan Varga f01ca1d5b2 Bug 1709352 - Clean up and polish LogError; r=dom-storage-reviewers,jstutte
Depends on D116121

Differential Revision: https://phabricator.services.mozilla.com/D116222
2021-05-28 16:33:41 +00:00
Jan Varga 2586de8e82 Bug 1709352 - Add missing mozilla/Variant.h include to QuotaCommon.h; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D116121
2021-05-28 16:33:40 +00:00
Jens Stutte 61d67b9ff0 Bug 1706998: Replace QuotaManager::GetRef().MaybeRecordShutdownStep by static QuotaManager::(Safe)MaybeRecordQuotaClientShutdownStep; r=dom-storage-reviewers,janv
There are some few unsafe uses of MaybeRecordShutdownStep where the QuotaManager singleton may be  not (yet or anymore) alive.
In order to not add many unnecessary null checks, we drop GetRef and MaybeRecordShutdownStep in favor of
QuotaManager::MaybeRecordQuotaClientShutdownStep
QuotaManager::SafeMaybeRecordQuotaClientShutdownStep
with the sole difference that the Safe variant runtime checks the singleton, while the normal one only asserts.

Differential Revision: https://phabricator.services.mozilla.com/D115988
2021-05-28 06:46:04 +00:00
Jan Varga 9111e8dffc Bug 1709352 - Fix compilation when QM_ERROR_STACKS_ENABLED is not defined; r=dom-storage-reviewers,asuth
LogError signature is now separately defined for the case when
QM_ERROR_STACKS_ENABLED is defined and when it's not defined).
HandleError has been changed as well to have explicit handling depending on
QM_ERROR_STACKS_ENABLED.
TestQMResult.cpp has been fixed to compile with undefined
QM_ERROR_STACKS_ENABLED in non-unified builds.

Differential Revision: https://phabricator.services.mozilla.com/D116070
2021-05-27 16:33:32 +00:00
Jan Varga 31744e4062 Bug 1709352 - Follow-up patch to fix indentation; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115869
2021-05-25 09:36:10 +00:00
Jan Varga 67f10dbbd4 Bug 1709352 - Remove the module extra key from LogError; r=dom-storage-reviewers,jstutte
The appening of module extra key was already commented out.

Differential Revision: https://phabricator.services.mozilla.com/D114739
2021-05-25 09:06:12 +00:00
Jan Varga 1afda44bfb Bug 1709352 - Support error stacks only in EARLY_BETA_OR_EARLIER) || DEBUG builds; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114736
2021-05-25 09:06:11 +00:00
Jan Varga d3de310d61 Bug 1709352 - Define LogError only when needed; r=dom-storage-reviewers,jstutte
This makes it consistent with other places where we check EARLY_BETA_OR_EARLIER
and DEBUG identifier. For example HandleError.

Differential Revision: https://phabricator.services.mozilla.com/D114735
2021-05-25 09:06:11 +00:00
Jan Varga b96826b190 Bug 1709352 - Add frame_id, process_id and stack_id to QM_TRY telemetry; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114340
2021-05-25 09:06:10 +00:00
Jan Varga b3a993972a Bug 1709352 - Reorder appending of extra keys to match the definition in Events.yaml; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114339
2021-05-25 09:06:10 +00:00
Jan Varga 137071aa29 Bug 1709352 - Add logging support for QMResult; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114338
2021-05-25 09:06:10 +00:00
Jan Varga 159ef171f9 Bug 1709352 - Convert MaybeRemoveLocalStorageArchiveTmpFile to return Result<Ok, QMResult>; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D114245
2021-05-25 07:28:21 +00:00
Jan Varga c06f56c861 Bug 1709352 - Allow QMResult errors to use existing stack id and to increase the frame id during error propagation; r=dom-storage-reviewers,asuth,glandium
Differential Revision: https://phabricator.services.mozilla.com/D114243
2021-05-25 07:28:20 +00:00
Jan Varga 01123f15c4 Bug 1709352 - Add ToResult function for QMResult; r=dom-storage-reviewers,jstutte,asuth
Differential Revision: https://phabricator.services.mozilla.com/D114242
2021-05-25 07:28:19 +00:00
Jan Varga 3f78809e7b Bug 1709352 - Introduce QMResult; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114241
2021-05-25 07:28:19 +00:00
Jan Varga 52086b9801 Bug 1711181 - Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=dom-storage-reviewers,jstutte
This is more consistent with other cases where we either use QM_OR_ELSE_WARN or
QM_OR_ELSE_NOTE. We will later change some uses of QM_OR_ELSE_LOG to
QM_OR_ELSE_LOG_IF. The switch from custom OrElseIf to Result::orElseIf will be
easier when we don't use OrElseIf directly.

This patch only changes uses of ordinary orElse introduced in bug 1701346.

Remaining uses will be handled in bug 1711180 (the ones that were missed in bug
1686191).

Differential Revision: https://phabricator.services.mozilla.com/D115055
2021-05-21 09:30:30 +00:00
Jan Varga cb7151e618 Bug 1711181 - Add QM_OR_ELSE_LOG macro; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114936
2021-05-21 09:30:29 +00:00
Andi-Bogdan Postelnicu eab549fd19 Bug 1519636 - Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre
clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)

Differential Revision: https://phabricator.services.mozilla.com/D114211
2021-05-10 07:15:07 +00:00
Andi-Bogdan Postelnicu a1f2f7329d Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,valentin,sylvestre
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)

Differential Revision: https://phabricator.services.mozilla.com/D114618
2021-05-10 07:15:06 +00:00
Jan Varga e9c1a62d68 Bug 1709067 - QM: Remove the ability to define module specific QM_TRY macros; r=dom-storage-reviewers,asuth
Depends on D114083

Differential Revision: https://phabricator.services.mozilla.com/D114084
2021-05-03 19:44:40 +00:00
Jan Varga 42a2a6727f Bug 1709067 - IDB: Remove module specific QM_TRY macros; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114080
2021-05-03 19:44:38 +00:00
Jan Varga 2372314fa1 Bug 1690025 - Move and rename DirectoryLock::Specialize to UniversalDirectoryLock::SpecializeForClient; r=dom-storage-reviewers,asuth
This patch also changes the only consumer to not depend on the lock passed to
OpenDirectoryListener::DirectoryLockAcquired because it uses the base type (
unsafe static_cast would have to be used).

Differential Revision: https://phabricator.services.mozilla.com/D104804
2021-05-02 09:57:15 +00:00
Jens Stutte 9c9f57574e Bug 1700915: Change the max_delta heuristics to look at average time, sort stacks for hit count rather than clients and add aborted stacks to output. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D113212
2021-04-29 07:04:33 +00:00
Jan Varga b6252c8c28 Bug 1701346 - QM: Revert QM_OR_ELSE_WARN to ordinary orElse in GetDirEntryKind; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D113527
2021-04-28 07:33:55 +00:00
Jan Varga cf5e9e7c32 Bug 1690326 - Follow-up fix for the ERROR_FILE_CORRUPT to NS_ERROR_FILE_FS_CORRUPTED mapping; r=jstutte
The code which depends on the old generic NS_ERROR_MODULE_WIN32 mapping needs
to be updated too.

Depends on D113505

Differential Revision: https://phabricator.services.mozilla.com/D113518
2021-04-28 07:33:54 +00:00
Jan Varga d213540b73 Bug 1702422 - Add missing include to create_db.js in groupMismatch_profile.zip; r=dom-storage-reviewers,asuth
This patch also fixes the unset "accessed" flag in the origin table in
storage.sqlite.

Differential Revision: https://phabricator.services.mozilla.com/D113491
2021-04-28 07:33:53 +00:00
Jan Varga c9b2e50517 Bug 1702422 - Add missing include to create_db.js in removedOrigin_profile.zip; r=dom-storage-reviewers,asuth
An empty buffer was stored in SimpleDB because of the missing include.

Differential Revision: https://phabricator.services.mozilla.com/D113490
2021-04-28 07:33:53 +00:00
Jan Varga a43be2a21f Bug 1702422 - Report failed LoadQuotaFromCache as a warning (instead of an error); r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D113370
2021-04-27 07:12:23 +00:00
Jan Varga 4bd1418875 Bug 1702422 - Move tests intended for quota info caching into a standalone directory; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D113369
2021-04-27 07:12:22 +00:00
Jan Varga 8fd7eedb03 Bug 1701346 - QM: Add a comment for QM_OR_ELSE_WARN in CreateOrUpgradeDirectoryMetadataHelper::MaybeUpgradeOriginDirectory; r=asuth,dom-storage-reviewers,jstutte
Depends on D113066

Differential Revision: https://phabricator.services.mozilla.com/D113067
2021-04-24 08:58:31 +00:00
Jan Varga 74252f6ada Bug 1701346 - QM: Fix the comment in EnsureDirectory; r=asuth,dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D113066
2021-04-24 08:58:31 +00:00
Jan Varga 4d52706661 Bug 1702415 - Fix relative path calculation of exported source files (like QuotaCommon.h); r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D112999
2021-04-23 13:59:42 +00:00
Jan Varga 6a56d8311f Bug 1702415 - Replace aSourceLine with aSourceFileLine; r=dom-storage-reviewers,jstutte,asuth
Differential Revision: https://phabricator.services.mozilla.com/D113077
2021-04-23 12:02:58 +00:00
Jan Varga 3323c1e8c3 Bug 1702415 - Replace aSourceFile with aSourceFilePath; r=dom-storage-reviewers,jstutte,asuth
This patch adjusts other similar names as well:
MakeRelativeSourceFileName -> MakeSourceFileRelativePath
relativeSourceFile -> sourceFileRelativePath
thisFileRelativeSourceFileName -> thisSourceFileRelativePath

Differential Revision: https://phabricator.services.mozilla.com/D113076
2021-04-23 12:02:58 +00:00
imoraru c3a79c6d69 Backed out 3 changesets (bug 1702415) for causing quota related build bustages. CLOSED TREE
Backed out changeset d10768c1b3ae (bug 1702415)
Backed out changeset e00a02611cd4 (bug 1702415)
Backed out changeset 2d54750b9f34 (bug 1702415)
2021-04-23 13:27:42 +03:00
Jan Varga a10db98510 Bug 1702415 - Fix relative path calculation of exported source files (like QuotaCommon.h); r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D112999
2021-04-23 09:56:30 +00:00
Jan Varga 192af47698 Bug 1702415 - Replace aSourceLine with aSourceFileLine; r=dom-storage-reviewers,jstutte,asuth
Differential Revision: https://phabricator.services.mozilla.com/D113077
2021-04-23 09:56:30 +00:00
Jan Varga c831b279f3 Bug 1702415 - Replace aSourceFile with aSourceFilePath; r=dom-storage-reviewers,jstutte,asuth
This patch adjusts other similar names as well:
MakeRelativeSourceFileName -> MakeSourceFileRelativePath
relativeSourceFile -> sourceFileRelativePath
thisFileRelativeSourceFileName -> thisSourceFileRelativePath

Differential Revision: https://phabricator.services.mozilla.com/D113076
2021-04-23 09:56:29 +00:00
Jens Stutte d19d0c34c3 Bug 1706928: Ignore duplicate telemetry events and increase the maximum delay between consecutive propagation stack frames. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D113106
2021-04-22 11:03:38 +00:00
Jan Varga e981a6fd53 Bug 1703310 - Enable LocalStorage NextGen (LSNG) when "network.cookie.lifetimePolicy" is set to ACCEPT_SESSION (2); r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D112326
2021-04-17 03:20:17 +00:00
Tom Tung be03b11109 Bug 1700676 - Unregister the lock itself before unblock other locks; r=dom-storage-reviewers,sg,janv
Differential Revision: https://phabricator.services.mozilla.com/D109640
2021-04-16 01:09:11 +00:00
Tom Tung 1631cf13b6 Bug 1647316 - Update expected file layout for test_originMismatch since the padding file will be removed if the caches.sqlite doesn't exist after initializing; r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D109639
2021-04-16 01:09:11 +00:00
Tom Tung c994e030b2 Bug 1647316 - Revert the change for test_initTemporaryStorage.js since we have test_originInit.js; r=dom-workers-and-storage-reviewers,janv
Depends on D80823

Differential Revision: https://phabricator.services.mozilla.com/D80824
2021-04-16 01:09:09 +00:00
Jens Stutte 9c2ff2bbbd Bug 1704433: Promote AssertIsOnIOThread to DiagnosticAssertIsOnIOThread in QuotaManager::EnsureStorageIsInitialized r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D112202
2021-04-15 16:15:28 +00:00
Jens Stutte 9f7b34c24e Bug 1700915: Python scripts that fetch and analyze QM_TRY errors. r=dom-storage-reviewers,janv
These scripts are not shipped with Firefox but serve to analyze the
telemetry data sent by the QM_TRY family of macros.

Differential Revision: https://phabricator.services.mozilla.com/D110277
2021-04-08 10:01:36 +00:00
Jan Varga 1c19e643ec Bug 1701346 - QM: Revert QM_OR_ELSE_WARN to ordinary orElse in EnsureDirectory; r=jstutte
Differential Revision: https://phabricator.services.mozilla.com/D109987
2021-03-26 22:55:18 +00:00