6 Коммитов

Автор	SHA1	Сообщение	Дата
Sylvestre Ledru	265e672179	Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format ... # ignore-this-changeset --HG-- extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022	2018-11-30 11:46:48 +01:00
Robert Bartlensky	50df265ee1	Bug 1471943: Remove release call to ensure socket is closed. r=valentin ... MozReview-Commit-ID: 8RC4YdaqAdX --HG-- extra : rebase_source : 029eeaad0a1eea60a9dce56756160a827b522d30	2018-07-02 11:45:39 +01:00
Jan Keromnes	57720f1ea5	Bug 1372853 - Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr). r=valentin	2017-06-16 01:35:00 -04:00
Nicholas Nethercote	34dcc7b852	Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. ... This change avoids lots of false positives for Coverity's CHECKED_RETURN warning, caused by NS_WARN_IF's current use in both statement-style and expression-style. In the case where the code within the NS_WARN_IF has side-effects, I made the following change. > NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); > --> > Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); In the case where the code within the NS_WARN_IF lacks side-effects, I made the following change. > NS_WARN_IF(!condWithoutSideEffects); > --> > NS_WARNING_ASSERTION(condWithoutSideEffects, "msg"); This has two improvements. - The condition is not evaluated in non-debug builds. - The sense of the condition is inverted to the familiar "this condition should be true" sense used in assertions. A common variation on the side-effect-free case is the following. > nsresult rv = Fn(); > NS_WARN_IF_(NS_FAILED(rv)); > --> > DebugOnly<nsresult rv> = Fn(); > NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed"); --HG-- extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611	2016-09-02 17:12:24 +10:00
Andi-Bogdan Postelnicu	932e09d8e4	Bug 1278504 - fixed buffer not null terminated. r=valentin ... MozReview-Commit-ID: 4V1YcK2thiF --HG-- extra : rebase_source : d7b574f8a36de604d7d48c33ca8b920a5659dbb5	2016-06-07 15:44:11 +03:00
Kannan Vijayan	e4d6db6820	Bug 1272101 - Changes in preparation for FlyWeb landing. Add nsINetworkInfoService and implementation for various platforms. r=hurley	2016-06-01 16:16:40 -04:00