Граф коммитов

10424 Коммитов

Автор SHA1 Сообщение Дата
Julien Wajsberg 44009be00a Bug 1813310 - Do not instanciate the Profiler Runnable RAII if the profiler isn't running r=florian
In Bug 1688300, we implemented that we emit markers when a Runnable
runs. But this has some performance consequences because we instanciate
the RAII even when the profiler doesn't run, even though we don't do
anything in it. Especially we're running TimeStamp::Now() which can be
slow on some platforms.

This patch avoids this by instanciating the RAII only when the profiler
runs.

Differential Revision: https://phabricator.services.mozilla.com/D168374
2023-01-31 17:24:05 +00:00
Gijs Kruitbosch 17c6749deb Bug 1795255 - Enable rule no-redeclare-with-import-autofix for browser tests, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D166178
2023-01-31 11:48:41 +00:00
Gijs Kruitbosch 2defa4450d Bug 1795255 - add no-redeclare-with-import-autofix eslint rule to deal with duplicate imports in tests, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D166177
2023-01-31 11:48:40 +00:00
Mark Banner 106725dcfc Bug 1813377 - Clean up XPCNativeWrapper globals handling for ESLint. r=mccr8
XPCNativeWrapper may be going away (bug 1481337). Stop defining it in the main environments and only define it
where necessary to discourage more uses.
This also helps to clarify the ESLint test environment globals.

Differential Revision: https://phabricator.services.mozilla.com/D168211
2023-01-30 21:55:25 +00:00
Mark Banner 79d86dc983 Bug 1812977 - Add basic support for loadSubScript handling to ESLint. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D168068
2023-01-30 19:33:36 +00:00
Mark Banner cc23ce6654 Bug 1812977 - Move ESLint functions for globals handling from helpers.js to globals.js. r=Gijs
This is a better location for these functions and helps avoid circular dependencies in the next patches.

Differential Revision: https://phabricator.services.mozilla.com/D168067
2023-01-30 19:33:36 +00:00
Kash Shampur b6e561f1f7 Bug 1803109 - Add test for checking very long strings in profiler markers. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D167830
2023-01-27 17:25:37 +00:00
Zeid e7df27d603 Bug 1797929: add mots to mach_commands r=sheehan
- add command and subcommand definitions for mots
- define some helper methods to reduce repetition

Differential Revision: https://phabricator.services.mozilla.com/D163110
2023-01-27 14:55:18 +00:00
Mark Banner 99c7240948 Bug 1812973 - Add xulStore interface to ESLint's services.json. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D168042
2023-01-27 10:00:31 +00:00
Dana Keeler 4d2b1f7538 Bug 1811633 - use updated, vendored version of PKI.js, remove old version r=Gijs
This also converts certDecoder.jsm to an ES module (as certDecoder.mjs) and
updates all uses of it.

Differential Revision: https://phabricator.services.mozilla.com/D167466
2023-01-27 04:07:10 +00:00
Fabrice Le Fessant 98cfeed071 Bug 1810126 - Add a generic mechanism to run cargo-* commands. r=glandium,firefox-build-system-reviewers,ahochheiden
`mach cargo COMMAND` will run `cargo-COMMAND` using `cargo build`
arguments by default. However, it is possible to tune the arguments
using either command-line arguments, or a YAML file in `config/cargo/`.
A file `config/cargo/template.yaml` can be used to create a new
configuration for a new cargo sub-command.

Differential Revision: https://phabricator.services.mozilla.com/D166780
2023-01-27 01:18:52 +00:00
Mike Conley 11c1ad2cd7 Bug 1756878 - Add a linter to enforce alphabetical ordering for mochitest manifests. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D141264
2023-01-26 16:24:33 +00:00
Francesco Lodolo (:flod) 7c57e229c9 Bug 1812568 - Fluent linter: Reset comment and variable references after reading terms, r=eemeli
Differential Revision: https://phabricator.services.mozilla.com/D167925
2023-01-26 14:30:17 +00:00
Noemi Erli e287ab9d9a Backed out 2 changesets (bug 1811633) for causing lint bustage CLOSED TREE
Backed out changeset 3ef0fe45b191 (bug 1811633)
Backed out changeset 92a7ec78a4ce (bug 1811633)
2023-01-26 02:26:54 +02:00
Dana Keeler 78cdb5eb07 Bug 1811633 - use updated, vendored version of PKI.js, remove old version r=Gijs
This also converts certDecoder.jsm to an ES module (as certDecoder.mjs) and
updates all uses of it.

Differential Revision: https://phabricator.services.mozilla.com/D167466
2023-01-26 00:07:49 +00:00
Francesco Lodolo (:flod) bcc543d625 Bug 1812011 - Add check for missing variable comments, r=gregtatum,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D167787
2023-01-25 21:18:32 +00:00
ogiorgis 892f701477 Bug 1749473 - fix warnings like unknown code language: None r=firefox-source-docs-reviewers,perftest-reviewers,sylvestre,sparky DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D167776
2023-01-25 13:41:05 +00:00
Andrew Creskey 78d06d6746 Bug 1810871 - Add perfstats to capture internal necko timings - async open to transaction pending and response start parent to content r=bas,necko-reviewers,kershaw
These timings look to be slow in the beta population so adding Perfstats to help test improvements.

Differential Revision: https://phabricator.services.mozilla.com/D167585
2023-01-25 13:28:49 +00:00
Nazım Can Altınova 51d41599d4 Bug 1811450 - Do not cap Firefox version on profiler metadata r=florian
Since Bug 1805967 Firefox version is capped to 109 due to some web
compatibility issues. This resulted us to add the wrong Firefox version in the
profiler metadata. We don't have the same webcompat related concerns and it's
important to see the real version so data is more accurate when performance
engineers look at the profiles of others.

This http misc field was populated here:
https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/netwerk/protocol/http/nsHttpHandler.cpp#407-415
and UA version comes from this function which uses `MOZILLA_UAVERSION` directly:
https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/netwerk/protocol/http/nsHttpHandler.cpp#303-320

Differential Revision: https://phabricator.services.mozilla.com/D167657
2023-01-24 14:18:31 +00:00
Nazım Can Altınova 14419ecf1f Bug 1615546 - Remove the optimizations field from profiler frame table r=julienw
This requires https://github.com/firefox-devtools/profiler/pull/4432 to be
landed and deployed. We bump the profile version in this patch.

Afaik we never used the optimizations field of the frame table in the profiler
frontend and this pfield was null for more than 3 years (since Bug 1614622).
We don't have any plans to make use of it any time soon. It's good to cleanup
this field so it doesn't clutter the profile data and we can reduce the profile
data size.

Differential Revision: https://phabricator.services.mozilla.com/D167290
2023-01-24 13:18:43 +00:00
Nazım Can Altınova af63479fe2 Bug 1811804 - Stop the profiler after capturing a profile on an Android device r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D167578
2023-01-24 11:12:42 +00:00
Gregory Pappas afbdb98adf Bug 1804264 - Refactor PermissionUI to use JS class r=pbz
Also, esmify.

Differential Revision: https://phabricator.services.mozilla.com/D167074
2023-01-23 21:53:19 +00:00
Greg Mierzwinski 28dfb3982f Bug 1811546 - Clean up docs, and add FAQ section to the mach try perf docs. r=perftest-reviewers,kshampur
This patch adds an FAQ (Frequently Asked Questions) section to the mach try perf docs. It also does a small cleanup to move fxrecord into the `testing/performance` folder, re-organize the linting configuration file, fix file naming, and captializes the `mozperftest` and `fxrecord` title names in the side-bar. Lastly, it adds a warning to the `mozperftest` docs to direct people who make it there to the `mach try perf` page.

Differential Revision: https://phabricator.services.mozilla.com/D167555
2023-01-23 18:31:31 +00:00
Mark Banner 351482d35e Bug 1808400 - Handle cases of .then(foo, Cu.reportError) in ESLint rule no-cu-reportError. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D167520
2023-01-23 18:09:04 +00:00
Noemi Erli 86d59c0b78 Backed out changeset c37b70009a8b (bug 1804264) for causing failures in Geolocation.cpp CLOSED TREE 2023-01-23 19:11:47 +02:00
cdengler 3a2b24f085 Bug 1807831 - Add a check to make sure that we don't regress the number of warnings r=sylvestre,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D167528
2023-01-23 16:49:17 +00:00
ogiorgis 1dfa7e23a3 Bug 1557020 - Don't remove unaccounted files while building docs r=sylvestre
While copying sphinx files, some unmodified static files were deleted.

Differential Revision: https://phabricator.services.mozilla.com/D167397
2023-01-23 16:40:07 +00:00
Gregory Pappas e8231395b2 Bug 1804264 - Refactor PermissionUI to use JS class r=pbz
Also, esmify.

Differential Revision: https://phabricator.services.mozilla.com/D167074
2023-01-23 16:30:32 +00:00
Eden Chuang 14ff5b1650 Bug 1351231 - Integrate FetchChild into Fetch.cpp r=dom-worker-reviewers,jesup
Depends on D142437

Differential Revision: https://phabricator.services.mozilla.com/D142704
2023-01-20 09:09:18 +00:00
Gijs Kruitbosch 8be066753c Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - other directories - r=Standard8,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D167154
2023-01-19 20:16:43 +00:00
Bilal ea77d6c67f Bug 1798635 - Converted WebChannel JSM modules to ESM. r=kpatenio,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D167216
2023-01-19 18:07:33 +00:00
Noemi Erli 2a016fbd8d Backed out 5 changesets (bug 1351231) for causing multiple wpt failures CLOSED TREE
Backed out changeset 257553919696 (bug 1351231)
Backed out changeset 4fd92351d64b (bug 1351231)
Backed out changeset 7a4e3f5f674a (bug 1351231)
Backed out changeset 9da00c1364a5 (bug 1351231)
Backed out changeset 19b78046ffef (bug 1351231)
2023-01-18 18:16:01 +02:00
Nazım Can Altınova 3894ab42c2 Bug 1807011 - Do not call TimeStamp::Now for text markers when profiler is not running r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D166804
2023-01-18 10:56:18 +00:00
Eden Chuang 473cb0ffa2 Bug 1351231 - Integrate FetchChild into Fetch.cpp r=dom-worker-reviewers,jesup
Depends on D142437

Differential Revision: https://phabricator.services.mozilla.com/D142704
2023-01-18 00:50:20 +00:00
Marian-Vasile Laza 1037940f5b Backed out 5 changesets (bug 1351231) for causing multiple wpt failures. CLOSED TREE
Backed out changeset a41252141399 (bug 1351231)
Backed out changeset 6cbb442f4772 (bug 1351231)
Backed out changeset dbdca4661a35 (bug 1351231)
Backed out changeset ea27cd66fefd (bug 1351231)
Backed out changeset 8c21c9468949 (bug 1351231)
2023-01-17 19:53:09 +02:00
Julien Cristau ae9dd1db3c Backed out changeset a4d8b4c3d321 (bug 1804303) as it is no longer necessary. r=bhearsum DONTBUILD
We needed one nightly build that updates channel-prefs.js.  Now that
it's done, and a watershed is in place, we can restore mar file
generation to its normal logic.

Differential Revision: https://phabricator.services.mozilla.com/D167036
2023-01-17 15:40:12 +00:00
Eden Chuang 81c1e9c406 Bug 1351231 - Integrate FetchChild into Fetch.cpp r=dom-worker-reviewers,jesup
Depends on D142437

Differential Revision: https://phabricator.services.mozilla.com/D142704
2023-01-17 15:13:46 +00:00
Gabriele Svelto d16fa49000 Bug 1810138 - Properly redirect unzip's output to /dev/null when scraping macOS system symbols r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D166788
2023-01-17 08:53:34 +00:00
Nika Layzell 9d6bb19c23 Bug 1809753 - Part 4: Remove unnecessary GetMainThreadEventTarget, r=mccr8
This method always returned GetMainThreadSerialEventTarget(). This patch
switches all callers over to use that method instead.

We can't easily switch all calls to be calls to NS_GetMainThread(), as there is
no version of that method returning a bare nsIThread* instance.

I didn't introduce one, as we may want to add a lock around mMainThread in the
future, which would require removing nsThreadManager::GetMainThreadWeak. As
this method only returns nsISerialEventTarget, it method could remain
implemented, however, by returning a statically allocated fake event target
which forwards dispatches (and QIs to nsIThread) to the real main thread.

Differential Revision: https://phabricator.services.mozilla.com/D166608
2023-01-16 23:14:12 +00:00
Sandor Molnar 41b78439d0 Backed out 6 changesets (bug 1809752, bug 1809753) for causing perma failures in browser/components/firefoxview/tests/browser/browser_feature_callout_position.js
Backed out changeset ea05784d74c4 (bug 1809753)
Backed out changeset 7c9b20eebcc8 (bug 1809753)
Backed out changeset d0267ac2256d (bug 1809753)
Backed out changeset aa9f2971bd6f (bug 1809753)
Backed out changeset f0d9fcfaa6f8 (bug 1809752)
Backed out changeset 6d58c799cffe (bug 1809752)
2023-01-17 03:19:24 +02:00
Nika Layzell f7772bb6ae Bug 1809753 - Part 4: Remove unnecessary GetMainThreadEventTarget, r=mccr8
This method always returned GetMainThreadSerialEventTarget(). This patch
switches all callers over to use that method instead.

We can't easily switch all calls to be calls to NS_GetMainThread(), as there is
no version of that method returning a bare nsIThread* instance.

I didn't introduce one, as we may want to add a lock around mMainThread in the
future, which would require removing nsThreadManager::GetMainThreadWeak. As
this method only returns nsISerialEventTarget, it method could remain
implemented, however, by returning a statically allocated fake event target
which forwards dispatches (and QIs to nsIThread) to the real main thread.

Differential Revision: https://phabricator.services.mozilla.com/D166608
2023-01-16 23:14:12 +00:00
Mark Banner cb71370cbb Bug 1810567 - Enable ESLint rule no-shadow for .mjs files (but not .sys.mjs). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D166942
2023-01-16 23:04:21 +00:00
Mike Hommey 4e0c7ddead Bug 1810014 - Move macOS SDK toolchain task to linux workers. r=firefox-build-system-reviewers,andi
Differential Revision: https://phabricator.services.mozilla.com/D166724
2023-01-16 21:23:44 +00:00
Dave Townsend 1135edff9e Bug 1777973: Remove MOZ_NEW_XULSTORE implementation. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D166786
2023-01-16 19:21:23 +00:00
Mark Banner f35ab1379d Bug 1808173 - Convert SharedPromptUtils.jsm to an ES module and rename it PromptUtils.sys.mjs. r=Gijs,credential-management-reviewers,dimi
Using shared no longer makes sense, as the non-shared parts in Prompter have been renamed as 'Utils'.

Differential Revision: https://phabricator.services.mozilla.com/D165792
2023-01-16 13:32:19 +00:00
Andrew Creskey 902da73f87 Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning r=necko-reviewers,fluent-reviewers,flod,valentin,pbz
Similar to Bug 1596845 - Implement new error page for DNS errors when DoH is enabled - this changes about:neterror to show an error page specific to DNS failures that would have previously been resolved by fallback to native resolution.

With the preference, network.trr.display_fallback_warning set (defaults to off), DNS resolution will now fail when the user is in trr mode 2 (trr first) and either of these occur:
- the TRR cannot be confirmed
- the canary network heuristic is tripped

The new custom error page will be shown for failures resulting from these conditions.

This offers the user more information about the failure, and the option to bypass this warning going forward.

As with Bug 1596845, this is experimental and will be further improved over time.

To see the error page, the user must first set the network.trr.display_fallback_warning preference.
They must then encounter one of the conditions (unable to confirm TRR or tripping the canary heuristic).
Preventing TRR confirmation can be done by modifying their local hosts file to map their regional TRR domain's to an invalid address.

Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ

Depends on D165557

Differential Revision: https://phabricator.services.mozilla.com/D165558
2023-01-16 13:12:04 +00:00
Julien Cristau c8b15ed4a6 Bug 1804303 - force update to channel-prefs.js on mac. r=bhearsum DONTBUILD
The channel-prefs.js file is normally excluded from updates, both so QA
can edit it for testing, and to enable shipping release candidates to
the beta channel.  However, that means any change to the file contents
we ship risk invalidating the package's signature for users with
preexisting installs.  Such a change happened in bug 1576546, so we're
now forcing an update to the file on macOS to make sure users get the
current, correctly signed, contents.

Differential Revision: https://phabricator.services.mozilla.com/D166190
2023-01-16 09:39:56 +00:00
Mike Hommey 33b9794921 Bug 1810042 - Add gzip support to macpkg.unxar. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D166740
2023-01-13 21:10:16 +00:00
alwu 6a283b2eab Bug 1809983 - part2 : support mochitest-browser-media in the media-full preset. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D166728
2023-01-13 00:04:13 +00:00
alwu 0fd970dca3 Bug 1809983 - part1 : split media browser tests from mochitest-browser-chrome into mochitest-browser-media. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D166705
2023-01-13 00:04:13 +00:00