This reduces the archive size while keeping the compiler functional. This should not impact the quality of debug information of the compiled files
The size reduction is significant: from 236MB down to48MB.
Differential Revision: https://phabricator.services.mozilla.com/D167706
Mobile clients reject syncing when credit card record version is not 3, so this patch
reverts the credit card record version back to 3 (with `cc-type` field).
The auto-detect network type behavior implemented in bug 1667257 still applies.
The changes made in this commit are:
1. Save the cc-type to storage to comply with the expectation of mobile clients.
(This is the behavior for v3 credit record)
2. When a v4 record is found, rollback to v3 and make sure `_sync.changeCounter` is set
so we upload the downgraded record to the sync server
Differential Revision: https://phabricator.services.mozilla.com/D167814
A similar change have been applied in the C++ header files for the WebExtensions API WebIDL bindings that were already
part of the mozilla-central tree as part of Bug 1777574.
This patch is making sure that C++ header boilerplate file generated by the WebExtensions python script
GenerateWebIDLBindings.py that we will generate next for the other WebExtensions APIs not yet implemented
in mozilla-central will also use this new macro.
Differential Revision: https://phabricator.services.mozilla.com/D167593
A similar change have been applied to the webidl files related to WebExtensions APIs that were already defined
in mozilla-central as part of Bug 1659158.
This patch updates the python script to make sure that the new generate WebIDL files for the other WebExtensions
API that are not already in mozilla-central will use 'undefined' instead of 'void' as the return value type for
WebExtensions API methods that do not return any value.
Differential Revision: https://phabricator.services.mozilla.com/D167592
Let the caller addref it if needed.
I wrote this because I wanted to make some code dealing with it
thread-safe, but I ended up writing a less sketchy solution. However I
still think this is worth it.
It seems this only returns an already_AddRefed because before it used to
be an XPCOM-ish thing where the widget was returned as an out-param.
For now it doesn't change behavior but there are some callers that would
benefit from having less addref/release calls if they only need to read
simple stuff from the widget.
Differential Revision: https://phabricator.services.mozilla.com/D168141
Bug 1375505, which introduced GuardAndGetIterator, has two microbenchmarks in the comments, testing monomorphic and small-N polymorphic cases. Both of those are faster if we remove GuardAndGetIterator and just use ObjectToIterator: the polymorphic case goes from 190-220ms to 165-175ms, and the monomorphic case goes from 140-160ms to 125-135ms.
Disabling GuardAndGetIterator gives about a 1% improvement on Speedometer 2, largely on the back of a 2-3% improvement on React/React-Redux.
Differential Revision: https://phabricator.services.mozilla.com/D168025
After some discussion, we came to the conclusion that this code still needs to exist, but the comment is misleading. Hopefully this describes the justification better.
Depends on D168001
Differential Revision: https://phabricator.services.mozilla.com/D168002
Some widely-used icon fonts use ligature rules to replace icon names such as "volume_up"
or "down_arrow" with icon glyphs. If the site is designed to use such a font, but the user
disables document fonts and we use our default Latin font instead, the underlying text will
be rendered instead of the intended icon.
To enable such fonts to continue to work, we provide a list of known ligature-icon fonts
and allow them to be used even when the document-fonts setting is disabled.
Differential Revision: https://phabricator.services.mozilla.com/D167923
Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk.
Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.
Differential Revision: https://phabricator.services.mozilla.com/D167167
This patch attempts to address a high frequency of failing imgur raptor-browsertime tests on macos.
Additionally, the secondary url is replaced as it gives a 404
Differential Revision: https://phabricator.services.mozilla.com/D168106