Andreea Pavel
64289058b6
Backed out 5 changesets (bug 1690167) for failing xpcshell at bootstrapSvc.js on a CLOSED TREE
...
Backed out changeset d28c0f11743f (bug 1690167)
Backed out changeset 3b2bebed9128 (bug 1690167)
Backed out changeset 7e925e90a251 (bug 1690167)
Backed out changeset f85934a2b7ad (bug 1690167)
Backed out changeset 6d83474e81bb (bug 1690167)
2021-02-17 07:10:58 +02:00
Mike Hommey
7912f64d75
Bug 1690167 - Add support for the j length modifier in Printf.cpp. r=Gankra
...
Test cases from TestIntegerPrintfMacros will cover this in an upcoming commit.
Differential Revision: https://phabricator.services.mozilla.com/D105080
2021-02-16 21:20:04 +00:00
Mike Hommey
900d63959b
Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden
...
Which means they move from MFBT to mozglue.
Differential Revision: https://phabricator.services.mozilla.com/D103728
2021-02-16 21:20:03 +00:00
Mihai Alexandru Michis
9154148880
Backed out 4 changesets (bug 1690167) for causing cppunit failures in TestIntegerPrintfMacros.
...
CLOSED TREE
Backed out changeset 27dee66eba83 (bug 1690167)
Backed out changeset cfffb092a39f (bug 1690167)
Backed out changeset 87b2a2a66fd9 (bug 1690167)
Backed out changeset cac4879f50b4 (bug 1690167)
2021-02-13 00:07:00 +02:00
Mihai Alexandru Michis
02e7dbde25
Bug 1690167 - Fix windows bustages. a=bustage-fix
...
CLOSED TREE
2021-02-12 23:00:44 +02:00
Mike Hommey
6c2fd9938a
Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden
...
Which means they move from MFBT to mozglue.
Differential Revision: https://phabricator.services.mozilla.com/D103728
2021-02-12 20:21:49 +00:00
Gerald Squelart
3cfdbccd99
Bug 1691353 - Fixed non-MOZ_GECKO_PROFILER build around StackCaptureOptions - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D104500
2021-02-09 12:00:58 +00:00
Mike Hommey
34b72664d0
Bug 1598533 - Add support for %t modifier in PrintfTarget. r=nika,Gankra
...
Differential Revision: https://phabricator.services.mozilla.com/D103731
2021-02-02 20:16:55 +00:00
Mike Hommey
88b97ce29a
Bug 1686831 - Use double-conversion for mozilla::PrintfTarget::cvt_f. r=nika
...
This makes mozilla::PrintfTarget consistent across all locales (not
printing e.g. "," instead of "." for the decimal point in floats in some
locales)
This implementation passes all the glibc tests in stdio-common/tfformat.c
except two tests because of the difference in how values like e.g 0.25 are
rounded. Printf in glibc and on MacOS, as well as Rust std::fmt, round to
nearest, ties to even. Double-conversion, as well as printf on Windows
and conversion functions in ECMAScript round to nearest, ties away from
zero.
The standard for printf says rounding is implementation-defined so
either way is technically correct.
Differential Revision: https://phabricator.services.mozilla.com/D102699
2021-01-29 04:25:54 +00:00
Mike Hommey
2b96dd066d
Bug 1686831 - Allow double-conversion's ToFixed to handle ±DBL_MAX. r=nika
...
While at this point PrintfTarget doesn't use double-conversion, add a
test that it can (and thus will) handle the largest double output possible
with the default %f precision.
Differential Revision: https://phabricator.services.mozilla.com/D103431
2021-01-29 16:54:03 +00:00
Mike Hommey
38fa1ea7bd
Bug 1686831 - Add some more double formatting tests. r=nika
...
Patch sent upstream. https://sourceware.org/bugzilla/show_bug.cgi?id=27245
Differential Revision: https://phabricator.services.mozilla.com/D103135
2021-01-28 09:48:40 +00:00
Mike Hommey
63d408918e
Bug 1686831 - Hook glibc printf tests in TestPrintf.cpp. r=nika,mhoye
...
It is worth noting that some of these tests fail on Windows for rounding
difference reasons (see later commit from this bug for more details),
and on both Windows and mac for differences in formatting for INFINITY
and NAN. All the tests pass on Linux (since the underlying printf is
currently glibc's).
Differential Revision: https://phabricator.services.mozilla.com/D103133
2021-01-29 06:05:45 +00:00
Mike Hommey
8cbd8f2b09
Bug 1686831 - Print out the expected and actual results when failing in TestPrintf. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D103132
2021-01-29 06:03:27 +00:00
Mike Hommey
6779b992a5
Bug 1686831 - Import glibc printf test cases verbatim. r=mhoye
...
Differential Revision: https://phabricator.services.mozilla.com/D103131
2021-01-28 09:48:53 +00:00
Csoregi Natalia
8db3ebb5da
Backed out 9 changesets (bug 1686831) for sanitizer failures on nsTSubstring.cpp. CLOSED TREE
...
Backed out changeset 0e03d508c8d4 (bug 1686831)
Backed out changeset cf6dd6eab427 (bug 1686831)
Backed out changeset 308000f1e14b (bug 1686831)
Backed out changeset c4d470be0184 (bug 1686831)
Backed out changeset 9751918b1ccb (bug 1686831)
Backed out changeset dd9b7e71dcfb (bug 1686831)
Backed out changeset 486a184530a7 (bug 1686831)
Backed out changeset b64d3e89bf68 (bug 1686831)
Backed out changeset dcc6396e455a (bug 1686831)
2021-01-28 09:55:28 +02:00
Mike Hommey
210911c78c
Bug 1686831 - Use double-conversion for mozilla::PrintfTarget::cvt_f. r=nika
...
This makes mozilla::PrintfTarget consistent across all locales (not
printing e.g. "," instead of "." for the decimal point in floats in some
locales)
This implementation passes all the glibc tests in stdio-common/tfformat.c
except two tests because of the difference in how values like e.g 0.25 are
rounded. Printf in glibc and on MacOS, as well as Rust std::fmt, round to
nearest, ties to even. Double-conversion, as well as printf on Windows
and conversion functions in ECMAScript round to nearest, ties away from
zero.
The standard for printf says rounding is implementation-defined so
either way is technically correct.
Differential Revision: https://phabricator.services.mozilla.com/D102699
2021-01-28 04:56:57 +00:00
Mike Hommey
f6c043db8f
Bug 1686831 - Add some more double formatting tests. r=nika
...
Patch sent upstream. https://sourceware.org/bugzilla/show_bug.cgi?id=27245
Differential Revision: https://phabricator.services.mozilla.com/D103135
2021-01-27 22:53:21 +00:00
Mike Hommey
ba38386d81
Bug 1686831 - Hook glibc printf tests in TestPrintf.cpp. r=nika,mhoye
...
It is worth noting that some of these tests fail on Windows for rounding
difference reasons (see later commit from this bug for more details),
and on both Windows and mac for differences in formatting for INFINITY
and NAN. All the tests pass on Linux (since the underlying printf is
currently glibc's).
Differential Revision: https://phabricator.services.mozilla.com/D103133
2021-01-27 23:10:02 +00:00
Mike Hommey
ae6a8b5554
Bug 1686831 - Print out the expected and actual results when failing in TestPrintf. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D103132
2021-01-27 22:43:43 +00:00
Mike Hommey
7208a7a56d
Bug 1686831 - Import glibc printf test cases verbatim. r=mhoye
...
Differential Revision: https://phabricator.services.mozilla.com/D103131
2021-01-27 23:10:02 +00:00
Gerald Squelart
46d0db1b2c
Bug 1677130 - Allow out-of-order ReleaseChunk - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D100860
2021-01-12 23:30:27 +00:00
Gerald Squelart
4ad68eb4c1
Bug 1651863 - ProfileBufferChunkManager::ReleaseChunk (no 's' anymore) only accepts zero or one chunk - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D100859
2021-01-08 12:11:18 +00:00
Masatoshi Kimura
e70bf4efaa
Bug 1684110 - Stop using some 'A'-functions in TestDllInterceptor. r=tkikuchi
...
Differential Revision: https://phabricator.services.mozilla.com/D100419
2020-12-27 08:40:36 +00:00
Gerald Squelart
2c7a8524ac
Bug 1678651 - ProfilerChunkedBuffer: Always mark current chunk full when entry doesn't fit - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D99980
2020-12-22 10:50:16 +00:00
Gerald Squelart
72310c2c2a
Bug 1678651 - Better ProfileChunkedBuffer::Clear(), recycles released chunks - r=canaltinova
...
Instead of discarding released chunks, we keep them as "next" chunks, and we make sure there's a valid "current" chunk when possible.
Recycling released chunks means that when using the `ProfileBufferChunkManagerSingle`, the one chunk, in whichever state it may be, will be kept alive and reused.
Differential Revision: https://phabricator.services.mozilla.com/D99979
2020-12-22 10:49:53 +00:00
Gerald Squelart
a611efcb7f
Bug 1678651 - ProfileChunkedBuffer now keeps track of failed puts - r=canaltinova
...
When a "Put" operation fails (most probably because no chunk was available to store the data), we remember the number of bytes that couldn't be stored.
This can be useful to give an indication of how much more memory would have been needed for successful puts.
Differential Revision: https://phabricator.services.mozilla.com/D99977
2020-12-22 10:49:12 +00:00
Gerald Squelart
058a0fdb7e
Bug 1678651 - Rewrote TestChunkedBufferSingle() to better test buffer-filling scenarios - r=canaltinova
...
This bug has revealed some issues when the single chunk gets filled, and there are different paths depending on whether the chunk is filled right to the end, or past it.
Later patches will fix these issues and update these tests accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D99976
2020-12-22 10:48:49 +00:00
Gerald Squelart
f11383c57a
Bug 1678651 - Added ProfileChunkedBuffer state tests - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D99975
2020-12-22 10:48:26 +00:00
Gerald Squelart
2893c11987
Bug 1676079 - For consistency and clarity, add Marker suffix to all marker types - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D98123
2020-11-30 22:52:44 +00:00
Gerald Squelart
b9191bb2ce
Bug 1646613 - Rename profiler overhead variables to include their true unit - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D97993
2020-11-30 10:44:13 +00:00
Gerald Squelart
8ed348d0c7
Bug 1675409 - Migrated UserTimingMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96051
2020-11-18 21:53:09 +00:00
Gerald Squelart
72195228c9
Bug 1675409 - Fix ProfilerString16View::WrapNullTerminatedString and Span converter - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96047
2020-11-18 21:51:06 +00:00
Gerald Squelart
c3d6e979a5
Bug 1675409 - Migrated MediaSampleMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96043
2020-11-18 21:49:52 +00:00
Gerald Squelart
4d9cfb4113
Bug 1675409 - Migrated LogMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96039
2020-11-18 21:47:24 +00:00
Gerald Squelart
46fed8e10f
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-18 21:46:56 +00:00
Gerald Squelart
237baa429c
Bug 1675409 - Migrated HangMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96036
2020-11-18 21:45:54 +00:00
Razvan Maries
b7eeb731df
Backed out 23 changesets (bug 1675409) for build bustages on Preferences.cpp. CLOSED TREE
...
Backed out changeset c1a131a55767 (bug 1675409)
Backed out changeset 47d210802a5d (bug 1675409)
Backed out changeset e8ebb1c58d30 (bug 1675409)
Backed out changeset 69a1e9aeff2a (bug 1675409)
Backed out changeset 68f330b387a8 (bug 1675409)
Backed out changeset e4750d9ef5a1 (bug 1675409)
Backed out changeset bb6bb71e5ab3 (bug 1675409)
Backed out changeset 988d7f4716df (bug 1675409)
Backed out changeset ca41382e891c (bug 1675409)
Backed out changeset 90f3fbbbbeda (bug 1675409)
Backed out changeset 9b109d61a6f6 (bug 1675409)
Backed out changeset 3dd66abfdaa2 (bug 1675409)
Backed out changeset 44181df5f0db (bug 1675409)
Backed out changeset bb2603d947fc (bug 1675409)
Backed out changeset 97055cf20a56 (bug 1675409)
Backed out changeset f88fcf09de0d (bug 1675409)
Backed out changeset 7963e1c49786 (bug 1675409)
Backed out changeset 4c379c1061c3 (bug 1675409)
Backed out changeset b8be8ae7da63 (bug 1675409)
Backed out changeset 0b90aa89421e (bug 1675409)
Backed out changeset c10fb46467c9 (bug 1675409)
Backed out changeset 894ac233b290 (bug 1675409)
Backed out changeset 075d1d8e34c2 (bug 1675409)
2020-11-18 20:06:28 +02:00
Gerald Squelart
2ab89b23a6
Bug 1675409 - Migrated UserTimingMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96051
2020-11-17 22:22:34 +00:00
Gerald Squelart
3db19002bf
Bug 1675409 - Fix ProfilerString16View::WrapNullTerminatedString and Span converter - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96047
2020-11-17 22:20:24 +00:00
Gerald Squelart
6462c5154d
Bug 1675409 - Migrated MediaSampleMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96043
2020-11-17 22:19:06 +00:00
Gerald Squelart
c76eb1b69b
Bug 1675409 - Migrated LogMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96039
2020-11-17 22:16:49 +00:00
Gerald Squelart
067cad5579
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-17 22:16:16 +00:00
Gerald Squelart
986eaf5787
Bug 1675409 - Migrated HangMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96036
2020-11-17 22:15:10 +00:00
Mihai Alexandru Michis
c0d25b01b2
Backed out 24 changesets (bug 1666566, bug 1675409) for causing hazard failures in profiler/core/platform.cpp
...
CLOSED TREE
Backed out changeset 4d8af8533fd4 (bug 1666566)
Backed out changeset f031a3a8a20f (bug 1675409)
Backed out changeset 2b7e1a031921 (bug 1675409)
Backed out changeset bda5a24b2d0a (bug 1675409)
Backed out changeset 4282e2284314 (bug 1675409)
Backed out changeset 0637f1b26e9f (bug 1675409)
Backed out changeset 67ae04c8f607 (bug 1675409)
Backed out changeset 6c7b3f3618ef (bug 1675409)
Backed out changeset 2f325c22d169 (bug 1675409)
Backed out changeset 1e48ff70ad8f (bug 1675409)
Backed out changeset 1dfc32d6871d (bug 1675409)
Backed out changeset 4f1f218a777b (bug 1675409)
Backed out changeset e6ac8722b38e (bug 1675409)
Backed out changeset cf132e15fb57 (bug 1675409)
Backed out changeset a126e6b00ba9 (bug 1675409)
Backed out changeset fbc7fbb04f33 (bug 1675409)
Backed out changeset 554c69681474 (bug 1675409)
Backed out changeset 44d0521c701f (bug 1675409)
Backed out changeset 04653dfe4720 (bug 1675409)
Backed out changeset 41ca2c043a00 (bug 1675409)
Backed out changeset 264ae4c805d4 (bug 1675409)
Backed out changeset 5f3bbdac0d52 (bug 1675409)
Backed out changeset 11311c11a6e8 (bug 1675409)
Backed out changeset 0355fbc44baf (bug 1675409)
2020-11-17 19:31:28 +02:00
Gerald Squelart
c152b9befc
Bug 1675409 - Migrated UserTimingMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96051
2020-11-17 11:37:08 +00:00
Gerald Squelart
06ed2337ba
Bug 1675409 - Fix ProfilerString16View::WrapNullTerminatedString and Span converter - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96047
2020-11-17 12:05:53 +00:00
Gerald Squelart
4075cd5ed6
Bug 1675409 - Migrated MediaSampleMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96043
2020-11-17 11:33:48 +00:00
Gerald Squelart
374448fe41
Bug 1675409 - Migrated LogMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96039
2020-11-17 11:31:37 +00:00
Gerald Squelart
ee94544ace
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-17 11:31:04 +00:00
Gerald Squelart
4a50146cab
Bug 1675409 - Migrated HangMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96036
2020-11-17 11:30:03 +00:00