fcaf70841e
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
2390d257e6
Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE
2022-03-16 18:32:51 +02:00
4b033a5256
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
927ad62c6a
Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE
2022-03-16 14:38:14 +02:00
7d4b5fae04
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
6ef1621b21
Bug 1747439: netwerk/cache2 cleanup r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D135167
2022-01-12 20:38:37 +00:00
205e4f70a7
Backed out changeset 7c1a1109d729 (bug 1747439) for causing build bustages on CacheEntry.cpp. CLOSED TREE
2022-01-12 16:52:24 +02:00
4037dc1397
Bug 1747439: netwerk/cache2 cleanup r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D135167
2022-01-12 13:54:01 +00:00
0cbc1f290d
Bug 1312057 - Fix prefetch telmetry r=mayhemer,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D11518
2021-10-12 15:41:15 +00:00
d99d6259ee
Bug 1732095 - Clean up CacheStorageService r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D126357
2021-09-23 09:14:19 +00:00
e209403593
Bug 1729717 - Remove unused CleanupCacheDirectories r=necko-reviewers,dragana
...
This was used previously when switching between cache backend versions.
Differential Revision: https://phabricator.services.mozilla.com/D124922
2021-09-13 12:07:37 +00:00
2ecacd2e2d
Backed out 2 changesets (bug 1729717) for causing assertion failures on CacheObserver.cpp. CLOSED TREE
...
Backed out changeset 7123efe825f0 (bug 1729717)
Backed out changeset 92e06bd625c9 (bug 1729717)
2021-09-13 12:40:11 +03:00
fc6cd46e34
Bug 1729717 - Remove unused CleanupCacheDirectories r=necko-reviewers,dragana
...
This was used previously when switching between cache backend versions.
Differential Revision: https://phabricator.services.mozilla.com/D124922
2021-09-13 09:12:34 +00:00
35bfc0713b
Bug 1708673 - Do not recreate CacheEntry when OPEN_READONLY flag is passed r=necko-reviewers,dragana
...
This bug is caused by two cache visitors working in parallel:
Visitor1: calls asyncDoomURI
Visitor2: calls asyncOpenURI
This causes CacheStorageService::AddStorageEntry to create a new entry and add
it to the hashtable:
https://searchfox.org/mozilla-central/rev/308ea44d0d60b391b031ccee695920bd543f7d2f/netwerk/cache2/CacheStorageService.cpp#1566,1574,1576
Visitor3: will then go through the hashtable and see the newly added entry.
Differential Revision: https://phabricator.services.mozilla.com/D118344
2021-06-22 08:23:36 +00:00
1a1f42da37
Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
...
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.
Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.
The member variables that are still initialized in the contructor definition
are:
- bitfields (not all currently supported compilers allow default-member-init
- variables that are initialized via a parameter
- variables that use code not visible in the header file
There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now
Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.
Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-11 07:10:41 +00:00
938a6943c6
Backed out changeset 6e00f8bd2acc (bug 1714307) for causing hazard bustage. CLOSED TREE
2021-06-09 21:50:03 +03:00
d1513f313e
Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
...
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.
Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.
The member variables that are still initialized in the contructor definition
are:
- bitfields (not all currently supported compilers allow default-member-init
- variables that are initialized via a parameter
- variables that use code not visible in the header file
There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now
Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.
Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-09 10:20:04 +00:00
d595491cc7
Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 12:35:16 +00:00
692bda1ca1
Backed out changeset c4b44c4ef15b (bug 1714307) for causing build bustages on nsHTTPCompressConv.h. CLOSED TREE
2021-06-04 13:53:37 +03:00
98146ae90b
Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 10:00:55 +00:00
ad01a10a3b
Bug 1634281 - Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
...
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.
Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
316b5113e0
Bug 1633239 - make the bitfields on CacheStorageService atomic. r=valentin,necko-reviewers
...
this is only a hypothetical fix to the underlying issue since we don't have a clean trace.
Differential Revision: https://phabricator.services.mozilla.com/D103057
2021-01-28 11:05:02 +00:00
0aefd3e956
Bug 1487101 - Do not interrupt purging of HTTP cache entries from memory by frecency until the pool containts at most 2000 entries, r=michal,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D80180
2020-06-19 05:43:42 +00:00
9fdf075d81
Bug 1624515 - Fix data race on CacheStorageService::mShutdown r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D71768
2020-04-21 20:33:37 +00:00
5cd74804aa
Bug 1614637 - ThreadSanitizer: data race [@ assign_assuming_AddRef] vs. [@ operator bool] in CacheStorageService r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D62550
--HG--
extra : moz-landing-system : lando
2020-02-17 18:44:21 +00:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
28962b5168
Bug 1468501 - Implement a way to delete network cache by nsIPrincipal, r=mayhemer, r=michal
2018-07-20 13:57:18 +02:00
3f2298c2f6
Bug 1457411 - Update netwerk module to make use of newer methods introduced with c++11 and c++14. r=valentin
...
MozReview-Commit-ID: 666LNaHyiuQ
--HG--
extra : rebase_source : f3a24e0342d8dcdf9020dd473bc6b1045cbc533b
2018-04-30 19:46:04 +03:00
8030ac3f2d
Bug 1382688 - Do not allow to enable old disk cache backend, r=honzab
2017-08-24 10:25:38 +02:00
95b18d794e
Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm
...
--HG--
extra : rebase_source : 84de1abfcc30a6964144c2e6718a508c71027b65
2017-07-27 02:18:20 +08:00
f115503a0b
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
f1364a75ea
Bug 1374580 (part 3) - Remove ns{,C}Substring typedefs. r=froydnj.
...
All the instances are converted as follows.
- nsSubstring --> nsAString
- nsCSubstring --> nsACString
--HG--
extra : rebase_source : cfd2238c52e3cb4d13e3bd5ddb80ba6584ab6d91
2017-06-20 19:19:52 +10:00
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
6b3e84ed5f
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
4592152411
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
d1637b9c5a
Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
...
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
7cb6a23814
Bug 1365101 - Convert NS_GetCurrentThread uses in netwerk/ (r=meyhemer)
...
MozReview-Commit-ID: IHBt6XAG8em
2017-06-12 20:21:43 -07:00
223b5464d4
Bug 1325341 - Query the cache index to get if the entry has alt data and its fileSize r=michal
...
MozReview-Commit-ID: 6wqsexqJq3u
2017-04-10 14:22:23 +03:00
f747db3bbd
Bug 1312954 - Part 1: Add the nsILoadContextInfo as one additional argument of nsILoadContextInfo.onCacheEntryInfo() and CacheStorageService::EntryInfoCallback.OnEntryInfo(). r=mayhemer
2017-02-02 22:14:00 -05:00
3c75088cde
Bug 1313095 - Add telemetry to measure if cache loads are faster than network loads r=michal
...
MozReview-Commit-ID: C6kMSPw8gxv
* * *
[mq]: bug1313095-telemetry-reval.patch
MozReview-Commit-ID: 8jwMgq0cx3Z
2016-11-10 16:14:34 +01:00
d9981dcb53
Bug 1271019 - Don't call on nsIURI on non-main threads from HTTP cache back end. r=michal
2016-05-12 06:38:00 -04:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
68a7636bf1
Bug 1050613 - Make sure force-valid for HTTP cache entries is removed when entries are removed, r=michal
2016-02-19 11:56:00 +01:00
581cd94d0a
Bug 1248003 - Purge from HTTP cache memory pool only in reasonable intervals, r=michal
2016-02-15 11:45:00 +01:00
686438c658
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
2016-02-10 08:23:00 +01:00
5b358688b7
Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures
...
--HG--
extra : rebase_source : fb6fd434c8e3f4b5fa53ea645a54c07cab207894
2016-02-08 11:17:38 +01:00
69cf7e035f
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
...
--HG--
extra : rebase_source : 3c6bba6613a14e48239d302bdd0f7fe2e322265d
2016-02-07 10:56:00 +01:00
a170797259
Bug 1220272 - Fix signalling in HTTP cache test code suspender. r=michal
2016-01-14 11:24:00 +01:00
7ed406b2be
Bug 1238290 - fix bad necko deps on unified_sources r=valentin.gosu
...
---
netwerk/base/ARefBase.h | 2 ++
netwerk/base/CaptivePortalService.cpp | 1 +
netwerk/base/CaptivePortalService.h | 1 +
netwerk/base/EventTokenBucket.cpp | 4 +++-
netwerk/base/LoadContextInfo.cpp | 3 +++
netwerk/base/LoadInfo.cpp | 3 +++
netwerk/base/MemoryDownloader.cpp | 1 +
netwerk/base/Predictor.cpp | 1 +
netwerk/base/RedirectChannelRegistrar.h | 1 +
netwerk/base/nsBaseChannel.cpp | 1 +
netwerk/base/nsChannelClassifier.cpp | 1 +
netwerk/base/nsDirectoryIndexStream.cpp | 3 ++-
netwerk/base/nsDownloader.cpp | 1 +
netwerk/base/nsIOService.cpp | 1 +
netwerk/base/nsIncrementalDownload.cpp | 3 +++
netwerk/base/nsNetUtil.cpp | 4 ++++
netwerk/base/nsNetUtil.h | 1 +
netwerk/base/nsProtocolProxyService.cpp | 1 +
netwerk/base/nsSecCheckWrapChannel.cpp | 2 ++
netwerk/base/nsUDPSocket.cpp | 4 +++-
netwerk/cache/nsDiskCacheBinding.cpp | 2 +-
netwerk/cache/nsDiskCacheDeviceSQL.cpp | 2 ++
netwerk/cache/nsMemoryCacheDevice.cpp | 2 +-
netwerk/cache2/CacheFileUtils.cpp | 2 ++
netwerk/cache2/CacheStorageService.h | 1 +
netwerk/ipc/NeckoParent.cpp | 1 +
netwerk/ipc/RemoteOpenFileChild.cpp | 1 +
netwerk/protocol/about/nsAboutBloat.cpp | 1 +
netwerk/protocol/about/nsAboutCacheEntry.cpp | 1 +
netwerk/protocol/about/nsAboutProtocolHandler.cpp | 1 +
netwerk/protocol/data/DataChannelParent.cpp | 1 +
netwerk/protocol/file/nsFileProtocolHandler.cpp | 1 +
netwerk/protocol/ftp/FTPChannelParent.cpp | 2 ++
netwerk/protocol/ftp/FTPChannelParent.h | 1 +
netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 1 +
netwerk/protocol/ftp/nsFtpProtocolHandler.h | 1 +
netwerk/protocol/http/Http2Compression.cpp | 1 +
netwerk/protocol/http/Http2Session.cpp | 1 +
netwerk/protocol/http/Http2Stream.h | 2 ++
netwerk/protocol/http/HttpBaseChannel.cpp | 4 ++++
netwerk/protocol/http/HttpBaseChannel.h | 1 +
netwerk/protocol/http/HttpChannelChild.cpp | 25 ++--------------------
netwerk/protocol/http/HttpChannelChild.h | 24 +++++++++++++++++++++
netwerk/protocol/http/HttpChannelParent.cpp | 1 +
netwerk/protocol/http/HttpChannelParent.h | 1 +
.../protocol/http/HttpChannelParentListener.cpp | 1 +
netwerk/protocol/http/HttpChannelParentListener.h | 1 +
netwerk/protocol/http/InterceptedChannel.cpp | 1 +
netwerk/protocol/http/NullHttpChannel.cpp | 1 +
netwerk/protocol/http/NullHttpTransaction.cpp | 1 +
netwerk/protocol/http/PackagedAppService.cpp | 14 ++++++++++--
netwerk/protocol/http/PackagedAppService.h | 4 +++-
netwerk/protocol/http/PackagedAppVerifier.cpp | 1 +
netwerk/protocol/http/nsCORSListenerProxy.cpp | 2 +-
netwerk/protocol/http/nsHttpBasicAuth.cpp | 1 +
netwerk/protocol/http/nsHttpChannel.cpp | 2 ++
netwerk/protocol/http/nsHttpChunkedDecoder.cpp | 1 +
netwerk/protocol/http/nsHttpConnectionInfo.cpp | 2 ++
netwerk/protocol/http/nsHttpConnectionMgr.cpp | 1 +
netwerk/protocol/http/nsHttpDigestAuth.cpp | 1 +
netwerk/protocol/viewsource/nsViewSourceHandler.h | 4 ++++
.../protocol/websocket/BaseWebSocketChannel.cpp | 1 +
.../websocket/WebSocketEventListenerParent.cpp | 1 +
.../protocol/websocket/WebSocketEventService.cpp | 3 +++
netwerk/protocol/websocket/WebSocketFrame.cpp | 2 ++
netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 1 +
.../protocol/wyciwyg/nsWyciwygProtocolHandler.cpp | 1 +
netwerk/streamconv/converters/mozTXTToHTMLConv.cpp | 1 +
.../streamconv/converters/nsFTPDirListingConv.cpp | 1 +
.../streamconv/converters/nsHTTPCompressConv.cpp | 2 ++
netwerk/streamconv/converters/nsHTTPCompressConv.h | 1 +
netwerk/streamconv/converters/nsIndexedToHTML.cpp | 1 +
netwerk/streamconv/converters/nsMultiMixedConv.cpp | 2 ++
netwerk/streamconv/converters/nsTXTToHTMLConv.cpp | 2 ++
netwerk/streamconv/converters/nsUnknownDecoder.cpp | 2 ++
75 files changed, 147 insertions(+), 32 deletions(-)
2016-01-08 20:20:50 -05:00
Randell Jesup
Noemi Erli
Butkovits Atila
Marian-Vasile Laza
Valentin Gosu
Csoregi Natalia
Simon Giesecke
Alexis Beingessner
Honza Bambas
Michal Novotny
Sylvestre Ledru
Andrea Marchesini
Andi-Bogdan Postelnicu
Bevis Tseng
Bill McCloskey
Nicholas Nethercote
Carsten "Tomcat" Book
Tim Huang
Kyle Huey
Aidin Gharibnavaz
Patrick McManus