This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This is _mostly_ boring, standard stuff. The most notable part is the refactor of the test transforms to process `variant` as early as possible. This is needed to key `suite` by variant (and is likely going to be helpful in other places as well, eg: we can now key all `mozharness` keys on variant). See the previous patch for why we need a separate xpcshell suite for this.
I don't know if I'm adding the runtime manifest correctly, or how those times are supposed to be generated/updated (the commit log seems to suggest that it's broken right now?) - let me know if I should do something differently here.
Note: I'm still working through a few more tests that need to be disabled, so this isn't ready to be landed yet, but I don't anticipate any changes to this patch.
Differential Revision: https://phabricator.services.mozilla.com/D164230
This commit moves crash tests from dom/mathml and layout/mathml into
testing/web-platform/tests/mathml/crashtests/mozilla, trying to do only
minimal changes (i.e. use 'test-wait' instead of 'reftest-wait' and
fix whitespace errors). lint errors are ignored for usage of
setTimeout as well as the invalid XML file testing bug 289180.
Regarding 400157.xhtml, it uses special powers to trigger a
zoom changes. It could probably be tweaked to convert to a mochitest or
rely on a different dynamic change. However, this was testing a crash for
the `<mfenced>` element in nsMathMLmfencedFrame whose code has been
completely removed, so it's now hard to reproduce the original crash.
Also that makes the test no longer very useful, so we just remove it.
Differential Revision: https://phabricator.services.mozilla.com/D159491
This commit moves crash tests from dom/mathml and layout/mathml into
testing/web-platform/tests/mathml/crashtests/mozilla, trying to do only
minimal changes (i.e. use 'test-wait' instead of 'reftest-wait').
The exception is 400157.xhtml which uses special powers to trigger a
zoom changes. It could probably be tweaked to convert to a mochitest or
rely on a different dynamic change. However, this was testing a crash for
the `<mfenced>` element in nsMathMLmfencedFrame whose code has been
completely removed, so it's now hard to reproduce the original crash.
Also that makes the test no longer very useful, so we just remove it.
Differential Revision: https://phabricator.services.mozilla.com/D159491
Update runtimes data manually for new antitracking manifest. This data is normally
updated by the writeruntimes script, but currently that is not working (it relies
on ActiveData). I manually updated with approximate durations.
Without an update to the runtime data, task scheduling is not aware that the new
manifest is long-running, and schedules it alongside many other manifests, which
continues to produce unbalanced test chunk run times; with the update, chunks are
much more balanced.
Differential Revision: https://phabricator.services.mozilla.com/D116639
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Changes:
- `web-platform-tests-wdspec` and `web-platform-tests-crashtests` are newly added to the file.
- `web-platform-tests` groupings are changed.
Differential Revision: https://phabricator.services.mozilla.com/D80921
Changes:
Update `writeruntimes` script so that each suite is in its own nested dictionary and add the ability to query `web-platform-tests-reftest`.
Differential Revision: https://phabricator.services.mozilla.com/D75229
CLOSED TREE
Backed out changeset 93efb53380c2 (bug 1637463)
Backed out changeset 5c8ccda5f1b1 (bug 1637463)
Backed out changeset a5fc1b604238 (bug 1637463)
Changes:
Update `writeruntimes` script so that each suite is in its own nested dictionary and add the ability to query `web-platform-tests-reftest`.
Differential Revision: https://phabricator.services.mozilla.com/D75229
Changes:
After some iterations, it turns out that normalization of the test paths returned by web-platform-tests is unnecessary for the time being.
- removed normalization of the test paths from `writeruntimes`.
- updated manifest-runtime JSON files for all three platforms.
Differential Revision: https://phabricator.services.mozilla.com/D74264
Julian Descottes
Noemi Erli
Barret Rennie
Sandor Molnar
Mark Banner
Norisz Fay
alwu
Ben Hearsum
Marco Castelluccio
Frederic Wang
Cristian Tuns
Nicolas Chevobbe
Punam Dahiya
Joel Maher
Neil Deakin
Geoff Brown
Valentin Gosu
Ted Campbell
Ricky Stewart
Bogdan Tara
Dorel Luca
Michael Froman
Razvan Maries
Robert Helmer
Narcis Beleuzu
Edwin Takahashi
Andrew Halberstadt
Nils Ohlmeier [:drno]
Mihai Alexandru Michis