Граф коммитов

2483 Коммитов

Автор SHA1 Сообщение Дата
Markus Stange db52198a46 Bug 1542454 - Remove unused function COLOR8TOCOLOR16. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D26400

--HG--
extra : moz-landing-system : lando
2019-04-29 17:02:16 +00:00
Masayuki Nakano 6c0c323d6f Bug 1546839 - part 1: Change `enum Command` to `enum class Command` and drop "Command" prefix from each item r=smaug
If I remember correctly, `enum class` was not allowed when I added
`enum Command`.  Now, we can make it `enum class` for better type check at
compile time.

Differential Revision: https://phabricator.services.mozilla.com/D29169

--HG--
extra : moz-landing-system : lando
2019-04-30 04:23:24 +00:00
Markus Stange 4c44b62eee Bug 1533562 - Do not move the TitlebarGradientView from a ToolbarWindow into a BorderlessWindow when hiding the window chrome. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D25516

--HG--
extra : moz-landing-system : lando
2019-04-29 17:00:31 +00:00
Markus Stange b396860365 Bug 1533562 - Implement titlebar gradient drawing with a new TitlebarGradientView. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D22646

--HG--
extra : moz-landing-system : lando
2019-04-29 17:00:13 +00:00
Markus Stange 7cb6bd28ef Bug 1533562 - Always make the content view of ToolbarWindows cover the entire window. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D22645

--HG--
extra : moz-landing-system : lando
2019-04-29 16:59:55 +00:00
Markus Stange 9b5e2958c5 Bug 1533562 - Remove override of -[NSThemeFrame _unifiedToolbarFrame]. r=spohl
This override has no effect in CoreAnimation-backed windows. The upcoming
patches will implement an alternative approach.

Differential Revision: https://phabricator.services.mozilla.com/D22644

--HG--
extra : moz-landing-system : lando
2019-04-29 16:59:42 +00:00
Markus Stange bf8b839110 Bug 1533562 - Remove code that deals with non-rounded bottom corners on regular windows. r=spohl
Rounded bottom corners have been the default since 10.7.
We still have square corners on windows without titlebars, such as the address
bar autocomplete dropdown, or the reftest window.

Differential Revision: https://phabricator.services.mozilla.com/D22643

--HG--
extra : moz-landing-system : lando
2019-04-29 16:59:25 +00:00
Markus Stange 890482c332 Bug 1533562 - Remove synchronous repaint capability of setTitlebarNeedsDisplayInRect:sync: and also remove the rect parameter because we always pass the same value to it. r=spohl
The synchronous paint was only needed a long time ago when we were calling this
method during drawRect. We're not doing that any more, we usually call it from
viewWillDraw now. But even at the time, forcing a synchronous paint *within*
a paint was extremely sketchy, so best just to remove the code.

Differential Revision: https://phabricator.services.mozilla.com/D22642

--HG--
extra : moz-landing-system : lando
2019-04-29 16:59:10 +00:00
Noemi Erli 449299cc22 Backed out 6 changesets (bug 1533562) for breaking reftests and failures in letter-spacing-005.xht
Backed out changeset 1976a614f8ce (bug 1533562)
Backed out changeset 02adcc70efbe (bug 1533562)
Backed out changeset 00ffda400dc5 (bug 1533562)
Backed out changeset 710d3c0129de (bug 1533562)
Backed out changeset 64720021f45c (bug 1533562)
Backed out changeset 68559438c818 (bug 1533562)
2019-04-26 22:26:17 +03:00
Markus Stange 3da5cd3df2 Bug 1533562 - Do not move the TitlebarGradientView from a ToolbarWindow into a BorderlessWindow when hiding the window chrome. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D25516

--HG--
extra : moz-landing-system : lando
2019-04-26 17:27:09 +00:00
Markus Stange 99b8e92ccc Bug 1533562 - Implement titlebar gradient drawing with a new TitlebarGradientView. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D22646

--HG--
extra : moz-landing-system : lando
2019-04-26 17:26:57 +00:00
Markus Stange 1079ac444c Bug 1533562 - Always make the content view of ToolbarWindows cover the entire window. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D22645

--HG--
extra : moz-landing-system : lando
2019-04-26 17:26:39 +00:00
Markus Stange 58796cf49b Bug 1533562 - Remove override of -[NSThemeFrame _unifiedToolbarFrame]. r=spohl
This override has no effect in CoreAnimation-backed windows. The upcoming
patches will implement an alternative approach.

Differential Revision: https://phabricator.services.mozilla.com/D22644

--HG--
extra : moz-landing-system : lando
2019-04-26 17:26:31 +00:00
Markus Stange 467f5af7ba Bug 1533562 - Remove code that deals with non-rounded bottom corners on regular windows. r=spohl
Rounded bottom corners have been the default since 10.7.

Differential Revision: https://phabricator.services.mozilla.com/D22643

--HG--
extra : moz-landing-system : lando
2019-04-26 17:26:14 +00:00
Markus Stange c0aa023eb0 Bug 1533562 - Remove synchronous repaint capability of setTitlebarNeedsDisplayInRect:sync: and also remove the rect parameter because we always pass the same value to it. r=spohl
The synchronous paint was only needed a long time ago when we were calling this
method during drawRect. We're not doing that any more, we usually call it from
viewWillDraw now. But even at the time, forcing a synchronous paint *within*
a paint was extremely sketchy, so best just to remove the code.

Differential Revision: https://phabricator.services.mozilla.com/D22642

--HG--
extra : moz-landing-system : lando
2019-04-26 17:25:59 +00:00
Gurzau Raul f05aef3e04 Backed out 9 changesets (bug 1542454, bug 1533562) for failing at /browser/browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js on a CLOSED TREE.
Backed out changeset 88756a309968 (bug 1542454)
Backed out changeset 37bd2819d3a7 (bug 1542454)
Backed out changeset 19f0462bb47a (bug 1542454)
Backed out changeset b4440b1833ec (bug 1533562)
Backed out changeset 8970cdb3c04a (bug 1533562)
Backed out changeset 498cd34eea78 (bug 1533562)
Backed out changeset 3a3b4d52e10a (bug 1533562)
Backed out changeset 5fae2f233aa0 (bug 1533562)
Backed out changeset e3fc54ebcd15 (bug 1533562)
2019-04-23 01:09:12 +03:00
Jeff Gilbert 544759b391 Bug 1545892 - Reduce includes in gfx2DGlue.h, nsLayoutUtils.h, nsPresContext.h. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D28266

--HG--
extra : moz-landing-system : lando
2019-04-22 19:58:52 +00:00
Markus Stange 77ddedaacb Bug 1542454 - Factor out some code. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D26402

--HG--
extra : moz-landing-system : lando
2019-04-22 19:41:58 +00:00
Markus Stange d0ba1d9725 Bug 1542454 - Remove support for drawing the window resizer. r=spohl
The last version of macOS that put resizers in window corners was 10.6.

Differential Revision: https://phabricator.services.mozilla.com/D26401

--HG--
extra : moz-landing-system : lando
2019-04-22 19:41:41 +00:00
Markus Stange 0f29789b59 Bug 1542454 - Remove unused function COLOR8TOCOLOR16. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D26400

--HG--
extra : moz-landing-system : lando
2019-04-22 19:41:21 +00:00
Markus Stange de6910917a Bug 1533562 - Do not move the TitlebarGradientView from a ToolbarWindow into a BorderlessWindow when hiding the window chrome. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D25516

--HG--
extra : moz-landing-system : lando
2019-04-22 19:27:09 +00:00
Markus Stange 537ff00f68 Bug 1533562 - Implement titlebar gradient drawing with a new TitlebarGradientView. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D22646

--HG--
extra : moz-landing-system : lando
2019-04-22 19:26:56 +00:00
Markus Stange 8f1414b86c Bug 1533562 - Always make the content view of ToolbarWindows cover the entire window. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D22645

--HG--
extra : moz-landing-system : lando
2019-04-22 19:26:38 +00:00
Markus Stange 92aa2412e5 Bug 1533562 - Remove override of -[NSThemeFrame _unifiedToolbarFrame]. r=spohl
This override has no effect in CoreAnimation-backed windows. The upcoming
patches will implement an alternative approach.

Differential Revision: https://phabricator.services.mozilla.com/D22644

--HG--
extra : moz-landing-system : lando
2019-04-22 19:26:29 +00:00
Markus Stange 61e81ce45e Bug 1533562 - Remove code that deals with non-rounded bottom corners on regular windows. r=spohl
Rounded bottom corners have been the default since 10.7.

Differential Revision: https://phabricator.services.mozilla.com/D22643

--HG--
extra : moz-landing-system : lando
2019-04-22 19:26:15 +00:00
Markus Stange 7540dfbeba Bug 1533562 - Remove synchronous repaint capability of setTitlebarNeedsDisplayInRect:sync: and also remove the rect parameter because we always pass the same value to it. r=spohl
The synchronous paint was only needed a long time ago when we were calling this
method during drawRect. We're not doing that any more, we usually call it from
viewWillDraw now. But even at the time, forcing a synchronous paint *within*
a paint was extremely sketchy, so best just to remove the code.

Differential Revision: https://phabricator.services.mozilla.com/D22642

--HG--
extra : moz-landing-system : lando
2019-04-22 19:26:00 +00:00
Srujana Peddinti b44e48bff4 Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki
Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag so that any referer in header files do not need to include MouseEvents.h only for referring them. Instead, they just need to include EventForwards.h. Now when MouseEvents.h is changed, the rebuild speed becomes faster.

Differential Revision: https://phabricator.services.mozilla.com/D25325

--HG--
extra : moz-landing-system : lando
2019-04-21 20:13:34 +00:00
Srujana Peddinti 0260a4f6e1 Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource r=masayuki
Renamed all class member instances from WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource

Differential Revision: https://phabricator.services.mozilla.com/D25322

--HG--
extra : moz-landing-system : lando
2019-04-21 18:19:43 +00:00
Srujana Peddinti 1f5de9021a Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::pressure to WidgetMouseEventBase::mPressure r=masayuki
Renamed all class member instances from WidgetMouseEventBase::pressure to WidgetMouseEventBase::mPressure

Differential Revision: https://phabricator.services.mozilla.com/D25314

--HG--
extra : moz-landing-system : lando
2019-04-21 18:19:18 +00:00
Srujana Peddinti 5f185eb5aa Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::button to WidgetMouseEventBase::mButton. r=masayuki
Renamed all class member instances from WidgetMouseEventBase::button to WidgetMouseEventBase::mButton.

Differential Revision: https://phabricator.services.mozilla.com/D25309

--HG--
extra : moz-landing-system : lando
2019-04-21 18:17:10 +00:00
Srujana Peddinti 614949385a Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::buttons to WidgetMouseEventBase::mButtons r=masayuki
Renamed all class member instances from  WidgetMouseEventBase::buttons to WidgetMouseEventBase::mButtons

Differential Revision: https://phabricator.services.mozilla.com/D25297

--HG--
extra : moz-landing-system : lando
2019-04-21 19:42:37 +00:00
Masayuki Nakano 1f3059e916 Bug 1542663 - Make nsViewManager and nsView (nsIWidgetListener) use mozilla::PresShell directly rather than via nsIPresShell r=tnikkel
This patch makes `nsViewManager::GetPresShell()` and
`nsIWidgetListener::GetPresShell()` (overridden by `nsView` and
`nsWebShellWindow::WidgetListenerDelegate`) return `mozilla::PresShell*`.

Additionally, makes `nsWebShellWindow::GetPresShell()` also return
`mozilla::PresShell()`.

Differential Revision: https://phabricator.services.mozilla.com/D26454

--HG--
extra : moz-landing-system : lando
2019-04-13 01:05:21 +00:00
Sylvestre Ledru 7f60810d86 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D27245

--HG--
extra : moz-landing-system : lando
2019-04-12 13:14:25 +00:00
Michael Froman 0b07404bf5 Bug 1539029 - pt 1 - give RDD its own process selector. r=froydnj
Originally, RDD reused the GPU process selector since they were
using all the same services, and it reduced the number of places
that had to be touched.  Now that RDD needs pref handling, it
needs its own process selector to avoid GPU inheriting pref
handling.

Differential Revision: https://phabricator.services.mozilla.com/D26566

--HG--
extra : moz-landing-system : lando
2019-04-09 21:13:16 +00:00
Andrew McCreight bf911424ef Bug 1543169 - Use nicer XPIDL arrays in nsITouchBarUpdater. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D26773

--HG--
extra : moz-landing-system : lando
2019-04-09 17:47:06 +00:00
Andrew McCreight c975aef40e Bug 1542944 - Release nsITouchBarInputCallback earlier so it doesn't leak. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D26712

--HG--
extra : moz-landing-system : lando
2019-04-09 16:53:55 +00:00
Haik Aftandilian 703b41f0d1 Bug 1541230 - Part 1 - YouTube Tab Crash on macOS 10.11 with security.sandbox.rdd.mac.earlyinit=true r=spohl
Don't swizzle the terminate method in process types that don't initialize the nsApplication.

Differential Revision: https://phabricator.services.mozilla.com/D26397

--HG--
extra : moz-landing-system : lando
2019-04-09 16:42:02 +00:00
Mike Hommey 071a2fe984 Bug 1541792 - Replace linker magic with manual component registration. r=froydnj
Before bug 938437, we had a rather large and error-prone
nsStaticXULComponents.cpp used to register all modules. That was
replaced with clever use of the linker, which allowed to avoid the mess
that maintaining that file was.

Fast forward to now, where after bug 1524687 and other work that
preceded it, we have a much smaller number of remaining static xpcom
components, registered via this linker hack, and don't expect to add
any new ones. The list should eventually go down to zero.

Within that context, it seems to be the right time to get rid of the
magic, and with it the problems it causes on its own.

Some of those components could probably be trivially be converted to
static registration via .conf files, but I didn't want to deal with the
possible need to increase the number of dummy modules in XPCOMInit.cpp.
They can still be converted as a followup.

Differential Revision: https://phabricator.services.mozilla.com/D26076

--HG--
extra : moz-landing-system : lando
2019-04-05 02:30:56 +00:00
Sylvestre Ledru 03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu 24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru 399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Emilio Cobos Álvarez 3a1e1a41c4 Bug 1541546 - Use the rust color representation. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D25976
2019-04-04 14:53:44 +02:00
Cosmin Sabou 8731816b89 Backed out 3 changesets (bug 1541546) for causing build bustages. CLOSED TREE
Backed out changeset 895863144707 (bug 1541546)
Backed out changeset 4da6fb98e8f9 (bug 1541546)
Backed out changeset ba71816514eb (bug 1541546)

--HG--
rename : layout/style/StyleColor.cpp => layout/style/StyleComplexColor.cpp
rename : layout/style/StyleColorInlines.h => layout/style/StyleComplexColor.h
2019-04-04 15:04:25 +03:00
Emilio Cobos Álvarez bc41ea853c Bug 1541546 - Use the rust color representation. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D25976

--HG--
extra : moz-landing-system : lando
2019-04-04 11:35:16 +00:00
Masayuki Nakano 5e41233499 Bug 1540990 - Get rid of unnecessary nsIPresShell.h inclusions r=emilio
A lot of files include `nsIPresShell.h` even though currently they don't
need it.  This patch removes the unnecessary inclusions.

Differential Revision: https://phabricator.services.mozilla.com/D25744

--HG--
extra : moz-landing-system : lando
2019-04-04 00:19:48 +00:00
Razvan Maries 1cd564b971 Backed out changeset 3b94c20ba873 (bug 1540990) for build bustages. CLOSED TREE 2019-04-04 02:44:00 +03:00
Masayuki Nakano b2bba953cc Bug 1540990 - Get rid of unnecessary nsIPresShell.h inclusions r=emilio
A lot of files include `nsIPresShell.h` even though currently they don't
need it.  This patch removes the unnecessary inclusions.

Differential Revision: https://phabricator.services.mozilla.com/D25744

--HG--
extra : moz-landing-system : lando
2019-04-03 23:29:38 +00:00
Masayuki Nakano fefd623c98 Bug 1530188 - Make nsChildView::GetEditorView() use eQueryContentState without flushing layout r=smaug
`nsChildView::GetEditorView()` is called by `TextInputHandlerBase::GetWindowLevel()`
which is called when Cocoa requests window level of focused widget.

It currently gets widget including focused element (e.g., it may be in a XUL
`<panel>`) with `eQueryTextContent` event.  However, it requires only the widget
(i.e., when a XUL `<panel>` has focused element, the widget for the panel).
Therefore, it does not require to flush the layout.

However, on macOS, `ContentEventHandler` always flushes layout even with
`eQueryContentState` which does not require any layout information.  Whether
it requires flushing layout or not is considered with
`WidgetQueryContentEvent::mNeedsToFlushLayout` but this is set to false only
when `IMEContentObserver` notifies widget (and IME) of focus set.  At this
time, only on macOS, IME caches the layout information, for example, the
character coordinates, but we don't have a way to update it.  This is the reason
why we always flush layout on macOS.

Unfortunately, when a menu popup frame is created, widget for the popup is
created synchronously.  Then, Cocoa retrieves window level of the widget including
focused element.  But this is unsafe to flush the layout.  So, we need to stop
flushing layout in this case.

Therefore, this patch moves the `#ifdef` from `TextEvents.h` to
`IMEContentObserver.cpp`, then, makes `nsChildView::GetEditorView()` use
`eQueryContentState` which is the simplest query content event, and finally,
sets `mNeedsToFlushLayout` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D25912

--HG--
extra : moz-landing-system : lando
2019-04-03 10:27:13 +00:00