cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
82dc9b2271
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 10:46:14 +00:00
e3dce68834
Backed out 3 changesets (bug 1643289, bug 1642949) for causing failure at test_headless_screenshot.html. CLOSED TREE
...
Backed out changeset 98c420f73380 (bug 1643289)
Backed out changeset 9447ea8910aa (bug 1643289)
Backed out changeset 0c827da9d847 (bug 1642949)
2020-06-10 10:07:23 +03:00
d419f0ff08
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 05:49:28 +00:00
191a830575
Bug 1628715 - Part 7: Add MOZ_NONNULL_RETURN to infallible nsTArray::AppendElements. r=xpcom-reviewers,necko-reviewers,nika,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D70831
2020-04-24 13:31:14 +00:00
444a911d92
Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that is changed during upgrading; r=smaug
...
In https://dom.spec.whatwg.org/#handle-attribute-changes , the attributeChangedCallback
reaction is enqueued only if the custom-element-state is customized.
And the assumption of "custom-element-definition is only available on the element whose
custom-element-state is customized" is no longer true after bug 1610054 along with the
spec changings in https://github.com/whatwg/html/pull/5126 .
Differential Revision: https://phabricator.services.mozilla.com/D71027
--HG--
extra : moz-landing-system : lando
2020-04-15 13:36:09 +00:00
a2961d74e7
Bug 1625789, optimize CustomElement constructors out from cycle collection graph, r=mccr8
...
Using the method name GetExistingCustomElements() to match CustomElements(), even though
they both return CustomElementRegistry.
Differential Revision: https://phabricator.services.mozilla.com/D69853
--HG--
extra : moz-landing-system : lando
2020-04-06 18:21:59 +00:00
00cd5d4380
Bug 1619112 part 5. Stop accepting nsAString in ErrorResult error-throwing. r=smaug
...
Callers should pass in UTF-8, since that's what the JS engine ends up with in the end anyway.
The various URL changes are because NS_NewURI converts incoming nsAString to
UTF-8 anyway. So we might as well do that up-front and then use the UTF-8
string for both the NS_NewURI call and the error-reporting if it fails.
Differential Revision: https://phabricator.services.mozilla.com/D65543
--HG--
extra : moz-landing-system : lando
2020-03-06 21:08:02 +00:00
c878a8bb26
Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D65538
--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
0082f55dee
Bug 1618011 part 7. Switch most error messages used in bindings to having a method name prefix. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D64888
--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
14247fb057
Backed out 11 changesets (bug 1618011)for Linting failure.
...
CLOSED TREE
Backed out changeset 8b11ddd8999f (bug 1618011)
Backed out changeset 11df2f359473 (bug 1618011)
Backed out changeset c50121035d50 (bug 1618011)
Backed out changeset 8b8c4c60c34b (bug 1618011)
Backed out changeset b01f8c66110b (bug 1618011)
Backed out changeset 433fdf04058c (bug 1618011)
Backed out changeset 29a9227d08ac (bug 1618011)
Backed out changeset b2dfa2e66d24 (bug 1618011)
Backed out changeset 85650ee945c4 (bug 1618011)
Backed out changeset 278a213e5304 (bug 1618011)
Backed out changeset 9119aeb72ea4 (bug 1618011)
2020-03-07 00:15:57 +02:00
bc068d0e54
Bug 1618011 part 7. Switch most error messages used in bindings to having a method name prefix. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D64888
--HG--
extra : moz-landing-system : lando
2020-03-06 20:39:10 +00:00
32c9aeaad4
Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D63865
--HG--
extra : moz-landing-system : lando
2020-02-25 09:36:12 +00:00
7f1afff492
Backed out 5 changesets (bug 1617604, bug 1617542, bug 1617546) for causing build bustages on ipc/mscom/Interceptor.cpp.
...
CLOSED TREE
Backed out changeset 5faa54ad950e (bug 1617542)
Backed out changeset cb38779e1eb6 (bug 1617604)
Backed out changeset 3aea18e0396f (bug 1617542)
Backed out changeset bc3eeefdfb6c (bug 1617542)
Backed out changeset b76a3aa5ff6f (bug 1617546)
2020-02-24 19:50:13 +02:00
df538d9a79
Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D63865
--HG--
extra : moz-landing-system : lando
2020-02-24 17:08:30 +00:00
05327f8a52
Bug 1613978. Allow passing u"...", not just nsAStrings, to templated ThrowType/RangeError. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D62061
--HG--
extra : moz-landing-system : lando
2020-02-10 13:08:48 +00:00
1395be1f23
Bug 1613013 part 3. Annotate TypeErrors and RangeErrors from WebIDL implementations with the method they come from. r=peterv
...
Please review the changes to Errors.msg very carefully. I caught a number of
mistakes there in self-review (e.g. not renumbering replacement markers
correctly when I added {0} to the beginnings of strings), and my confidence
that I caught them all is only middling.
A few lines (MSG_USELESS_SETTIMEOUT, MSG_TYPEDARRAY_IS_DETACHED,
MSG_NOT_SUBMIT_BUTTON) were removed from Errors.msg either because they were
already unused or because they either were single-user constant strings or
became such in the new setup and we could just use the string version of
ThrowTypeError.
Differential Revision: https://phabricator.services.mozilla.com/D61523
--HG--
extra : moz-landing-system : lando
2020-02-06 21:22:32 +00:00
747a4d9f0a
Bug 1613013 part 1. Annotate DOMExceptions from WebIDL implementations with the method they come from. r=peterv
...
This adds the name of the interface and method to the beginning of the exception
string when reporting the exception from Web IDL codegen, so it's clearer what
was called.
Some existing error messages are adjusted to not duplicate the information
about which method was called.
Differential Revision: https://phabricator.services.mozilla.com/D61521
--HG--
extra : moz-landing-system : lando
2020-02-06 21:16:10 +00:00
f2e63f3027
Bug 1543570 - Make CustomElementConstructor exceptions more consistent; r=smaug
...
See https://github.com/whatwg/html/pull/4525 .
Differential Revision: https://phabricator.services.mozilla.com/D61247
--HG--
extra : moz-landing-system : lando
2020-02-04 23:47:18 +00:00
b88d5ac5a8
Bug 1612213 part 1. Switch most consumers of ThrowDOMException to the new methods. r=smaug,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D61267
--HG--
extra : moz-landing-system : lando
2020-02-03 20:19:11 +00:00
767c73d6b2
Bug 1610054 - Prevent infinite recursion when upgrading custom elements; r=smaug
...
See https://github.com/whatwg/html/pull/5126 .
Differential Revision: https://phabricator.services.mozilla.com/D60848
--HG--
extra : moz-landing-system : lando
2020-01-28 08:46:47 +00:00
187e9bafaf
Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D60354
--HG--
extra : moz-landing-system : lando
2020-01-21 09:51:27 +00:00
78ee6675cf
Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D59042
--HG--
extra : moz-landing-system : lando
2020-01-13 19:18:56 +00:00
69ea5af19a
Bug 1605662 - Remove redundant return in void function. r=sylvestre
...
Depends on D58225
Differential Revision: https://phabricator.services.mozilla.com/D58227
--HG--
extra : moz-landing-system : lando
2019-12-26 08:42:00 +00:00
b47fa008ad
Bug 1595050 - Update spec comment in CustomElementRegistry::Define to reflect the latest spec; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D52348
--HG--
extra : moz-landing-system : lando
2019-11-08 13:18:53 +00:00
de2c2a249a
Bug 1552313 - Implement element.attachInternals; r=smaug,edgar
...
ElementInternals class is empty-for-now.
Differential Revision: https://phabricator.services.mozilla.com/D52158
--HG--
extra : moz-landing-system : lando
2019-11-12 11:27:55 +00:00
790ed5a490
Bug 1552313 - Implement disableShadow; r=smaug,edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D52157
--HG--
extra : moz-landing-system : lando
2019-11-12 11:27:52 +00:00
128e81de25
Bug 1552313 - Implement custom element disabledFeatures and disableInternals; r=smaug,edgar
...
- Introduce `dom.webcomponents.elementInternals.enabled` for custom element's elementInternals.
- Implement disabledFeatures static field and disableInternals.
- Refactor get observedAttributes sequence.
Differential Revision: https://phabricator.services.mozilla.com/D52156
--HG--
extra : moz-landing-system : lando
2019-11-12 11:27:45 +00:00
cbf2994b14
Backed out 3 changesets (bug 1552313) for WPT failures in custom-elements/CustomElementRegistry.html. CLOSED TREE
...
Backed out changeset 27a01989152a (bug 1552313)
Backed out changeset 5f8c6c9f2d36 (bug 1552313)
Backed out changeset f26d61e06a9d (bug 1552313)
2019-11-11 20:55:58 +02:00
d9933f32ad
Bug 1552313 - Implement element.attachInternals; r=smaug,edgar
...
ElementInternals class is empty-for-now.
Differential Revision: https://phabricator.services.mozilla.com/D52158
--HG--
extra : moz-landing-system : lando
2019-11-11 15:43:03 +00:00
708988da6b
Bug 1552313 - Implement disableShadow; r=smaug,edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D52157
--HG--
extra : moz-landing-system : lando
2019-11-11 15:42:58 +00:00
e95dd01125
Bug 1552313 - Implement custom element disabledFeatures and disableInternals; r=smaug,edgar
...
- Introduce `dom.webcomponents.elementInternals.enabled` for custom element's elementInternals.
- Implement disabledFeatures static field and disableInternals.
- Refactor get observedAttributes sequence.
Differential Revision: https://phabricator.services.mozilla.com/D52156
--HG--
extra : moz-landing-system : lando
2019-11-11 15:42:56 +00:00
417c6749c3
Bug 1581276. Require a message arg to ThrowDOMException. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D46250
--HG--
extra : moz-landing-system : lando
2019-09-20 02:17:01 +00:00
4366802146
Bug 1560744 - Part 2: Add clearer error message for duplicate custom element name;
...
Differential Revision: https://phabricator.services.mozilla.com//D38206
2019-07-16 19:35:12 +03:00
0805f9e709
Bug 1560744 - Add clearer message for custom elements; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D38082
--HG--
extra : moz-landing-system : lando
2019-07-16 10:03:10 +00:00
b275f554ac
Bug 1542932 Remove CustomElementConstructor copy r=bzbarsky
...
Depends on D26868
Differential Revision: https://phabricator.services.mozilla.com/D26869
--HG--
extra : moz-landing-system : lando
2019-04-10 15:45:57 +00:00
e4131b866f
Bug 1542932 Change define() parameter functionConstructor from Function to CustomElementConstructor r=bzbarsky
...
Depends on D26867
Differential Revision: https://phabricator.services.mozilla.com/D26868
--HG--
extra : moz-landing-system : lando
2019-04-10 15:45:11 +00:00
9e68172512
bug 1542932 Generate CustomElementConstructor from WebIDL callback definition r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D26867
--HG--
extra : moz-landing-system : lando
2019-04-11 23:05:10 +00:00
99521124d0
Bug 1542932 align CustomElementConstructor::Construct() parameters with WebIDL bindings conventions r=bzbarsky
...
Depends on D26865
Differential Revision: https://phabricator.services.mozilla.com/D26866
--HG--
extra : moz-landing-system : lando
2019-04-10 15:25:15 +00:00
1896b280b5
bug 1542934 Annotate that CustomElementConstructor::Construct() callers can run script r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D26635
--HG--
extra : moz-landing-system : lando
2019-04-10 12:51:15 +00:00
8591f49e08
Bug 1542934 Mark strong reference members as const to aid CanRunScriptChecker r=smaug
...
Depends on D26633
Differential Revision: https://phabricator.services.mozilla.com/D26634
--HG--
extra : moz-landing-system : lando
2019-04-09 13:37:23 +00:00
fb212757ff
Bug 1542934 strong ref arguments for functions that may run CustomElementConstructor::Construct() r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D26633
--HG--
extra : moz-landing-system : lando
2019-04-10 06:29:56 +00:00
c40e81a2e9
Bug 1537536 - Move JS::ForOfIterator to its own header. r=arai,bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D24257
--HG--
rename : js/src/jsapi.h => js/public/ForOfIterator.h
extra : moz-landing-system : lando
2019-03-26 17:10:44 +00:00
00e98538aa
Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D21106
--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
12266da44b
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D17884
--HG--
extra : moz-landing-system : lando
2019-02-02 03:24:22 +00:00
44e4d42e8a
Backed out 7 changesets (bug 1521907) for failing at unit/test_bug1151385.js on a CLOSED TREE.
...
Backed out changeset ef04359ccf0d (bug 1521907)
Backed out changeset ac1c61bf61e9 (bug 1521907)
Backed out changeset df09b7be63c5 (bug 1521907)
Backed out changeset 585fa0024d46 (bug 1521907)
Backed out changeset e593c29aaff4 (bug 1521907)
Backed out changeset ac2e180a35b6 (bug 1521907)
Backed out changeset 270b1db9ea81 (bug 1521907)
2019-02-02 00:58:16 +02:00
76e1fab0c7
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D17884
--HG--
extra : moz-landing-system : lando
2019-02-01 18:48:36 +00:00
63b0f3f854
Backed out 7 changesets (bug 1521907) for JSObject Wrapper.cpp bustages and failures CLOSED TREE
...
Backed out changeset ce3108090e77 (bug 1521907)
Backed out changeset efd05f4979f1 (bug 1521907)
Backed out changeset 2d0895148907 (bug 1521907)
Backed out changeset 192152fe986a (bug 1521907)
Backed out changeset ca65b46b0d37 (bug 1521907)
Backed out changeset b3daf5ca3d11 (bug 1521907)
Backed out changeset 1b0a09a46c70 (bug 1521907)
2019-02-01 19:38:25 +02:00
b014cb9758
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D17884
--HG--
extra : moz-landing-system : lando
2019-01-31 15:51:52 +00:00
98f992df34
Bug 1519193 part 3. Convert CustomElementRegistry::Upgrade to using ShadowIncludingTreeIterator. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D16244
--HG--
extra : moz-landing-system : lando
2019-01-12 03:19:27 +00:00
Simon Giesecke
Butkovits Atila
Edgar Chen
Olli Pettay
Boris Zbarsky
Arthur Iakab
Cosmin Sabou
Sylvestre Ledru
Eric Rahm
Manish Giri
John Dai
Dorel Luca
Karl Tomlinson
Jeff Walden
Ryan Hunt
Gurzau Raul
Ciure Andrei