a71fdf6c5c
Convert T61String-labeled ISO-8859-1 to UTF-8: bug 53133 r=nelsonb a=wtc
2004-01-15 06:23:14 +00:00
65088fd320
Add 2 additional OIDs to the list of acceptable digestEncryptionAlgIDs,
...
per RFC 3370. r=thayes. Bug 230761.
2004-01-14 22:20:44 +00:00
49152980bd
Tool to manage pkcs 11 module tests.
2004-01-14 21:34:20 +00:00
0a29c7fe2b
Fix double free introduced in rev 1.54. r=wtc. bug 230774.
...
Bug occurs only in NSS utilities that import base64 encoded files, e.g.
with the -a option.
2004-01-14 01:19:26 +00:00
ab1b1d58f9
Bugzilla bug 229289: fixed an unused variable warning. r=relyea.
2004-01-13 01:59:41 +00:00
c000ae86e8
General deCOMtamination of nsIDocument, nsIContent, and nsIFormSubmission. Eliminating nsIAttributeContent, and doing some URL->URI changes. r+sr=peterv@propagandism.org
2004-01-09 23:54:21 +00:00
7bcf0f4ab9
Upgraded to NSPR 4.4.1 and NSS 3.9.
2004-01-09 02:34:14 +00:00
2543d8c8d1
Bugscape bug 54500: made uniqueNamedKeyExists public.
2004-01-08 18:09:15 +00:00
8dc069e8e4
Overload the error code SSL_ERROR_RX_RECORD_TOO_LONG to report SSL2
...
records that are too short. Bugscape bug 54814
2004-01-08 06:52:00 +00:00
8a6338d551
Rename PK11_PubDeriveExtended to PK11_PubDeriveWithKDF
2004-01-08 01:37:46 +00:00
435bc1ad86
Set NSS version to 3.9.
2004-01-08 01:04:56 +00:00
e7036921ca
Rename PK11_FindSlotsByAliases to PK11_FindSlotsByNames
2004-01-07 23:12:01 +00:00
70f0bbf00d
Rename CERT_DecodeTimeChoice/CERT_EncodeTimeChoice to DER_DecodeTimeChoice/DER_EncodeTimeChoice
2004-01-07 23:07:24 +00:00
d0f309943a
Continuing to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 13:37:00 +00:00
274ef7cd49
Beginning to land the PACKAGING_20030906_BRANCH for bug 20640. Not part of the build, yet.
2004-01-07 01:22:31 +00:00
5d8bd61334
Fix crashes in NSS_CMSSignedData_GetDigestValue and
...
NSS_CMSContentInfo_GetContent that occur when a detached signature is not
accompanied by the data on which the signature was computed. Bug 229242.
Make NSS_CMSContentInfo_GetInnerContent and NSS_CMSMessage_GetContent
more easily debugged, by storing the results returned by function calls
in automatic variables before using them in subsequent calls/switches.
2004-01-07 00:09:17 +00:00
6a63299667
Bug 229193
...
Patch by wtc revied by relyea & ian
2003-12-31 23:19:26 +00:00
c54ac86e5f
Fix the security warning dialogs to work as designed for Firebird:
...
- All dialogs will appear the first time a user encounters them
- The "show every time" checkbox will default to off
- If the user checks the checkbox to see the dialogs every time, the choice will be remembered.
Because of the change in default prefs, this will cause Firebird users to see these dialogs again (but defaulted to not show after that) when upgrading. Bug 172091, r=brendan, sr=ben.
2003-12-31 23:03:08 +00:00
144c518d7a
Set NSS version to 3.9 Beta 6.
2003-12-24 06:22:49 +00:00
1550e4ab3e
Removed unused variable 'val'.
2003-12-23 21:40:52 +00:00
0ea554f2f9
Fixed unused variable compiler warning about 'html'. Declare it inside
...
the same ifdef with which it is used.
2003-12-23 21:37:07 +00:00
34519e6ab3
Removed unused variable 'rawSigLen'.
2003-12-23 21:24:01 +00:00
11c67b98af
Removed unused variable 'attribute'.
2003-12-23 21:21:39 +00:00
60cf880826
Include "nsslocks.h" for nss_InitLock.
2003-12-23 02:09:55 +00:00
5bfcd81514
Declare the argument to SECKEY_ECParamsToKeySize as const.
...
Modified Files: seckey.c pk11skey.c
2003-12-23 02:05:28 +00:00
95e1ce0279
Bugscape bug 54500: trim preceding/trailing whitespace from passed-in
...
String arguments.
2003-12-23 01:19:48 +00:00
09584fb9f9
Return a value of the correct type.
2003-12-23 01:03:39 +00:00
290a965230
Fixed a spelling error.
2003-12-23 00:52:06 +00:00
0433b41c3b
Moved ecl-curve.h from the EXPORTS to the PRIVATE_EXPORTS list.
2003-12-23 00:17:04 +00:00
79387320b7
Renamed SECKEY_ECParams2KeySize as SECKEY_ECParamsToKeySize. Do not export
...
this function from the nss3 shared library.
Modified Files: seckey.c pk11skey.c nss.def
2003-12-22 23:36:40 +00:00
7adfc17d1d
Declare the 'input' argument to CERT_DecodeTimeChoice as 'const'. Removed
...
an extraneous semicolon (;) after the SEC_ASN1_CHOOSER_IMPLEMENT macro.
Modified Files: secder.h sectime.c
2003-12-22 23:33:39 +00:00
4b807fd2b8
Bugzilla bug 228907: added a stub implementation for the obsolete native
...
function Java_org_mozilla_jss_pkcs11_PK11Cert_getNickname, which is listed
in the symbol export file jss.def.
2003-12-20 15:56:11 +00:00
76bb8f646c
Some further cleanup of p12d.c. Bugscape bug 52528. r=wtc.
2003-12-20 01:33:06 +00:00
7905ca6b6f
Set NSS version to 3.9 Beta 5.
2003-12-20 00:35:01 +00:00
9ccb6b87c5
Made wincx the last argument of PK11_PubDeriveExtended. r=relyea.
...
Modified Files: pk11func.h pk11skey.c ssl3con.c
2003-12-19 23:54:29 +00:00
312061509b
Impose new limits on RSA public key sizes. 8k bits for modulus,
...
64 bits for public exponent. This prevents certain attacks on SSL
servers. Bugscape bug 54019. r=wtc,relyea.
2003-12-19 23:50:45 +00:00
010acd81c1
PK11_MoveKey was renamed PK11_MoveSymKey. r=relyea.
...
Modified Files: symkeyutil.c nss.def pk11func.h pk11skey.c
2003-12-19 23:29:43 +00:00
6e767fb4eb
Make database access to the key db thread safe.
2003-12-19 23:24:48 +00:00
8ec4937462
Add keydb lock type. keydb should be locked like the certdb.
2003-12-19 23:24:00 +00:00
5014045f8c
Backed out the previous checkin, which broke our S/MIME QA tests.
2003-12-19 22:54:20 +00:00
fac46295ff
Bugzilla bug 228624: we need to call STAN_ForceCERTCertificateUpdate if
...
the cert's instances changed. r=relyea.
2003-12-19 22:33:12 +00:00
64276531dd
Bugscape bug 54627: made the fix for NSS_CMSSignedData_Encode_BeforeData
...
the same as the code in NSS_CMSSignedData_Decode_BeforeData. r=nelsonb.
2003-12-19 22:08:12 +00:00
c367aa403a
Bugscape bug 54500: Improved the previous checkin: fixed leaks of the
...
return values of PK11_GetSymKeyNickname. Removed unnecessary assignment
statements "symKeyObj = NULL;". Removed an unnecessary else { }.
2003-12-19 19:36:30 +00:00
deb29c8f1f
Import NSPR 4.4.1.
2003-12-19 17:02:57 +00:00
4a54a29151
Bugzilla bug 221133: fixed unused variable warning on some platforms.
...
The patch is contributed by timeless@bemail.org . r=wtc.
2003-12-19 16:35:14 +00:00
ec5678ff34
Bugscape bug 54500: added some new methods to the SecretDecoderRing
...
KeyManager class. The patch is contributed by Matthew Harmsen of AOL.
Modified Files:
lib/jss.def org/mozilla/jss/SecretDecoderRing/KeyManager.c
org/mozilla/jss/SecretDecoderRing/KeyManager.java
2003-12-19 05:33:50 +00:00
546a8a6e87
Set JSS version to 3.5 Beta.
...
Modified Files:
org/mozilla/jss/CryptoManager.java
org/mozilla/jss/util/jssver.h
2003-12-19 05:08:34 +00:00
70470925e0
Don't overwrite pointers to existing message digests if they've been
...
precomputed. Bugscape bug 54627. r=wtc, jpierre.
2003-12-19 03:58:28 +00:00
a08b14e07e
Bugzilla bug 228907: enable PK11Store.getCertificates to return the correct
...
nicknames for certs with multiple instances. This requires adding a new
nickname argument to the constructors of the various cert classes and
passing a nickname better than NSS's cert->nickname where possible.
r=thomask.
Modified Files:
pkcs11/PK11Cert.c
pkcs11/PK11Cert.java
pkcs11/PK11InternalCert.java
pkcs11/PK11InternalTokenCert.java
pkcs11/PK11Store.c
pkcs11/PK11TokenCert.java
pkcs11/pk11util.h
util/java_ids.h
2003-12-19 00:19:57 +00:00
8bfb2f97fd
Set NSS version to 3.9 Beta 4.
2003-12-18 21:45:34 +00:00
991ddf2ba6
Bugzilla bug 228624: made PK11_ListCertsInSlot reach into the Stan layer
...
to obtain the correct nicknames of the cert instances (pk11cert.c). Fixed
the bug that if a cert we want to add the the cache is already in the
cache, we should merge the instances of the cert before destroying the
duplicate cert (tdcache.c). r=jpierre,relyea.
2003-12-18 18:23:17 +00:00
ec4dda5d19
Bugzilla bug 219982: removed an unused local variable. (The function call
...
is needed for its side effect.) Thanks to timeless@bemail.org and
Serge GAUTHERIE <gautheri@noos.fr> for the patch. r=wtc.
2003-12-17 22:43:25 +00:00
634bb98533
Allow NSS_CMSDigestContext objects to be created, even when there are
...
no valid digest algorithm OIDs. This allows "certs only" messages to
be decoded. Bugzilla bug 228707. r=jpierre, wtc.
2003-12-17 03:49:10 +00:00
e3cda94421
Bugzilla bug 228618: fixed an incorrect use of realloc. Fixed an unused
...
variable compiler warning. r=jpierre.
2003-12-16 04:24:57 +00:00
b41986df1b
Fix S/MIME bugs that caused parallel arrays of digest OIDs and digest
...
values to become out of sync. Bugscape bug 54256. r=relyea.
Modified Files: cmd/smimetools/cmsutil.c lib/smime/cmsdigest.c
2003-12-12 23:55:06 +00:00
3331d24ed7
Fix for 54061 . Return SEC_ERROR_INVALID_ARGS and remove assertions . r=wtc,misterssl
2003-12-12 21:42:02 +00:00
cbcce6aa7e
fixes bug 228062 "NTLM authentication fails with mod_ntlm, mod_ntlm reports 'missing/corrupt NTLM header'" r+sr=bryner a=dbaron
2003-12-12 02:58:42 +00:00
ec74b37f9f
fix 227991, nsNSSCertificateDB::AddCertFromBase64 crashes (only used from auto config), r=kaie, sr=mscott, a=sspitzer
2003-12-11 16:02:08 +00:00
fff428a34a
CERT_ImportCerts now returns SECFailure when NONE of the certs was succesfully imported. r=wtc. Bugscape bug 54311.
2003-12-06 06:52:53 +00:00
7ed9720eb2
__CERT_AddTempCertToPerm will now set error SEC_ERROR_ADDING_CERT
...
when attempting to make a cert perm that is already permanent.
Bugzilla bug 227559. r=wtc
2003-12-06 06:46:27 +00:00
87f5c7ded0
NSC_Finalize will now destroy 3 softoken free lists and one more
...
global pointer. Plugs some memory leaks. Bugscape bug 54301. r=wtc
2003-12-06 06:41:51 +00:00
6f425d9730
Add /FIXED:NO argument to linker command line for EXEs. Purify
...
requires this to precisely instrument EXEs. r=wtc
2003-12-06 06:34:20 +00:00
2b4825491c
Add new -k option to NSS QA test program cmsutil. By default, cmsutil
...
will no longer add any decoded certs to the cert db file, which is
useful for reproducibility of results in QA scripts.
Bugscape bug 54293. r=relyea,jpierre,wtc
2003-12-06 06:31:08 +00:00
2483a508a7
Bugzilla bug 227296: fixed the bug that NSS_CMSAttribute_AddValue adds the
...
address of a stack variable to the attr->values array. Added a new
function SECITEM_ArenaDupItem. r=nelsonb.
Modified Files:
nss/nss.def util/secitem.c util/secitem.h smime/cmsarray.c
smime/cmsattr.c
2003-12-06 01:16:50 +00:00
265f6a9b37
Further simplification and improvement of the parsing of UTCTime
...
and GeneralizedTime to avoid UMRs. Bugscape bug 54198. r=wtc
2003-12-05 04:53:28 +00:00
b87fc256c1
NSS_CMSContentInfo_Destroy()
...
- The patch destroys the digest context member of the CMSContentInfo.
It calls the previously unused function NSS_CMSDigestContext_Cancel
to destroy the digest context. Eliminates an object reference leak.
Bugscape bug 54208, r=relyea
2003-12-04 00:39:24 +00:00
697b57f151
In functions NSS_CMSSignedData_Encode_AfterData and
...
NSS_CMSSignedData_Decode_AfterData
- These functions call NSS_CMSDigestContext_FinishMultiple, which
always destroys the digest context, regardless of whether it returns
SECSUccess or SECFailure. So, change these functions to always NULL
out the context pointer regardless of the returned value.
NSS_CMSSignedData_VerifySignerInfo()
- Always call NSS_CMSSignerInfo_Verify() to set the verification status
in the signerinfo object, even if some of the other arguments are NULL,
or other failures have occurred, but avoid NULL pointer dereferences
along the way. Notice that this change is dependent on changes to
NSS_CMSSignerInfo_Verify() (see below.)
NSS_CMSSignedData_SetDigests() - skip over missing digests. Don't fail
the function, and don't crash, if digest pointers are NULL.
Bugscape bug 54208, r=relyea
2003-12-04 00:36:47 +00:00
8a0ca297e4
Functions NSS_CMSDigestedData_Encode_AfterData and
...
NSS_CMSDigestedData_Decode_AfterData
- Since NSS_CMSDigestContext_FinishSingle always destroys the context,
regardless of whether it returns SECSuccess or SECFailure, these
functions have been changed to always NULL out the context pointer
after calling NSS_CMSDigestContext_FinishSingle, regardless of the
outcome.
Bugscape bug 54208, r=relyea
2003-12-04 00:35:02 +00:00
d0960c05d3
There is a lot of "cleanup" in this file, wrapping source at 80 columns.
...
The relevant fixes for this bug include:
NSS_CMSDigestContext_StartMultiple()
- make sure that cmsdigcx->digcxs and cmsdigcx->digobjs are initialized.
- at the "loser" label, be sure to free the digest context itself.
NSS_CMSDigestContext_Cancel()
- after destroying all the objects, free the arrays of pointers to the
objects, and the digest context itself. Previously these items were
leaked by this function.
NSS_CMSDigestContext_FinishMultiple()
- ensure that this function ALWAYS destroys all the NSS digest objects,
and doesn't stop destroying them if it encounters an error. Note that
this is a newer revision of an older patch for that problem.
- always Free the arrays of pointers used in this object.
NSS_CMSDigestContext_FinishSingle()
- simplify this code.
Bugscape bug 54208, r=relyea
2003-12-04 00:32:18 +00:00
f6f1a0d2e4
NSS_CMSSignerInfo_Verify()
...
- This function is changed to explicitly allow some of its input arguments
to be NULL. It will set the verification status in the CMSSignerInfo
object accordingly. Since this is the ONLY function that ever sets the
verification status, it must be able to do so even when problems have
occurred.
- lots of cleanup of this source code.
Bugscape bug 54208, r=relyea
2003-12-04 00:29:31 +00:00
874fa3a93d
Add null pointer checks to nss_cms_after_end and NSS_CMSEnvelopedData_Decode_AfterData. Bugscape bug 54061. r=wtc,relyea
...
Lots of code "cleanup" (reformatting for 80 columns) in cmsdecode.c
2003-12-04 00:14:24 +00:00
e4d53231f8
Avoid UMRs in dertime.c. Bugscape bug 54198. r=wtc.
2003-12-03 04:03:40 +00:00
e6c9ba62d7
Fix for 54061 - null pointer check . r=nelsonb
2003-12-03 02:42:08 +00:00
80462e9cb1
Bugscape bug 54021: in CERT_FindSubjectKeyIDExtension, if PORT_NewArena
...
fails we should return SECFailure. Document that the return values of
CERT_GetCommonName and NSS_CMSSignerInfo_GetSignerCommonName must be freed
with PORT_Free. r=nelsonb.
Modified Files:
certdb/alg1485.c certdb/cert.h certdb/certv3.c smime/cms.h
smime/cmssiginfo.c
2003-12-03 00:09:05 +00:00
d5582721b7
Separate locale version from Mozilla version so we do not have to bump locale version for every release. b=226377 r=kairo, bsmedberg sr=ben a=asa
2003-12-02 23:22:11 +00:00
e5c708bb65
Prevent SMIME crash in the opaque signature test. bugscape 54061. r=nelsonb
2003-12-02 05:46:27 +00:00
7eef555978
Fix for 54088 . Don't try to encode attributes with no value. r=wtc
2003-12-02 05:05:30 +00:00
02198fd686
Bound stan error stack at 16 error codes to limit growth.
...
Bugscape bug 54021. r=wtc.
2003-12-02 02:05:47 +00:00
cb7164249f
Reverted to NSPR 4.3 until Sun has NSPR 4.4.1 binary distributions.
2003-11-28 05:41:42 +00:00
785b886515
Detect invalid input buffer lengths, and return error instead of UMR>
...
Bugscape bug 54021. r=wchang0222
2003-11-27 05:08:20 +00:00
13f3e6fa94
Fix leak in CERT_FindSubjectKeyIDExtension, and use the Quick DER
...
decoder. Bugscape bug 54021. r=jpierre
2003-11-27 05:06:20 +00:00
1731be9206
Upgraded to NSPR 4.4.1.
2003-11-27 01:43:15 +00:00
931071736c
Clean up some arithmetic used for UCS4. Detect when UCS2 and UCS4
...
buffers have invalid lengths. Bugscape bug 54021. r=whang0222, relyea
2003-11-27 01:08:59 +00:00
dcc1fa5880
Bugzilla bug 226861: removed NSS_CMSSignedData_GetDigestByAlgTag, which is
...
a duplicate of NSS_CMSSignedData_GetDigestValue. r=nelsonb.
Modified Files: cms.h cmssigdata.c
2003-11-26 23:50:02 +00:00
1c7b6a8ea4
In NSS_CMSSignedData_VerifySignerInfo(), test all returned pointers
...
for NULL before attempting to dereference them.
Bugscape bug 54057. r=wchang0222
2003-11-26 22:02:38 +00:00
36fc65a627
Performance enhancement. Detect absurdly large modulae in public keys,
...
and don't waste time on them. Bugscape bug 54019. r=relyea.
2003-11-26 06:26:31 +00:00
d596531040
Remove an unnecessary and incorrect assert call.
...
Bugscape bug 54018. r=jpierre
2003-11-26 06:16:01 +00:00
8cc8dfcdf3
This patch reduces the scope of many variables in cmsutil's decode function. It frees the signer's CN string after use.
...
Bugscape bug 54021. r=jpierre
2003-11-25 23:26:39 +00:00
2c0d2708f3
fixes bug 226639 "send NegotiateAlwaysSign in NTLM type 1 message to make NetApp/6.3.3 happy" r+sr=bryner a=dbaron
2003-11-25 02:12:41 +00:00
86e2d2c45d
Bugzilla bug 226470: removed -qarch=com, which is the default for the
...
compiler. r=pkw@us.ibm.com .
2003-11-24 19:45:18 +00:00
034bf93de9
Bugzilla bug 226470: use a C compiler rather than a C++ compiler to compile
...
C code. The patch is contributed by Philip K. Warren <pkw@us.ibm.com>.
2003-11-22 06:45:50 +00:00
20abf0c0aa
Don't invoke PKCS11 with an invalid handle. Bug 226285.
...
r=relyea sr=wchang0222
2003-11-21 22:10:56 +00:00
d3382c6ffe
Remove an overreaching constraing on modulus length. Bug 226285.
...
r=relyea sr=wchang0222
2003-11-21 22:09:27 +00:00
0fa7d0adc8
Implement new "batch mode" (see the -b option). Plug some leaks.
...
Facilitates memory leak testing of the SMIME library.
This revision combines the patches for Bugzilla bug 225513 and
Bugscape bug 53775. r = relyea and wchang0222
2003-11-20 02:33:18 +00:00
52dffd46a8
Don't accept ASN.1 items whose length is 2GB or more.
...
Bugscape bug 53875. r=wchang0222 and r=relyea.
2003-11-20 02:08:34 +00:00
67d78ccfb9
Dont attempt to allocate 2GB or more from an arenapool.
...
Bugscape bug 53875. r=relyea.
2003-11-20 02:06:16 +00:00
511a262edc
Remove as assertion that is triggered by bad data input, but does not
...
indicate a code flaw. Bugscape bug 53875. r=relyea
2003-11-20 02:04:07 +00:00
75ca774270
Be sure not to ask NSS to use an invalid PKCS11 mechanism.
...
Bugscape bug 53875. r=relyea.
2003-11-20 02:00:04 +00:00
b79aed8a42
Plug a leak that occurs when code asks NSS to use an invalid PKCS11
...
mechanism. Bugscape bug 53875. r=relyea
2003-11-20 01:59:07 +00:00
d7ce33ed84
fix two "might be used uninitialized" warnings from NTLM patch, bug=224653.
2003-11-19 05:00:43 +00:00
jgmyers%speakeasy.net
nelsonb%netscape.com
relyea%netscape.com
wchang0222%aol.com
jst%mozilla.jstenback.com
jpierre%netscape.com
bsmedberg%covad.net
bryner%brianryner.com
darin%meer.net
bienvenu%nventure.com
dbaron%dbaron.org