99ab2bae3c
Bug 1797211: Make TextOverflow's default constructor private (as a nudge towards its static factory method). r=dshin
...
This patch also reorders the destructor/constructor decls so that all the
deleted ones are bunched together.
Differential Revision: https://phabricator.services.mozilla.com/D160547
2022-10-27 17:58:06 +00:00
3c206e563a
Bug 1786147 - Make -webkit-line-clamp create a block container in the appropriate situations. r=dholbert
...
This is a hack, sorta, similar to Chromium's:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_object.cc;l=356;drc=312b74e385e6aba98ab31fd911238c0dc16b396c
except at computed-value rather than used-value time, because it's both
simpler to reason about and prevents lying in the computed style.
This fixes the relevant test-case, and matches closer what Chromium does,
by not creating anonymous flex items for all elements inside the
line-clamp context.
The behavior change is covered by the test changes. I had to also fix a
couple pre-existing bugs that were caught by tests, now that the
line-clamped block is the -webkit-box-styled element rather than an anonymous
flex item (and thus now had padding).
Depends on D155180
Differential Revision: https://phabricator.services.mozilla.com/D155181
2022-09-07 23:57:18 +00:00
628cc55f22
Bug 708901 - Migrate to nsTHashSet in layout. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D108597
2021-03-24 17:56:46 +00:00
f54ee076ae
Backed out 13 changesets (bug 708901, bug 1184468) for causing build bustage on GeckoViewHistory.cpp. CLOSED TREE
...
Backed out changeset b1e4c01e63b8 (bug 708901)
Backed out changeset 37b52cce83c0 (bug 708901)
Backed out changeset eee75f33f060 (bug 708901)
Backed out changeset 479bf64c7986 (bug 708901)
Backed out changeset 15a8fb94d15d (bug 708901)
Backed out changeset be31ccd9a61d (bug 708901)
Backed out changeset fc54f4eaedd5 (bug 708901)
Backed out changeset 03c3a56c3d13 (bug 708901)
Backed out changeset 73f11d3c1298 (bug 708901)
Backed out changeset aed22fd80893 (bug 708901)
Backed out changeset 74d8249fbe7e (bug 708901)
Backed out changeset acb725eb3c1d (bug 1184468)
Backed out changeset 70f3ea6efec4 (bug 1184468)
2021-03-24 19:26:20 +02:00
c73f87b72b
Bug 708901 - Migrate to nsTHashSet in layout. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D108597
2021-03-24 16:58:58 +00:00
fdc00547f6
Bug 1637130 - Rename visual overflow to ink overflow. r=dbaron
...
This patch is generated by:
```
# Rename the nsOverflowType enum.
rg -l "eVisualOverflow" layout/ gfx/ | xargs sed -i "s/eVisualOverflow/eInkOverflow/g"
# Rename and drop the "Get" prefix from various functions.
rg -l "GetVisualOverflowRect" layout/ gfx/ | xargs sed -i "s/GetVisualOverflowRect/InkOverflowRect/g"
rg -l "GetPreEffectsVisualOverflowRect" layout/ gfx/ | xargs sed -i "s/GetPreEffectsVisualOverflowRect/PreEffectsInkOverflowRect/g"
rg -l "GetVisualOverflowFromDeltas" layout/ gfx/ | xargs sed -i "s/GetVisualOverflowFromDeltas/InkOverflowFromDeltas/g"
rg -l "GetScrollableOverflowRect" layout/ gfx/ | xargs sed -i "s/GetScrollableOverflowRect/ScrollableOverflowRect/g"
# Rename, drop the "Get" prefix, and change the suffix "Area" to "Rect"
# (because they return nsRect) for the two methods in nsLineBox.
rg -l "GetVisualOverflowArea" layout/ gfx/ | xargs sed -i "s/GetVisualOverflowArea/InkOverflowRect/g"
rg -l "GetScrollableOverflowArea" layout/ gfx/ | xargs sed -i "s/GetScrollableOverflowArea/ScrollableOverflowRect/g"
# Rename rest of the functions and variables.
rg -l "VisualOverflow" layout/ gfx/ | xargs sed -i "s/VisualOverflow/InkOverflow/g"
rg -l "visual overflow" layout/ gfx/ | xargs sed -i "s/visual overflow/ink overflow/g"
rg -l "visualOverflow" layout/ gfx/ | xargs sed -i "s/visualOverflow/inkOverflow/g"
rg -l "visOverflow" layout/ gfx/ | xargs sed -i "s/visOverflow/inkOverflow/g"
rg -l "vis-overflow" layout/ gfx/ python/ | xargs sed -i "s/vis-overflow/ink-overflow/g"
./mach clang-format
```
Differential Revision: https://phabricator.services.mozilla.com/D84231
2020-07-20 20:17:36 +00:00
91d759f562
Bug 1553252 - Use cbindgen for text-overflow r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D32285
--HG--
extra : moz-landing-system : lando
2019-05-24 04:48:46 +00:00
d020804eba
Backed out changeset 3304277f5bde (bug 1553252) for build bustages on Windows on a CLOSED TREE
2019-05-23 17:52:21 +03:00
4ab5380719
Bug 1553252 - Use cbindgen for text-overflow r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D32285
--HG--
extra : moz-landing-system : lando
2019-05-23 14:02:17 +00:00
f5b7d1380b
Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D20115
--HG--
extra : moz-landing-system : lando
2019-05-09 02:32:30 +00:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
e82b6edd6f
Bug 1497330: Explicitly delete TextOverflow's default constructor. r=dthayer
...
Before this patch, TextOverflow had an explicitly-*defaulted* default
constructor. But in fact, this constructor was *implicitly* deleted because one
of the member variables (of type LogicalRect) couldn't be default-constructed
due to having its own default constructor explicitly deleted.
clang trunk highlights this inconsistency with a build warning
(-Wdefaulted-function-deleted) which this patch addresses.
Differential Revision: https://phabricator.services.mozilla.com/D8028
--HG--
extra : moz-landing-system : lando
2018-10-08 20:21:52 +00:00
3241d9c80c
Bug 1489588 - Allocate TextOverflows inline r=mattwoodrow
...
Summary:
Once the nsDisplayList difficulties are sorted out, this
becomes rather trivial.
Depends on D5293
Reviewers: mattwoodrow
Reviewed By: mattwoodrow
Bug #: 1489588
Differential Revision: https://phabricator.services.mozilla.com/D5294
--HG--
extra : histedit_source : 9eae7ebf1455acae8a9ffaff90ce8f92e1e62566
2018-09-11 04:31:40 +03:00
5e3e0d4498
Bug 1453795 - Layout - Initialize member fields in classes/ structures. r=dbaron
2018-07-12 09:42:14 +03:00
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
680815cd6e
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
1c528ae1ab
Bug 1397059 - Make sure we generate unique display item keys for nsDisplayTextOverflowMarker. r=mats
2017-09-13 15:28:24 -04:00
fc581a5454
Bug 1284888 part 2: Make TextOverflow::WillProcessLines() return a UniquePtr, for stronger lifetime guarantees. r=jfkthame
...
MozReview-Commit-ID: 7KVsFlxuL9p
--HG--
extra : rebase_source : 13ee634d9a310236f70c30afa0d3c5a798a00194
2017-07-18 22:42:42 -07:00
09b0fe59f0
Bug 1284888 part 1: Annotate TextOverflow as a heap-only final class, to reflect reality. r=jfkthame
...
MozReview-Commit-ID: 9e03pevzCOc
--HG--
extra : rebase_source : 1bd889e9142390e746d1bbed3092c6108049c3f5
2017-07-18 22:36:24 -07:00
33e10acd83
Backed out 2 changesets (bug 1284888) for windows build failures in TextOverflow.h a=backout
...
Backed out changeset 520df8c2a0ac (bug 1284888)
Backed out changeset 39e9b0e7ae04 (bug 1284888)
MozReview-Commit-ID: CIzl29LVfFM
2017-07-18 20:59:51 -07:00
93add5506b
Bug 1284888 part 2: Make TextOverflow::WillProcessLines() return a UniquePtr, for stronger lifetime guarantees. r=jfkthame
...
MozReview-Commit-ID: 7KVsFlxuL9p
--HG--
extra : rebase_source : e0ee604800f456d1a0b24f7933d722fe51d15122
2017-07-18 10:48:07 -07:00
5211e242a7
Bug 1284888 part 1: Annotate TextOverflow as a heap-only final class, to reflect reality. r=jfkthame
...
MozReview-Commit-ID: 9e03pevzCOc
--HG--
extra : rebase_source : b099f11bba849f83a0eb536a7573b45d265a7b62
2017-07-18 10:47:30 -07:00
23bce99ae1
Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
...
This avoids conflicts with mozilla::dom::FrameType.
MozReview-Commit-ID: 7aEMbHRaTFk
--HG--
extra : rebase_source : 2d01321f5ce0ec8c0e3f70984674f82678034b3c
2017-05-01 19:32:52 +02:00
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
5775b65ac0
Bug 944200 part 4 - [css-ui] Use the stored float edges to narrow the block's content area to account for any floats on each line. r=dholbert
...
MozReview-Commit-ID: AFnDG8mQkiG
2017-04-15 00:31:44 +02:00
5599f9d7d7
Bug 944200 part 3 - [css-ui] Refactor the code to prepare for narrowing the content area by the float edges in the next part (idempotent patch). r=dholbert
...
MozReview-Commit-ID: 8s0ynJSmBbD
2017-04-15 00:31:44 +02:00
76e3990b88
Bug 944200 part 1 - [css-ui] Make TextOverflow::CanHaveTextOverflow not take a nsDisplayListBuilder so we can use it in Reflow; cache the value in BlockReflowInput::mCanHaveTextOverflow. r=dholbert
...
MozReview-Commit-ID: 1wGE5svg1V9
2017-04-15 00:31:43 +02:00
b15368cfcb
Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky
2016-06-07 21:10:18 +01:00
4e6c40d7ea
Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert
2015-07-16 10:07:57 +01:00
ed4f94f6c0
Bug 1157951 patch 1 - Rename fields and variables in nsCharClipDisplayItem etc using VisIStart/End instead of left/right. r=roc
2015-04-29 08:18:53 +01:00
cb03df0c0b
Bug 1117227 part 2 - Convert TextOverflow to logical coordinate. r=roc
...
--HG--
extra : source : fc021c6ca3be7dbbe30fadfbe41f9e8b69c2f6a3
2015-04-24 10:15:32 +12:00
085da9302a
Bug 1156632 - Remove unused forward class declarations - patch 5 - rdf, parser, layout and something else, r=ehsan
2015-04-22 08:29:22 +02:00
6e2b17d2de
Bug 990907 - Don't add text-overflow markers while being actively scrolled by APZ. r=mstange,tn
2015-02-25 09:33:00 -05:00
55170c430a
bug 1031241 pt 3 - Also rename Intrinsic{Width,Height} to Intrinsic{I,B}Size. r=smontagu
2014-07-24 18:03:26 +01:00
baf3a129ad
Bug 907883 - Minimize #includes in layout/generic; r=roc
...
--HG--
extra : rebase_source : 5e87b764a12b05aff477c71547e2131be67ca93b
2013-08-22 14:32:52 -04:00
51d2de9a05
bug 840431 - cache an ellipsis textrun on gfxFontGroup, to minimize perf overhead due to text-overflow. r=roc
2013-03-08 10:41:31 +00:00
b7ae90666d
Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan
2013-01-15 13:22:03 +01:00
761b11160f
Bug 792180 - Replace NS_{UN,}LIKELY with MOZ_{UN,}LIKELY; r=ehsan
2012-10-26 15:32:10 +02:00
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
c3ebc87501
Bug 748646 patch 2: Remove no-longer-needed parameter aLists from a few TextOverflow functions. r=mats
2012-07-22 23:08:24 -07:00
3232915300
Bug 748646 patch 1: Put a block's text-overflow markers in PositionedDescendants() before the rest of the block's display items. r=roc
2012-07-22 23:08:20 -07:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
c496441d30
Bug 672944 - Setup overflow areas for the scrolled block frame in a XUL scroll frame for the benefit of text-overflow; Make the text-overflow code grok the extra wrapper frame in this case. r=roc
2012-01-28 04:35:59 +01:00
0d801fb5ed
Bug 690187 - Clip or suppress a marker if it makes the line empty. r=roc
2011-12-19 15:48:31 +01:00
084e39e944
Bug 690187 - Make the edge analysis report back if text or atomic inline-level content is visible between the marker edges. r=roc
2011-12-19 15:48:31 +01:00
a330ccd83d
Bug 690187 - Use a bit on each marker to track if it's active (only text-overflow:clip means inactive for now); check the flag rather setting the clip edge at infinity to disable ellipsing on a side. r=roc
2011-12-19 15:48:30 +01:00
2db71e8621
Bug 681867. text-overflow only needs to affect the scrolling behavior of the block container with text-overflow. r=mats
2011-10-21 14:41:36 +13:00
d0304072ba
Bug 677582 - Implement CSS3 text-overflow: <left> <right> in layout. r=roc
2011-08-20 22:41:39 +02:00
e757474795
Bug 312156 - Implement CSS3 text-overflow. r=roc
2011-06-22 20:11:48 +02:00
Daniel Holbert
Emilio Cobos Álvarez
Simon Giesecke
Csoregi Natalia
Ting-Yu Lin
violet
Oana Pop Rus
Cameron McCormack
Sylvestre Ledru
Doug Thayer
Andi-Bogdan Postelnicu
Sebastian Hengst
Tristan Bourvon
Matt Woodrow
Wes Kocher
Mats Palmgren
Jonathan Watt
Jonathan Kew
Xidorn Quan
Andrea Marchesini
Kartikaya Gupta
Ehsan Akhgari
Mats Palmgren
Jacek Szpot
Aryeh Gregor
Gervase Markham
Robert O'Callahan