82c01addf1
Bug 1728769 - Use std::underlying_type_t for profile buffer enum types r=canaltinova
...
This patch replaces "custom" underlying type definitions with definitions gleaned using the std::underlying_type mechanism. This allows us to directly set the underlying type for the enums without having to name it, and reduces the number of semantically identical names in the profile buffer code.
Differential Revision: https://phabricator.services.mozilla.com/D174260
2023-04-05 13:52:29 +00:00
9d12970ac8
Bug 1818080 - [remote] Add profile markers for CDP, Marionette and WebDriver BiDi commands and events. r=webdriver-reviewers,canaltinova,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D174211
2023-03-31 12:42:44 +00:00
dd3c5bba04
Bug 1824518 - Make mozglue/linker/tests buildable outside of a unified build environment r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D173618
2023-03-30 13:48:34 +00:00
e3e0777986
Bug 1824084: use linux codepaths for BSDs in uptime-related functions r=padenot
...
should unbreak telemetry for BSDs and Solaris.
In NowExcludingSuspendMs() use CLOCK_UPTIME instead of CLOCK_MONOTONIC on
OpenBSD as this one excludes time spent suspended.
Differential Revision: https://phabricator.services.mozilla.com/D173625
2023-03-30 07:14:17 +00:00
23177bd720
Bug 1824972 [Linux] Allow to leak xdg_mime_init() as it's leaked by Gtk3 library r=emilio,decoder
...
Differential Revision: https://phabricator.services.mozilla.com/D173824
2023-03-29 06:38:01 +00:00
4efa1bd0ba
Bug 1276351 - Move away from mozilla::tuple to std::tuple. r=necko-reviewers,sergesanspaille
...
Differential Revision: https://phabricator.services.mozilla.com/D173256
2023-03-27 07:20:25 +00:00
9db345d4c1
Backed out 2 changesets (bug 1276351) for causing build bustage in image/ClippedImage.cp CLOSED TREE
...
Backed out changeset e84598eb82c1 (bug 1276351)
Backed out changeset e940b0554484 (bug 1276351)
2023-03-25 14:16:43 +02:00
447f1e3358
Bug 1276351 - Move away from mozilla::tuple to std::tuple. r=necko-reviewers,sergesanspaille
...
Differential Revision: https://phabricator.services.mozilla.com/D173256
2023-03-25 06:58:52 +00:00
6d40eee997
Backed out 2 changesets (bug 1276351) for causing multiple failures.
...
Backed out changeset eeaf4f1e06af (bug 1276351)
Backed out changeset d44cb5704342 (bug 1276351)
2023-03-25 00:08:24 +02:00
a1b827b503
Bug 1276351 - Move away from mozilla::tuple to std::tuple. r=necko-reviewers,sergesanspaille
...
Differential Revision: https://phabricator.services.mozilla.com/D173256
2023-03-24 18:55:39 +00:00
6030033461
Bug 1536901 - add breakpad id to untrusted modules ping r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D172257
2023-03-24 01:20:17 +00:00
fa5d4cca1f
Bug 1660405 - Move away from mozilla::IsFinite in favor of std::isfinite. r=sergesanspaille
...
Differential Revision: https://phabricator.services.mozilla.com/D173036
2023-03-22 11:35:33 +00:00
10f49d4180
Bug 1660405 - Move away from mozilla::IsNaN in favor of std::isnan. r=nbp,media-playback-reviewers,sergesanspaille,padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D173035
2023-03-22 11:35:33 +00:00
e31a178029
Backed out 7 changesets (bug 1660405) for causing bustages on Linux x64 opt. CLOSED TREE
...
Backed out changeset ad1a5f59214f (bug 1660405)
Backed out changeset a39e95f0aafe (bug 1660405)
Backed out changeset 48629ee0d70d (bug 1660405)
Backed out changeset 8419b99aab60 (bug 1660405)
Backed out changeset 535cc12c8bed (bug 1660405)
Backed out changeset e27052da4927 (bug 1660405)
Backed out changeset 11b0f9cf8091 (bug 1660405)
2023-03-22 13:05:53 +02:00
0b692b5a96
Bug 1660405 - Move away from mozilla::IsFinite in favor of std::isfinite. r=sergesanspaille
...
Differential Revision: https://phabricator.services.mozilla.com/D173036
2023-03-22 09:27:57 +00:00
a5d28acdd6
Bug 1660405 - Move away from mozilla::IsNaN in favor of std::isnan. r=nbp,media-playback-reviewers,sergesanspaille,padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D173035
2023-03-22 09:27:56 +00:00
ee90197d56
Bug 1805805 - Update builders to rustc 1.68. r=firefox-build-system-reviewers,andi
...
Keep the wrench android jobs on 1.67 until the NDK is upgraded in bug
1820876.
Differential Revision: https://phabricator.services.mozilla.com/D172078
2023-03-22 04:11:05 +00:00
b779c87526
Backed out changeset f1a117b31490 (bug 1805805) for causing wrench bustages on android CLOSED TREE
2023-03-21 20:27:47 -04:00
f346c8ce36
Bug 1805805 - Update builders to rustc 1.68. r=firefox-build-system-reviewers,andi
...
Differential Revision: https://phabricator.services.mozilla.com/D172078
2023-03-21 22:44:06 +00:00
ab6d98f4db
Bug 1822605: Add ThreadSanitizer suppression for race in libvulkan_lvp.so r=decoder
...
Differential Revision: https://phabricator.services.mozilla.com/D172819
2023-03-16 20:12:03 +00:00
d8ac128a8d
Backed out changeset 78e7281703a2 (bug 1788004) for causing SM failures. CLOSED TREE
2023-02-24 19:13:47 +02:00
45cce5b7c0
Bug 1788004 - Implement a hook-based fallback for BCryptGenRandom to mitigate Rust panics. r=cmartin
...
BCryptGenRandom can be broken, but the Rust stdlib and the getrandom
crate rely on it, and this is a source of crashes which are Rust
panics. This happens the most on Windows 7 after bcryptprimitives.dll
fails to load (see bug 1788004).
To mitigate these crashes, we hook BCryptGenRandom if we detect that it
is broken, and install a fallback based on RtlGenRandom. We only protect
calls that use BCRYPT_USE_SYSTEM_PREFERRED_RNG; so code that relies on
using BCryptOpenAlgorithmProvider and doesn't have its own fallback can
still fail.
We will hopefully remove this hook when the Rust stdlib and the
getrandom crate both have their own RtlGenRandom-based fallback.
Differential Revision: https://phabricator.services.mozilla.com/D170662
2023-02-24 15:47:14 +00:00
6a8f812670
Bug 1733532 - Avoid using stack buffers during calls to Thread32Next. r=gstoll
...
Thread32Next relies on NtMapViewOfSection to map the snapshot that it works with.
We hook NtMapViewOfSection, so calls to Thread32Next reach our patched_NtMapViewOfSection.
With some third-party software, this results in a crash if we use stack buffers (see bug 1733532),
because for some reason the stack cookie check code is not mapped executable. If we can avoid using
stack buffers in that case, then the third-party DLL should get its result from NtMapViewOfSection
without error.
This change thus splits patched_NtMapViewOfSection so that we only use stack buffers when necessary,
i.e. when an executable mapping is asked. Hopefully this can fix bug 1733532.
Differential Revision: https://phabricator.services.mozilla.com/D169450
2023-02-24 15:43:51 +00:00
c896734446
Bug 1779257 - Fix the stack walking for linux markers by calling getcontext in a valid stack frame r=mstange
...
See my comment on here for more context of my investigation:
https://bugzilla.mozilla.org/show_bug.cgi?id=1779257#c9
The saved context is invalid once the function that called `getcontext`
returns. We need to call the `getcontext` while the frame where we called it is
still on the stack. That's why this patch is moving the call to `getcontext` to
parent function by inlining the SyncPopulate content by using a macro instead.
This has to be a macro instead of a function because stack pointer address will
be invalid once the `Registers::SyncPopulate` returns. I tried to change this
method to inline but that didn't help either.
Differential Revision: https://phabricator.services.mozilla.com/D170133
2023-02-22 19:57:08 +00:00
479b17f2f7
Bug 1817034 - add a new Timer profiler category to use it for markers in the Timer thread, r=canaltinova.
...
Differential Revision: https://phabricator.services.mozilla.com/D169973
2023-02-17 13:11:08 +00:00
3c7629ff11
Bug 1814908 - Do not collect the marker stacks if NoMarkerStacks feature is set r=julienw,mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169112
2023-02-15 15:53:28 +00:00
a4089e0540
Bug 1814908 - Rename the noiostacks to nomarkerstacks r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D169110
2023-02-15 15:53:27 +00:00
699dd296eb
Backed out 4 changesets (bug 1814908) for causing Xpcshell failures at test_addProfilerMarker.js. CLOSED TREE
...
Backed out changeset 07252e8b15df (bug 1814908)
Backed out changeset 14f79f14b429 (bug 1814908)
Backed out changeset d9bdfd2796a8 (bug 1814908)
Backed out changeset 78e1485fe526 (bug 1814908)
2023-02-14 17:43:32 +02:00
25d320785f
Bug 1811068 - Implement the codeId for Windows r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169519
2023-02-14 14:50:57 +00:00
2dd9c867b8
Bug 1811068 - Implement the codeId for Linux r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169518
2023-02-14 14:50:57 +00:00
a746c66ac3
Bug 1811068 - Implement the codeId for macOS r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169517
2023-02-14 14:50:57 +00:00
fb46d65b02
Bug 1811068 - Fix the breakpad id bug on macOS shared libraries code r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169516
2023-02-14 14:50:56 +00:00
a224d65e3f
Bug 1811068 - Add codeId field to SharedLibrary class and output it in profile json r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169515
2023-02-14 14:50:56 +00:00
73a3af3877
Bug 1814908 - Do not collect the marker stacks if NoMarkerStacks feature is set r=julienw,mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169112
2023-02-14 14:11:42 +00:00
4fdbbc649f
Bug 1814908 - Rename the noiostacks to nomarkerstacks r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D169110
2023-02-14 14:11:42 +00:00
6e54d85e3b
Backed out 4 changesets (bug 1814908) for causing cppunit failures on TestBaseProfiler CLOSED TREE
...
Backed out changeset 4fd5e3f3d87b (bug 1814908)
Backed out changeset 6a716b16e8e3 (bug 1814908)
Backed out changeset a8557338bd74 (bug 1814908)
Backed out changeset b1a9a1820b56 (bug 1814908)
2023-02-14 14:44:31 +02:00
7952beca94
Bug 1814908 - Do not collect the marker stacks if NoMarkerStacks feature is set r=julienw,mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D169112
2023-02-14 11:42:28 +00:00
14ec874db5
Bug 1814908 - Rename the noiostacks to nomarkerstacks r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D169110
2023-02-14 11:42:27 +00:00
d7e8a09c21
Bug 1519636 - Reformat recent changes to the Google coding style. r=glandium
...
Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D168658
2023-02-13 15:02:07 +00:00
4407f46f5d
Bug 1815438 - remove the 'Preference Read' profiler feature and record these markers unconditionally, r=canaltinova.
...
Differential Revision: https://phabricator.services.mozilla.com/D169239
2023-02-10 21:50:02 +00:00
c0d7f950f7
Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova
...
Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk.
Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.
Differential Revision: https://phabricator.services.mozilla.com/D167167
2023-01-27 17:25:37 +00:00
14419ecf1f
Bug 1615546 - Remove the optimizations field from profiler frame table r=julienw
...
This requires https://github.com/firefox-devtools/profiler/pull/4432 to be
landed and deployed. We bump the profile version in this patch.
Afaik we never used the optimizations field of the frame table in the profiler
frontend and this pfield was null for more than 3 years (since Bug 1614622).
We don't have any plans to make use of it any time soon. It's good to cleanup
this field so it doesn't clutter the profile data and we can reduce the profile
data size.
Differential Revision: https://phabricator.services.mozilla.com/D167290
2023-01-24 13:18:43 +00:00
3894ab42c2
Bug 1807011 - Do not call TimeStamp::Now for text markers when profiler is not running r=julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D166804
2023-01-18 10:56:18 +00:00
8b991af173
Bug 1804226 - fma3 support for AudioNodeEngine r=padenot
...
Update xsimd dependency to integrate an fma portability patch.
Add support for fma and sse4.2 detection.
Differential Revision: https://phabricator.services.mozilla.com/D163927
2023-01-16 11:05:20 +00:00
251ada4676
Backed out 3 changesets (bug 1801557, bug 1804226) for causing Bug 1810251. a=backout
...
Backed out changeset 99419440af5c (bug 1804226)
Backed out changeset 741734906105 (bug 1801557)
Backed out changeset 6bb3ced40693 (bug 1801557)
2023-01-14 01:30:07 +02:00
23f6cd371e
Bug 1804226 - fma3 support for AudioNodeEngine r=padenot
...
Update xsimd dependency to integrate an fma portability patch.
Add support for fma and sse4.2 detection.
Differential Revision: https://phabricator.services.mozilla.com/D163927
2023-01-13 13:31:44 +00:00
8dc1a8ef3c
Backed out 3 changesets (bug 1804226, bug 1801557) for causing failures on AudioNodeEngineGeneric.h CLOSED TREE
...
Backed out changeset fc718f9cc51d (bug 1804226)
Backed out changeset 8409212faaf1 (bug 1801557)
Backed out changeset 49c08aab9622 (bug 1801557)
2023-01-10 14:16:40 +02:00
aebf685769
Bug 1804226 - fma3 support for AudioNodeEngine r=padenot
...
Update xsimd dependency to integrate an fma portability patch.
Add support for fma and sse4.2 detection.
Differential Revision: https://phabricator.services.mozilla.com/D163927
2023-01-10 10:22:34 +00:00
af7d7f81ec
Backed out 3 changesets (bug 1804226, bug 1801557) for causing build bustages on AudioNodeEngineGeneric.h CLOSED TREE
...
Backed out changeset 4615951ea4dd (bug 1804226)
Backed out changeset c401e374a769 (bug 1801557)
Backed out changeset 5d265c462faf (bug 1801557)
2023-01-05 16:32:51 -05:00
0aefae5322
Bug 1804226 - fma3 support for AudioNodeEngine r=padenot
...
Update xsimd dependency to integrate an fma portability patch.
Add support for fma and sse4.2 detection.
Differential Revision: https://phabricator.services.mozilla.com/D163927
2023-01-05 21:08:17 +00:00
Adam Brouwers-Harries
Henrik Skupin
serge-sans-paille
Landry Breuil
stransky
Andi-Bogdan Postelnicu
Sandor Molnar
Iulian Moraru
Greg Stoll
Stanca Serban
Mike Hommey
Cristian Tuns
Jason Kratzer
Cosmin Sabou
Yannis Juglaret
Nazım Can Altınova
Florian Quèze
Butkovits Atila
Norisz Fay
Andi-Bogdan Postelnicu
Kash Shampur