Nazım Can Altınova
ba374b05d5
Bug 1480496 - Add a profiler label frame to Loader::ParseSheet with the LAYOUT category r=mstange
...
MozReview-Commit-ID: CcuCs9fxTbT
--HG--
extra : rebase_source : eec3bb1c60a3fe1d724c302cfe6edfd226c8ac21
2018-08-03 13:43:57 +02:00
Emilio Cobos Álvarez
638c015ba9
Bug 1477198: Remove Document.obsoleteSheet. r=bz
...
Not used anywhere, not even comm-central or bluegriffon.
Differential Revision: https://phabricator.services.mozilla.com/D2263
MozReview-Commit-ID: LGefiaYSZjT
2018-07-29 00:34:33 +02:00
Andrea Marchesini
5fff1762ad
Bug 1418236 - Correct EventTarget for CSP violation events, r=ckerschb
2018-07-10 17:40:21 +02:00
Andrea Marchesini
14d462eeb3
Bug 1418246 - Return valid columnNumber value in CSP violation events, r=ckerschb
2018-07-05 08:21:04 +02:00
Emilio Cobos Álvarez
c7d35aa526
Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug
...
MozReview-Commit-ID: DsNuF7GAflJ
2018-06-26 18:22:06 +02:00
Emilio Cobos Álvarez
a79eb06b7c
Bug 1470420: followup: Try to fix the build in some compilers. r=me CLOSED TREE
...
MozReview-Commit-ID: Hc7LRfl16ED
2018-06-22 17:45:26 +02:00
Emilio Cobos Álvarez
e54eee09d0
Bug 1470420: Fix some minor style inconsistencies I stumbled upon. r=xidorn
...
MozReview-Commit-ID: KKnIXoQthdG
2018-06-22 17:23:02 +02:00
Emilio Cobos Álvarez
9caf38a872
Bug 1470420: Change an nsAutoPtr to UniquePtr in the Loader. r=xidorn
...
MozReview-Commit-ID: 4KnjxHOybmG
2018-06-22 17:23:01 +02:00
Emilio Cobos Álvarez
da6e9b176a
Bug 1470420: Cleanup ParseSheet. r=xidorn
...
MozReview-Commit-ID: 3RtTHSo9Z1G
2018-06-22 17:23:00 +02:00
Emilio Cobos Álvarez
79401ad550
Bug 1470420: Make Stop() infallible. r=xidorn
...
MozReview-Commit-ID: KScKUyUSkjj
2018-06-22 17:22:59 +02:00
Emilio Cobos Álvarez
c3f12726ac
Bug 1470420: Make InsertChildSheet infallible. r=xidorn
...
MozReview-Commit-ID: 4bkwzSZ2ByZ
2018-06-22 17:22:58 +02:00
Emilio Cobos Álvarez
ee59da45b2
Bug 1470358: Deduplicate sheet insertion code between document and shadow root. r=heycam
...
Summary: Sort of straight-forward cleanup.
Test Plan: Covered by existing tests.
Reviewers: heycam
Reviewed By: heycam
Bug #: 1470358
Differential Revision: https://phabricator.services.mozilla.com/D1763
2018-06-22 12:57:37 +02:00
Emilio Cobos Álvarez
c228998b4f
Bug 1410578: Make <link rel="stylesheet"> work in shadow trees. r=heycam
...
Summary: Somewhat straight-forward, mostly removing special-casing.
Differential Revision: https://phabricator.services.mozilla.com/D1761
MozReview-Commit-ID: 6f8duD4pGrl
2018-06-22 04:15:56 +02:00
Emilio Cobos Álvarez
7063be7e1b
Bug 1423895: Don't use the XUL stylesheet cache if the parsing mode doesn't match. r=bz
...
Enigmail is loading a XUL document sheet that is @import-ed in another chrome://
sheet.
Servo keys stuff off the origin of the sheet, which we derive from the parsing
mode (see mode_to_origin in glue.rs).
MozReview-Commit-ID: LQqKmxToBKC
2018-06-14 09:52:32 -07:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Boris Zbarsky
9748db120d
Bug 1455676 part 8. Remove nsIDOMNode usage from layout/. r=qdot
2018-05-29 22:58:48 -04:00
Emilio Cobos Álvarez
cb56e2c9f3
Bug 1459529: Remove UPDATE_STYLE. r=heycam
...
Now that BeginUpdate is useless for the UPDATE_STYLE case, we don't need the
update mechanism at all. Just ensure that ApplicableStylesChanged is called on
the pres shell via the relevant RuleChanged, etc. notifications.
There's a big hidden gotcha here. nsIDocument::BeginUpdate does put a script
blocker on the stack for these updates. However it's not needed, since no script
can run during these notifications (only the stylesheet events we post for
devtools, but those use AsyncEventDispatcher and PostDOMEvents, so they don't
try to run immediately).
nsIDocument::BeginUpdate also does XBL binding attached queue stuff, but we
can't change bindings during these notifications anyway, so it also doesn't
matter.
MozReview-Commit-ID: HJvK6zQfloh
2018-05-15 18:44:29 +02:00
Emilio Cobos Álvarez
2054320f28
Bug 1459529: Make sheets be associated to a shadow root too potentially. r=bz
...
MozReview-Commit-ID: Cd8xJuLRY5w
2018-05-15 18:44:25 +02:00
Emilio Cobos Álvarez
6bb8b0c814
Bug 1459498: Make SheetLoadData constructor take enums instead of booleans. rs=heycam
...
MozReview-Commit-ID: H6QF4NQemAx
2018-05-08 10:09:41 +02:00
Emilio Cobos Álvarez
9509853a38
Bug 1459498: Rename nsIStyleSheetLinkingElement::StyleSheetInfo to SheetInfo. r=heycam
...
MozReview-Commit-ID: FeOmISAxWBk
2018-05-08 10:07:46 +02:00
Emilio Cobos Álvarez
786abfd0cc
Bug 1459498: Remove a useless QI. r=heycam
...
MozReview-Commit-ID: FD74BpQvMih
2018-05-08 10:07:45 +02:00
Emilio Cobos Álvarez
c8b98b398b
Bug 1459498: Remove useless CreateSheet arguments. r=heycam
...
This is one of the most important steps for bug 1459498. After this I can use
StyleSheetInfo to compute IsAlternate. Still all the preferred stylesheet stuff
is crazy...
MozReview-Commit-ID: 9ZHW9AYGoBe
2018-05-08 10:07:44 +02:00
Emilio Cobos Álvarez
91b6cb40dc
Bug 1459498: Use StyleSheetInfo more. r=heycam
...
Not as much as I'd like, because we have all the internal loads and child
sheets, but...
MozReview-Commit-ID: 7402w8vxCel
2018-05-08 10:07:43 +02:00
Emilio Cobos Álvarez
5b6f2bdee0
Bug 1459498: Refactor nsStyleLinkElement so that all the stylesheet information comes from one place. r=heycam
...
I've kept the nsAutoStrings in the StyleSheetInfo class on the hopes that the
compiler does RVO, but if it doesn't I can remove I guess.
MozReview-Commit-ID: 2vN6BSEhYcw
2018-05-08 10:07:41 +02:00
Chris Peterson
71422dcaa9
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez
d6f7b1d2f5
Bug 1459497: Refactor the preferred style set stuff in order to move the state away from the loader. r=heycam
...
The main thing to have into account is that the styleset to use is either
mLastStyleSheetSet, or mPreferredStyleSheetSet.
This last one gets set from Loader::IsAlternateSheet, which is quite nasty and
what I'm trying to remove.
MozReview-Commit-ID: BI4P1Chqtli
2018-05-07 03:55:36 +02:00
Emilio Cobos Álvarez
9b13f54912
Bug 1457920: Loader::ParseSheet is not really fallible. r=xidorn
...
MozReview-Commit-ID: IexX1RRCuF4
2018-05-02 04:13:34 +02:00
Emilio Cobos Álvarez
a62beaa09b
Bug 1457920: Cleanup a useless argument in Loader. r=xidorn
...
MozReview-Commit-ID: HajaHl6JEV8
2018-05-02 04:13:32 +02:00
Emilio Cobos Álvarez
c556ec7ad0
Bug 1457920: Remove ServoStyleSheet usage. r=xidorn
...
MozReview-Commit-ID: LIBkovuQ6MB
2018-05-02 04:13:26 +02:00
Emilio Cobos Álvarez
bf64474d79
Bug 1457920: Remove StyleSheet::AsServo. r=xidorn
...
MozReview-Commit-ID: IkkJvUFHykk
2018-05-02 04:13:21 +02:00
Emilio Cobos Álvarez
8239c1300e
Bug 1386840: Defer loading and don't block rendering for non-matching stylesheets. r=bz,heycam
...
MozReview-Commit-ID: 24UJZDooGmn
2018-04-26 16:44:03 +02:00
Emilio Cobos Álvarez
31aff796a0
Bug 1456435: Make the loader a bit less outparam-happy. r=heycam
...
Returning the same type and UpdateStyleSheet.
This hopefully helps seeing how the data flows between the methods, instead of
the messy bits we had before.
MozReview-Commit-ID: C6THNRi8bbg
2018-04-26 16:43:58 +02:00
Emilio Cobos Álvarez
5618bcfb59
Bug 1456435: Less bool outparam in Loader too. r=heycam
...
MozReview-Commit-ID: D5A2BxwHGjn
2018-04-26 16:43:54 +02:00
Emilio Cobos Álvarez
a00f507b72
Bug 1456435: Make UpdateStyleSheet less bool-happy. r=heycam
...
MozReview-Commit-ID: FlTD390lMhg
2018-04-26 16:43:52 +02:00
Emilio Cobos Álvarez
f8233b4454
Bug 1456471: Remove nsCSSParser.h. r=xidorn
...
MozReview-Commit-ID: 4qa7llzCXeR
2018-04-25 10:38:37 +02:00
Emilio Cobos Álvarez
f790d1c4cb
Bug 1455492: While here, fix refcount churn. r=bholley
...
MozReview-Commit-ID: 88jzsn25e53
2018-04-21 12:08:44 +02:00
Emilio Cobos Álvarez
1c74b688f7
Bug 1455492: Remove redundant ParseSheet arguments. r=bholley
...
For the async caller, pretty much everything can be extracted out of the loader
/ loadData.
For the sync callers, we need to be a bit more careful because ReparseSheet
tries to get its line number on its own.
I changed the compat mode passed to the reparse stuff to be the document's one
in this case, but that seems a bug fix.
MozReview-Commit-ID: 2wi5HPRAlPi
2018-04-21 12:08:44 +02:00
Bobby Holley
3f98737f56
Bug 1454460 - Hoist SRI helper into Loader.cpp. r=bz
...
MozReview-Commit-ID: 2wgVAJDgHDl
2018-04-17 16:27:09 -07:00
Bobby Holley
9cff749db5
Bug 1454460 - Pass a bonafide nsACString to Servo. r=bz
...
This will allow the Rust code hold a copy-free strong reference to the string
past callstack unwind.
MozReview-Commit-ID: HCop9h2abZU
2018-04-17 16:27:08 -07:00
Bobby Holley
055086766b
Bug 1454460 - Buffer the potentially-BOM-related bytes separately and handle them on the fly. r=bz
...
MozReview-Commit-ID: 5zrKyadBppO
2018-04-17 16:27:08 -07:00
Christoph Kerschbaumer
a929955d1f
Bug 1439713 - Change nsIContentPolicy shouldLoad to take an <uri, loadInfo> pair instead of the various args. r=bz
2018-03-29 12:16:23 +02:00
Xidorn Quan
3b8cc6c6ef
Bug 1447828 part 4 - Remove StyleBackendType uses from Loader. r=emilio
...
MozReview-Commit-ID: 8DbjibZE3Dw
--HG--
extra : rebase_source : aa664ee40199b5358e304e076c8d6853e496d7a8
extra : source : 06be08613cf88b6963033929ff5ac0d82a6327b1
2018-03-29 02:33:01 +11:00
Xidorn Quan
1cf8082e67
Bug 1447828 part 3 - Remove StyleBackendType uses from MediaList. r=emilio
...
MozReview-Commit-ID: 9sG73iLeBw4
--HG--
extra : rebase_source : a2626f6d1f8af02caeb7f3d37b7d258b4544b62d
extra : source : 2f443463446897080b85ac0da5b7a9ea6ccc9de2
2018-03-29 02:31:46 +11:00
Xidorn Quan
d9cb92544e
Bug 1447828 part 2 - Remove StyleBackendType uses from nsXULPrototypeCache. r=emilio
...
MozReview-Commit-ID: 1tYFBTk9BqF
--HG--
extra : rebase_source : 72c783c84ff36fddd6d49e79e7912f42bb0c11a8
extra : source : 4972e279ef76127e4898874478fcbd75c9631d76
2018-03-29 02:31:23 +11:00
Jonathan Watt
4570211dcc
Bug 1449565 - Remove the aGeckoParentRule parameter from css::Loader's InsertChildSheet and LoadChildSheet. r=emilio
...
--HG--
extra : source : c31de7e26809522daca72a6050cd3ab665e8f6ff
2018-03-23 17:02:35 +00:00
Jonathan Watt
68e78b291f
Bug 1449321 - Remove the IsServo and IsGecko methods from the style system code. r=emilio
...
--HG--
extra : source : 763277b299e42d8ee7eafede027ee690b66a7a2a
2018-03-23 16:01:34 +00:00
Henri Sivonen
eaa2f6b46b
Bug 1395114 - Remove nsIUnicharStreamLoader. r=emilio,michal
...
MozReview-Commit-ID: ECKNnJt80oK
--HG--
extra : rebase_source : 6f09937e0648c65d035dfb4935d6e9a06d0223df
2018-03-26 12:45:31 +03:00
Emilio Cobos Álvarez
f7522ae728
Bug 1447358: Unifdef the old style system code. r=jwatt
...
Summary:
This has been automatically generated using:
http://dotat.at/prog/unifdef/
And:
find $OBJDIR -type f -name '*.h' |
while read FILE; do
echo "$FILE"
unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done
find $OBJDIR -type f -name '*.cpp' |
while read FILE; do
echo "$FILE"
unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done
MozReview-Commit-ID: I4NdKqbMXzJ
Reviewers: jwatt
Bug #: 1447358
Differential Revision: https://phabricator.services.mozilla.com/D779
2018-03-21 10:20:34 +01:00
Emilio Cobos Álvarez
de099db7bd
Bug 1444905: Remove scoped style support from the old style system. r=xidorn,smaug
...
Summary: It uses two node bits that can be better suited for something else.
Reviewers: xidorn, smaug
Bug #: 1444905
Differential Revision: https://phabricator.services.mozilla.com/D709
MozReview-Commit-ID: HIPDtHm6xpM
2018-03-13 10:26:13 +01:00
Boris Zbarsky
826d1e3167
Bug 1443344. Flag a parent sheet load as failed if an import is blocked by content policy. r=bholley
...
MozReview-Commit-ID: AArgnuHbCYL
2018-03-06 14:45:27 -05:00