The follow issues are fixed:
- Returning a failure result when failing to get a pref value instead of more
gracefully falling back to a default.
- Using an enum instead of a more strongly typed enum class.
- Using a pref branch instead of the preferred Preferences.h API.
- Manual memory management.
- Unnecessary use of pointers.
MozReview-Commit-ID: FKw5kBhnwxL
--HG--
extra : transplant_source : %21K%E2%83/%A5%AB%DB3%F4%FB%2CUD%9E%B6l%1C%3A%22
After bug 1258657 landed, summary element is rendered by nsBlockFrame,
so it supports css columns for free.
MozReview-Commit-ID: 2RPSYk81BHy
--HG--
extra : rebase_source : 9b8e2be476319d938cfd06e876c68a18f8995bce
Turn on the pref at once instead of duplicating the line in every single
tests.
MozReview-Commit-ID: L8cf2mVxfF1
--HG--
extra : rebase_source : 7992753cd178dc652fa76b2fa3d4877e4104b0eb
Use chromeScript and message manager to fetch state of prompt and dismiss it. Enable tests in E10S.
MozReview-Commit-ID: 5M9GYijlQPV
--HG--
extra : rebase_source : 244c8abd7e23d464f8f0cbe883dd41fecbd1d070
Move state/action objects out of handleDialog, into main runTest() body.
MozReview-Commit-ID: 1250sb8N5sT
--HG--
extra : rebase_source : 1d825baf000359c127707e0f1c77d1465f257788
Make expected-state object independent from ui object.
MozReview-Commit-ID: 547tN5kSyDt
--HG--
extra : rebase_source : fd30b56983e4d7f7236c66be4ff075fca714b6e8
Move all expected-ui state checks into state object.
MozReview-Commit-ID: AKV0z4G3R7d
--HG--
extra : rebase_source : f9842066a0ad5dde957e1084cdbe3d858b34ea56
Move all actions to be performed on a prompt (e.g. clicking a button, checking a checkbox) into an "action" object.
MozReview-Commit-ID: 8KSGmezOGZZ
--HG--
extra : rebase_source : 8daded4813871ecc8deea2c5543f6c4f52a45542
The format provided to the build system by the manifest parser is highly redundant:
every test lists all variables for that test, and many tests use a large
support-files entry in DEFAULT that ends up in individual test objects. This
patch stores these DEFAULTS per-manifest rather than per-test to save disk
space, resulting in about a ~22mb smaller all-tests.json file. The
in-memory representation of tests is not changed by this patch, as the defaults
are again propagated to individual tests as all-tests.json is read by the test
resolver.
MozReview-Commit-ID: CEJaevfS5s7
There are no callers of these methods in mozilla-central, and having
them in the vtable of nsIFrame (and its 100+ subclasses!) consumes
needless space.
We have inconclusive evidence that compartmentStats is sometimes nullptr during
memory reporting, which would be bad. This patch makes us abort in that case.
It also changes some pointers to references to make the expected non-nullness
clearer.
--HG--
extra : rebase_source : c49f727450ce065d0e84d7728057c93d35353e91
Jeff Walden
ABE Hiroki (hATrayflood)
Valentin Gosu
Jean-Yves Avenard
Michal Novotny
Kartikaya Gupta
Charles Collicutt
Cykesiopka
Carsten "Tomcat" Book
Andrew McCreight
Ting-Yu Lin
Mats Palmgren
Jan Beich
Tom Schuster
Marcos Caceres
Randell Jesup
Morgan Phillips
Justin Dolske
Chris Manchester
Myk Melez
Nathan Froyd
Ben Kelly
Nicholas Nethercote
Wes Kocher
Jonas Sicking