Граф коммитов

178 Коммитов

Автор SHA1 Сообщение Дата
Valentin Gosu a3a123bcf3 Bug 1667975 - Don't check rcode before parsing packet r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92040
2020-10-01 10:05:03 +00:00
Sebastian Hengst a34f36ddbd Backed out 2 changesets (bug 1652677) on request from kershaw for causing bug 1667801
Backed out changeset 4a66e4016c18 (bug 1652677)
Backed out changeset df6bdf8157b1 (bug 1652677)
2020-09-30 13:14:00 +02:00
Kershaw Chang 93e628b4ae Bug 1652677 - P2: Implement necko part of echconfig r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D89455
2020-09-25 07:35:04 +00:00
Kershaw Chang 0ec383b700 Bug 1652677 - P1: Prefer to use records with ECH config r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D89454
2020-09-24 19:33:15 +00:00
Razvan Maries e761feff33 Backed out 2 changesets (bug 1652677) for build bustages on nsHttpConnection.cpp. CLOSED TREE
Backed out changeset 7df7bfbfbc6e (bug 1652677)
Backed out changeset 435ff20fa8c6 (bug 1652677)
2020-09-24 22:01:09 +03:00
Kershaw Chang d12fbcdc43 Bug 1652677 - P2: Implement necko part of echconfig r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D89455
2020-09-24 16:20:04 +00:00
Kershaw Chang bd99e0b590 Bug 1652677 - P1: Prefer to use records with ECH config r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D89454
2020-09-24 14:29:56 +00:00
Simon Giesecke de7bab0f06 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Valentin Gosu d8fa63f024 Bug 1666249 - Save canonical name when lookup with DNS-over-HTTPS enabled r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D90979
2020-09-23 09:29:50 +00:00
Butkovits Atila 499dcd036b Backed out 2 changesets (bug 1666711, bug 1666249) for causing failures at test_trr_additional_section.js. CLOSED TREE
Backed out changeset a802f1c429bc (bug 1666711)
Backed out changeset da73031913b7 (bug 1666249)
2020-09-23 11:49:14 +03:00
Valentin Gosu df16132ad7 Bug 1666249 - Save canonical name when lookup with DNS-over-HTTPS enabled r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D90979
2020-09-23 07:56:23 +00:00
Csoregi Natalia 3efe04d48a Backed out 2 changesets (bug 1666249) for failures on test_trr_nat64.js. CLOSED TREE
Backed out changeset cc8915693d90 (bug 1666249)
Backed out changeset 42106e84c23a (bug 1666249)
2020-09-22 23:30:13 +03:00
Valentin Gosu 22d869c8ba Bug 1666249 - Save canonical name when lookup with DNS-over-HTTPS enabled r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D90979
2020-09-22 16:32:46 +00:00
Valentin Gosu ea223460f7 Bug 1665979 - Make sure we call MaybeRenewHostRecord when adding additional record r=kershaw,necko-reviewers
If we don't, the record may already be on the eviction queue, meaning
we try to remove it twice.

Differential Revision: https://phabricator.services.mozilla.com/D90787
2020-09-21 07:09:05 +00:00
Valentin Gosu 07362aeaa4 Bug 1663657 - Turn IsIpAddr* functions into NetAddr methods r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D89552
2020-09-15 10:39:56 +00:00
Valentin Gosu 7de4c8009c Bug 1525854 - TRR shouldn't fallback to DNS on DNSSEC error r=necko-reviewers,dragana
This patch adds support for the Extended DNS Errors draft code.
https://datatracker.ietf.org/doc/html/draft-ietf-dnsop-extended-error-16

While not yet in the draft, it seems the OPT code for Extended DNS Error is 15
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-11

The list of errors for which we hard fail isn't necessarily final.
I picked the errors that indicate a DNSSec failure, or an intentional
filtering done by the resolver.

Differential Revision: https://phabricator.services.mozilla.com/D87698
2020-09-15 10:39:07 +00:00
Valentin Gosu 8fac241692 Bug 1660970 - Get rid of DoHAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D88121
2020-09-15 10:38:41 +00:00
Valentin Gosu 3e2712a46b Bug 1645108 - Parse additional section of TRR response r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87088
2020-09-15 10:38:27 +00:00
Razvan Maries c8e604eb78 Backed out 4 changesets (bug 1660970, bug 1525854, bug 1663657, bug 1645108) for perma failures on test_trr_additional_section.js. CLOSED TREE
Backed out changeset ad6c2e8af09b (bug 1663657)
Backed out changeset 419e26e3f452 (bug 1525854)
Backed out changeset 55bf856faf33 (bug 1660970)
Backed out changeset c543a3a008fa (bug 1645108)
2020-09-15 02:35:05 +03:00
Valentin Gosu 6d149e6e7a Bug 1663657 - Turn IsIpAddr* functions into NetAddr methods r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D89552
2020-09-14 12:06:27 +00:00
Valentin Gosu 26af33d4cc Bug 1525854 - TRR shouldn't fallback to DNS on DNSSEC error r=necko-reviewers,dragana
This patch adds support for the Extended DNS Errors draft code.
https://datatracker.ietf.org/doc/html/draft-ietf-dnsop-extended-error-16

While not yet in the draft, it seems the OPT code for Extended DNS Error is 15
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-11

The list of errors for which we hard fail isn't necessarily final.
I picked the errors that indicate a DNSSec failure, or an intentional
filtering done by the resolver.

Differential Revision: https://phabricator.services.mozilla.com/D87698
2020-09-14 21:42:02 +00:00
Valentin Gosu 438128d0d4 Bug 1660970 - Get rid of DoHAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D88121
2020-09-14 21:42:02 +00:00
Valentin Gosu 6051d814c2 Bug 1645108 - Parse additional section of TRR response r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87088
2020-09-14 21:41:44 +00:00
Kershaw Chang 361fe2d82b Bug 1652670 - P2: Make nsSocketTransport use IP hint address to connect r=valentin,dragana
Differential Revision: https://phabricator.services.mozilla.com/D88988
2020-09-14 14:47:36 +00:00
Kershaw Chang 1ed2ff578d Bug 1652670 - P1: Use IP hint addresses as regular A/AAAA records r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D88780
2020-09-14 14:47:29 +00:00
Valentin Gosu 0cf5f5e5ac Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-09-01 07:22:14 +00:00
Valentin Gosu 934d895d74 Bug 1659132 - Get rid of NetAddrElement. Make mAddresses an array r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87090
2020-09-01 07:38:03 +00:00
Valentin Gosu 8e8a6ed3eb Bug 1660975 - Move some TRR prefs to StaticPrefList.yaml r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D88123
2020-08-31 12:49:59 +00:00
Valentin Gosu 836481e674 Bug 1659699 - HTTPSSVC: Special handling of "." in TargetName r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D88286
2020-08-28 09:22:12 +00:00
Butkovits Atila cdf1ae5211 Backed out 2 changesets (bug 1659132) for failures at browser_cleanFlow.js. CLOSED TREE
Backed out changeset 7952fd59f59b (bug 1659132)
Backed out changeset fa8ce4af10a0 (bug 1659132)
2020-08-25 13:02:33 +03:00
Valentin Gosu b4b3279a00 Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-08-25 08:02:22 +00:00
Valentin Gosu 240eeaae88 Bug 1659132 - Get rid of NetAddrElement. Make mAddresses an array r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87090
2020-08-25 08:01:36 +00:00
Butkovits Atila 73a14f1b36 Backed out 2 changesets (bug 1659132) for build bustage. CLOSED TREE
Backed out changeset 1caace74f89e (bug 1659132)
Backed out changeset 58fdbfbe05a1 (bug 1659132)
2020-08-25 09:43:01 +03:00
Valentin Gosu ec0be3efef Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-08-24 12:23:06 +00:00
Valentin Gosu 125efe18dd Bug 1659132 - Get rid of NetAddrElement. Make mAddresses an array r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87090
2020-08-24 11:38:01 +00:00
Kershaw Chang 2e10bf25d7 Bug 1652655 - P1: Sort HTTPSSVC records, r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D85121
2020-08-21 18:59:03 +00:00
Valentin Gosu c61967c799 Bug 1652106 - Add support for the mandatory SvcParamKey r=kershaw,necko-reviewers
6.5 A ServiceMode RR is considered "compatible" with a client if the
client implements support for all its mandatory keys.  If the SVCB
RRSet contains no compatible RRs, the client will generally act as if
the RRSet is empty.

Differential Revision: https://phabricator.services.mozilla.com/D85838
2020-08-05 13:40:33 +00:00
Valentin Gosu 098b049d81 Bug 1652106 - Reject RR if SvcParamKeys are not in strictly increasing numeric order r=kershaw,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D85837
2020-08-05 13:57:06 +00:00
Valentin Gosu 6680c6fb12 Bug 1652106 - Rename esniconfig to echconfig and add HTTPS RR type r=kershaw,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D85836
2020-08-05 13:39:53 +00:00
Frederik Braun a7153982e8 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
Valentin Gosu 0475d7a7ba Bug 1650356 - Call IsExcludedFromTRR in TRR::SendHTTPRequest r=dragana,necko-reviewers
Since IsTemporarilyBlocked no longer calls IsExcludedFromTRR we have to do
this explicitly at this call site.

Differential Revision: https://phabricator.services.mozilla.com/D82221
2020-07-11 19:32:57 +00:00
Valentin Gosu 0606ff0236 Bug 1650356 - Rename TRR Blacklist to TRR blocklist r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82219
2020-07-11 19:32:27 +00:00
Valentin Gosu 4106c61ff1 Bug 1649143 - Record telemetry with reason we fell back to Do53 r=dragana,necko-reviewers
This patch attempts to record the reason why we fall back to DNS.
I considered using categorical probes for this, but they have a max limit of
20 categories, so we have to use a linear probe. I chose 50 buckets to allow
us to add more failure reasons in the future.

The recorded values are defined in nsHostRecord::TRRSkippedReason.
nsHostRecord::RecordReason is called whenever we encounter a condition that
will cause us to skip TRR in nsHostResolver.

For failures that occur inside TRR.cpp, each TRR object holds its own reason
that is recorded in a similar way. When all TRR requests are complete we
report the one that failed (or if both failed we report the one for the A
request).

Due to the fact that we might also follow CNAME requests, and the final
TRR request might not be the one that was issued at first, TRR requests
must pass back the reason as an argument to CompleteLookup.

Finally, this patch records the reason in two probes:
TRR_SKIP_REASON_TRR_FIRST - only reported in TRR-first mode
TRR_SKIP_REASON_DNS_WORKED - only reported in TRR-first mode when the
  fallback DNS request succeeded. This allows us to filter for complete
  network failures.

Differential Revision: https://phabricator.services.mozilla.com/D82168
2020-07-11 19:32:05 +00:00
Valentin Gosu 9b25e934ea Bug 1649127 - Make sure we only set AddrHostRecord::mTRRUsed = true when TRRServiceChannel::AsyncOpen succeeds r=dragana,necko-reviewers
mTRRUsed is a variable that we check to gate several telemetry probes, and to
decide if TRR really failed and we should add a domain to the TRR blocklist.
The problem with setting this too early is that when this is true but we
don't actually send the TRR request, then we will report that we fell back
to Do53 and potentially skip next TRR requests in the future.

The solution here is to only set mTRRUsed if TRRServiceChannel::AsyncOpen
succeeds.

Differential Revision: https://phabricator.services.mozilla.com/D81517
2020-07-07 10:08:28 +00:00
Razvan Maries 9da7f3cb73 Backed out 2 changesets (bug 1649127) for perma failures on test_trr.js. CLOSED TREE
Backed out changeset d967c48fa147 (bug 1649127)
Backed out changeset 17e5b3f78f03 (bug 1649127)
2020-07-04 18:30:54 +03:00
Valentin Gosu a38929f26f Bug 1649127 - Make sure we only set AddrHostRecord::mTRRUsed = true when TRRServiceChannel::AsyncOpen succeeds r=dragana,necko-reviewers
mTRRUsed is a variable that we check to gate several telemetry probes, and to
decide if TRR really failed and we should add a domain to the TRR blocklist.
The problem with setting this too early is that when this is true but we
don't actually send the TRR request, then we will report that we fell back
to Do53 and potentially skip next TRR requests in the future.

The solution here is to only set mTRRUsed if TRRServiceChannel::AsyncOpen
succeeds.

Differential Revision: https://phabricator.services.mozilla.com/D81517
2020-07-04 13:08:15 +00:00
Mihai Alexandru Michis e587ecf789 Backed out changeset 16ff0a677ab2 (bug 1649127) for causing failures in nsHostResolver.cpp
CLOSED TREE
2020-07-04 00:01:32 +03:00
Valentin Gosu 2d46993c30 Bug 1649127 - Make sure we only set AddrHostRecord::mTRRUsed = true when TRRServiceChannel::AsyncOpen succeeds r=dragana,necko-reviewers
mTRRUsed is a variable that we check to gate several telemetry probes, and to
decide if TRR really failed and we should add a domain to the TRR blocklist.
The problem with setting this too early is that when this is true but we
don't actually send the TRR request, then we will report that we fell back
to Do53 and potentially skip next TRR requests in the future.

The solution here is to only set mTRRUsed if TRRServiceChannel::AsyncOpen
succeeds.

Differential Revision: https://phabricator.services.mozilla.com/D81517
2020-07-03 09:17:44 +00:00
Valentin Gosu c5c364d39b Bug 1649417 - Don't perform unnecessary DoH CNAME requests r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D81721
2020-07-01 12:34:15 +00:00
Valentin Gosu 6e82d17bea Bug 1649401 - Remove unused mStartTime r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D81673
2020-07-01 12:34:56 +00:00