0eb1f2ca26
Bug 1349203 - Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint. r=mossop
...
MozReview-Commit-ID: C1oB0pQ3fev
--HG--
extra : rebase_source : 93e63db48f815e173b80611ae592806e4ef43fae
2017-03-21 14:50:45 +01:00
a54eda04ca
Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
...
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
62f6c37109
merge mozilla-inbound to mozilla-central a=merge
2017-03-22 14:26:27 +01:00
c225eb9884
Bug 1347712 - Add the tree-wide rules and config to the recommended eslint-plugin-mozilla config, to make it easier for outside projects. r=jaws
...
MozReview-Commit-ID: K7X57ZNppkE
--HG--
extra : rebase_source : 697cdbcbbc732a7ae5b538112f3c603943e86692
2017-03-21 15:40:33 +01:00
d7d8be9285
Bug 1347712 - Move toolkit/.eslintrc.js rules into a 'recommended' set within eslint-plugin-mozilla. r=jaws
...
MozReview-Commit-ID: Jy4apKnmWcV
--HG--
rename : toolkit/.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
extra : rebase_source : ae0c740c1c2a9cf620c1ac34024622ade12e6fd4
2017-03-22 10:43:00 +01:00
d4822994da
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - structural changes. r=jaws
...
MozReview-Commit-ID: HmNYrVyNiMr
--HG--
rename : testing/mochitest/browser.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/browser-test.js
rename : testing/mochitest/chrome.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/chrome-test.js
rename : testing/mochitest/mochitest.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/mochitest-test.js
rename : testing/xpcshell/xpcshell.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/xpcshell-test.js
extra : rebase_source : 21380c13600e54e5fe86ef2d85518272b8a75de6
2017-03-21 16:43:01 +01:00
df122d5bfa
Bug 1340584 - Remove devicemanagerSUT and references to sutagent; r=wlach
...
sutagent is no longer built or used; devicemanagerSUT is completely
unused. After this change, devicemanagerADB is the only implementation of
devicemanager, and test harness options like --dm_trans are eliminated.
2017-03-21 12:20:01 -06:00
644825e657
Bug 1344932 - Separate out the ESLint spidermonkey preprocessor to avoid breaking './mach eslint --fix' on the whole tree.' r=jryans
...
This doesn't allow --fix to run on the whole tree in one go, but does allow it to be run on individual directories. This
is due to an ESLint issue, where once the processor is loaded, it applies to the rest of the files.
MozReview-Commit-ID: Fqg5yK22Dhu
--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/.eslintrc.js => tools/lint/eslint/.eslintrc.js
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/processors/self-hosted.js => tools/lint/eslint/eslint-plugin-spidermonkey-js/lib/processors/self-hosted.js
extra : rebase_source : 9913f929985016f4a22ff78641051dc025df14f2
2017-03-19 18:35:17 +00:00
be00c3b9e8
Bug 1345294 - add an eslint rule to reject usage of {get,set}ComplexValue for nsISupportsString and suggest {get,set}StringPref instead, and make it pass, r=Mossop.
2017-03-16 19:26:02 +01:00
2ce3d7d34a
Bug 1347947 - Move static checking browser mochitests to their own folder, r=Gijs.
...
--HG--
rename : browser/base/content/test/general/browser_misused_characters_in_strings.js => browser/base/content/test/static/browser_misused_characters_in_strings.js
rename : browser/base/content/test/general/browser_parsable_css.js => browser/base/content/test/static/browser_parsable_css.js
rename : browser/base/content/test/general/browser_parsable_script.js => browser/base/content/test/static/browser_parsable_script.js
rename : browser/base/content/test/general/bug1262648_string_with_newlines.dtd => browser/base/content/test/static/bug1262648_string_with_newlines.dtd
rename : browser/base/content/test/general/dummy_page.html => browser/base/content/test/static/dummy_page.html
rename : browser/base/content/test/general/parsingTestHelpers.jsm => browser/base/content/test/static/head.js
2017-03-16 19:26:01 +01:00
efcef12931
Backed out changeset e73241bcb49a (bug 1340584) for Windows build failures a=backout CLOSED TREE
...
MozReview-Commit-ID: 22csfCgl7Wb
2017-03-16 10:25:15 -07:00
ecc9668072
Bug 1340584 - Remove devicemanagerSUT and references to sutagent; r=wlach
...
sutagent is no longer built or usedr; devicemanagerSUT is completely
unused. After this change, devicemanagerADB is the only implementation of
devicemanager, and the --dmTrans and similar options have been removed
from test harnesses and mach commands.
2017-03-16 10:44:44 -06:00
9500176490
Bug 1346167 - Make the eslint-plugin-mozilla environments more flexible for when they are used outside of mozilla-central. r=mossop
...
For now, we return virtually no globals for browser-window/places-overlay/simpletest as they aren't able to load the m-c files. Later we may want to find a way of enabling this to work for outside repositories.
MozReview-Commit-ID: 8SFVuQuEqfL
--HG--
extra : rebase_source : ff773796d14ef27b47f25b0b8503ae3f093bfb9e
2017-03-10 11:44:35 +00:00
15bd196ab5
Bug 1346014: Update the minimum required version of node to 6.9.1. r=jaws
...
MozReview-Commit-ID: Ex0HiKWHfwK
--HG--
extra : rebase_source : 2af12fc6b9c4153ed1b3c6d5b46ecda68c478dc2
2017-03-09 13:57:20 -08:00
5420828c24
Bug 1314405 - Provide a readme for eslint-plugin-mozilla, and add some more details to its package.json. r=mossop
...
MozReview-Commit-ID: DdzWwWEFvf6
--HG--
extra : rebase_source : 6d1825b1007b56cd99567b46e735740ac0414757
2017-03-09 11:45:04 +00:00
9d62681259
Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws.
2017-03-08 10:17:52 +01:00
e2b53c13ce
Bug 1344711 - Add an eslint rule to report an error when a get*Pref call is the only instruction in a try block, r=jaws.
...
--HG--
extra : rebase_source : b98fc9c75089c3eeb2f1317623b08ee9cd4d1541
2017-03-07 15:29:47 +01:00
087da3f0d9
merge mozilla-inbound to mozilla-central a=merge
2017-03-07 15:13:31 +01:00
9ac2a16551
Bug 1332651 - Enabled python code linting in Telemetry. r=Dexter
...
Enabled python code linting in Telemetry and created a new .flake8 file in
toolkit/components/telemetry.
2017-03-03 23:47:04 +05:30
100766fec4
Bug 1335877 - Remove resource://services-common/stringbundle.js from gecko. r=gandalf
...
MozReview-Commit-ID: FNoj7XH71E4
--HG--
extra : rebase_source : 294d3e425ca60e2aac6149998da7f39f62864ae5
2017-03-06 09:39:52 -08:00
1bc7720a43
Backed out changeset 0bd17b868a31 (bug 1335877) for causing regression bug 1344760
2017-03-06 17:03:11 +01:00
7d5e6f23c5
Bug 1344027 - Move eslint-plugin-mozilla's .eslintrc.js file so that all of the plugin is linted, and fix the resulting issues. r=mossop
...
MozReview-Commit-ID: POYhxkeOaw
--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/.eslintrc.js
extra : rebase_source : efd9a97796e72e94c436df6f4223a12d6daa036a
2017-03-03 10:17:54 +00:00
8796160b00
Bug 1344027 - Add a places-overlay environment for ESLint for when placesOverlay.xul is included. r=mossop
...
MozReview-Commit-ID: 3uoneyJdEmx
--HG--
extra : rebase_source : 4c09327246e3c490c0fa30fd792c04b53d6b142e
2017-03-03 09:25:31 +00:00
800c6a4602
Bug 1344027 - Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences. r=mossop
...
MozReview-Commit-ID: BERAbtYkxsF
--HG--
extra : rebase_source : e319699651a8d33db026d7697ccaddd2d1e4e2d3
2017-02-22 10:19:11 +00:00
4b7b3d4092
Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman
...
MozReview-Commit-ID: M7V6JS5myy
--HG--
extra : rebase_source : a47d739d3dd67ce563088aaf9fab5421de376cd7
2017-03-02 15:26:53 -08:00
9b6693b8ee
Bug 1317223 (part 5) - a bookmark repair responder. r=kitcambridge
...
This is the "repair responder" - it handles a "repairRequest" command sent
by another client and attempts to take the list of IDs that client lists as
missing and upload whatever records are necessary such that the requesting
client would then be likely to find a complete and valid tree on the server.
MozReview-Commit-ID: 4xw19nH6EfL
2017-02-28 15:34:37 +11:00
8c4e55d022
Bug 1317223 (part 3) - a bookmark repair requestor. r=markh,tcsc
...
The bookmark repair requestor takes the validation results and possibly
initiates a bookmark repair.
MozReview-Commit-ID: 7rRNbBx8Vo3
2017-03-02 19:21:53 +11:00
de20e8f357
Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r=tcsc
...
This patch defines the concept of a "doctor" for collections. The doctor is
responsible for running all validators and deciding whether or not to initiate
a repair request based on the validation results.
MozReview-Commit-ID: 6NLRE6L0OpA
2017-03-02 17:14:31 +11:00
fdeace22db
Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman
...
This creates a collection_repair module, somewhat analogous to the existing
collection_validator module. This defines the public interface to request a
new repair and respond to a remote repair request, and also includes changes
to clients.js to call this public interface.
MozReview-Commit-ID: 9JPpRrLgFoR
2017-03-02 16:14:51 +11:00
e43ef8d772
Bug 1343519 - Bump the version number for eslint-plugin-mozilla for the changes. r=bustage-fix-for-developers a=tomcat
...
MozReview-Commit-ID: EIykbh2t5mv
2017-03-02 00:26:00 +01:00
23b7396105
Bug 1343519 - Change the ESLint browser-window environment to determine most of the scripts for globals by parsing global-scripts.inc. r=mossop
...
MozReview-Commit-ID: 6rxN3ORgItH
--HG--
extra : rebase_source : 100ddf6c09f229baa2334d11211c6fb28d643c3b
2017-03-01 21:44:45 +00:00
fb13a772a1
Bug 1343519 - Change the ESLint rule 'import-test-globals' to be an environment (mozilla/simpletest) to better describe the purpose of it. r=mossop
...
MozReview-Commit-ID: DbrsnUVrAas
--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-test-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/environments/simpletest.js
extra : rebase_source : 97d0537c347999159c82d4757b265f580ec981eb
2017-03-01 21:34:24 +00:00
09889d3184
Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
...
MozReview-Commit-ID: FTDV8BcMGeF
--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
extra : rebase_source : f0e89f2ce3cfdf343213f66a007f74a80a785c19
2017-03-01 21:29:52 +00:00
c23e14f565
Bug 1343519 - Change some function calls from using 'this' to 'context' in the eslint-plugin-mozilla code so that it works correctly when timing rule lengths. r=mossop
...
MozReview-Commit-ID: Dzjnhtu9bml
--HG--
extra : rebase_source : 16746dab5a46fd447329ca381ef44fc854695af0
2017-03-01 21:05:01 +00:00
f5150ddf41
Bug 1340146 - Part 2: Process js/src/shell JavaScript files as self-hosted in eslint plugin. r=evilpie
2017-02-27 09:55:21 -08:00
dbf209197e
Backed out 2 changesets (bug 1340146) for spidermonkey bustage a=backout
...
Backed out changeset 5556b171034e (bug 1340146)
Backed out changeset c355a0ffcb10 (bug 1340146)
MozReview-Commit-ID: JTVSUcenPdC
2017-02-27 15:28:34 -08:00
a8358b9891
Bug 1340146 - Process js/src/shell JavaScript files as self-hosted in eslint plugin. r=evilpie
...
--HG--
extra : rebase_source : c34e54150dafbab3f6422b1beb0689b9ced87608
2017-02-27 09:55:21 -08:00
c1b9e3db78
Bug 1341029 - Add more 'globals' for browserjs equivalent imports, and for test imports. r=mossop
...
MozReview-Commit-ID: Iy0rSOivsGQ
--HG--
extra : rebase_source : ba1f7583624d0b28591a6c7b54ec218bdbd0a40a
2017-02-08 09:41:30 +00:00
8e621b659c
Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
...
MozReview-Commit-ID: D53xoTa0PZu
--HG--
extra : rebase_source : a4aa143c627df0f70c15fd3589cde7a49e30d80d
2016-12-11 14:37:22 -10:00
733f0b7c97
Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals. r=mossop
...
MozReview-Commit-ID: Fcin4InbLK2
--HG--
extra : rebase_source : f94dbb2e5af83bb4d32c51a55702e6f58cc25323
2017-02-07 10:52:06 +00:00
0240235e36
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: 2KYT7x0b6I1
2017-02-15 19:17:03 -08:00
8f2ba061cd
Backed out changeset 63d0ef447e81 (bug 1224528) for Android permaorange in test_blocklist_certificates.js
2017-02-15 19:07:26 -08:00
3797956aa6
Merge m-c to inbound a=merge
...
MozReview-Commit-ID: BemR756HJnR
2017-02-15 16:33:03 -08:00
31c56b8f1f
Bug 1280572 - Add layout/tools/reftest to flake8 linter r=ahal
...
MozReview-Commit-ID: Cqllz9BeV7X
--HG--
extra : rebase_source : 862709bfe8600a0761467cc79cfa9dadb4e66e62
2017-02-15 01:20:56 +05:30
d28d6df424
Bug 1338249 - Improve eslint-plugin-mozilla's handling of workers when dealing with globals and imports. r=mossop
...
MozReview-Commit-ID: 7UdgstbYNlB
--HG--
extra : rebase_source : 63005f09ce96135ea239db2de7bcffa924ae03ef
2017-02-07 11:14:49 +00:00
82d2407ee9
No bug - Follow-up to fix eslint 'max-len' failure.
...
MozReview-Commit-ID: AoyUSqODG3b
--HG--
extra : rebase_source : 68b24cda681f6479758d65c47a321cbfd5169bab
2017-02-14 23:11:53 +08:00
60e157bd14
Bug 1300989 - Part 1: Fill the autofill profile that the user selects from autocomplete; r=MattN
...
MozReview-Commit-ID: 5oMgvdO5RD1
--HG--
extra : rebase_source : 629a34ec404f9c426857172644b4ae8003ac1b70
extra : histedit_source : 1aeddb96261a8da9058fe65412e8ba9944f93fb2
2017-01-07 09:22:19 +08:00
870ef630b6
Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
...
MozReview-Commit-ID: D53xoTa0PZu
--HG--
extra : rebase_source : 48481994fc4aa6afcd7ef46ac62861fc1ad6b281
2016-12-11 14:37:22 -10:00
433f1f5ec7
Backed out changeset 03bfb1ccd33f (bug 1338249) for test failures in test_loading.xul
2017-02-15 15:24:32 +01:00
cd234e0642
Bug 1338249 - Improve eslint-plugin-mozilla's handling of workers when dealing with globals and imports. r=mossop
...
MozReview-Commit-ID: 7UdgstbYNlB
--HG--
extra : rebase_source : e8eb9718da9bf378b293aca5211c53dd063d4f7a
2017-02-07 11:14:49 +00:00
Mark Banner
Jared Wein
Carsten "Tomcat" Book
Geoff Brown
Florian Quèze
Wes Kocher
Dave Townsend
djmdev
Zibi Braniecki
Mark Hammond
André Bargull
Mathieu Leplatre
Phil Ringnalda
Deepa
Matthew Noorenberghe
Sean Lee