This patch adds the initial set of documentation that will be added to the source-docs website.
Differential Revision: https://phabricator.services.mozilla.com/D60241
--HG--
extra : moz-landing-system : lando
This patch adds the PerfDocs Generator. Some modificiations to `run_perfdocs` were also made because verification always has to occur before the documentation generation, and generation always has to be run after verification (if verification passes).
Differential Revision: https://phabricator.services.mozilla.com/D57111
--HG--
extra : moz-landing-system : lando
This patch adds a function to get an exported function in a remote process.
We need this implementation to address Bug 1604008, Bug 1608645, and Bug 1610790.
When `WindowsDllInterceptor` detours a function in a remote process, we used the
native `GetProcAddress` locally, and then detours the returned address in the
target process. The problem is if the caller's export table was modified, the
address returned from `GetProcAddress` might be invalid in the target process,
which is Bug 1604008.
I implemented `GetProcAddress` depending on both local and remote process image,
but it caused two regressions Bug 1608645 and Bug 1610790 because multiple
applications modify firefox's export table in multiple ways, such as replacing
an entry of EAT, replacing an RVA to Export section, or etc.
With this patch, we can use `PEExportSection<MMPolicy>::GetProcAddress` to get
an exported function in a remote process without relying on any local data so
that it's not impacted by modification of the local export table.
Differential Revision: https://phabricator.services.mozilla.com//D62315
Depends on D62314
The tools repo is no longer used, so remove the references to the path where it
was checked out.
Differential Revision: https://phabricator.services.mozilla.com/D62404
--HG--
extra : moz-landing-system : lando
In automation, `GECKO_PATH` always refers to the source directory, so use that in mozharness
rather than assuming it is somewhere relative to `work_dir`.
Differential Revision: https://phabricator.services.mozilla.com/D62403
--HG--
extra : moz-landing-system : lando
The original code hard-coded the path of the source directory. Instead, use the
actual source directory.
Differential Revision: https://phabricator.services.mozilla.com/D62368
--HG--
extra : moz-landing-system : lando
This patch adds a function to get an exported function in a remote process.
We need this implementation to address Bug 1604008, Bug 1608645, and Bug 1610790.
When `WindowsDllInterceptor` detours a function in a remote process, we used the
native `GetProcAddress` locally, and then detours the returned address in the
target process. The problem is if the caller's export table was modified, the
address returned from `GetProcAddress` might be invalid in the target process,
which is Bug 1604008.
I implemented `GetProcAddress` depending on both local and remote process image,
but it caused two regressions Bug 1608645 and Bug 1610790 because multiple
applications modify firefox's export table in multiple ways, such as replacing
an entry of EAT, replacing an RVA to Export section, or etc.
With this patch, we can use `PEExportSection<MMPolicy>::GetProcAddress` to get
an exported function in a remote process without relying on any local data so
that it's not impacted by modification of the local export table.
Differential Revision: https://phabricator.services.mozilla.com/D62315
Depends on D62314
--HG--
extra : rebase_source : 3088f5997a2097ef22ce8567783375e5f7866ab2
Tweak the ShapeSourceRepresentation so that it doesn't store Option<>s.
Some renames so that GeometryBox doesn't conflict with the Gecko type, and some
other usual bits / re-exports to deal with cbindgen and generics.
Also, drive-by derive parsing of GeometryBox as it's trivial.
Doing this unfortunately is not possible without removing nsStyleImage first, so
let's do that before.
This makes us serialize in the shortest form for shape-outside, but that's what
we should do anyway.
(aside: the shapes code is a bit too generic, maybe we should unify
ClippingShape and FloatAreaShape...)
Differential Revision: https://phabricator.services.mozilla.com/D62163
--HG--
extra : moz-landing-system : lando
Raptor was previously generating two artifacts for the `run-visual-metrics.py`
script to consume: `jobs.json` and `application.json`. These artifacts have
been merged.
Differential Revision: https://phabricator.services.mozilla.com/D62363
--HG--
extra : moz-landing-system : lando
The `run-visual-metrics.py` script was intended to consume a `jobs.json` file
containing one `browsertime.json` per video. However it was not being used as
such and was continuously re-processing the first video specified in the
`browsertime.json` file. If a job were submitted with a `browsertime.json`
containing 15 videos and 15 different videos, only the first would be
processed. This leads to us having incorrect metrics because over all runs all
the metrics will be identical.
Now we only specify the `browsertime.json` in the `jobs.json` file and extract
the paths to videos from there. Also because we are never downloading inputs
this way, we get to remove some dead code and our dependency on `requests`.
Differential Revision: https://phabricator.services.mozilla.com/D62320
--HG--
extra : moz-landing-system : lando
Convert back slashes to forward slashes in manifest keys used for the manifests.list
and the suite_start message.
Differential Revision: https://phabricator.services.mozilla.com/D62450
--HG--
extra : moz-landing-system : lando
With this patch, we now remove all blank lines from the profiles we produce which cause Browsertime 8 to break.
Differential Revision: https://phabricator.services.mozilla.com/D62370
--HG--
extra : moz-landing-system : lando
intern() has to take a str in Python 2 and 3 (i.e bytes in the former and
unicode in the latter). A recent upstream change changed url_base to unicode
which revealed there was one place we forgot to call ensure_str when interning
in the wpt metadata update code. This was blocking the sync.
Differential Revision: https://phabricator.services.mozilla.com/D62064
Automatic update from web-platform-tests
[TableNG] Fix minor colspan percentage redistribution bug
Legacy code was not enforcing 2 invariants of colspan
redistribution.
- min_width <= max_width
- redistribution should never shrink width.
The fix introduces a part of new colspan redistribution
test suite.
Bug: 958381
Change-Id: I3cc6e55af86dd376ffbc0a4c4710900df8bccce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030805
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738062}
--
wpt-commits: aede77a55588790eca722d2fe5ee948a9f20e216
wpt-pr: 21534
Automatic update from web-platform-tests
Restore pull_request_previews.yml to use secrets.DEPLOY_TOKEN (#21561)
As per https://github.com/web-platform-tests/wpt/pull/21560, the
re-launch of pull_request_previews.yml appears to work using my personal
access token. Switching it back to use DEPLOY_TOKEN to see if that
works.
--
wpt-commits: aa4c61f655811a1a6b2e70c3b5377fb4e34b1aa9
wpt-pr: 21561
Automatic update from web-platform-tests
Re-land pull_request_previews.yml workflow (#21558)
This attempts to re-land the pull_request_previews.yml workflow, to
create deployments for wptpr.live. This was previously reverted because
it was not properly triggering the dependent deployment workflow. I've
tested it on my local fork of wpt with my personal token and can't
reproduce the failure (i.e. it is working), so I'm landing this again to
see if it works now.
This reverts commit 462f3c4680dc9d4c5dd4740742947cd16d6fc1df. I've
changed two main things:
* Use my personal token temporarily, to mimic the local setup.
* Only deploy one PR, to avoid spamming.
--
wpt-commits: 5bfe66a9068ede4f0228ace529c3bc7b1a54c202
wpt-pr: 21558
Automatic update from web-platform-tests
Update chromium log formatter to handle known_intermittent. (#21517)
Update chromium log formatter to handle known_intermittent.
It will combine the expected status and anything in known_intermittent
into a space-separated list of statuses which are output into the
"expected" field in the chromium log.
--
wpt-commits: 9a559c43f8c4469af284d460f89b295eae4edc9b
wpt-pr: 21517
Automatic update from web-platform-tests
Remove instance of 'whitelist' in css/css-pseudo
As per https://whatwg.org/style-guide
--
wpt-commits: 1703644cf1da595b6926d1f6007c17121720a5b3
wpt-pr: 21319
Automatic update from web-platform-tests
[Security] Fix WPTs that are wrong or with undeterministic failure output
This fixes three tests:
- blob-popup.https.html checked for a random string to be empty,
which makes test expectations unreliable, use length instead.
- coop-navigated-popup.https.html had a failure in the cleanup, trying
to use a non-existent object. This change defines the broadcast channel
beforehand and uses the proper variable name.
- historical/coep-navigate-popup-unsafe-inherit.https.html had an
invalid expectation that navigating a popup from a COOP: same-origin
document to a COOP: unsafe-none document should not create a new
browsing context group.
Bug: 922191
Change-Id: Ife24aee4369a3a25bbff32a2fe5e8c29abb2d468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030902
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737734}
--
wpt-commits: b49a11955de10ebff809462df4b54d5609b41fb9
wpt-pr: 21547
Automatic update from web-platform-tests
Block the XML parser on parser blocking stylesheets.
The html spec talks about script blocking stylesheets[1], but we do
script blocking in body by pausing the html parser. The APIs for doing
that for the XML parser had empty implementations which meant that
querying style from a script after an external stylesheet resource would
not wait for the stylesheet to load.
[1] https://html.spec.whatwg.org/multipage/semantics.html#interactions-of-styling-and-scripting
Bug: 1043944, 917116
Change-Id: I08422fa0608db8972154a8b19854906e154dfdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012021
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737721}
--
wpt-commits: 220c6b1d4bd084c1835cf274f3ed5f8dd8468fea
wpt-pr: 21335
Andrei Oprea
alexandru.ionescu
Toshihito Kikuchi
Tom Prince
Cosmin Sabou
Florin Strugariu
Emilio Cobos Álvarez
Barret Rennie
Ehsan Akhgari
Christoph Kerschbaumer
Mark Banner
Geoff Brown
Tarek Ziadé
J.C. Jones
Brindusan Cristian
Sebastian Hengst
Gregory Mierzwinski
John Dai
moz-wptsync-bot
James Graham
Sergio
Frédéric Wang
Anne van Kesteren
Aleks Totic
Klaus Weidner
Stephen McGruer
Luke Zielinski
autofoolip
Pâris MEULEMAN
Rune Lillesveen