We can directly return `JS::Value` from InterpretObjLiteralValue instead of passing
it indirectly through a `MutableHandleValue`.
Depends on D65771
Differential Revision: https://phabricator.services.mozilla.com/D65772
--HG--
extra : moz-landing-system : lando
The standard convention is to omit a `is<T>` test when it is directly followed
by `as<T>`, because `as<T>` is also testing for `is<T>`.
Depends on D65768
Differential Revision: https://phabricator.services.mozilla.com/D65769
--HG--
extra : moz-landing-system : lando
The preceding `JSOp::{Object,NewObject,NewObjectWithGroup,NewArrayCopyOnWrite}`
opcode already performs the correct stack depth adjustment.
Differential Revision: https://phabricator.services.mozilla.com/D65768
--HG--
extra : moz-landing-system : lando
Cherry-picking the following commits from Chromium to keep file_version_info_win.cpp
up-to-date.
1. Use StringPiece rather than std::string for Version parsing.
15a9d1733f
2. [Cleanup] Un-const the result of base::Version::GetString()
fde745d058
3. Export Windows file version as base::Version
e93de3a37d
4. Tidy FileVersionInfoWin.
4bb23ded3a
Differential Revision: https://phabricator.services.mozilla.com/D65802
Depends on D65744
This patch partially implements `FileVersionInfoWin` and `base::FilePath` class of
Chromium sandbox so that a coming patch can use `base::win::OSInfo::Kernel32BaseVersion()`.
Differential Revision: https://phabricator.services.mozilla.com/D65744
N_STACK_BYTES are needed to store backtrace information, so use
that plus some extra as the minimum stack size for the sampler
thread to ensure that it doesn't overflow.
Differential Revision: https://phabricator.services.mozilla.com/D65705
--HG--
extra : moz-landing-system : lando
Callers should pass in UTF-8, since that's what the JS engine ends up with in the end anyway.
The various URL changes are because NS_NewURI converts incoming nsAString to
UTF-8 anyway. So we might as well do that up-front and then use the UTF-8
string for both the NS_NewURI call and the error-reporting if it fails.
Differential Revision: https://phabricator.services.mozilla.com/D65543
--HG--
extra : moz-landing-system : lando
CStringArrayAppender is just a copy of StringArrayAppender with the incoming
types expanded to accept both wide and narrow strings. Later patches will
remove the wide-string variants incrementally.
Differential Revision: https://phabricator.services.mozilla.com/D65537
--HG--
extra : moz-landing-system : lando
Instead of something like
"ByteStringSequenceSequenceOrByteStringByteStringRecord" we should have
"(sequence<sequence<ByteString>> or record<ByteString, Bytestring>)" in error
messages.
Please take a careful look at the resulting error messages (see attachment
in the bug) to see whether this makes sense.
Differential Revision: https://phabricator.services.mozilla.com/D64890
--HG--
extra : moz-landing-system : lando
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").
Differential Revision: https://phabricator.services.mozilla.com/D64887
--HG--
extra : moz-landing-system : lando
We basically need this because some of the type conversions those guts need to
do may need a BindingCallContext.
We could probably do more optimization here to only generate the
BindingCallContext bits if we will really need them, more or less based on our
return type. But for now that doesn't seem worthwhile.
Differential Revision: https://phabricator.services.mozilla.com/D64886
--HG--
extra : moz-landing-system : lando
Dictionaries always need a BindingCallContext, because they can throw
MSG_NOT_DICTIONARY from Init().
We allow non-binding callsites to pass JSContext*, in which case they will not
get quite-as-nice error reporting.
Differential Revision: https://phabricator.services.mozilla.com/D64885
--HG--
extra : moz-landing-system : lando
We instantiate this class in various binding methods. Future patches will make
use of it to throw errors.
Differential Revision: https://phabricator.services.mozilla.com/D64883
--HG--
extra : moz-landing-system : lando
This does not change behavior at the moment, because the only callers of
ThrowErrorMessage that pass an error number that has a context pass an empty
string for the first (context) arg. Both of those callers are changed to pass
nullptr for the context in this patch.
We want to support nullptr to mean "empty context", because that way at
callsites we can avoid having extra empty strings.
We could avoid putting this machinery in place if we hardcoded the trailing
": " at all the callsites, but that would reduce future flexibility in where the
context is placed in the message string (e.g. if we wanted to move it to the
end instead of the beginning) and increase the amount of string data we have to
cart around in the binary quite noticeably: we have a _lot_ of places in
bindings where we call ThrowErrorMessage.
Differential Revision: https://phabricator.services.mozilla.com/D64882
--HG--
extra : moz-landing-system : lando
IgnoredErrorResult works well as the auto suppressor class and it's
cleaner.
Differential Revision: https://phabricator.services.mozilla.com/D65810
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Add tests for input and change events on checkboxes and radios
This follows @domenic's suggestion in https://github.com/whatwg/html/issues/5291
--
wpt-commits: 78f14c537b62447d64aeb65a30ede77c5d26db41
wpt-pr: 22075
Automatic update from web-platform-tests
Sync on style when creating a pseudo-element animation from script
Sync on style before evaluating a pseudo-element selector other than null.
Remove manual style syncs from pseudo-element animation wpt tests.
Bug: 1057101
Change-Id: I8a1184221f40c7546ac5179615f0d6541e8729e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083715
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747333}
--
wpt-commits: b15e954c41e6d98122ea8e4b4515bb6c6e43cf62
wpt-pr: 22048
Automatic update from web-platform-tests
[Trusted Types] Gate eval on require-tt-for.
Also, tidy up enforcement headers in WPTs, update one.
Bug: 1058437
Change-Id: Ic24b0297af04230562b104fd6664387cba5b169b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089772
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747320}
--
wpt-commits: 261dd95ad3bf4b36b971fe4832dc2f313c491448
wpt-pr: 22102
Automatic update from web-platform-tests
Pointer Event Capture is not lost when using chorded buttons.
Add web test for the bug.
Add check in HandleMouseReleaseEvent to release mouse capture only when all the mouse buttons are released.
Bug: 1053385
Change-Id: Id327f67c915b79673e80b1c97d3e6975a3488d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071292
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747291}
--
wpt-commits: 0b243d36ce54f38a58edbea54a51eb0d6940a12a
wpt-pr: 21970
André Bargull
Timothy Nikkel
Boris Zbarsky
Scott
Jan-Ivar Bruaroey
Toshihito Kikuchi
Tom Prince
Arthur Iakab
Michael Forney
Agi Sferro
Punam Dahiya
Mark Striemer
Emma Malysz
Jeff Walden
Boris Chiou
Noemi Erli
moz-wptsync-bot
Joey Arhar
George Steel
Stefano Sanfilippo
Liviu Tinta
Krzysztof Kotowicz