We need to recognize IPDL errors in order to return the proper error status when the right PluginScriptableObject could not be found.
Differential Revision: https://phabricator.services.mozilla.com/D15469
--HG--
extra : moz-landing-system : lando
The `GEOLOCATION_REQUEST_GRANTED` probe was renewed in Bug #1494496 to support targeting for a survey project that I originally expected to launch in November. Thanks to the usual vagaries of IRBs, holidays, and other priorities, we haven't launched yet, and the probe expiry is configured to stop collecting in 65. To mitigate the risk of failing to deploy the survey before the targeting probe expires, I'd like to bump the probe expiration out another couple of releases and uplift to beta.
I think we're actually ready to launch now so I'm confident another 12 weeks will be more than enough time and we won't have to repeat this exercise again.
I expect the data review in Bug #1494496 provides coverage for this change.
Differential Revision: https://phabricator.services.mozilla.com/D16211
--HG--
extra : moz-landing-system : lando
This allows us to centralize the logic about which field names are "sensitive" and shouldn't be saved in things like form history or session history.
Differential Revision: https://phabricator.services.mozilla.com/D16128
--HG--
extra : moz-landing-system : lando
In 1404608, the OS was revealed in both the HTTP User-Agent
header and to JavaScript code via navigator.userAgent. To avoid
leaking the OS inside each HTTP request (which many web servers
log), always use the Windows 7 OS value in the desktop User-Agent
header. We continue to allow access to the actual OS via JavaScript,
since doing so improves compatibility with web applications such
as GitHub and Google Docs.
This is an uplift of Tor's 26146
Avoid resetting volume in every AudioSink restart to stop unexpected volume change during play/pause and seek. Volume changes could occur if the volume has been modified outside firefox (for example pavucontrol in Linux).
Differential Revision: https://phabricator.services.mozilla.com/D15210
--HG--
extra : moz-landing-system : lando
The patch updates the Marionette client and all Marionette unit
tests to make use of the new `Create Window` command as much as
possible.
Depends on D13663
Differential Revision: https://phabricator.services.mozilla.com/D13664
--HG--
extra : moz-landing-system : lando
By default PollPromise has to behave similar to a normal Promise
and wait forever until it gets resolved or rejected.
Depends on D13662
Differential Revision: https://phabricator.services.mozilla.com/D15907
--HG--
extra : moz-landing-system : lando
To be closer to other test harnesses which are using executeSoon()
to run a task on the main thread, this patch adds the same
method to Marionette's sync module.
Differential Revision: https://phabricator.services.mozilla.com/D13659
--HG--
extra : moz-landing-system : lando
Previously we assumed that the path for the lsan_suppressions.txt file was the same as the prefs path,
which is correct in CI but wrong for local builds. This adds a --lsan-dir command line argument and sets
it in mach to the correct value for local builds and uses the prefs directory as a default for backwards
compatibility
Differential Revision: https://phabricator.services.mozilla.com/D16024
--HG--
extra : moz-landing-system : lando
Chrome synthesizes mousemove event and related events (mouseover, mouseenter,
etc) when context menu event is fired by long tap. This allows users to open
submenu which is opened by moving mouse cursor over a link.
So, this fix improves accessibility of our users on some websites which are
designed for desktop.
Differential Revision: https://phabricator.services.mozilla.com/D14857
--HG--
extra : moz-landing-system : lando
This patch makes ContentIteratorBase, PostContentIterator, PreContentIterator
and ContentSubtreeIterator classes non-refcountable because most users can
create their instances in stack and such users may be in a hot path. So,
we can save a lot of cost of instantiation.
Unfortunately, only ScriptableContentIterator creates one of the concrete
classes and needs to destroy it properly. Therefore, its
EnsureContentIterator(), destructor, traverse and unlink code becomes messy.
However, ScriptableContentIterator was designed for automated tests and we
need to maintain it not so many times. Therefore, improvement of other
users must be worthwhiler than this demerit.
Differential Revision: https://phabricator.services.mozilla.com/D15928
--HG--
extra : moz-landing-system : lando
Now, nobody requires nsIContentIterator interface. So, we can get rid of it.
Unfortunately, there is no macro to keep the inherited class,
ContentSubtreeIterator, in the cycle collection to make it keep managing
ContentSubtreeIterator::mRange without nsISupports interface. Therefore, this
patch moves it into ContentIteratorBase temporarily. Anyway, the following
patch makes those classes not refcountable. At that time, this issue will be
fixed.
Differential Revision: https://phabricator.services.mozilla.com/D15927
--HG--
extra : moz-landing-system : lando
nsFilteredContentIterator is used only by TextServicesDocument and there is
no reason that it should be derived from nsIContentIterator except consistency.
Additionally, it's now only class which is derived from nsIContentIterator
except ContentIteratorBase. So, after this change, we can get rid of
nsIContentIterator completely.
This patch moves nsFilteredContentIterator into mozilla namespace and
makes TextServicesDocument treat FilteredContentIterator directly instead of
nsIContentIterator interface.
Differential Revision: https://phabricator.services.mozilla.com/D15925
--HG--
rename : editor/spellchecker/nsFilteredContentIterator.cpp => editor/spellchecker/FilteredContentIterator.cpp
rename : editor/spellchecker/nsFilteredContentIterator.h => editor/spellchecker/FilteredContentIterator.h
extra : moz-landing-system : lando
Now, all users of PostContentIterator can access it directly. This patch
makes them use the concrete class directly.
Differential Revision: https://phabricator.services.mozilla.com/D15923
--HG--
extra : moz-landing-system : lando
Now, all users of PreContentIterator can access it directly. This patch makes
them use the concrete class directly.
Differential Revision: https://phabricator.services.mozilla.com/D15922
--HG--
extra : moz-landing-system : lando
Now, all users of ContentSubtreeIterator can access it directly. This patch
makes them use the concrete class directly.
Differential Revision: https://phabricator.services.mozilla.com/D15920
--HG--
extra : moz-landing-system : lando
Currently, ContentIterator is created with a bool flag to decide whether the
instance lists up post-order or pre-order. However, this is not clear. For
example:
nsCOMPtr<nsIContentIterator> preOrderIter = new ContentIterator(false);
This is not clear whether this does right thing or not.
This patch makes any users can create PostContentIterator for post-order
iterator, and creates PreContentIterator for pre-order iterator. So, now,
each creator needs to writhe above as:
nsCOMPtr<nsIContentIterator> preOrderIter = new PreContentIterator();
or
nsCOMPtr<nsIContentIterator> postOrderIter = new PostContentIterator();
Additionally, with this change, if each user starts to use concrete classes
directly, compiler can stop using virtual calls because of all concrete
classes are now marked as "final".
Differential Revision: https://phabricator.services.mozilla.com/D15918
--HG--
extra : moz-landing-system : lando
David Parks
Jeff Muizelaar
Andrew McCreight
Tim D. Smith
Luca Greco
Cosmin Sabou
Matthew Noorenberghe
Vlad Baicu
André Bargull
Olli Pettay
Bogdan Tara
Kartikaya Gupta
Jon Coppeard
Tom Ritter
Kestrel
Alex Chronopoulos
Henri Sivonen
Oriol Brufau
Henrik Skupin
James Graham
Csoregi Natalia
Masayuki Nakano
Ehsan Akhgari