Dorel Luca
03794edd6e
Merge autoland to mozilla-central. a=merge
2020-07-31 12:45:12 +03:00
Morgan Reschenberg
b788945f30
Bug 1652809: Create search class for querying rotor elements r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D83672
2020-07-30 22:17:41 +00:00
Eitan Isaacson
80f99b2bcb
Bug 1654603 - Support text entry in contenteditable nested nodes. r=morgan
...
VoiceOver expects text value change events to originate from the editable ancestor.
Differential Revision: https://phabricator.services.mozilla.com/D85050
2020-07-27 22:20:06 +00:00
Eitan Isaacson
1c1c047771
Bug 1655779 - Check that range is valid before getting its string. r=MarcoZ
...
Differential Revision: https://phabricator.services.mozilla.com/D85179
2020-07-28 16:02:20 +00:00
Eitan Isaacson
70a126786a
Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-27 21:08:20 +00:00
Mihai Alexandru Michis
13e26846d7
Backed out changeset 47667fbae734 (bug 1654679) for causing failures in browser_text_input.js
2020-07-24 03:16:52 +03:00
Eitan Isaacson
fd819b55c1
Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-23 21:31:35 +00:00
Dorel Luca
784df221cc
Backed out changeset 8848caa5b125 (bug 1654679) for Browser-chrome failures in accessible/tests/browser/mac/browser_text_input.js. CLOSED TREE
2020-07-23 20:44:22 +03:00
Eitan Isaacson
c4c117984b
Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-23 16:29:19 +00:00
Bogdan Tara
c61d07ee89
Backed out changeset 290c72f07e0c (bug 1654679) for es lint failure on browser_text_input.js CLOSED TREE
2020-07-23 09:05:54 +03:00
Eitan Isaacson
089db2c536
Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-23 04:52:00 +00:00
Eitan Isaacson
6233e4868e
Bug 1654601 - Ensure given text marker is valid in public API. r=MarcoZ
...
Differential Revision: https://phabricator.services.mozilla.com/D84567
2020-07-22 18:08:10 +00:00
Eitan Isaacson
8216f98213
Bug 1653421 - Part 5: Add xpc mac event interface so we can include data. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84057
2020-07-21 23:03:02 +00:00
Eitan Isaacson
42dcf89b84
Bug 1653421 - Part 4: Pass data with text value change events. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84056
2020-07-21 23:03:00 +00:00
Eitan Isaacson
1d2bd5cd78
Bug 1653421 - Part 3: Don't normalize marker beyond editable root. r=morgan
...
When in an editable container, text markers are expected to not go past or before the editable root.
Differential Revision: https://phabricator.services.mozilla.com/D84055
2020-07-21 23:02:57 +00:00
Eitan Isaacson
c52b49a014
Bug 1653421 - Part 2: Add attributed string for range getter. r=morgan
...
This doesn't actually add any attributes yet.
VoiceOver uses this instead of the plain string equivalent.
Differential Revision: https://phabricator.services.mozilla.com/D84054
2020-07-21 23:02:55 +00:00
Eitan Isaacson
66653fbad1
Bug 1653421 - Part 1: Refactor AccessibleWrap event handling. r=morgan
...
I split the switch statement into two: the first switch determines the
MOX target accessible. The second one does all the rest. This makes it more
readable and scalable when we add more events that need to be accompanied with
data.
Differential Revision: https://phabricator.services.mozilla.com/D84053
2020-07-21 23:02:53 +00:00
Morgan Reschenberg
a707c0c636
Bug 1643765: Add moxUnignoredChildren getter to MOXAccessibleBase r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D80983
2020-07-21 20:41:55 +00:00
Eitan Isaacson
cfcad506f6
Bug 1628236 - Add cell getter and column headers attribute to tables. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84249
2020-07-21 20:58:36 +00:00
Dorel Luca
560f272fda
Backed out changeset a83d85107142 (bug 1628236) for OSX build bustage on mozTableAccessible.h. CLOSED TREE
2020-07-21 22:49:30 +03:00
Eitan Isaacson
a024bafebe
Bug 1628236 - Add cell getter and column headers attribute to tables. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D84249
2020-07-21 16:43:28 +00:00
Eitan Isaacson
906483c74e
Bug 1653039 - Add word at marker APIs. r=morgan
...
This patch adds several new parameters:
* AXLeftWordTextMarkerRangeForTextMarker
* AXRightWordTextMarkerRangeForTextMarker
* AXStartTextMarkerForTextMarkerRange
* AXEndTextMarkerForTextMarkerRange
* AXNextTextMarkerForTextMarker
* AXPreviousTextMarkerForTextMarker
Our word boundaries API is pretty buggy. Instead of trying to
resolve or triage each issue I found, I added todo tests
for them.
Differential Revision: https://phabricator.services.mozilla.com/D83680
2020-07-20 22:53:04 +00:00
Bogdan Tara
92d6c2f06f
Backed out changeset 8d3a31f6fcd6 (bug 1643765) by morgan's request CLOSED TREE
2020-07-08 19:57:22 +03:00
Morgan Reschenberg
22c2b06956
Bug 1643765: Add moxUnignoredChildren getter to MOXAccessibleBase r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D80983
2020-07-06 19:24:19 +00:00
Razvan Maries
3b7f8e576f
Backed out changeset e7c1f66e9ff4 (bug 1643765) for build bustages on MOXAccessibleProtocol.h. CLOSED TREE
2020-07-06 21:02:44 +03:00
Morgan Reschenberg
1a49e563e3
Bug 1643765: Add moxUnignoredChildren getter to MOXAccessibleBase r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D80983
2020-07-06 17:31:15 +00:00
Eitan Isaacson
8b130be2bb
Bug 1226473 - Support AXSelectedTextMarkerRange. r=morgan
...
To do this well we need to cache the text selection in the top level process.
Differential Revision: https://phabricator.services.mozilla.com/D82111
2020-07-06 17:32:45 +00:00
Eitan Isaacson
e1559a9b24
Bug 1650740 - Don't allow text range retrieval when doc tree is not fully constructed. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D82410
2020-07-06 17:31:17 +00:00
Sylvestre Ledru
caf785c695
Bug 1519636 - Reformat recent changes to the Google coding style r=andi
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D82178
2020-07-04 09:38:43 +00:00
Eitan Isaacson
2f2f6eb3ee
Bug 1649575 - Part 5: Implement string building for GeckoTextMarkerRange. r=morgan
...
This is a seperate patch because of the complexity.
Differential Revision: https://phabricator.services.mozilla.com/D81761
2020-07-02 21:57:55 +00:00
Eitan Isaacson
ebff8f5ad8
Bug 1649575 - Part 4: Introduce GeckoTextMarker and GeckoTextMarkerRange. r=morgan
...
These classes do a few things:
1. They implement and abstract common text operations, for example:
(a) comparing two markers to know which one precedes the other.
(b) text retrieval for ranges
(c) geometric bounds for ranges
(d) etc.
2. They can be converted to and from AXTextMarker(Range)s. Since the AXTextMarker
should not contain a raw pointer since there is a potential for use-after-free,
we need to lookup the referenced accessible in its document to know that it still exists.
Note: mozTextAccessible got pushed to another unified source file, so we need to
declare some stuff for it. Ideally we would be detecting these kinds of things sooner.
Differential Revision: https://phabricator.services.mozilla.com/D81760
2020-07-02 21:35:05 +00:00
Eitan Isaacson
7c21778bfd
Bug 1649575 - Part 3: Introduce MOXTextMarkerDelegate. r=morgan
...
The delegate is associated with accessible documents (either local or remote).
I made a separate protocol for all the text marker stuff as it really is a seperate API.
Differential Revision: https://phabricator.services.mozilla.com/D81759
2020-07-02 21:33:07 +00:00
Eitan Isaacson
9abbad9091
Bug 1649217 - Part 2: Send isSelectionCollapsed for caret move in IPC. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D81912
2020-07-02 18:08:52 +00:00
Simon Giesecke
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Morgan Reschenberg
4891a7b86e
Bug 1630292: Enusre we don't create accessibles for linebreaks. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D80986
2020-06-26 18:04:39 +00:00
Morgan Reschenberg
117fa600ac
Bug 1642707: Add web area class and attributes r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D80473
2020-06-26 04:00:49 +00:00
Eitan Isaacson
cd63c02db9
Bug 1647828 - Block moxPerformPress selector on non-actionable nodes. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D80712
2020-06-23 19:21:28 +00:00
Eitan Isaacson
31b2dc735d
Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D78160
2020-06-10 17:34:30 +00:00
Dorel Luca
31ee7a3080
Backed out changeset 498dee65dcf8 (bug 1643168) for Browser-chrome failures browser/mac/browser_focus.js. CLOSED TREE
2020-06-08 20:28:05 +03:00
Eitan Isaacson
97fb862d37
Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D78160
2020-06-08 15:47:11 +00:00
Morgan Reschenberg
3083026d43
Bug 1641932: Add Mac subroles to role map. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D77500
2020-06-05 03:45:44 +00:00
Eitan Isaacson
add69c1749
Bug 1642033 - Refactor mozTextAccessible to use MOX api. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D77564
2020-06-03 21:15:43 +00:00
Zeke Medley
533e723a19
Bug 1642448 - Replace remaining NSAssert statements in accessible/mac/ with MOZ_ASSERT's. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D77874
2020-06-02 20:40:37 +00:00
Eitan Isaacson
c3aa4bdf8c
Bug 1641984 - Implement MOX parameterized attribute getters. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D77563
2020-06-02 04:57:14 +00:00
Ricky Stewart
0bbaac721b
Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj
...
Also update documentation to suggest using the `GeneratedFile` template rather than directly referencing `GENERATED_FILES` where possible.
Differential Revision: https://phabricator.services.mozilla.com/D77496
2020-06-01 16:00:28 +00:00
Morgan Reschenberg
d93dd3ccbb
Bug 1624909: Create and maintain radio siblings array for position information. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D72751
2020-05-29 17:37:46 +00:00
Eitan Isaacson
9aa6dd6524
Bug 1641665 - Remove NSAccessibility methods from mozTableAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D77345
2020-05-28 23:06:42 +00:00
Eitan Isaacson
4a8cd9c1f8
Bug 1641659 - Remove NSAccessibility methods from mozActionElements. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D77344
2020-05-28 23:02:52 +00:00
Eitan Isaacson
a3ca2295dc
Bug 1641657 - Remove NSAccessibility methods from mozRootAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D77343
2020-05-28 22:41:30 +00:00
Eitan Isaacson
d0f0c96f5e
Bug 1641655 - Remove NSAccessibility methods from mozSelectableElements. r=morgan
...
A casualty of this is the "switch" action description for pressing tabs. That code
goes way back to our first Mac a11y support. WebKit and Chromium don't have it.
I tried to figure out when other browsers or apps had that with no luck.
Anyway, removing that description gives us the same behavior in VO as
WebKit and Chromium where there are no custom action description strings.
Differential Revision: https://phabricator.services.mozilla.com/D77342
2020-05-28 22:41:23 +00:00