Automatic update from web-platform-tests
Restore SVGSMILElement::Elapsed()
When sampling/adding instance times from within the animation engine we
want to use SMILTimeContainer::CurrentDocumentTime() rather than
SMILTimeContainer::Elapsed(). However the latter should still be used
for all event bases and similar. Since most users of
SVGSMILElement::Elapsed() still fall into the "event base" category,
restore it to its original guise and open-code usage of
CurrentDocumentTime() where it's needed.
Bug: 1000290
Change-Id: Ie91ae8d5c9c63d03476ba11921777d064b264066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783153
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#693589}
--
wpt-commits: 1ef7f92af6712133d89d663f612f4637e74e7cb0
wpt-pr: 18846
Automatic update from web-platform-tests
Revert "[webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm"
This reverts commit 581b273e3743fcbd168775edfeebae8b092fc706.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 693539 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU4MWIyNzNlMzc0M2ZjYmQxNjg3NzVlZGZlZWJhZThiMDkyZmM3MDYM
Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-rel/7906
Sample Failed Step: compile
Original change's description:
> [webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm
>
> This CL implements strictly the "Creating Web NFC message" algorithm
> described at http://w3c.github.io/web-nfc/#creating-web-nfc-message.
>
> 1.
> Changes the Web IDL definition for NDEFRecordData from
> "typedef (DOMString or unrestricted double or ArrayBuffer or Dictionary) NDEFRecordData;"
> to
> "typedef any NDEFRecordData;"
>
> 2.
> Adds verification of NDEFRecordInit when creating NDEFRecord, i.e. makes
> NDEFRecord ctor throw exceptions in case of invalid NDEFRecordInit.
> Also, the same thing for NDEFMessage and NFCReadingEvent.
>
> 3.
> Changes code flow for Step 10.9 of "9.10.1 The push() method" described
> at https://w3c.github.io/web-nfc/#the-push-method.
> "
> Let output be the notation for the NDEF message to be created by UA, as
> the result of passing message to create Web NFC message. If this throws
> an exception, reject p with that exception and abort these steps.
> "
> Previously,
> NDEFMessageSource (NDEFMessageInit) -Validity check->
> -Mojo TypeConverter-> Mojom NDEFMessagePtr
> Now,
> Remove "Validity check" and "Mojo TypeConverter" mentioned above,
> instead, we reuse the process of creating NDEFMessage from
> NDEFMessageSource (NDEFMessageInit), then the next step converting
> NDEFMessage to Mojom NDEFMessagePtr is quite an easy job.
>
> BUG=520391
>
> Change-Id: I628981e556f89ffdd0f883da0cfa99b20a6f8300
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767719
> Commit-Queue: Leon Han <leon.han@intel.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
> Cr-Commit-Position: refs/heads/master@{#693539}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=520391
Change-Id: I29fbd5f35999f41bfd1bc776c3c375bf3e6245f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787234
Cr-Commit-Position: refs/heads/master@{#693586}
--
wpt-commits: 4c1677a6c5838e772e554b1cfd939d957bbc4ef6
wpt-pr: 18869
Automatic update from web-platform-tests
[webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm
This CL implements strictly the "Creating Web NFC message" algorithm
described at http://w3c.github.io/web-nfc/#creating-web-nfc-message.
1.
Changes the Web IDL definition for NDEFRecordData from
"typedef (DOMString or unrestricted double or ArrayBuffer or Dictionary) NDEFRecordData;"
to
"typedef any NDEFRecordData;"
2.
Adds verification of NDEFRecordInit when creating NDEFRecord, i.e. makes
NDEFRecord ctor throw exceptions in case of invalid NDEFRecordInit.
Also, the same thing for NDEFMessage and NFCReadingEvent.
3.
Changes code flow for Step 10.9 of "9.10.1 The push() method" described
at https://w3c.github.io/web-nfc/#the-push-method.
"
Let output be the notation for the NDEF message to be created by UA, as
the result of passing message to create Web NFC message. If this throws
an exception, reject p with that exception and abort these steps.
"
Previously,
NDEFMessageSource (NDEFMessageInit) -Validity check->
-Mojo TypeConverter-> Mojom NDEFMessagePtr
Now,
Remove "Validity check" and "Mojo TypeConverter" mentioned above,
instead, we reuse the process of creating NDEFMessage from
NDEFMessageSource (NDEFMessageInit), then the next step converting
NDEFMessage to Mojom NDEFMessagePtr is quite an easy job.
BUG=520391
Change-Id: I628981e556f89ffdd0f883da0cfa99b20a6f8300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767719
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#693539}
--
wpt-commits: 685003d701e3c4154227758c65259c56662aa23d
wpt-pr: 18633
Automatic update from web-platform-tests
[LayoutNG] Handle `fit-content` for block axis as `auto`
The `min-content`, `max-content`, and `fit-content` spec[1]
defines:
> If specified for the inline axis, use ...;
> otherwise behaves as the property’s initial value.
This patch fixes |HasAutoHeightOrContainingBlockWithAutoHeight|
to match to the definition.
Legacy has some other behaviors that it doesn't require to
implement this part of the spec, but LayoutNG does, due to
some different behavior and code path around percentage
resolution for replaced elements.
[1]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content
Bug: 999913
Change-Id: I73feadee077ecbec6f23e08bb5d2b03a62eaf951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782187
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693476}
--
wpt-commits: b5f80c37979819db2766f845bbdba94dfffda1c3
wpt-pr: 18818
Automatic update from web-platform-tests
Do not simplify calc(0px + 0%) into 0px
Currently, when we create |Length| from calc(), and then create a
CSSPrimitiveValue from that |Length|, we may drop the percentage part
if it's zero.
As discussed at https://github.com/w3c/csswg-drafts/issues/3482, zero
percentages in calcs should be preserved.
Hence, this part ensures that percentage is perserved in calc(0px + 0%)
Note: we may want to preserve 0% in all cases, but that leads to many
test failures, so we leave the investigation to future instead.
This is also preparation for crrev.com/c/1777025, which switches the
implementation of InterpolableLength to a math expression to support
min/max.
Bug: 991672
Change-Id: I386f42a323079cce3d6ee545fa00ef289406e8bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779721
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693437}
--
wpt-commits: c92eaa98a3e95a47ab21dcdb974f5d1a79e354bb
wpt-pr: 18858
Automatic update from web-platform-tests
Implement checks in the proper order in XR::requestSession
The number and ordering of checks in XR::requestSession was not
compliant with the spec. This CL fixes that. There is still a remaining
issue around multiple immersive requests from different pages
simultaneously, but that should be done as separate work.
Link to relevant spec section:
https://immersive-web.github.io/webxr/#dom-xr-requestsession
Bug: 962991, 987073
Change-Id: I590eed311583542ceadc208047e40c3bf260e421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764325
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693455}
--
wpt-commits: 28d068748b2c965b69f4333b12bed1f38ab70a36
wpt-pr: 18754
Automatic update from web-platform-tests
[LayoutNG] Simplified layout needs to account for table-cell intrinsic padding.
Previously we didn't account for intrinsic-padding when determining the
static postiion in the simplified layout algorithm.
When using vertical-align: middle (or something which triggers intrinsic
padding) a OOF-position node might "jump".
This was found with the lastpass password manager.
Bug: 1000864
Change-Id: I94831f735a7e0992130ae065b0f6c9c6abb8c37a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785898
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693446}
--
wpt-commits: a6e7e60c55a11c1f12eeaa8384882fb3f70c127d
wpt-pr: 18859
Automatic update from web-platform-tests
Add a relaxedDurability option to IDBDatabase transaction
This plumbs a new optional relaxedDurability flag from the IDBDatabase
transaction web api in the renderer to the IndexedDBBackingStore
in the browser.
Flushing after every file write is very expensive and burns power,
and so it's desirable to eventually experiment with turning this
option off by default. It is currently implicitly on. This patch
doesn't change the default, but only exposes the option.
Results from my local Linux machine on the issue 785305 test case:
num | master | patch
------+-----------+---------
1000 | 41386 ms | 1843 ms
5100 | 214892 ms | 14283 ms
10000 | 423271 ms | 34271 ms
This test case had extremely variable output times, but this seems
to be about a 10x performance improvement on that test case.
Bug: 965883, 785305
Change-Id: Id54b65bd462f0983f8af44abc26575135d35f535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775557
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693419}
--
wpt-commits: 7561b155e100d0db088c9185457eb611313f6807
wpt-pr: 18817
Automatic update from web-platform-tests
[layoutng] Don't set the intrinsic height if the block height is fixed
This mirrors the legacy code in LayoutBox::UpdateLogicalHeight; see
also https://crrev.com/612705b60640f5e4157898e8d3d9bc128155924e.
Bug: 999253
Change-Id: Iabe46b61aebc952b8bd76470d7569b82d1901bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784330
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693336}
--
wpt-commits: b4236a6d2cf913f7ad4ed17b0be71fc6b519fe61
wpt-pr: 18844
Automatic update from web-platform-tests
[WPT/referrer-policy] Remove unset-referrer-policy/attr-referrer
This CL removes unset-referrer-policy/attr-referrer directory because:
- In unset-referrer-policy/ tests, no referrer policies are set
and thus unset-referrer-policy/attr-referrer is virtually
the same as unset-referrer-policy/{http-rp,meta-referrer}
and thus redundant.
- Because of the test code structure after [1],
there will be no test files corresponding to
unset-referrer-policy/attr-referrer after [1]
(while there will still be test files corresponding to
unset-referrer-policy/{http-rp,meta-referrer}).
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548
Bug: 906850
Change-Id: I2a81ac431c38201ae86027a2cd7ca195c00a8ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783238
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693323}
--
wpt-commits: c369cfcad4e83d1edab49dcc9f0f9d3e0f597dc0
wpt-pr: 18814
Automatic update from web-platform-tests
Fix WebXR display issue for angled screens when using OpenVR
Sending the full head-from-eye transformation matrix instead of just
the translation component and then multiplying the view matrix by it
fixesthe issue of having double vision when using a headset such as the
pimax 5k with significantly angled screens through OpenVR.
Also updated naming of transforms in XRView to be more readable.
Platforms that now send the actual head-from-eye transform:
- OpenVR
- GVR
Platforms that still only send the offset, but have at least been
updated to send it via the transformation matrix. These can be updated
in separate CLs.
- WMR
- Oculus (getting full transform would require updating libovr version)
- OpenXR
Because WebVR blink code uses the same mojo structs, it required a
small update to extract the translation component from the
transformation matrix that it receives. I verified that the WebVR
behavior is still the same (doesn't work with angled screens before or
after this change, but non-angled screens work fine).
Bug: 928433
Change-Id: Icf1004bb6ced033c5e4d68bf80686aeb77c393a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775229
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693311}
--
wpt-commits: ad816b8da48ee7d2ff1bac29aca76186172556f4
wpt-pr: 18759
Automatic update from web-platform-tests
Apply masks to <foreignObject>
An earlier CL stopped applying mask state, but this is incorrect,
as masks need to paint in the correct property tree state to apply.
The new CL applies the same logic as for the root <svg> element, which
paints in the same way as <foreignObject>
Bug: 998553
Change-Id: Ib8cea27e16063f459d9719336d4c0fac63589759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783144
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693215}
--
wpt-commits: 4490750ec49e4a0defa724950e0160ccce42a532
wpt-pr: 18821
Automatic update from web-platform-tests
[WPT/referrer-policy] Dedup some similar <srcdoc>-related tests
[1] will
(a) rename test files largely,
(b) split out <srcdoc>-related subtests for image requests
into separate test files, and
(c) omit some of the subtests, because they are redundant,
or due to mismatches between how tests are executed
before and after [1].
It is hard to track the mixture of (a), (b) and (c),
especially to see whether there are regressions by [1].
To remove the effect of (c) to some extent,
this CL skips some <srcdoc>-related tests (before [1]).
Ideally, if we can omit (c) from [1], then we can estimate
the number of passing/failing tests before/after [1]
by simple calculation, making it easier to check whether
[1] causes regressions.
The skipped tests have similar (non-skipped) tests so I expect
this CL doesn't substantially reduce test coverage.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548/
Bug: 906850
Change-Id: I4b791ba3a6b7512fea1a2e4debf67f382b966906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777094
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692734}
--
wpt-commits: 40215ec50a1d58ec9eff2b8e3f64f9ad75102a0b
wpt-pr: 18800
Automatic update from web-platform-tests
Remove explicit testharness(report).js includes in Bluetooth tests (#18832)
These are always included in multi-global tests, and including them
again leads to errors.
Discovered via https://github.com/web-platform-tests/wpt/pull/11024.
--
wpt-commits: ad3ad3e95482af4f96a1aed7a32726bb28ad3bdc
wpt-pr: 18832
Automatic update from web-platform-tests
[sms] Remove concept of timeouts in renderer process
This change follows this CL [1] and does further cleanup to remove
the concept of timeouts from the SMS Receiver API mainly from the
API interface and renderer process.
[1] https://crrev.com/c/1783219
Bug: 1000376
Change-Id: If7b8c17e0f1332df17e374c6f84e772a267c4760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783227
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693153}
--
wpt-commits: dee400049025a0b05dd7088d597b72ded800f8a9
wpt-pr: 18816
Automatic update from web-platform-tests
[css-contain-1] Fix tests to work on in the css testharness (#18828)
--
wpt-commits: 6e83b23bb962c97687b6573c378963208219ad1b
wpt-pr: 18828
Automatic update from web-platform-tests
Allow strings containing '.' after sign (ex: -.8) in Decimal::FromString.
Entering those strings in a <input type=number> leads to validation messages not being displayed in certain cases:
- rangeUnderflow (bug985330)
- rangeOverflow
- stepMisMatch
This is due to Decimal::FromString not recognizing it as valid, hence returning NaN incorrectly. decimal.h and the spec:
https://html.spec.whatwg.org/#valid-floating-point-number say it should be supported.
Fixes it and adds appropriate tests in wtf_unittests and in web_tests.
Bug: 985330
Change-Id: Ic3a3bb1ca855ebcc13f96aac16c31937a2cba0cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773262
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693074}
--
wpt-commits: 406e0ae0c356eda5cb9fb6ff82a926d2a44276a1
wpt-pr: 18778
Kris Maglione
moz-wptsync-bot
autofoolip
Hiroshige Hayashizaki
Fredrik Söderquist
Findit
Leon Han
Koji Ishii
Xiaocheng Hu
Will Cassella
Ian Kilpatrick
Adrienne Walker
Christian Biesinger
Jacob DeWitt
Rodney Ding
Chris Harrelson
Philip Jägenstedt
youennf
Stefano Sanfilippo
Ayu Ishii
Florian Rivoal
Rob Buis
Matthieu Rigolot