Граф коммитов

10980 Коммитов

Автор SHA1 Сообщение Дата
Dorel Luca e0ac748fab Backed out 2 changesets (bug 1644896) for XPCshell failures on widget/headless/tests/test_headless.js. CLOSED TREE
Backed out changeset f501e7db25a8 (bug 1644896)
Backed out changeset 2d984add3abb (bug 1644896)
2020-07-13 23:11:40 +03:00
Andrea Marchesini c14aa7655d Bug 1644896 - Add the shutdown blocker during the PermissionManager::initDB, r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D83360
2020-07-13 17:48:30 +00:00
Andrea Marchesini 8a5c2d57b1 Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 17:48:20 +00:00
Bogdan Tara 51562a8355 Backed out changeset 73b12096811d (bug 1644896) for mochitest crashes CLOSED TREE 2020-07-13 12:32:28 +03:00
Andrea Marchesini 6955bc5543 Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 08:23:27 +00:00
Kris Maglione 9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Kris Maglione 6a39211860 Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 21:42:25 +00:00
Csoregi Natalia b355fcc4bf Backed out 6 changesets (bug 1464542) for xpcshell failures on test_Services.js. CLOSED TREE
Backed out changeset b50af9005851 (bug 1464542)
Backed out changeset 9d3a0ea2cf65 (bug 1464542)
Backed out changeset 71c3475fcbc2 (bug 1464542)
Backed out changeset 51ff93220a95 (bug 1464542)
Backed out changeset e84de1547c09 (bug 1464542)
Backed out changeset bbecc16d08eb (bug 1464542)
2020-07-09 23:19:26 +03:00
Kris Maglione d09458dc51 Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 17:59:16 +00:00
Simon Giesecke 61e4a0be9b Bug 1649729 - Get rid of MOZ_ACCESS_THREAD_BOUND macro. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D81843
2020-07-01 13:13:23 +00:00
Simon Giesecke 9364b353d4 Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
Simon Giesecke e3c223da3e Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
Simon Giesecke cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Andrea Marchesini 788cd2c41f Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D81681
2020-06-30 18:34:51 +00:00
Andrea Marchesini 5b1b63de75 Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-30 09:44:00 +00:00
Csoregi Natalia adaed940e7 Backed out changeset 34d09061d827 (bug 1648134) for failures on test_permmanager_remove_add_update.js. CLOSED TREE 2020-06-29 20:43:54 +03:00
Andrea Marchesini dc7bad122c Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-29 14:37:19 +00:00
Tim Huang 1d1ef81356 Bug 1645997 - Use BrowsingContext to get the top-level window context in PermissionDelegateHandler.cpp r=baku
We used the Document::GetWindowContext() to get the window context
related to the doucment. But, this could return a nullptr if the
document is detached from the window or the docuemnt is destoried.

We move to use the BrowsingContext instead which won't return a nullptr
in these cases.

Differential Revision: https://phabricator.services.mozilla.com/D79897
2020-06-19 12:31:29 +00:00
Henri Sivonen d5b9be12ce Bug 1603712 - Remove intl.charset.detector.ng.enabled pref and resulting dead code. r=Gijs,fluent-reviewers,valentin,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D79101
2020-06-15 15:32:21 +00:00
Tim Huang f5adef2650 Bug 1587743 - Part 3: Using WindowContext to test delegated permissions. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79134
2020-06-12 16:32:03 +00:00
Tim Huang 8422436b6c Bug 1587743 - Part 2: Removing mTopLevelPrincipal from the PermissionDelegateHandler. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79133
2020-06-12 16:31:56 +00:00
Tim Huang eab7aa2b87 Bug 1587743 - Part 1: Pre-compute the delegated permissions for the top-level content and store it in the WindowContext. r=baku,nika
In order to delegate the permission to the top-level window, in this
patch, we pre-compute the permissions of the top-level context and set
them to the top-level WindowContext. So, the cross-origin iframe can
know the permission of the top-level window through the WindowContext.
Thus, the permission can be delegated in Fission.

Differential Revision: https://phabricator.services.mozilla.com/D79132
2020-06-12 16:31:49 +00:00
Haik Aftandilian b1f63ced7e Bug 1632845 - Firefox gets stuck when quit from the dock if the user cancels quitting from a beforeunload prompt r=Gijs,spohl,necko-reviewers,geckoview-reviewers,dragana,agi
Return NSTerminateCancel from applicationShouldTerminate when the user chooses to "Stay on Page".

Differential Revision: https://phabricator.services.mozilla.com/D78839
2020-06-09 18:20:36 +00:00
Dimi Lee 53b848ce2f Bug 1644073 - Remove storageAccessAPI permission from preload list r=baku
We add storageAccessAPI permission to perload list in Bug 1499442.

In the recent ETP fission works, we have ensured that the user interaction
permission check can only happen either in the parent process or in the
content processes that load principal to check. This means we don't need
to preload it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D78639
2020-06-08 11:24:05 +00:00
Makoto Kato b8d216c8f6 Bug 1637553 - Reduce array copy in spell checker loop. r=masayuki
Actually, we always clone spell checker range array per IPC call into spell
check loop. But we can use `std::move` to reduce unnecessary copy.

Also, `mozInlineSpellWordUtil::GetNextWord` always returns NS_OK, so
this should use boolean value to know whether loop is done.

Differential Revision: https://phabricator.services.mozilla.com/D75111
2020-05-27 14:33:12 +00:00
Emilio Cobos Álvarez 89958b377a Bug 1640605 - Remove IsInAnonymousSubtree / IsRootOfAnonymousSubtree. r=edgar
In favor of the NativeAnonymous versions which they forward to.

Done automatically with:

  rg -l 'IsInAnonymousSubtree' | xargs sed -i 's/IsInAnonymousSubtree/IsInNativeAnonymousSubtree/g'

And removing the function definitions afterwards.

Differential Revision: https://phabricator.services.mozilla.com/D76681
2020-05-25 11:43:51 +00:00
Johann Hofmann badadf3f93 Bug 1596855 - Update browser_permmgr_sync.js for Fission. r=pbz
The test was updated to ensure that under Fission we're not syncing
all permission information to a "parent" content process, and instead
just to the specific iframe that needs it.

Differential Revision: https://phabricator.services.mozilla.com/D76103
2020-05-20 16:45:01 +00:00
Andrea Marchesini 68dab10ed9 Bug 1629274 - Fix Intermittent failure in test_permmanager_removeall.js, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D74590
2020-05-11 08:34:04 +00:00
Andrea Marchesini 8bc8cd34b1 Bug 1635693 - Ensure permissionManager DB connection is active only if the initialization completed, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D74385
2020-05-08 16:23:15 +00:00
Ian Moody 011b59d595 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Simon Giesecke 6a983da8c3 Bug 1626570 - Improve handling of copying arrays in extensions/spellcheck. r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D72319
2020-04-30 09:36:26 +00:00
Andi-Bogdan Postelnicu 38afb32dc5 Bug 1626555 - Make `dom/base` buildable outside of `unified-build` environment. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D69183
2020-04-29 09:02:05 +00:00
Johann Hofmann 59f0df8747 Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 17:26:04 +00:00
Daniel Varga ce17a27917 Backed out changeset b1f668b65e69 (bug 1627220) for causing xpcshell failures at extensions/permissions/test/unit/test_permmanager_expiration.js
CLOSED TREE
2020-04-27 17:49:53 +03:00
Johann Hofmann 105e5e23f6 Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 11:40:53 +00:00
Sebastian Streich ea62971514 Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
***

Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-23 13:11:56 +00:00
Noemi Erli b611a44386 Backed out changeset a2bff0eef797 (bug 1623417) for causing xpcshell failures in test_permmanager_matchesuri.js CLOSED TREE 2020-04-20 20:09:23 +03:00
Sebastian Streich bb11628699 Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
***

Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-20 15:59:44 +00:00
Kershaw Chang 85532d60f8 Bug 1626076 - Make it possible to use DataStorage on socket process r=keeler,dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D68877
2020-04-20 09:41:58 +00:00
Sebastian Streich c0401ba16f Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D65606
2020-04-20 09:53:40 +00:00
Magnus Melin 7be9697324 Bug 1629450 - reset built-in permissions earily also in test_permmanager_load_invalid_entries.js. r=baku
Started failing following https://hg.mozilla.org/mozilla-central/rev/f1d9689ea300

Differential Revision: https://phabricator.services.mozilla.com/D70930

--HG--
extra : moz-landing-system : lando
2020-04-15 07:23:11 +00:00
Magnus Melin 7e719a42a0 Bug 1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku
After bug 1363541 the calls to Services.prefs.setCharPref("permissions.manager.defaultsUrl", ""); must be done early to have any effect. Otherwise the defaults will already be imported and tests do not get the expected starting point.

Differential Revision: https://phabricator.services.mozilla.com/D70675

--HG--
extra : moz-landing-system : lando
2020-04-14 08:34:17 +00:00
Andrea Marchesini 68d9c71f19 Bug 1629273 - Fix intermittent failure in test_permmanager_load_invalid_entries.js, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70639

--HG--
extra : moz-landing-system : lando
2020-04-14 07:55:52 +00:00
Andrea Marchesini 98eff139c5 Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70164

--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:53 +00:00
Andrea Marchesini 9f0376cefe Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:30 +00:00
Andrea Marchesini 13481ea877 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-11 13:42:12 +00:00
Andrea Marchesini a765ed14dd Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
2020-04-11 13:41:19 +00:00
Andrea Marchesini 5c1bc3ab01 Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
2020-04-10 08:36:46 +00:00
Andrea Marchesini d0bfec4f79 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-10 08:36:37 +00:00
Razvan Maries b74e338c98 Backed out 6 changesets (bug 1363541) for perma failures. CLOSED TREE
Backed out changeset a775f6e9eb41 (bug 1363541)
Backed out changeset 9212bfd89eca (bug 1363541)
Backed out changeset bf41b0c139f6 (bug 1363541)
Backed out changeset aa7c6668b249 (bug 1363541)
Backed out changeset 9f413a8a47bb (bug 1363541)
Backed out changeset 827a9a2866bd (bug 1363541)

--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 11:31:20 +03:00
Andrea Marchesini 519961d263 Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70164

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
Andrea Marchesini 4adbfbb4d0 Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
Andrea Marchesini b523b552a4 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
Andrea Marchesini f78d7b4bd4 Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
2020-04-10 06:36:03 +00:00
Andrea Marchesini 3961346cfc Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
Andrea Marchesini 2ab42cd711 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
Coroiu Cristina d37de5ed78 Backed out 6 changesets (bug 1363541) for browser-chrome failures at browser/base/content/test/performance/browser_startup_mainthreadio.js on a CLOSED TREE
Backed out changeset 947073be919f (bug 1363541)
Backed out changeset 1f397b686c11 (bug 1363541)
Backed out changeset d2ba944a47a3 (bug 1363541)
Backed out changeset 80d4d1f0c921 (bug 1363541)
Backed out changeset 9d6b9052f413 (bug 1363541)
Backed out changeset aeaa10789071 (bug 1363541)

--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 01:00:15 +03:00
Andrea Marchesini 25ea79a516 Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70164

--HG--
extra : moz-landing-system : lando
2020-04-09 13:28:23 +00:00
Andrea Marchesini 3e892fdba4 Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-09 13:27:53 +00:00
Andrea Marchesini 8764c55c53 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 13:27:35 +00:00
Andrea Marchesini f71aefda4e Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
2020-04-09 13:26:29 +00:00
Andrea Marchesini cefe8accad Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
2020-04-09 13:25:56 +00:00
Andrea Marchesini 23b424cd70 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-09 14:07:34 +00:00
Andreas Farre b529c76594 Bug 1620594 - Part 6: Use AbstractThread::MainThread instead of SystemGroup::AbstractThread. r=nika
Depends on D67635

Differential Revision: https://phabricator.services.mozilla.com/D67636

--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:14 +00:00
Andreas Farre 63e21eec70 Bug 1620594 - Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika
To be able to remove SystemGroup, NS_ReleaseOnMainThreadSystemGroup
needs to have its dependency on SystemGroup removed. Since all
releases using SystemGroup would've released on the main thread anyway
we can safely replace NS_ReleaseOnMainThreadSystemGroup with
NS_ReleaseOnMainThread.

Depends on D64390

Differential Revision: https://phabricator.services.mozilla.com/D67631

--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:23 +00:00
Kearwood Gilbert 9136ce65cf Bug 1614496 - Implement WebXR Core Module DOM Interfaces r=jgilbert,daoshengmu,webidl,smaug,baku,imanol
Implement DOM interfaces for the WebXR Core Module. Additional work to implement the WebXR Core Module are marked with TODO (Bug #) comments within the patch and must be landed before enabling the dom.vr.webxr.enabled flag.

Differential Revision: https://phabricator.services.mozilla.com/D62369

--HG--
extra : moz-landing-system : lando
2020-04-06 19:33:32 +00:00
Cosmin Sabou 2db886518c Backed out changeset 848221b2e156 (bug 1620402) for causing several test failures.
CLOSED TREE
2020-03-30 11:35:20 +03:00
Sebastian Streich e23cc2cd7f Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D65606

--HG--
extra : moz-landing-system : lando
2020-03-30 07:34:37 +00:00
Makoto Kato 8e9a1c655f Bug 1619883 - Don't include spellchecker dictionary in omni.ja of GeckoView. r=geckoview-reviewers,agi
Actually, we don't turn on hunspell spellchecker for Android, but, omni.ja seems have hunspell's dictionary. Let's remove it from package.

Differential Revision: https://phabricator.services.mozilla.com/D65477

--HG--
extra : moz-landing-system : lando
2020-03-23 15:46:06 +00:00
Tim Huang 7057b877bd Bug 1612378 - Part 8: Remove "trackingprotection" and "trackingprotection-pb" from the preload permission list. r=dimi,baku
We can remove this two permissions from the preload list since we would
only access these two permissions in the parent process. So, it doesn't
need to be sent to content processes anymore.

Differential Revision: https://phabricator.services.mozilla.com/D66215

--HG--
extra : moz-landing-system : lando
2020-03-25 13:22:09 +00:00
Chris Fronk d5b004443b Bug 1143478 - Rename mozilla::Pair to CompactPair. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64511

--HG--
rename : mfbt/Pair.h => mfbt/CompactPair.h
extra : moz-landing-system : lando
2020-03-17 12:42:12 +00:00
Mirko Brodesser ec9cb4d8ef Bug 1622199: annotate `Selection::AddRangeAndSelectFramesAndNotifyListeners` with `MOZ_CAN_RUN_SCRIPT`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D66759

--HG--
extra : moz-landing-system : lando
2020-03-13 15:46:13 +00:00
aarushivij 679f1a2799 Bug 1580866 - PermissionTestUtils should throw for undefined r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66413

--HG--
extra : moz-landing-system : lando
2020-03-12 19:15:48 +00:00
shindli b02b3a6e1a Backed out changeset a08637fb30c8 (bug 1143478) for causing bustages in /builds/worker/checkouts/gecko/ipc/mscom/Registration.cpp CLOSED TREE
--HG--
rename : mfbt/CompactPair.h => mfbt/Pair.h
2020-03-11 14:30:54 +02:00
Chris Fronk a27e438c2d Bug 1143478 - Rename mozilla::Pair to CompactPair. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64511

--HG--
rename : mfbt/Pair.h => mfbt/CompactPair.h
extra : moz-landing-system : lando
2020-03-11 12:18:13 +00:00
Ehsan Akhgari 4369044005 Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65819

--HG--
extra : moz-landing-system : lando
2020-03-09 23:36:35 +00:00
Narcis Beleuzu 0186cbe565 Backed out 8 changesets (bug 1620322) for bustages on nsContentSink.cpp . CLOSED TREE
Backed out changeset f41739c64dff (bug 1620322)
Backed out changeset be942a7f329e (bug 1620322)
Backed out changeset a916987c7c71 (bug 1620322)
Backed out changeset ead3484ffb5f (bug 1620322)
Backed out changeset 4e1e8b9afa1a (bug 1620322)
Backed out changeset 473bba698e5a (bug 1620322)
Backed out changeset 0e5e5d41597d (bug 1620322)
Backed out changeset 31b24d79db3d (bug 1620322)

--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
2020-03-09 22:18:36 +02:00
Ehsan Akhgari a95fb737fd Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65819

--HG--
extra : moz-landing-system : lando
2020-03-09 18:12:35 +00:00
Noemi Erli a48fac9e3b Backed out 8 changesets (bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE
Backed out changeset 3dcf513e36cb (bug 1620322)
Backed out changeset 46714855ce1d (bug 1620322)
Backed out changeset 0eb2b5f7322f (bug 1620322)
Backed out changeset 72d640fa0740 (bug 1620322)
Backed out changeset 4533bb4e5177 (bug 1620322)
Backed out changeset 659270edd419 (bug 1620322)
Backed out changeset 6802c18b1914 (bug 1620322)
Backed out changeset 60ff34db9f15 (bug 1620322)

--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
2020-03-09 19:19:41 +02:00
Ehsan Akhgari 300024b8c3 Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65819

--HG--
extra : moz-landing-system : lando
2020-03-09 10:22:14 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Mirko Brodesser 4be580237d Bug 1619617: part 1) Annotate `RemoveRangeAndUnselectFramesAndNotifyListeners` with `MOZ_CAN_RUN_SCRIPT`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65511

--HG--
extra : moz-landing-system : lando
2020-03-06 12:03:23 +00:00
Tim Huang 04d44bae12 Bug 1616570 - Part 1: Rename CookieSettings to CookieJarSettings. r=Ehsan
Given that we are going to add ContentBlockingAllowList in
CookieSettings, so CookieSettings will be responsible for more stuff than the
cookie behavior and cookie permission. We should use a proper name to
reflect the purpose of it. The name 'CookieSettings' is misleading that
this is only for cookie related stuff. So, we decide to rename
'CookieSettins' to 'CookieJarSettings' which serves better meaning here.

Differential Revision: https://phabricator.services.mozilla.com/D63935

--HG--
rename : netwerk/cookie/CookieSettings.cpp => netwerk/cookie/CookieJarSettings.cpp
rename : netwerk/cookie/nsICookieSettings.idl => netwerk/cookie/nsICookieJarSettings.idl
extra : moz-landing-system : lando
2020-03-04 08:59:08 +00:00
Mike Conley aef458a960 Bug 1614639 - Clear expired permissions from the database during idle off of the main thread. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D64749

--HG--
extra : moz-landing-system : lando
2020-02-28 17:50:19 +00:00
Masatoshi Kimura 2a6dcf4db7 Bug 1617338 - Suppress warnings from third-party code in extensions/spellcheck/hunspell/glue/. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63749

--HG--
extra : moz-landing-system : lando
2020-02-27 14:52:00 +00:00
Ehsan Akhgari 7a072c5114 Bug 1617893 - Ensure that we properly strip OriginAttributes when deciding which permissions to send for a principal; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D64428

--HG--
extra : moz-landing-system : lando
2020-02-26 18:39:30 +00:00
Ehsan Akhgari cc9c416a87 Bug 1618251 - Remove the duplicated call to GetKeyForPrincipal() which got added during rebasing; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D64404

--HG--
extra : moz-landing-system : lando
2020-02-26 16:49:59 +00:00
Brindusan Cristian a58c69be12 Backed out changeset 358b1ecca80b (bug 1617338) for build bustages on Unified_cpp_hunspell_glue0. CLOSED TREE 2020-02-26 19:28:54 +02:00
Masatoshi Kimura cb9e7bf077 Bug 1617338 - Suppress warnings from third-party code in extensions/spellcheck/hunspell/glue/ r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63749

--HG--
extra : moz-landing-system : lando
2020-02-26 16:45:29 +00:00
Kris Maglione c31aa68fb4 Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.

Differential Revision: https://phabricator.services.mozilla.com/D63962

--HG--
extra : moz-landing-system : lando
2020-02-25 19:44:39 +00:00
Simon Giesecke aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
2020-02-25 17:03:36 +00:00
Simon Giesecke 32c9aeaad4 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
2020-02-25 09:36:12 +00:00
Cosmin Sabou 7f1afff492 Backed out 5 changesets (bug 1617604, bug 1617542, bug 1617546) for causing build bustages on ipc/mscom/Interceptor.cpp.
CLOSED TREE

Backed out changeset 5faa54ad950e (bug 1617542)
Backed out changeset cb38779e1eb6 (bug 1617604)
Backed out changeset 3aea18e0396f (bug 1617542)
Backed out changeset bc3eeefdfb6c (bug 1617542)
Backed out changeset b76a3aa5ff6f (bug 1617546)
2020-02-24 19:50:13 +02:00
Simon Giesecke df538d9a79 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
2020-02-24 17:08:30 +00:00
Ehsan Akhgari 8cf4826b61 Bug 1617205 - In nsPermissionManager::AddInternal(), only compute the origin string when it is needed, and when the caller doesn't have it available; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D63678

--HG--
extra : moz-landing-system : lando
2020-02-24 15:06:54 +00:00
Ehsan Akhgari a8ca0713ed Bug 1614831 - Speed up the transmission of permissions to content processes upon navigation; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D63674

--HG--
extra : moz-landing-system : lando
2020-02-24 15:21:51 +00:00
pbz 490d6db508 Bug 1614956 - Removed invalid IsOAForceStripPermission call in nsPermissionManager. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D62610

--HG--
extra : moz-landing-system : lando
2020-02-12 18:50:02 +00:00
Simon Giesecke b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
shindli 91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Mirko Brodesser 36437a9d2d Bug 1613378: part 9) Clarify dependency to `mFrameSelection` in `Selection` when adding/removing ranges. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D62198

--HG--
extra : moz-landing-system : lando
2020-02-12 12:27:32 +00:00
Ehsan Akhgari 299cb321f2 Bug 1595542 - Update the spellchecker dictionary to SCOWL 2019.10.06
Differential Revision: https://phabricator.services.mozilla.com/D62069

--HG--
extra : amend_source : 44ea926d595dcfa8d0adedd559cc3b545eca119d
2020-02-07 20:15:26 +02:00
Masayuki Nakano 450b71f763 Bug 1612085 - part 1: Hide constructor of `nsRange` r=smaug
`nsRange` instances are allocated a lot in the heap especially by editor and
spellchecker.  The allocation cost is too bad for benchmarks.  Therefore,
we should reuse released instances as far as possible.  For managing it in
static factory methods of `nsRange`, we need to hide `nsRange` constructor.

Differential Revision: https://phabricator.services.mozilla.com/D61237

--HG--
extra : moz-landing-system : lando
2020-01-30 13:23:35 +00:00
pbz 0d5e5faea7 Bug 1357107 - Remove nsContentBlocker. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D59696

--HG--
extra : moz-landing-system : lando
2020-01-21 19:19:17 +00:00
Sylvestre Ledru 187e9bafaf Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D60354

--HG--
extra : moz-landing-system : lando
2020-01-21 09:51:27 +00:00
Emilio Cobos Álvarez 256c124f94 Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
This was done by:

This was done by applying:

```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
         from subprocess import Popen, PIPE, check_output, CalledProcessError

         diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
-        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']

         if not output_file:
             args.append("-i")
```

Then running `./mach clang-format -c <commit-hash>`

Then undoing that patch.

Then running check_spidermonkey_style.py --fixup

Then running `./mach clang-format`

I had to fix four things:

 * I needed to move <utility> back down in GuardObjects.h because I was hitting
   obscure problems with our system include wrappers like this:

0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94              ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94     MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94                                ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)

   Which I really didn't feel like digging into.

 * I had to restore the order of TrustOverrideUtils.h and related files in nss
   because the .inc files depend on TrustOverrideUtils.h being included earlier.

 * I had to add a missing include to RollingNumber.h

 * Also had to partially restore include order in JsepSessionImpl.cpp to avoid
   some -WError issues due to some static inline functions being defined in a
   header but not used in the rest of the compilation unit.

Differential Revision: https://phabricator.services.mozilla.com/D60327

--HG--
extra : moz-landing-system : lando
2020-01-20 16:19:48 +00:00
Emilio Cobos Álvarez aa3a695712 Bug 1609996 - Remove mozilla/Move.h. r=froydnj
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'

Further manual fixups and cleanups to the include order incoming.

Differential Revision: https://phabricator.services.mozilla.com/D60323

--HG--
extra : moz-landing-system : lando
2020-01-20 16:18:20 +00:00
pbz 9f91b02a4c Bug 1591748 - Added test for oa strip permission list. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D58832

--HG--
extra : moz-landing-system : lando
2020-01-08 12:17:05 +00:00
pbz 2945018d83 Bug 1591748 - nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D58831

--HG--
extra : moz-landing-system : lando
2020-01-08 13:06:28 +00:00
Noemi Erli c2e009f1e0 Backed out 2 changesets (bug 1591748) for causing bustages in nsPermissionManager.cpp CLOSED TREE
Backed out changeset 18fe0c505632 (bug 1591748)
Backed out changeset 94d8942709df (bug 1591748)
2020-01-07 02:28:04 +02:00
pbz 2eac1bb2bf Bug 1591748 - Added test for oa strip permission list. r=Ehsan
Depends on D58831

Differential Revision: https://phabricator.services.mozilla.com/D58832

--HG--
extra : moz-landing-system : lando
2020-01-06 20:11:07 +00:00
pbz f5737d34aa Bug 1591748 - nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D58831

--HG--
extra : moz-landing-system : lando
2020-01-06 23:49:10 +00:00
Thomas Nguyen b4435e40e5 Bug 1603674 - Add a new API to check if permission delegation and Feature Policy are enabled r=baku
Differential Revision: https://phabricator.services.mozilla.com/D57077

--HG--
extra : moz-landing-system : lando
2020-01-06 15:28:12 +00:00
Makoto Kato 7e2d6cdef4 Bug 1602526 - Part 1. Don't use implicit cast from char to uint32_t r=masayuki
This is regerssion by bug 1571339.

Non-ASCII character such as 0xf9 will be casted to 0xfff9 etc by implicit cast.
So I should cast from char to uint8_t or add char version fucntions.

Differential Revision: https://phabricator.services.mozilla.com/D58090

--HG--
extra : moz-landing-system : lando
2019-12-26 03:34:49 +00:00
Chris Peterson 406763af7f Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj
This changeset is a simple find and replace of `MOZ_FALLTHROUGH` and `[[fallthrough]]`.

Unfortunately, the MOZ_FALLTHROUGH_ASSERT macro (to assert on case fallthrough in debug builds) is still necessary after switching from [[clang::fallthrough]] to [[fallthrough]] because:

* MOZ_ASSERT(false) followed by [[fallthrough]] triggers a -Wunreachable-code warning in DEBUG builds
* but MOZ_ASSERT(false) without [[fallthrough]] triggers a -Wimplicit-fallthrough warning in NDEBUG builds.

Differential Revision: https://phabricator.services.mozilla.com/D56440

--HG--
extra : moz-landing-system : lando
2019-12-20 07:16:43 +00:00
Ehsan Akhgari 77edf2c060 Bug 1603969 - Part 2: Update existing 'storageAccessAPI' permissions with granted origin used in them; r=baku
This permission manager migration drops the granted origin part of the
permission type.

Differential Revision: https://phabricator.services.mozilla.com/D57494

--HG--
extra : moz-landing-system : lando
2019-12-19 02:56:54 +00:00
Gurzau Raul bed8b9f116 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE.
Backed out changeset c4d79087eef1 (bug 1603969)
Backed out changeset 2c0198f3506c (bug 1603969)
Backed out changeset c5ad252c525b (bug 1603969)
Backed out changeset a334451b95eb (bug 1603969)
2019-12-19 02:08:09 +02:00
Ehsan Akhgari 5cd834fdd4 Bug 1603969 - Part 2: Update existing 'storageAccessAPI' permissions with granted origin used in them; r=baku
This permission manager migration drops the granted origin part of the
permission type.

Differential Revision: https://phabricator.services.mozilla.com/D57494

--HG--
extra : moz-landing-system : lando
2019-12-18 19:14:55 +00:00
Gurzau Raul e92fa08412 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE.
Backed out changeset 959f12e42db9 (bug 1603969)
Backed out changeset 18bf461b9630 (bug 1603969)
Backed out changeset 8c3bb23a048b (bug 1603969)
Backed out changeset 450eec13d73e (bug 1603969)
2019-12-18 20:53:13 +02:00
Ehsan Akhgari 1211dd7e49 Bug 1603969 - Part 2: Update existing 'storageAccessAPI' permissions with granted origin used in them; r=baku
This permission manager migration drops the granted origin part of the
permission type.

Differential Revision: https://phabricator.services.mozilla.com/D57494

--HG--
extra : moz-landing-system : lando
2019-12-18 15:49:17 +00:00
Kris Maglione 94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:16 +00:00
pbz a937a753bc Bug 1601256 - nsPermissionManager: Store all private browsing permissions with session expiry. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D56183

--HG--
extra : moz-landing-system : lando
2019-12-13 12:27:10 +00:00
Henri Sivonen 5c2bad25ab Bug 1551276 - Autodetect legacy encodings on unlabeled pages. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D56362

--HG--
extra : moz-landing-system : lando
2019-12-12 17:50:19 +00:00
Oana Pop Rus df78d6011c Backed out changeset 0810ad586986 (bug 1551276) for wpt failures in ar-ISO-8859-6-late.tentative.html on a CLOSED TREE 2019-12-12 16:38:54 +02:00
Henri Sivonen 07527a83c9 Bug 1551276 - Autodetect legacy encodings on unlabeled pages. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D56362

--HG--
extra : moz-landing-system : lando
2019-12-12 12:59:47 +00:00
Kearwood Kip Gilbert 19ba3b0322 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-12 03:10:51 +00:00
Tom Tung 83eb41d14a Bug 1474608 - P1 - Clear origin attributes directly for deleteDataFromOriginAttributesPattern if it's possible; r=asuth,baku
The idea of this patch is to try to not use oberver mechanism as possible. To
achieve that, it introduces deleteByOriginAttributes() to cleaners. Different
from other methods, it would only be executed if it's implemented from a
cleaner.

It doesn't remove oberver mechanism entirely since some cleaners are still using
that for other deleteByXXX() functions. So, it only applies removing stuff to
PushService, QuotaManagerService, ServiceWorkerManager, nsPermissionManager,
nsApplicationCacheService, and nsCookieService.

Since the original issue is related to QuotaManagerService, it adds xpcshell
test under the dom/quota/test/unit/ to ensure the behavior won't be changed
accidentally in the future.

Differential Revision: https://phabricator.services.mozilla.com/D33758

--HG--
extra : moz-landing-system : lando
2019-12-02 19:47:13 +00:00
Megha 08ae52fe49 Bug 1556380 - Enable more ESLint rules for extensions/. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D43355

--HG--
extra : moz-landing-system : lando
2019-12-06 21:05:20 +00:00
Mark Banner 2103c3b16a Bug 1601681 - Switch recently added files with Windows line endings to Unix. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D55990

--HG--
extra : moz-landing-system : lando
2019-12-11 08:12:49 +00:00
Brindusan Cristian 9c36dcbf23 Backed out 2 changesets (bug 1580567, bug 1599927) for mochitest failures at test_interfaces.html. CLOSED TREE
Backed out changeset 0e0d88942d33 (bug 1599927)
Backed out changeset 522c8d183bd5 (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-11 05:31:08 +02:00
Kearwood Kip Gilbert 7c8ce74b8f Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-11 01:38:17 +00:00
shindli 652f3b0296 Backed out 2 changesets (bug 1580567, bug 1599927) for causing permafailures in dom/tests/mochitest/general/test_interfaces.html CLOSED TREE
Backed out changeset aeceec922866 (bug 1599927)
Backed out changeset 29809135f18e (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-11 03:32:44 +02:00
shindli 91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kearwood Kip Gilbert 6a9c22db45 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-10 23:55:05 +00:00
Kris Maglione 16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:13 +00:00
Noemi Erli 82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione 910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-07 19:11:58 +00:00
Daniel Varga 84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione 20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-06 22:14:14 +00:00
Gabriele Svelto 69790bc62e Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443

--HG--
extra : moz-landing-system : lando
2019-12-06 09:16:44 +00:00
Boris Zbarsky 75124bdd98 Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D53067

--HG--
extra : moz-landing-system : lando
2019-12-05 04:44:32 +00:00
Thomas Nguyen 1e82cdc161 Bug 1483631 - Prompt with both first party and third party origin if we are delegating permission with allows all feature policy. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D51839

--HG--
extra : moz-landing-system : lando
2019-12-04 15:39:26 +00:00
Thomas Nguyen fd744cea01 Bug 1483631 - Restrict nested permission requests in ContentPermissionPrompt with permission delegate r=baku,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D47416

--HG--
extra : moz-landing-system : lando
2019-12-04 15:39:03 +00:00
Gurzau Raul 4f21dcd081 Backed out 4 changesets (bug 1483631) for failing at browser_temporary_permissions.js on a CLOSED TREE.
Backed out changeset f5bb5f6a148f (bug 1483631)
Backed out changeset c5e562c1d590 (bug 1483631)
Backed out changeset 7ef09193a7ef (bug 1483631)
Backed out changeset a909dcbbea2b (bug 1483631)
2019-12-03 21:57:55 +02:00
Emma Malysz c502777f53 Bug 1597847, rename remaining misc xul files from within /view, /gfx, /extensions, and /testing to .xhtml format r=marionette-reviewers,bgrins,whimboo,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D54035

--HG--
rename : extensions/spellcheck/tests/chrome/test_add_remove_dictionaries.xul => extensions/spellcheck/tests/chrome/test_add_remove_dictionaries.xhtml
rename : gfx/tests/crashtests/593526.xul => gfx/tests/crashtests/593526.xhtml
rename : testing/marionette/chrome/test.xul => testing/marionette/chrome/test.xhtml
rename : testing/marionette/chrome/test2.xul => testing/marionette/chrome/test2.xhtml
rename : testing/marionette/chrome/test_dialog.xul => testing/marionette/chrome/test_dialog.xhtml
rename : testing/marionette/chrome/test_nested_iframe.xul => testing/marionette/chrome/test_nested_iframe.xhtml
rename : testing/marionette/reftest.xul => testing/marionette/reftest.xhtml
rename : testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xul => testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xhtml
rename : testing/mochitest/browser-harness.xul => testing/mochitest/browser-harness.xhtml
rename : testing/mochitest/chrome/test_chromeGetTestFile.xul => testing/mochitest/chrome/test_chromeGetTestFile.xhtml
rename : testing/mochitest/chrome/test_sample.xul => testing/mochitest/chrome/test_sample.xhtml
rename : testing/mochitest/chrome/test_sanityEventUtils.xul => testing/mochitest/chrome/test_sanityEventUtils.xhtml
rename : testing/mochitest/chrome/test_sanityException.xul => testing/mochitest/chrome/test_sanityException.xhtml
rename : testing/mochitest/chrome/test_sanityException2.xul => testing/mochitest/chrome/test_sanityException2.xhtml
rename : testing/mochitest/chrome/test_sanityManifest.xul => testing/mochitest/chrome/test_sanityManifest.xhtml
rename : testing/mochitest/chrome/test_sanityManifest_pf.xul => testing/mochitest/chrome/test_sanityManifest_pf.xhtml
rename : testing/mochitest/chrome/test_tasks_skip.xul => testing/mochitest/chrome/test_tasks_skip.xhtml
rename : testing/mochitest/chrome/test_tasks_skipall.xul => testing/mochitest/chrome/test_tasks_skipall.xhtml
rename : testing/mochitest/harness.xul => testing/mochitest/harness.xhtml
rename : testing/talos/talos/pageloader/chrome/pageloader.xul => testing/talos/talos/pageloader/chrome/pageloader.xhtml
rename : view/crashtests/382756-1.xul => view/crashtests/382756-1.xhtml
rename : view/crashtests/38589-1.xul => view/crashtests/38589-1.xhtml
extra : moz-landing-system : lando
2019-12-02 19:16:22 +00:00
Thomas Nguyen 14991f5ba2 Bug 1483631 - Prompt with both first party and third party origin if we are delegating permission with allows all feature policy. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D51839

--HG--
extra : moz-landing-system : lando
2019-12-03 16:24:39 +00:00
Thomas Nguyen d48ace2c5f Bug 1483631 - Restrict nested permission requests in ContentPermissionPrompt with permission delegate r=baku,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D47416

--HG--
extra : moz-landing-system : lando
2019-12-03 16:25:51 +00:00
Christian Holler aef146a43a Bug 1597931 - Add libFuzzer instrumentation to extensions/auth/. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D53988

--HG--
extra : moz-landing-system : lando
2019-11-22 14:46:17 +00:00
Christian Holler fcad9f8bf9 Bug 1595692 - Handle missing base64 challenge in NegotiateAuth. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D53989

--HG--
extra : moz-landing-system : lando
2019-11-22 21:17:10 +00:00
Masayuki Nakano b91249c508 Bug 1599318 - `TextEditor` shouldn't put `\r` into its anonymous text node r=m_kato
Starting from bug 1597679, `HTMLTextAreaElement::GetValueInternal()` stops
converting `\r\n` and `\r` with `\n` because it may be in hot path and the scan
cost of `\r` in `nsContentUtils::PlatformToDOMLineBreaks()` is redundant in
most cases.

However, there are still some paths to input `\r`.  This patch makes them
call `nsContentUtils::PlatformToDOMLineBreaks()` if they have not done it.

Differential Revision: https://phabricator.services.mozilla.com/D54906

--HG--
extra : moz-landing-system : lando
2019-11-28 05:51:41 +00:00
Masayuki Nakano 20699e2189 Bug 1597679 - part 2: Make `nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` r=smaug
Sub classes of `nsITextControlElement` are only `HTMLInputElement` and
`HTMLTextAreaElement`. And both base class is
`nsGenericHTMLFormElementWithState`.  Therefore, we can make
`nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` and
make `HTMLInputElement` and `HTMLTextAreaElement` inherit
`nsITextControlElement`.  Then, we can get rid of a lot of QI between
`nsINode`/`nsIContent`/`Element` and `nsITextControlElement` (and note that
some of them in a hot path).

Additionally, this patch renames `nsITextControlElement` to
`mozilla::TextControlElement`.

Differential Revision: https://phabricator.services.mozilla.com/D54330

--HG--
rename : dom/html/nsITextControlElement.h => dom/html/TextControlElement.h
extra : moz-landing-system : lando
2019-11-25 06:35:15 +00:00
Coroiu Cristina 84bf2b6d25 Backed out 3 changesets (bug 1597679) for Android debug build bustage at build/src/dom/base/nsContentAreaDragDrop.cpp
Backed out changeset 6a73b58e0db4 (bug 1597679)
Backed out changeset 90a172eff2de (bug 1597679)
Backed out changeset d4a156cf28ff (bug 1597679)

--HG--
rename : dom/html/TextControlElement.h => dom/html/nsITextControlElement.h
2019-11-24 09:02:53 +02:00
Masayuki Nakano eea1784f2d Bug 1597679 - part 2: Make `nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` r=smaug
Sub classes of `nsITextControlElement` are only `HTMLInputElement` and
`HTMLTextAreaElement`. And both base class is
`nsGenericHTMLFormElementWithState`.  Therefore, we can make
`nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` and
make `HTMLInputElement` and `HTMLTextAreaElement` inherit
`nsITextControlElement`.  Then, we can get rid of a lot of QI between
`nsINode`/`nsIContent`/`Element` and `nsITextControlElement` (and note that
some of them in a hot path).

Additionally, this patch renames `nsITextControlElement` to
`mozilla::TextControlElement`.

Differential Revision: https://phabricator.services.mozilla.com/D54330

--HG--
rename : dom/html/nsITextControlElement.h => dom/html/TextControlElement.h
extra : moz-landing-system : lando
2019-11-24 05:38:02 +00:00
Paul Zuehlcke 97a444cc97 Bug 1597541 - Added pref and disabled nsContentBlocker by default. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D53975

--HG--
extra : moz-landing-system : lando
2019-11-22 14:32:44 +00:00
alwu 0d289c99b1 Bug 1596988 - remove telemetry ping 'AUTOPLAY_SITES_SETTING_CHANGE'. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D53752

--HG--
extra : moz-landing-system : lando
2019-11-19 14:39:16 +00:00
Ehsan Akhgari 659d5a38ee Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53240

--HG--
extra : moz-landing-system : lando
2019-11-17 22:22:34 +00:00
Ehsan Akhgari d3690a33cf Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53239

--HG--
extra : moz-landing-system : lando
2019-11-17 22:22:26 +00:00
Ehsan Akhgari 64828b7697 Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53238

--HG--
extra : moz-landing-system : lando
2019-11-17 22:22:24 +00:00
Ehsan Akhgari d793147c0c Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53237

--HG--
extra : moz-landing-system : lando
2019-11-17 22:22:21 +00:00
Moritz Birghan 975648e245 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-18 13:03:58 +00:00
Noemi Erli 117375bafe Backed out 4 changesets (bug 1596843) for causing nsPermissionManager related failures
Backed out changeset 48577632f4b3 (bug 1596843)
Backed out changeset b9061f93d045 (bug 1596843)
Backed out changeset 691397c2fde6 (bug 1596843)
Backed out changeset 88e8383dc3e4 (bug 1596843)
2019-11-17 23:00:23 +02:00
Ehsan Akhgari ce669bf3af Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53240

--HG--
extra : moz-landing-system : lando
2019-11-17 20:06:11 +00:00
Ehsan Akhgari 5478509264 Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53239

--HG--
extra : moz-landing-system : lando
2019-11-17 20:06:08 +00:00
Ehsan Akhgari c05273a531 Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53238

--HG--
extra : moz-landing-system : lando
2019-11-17 20:06:06 +00:00
Ehsan Akhgari bab3fe707f Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53237

--HG--
extra : moz-landing-system : lando
2019-11-17 20:06:04 +00:00
Ehsan Akhgari 7abf369283 Bug 1595935 - Remove a couple of long expired telemetry probes from the permission manager; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D52762

--HG--
extra : moz-landing-system : lando
2019-11-17 07:22:02 +00:00
Gurzau Raul 9c990aad98 Backed out 4 changesets (bug 1596843) for XPCShellTestsTests build bustage ona CLOSED TREE.
Backed out changeset 69ee727d5b45 (bug 1596843)
Backed out changeset a9827fae8655 (bug 1596843)
Backed out changeset 8b2220bc47af (bug 1596843)
Backed out changeset b10aec041377 (bug 1596843)
2019-11-17 11:07:15 +02:00
Ehsan Akhgari 0ad4207862 Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53240

--HG--
extra : moz-landing-system : lando
2019-11-17 07:23:39 +00:00
Ehsan Akhgari 2e390a7aa7 Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53239

--HG--
extra : moz-landing-system : lando
2019-11-17 07:23:32 +00:00
Ehsan Akhgari a6b7fa0902 Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53238

--HG--
extra : moz-landing-system : lando
2019-11-17 07:23:29 +00:00
Ehsan Akhgari 7664cbc2d4 Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53237

--HG--
extra : moz-landing-system : lando
2019-11-17 07:23:27 +00:00
Valentin Gosu eb1c1972b8 Bug 1595242 - Move the offthread negotiate auth to dispatch to the background thread pool r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D52904

--HG--
extra : moz-landing-system : lando
2019-11-15 19:45:17 +00:00
Andrew McCreight c18473df1d Bug 1596834 - Use forceNewProcess in browser_permmgr_sync.js. r=mconley
Also fix a few typos in comments.

Differential Revision: https://phabricator.services.mozilla.com/D53229

--HG--
extra : moz-landing-system : lando
2019-11-15 17:24:11 +00:00
Michael Kaply fcf89c6721 Bug 1594584 - Marionette test for autoconfig. r=whimboo,kmag
Differential Revision: https://phabricator.services.mozilla.com/D52106

--HG--
extra : moz-landing-system : lando
2019-11-12 18:18:49 +00:00
Thomas Nguyen 17a6860942 Bug 1591113 - Remove support for third-party vibrate r=baku,snorp
Differential Revision: https://phabricator.services.mozilla.com/D52531

--HG--
extra : moz-landing-system : lando
2019-11-12 08:42:02 +00:00
Thomas Nguyen 7e65be9414 Bug 1583142 - Remove third-party "persistent-storage" prompting support r=baku
Differential Revision: https://phabricator.services.mozilla.com/D50908

--HG--
extra : moz-landing-system : lando
2019-11-07 14:29:02 +00:00
Ciure Andrei c5a6643d39 Backed out changeset dde0354521ab (bug 1583142) for causing PermissionDelegateHandler.cpp bustages CLOSED TREE 2019-11-07 14:17:02 +02:00
Thomas Nguyen f431604a62 Bug 1583142 - Remove third-party "persistent-storage" prompting support r=baku
Differential Revision: https://phabricator.services.mozilla.com/D50908

--HG--
extra : moz-landing-system : lando
2019-11-07 11:56:28 +00:00
Coroiu Cristina 27a753cc4a Backed out changeset 96048cce4b80 (bug 1571656) for xpcshell failures at toolkit/components/places/tests/unifiedcomplete/test_autofill_origins.js on a CLOSED TREE 2019-11-06 22:59:45 +02:00
Moritz Birghan 70c7a633fb Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-06 18:07:54 +00:00
Jorg K 376642ff2c Bug 1592922 - Fix typo in autoconfig's prefcalls.js. r=mkaply DONTBUILD
Adding DONTBUILD for a one character change in a string.

Differential Revision: https://phabricator.services.mozilla.com/D51256

--HG--
extra : moz-landing-system : lando
2019-10-31 16:18:57 +00:00
Paul Zuehlcke 7fcc94c765 Bug 1422056 - Put remaining permission userContextId OA stripping behind pref. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50811

--HG--
extra : moz-landing-system : lando
2019-10-30 12:21:14 +00:00
Ehsan Akhgari a8a01884db Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
2019-10-29 01:56:25 +00:00
Arthur Iakab 9c93bb3a7a Backed out 2 changesets (bug 1591803) for causing build bustages on XULAlerts.cpp CLOSED TREE
Backed out changeset 7eff50262110 (bug 1591803)
Backed out changeset c0b6f37d24d2 (bug 1591803)
2019-10-29 03:37:07 +02:00
Ehsan Akhgari 8c1d9bf15d Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
2019-10-28 20:26:21 +00:00
Ehsan Akhgari 05b288d47f Bug 1591746 - Make nsIPermissionManager.getAllForPrincipal() return an Array<> instead of an XPCOM enumerator; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50717

--HG--
extra : moz-landing-system : lando
2019-10-29 01:13:57 +00:00
Arthur Iakab 470c5a07f1 Backed out 2 changesets (bug 1591803) for causing build busatges on PermissionManager.idl. CLOSED TREE
Backed out changeset 060f159fa43d (bug 1591803)
Backed out changeset b53a3d8c408d (bug 1591803)
2019-10-28 22:12:01 +02:00
Ehsan Akhgari f7eef9ebc5 Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
2019-10-28 13:55:56 +00:00
Ehsan Akhgari 9a5d7b4dfa Bug 1589407 - Part 1: Avoid calling nsPermissionManager::GetAllForPrincipal() if no permissions are available in the current process; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D50710

--HG--
extra : moz-landing-system : lando
2019-10-28 10:57:51 +00:00
Rob Wu 57e66afc2a Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D50068

--HG--
extra : moz-landing-system : lando
2019-10-24 12:57:21 +00:00
Rob Wu 1884e2a75a Bug 1589754 - Fix permissions.query in top-level document r=tnguyen
Differential Revision: https://phabricator.services.mozilla.com/D50067

--HG--
extra : moz-landing-system : lando
2019-10-24 12:57:23 +00:00
Paul Zuehlcke 46e33fe965 Bug 1422056 - Added permission manager OA strip test. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D49960

--HG--
extra : moz-landing-system : lando
2019-10-24 14:20:03 +00:00
Paul Zuehlcke c462a0fcba Bug 1422056 - Updated tests to account for permission manager OA stripping. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D48665

--HG--
extra : moz-landing-system : lando
2019-10-24 14:19:57 +00:00
Paul Zuehlcke 7b483252bd Bug 1588461 - Added OA StripAttributes flag for privateBrowsingId. r=johannh,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D49174

--HG--
extra : moz-landing-system : lando
2019-10-24 14:18:54 +00:00
Paul Zuehlcke b68b9d1297 Bug 1422056 - nsPermissionManager: Disabled OA stripping for private browsing and added OA strip prefs. r=johannh,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D48664

--HG--
extra : moz-landing-system : lando
2019-10-25 10:26:45 +00:00
Narcis Beleuzu ba16f78901 Backed out 2 changesets (bug 1589754) for mochitest failures on test_notification_permissions.html CLOSED TREE
Backed out changeset 120203cf34b0 (bug 1589754)
Backed out changeset 49e887cef91d (bug 1589754)

--HG--
extra : rebase_source : 9444ef674a85faec70c0d891caeb59af557d2de7
2019-10-24 15:51:34 +03:00
Rob Wu bcccc1d738 Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D50068

--HG--
extra : moz-landing-system : lando
2019-10-23 18:14:44 +00:00
Rob Wu fcb704f351 Bug 1589754 - Fix permissions.query in top-level document r=tnguyen
Differential Revision: https://phabricator.services.mozilla.com/D50067

--HG--
extra : moz-landing-system : lando
2019-10-23 16:12:13 +00:00
Emilio Cobos Álvarez 698db0028a Bug 1589327 - Remove some other various fennec-dependent code. r=snorp,botond
Some of this may be able to be cleaned up further.

Differential Revision: https://phabricator.services.mozilla.com/D49587

--HG--
extra : moz-landing-system : lando
2019-10-18 18:49:49 +00:00
Ehsan Akhgari dab85e2115 Bug 1588164 - Remove an unused declaration for nsPermissionManager::GetPermissionHashKey; r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D48991

--HG--
extra : moz-landing-system : lando
2019-10-14 09:50:50 +00:00
Emilio Cobos Álvarez 536c1bc0bb Bug 1581467 - Fix checks for display: inline{,-block} which don't account for inline list items. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D48346

--HG--
extra : moz-landing-system : lando
2019-10-12 21:05:16 +00:00
Perry Jiang d42e87a765 Bug 1587365 - Allow multiple callers to wait for permissions r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D49043

--HG--
extra : moz-landing-system : lando
2019-10-12 03:21:41 +00:00
Brian Grinstead 5cfb7798a4 Bug 1586878 - Replace <xul:textbox> with <html:input> in test_add_remove_dictionaries.xul;r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D48419

--HG--
extra : moz-landing-system : lando
2019-10-08 17:13:43 +00:00
Paul Zuehlcke c34871acfc Bug 1402957 - Removed URI based nsIPermissionManager methods. r=johannh,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D47254

--HG--
extra : moz-landing-system : lando
2019-09-27 14:55:53 +00:00
Paul Zuehlcke abeca18f1c Bug 1402957 - Refactored nsIPermissionManager tests to use principals. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D47251

--HG--
rename : extensions/permissions/test/unit/test_permmanager_getAllForURI.js => extensions/permissions/test/unit/test_permmanager_getAllForPrincipal.js
extra : moz-landing-system : lando
2019-09-27 09:48:39 +00:00
Sebastian Streich 88670a47e9 Bug 1580782 - Change Callsites to use nsIPrincipal->SchemeIs r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D45654

--HG--
extra : moz-landing-system : lando
2019-09-26 10:47:16 +00:00
David Major 8f0fcd819e Bug 1583332 - Define HUNSPELL_STATIC to silence warnings on Windows about importing intra-DLL code r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D47069

--HG--
extra : moz-landing-system : lando
2019-09-26 09:19:22 +00:00
Paul Zuehlcke 7dbb6cb72e Bug 1574473 - Updated nsContentBlocker::TestPermission to use LegacyTestPermissionFromURI. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D46180

--HG--
extra : moz-landing-system : lando
2019-09-19 17:06:29 +00:00
Paul Zuehlcke 2189ac4496 Bug 1574469 - Implemented nsPermissionManager::LegacyTestPermissionFromURI for nsIURI queries with origin attributes. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45847

--HG--
extra : moz-landing-system : lando
2019-09-19 17:07:22 +00:00
Thomas Nguyen cf867199bc Bug 1560570- FeaturePolicy should be considered when permissions.query() is called r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D44210

--HG--
extra : moz-landing-system : lando
2019-09-21 08:38:26 +00:00
Henri Sivonen c193518677 Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D43957

--HG--
extra : moz-landing-system : lando
2019-09-18 08:26:34 +00:00
Emma Malysz 6a694db9bd Bug 599996, remove nsPermissionManager::Import to avoid main-thread IO r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D45921

--HG--
extra : moz-landing-system : lando
2019-09-17 15:22:55 +00:00
Makoto Kato 50895a5db7 Bug 1571339 - Don't use nsTextFragment::AppendTo to get string in TextNodeContainsDOMWordSeparator. r=masayuki
Actually, spellchecker always allocates the heap to get text from text node. But it is unnecessary to allocate another heap here since `WordSplitState` walks text only and it is stack class.

If text is in '<textarea>', text node may be too large, so we shouldn't allocate memory to walk character in `WordSplitState` if possible. Because `TextNodeContainsDOMWordSeparator` will be called per input.

And `mWordUtil` is unused, so we should remove it.

Differential Revision: https://phabricator.services.mozilla.com/D42257

--HG--
extra : moz-landing-system : lando
2019-09-09 03:42:45 +00:00
Tom Ritter d922064696 Bug 1547519 - Rename NS_STRINGIFY to MOZ_STRINGIFY, move to mfbt, and unify stragglers r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D39961

--HG--
extra : moz-landing-system : lando
2019-09-04 02:40:32 +00:00
Dylan Roeh 9f71be1805 Bug 1572191 - Prevent nsPermissionManager from persisting certain permissions to disk under GeckoView. r=snorp,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D43759

--HG--
extra : moz-landing-system : lando
2019-08-30 21:41:47 +00:00
Ehsan Akhgari c771ae8334 Bug 1572240 - Part 6: Remove nsIPermissionManager.testPermissionOriginNoSuffix; r=baku
This is now dead code which will be kept alive by the vtable,
and introduces needless overhead inside the permission manager.

Differential Revision: https://phabricator.services.mozilla.com/D42207

--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:47 +00:00
Ciure Andrei 9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan 240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Paul Zuehlcke f2675da6d6 Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41028

--HG--
extra : moz-landing-system : lando
2019-08-15 14:32:46 +00:00
Ciure Andrei b454daea7a Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail CLOSED TREE
Backed out changeset 87305e83174e (bug 1531303)
Backed out changeset 0c75c3bac00b (bug 1531303)
Backed out changeset 865c2a5d40da (bug 1531303)
2019-08-14 13:07:55 +03:00
Paul Zuehlcke 160cf2c1df Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41028

--HG--
extra : moz-landing-system : lando
2019-08-14 08:36:41 +00:00
Tom Schuster 0e913c22c4 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
2019-08-07 19:49:40 +00:00
Cosmin Sabou c3430326e6 Backed out changeset ca88862d6b63 (bug 1558915) for causing build bustages on StartupCacheUtils. CLOSED TREE 2019-08-07 13:20:32 +03:00
Tom Schuster 8bc1f5ada8 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
2019-08-07 09:36:56 +00:00
Razvan Maries eedbf1137f Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
Tom Schuster 03c7998ef2 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
2019-08-06 20:19:41 +00:00
Makoto Kato 79bf4210ee Bug 1565919 - Don't separate words by contextual-based character. r=Ehsan
Original regression was by bug 1362858, and bug 1418629 wasn't enough to fix.

By bug 1362858, we use `CHAR_CLASS_SEPARATOR` in additional to DOM word separator. But some characters such as single quote, `@` and etc are `CHAR_CLASS_SEPARATOR`, so we may check spell by incomplete word.

We shouldn't separate word by characters that is email part, URL part or conditional punctuation.

And I also update test cases for this situation. `<textarea>` is better for spell checking since it can has multiple anonymous text nodes.

Differential Revision: https://phabricator.services.mozilla.com/D39829

--HG--
extra : moz-landing-system : lando
2019-08-03 13:44:56 +00:00
Jorg K 864c351bc8 Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki 2019-08-02 10:49:17 +02:00
Kris Maglione 0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Gurzau Raul 21df1f7413 Merge inbound to mozilla-central. a=merge 2019-07-17 06:48:50 +03:00
Mirko Brodesser 8135a5859f Bug 1566046: move `nsContentUtils::ContentIsShadowIncludingDescendantOf` to `nsINode::IsShadowIncludingInclusiveDescendantOf`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D38079
2019-07-16 09:25:02 +02:00
Noemi Erli af897e281a Merge inbound to mozilla-central. a=merge 2019-07-16 00:42:51 +03:00
Mirko Brodesser 2f40f072ab Bug 1565584: move `nsIContentUtils::ContentIsDescendantOf` to `nsINode::IsInclusiveDescendantOf`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D37880
2019-07-15 10:02:21 +02:00
Barret Rennie c1d06a6c0c Bug 1289211 - Rename InfallibleTArray to nsTArray in extensions/spellcheck/ r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D36952

--HG--
extra : moz-landing-system : lando
2019-07-10 03:28:47 +00:00
Boris Zbarsky 5062731c15 Bug 1565688. Remove unused IOService arg from NS_NewURI. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D37968

--HG--
extra : moz-landing-system : lando
2019-07-15 13:39:51 +00:00
Sylvestre Ledru e77bfc655d Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D38057

--HG--
extra : moz-landing-system : lando
2019-07-16 07:33:44 +00:00
Ryan VanderMeulen d4d246dca3 Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D15652

--HG--
extra : moz-landing-system : lando
2019-07-03 16:18:23 +00:00
Jonathan Kingston 31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Alex Catarineu dbce01f2ff Bug 467035 - Add new internal DTD content types r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35232

--HG--
extra : moz-landing-system : lando
2019-07-03 17:28:25 +00:00
Sylvestre Ledru fc2eb5393c Bug 1562642 - Part 2 - Add missing MPL2 headers r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37146

--HG--
extra : moz-landing-system : lando
2019-07-08 09:27:47 +00:00
Victor Porof 5af464dcc4 Bug 1561435 - Format extensions/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35902

--HG--
extra : source : 31cb194f2a6651332aa71a41c0f06a29daf8a186
2019-07-05 10:46:07 +02:00
Mirko Brodesser 6b67de025f Bug 1562876: rename `Selection::RemoveRange` to `Selection::RemoveRangeAndUnselectFramesAndNotifyListeners`. r=smaug
The name of the corresponding webidl interface of course remains unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D36607
2019-07-03 13:26:14 +02:00
Mirko Brodesser 63b4627d28 Bug 1562876: rename `Selection::AddRange` to `Selection::AddRangeAndSelectFramesAndNotifyListeners`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D36602
2019-07-03 13:26:13 +02:00
Masayuki Nakano da61ea3112 Bug 1444847 - part 3: Create `RangeUtils` to place public static methods of `nsRange` r=smaug
Some `nsRange` static methods are useful in `StaticRange` and some of them
are used in a lot of places but not related to `nsRange` directly.  This
patch moves them into new static method only class, `mozilla::RangeUtils`.

Differential Revision: https://phabricator.services.mozilla.com/D35142

--HG--
extra : moz-landing-system : lando
2019-06-28 07:48:07 +00:00
Makoto Kato 5f9abd3366 Bug 1444847 - part 1: Create `mozilla::dom::AbstractRange` r=smaug
This patch is based on the patch created by Makoto Kato-san.

`Range` and `StaticRange` have common base interface, `AbstractRange`.
https://dom.spec.whatwg.org/#abstractrange

This interface has simply returns `startContainer`, `endContainer`,
`startOffset`, `endOffset` and `collapsed`.

Different from the original patch's approach, this patch moves related
members in `nsRange` to `AbstractRange` since this approach avoids
virtual call cost.  Additionally, this patch makes them not throw as
declared by the spec.  As far as I know, the destruction cost of
`ErrorResult` may appear in profile so that we should avoid creating
the instance if we can avoid it.

Unfortunately, the instance size of `nsRange` becomes larger with this
patch.  The size is changed from 176 to 184.  I.e., now, `nsRange`
requires bigger chunk.

Differential Revision: https://phabricator.services.mozilla.com/D35140

--HG--
extra : moz-landing-system : lando
2019-06-28 07:46:35 +00:00
Makoto Kato cb97dec989 Bug 1560517 - Update LICENSE, README and license.hunspell to 1.6.1 r=RyanVM
No one includes `license.hunspell`, so we don't need our custimze block (`#include "config.h"`)

Also, some files isn't updated to 1.6.1, so we should update it.

Depends on D35516

Differential Revision: https://phabricator.services.mozilla.com/D35517

--HG--
extra : moz-landing-system : lando
2019-06-21 14:26:53 +00:00
Makoto Kato e20f6f80c7 Bug 1560517 - Add update script and patch files for hunspell library r=masayuki
Add `update.sh` script and patch files to update hunspell library easily.

Differential Revision: https://phabricator.services.mozilla.com/D35516

--HG--
extra : moz-landing-system : lando
2019-06-21 18:57:35 +00:00
Boris Zbarsky 9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Boris Zbarsky dc2b7685d7 Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D33908

--HG--
extra : moz-landing-system : lando
2019-06-06 06:59:37 +00:00
Boris Zbarsky d0cff2d0c6 Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D33744

--HG--
extra : moz-landing-system : lando
2019-06-05 12:57:32 +00:00