Граф коммитов

59 Коммитов

Автор SHA1 Сообщение Дата
Sylvestre Ledru fde06f6d21 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila 964cca3198 Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru 5f29324f60 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Andi-Bogdan Postelnicu 30d32f4fc7 Bug 1671641 - Make `dom/flex` buildable outside of `unified-build` environment. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D94933
2020-10-28 09:28:50 +00:00
Ricky Stewart 02a7b4ebdf Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart c0cea3b0fa Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 50762dacab Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Botond Ballo 948cec1b06 Bug 1667594 - Avoid including nsLayoutUtils.h in nsContainerFrame.h. r=emilio
nsContainerFrame.h was only using the enum nsLayoutUtils::IntrinsicISizeType,
which this patch moves to LayoutConstants.h instead.

Depends on D91505

Differential Revision: https://phabricator.services.mozilla.com/D91506
2020-09-26 18:19:14 +00:00
Brad Werth 26175c43c6 Bug 1648774 Part 2: Add a test that display:flex elements generate computed flex info. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D84627
2020-07-23 20:48:04 +00:00
Simon Giesecke d39b639f56 Bug 1652942 - Remove some unnecessary includes of Element.h. r=smaug
Depends on D83632

Differential Revision: https://phabricator.services.mozilla.com/D83633
2020-07-15 13:55:24 +00:00
Ting-Yu Lin 48fdff53fc Bug 1639053 - Remove the ability to reverse axes internally for nsFlexContainerFrame. r=dholbert
The ability to reverse axes internally was added in bug 983427, but it
turns out not to be used.

test_flex_lines.html needs to be modified because those expected cross
values are written as if the flex lines are physically in top-to-bottom
order (due to we reversed the axes internally).

Now we don't reverse the internal axes, the order of the flex lines
becomes bottom-to-top due to "flex-wrap: wrap-reverse". The crossStart
coordinate begins from the flex container's bottom end edge, and it
increases from bottom to the top to the flex container's top end
edge. (Note the flex container has 42px height.)

Differential Revision: https://phabricator.services.mozilla.com/D75887
2020-05-19 21:13:35 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Brad Werth 9521ad6e9c Bug 1563163 Part 1: Make Flex::Flex gracefully handle frames without FlexContainerInfo structures. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D44283

--HG--
extra : moz-landing-system : lando
2019-08-30 23:16:09 +00:00
Shashank kaushik c329f1cc44 Bug 1532937 - Enable ESLint for dom/flex and dom/grid (manual changes). r=Standard8,smaug
Depends on D33345

Differential Revision: https://phabricator.services.mozilla.com/D33352

--HG--
extra : moz-landing-system : lando
2019-06-03 10:35:57 +00:00
Shashank kaushik 3ebe62f954 Bug 1532937 - Enable ESLint for dom/flex and dom/grid (automatic changes). r=Standard8,smaug
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D33345

--HG--
extra : moz-landing-system : lando
2019-06-03 10:42:12 +00:00
Brian Grinstead 6515f97bcb Bug 1544322 - Part 1 - Remove the [type] attribute for one-liner <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 1` argument.

Differential Revision: https://phabricator.services.mozilla.com/D26812

--HG--
extra : moz-landing-system : lando
2019-04-15 20:56:58 +00:00
Brad Werth 4f7748eb5d Bug 1521604 Part 3: Add a test of parentFlexElement. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D17433

--HG--
extra : moz-landing-system : lando
2019-02-01 22:30:45 +00:00
Sylvestre Ledru 265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Mark Banner b1c872942c Bug 1508980 - Add more .eslintrc.js files for dom/ and update .eslintignore. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D12529

--HG--
extra : moz-landing-system : lando
2018-11-21 14:27:27 +00:00
Brad Werth 0bbbba0715 Bug 1506687 Part 2: Add a test of FlexItemValues frameRect property. r=dholbert
Depends on D12182

Differential Revision: https://phabricator.services.mozilla.com/D12183

--HG--
extra : source : f93f179fb3b46ea0b3612c21db6cf0a044c03ec0
2018-11-17 00:58:26 +00:00
Brad Werth 346bc8427e Bug 1506687 Part 1: Make FlexItemValues also provide the item's frame rect. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D12182

--HG--
extra : source : d8230f3fdd2c3ecea4771ebe98c83be6e3ebcbfc
2018-11-17 00:56:51 +00:00
Cosmin Sabou 06a105eed0 Backed out 2 changesets (bug 1506687) for causing mochitest mass failures. CLOSED TREE
Backed out changeset f93f179fb3b4 (bug 1506687)
Backed out changeset d8230f3fdd2c (bug 1506687)
2018-11-17 05:05:53 +02:00
Brad Werth 4476e0d1a3 Bug 1506687 Part 2: Add a test of FlexItemValues frameRect property. r=dholbert
Depends on D12182

Differential Revision: https://phabricator.services.mozilla.com/D12183

--HG--
extra : moz-landing-system : lando
2018-11-17 00:58:26 +00:00
Brad Werth cae2b12074 Bug 1506687 Part 1: Make FlexItemValues also provide the item's frame rect. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D12182

--HG--
extra : moz-landing-system : lando
2018-11-17 00:56:51 +00:00
Cosmin Sabou 5394c8a6ca Backed out 3 changesets (bug 1506687) for devtools failures on browser_flexbox_sizing_info_for_text_nodes. CLOSED TREE
Backed out changeset 2788a93e179a (bug 1506687)
Backed out changeset 1c3baa04d4ce (bug 1506687)
Backed out changeset c50af93cfc84 (bug 1506687)
2018-11-15 20:01:52 +02:00
Brad Werth 92eac4e18e Bug 1506687 Part 3: Update test expectations. r=dholbert
Depends on D11783

Differential Revision: https://phabricator.services.mozilla.com/D11784

--HG--
extra : moz-landing-system : lando
2018-11-15 16:20:58 +00:00
Brad Werth 5e72dc5a5b Bug 1506687 Part 2: Make FlexItemValues also provide the item's position and size. r=dholbert
Depends on D11782

Differential Revision: https://phabricator.services.mozilla.com/D11783

--HG--
extra : moz-landing-system : lando
2018-11-15 16:20:40 +00:00
Brad Werth 6d53b458a3 Bug 1498273 Part 4: Add tests of FlexItem clampState. r=dholbert
Depends on D9447

Differential Revision: https://phabricator.services.mozilla.com/D8776

--HG--
extra : moz-landing-system : lando
2018-10-25 00:14:40 +00:00
Brad Werth 1600580027 Bug 1498273 Part 3: Define and set ComputedFlexItemInfo::mClampState. r=dholbert
Depends on D9727

Differential Revision: https://phabricator.services.mozilla.com/D9728

--HG--
extra : moz-landing-system : lando
2018-10-24 23:47:23 +00:00
Brad Werth 23c8887384 Bug 1498273 Part 1: Updated Flex.webidl to add a per-item clamp state attribute. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D8769

--HG--
extra : moz-landing-system : lando
2018-10-24 23:46:16 +00:00
Brad Werth e7dc869f77 Bug 1501109 Part 2: Update test expectations for flex line growth state. r=dholbert
Depends on D9454

Differential Revision: https://phabricator.services.mozilla.com/D9455

--HG--
extra : moz-landing-system : lando
2018-10-23 16:24:00 +00:00
Brad Werth 29992e3858 Bug 1501109 Part 1: Change Flex API growth state to match layout algorithm, and use enums from webidl. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D9454

--HG--
extra : moz-landing-system : lando
2018-10-23 16:23:37 +00:00
Daniel Holbert a597621867 Bug 1500608: Don't skip the flex-item early-freeze for devtools after all. r=bradwerth
This patch basically reverts the functional part of changeset 52bd865d757c.
I'd optimistically hoped we could skip this early-freeze in order to compute &
report a bit more "potential flexing" information via devtools.  Bbut it turns
out that breaks assertions & produces bogus information for flex items whose
base size vs. min/max-clamped "hypothetical" sizes are very
different. (Specifically: it produces nonsense for flex items whose base sizes,
if unclamped, would reverse the directionality of flexing.)

Differential Revision: https://phabricator.services.mozilla.com/D9304

--HG--
extra : moz-landing-system : lando
2018-10-19 22:05:46 +00:00
Daniel Holbert fd3bb50eac Bug 1499875 part 2: Give mochitest test_flex_items.html some tests for a flex container that has multiple passes of flex-grow + clamping. r=bradwerth
Depends on D9152

Differential Revision: https://phabricator.services.mozilla.com/D9169

--HG--
extra : moz-landing-system : lando
2018-10-19 06:04:26 +00:00
Daniel Holbert 6e01c82c66 Bug 1499875 part 1: Adjust existing tests/content in test_flex_items.html to prepare for additional flex containers to be added. r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D9152

--HG--
extra : moz-landing-system : lando
2018-10-18 23:47:47 +00:00
Daniel Holbert 8d0f407881 Bug 1498281: Make flexbox devtools API report actual flex base size (not its min/max-clamped version). r=bradwerth
This patch also updates the expectations in the mochitest test_flex_items.html.
Before this commit, the test (incorrectly) expected the mainBaseSize API to
return some items' *final sizes*, because that's what our implementation did
return, up until now. As of this patch, that API will now return the item's
actual flex base size, which means the text expectations need to change.

I'm also adding a new flex item to the test, to exercise a formerly-untested
scenario.  And to accommodate this new item, I'm also doubling the width of
the flex container to be sure there's plenty of space.

Differential Revision: https://phabricator.services.mozilla.com/D8476

--HG--
extra : moz-landing-system : lando
2018-10-18 23:45:51 +00:00
Daniel Holbert f82f9bd967 Bug 1499542 part 3: Give test_flex_items.html an item that's trivially clamped to small max-size. r=bradwerth
Depends on D9018

Differential Revision: https://phabricator.services.mozilla.com/D9019

--HG--
extra : moz-landing-system : lando
2018-10-17 19:15:15 +00:00
Brad Werth b7374a380b Bug 1497589 Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert
Depends on D8617

Differential Revision: https://phabricator.services.mozilla.com/D8618

--HG--
extra : moz-landing-system : lando
2018-10-17 20:23:27 +00:00
Brad Werth e2f5a79f00 Bug 1497589 Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert
Depends on D8616

Differential Revision: https://phabricator.services.mozilla.com/D8617

--HG--
extra : moz-landing-system : lando
2018-10-17 20:23:09 +00:00
Brad Werth 55045f0ce3 Bug 1497589 Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D8616

--HG--
extra : moz-landing-system : lando
2018-10-17 20:22:46 +00:00
Brad Werth 04ba5f13c0 Bug 1497589 Part 2: Rename Flex API classes to avoid namespace collision with nsFlexContainerFrame classes. r=dholbert
Depends on D9022

Differential Revision: https://phabricator.services.mozilla.com/D9023

--HG--
rename : dom/flex/FlexItem.cpp => dom/flex/FlexItemValues.cpp
rename : dom/flex/FlexItem.h => dom/flex/FlexItemValues.h
rename : dom/flex/FlexLine.cpp => dom/flex/FlexLineValues.cpp
rename : dom/flex/FlexLine.h => dom/flex/FlexLineValues.h
extra : moz-landing-system : lando
2018-10-17 20:22:26 +00:00
Daniel Holbert d2eff8f7ac Bug 1499569: Rewrite test_flex_items.html to be simpler & easier to extend. r=bradwerth
Primary changes:
 - Rewrap some lines that are too long.
 - Adjust some failure-messages with s/has/should have/ etc.
 - Replace 'nearlyEqual' function with the standard mochitest
   'isfuzzy()' API (which is like 'is()' with an extra epsilon arg)
 - Remove dependence on hardcoded element IDs, and simply walk over the
   flex container's children in order instead (still noting each child node
   and making sure it matches the node in the flex API).

Differential Revision: https://phabricator.services.mozilla.com/D8933

--HG--
extra : moz-landing-system : lando
2018-10-17 21:42:54 +00:00
Csoregi Natalia fe9fa07de9 Backed out changeset daf3e491e6ff (bug 1499569) for test_flex_items.html failures. CLOSED TREE 2018-10-17 09:44:28 +03:00
Daniel Holbert a8a1b87c80 Bug 1499569: Rewrite test_flex_items.html to be simpler & easier to extend. r=bradwerth
Primary changes:
 - Rewrap some lines that are too long.
 - Adjust some failure-messages with s/has/should have/ etc.
 - Replace 'nearlyEqual' function with the standard mochitest
   'isfuzzy()' API (which is like 'is()' with an extra epsilon arg)
 - Remove dependence on hardcoded element IDs, and simply walk over the
   flex container's children in order instead (still noting each child node
   and making sure it matches the node in the flex API).

Differential Revision: https://phabricator.services.mozilla.com/D8933

--HG--
extra : moz-landing-system : lando
2018-10-17 03:14:10 +00:00
Daniel Holbert fccedb8262 Bug 1477856: In flexbox devtools API, report max-width:none as +infinity. r=bradwerth
Previously we were just directly converting this nscoord sentinel-value representation (NS_UNCONSTRAINEDSIZE) into CSS pixels and producing a particular bogus number of pixels.

Differential Revision: https://phabricator.services.mozilla.com/D2432

--HG--
extra : moz-landing-system : lando
2018-07-27 21:38:46 +00:00
Jeff Gilbert 5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Boris Zbarsky 8b9400c98b Bug 1455676 part 19. Remove some remaining nsIDOMNode uses. r=qdot 2018-05-29 22:58:50 -04:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00