Gijs Kruitbosch
4f3914f12d
Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem
...
Differential Revision: https://phabricator.services.mozilla.com/D68465
--HG--
extra : moz-landing-system : lando
2020-03-27 16:05:00 +00:00
ffxbld
d1bfa2330a
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D68386
--HG--
extra : moz-landing-system : lando
2020-03-26 13:53:08 +00:00
Sam Foster
2db8ec19f5
Bug 1622514 - Move OSKeyStore.jsm into toolkit/modules. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D68133
--HG--
rename : browser/modules/OSKeyStore.jsm => toolkit/modules/OSKeyStore.jsm
rename : browser/modules/test/OSKeyStoreTestUtils.jsm => toolkit/modules/tests/modules/OSKeyStoreTestUtils.jsm
rename : browser/modules/test/unit/test_osKeyStore.js => toolkit/modules/tests/xpcshell/test_osKeyStore.js
extra : moz-landing-system : lando
2020-03-25 08:21:24 +00:00
Gijs Kruitbosch
0377d8eece
Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
...
By and large, this change accomplishes two things:
1. Run db.close() in finally clauses so that even if db access fails, we close
our connections. It also tries to avoid waiting on other, non-DB operations
before calling close, to avoid the DB connection needlessly hanging around.
2. Intercept all async database operations from the remote settings client to
kinto and ensuring they complete before the end of `profile-before-change`.
Any operations started after Services.startup.isShuttingDown (so after
quit/restart is initiated by the user) will throw. Operations started
beforehand are put in a set of operations, and remove themselves once
complete. We AsyncShutdown block on that set of operations completing.
Differential Revision: https://phabricator.services.mozilla.com/D66995
--HG--
extra : moz-landing-system : lando
2020-03-24 14:55:41 +00:00
Andreea Pavel
3550cada92
Backed out changeset 3b7ccffc0546 (bug 1598924) for permafailing bug 1621759 on a CLOSED TREE
2020-03-23 21:37:55 +02:00
Gijs Kruitbosch
457afaaba0
Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
...
By and large, this change accomplishes two things:
1. Run db.close() in finally clauses so that even if db access fails, we close
our connections. It also tries to avoid waiting on other, non-DB operations
before calling close, to avoid the DB connection needlessly hanging around.
2. Intercept all async database operations from the remote settings client to
kinto and ensuring they complete before the end of `profile-before-change`.
Any operations started after Services.startup.isShuttingDown (so after
quit/restart is initiated by the user) will throw. Operations started
beforehand are put in a set of operations, and remove themselves once
complete. We AsyncShutdown block on that set of operations completing.
Differential Revision: https://phabricator.services.mozilla.com/D66995
--HG--
extra : moz-landing-system : lando
2020-03-23 16:35:08 +00:00
ffxbld
688cc76dfc
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D67852
--HG--
extra : moz-landing-system : lando
2020-03-23 13:43:31 +00:00
Amogh Kerigond
d1ba6e0606
Bug 1622666 - Removes redundant access specifier r=froydnj
...
Depends on D67739
Differential Revision: https://phabricator.services.mozilla.com/D67767
--HG--
extra : moz-landing-system : lando
2020-03-22 11:58:15 +00:00
Mathieu Leplatre
924826ecef
Bug 1623481 - Fix intermittent failure on Remote Settings Database open r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D67454
--HG--
extra : moz-landing-system : lando
2020-03-20 09:46:44 +00:00
Mark Banner
c2e698bc85
Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D55464
--HG--
extra : moz-landing-system : lando
2020-03-19 14:11:40 +00:00
Sylvestre Ledru
be18fd4dba
Bug 1622328
- add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr
...
Differential Revision: https://phabricator.services.mozilla.com/D67319
--HG--
extra : moz-landing-system : lando
2020-03-19 13:47:51 +00:00
ffxbld
8fdcf8990c
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D67475
--HG--
extra : moz-landing-system : lando
2020-03-19 13:43:29 +00:00
Sylvestre Ledru
200b20eb5c
Bug 1622328
- fxa_utils.js: Add the license r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D66831
--HG--
extra : moz-landing-system : lando
2020-03-14 01:09:01 +00:00
Mathieu Leplatre
d8a808669c
Bug 1620185 - Fetch metadata and records in parallel r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D67142
--HG--
extra : moz-landing-system : lando
2020-03-17 20:26:01 +00:00
Mathieu Leplatre
24fcb6ab53
Bug 1620185 - Improve behaviour when signature is bad after retry r=glasserc
...
When the signature verification fails after retry we don't want to apply the changes, and if possible we want to leave the local data as it was before sync.
Differential Revision: https://phabricator.services.mozilla.com/D67139
--HG--
extra : moz-landing-system : lando
2020-03-17 20:24:01 +00:00
Mathieu Leplatre
c74311c266
Bug 1620185 - Import IndexedDB code from kinto.js r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66752
--HG--
extra : moz-landing-system : lando
2020-03-17 20:23:31 +00:00
Mathieu Leplatre
7ddb40d7b9
Bug 1620185 - Move DB to separate file r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66751
--HG--
extra : moz-landing-system : lando
2020-03-17 20:23:00 +00:00
Mathieu Leplatre
fbd73a9215
Bug 1620185 - Simplify CanonicalJSON of records r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66750
--HG--
extra : moz-landing-system : lando
2020-03-17 20:22:32 +00:00
Mathieu Leplatre
bc6e54afaa
Bug 1620185 - Remove usage of .openCollection() in other modules r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66749
--HG--
extra : moz-landing-system : lando
2020-03-17 20:21:54 +00:00
Mathieu Leplatre
aaf32a2504
Bug 1620185 - Remove usage of .openCollection() r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66632
--HG--
extra : moz-landing-system : lando
2020-03-17 20:20:46 +00:00
Mathieu Leplatre
47e09d0ba8
Bug 1620185 - Remove usage of kinto.js collection instance r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66630
--HG--
extra : moz-landing-system : lando
2020-03-17 20:20:05 +00:00
Mathieu Leplatre
76e09115f9
Bug 1620185 - Remove usage of kinto.js collection methods r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66629
--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:38 +00:00
Mathieu Leplatre
fbc12fc39d
Bug 1620185 - Reuse code from signature failure retry r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66412
--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:28 +00:00
Mathieu Leplatre
6d01f4e707
Bug 1620185 - Replace pullMetadata() with low level code r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66411
--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:23 +00:00
Mathieu Leplatre
5b64d20ae2
Bug 1620185 - Replace .sync() by underlying calls r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D66409
--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:20 +00:00
Thom Chiovoloni
0b02e4870b
Bug 1621806 - Reduce frequency of client-side extension-storage syncs. r=markh
...
Reduce frequency of client-side extension-storage syncs
Differential Revision: https://phabricator.services.mozilla.com/D66650
--HG--
extra : moz-landing-system : lando
2020-03-17 19:36:58 +00:00
ffxbld
5102396177
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D66963
--HG--
extra : moz-landing-system : lando
2020-03-16 13:48:38 +00:00
Christoph Kerschbaumer
af63b804a6
Bug 1508292: Implement Sec-Fetch-*. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D66283
--HG--
extra : source : a0508ae6c037928981ac2733860b6ec84d7069ec
2020-03-14 17:28:41 +00:00
Brindusan Cristian
11cc2fbf73
Backed out changeset a0508ae6c037 (bug 1508292) for sm bustage.
...
--HG--
extra : rebase_source : 0db77cae1e8115c19dbaa6d556b30890909ed996
2020-03-14 22:40:55 +02:00
Christoph Kerschbaumer
bc8997ee18
Bug 1508292: Implement Sec-Fetch-*. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D66283
--HG--
extra : moz-landing-system : lando
2020-03-14 17:28:41 +00:00
Ed Lee
acb960676c
Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
...
Differential Revision: https://phabricator.services.mozilla.com/D66128
--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Vlad Filippov
b2e173a799
Bug 1590946 - Remove `service=sync` from account management links. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D63737
--HG--
extra : moz-landing-system : lando
2020-03-13 20:53:12 +00:00
Anurag Aggarwal
45b0a79f3d
Bug 1536103 - Fixed mach doc warnings.r=firefox-source-docs-reviewers,championshuttler,sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D66462
--HG--
extra : moz-landing-system : lando
2020-03-12 17:20:15 +00:00
ffxbld
7207d7f765
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D66614
--HG--
extra : moz-landing-system : lando
2020-03-12 17:07:37 +00:00
Jared Wein
11ed78ea66
Bug 1194529 - Move OSKeyStore.jsm to browser/modules since it is no longer used by just Form Autofill. r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D61743
--HG--
rename : browser/extensions/formautofill/OSKeyStore.jsm => browser/modules/OSKeyStore.jsm
rename : browser/extensions/formautofill/test/fixtures/OSKeyStoreTestUtils.jsm => browser/modules/test/OSKeyStoreTestUtils.jsm
rename : browser/extensions/formautofill/test/unit/test_osKeyStore.js => browser/modules/test/unit/test_osKeyStore.js
extra : moz-landing-system : lando
2020-03-12 14:47:18 +00:00
Mathieu Leplatre
9296f12f2b
Bug 1621308 - Give up client sync early during shutdown r=glasserc
...
A significant amount of clients report OFFLINE_ERROR during shutdown.
Instead of adding a new uptake status to be reported when detecting offline during shutdown (eg. INTERRUPTED, not *_ERROR), we do nothing and give up immediately.
Differential Revision: https://phabricator.services.mozilla.com/D66271
--HG--
extra : moz-landing-system : lando
2020-03-10 19:10:18 +00:00
Florian Quèze
2c3a1ae0be
Bug 1620630 - The OS.File worker should record markers indicating which operation it is performing on which file, r=Yoric.
...
Differential Revision: https://phabricator.services.mozilla.com/D65747
--HG--
extra : moz-landing-system : lando
2020-03-11 14:22:06 +00:00
Dorel Luca
7d0c94a0e9
Backed out 8 changesets (bug 1506602, bug 1194529) for Browser-chrome failures in browser/browser_aaa_eventTelemetry_run_first.js. CLOSED TREE
...
Backed out changeset 0848e3945164 (bug 1506602)
Backed out changeset a8b80ec1830e (bug 1506602)
Backed out changeset e83a89eb5007 (bug 1194529)
Backed out changeset 7bf0a8463e53 (bug 1194529)
Backed out changeset 5b5cbd52e30f (bug 1194529)
Backed out changeset 55c38d92f65a (bug 1194529)
Backed out changeset 3242adb0ff8e (bug 1194529)
Backed out changeset c2f10d341da8 (bug 1194529)
--HG--
rename : browser/modules/OSKeyStore.jsm => browser/extensions/formautofill/OSKeyStore.jsm
rename : browser/modules/test/OSKeyStoreTestUtils.jsm => browser/extensions/formautofill/test/fixtures/OSKeyStoreTestUtils.jsm
rename : browser/modules/test/unit/test_osKeyStore.js => browser/extensions/formautofill/test/unit/test_osKeyStore.js
2020-03-11 01:48:36 +02:00
Jared Wein
2642cc0cdb
Bug 1194529 - Move OSKeyStore.jsm to browser/modules since it is no longer used by just Form Autofill. r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D61743
--HG--
rename : browser/extensions/formautofill/OSKeyStore.jsm => browser/modules/OSKeyStore.jsm
rename : browser/extensions/formautofill/test/fixtures/OSKeyStoreTestUtils.jsm => browser/modules/test/OSKeyStoreTestUtils.jsm
rename : browser/extensions/formautofill/test/unit/test_osKeyStore.js => browser/modules/test/unit/test_osKeyStore.js
extra : moz-landing-system : lando
2020-03-10 20:00:55 +00:00
Daniel Varga
df858c9057
Backed out changeset 6aaa835ae0eb (bug 1620630) for causing xpcshell failures at osfile/tests/xpcshell/test_osfile_closed.js
...
CLOSED TREE
2020-03-10 21:08:48 +02:00
Florian Quèze
5345d6fcbb
Bug 1620630 - The OS.File worker should record markers indicating which operation it is performing on which file, r=Yoric.
...
Differential Revision: https://phabricator.services.mozilla.com/D65747
--HG--
extra : moz-landing-system : lando
2020-03-10 17:04:10 +00:00
ffxbld
7a35fa9703
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2020-03-09 15:41:51 +00:00
Mark Banner
2c4e35b0a6
Bug 1620218
- Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65509
--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mark Banner
15cfe23b88
Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D65703
--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Mathieu Leplatre
2d4875b904
Bug 1618491 - Detect shutdown during Remote Settings sync r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D65318
--HG--
extra : moz-landing-system : lando
2020-03-05 18:06:52 +00:00
ffxbld
39c3d77141
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D65516
--HG--
extra : moz-landing-system : lando
2020-03-05 17:17:28 +00:00
Andrea Marchesini
9bc071f817
Bug 1619875 - Remove the remaining of the prompting code in the cookie-world, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D65289
--HG--
extra : moz-landing-system : lando
2020-03-04 21:25:33 +00:00
Mathieu Leplatre
da32d01a9d
Bug 1619569 - Fix Uptake events test on beta merge r=glasserc
...
The test passes on nightly because the condition actually checks specifically for nightly. On non-nightly the test fails because although it mocks the channel with withFakeChannel, the code under test doesn't respect that.
Differential Revision: https://phabricator.services.mozilla.com/D65303
--HG--
extra : moz-landing-system : lando
2020-03-04 18:41:39 +00:00
Mathieu Leplatre
863b4989d3
Bug 1617942 - Close Remote Settings DB connections after use r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D64303
--HG--
extra : moz-landing-system : lando
2020-03-03 16:41:47 +00:00
Mathieu Leplatre
5a2acf4e4f
Bug 1617133 - Upgrade kinto-offline-client to v13.0.0 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D64561
--HG--
extra : moz-landing-system : lando
2020-03-02 14:13:57 +00:00
Mathieu Leplatre
9448fcafc5
Bug 1617133 - Report error names to Telemetry on Nightly r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D64560
--HG--
extra : moz-landing-system : lando
2020-03-02 15:04:33 +00:00
Mathieu Leplatre
acd66bc75c
Bug 1617133 - Reduce complexity of RemoteSettingsClient.maybeSync() r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D64559
--HG--
extra : moz-landing-system : lando
2020-02-28 17:06:17 +00:00
Mathieu Leplatre
ec2cc6b37b
Bug 1617133 - Improve categorization of Remote Settings errors r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D64402
--HG--
extra : moz-landing-system : lando
2020-02-28 17:06:17 +00:00
ffxbld
2690d1d20f
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D64941
--HG--
extra : moz-landing-system : lando
2020-03-02 13:42:22 +00:00
Lina Cambridge
be55ac8482
Bug 1615931
- Handle invalid bookmark URLs in new bookmark sync. r=markh,LougeniaBailey
...
This commit changes `Store::local_row_to_item` to validate local URLs,
and flags items with malformed URLs as invalid. These items are either
replaced with valid remote copies, if they exist, or deleted if not.
Additionally, `BaseBookmarksStore#_calculateIndex` no longer throws
when determining the sort index for an item with an invalid URL.
As an aside, we use the `url` crate to parse URLs. This is the same
crate as used by `MozURL`, which, in turn, backs the JS `URL`
constructor...so URLs should be validated the same way in Rust and JS.
Differential Revision: https://phabricator.services.mozilla.com/D64695
--HG--
extra : moz-landing-system : lando
2020-03-02 02:11:13 +00:00
Christian Holler
a801538b51
Bug 1344085 - Re-enable sync services tests under ASan. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D64565
--HG--
extra : moz-landing-system : lando
2020-02-28 03:57:50 +00:00
ffxbld
3da50ef6ba
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D64580
--HG--
extra : moz-landing-system : lando
2020-02-27 18:48:55 +00:00
Mathieu Leplatre
38a37caab2
Bug 1616052 - Add low-level helpers to debug and test Remote Settings r=tarek,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63207
--HG--
extra : moz-landing-system : lando
2020-02-25 15:29:48 +00:00
Mathieu Leplatre
88640634af
Bug 1605973 - Show shutdown blockers in RemoteSettings worker r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D64101
--HG--
extra : moz-landing-system : lando
2020-02-25 15:47:33 +00:00
ffxbld
1a2afa385b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D63847
--HG--
extra : moz-landing-system : lando
2020-02-24 13:53:33 +00:00
Tarek Ziadé
dc72ba77ca
Bug 1597336 - add a fxa+sync scenario r=lina,markh
...
This patch adds a scenario that ends up syncing the generated profile into FxSync.
Differential Revision: https://phabricator.services.mozilla.com/D53789
--HG--
extra : moz-landing-system : lando
2020-02-23 23:17:23 +00:00
Csoregi Natalia
1ece026f40
Backed out changeset aa296c08a667 (bug 1597336) for browser-chrome failures on browser_all_files_referenced.js. CLOSED TREE
2020-02-23 12:26:50 +02:00
Tarek Ziadé
f2659ce7c3
Bug 1597336 - add a fxa+sync scenario r=lina,markh
...
This patch adds a scenario that ends up syncing the generated profile into FxSync.
Differential Revision: https://phabricator.services.mozilla.com/D53789
--HG--
extra : moz-landing-system : lando
2020-02-23 07:48:19 +00:00
Mathieu Leplatre
2e479b39a0
Bug 1616637 - Generalize appinfo attribute in JEXL environments r=mythmon
...
Differential Revision: https://phabricator.services.mozilla.com/D63673
--HG--
extra : moz-landing-system : lando
2020-02-21 18:12:44 +00:00
Cosmin Sabou
db738a9933
Backed out changeset 78353ef17d0d (bug 1616052) for causing xpc crashes @mozilla::storage::Service::Observe.
...
CLOSED TREE
2020-02-21 20:18:26 +02:00
Mathieu Leplatre
71425f67b1
Bug 1616052 - Add low-level helpers to debug and test Remote Settings r=tarek,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63207
--HG--
extra : moz-landing-system : lando
2020-02-21 16:16:10 +00:00
ffxbld
60706288cf
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D63465
--HG--
extra : moz-landing-system : lando
2020-02-20 13:40:32 +00:00
Mathieu Leplatre
b26270876b
Bug 1597688 - Catch Remote Settings worker crashes r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D63161
--HG--
extra : moz-landing-system : lando
2020-02-19 17:40:54 +00:00
Daniel Varga
5ef32871a5
Backed out changeset 4d1cffb02095 (bug 1616052) for causing xpcshell failures at oolkit/components/url-classifier/tests/unit/test_features.js
...
CLOSED TREE
2020-02-19 23:02:45 +02:00
Mathieu Leplatre
39b0b08525
Bug 1616052 - Add low-level helpers to debug and test Remote Settings r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63207
--HG--
extra : moz-landing-system : lando
2020-02-19 17:26:07 +00:00
Mathieu Leplatre
52cd30df2d
Bug 1616274 - Report offline error for attachments downloading r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D63194
--HG--
extra : moz-landing-system : lando
2020-02-18 19:51:41 +00:00
ffxbld
c8bab6f1bf
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D63065
--HG--
extra : moz-landing-system : lando
2020-02-17 14:03:43 +00:00
Mathieu Leplatre
0ef9e2ed2f
Bug 1613923 - Do not synchronize if network is offline r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D62600
--HG--
extra : moz-landing-system : lando
2020-02-17 10:52:47 +00:00
ffxbld
1564b1756c
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D62744
--HG--
extra : moz-landing-system : lando
2020-02-13 18:39:13 +00:00
Simon Giesecke
b50347f917
Bug 1611415 - Prefer using std::move over forget. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
shindli
91aa0518dd
Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE
2020-02-12 20:13:29 +02:00
Simon Giesecke
f604a47fa5
Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Mathieu Leplatre
ccf760a4f8
Bug 1612712 - Add received polling timestamp in uptake events r=mythmon
...
Differential Revision: https://phabricator.services.mozilla.com/D62436
--HG--
extra : moz-landing-system : lando
2020-02-11 17:10:38 +00:00
Andreea Pavel
85ace0c538
Merge autoland to mozilla-central a=merge
2020-02-10 19:28:40 +02:00
ffxbld
0d739c0fa1
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2020-02-10 10:58:31 +00:00
ffxbld
064dc02d0e
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D62251
--HG--
extra : moz-landing-system : lando
2020-02-10 13:33:58 +00:00
ffxbld
b0457ded54
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D61817
--HG--
extra : moz-landing-system : lando
2020-02-06 13:38:28 +00:00
Mathieu Leplatre
5939bf0534
Bug 1600581
- Add performance counters to Remote Settings r=tarek
...
Differential Revision: https://phabricator.services.mozilla.com/D59849
--HG--
extra : moz-landing-system : lando
2020-02-04 18:42:51 +00:00
Christian Holler
71231ac083
Bug 1612707 - Disable various slow tests under TSan. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D61562
--HG--
extra : moz-landing-system : lando
2020-02-04 14:34:07 +00:00
ffxbld
8715672a5b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D61462
--HG--
extra : moz-landing-system : lando
2020-02-03 15:34:55 +00:00
Brian Grinstead
3d2d2d0ea7
Bug 1608281 - Automated rewrite away from reading properties on the global `this` in JSM files - round 1 r=mossop
...
This patch was generated with a script. It doesn't include all files:
- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)
It was generated with the following command using d855222aa2/no-this-property-read.js
:
```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```
Differential Revision: https://phabricator.services.mozilla.com/D60187
--HG--
extra : moz-landing-system : lando
2020-01-29 21:50:04 +00:00
ffxbld
2f2c6ee707
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D60838
--HG--
extra : moz-landing-system : lando
2020-01-23 13:31:34 +00:00
ffxbld
2dea3bc808
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D60400
--HG--
extra : moz-landing-system : lando
2020-01-20 17:59:00 +00:00
Mark Banner
77a7218e90
Bug 1609966 - Enable ESLint for services/sync/modules/constants.js. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D60280
--HG--
extra : moz-landing-system : lando
2020-01-17 19:27:31 +00:00
Siddhant085
676ce0d13c
Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
...
Phasing out the old notification system for OnItemRemoved events.
Differential Revision: https://phabricator.services.mozilla.com/D17753
--HG--
extra : moz-landing-system : lando
2020-01-16 18:38:54 +00:00
ffxbld
5a611b020b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D60144
--HG--
extra : moz-landing-system : lando
2020-01-16 19:24:27 +00:00
Punam Dahiya
94027b5678
Bug 1608942 - Add FX_MONITOR_OAUTH_CLIENT_ID as FxA constant r=rfkelly,k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D59930
--HG--
extra : moz-landing-system : lando
2020-01-16 18:01:29 +00:00
Brian Grinstead
06d6426d76
Bug 1608278 - Remove global `this` setter for LOG_LEVEL in Credentials.jsm r=eoger
...
We need to stop relying on the global `this` in order to support ES Modules.
This instance was harder to fix by a script than others since it's in a try/catch,
so this patch is a manual change.
Differential Revision: https://phabricator.services.mozilla.com/D60080
--HG--
extra : moz-landing-system : lando
2020-01-15 23:52:13 +00:00
Shane Caraveo
8351044ded
Bug 1524327 remove MOZ_ALLOW_LEGACY_EXTENSIONS and extensions.legacy.enabled r=zombie,aswan
...
Legacy extensions are no longer loaded, so we can drop the build config for it. We
still need flags for handling experimental APIs since what we require differs between builds
and distributions.
Differential Revision: https://phabricator.services.mozilla.com/D57413
--HG--
extra : moz-landing-system : lando
2020-01-15 21:38:40 +00:00
Mark Hammond
12bcd1cab8
Bug 1601446 - re-register the FxA device after the user becomes verified. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D59831
--HG--
extra : moz-landing-system : lando
2020-01-14 21:11:34 +00:00
shindli
3d28702804
Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE
2020-01-13 22:33:58 +02:00
Siddhant085
d48342d7db
Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
...
Phasing out the old notification system for OnItemRemoved events.
Differential Revision: https://phabricator.services.mozilla.com/D17753
--HG--
extra : moz-landing-system : lando
2020-01-13 16:25:39 +00:00
ffxbld
f55cc5e382
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D59687
--HG--
extra : moz-landing-system : lando
2020-01-13 13:50:15 +00:00
Tooru Fujisawa
8a7e982608
Bug 1259822 - Part 2: Show property key in the error message when target object value is null or undefined. r=jorendorff
...
Differential Revision: https://phabricator.services.mozilla.com/D58104
--HG--
extra : moz-landing-system : lando
2020-01-11 05:10:54 +00:00
Brindusan Cristian
cd0639ae45
Bug 1608011 - Fix ESlint. r=lint-fix CLOSED TREE
2020-01-10 01:19:20 +02:00
Mark Hammond
dad771fce0
Bug 1608011 - ensure sync telemetry reports the storage node type. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D59273
--HG--
extra : moz-landing-system : lando
2020-01-09 22:54:39 +00:00
Brindusan Cristian
1f941a27c0
Backed out changeset fe11ab9196ba (bug 1608011) for xpcshell failures at test_tokenserverclient.js. CLOSED TREE
2020-01-10 00:21:00 +02:00
Mark Hammond
22bcd88049
Bug 1608011 - ensure sync telemetry reports the storage node type. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D59273
--HG--
extra : moz-landing-system : lando
2020-01-09 20:13:12 +00:00
ffxbld
47f9f24123
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D59324
--HG--
extra : moz-landing-system : lando
2020-01-09 15:43:49 +00:00
Noemi Erli
79c4589718
Merge autoland to mozilla-central. a=merge
2020-01-06 23:53:16 +02:00
ffxbld
96ff1ca153
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2020-01-06 15:53:38 +00:00
ffxbld
e81b921296
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D58514
--HG--
extra : moz-landing-system : lando
2020-01-02 13:26:27 +00:00
ffxbld
92b26fef5d
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D58770
--HG--
extra : moz-landing-system : lando
2020-01-06 13:40:52 +00:00
ffxbld
cbe062ca0b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D58244
--HG--
extra : moz-landing-system : lando
2019-12-26 21:30:40 +00:00
ffxbld
0d4a7ec64a
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D57856
--HG--
extra : moz-landing-system : lando
2019-12-19 19:44:12 +00:00
Mathieu Leplatre
7e8fc190b6
Bug 1601893 - Fix Remote Settings test about events on release r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D57761
--HG--
extra : moz-landing-system : lando
2019-12-19 15:03:31 +00:00
Mark Hammond
2f0396d567
Bug 1582317 - record the sync storage node type in the sync telemetry ping. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D55196
--HG--
extra : moz-landing-system : lando
2019-12-14 04:26:05 +00:00
ffxbld
11ac8caa11
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D57311
--HG--
extra : moz-landing-system : lando
2019-12-16 15:13:53 +00:00
ffxbld
7f9eb46978
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D56907
--HG--
extra : moz-landing-system : lando
2019-12-12 15:32:17 +00:00
ffxbld
ddfb9c0ff8
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D56358
--HG--
extra : moz-landing-system : lando
2019-12-09 18:02:19 +00:00
Mathieu Leplatre
4bce641544
Bug 1598562 - Prevent Remote Settings server URL to be modified in release r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D54262
--HG--
extra : source : 0e4aef99fe4b85e8d9fb6d568830c638b8c4cd73
2019-12-09 12:07:46 +00:00
Mihai Alexandru Michis
8030d47ee6
Backed out changeset 0e4aef99fe4b (bug 1598562) for causing browser-chrome failures in browser_tabMatchesInAwesomebar.js CLOSED TREE
2019-12-09 15:10:30 +02:00
Mathieu Leplatre
567d3f7b05
Bug 1598562 - Prevent Remote Settings server URL to be modified in release r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D54262
--HG--
extra : moz-landing-system : lando
2019-12-09 12:07:46 +00:00
Mark Hammond
964d300af6
Bug 1601797 - ensure we consistently report auth errors when a session token is missing. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D56096
--HG--
extra : moz-landing-system : lando
2019-12-06 16:44:55 +00:00
ffxbld
029fc78ac3
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D55956
--HG--
extra : moz-landing-system : lando
2019-12-05 15:40:18 +00:00
Geoff Brown
9e59579c39
Bug 1601076 - Fix some broken BUG_COMPONENTS in moz.build files; r=jmaher
...
Some of these were obvious typos. Others probably reflect once-correct components
that have been combined, split, or otherwise obsoleted; for these I've tried to
use the component associated with the bugs for recent changes to the affected files.
Differential Revision: https://phabricator.services.mozilla.com/D55756
--HG--
extra : moz-landing-system : lando
2019-12-04 13:55:45 +00:00
Mark Hammond
695f37d9b1
Bug 1597868 - refresh the fxa device list each 2 hours instead of each sync. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D55590
--HG--
extra : moz-landing-system : lando
2019-12-03 16:07:46 +00:00
Noemi Erli
79b3b21bb6
Merge autoland to mozilla-central. a=merge
2019-12-02 20:41:12 +02:00
ffxbld
2eb3b6566d
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2019-12-02 11:59:11 +00:00
ffxbld
095a889675
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D55438
--HG--
extra : moz-landing-system : lando
2019-12-02 14:02:17 +00:00
Daniel Varga
b6af88ada4
Backed out changeset 6e7d21f9e8ef (bug 1598562) causing bug 1600450 in 72 beta
...
--HG--
extra : rebase_source : eb7b34c8d7259529189837a2a51dec53263c7cef
2019-12-02 01:19:09 +02:00
Mathieu Leplatre
11ef5b562c
Bug 1598562 - Prevent Remote Settings server URL to be modified in release r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D54262
--HG--
extra : moz-landing-system : lando
2019-11-29 10:29:44 +00:00
Sylvestre Ledru
ba488cdc09
Bug 1598971 - codespell: Fix typos in the doc r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,ato
...
Depends on D54430
Differential Revision: https://phabricator.services.mozilla.com/D54431
--HG--
extra : moz-landing-system : lando
2019-11-25 10:06:12 +00:00
Mark Hammond
818e5a5c52
Bug 1598997 - Mock profile fetching function in xpcshell tests. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D54450
--HG--
extra : moz-landing-system : lando
2019-11-25 21:21:46 +00:00
Mathieu Leplatre
a6d949c39b
Bug 1559132 - Add ability to download Remote Settings attachments as bytes r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D53812
--HG--
extra : moz-landing-system : lando
2019-11-25 16:13:52 +00:00
ffxbld
97c99c1595
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D54500
--HG--
extra : moz-landing-system : lando
2019-11-25 13:53:13 +00:00
Mark Hammond
9ff9e9548a
Bug 1595954 - record event as the user explicitly connects or disconnects sync or fxa. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D53907
--HG--
extra : moz-landing-system : lando
2019-11-25 00:12:01 +00:00
Mathieu Leplatre
280083669e
Bug 1597337 - Report download errors in uptake telemetry r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D53783
--HG--
extra : moz-landing-system : lando
2019-11-22 08:35:30 +00:00
ffxbld
533132c23d
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D54125
--HG--
extra : moz-landing-system : lando
2019-11-21 15:29:52 +00:00
Gijs Kruitbosch
734a4ade99
Bug 1597785 - fix review nits from bug 1594521, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D53861
--HG--
extra : moz-landing-system : lando
2019-11-19 21:44:10 +00:00
Gijs Kruitbosch
acafdba483
Bug 1594521 - avoid instantiating remote settings worker after shutdown, r=leplatrem,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D53751
--HG--
extra : moz-landing-system : lando
2019-11-19 15:14:07 +00:00
Moritz Birghan
975648e245
Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D40614
--HG--
extra : moz-landing-system : lando
2019-11-18 13:03:58 +00:00
ffxbld
a55a956277
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D53414
--HG--
extra : moz-landing-system : lando
2019-11-18 13:25:41 +00:00
Mark Hammond
c56be6e72f
Bug 1594704 - ensure sync data choices made before connecting sync are honored. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D53138
--HG--
extra : moz-landing-system : lando
2019-11-15 19:12:16 +00:00
Mark Hammond
7979d6602b
Bug 1596659 - Delete declineDisabled from engines.js. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D53141
--HG--
extra : moz-landing-system : lando
2019-11-15 20:04:53 +00:00
ffxbld
6e44b2aa1e
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D53009
--HG--
extra : moz-landing-system : lando
2019-11-14 23:48:44 +00:00
Vijay Budhram
0929b414ed
Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D50931
--HG--
extra : moz-landing-system : lando
2019-11-14 21:01:23 +00:00
Mark Hammond
e57be9d2f3
Bug 1594929 - Remove invalidateCertificate from FxAccountsKeys.jsm. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D52623
--HG--
extra : moz-landing-system : lando
2019-11-12 04:05:28 +00:00
Mark Hammond
ab41353fa5
Bug 1548404 - Update UITour to reflect the decoupling of FxA and Sync. r=MattN,andreio,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D51976
--HG--
extra : moz-landing-system : lando
2019-11-12 23:58:03 +00:00
ffxbld
46cd67e91a
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D52533
--HG--
extra : moz-landing-system : lando
2019-11-11 14:21:48 +00:00
rfkelly
048a518c75
Bug 1591312 - Revert to using BrowserID to generate OAuth tokens. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D50770
--HG--
extra : moz-landing-system : lando
2019-11-08 06:28:54 +00:00
ffxbld
02b887e62e
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D52150
--HG--
extra : source : 90745d442c4b0885b14449065509484da5de9fe5
2019-11-07 15:36:28 +00:00
Ciure Andrei
98e9f97749
Backed out changeset 90745d442c4b for causing build bustages CLOSED TREE
2019-11-07 18:19:01 +02:00
ffxbld
3d9a3dab4a
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D52150
--HG--
extra : moz-landing-system : lando
2019-11-07 15:36:28 +00:00
Coroiu Cristina
27a753cc4a
Backed out changeset 96048cce4b80 (bug 1571656) for xpcshell failures at toolkit/components/places/tests/unifiedcomplete/test_autofill_origins.js on a CLOSED TREE
2019-11-06 22:59:45 +02:00
Moritz Birghan
70c7a633fb
Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D40614
--HG--
extra : moz-landing-system : lando
2019-11-06 18:07:54 +00:00
Oana Pop Rus
6c038766da
Backed out changeset dd5c1030d23b (bug 1590231) for bc failures in browser_search_within_preferences_2.js on a CLOSED TREE
2019-11-06 19:44:13 +02:00
Vijay Budhram
b9c626a520
Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D50931
--HG--
extra : moz-landing-system : lando
2019-11-06 16:51:03 +00:00
Thom Chiovoloni
0aee355709
Bug 1582263 - Move devices list to top level of sync ping. r=markh
...
Move devices list to top level of sync ping
Differential Revision: https://phabricator.services.mozilla.com/D49194
--HG--
extra : moz-landing-system : lando
2019-11-05 17:21:12 +00:00
ffxbld
7ecd576f74
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D51601
--HG--
extra : moz-landing-system : lando
2019-11-04 13:51:07 +00:00
Gijs Kruitbosch
00778dd54e
Bug 1591212 - make webchannel work with fission, r=vladikoff,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D51214
--HG--
rename : toolkit/modules/WebChannel.jsm => toolkit/actors/WebChannelParent.jsm
rename : browser/base/content/test/general/browser_web_channel.js => toolkit/modules/tests/browser/browser_web_channel.js
rename : browser/base/content/test/general/browser_web_channel.html => toolkit/modules/tests/browser/file_web_channel.html
rename : browser/base/content/test/general/browser_web_channel_iframe.html => toolkit/modules/tests/browser/file_web_channel_iframe.html
extra : moz-landing-system : lando
2019-11-02 00:39:35 +00:00
ffxbld
c1e90a0ee7
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D51261
--HG--
extra : moz-landing-system : lando
2019-10-31 14:46:55 +00:00
ffxbld
b6ddb7ea53
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D50806
--HG--
extra : moz-landing-system : lando
2019-10-28 13:17:59 +00:00
Thom Chiovoloni
962b41a45b
Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
...
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment
Differential Revision: https://phabricator.services.mozilla.com/D49166
--HG--
extra : moz-landing-system : lando
2019-10-25 21:38:01 +00:00
rfkelly
ebf99d6f4f
Bug 1590948 - Properly inspect `context` param when handling `fxa_status` webchannel message. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D50408
--HG--
extra : moz-landing-system : lando
2019-10-25 00:23:09 +00:00
Cosmin Sabou
23c6504831
Bug 1590486 - Fix eslint failure. r=eslint-fix
2019-10-24 06:58:21 +03:00
Mark Hammond
274e0280b0
Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D50359
--HG--
extra : moz-landing-system : lando
2019-10-24 03:30:57 +00:00
lougenia
4a5ba28d8a
Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D49805
--HG--
extra : source : b300b58faf473a242d4ed3428a97dec17bcd862c
2019-10-23 17:49:51 +00:00
Cosmin Sabou
68edcb2abb
Backed out changeset b300b58faf47 (bug 1588948) for browser chrome failures on test_basic_form_autocomplete.html.
2019-10-24 02:06:37 +03:00
Cosmin Sabou
291e0d381d
Backed out changeset c5503bc49a73 (bug 1590486) for xpc failures on test_web_channel.js.
2019-10-24 02:04:03 +03:00
lougenia
8fff38140a
Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D49805
--HG--
extra : moz-landing-system : lando
2019-10-23 17:49:51 +00:00
Mark Hammond
75ea9bc416
Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D50359
--HG--
extra : moz-landing-system : lando
2019-10-23 21:21:23 +00:00
Oana Pop Rus
5033d599b4
Backed out changeset 3d7b77564cb7 (bug 1238810) for bc perma failures in browser_startup.js on a CLOSED TREE
2019-10-24 00:38:10 +03:00
Thom Chiovoloni
b8fe187695
Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
...
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment
Differential Revision: https://phabricator.services.mozilla.com/D49166
--HG--
extra : moz-landing-system : lando
2019-10-15 22:57:58 +00:00
Drew Willcoxon
c7e19ee271
Bug 1579334 - Properly limit remote tab matches in the quantumbar. r=mak
...
This is a narrow patch that simply adds a `maxMatches` param to `PlacesRemoteTabsAutocompleteProvider.getMatches`.
Differential Revision: https://phabricator.services.mozilla.com/D50019
--HG--
extra : moz-landing-system : lando
2019-10-22 15:22:48 +00:00
Mark Hammond
12dd37165b
Bug 1574051 - make FxA's session/account status checking sane and understandable. r=rfkelly,mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D49689
--HG--
extra : moz-landing-system : lando
2019-10-22 00:58:36 +00:00
Mark Hammond
9a28c6748d
Bug 1574052 - only return public fields from fxAccounts.getSignedInUser(). r=rfkelly,eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D49525
--HG--
extra : moz-landing-system : lando
2019-10-22 00:57:27 +00:00
Narcis Beleuzu
2b0d2dd8e7
Merge autoland to mozilla-central. a=merge
2019-10-22 00:50:23 +03:00
ffxbld
4c889635b4
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D49928
--HG--
extra : moz-landing-system : lando
2019-10-21 13:23:30 +00:00
ffxbld
716fe01e26
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D49605
--HG--
extra : moz-landing-system : lando
2019-10-17 14:34:51 +00:00
ffxbld
7b3edc3d02
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2019-10-21 18:00:38 +00:00
Lina Cambridge
a0d2e56628
Bug 1588329 - Centralize array chunking in `PlacesUtils.chunkArray`. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D49072
--HG--
extra : moz-landing-system : lando
2019-10-15 21:23:07 +00:00
Dorel Luca
b6eeb7d5d3
Backed out changeset 35d4451f348d (bug 1588458) as requested by the dev
2019-10-15 19:04:22 +03:00
Sylvestre Ledru
0f71aeba53
Bug 1588458 - Replace dxr by searchfox in the doc r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D49140
--HG--
extra : moz-landing-system : lando
2019-10-15 15:27:13 +00:00
Sam Foster
9b996482ca
Bug 1567196
- Ignore invalid password date values. r=markh
...
Depends on D48941
Differential Revision: https://phabricator.services.mozilla.com/D49218
--HG--
extra : moz-landing-system : lando
2019-10-15 00:23:42 +00:00
Mark Hammond
0481284ac7
Bug 1583897 - Send a telemetry event for new sendtab. r=tcsc,eoger,lina
...
Differential Revision: https://phabricator.services.mozilla.com/D48153
--HG--
extra : moz-landing-system : lando
2019-10-14 22:17:28 +00:00
Mark Hammond
c7296e7825
Bug 1587769 - update the pref we watch to ensure we sync immediately after device name change. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D49102
--HG--
extra : moz-landing-system : lando
2019-10-14 16:30:27 +00:00
ffxbld
cbc7251ad9
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D49151
--HG--
extra : moz-landing-system : lando
2019-10-14 13:16:30 +00:00
Lina Cambridge
5ac45f3f35
Bug 1588018 - Remove remaining event telemetry from the bookmarks mirror. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D49049
--HG--
extra : moz-landing-system : lando
2019-10-14 00:22:10 +00:00
Mark Hammond
1b362fb843
Bug 1587837 - better checking of the Firefox Account password changing. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D48936
--HG--
extra : moz-landing-system : lando
2019-10-11 16:41:44 +00:00
Edouard Oger
25eb2d60df
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D48410
--HG--
extra : moz-landing-system : lando
2019-10-11 17:06:57 +00:00
Andreea Pavel
eb350d4f6b
Backed out changeset 4695136f7e82 (bug 1549049) for assertion failures at ErrorResult.h on a CLOSED TREE
2019-10-11 00:53:42 +03:00
Edouard Oger
136a86deed
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D48410
--HG--
extra : moz-landing-system : lando
2019-10-10 21:08:01 +00:00
Mark Hammond
b559ec6b1b
Bug 1587691 - Firefox Accounts webchannel message should allow login without engine choices. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D48797
--HG--
extra : moz-landing-system : lando
2019-10-10 16:57:42 +00:00
ffxbld
8d4072c53b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D48836
--HG--
extra : moz-landing-system : lando
2019-10-10 14:38:00 +00:00
Edouard Oger
79a871cd9c
Bug 1577690 - WebChannel support for optional Sync. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46316
--HG--
extra : moz-landing-system : lando
2019-10-08 15:19:23 +00:00
Edouard Oger
da3f0d0753
Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46517
--HG--
extra : moz-landing-system : lando
2019-10-08 15:45:06 +00:00
Razvan Maries
9c27546918
Backed out changeset 6852bdb8d8c5 (bug 1581709) for Linting failures. CLOSED TREE
2019-10-08 18:42:11 +03:00
Edouard Oger
1093781abc
Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46517
--HG--
extra : moz-landing-system : lando
2019-10-08 14:19:11 +00:00
Edouard Oger
44a0e91fcd
Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D48272
--HG--
extra : moz-landing-system : lando
2019-10-07 15:25:38 +00:00
ffxbld
5a0922f7cb
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D48342
--HG--
extra : moz-landing-system : lando
2019-10-07 13:11:07 +00:00
Lina Cambridge
397d3a1156
Bug 1583413
- Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
...
Instead of using the list of FxA devices from the Sync clients engine,
we now fetch the list of Send Tab devices from FxA. This works like
this:
* `FxAccountsDevice#getDeviceList` has been split up into
`recentDeviceList` and `refreshDeviceList`.
* `recentDeviceList` synchronously returns the last fetched list, so
that consumers like Send Tab can use it right away.
* `refreshDeviceList` is asynchronous, and refreshes the last fetched
list. Refreshes are limited to once every minute by default, matching
the minimum sync interval (Send Tab passes the `ignoreCached` option
to override the limit if the user clicks the "refresh" button).
Concurrent calls to `refreshDeviceList` are also serialized, to
ensure the list is only fetched once.
* The list is flagged as stale when a device is connected or
disconnected. It's still kept around, but the next call to
`refreshDeviceList` will fetch a new list from the server.
* The Send Tab UI refreshes FxA devices in the background. Matching FxA
devices to Sync client records is best effort; we don't do it if Sync
isn't configured or hasn't run yet. This only impacts the fallback
case if the target doesn't support FxA commands.
Differential Revision: https://phabricator.services.mozilla.com/D47521
--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:55 +00:00
Lina Cambridge
51e03623ee
Bug 1583413
- Move device-related methods into `FxAccountsDevice.jsm`. r=eoger
...
This commit contains no functional changes, just moving code around to
make the next patch in this series easier to write.
Differential Revision: https://phabricator.services.mozilla.com/D47520
--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:41 +00:00
ffxbld
9238ced3bb
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D48055
--HG--
extra : moz-landing-system : lando
2019-10-03 13:40:24 +00:00
Mark Hammond
47380e1a34
Bug 1581980 - change the text of many Sync notifications so they aren't Sync specific. r=flod,eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D47853
--HG--
extra : moz-landing-system : lando
2019-10-03 05:52:58 +00:00
Mark Hammond
51a55ec4ba
Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D47861
--HG--
extra : moz-landing-system : lando
2019-10-03 01:18:09 +00:00
Bogdan Tara
11b09d510c
Backed out changeset 961eac228e3e (bug 1585299) for ES Lint failures on FxAccounts.jsm && test_accounts.js CLOSED TREE
2019-10-02 09:41:37 +03:00
Mark Hammond
c0a71bf7f1
Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D47861
--HG--
extra : moz-landing-system : lando
2019-10-02 06:03:39 +00:00
Mark Hammond
499384cb8e
Bug 1585211 - Have TPS enable sync when the test user logs in. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D47714
--HG--
extra : moz-landing-system : lando
2019-10-01 00:32:01 +00:00
ffxbld
8a664f77d8
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D47597
--HG--
extra : moz-landing-system : lando
2019-09-30 13:11:37 +00:00
ffxbld
c9b081d8c9
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D47244
--HG--
extra : moz-landing-system : lando
2019-09-26 14:33:06 +00:00
Mark Hammond
4b629788b2
Bug 1570567 - update about:preferences#sync to reflect the decoupling of FxA and Sync. r=Gijs,eoger,flod,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D46574
--HG--
extra : moz-landing-system : lando
2019-09-26 10:48:22 +00:00
Mark Hammond
7ec2097ae8
Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
...
Differential Revision: https://phabricator.services.mozilla.com/D46572
--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
Geoff Brown
dcb380399e
Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
...
Most of these tests have been disabled for a long time; they run well
in the current test environment.
Differential Revision: https://phabricator.services.mozilla.com/D46642
--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Edouard Oger
5431bbfab3
Bug 1547120 - Add a method to list attached clients. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D46838
--HG--
extra : moz-landing-system : lando
2019-09-23 20:43:56 +00:00
ffxbld
bdeece726d
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D46777
--HG--
extra : moz-landing-system : lando
2019-09-23 13:09:04 +00:00
Edouard Oger
7f39ae82a2
Bug 1582542 - Use getUserAccountData in FxA commands invoke. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46511
--HG--
extra : moz-landing-system : lando
2019-09-19 19:51:41 +00:00
ffxbld
959ff7f82f
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D46469
--HG--
extra : moz-landing-system : lando
2019-09-19 14:37:28 +00:00
Edouard Oger
3017be71f8
Bug 1582537
- Call getScopedKeys on keys field. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46509
--HG--
extra : moz-landing-system : lando
2019-09-19 19:28:48 +00:00
Mark Hammond
7531325c86
Bug 1582023 - Replace "sync disconnect" dialog and local data removal with simple confirmation dialog. r=eoger,flod,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D46253
--HG--
extra : moz-landing-system : lando
2019-09-19 05:59:51 +00:00
Mark Hammond
140dc3f765
Bug 1578217 - remove the sync 'yellow state' telemetry. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D45765
--HG--
extra : moz-landing-system : lando
2019-09-19 00:34:04 +00:00
Ehsan Akhgari
1ba181f8bf
Bug 1581160 - Prepackage url-classifier-skip-urls into the binaries; r=leplatrem,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D45871
--HG--
extra : moz-landing-system : lando
2019-09-13 16:26:57 +00:00
Edouard Oger
a6c404619f
Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D44485
--HG--
extra : moz-landing-system : lando
2019-09-10 18:23:31 +00:00
Edouard Oger
926c5d067c
Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D44484
--HG--
extra : moz-landing-system : lando
2019-09-11 01:17:46 +00:00
ffxbld
5af1f73d04
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D45662
--HG--
extra : moz-landing-system : lando
2019-09-12 13:37:51 +00:00
Mark Hammond
0203cd1dd5
Bug 1574048 - Remove FxAccounts internal/external/Object.freeze()/ weirdness. r=lina,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D44083
--HG--
extra : moz-landing-system : lando
2019-09-12 02:08:50 +00:00
Mark Hammond
e074186422
Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D43897
--HG--
extra : moz-landing-system : lando
2019-09-11 01:37:50 +00:00
Bogdan Tara
0f5e9e5206
Backed out changeset 93d2d4bbe263 (bug 1575921) for xpcshell failures on test_device.js CLOSED TREE
2019-09-10 04:42:15 +03:00
Mark Hammond
15535c9309
Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D43897
--HG--
extra : moz-landing-system : lando
2019-09-10 00:09:52 +00:00
ffxbld
426de7d9bd
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2019-09-02 09:00:31 +00:00
ffxbld
3b375c8b7b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D43967
--HG--
extra : moz-landing-system : lando
2019-08-29 13:14:59 +00:00
Mathieu Leplatre
43084d5e54
Bug 1577218 - Upgrade kinto-offline-client to 12.7.0 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D43773
--HG--
extra : moz-landing-system : lando
2019-08-28 16:08:29 +00:00
Sylvestre Ledru
d264b841c9
Bug 1576502 - Fix some wording issues r=mhoye
...
Differential Revision: https://phabricator.services.mozilla.com/D43363
--HG--
extra : moz-landing-system : lando
2019-08-27 15:38:58 +00:00
Luca Greco
b2c8b8875b
Bug 1572711 - Record extensions.blocklist.useXML and services.blocklist.*.checked prefs into new telemetry scalars. r=janerik,leplatrem,Gijs
...
Depends on D41734
Differential Revision: https://phabricator.services.mozilla.com/D41735
--HG--
extra : moz-landing-system : lando
2019-08-22 16:32:19 +00:00
ffxbld
409e5b7a75
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D43052
--HG--
extra : moz-landing-system : lando
2019-08-22 13:43:50 +00:00
Mark Hammond
c2a3916396
Bug 1574382 - use yaml to parse TPS tests. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D42263
--HG--
extra : moz-landing-system : lando
2019-08-19 20:55:05 +00:00
Ciure Andrei
9a123fb597
Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE
2019-08-19 13:00:44 +03:00
Moritz Birghan
240771fa29
Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D40614
--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Mark Banner
b1970e6a2f
Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
...
These are raised as redeclares or unused variables by ESLint 6.
Differential Revision: https://phabricator.services.mozilla.com/D37268
--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
Lina Cambridge
a17323e9d8
Bug 1573709 - Return an aborted watchdog for testing interrupted bookmark merges. a=testonly
...
Differential Revision: https://phabricator.services.mozilla.com/D41876
--HG--
extra : moz-landing-system : lando
2019-08-14 00:28:52 +00:00
Lina Cambridge
65dfa84ccd
Bug 1573305 - Remove the check for unmerged synced bookmark changes. r=markh
...
When a local or remote item changed, we'd potentially scan three tables
(with an expensive `LEFT JOIN`!) to check if anything changed...then
scan the same tables again to build the local and remote trees. This
check was originally meant to avoid unnecessary merges. However, the
bottleneck isn't merging now; it's reading from the database.
Since the merger has been rewritten in Rust, is synchronous, doesn't
keep a transaction open for the entire merge (see the
`total_sync_changes` check), and only emits ops for items that actually
changed, it's more efficient to build and merge optimistically, and
bail before applying if nothing changed.
This commit also moves `validateLocalRoots` into Rust.
Differential Revision: https://phabricator.services.mozilla.com/D41690
--HG--
extra : moz-landing-system : lando
2019-08-13 22:58:16 +00:00
Lina Cambridge
19557885f6
Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh
...
This commit introduces a new `Watchdog` class that signals an abort,
either after a delay or at shutdown, and wires up the buffered engine
to use it.
Differential Revision: https://phabricator.services.mozilla.com/D41311
--HG--
extra : moz-landing-system : lando
2019-08-13 18:48:25 +00:00
ffxbld
21d02cb6fe
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D41541
--HG--
extra : moz-landing-system : lando
2019-08-12 13:08:23 +00:00
Nicholas Nethercote
41a012cce7
Bug 1572621 - Merge services-sync.js into all.js. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D41323
--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:41 +00:00
Nicholas Nethercote
73d5a12400
Bug 1572621 - Merge services-common.js into all.js. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D41322
--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:27 +00:00
Lina Cambridge
0d63b1e98f
Bug 1498073 - Use centisecond precision for modified times in Sync tests. a=testonly
...
Differential Revision: https://phabricator.services.mozilla.com/D41266
--HG--
extra : moz-landing-system : lando
2019-08-08 19:19:47 +00:00
Jared Wein
22ae3511f6
Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D40878
--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:36 +00:00
Bogdan Tara
844afcfb06
Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
...
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
9cf685253f
Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D40878
--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:51 +00:00
Mark Hammond
05df0254b8
Bug 1568353 - set the default rest.js timeout to be 5 minutes. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D40927
--HG--
extra : moz-landing-system : lando
2019-08-07 05:25:49 +00:00
Mark Hammond
40d28c338b
Bug 1561762 - better handle concurrent requests for FxA oauth tokens. r=eoger,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D38036
--HG--
extra : moz-landing-system : lando
2019-08-06 15:25:05 +00:00
Lina Cambridge
9320172d8f
Bug 1567238 - Refactor the bookmarks mirror merge triggers to do less work. r=tcsc,markh
...
This commit reduces the number of database writes and table scans
needed to merge synced bookmarks.
* Remove `fetchNew{Local, Remote}Contents`. Fetching the tree already
scans the table, so we can piggyback on it to fetch content info for
deduping.
* Store completion ops in temp tables to only update changed parts of
the local tree, and remove the `mergeStates` table and views.
* Replace the `itemsToMerge` view with an indexed `itemsToApply` temp
table.
* Replace the `updateGuidsAndSyncFlags` trigger with a `changeGuidOps`
table and a `changeGuids` trigger.
* Replace the `updateLocalItems` trigger with an `apply_remote_items`
function to bulk upsert new and updated items.
* Replace the `structureToMerge` view with an
`applyNewLocalStructureOps` table that holds parents and positions
for moved items, and an `applyNewLocalStructure` trigger to update
them.
* Remove tombstones for revived items, update change counters, and flag
mirror items as merged directly in `update_local_items_in_places`,
instead of indirecting through temp tables.
* Don't mark items flagged for reupload as merged, since we'll write
them back to the mirror after upload.
* Use a scalar subquery instead of a join in the `localTags` view to
look up the tags root ID.
* Replace `relatedIdsToReupload` with a `Store::prepare` method that
flags all bookmarks with keyword-URL mismatches for reupload.
* Trigger frecency updates for origins once, not for every item.
* Remove two extra scans on `itemsAdded` and `itemsChanged` when
recording observer notifications for changed keywords.
* Notify all `bookmark-added` listeners in a single batch.
This also fixes some edge cases:
* Update root positions correctly after deleting a non-syncable root
or item.
* Keyword-URL mismatches may reupload more items than before, but now
ensure that all bookmarks with the same URL have the same keyword.
* Only set items with deduped GUIDs to `SYNC_STATUS_NORMAL` after
merging.
* Bump the last modified time for modified items only.
Differential Revision: https://phabricator.services.mozilla.com/D39889
--HG--
extra : moz-landing-system : lando
2019-08-06 23:48:03 +00:00
ffxbld
6dfb6ea6a1
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D40198
--HG--
extra : moz-landing-system : lando
2019-08-01 13:24:01 +00:00
Ehsan Akhgari
f172f95ac0
Bug 1568341 - Part 4: Pre-package the anti-tracking-url-decoration.json remote settings bucket for new profiles or fresh upgrades; r=leplatrem
...
Differential Revision: https://phabricator.services.mozilla.com/D39922
--HG--
extra : moz-landing-system : lando
2019-07-31 19:32:07 +00:00
Luke Crouch
940333a24b
Bug 1566591: catch and log RemoteSettings errors r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D39824
--HG--
extra : moz-landing-system : lando
2019-07-30 19:39:03 +00:00