Automatic update from web-platform-tests
Fix wpt/css/css-backgrounds/background-332.html
The 'background-size' component of the shorthand is '10em' - which is
the same as '10em auto' (not '10em 10em'). Also, the value should be the
computed <length> (160px). Thus '160px' will be the shortest computed
form.
For the 'background-repeat' component, 'round' is equivalent to
'round round' but the former is the shorter form.
Fixed: 1184497
Change-Id: I82e9bfbfdf6eac2ca7781d4332e7954ef7cbdb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919751
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#886764}
--
wpt-commits: 69032b42bd96f3fd889fef7730ed7ff53fb3e167
wpt-pr: 29122
Automatic update from web-platform-tests
[Credentialless]: WPT vs CacheStorage. 2 cases about "omit".
On https://github.com/w3c/ServiceWorker/issues/1592#issuecomment-838741939
I mentioned 5 "interesting" cases about `COEP:credentialless` and CacheStorage.
All are already tested, except the 4th.
This patch introduces two new tests with request.credentials="omit",
including the missing one above.
R=antoniosartori@chromium.org
CC: clamy@chromium.org
CC: mkwst@chromium.org
CC: lyf@chromium.org
Bug: 1175099
Change-Id: If8ea3ebc9efd6622be0d8c4dae7eba1bb28ce3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917020
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886703}
--
wpt-commits: b7a876caf70a8124d66f1a112d39c3712b2fa125
wpt-pr: 29102
Automatic update from web-platform-tests
Flake-secure background-attachment test
Preload background-image and wait for it to be loaded before doing a
screenshot. This test is currently not flaky, but landing [1] would make
it start failing.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2871469
Bug: 332189
Change-Id: I87d00c8021c44e405b0f45af72f9b8b20eb5a82f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917298
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886673}
--
wpt-commits: 1940839d9b546f4e8e47ca61b4fdf4f365b7bac2
wpt-pr: 29115
Automatic update from web-platform-tests
Use PostLayoutBoxFragment() in RecalcChildLayoutOverflow()
Use PostLayoutBoxFragment() instead of BoxFragment()
in LayoutNGMixin::RecalcChildLayoutOverflow() to avoid hitting
the assert in NGPhysicalBoxFragment::OwnerLayoutBox().
This avoids the DCHECK failures when for some reason
the fragment tree is out of sync.
BUG=1203387
TEST=external/wpt/css/css-tables/crashtests/vertical_percentage_crash.html
Change-Id: I957a7b35df4f0179bc8c3d33d2476b86a34a225b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914881
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#886646}
--
wpt-commits: 166807bde32a7016420f87397b000a1f10c68c1d
wpt-pr: 29099
Automatic update from web-platform-tests
[GridNG] Fix invalidation logic for out of flow items via simplified
layout
This CL addresses a failure where an absolutely positioned item changed
its position dynamically. Previously, a new |containing_block_rect| was
not being added nor re-computed in |SimplifiedLayoutAlgorithm| for
out of flow items that are children of the grid, thus their position was
incorrect. This change computes the new containing block by calling
existing helpers in |NGGridLayoutAlgorithm|. As a result, some methods
had to be changed and constructors overloaded in order to use what was
already computed and stored in |NGGridData|.
Bug: 1045599
Change-Id: Ic299a57aa5e69063c6f8d0f39c92772503b15f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872591
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#886600}
--
wpt-commits: d838b9ed5636932df5e2b0616a152480cccdd3f5
wpt-pr: 28852
Automatic update from web-platform-tests
MSE-in-Workers: Make MediaSource.duration acquire lock to access demuxer
Worker JS accessing MediaSource.duration wasn't taking the necessary
CrossThreadAttachment lock. It should, so that it can safely access the
underlying main-thread-owned demuxer to retrieve its duration.
This change refactors MediaSource::duration() so that only the IDL calls
it, and both it and all other previous callers of duration() are updated
to instead call GetDuration_Locked. duration() calls GetDuration_Locked
via the existing MediaSource::RunUnlessElementGoneOrClosingUs()
machinery that ensures the call only occurs while it is safe to access
the underlying demuxer. Other callers of MediaSource::duration() were
already running in the context of that machinery, and are updated to
provide the appropriate ExclusiveKey to confirm that contract statically
during build (like all the other paths already using that machinery).
Bug: 1211551,878133
Change-Id: I44b97e63e2a2bd9473f4cd0fc07bc734b344bf2d
Fixed: 1211551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2909389
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#886576}
--
wpt-commits: aa56558b1157151f5f71bc41117d0b69dbb88ace
wpt-pr: 29068
Automatic update from web-platform-tests
Update DCHECK for corner case
In a corner case situation (crbug.com/1212619) foster parenting
can lead to a call to ParserInsertBefore() with a |next_child|
value that has a different parent from |this|. This case was
already handled in code, so the DCHECK is updated to allow the
newly-discovered corner case.
The relevant spec is
https://html.spec.whatwg.org/multipage/parsing.html#appropriate-place-for-inserting-a-node
from which step 2.5 says:
If last table has a parent node, then let adjusted insertion
location be inside last table's parent node, immediately before
last table, and abort these steps.
If, at that point, "inside last table's parent node" is a template
element, it isn't exactly clear whether that means a child of
template's content document, or the template itself.
Fixed: 1212619
Change-Id: Iab914f5c39ab6842d92eeae6134f2f347a851e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917760
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886561}
--
wpt-commits: 2d8c1c7879def7096951b842a1b8751317b1e621
wpt-pr: 29112
Automatic update from web-platform-tests
[GridNG] Updating grid-baseline-align-cycles-001.html
This CL updates this test to match expectations where baseline
alignment should not apply. The CSS Grid spec indicates that baseline
alignment should not apply in cases where there's a cyclic dependency
on sizing in the dimension where baseline alignment applies. However,
it also states that certain conditions will force another sizing pass,
and under such conditions baseline alignment may be possible, and under
these circumstances, baseline alignment should apply. If we were to
change behavior to match this test case, numerous other second pass
baseline tests would break. In fact, this test was actually matching
the old expected results before we added logic to support second
passes on baseline alignment - see
https://chromium-review.googlesource.com/c/chromium/src/+/2873217.
Instead, this change updates the test expectations so that they are
all situations where baseline alignment should never apply.
Bug: 941987
Change-Id: Icec9ec1a2708f488dd2dd0d6c472859b36fb2460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911306
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886493}
--
wpt-commits: 0895a4d4a2681c4d892bfeb90cc8188db75cbce0
wpt-pr: 29106
Automatic update from web-platform-tests
Preload background-image resources in tests
Preload and wait for background-image resources to finish loading before
triggering reftest screenshots. Background images are triggered to load
the first time we do a style resolution which means it is not guaranteed
to be loaded and painted on first paint.
These tests are flaky, and increasingly so with [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2871469
Bug: 332189
Change-Id: Ibefbd75f22a9783e27838ec549072a58ede31325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2916998
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886469}
--
wpt-commits: 2ea42e4e13cc9ca219ba7b2b4cca39ab34f438a7
wpt-pr: 29109
Automatic update from web-platform-tests
Forced accent-color followup
In CL:2847031, accent-color was forced to auto in forced colors mode.
This CL moves this logic to StyleAdjuster::AdjustForForcedColorsMode()
so that it is forced in the same place as the other properties forced
at computed value time.
Bug: 1092093
Change-Id: I77ba92e30c6ea060521a8d05747c32a38f149601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2909975
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#886369}
--
wpt-commits: bc6aa2df9438b02a2be08efb88db022e6943217c
wpt-pr: 29104
Automatic update from web-platform-tests
Update test and move cancelAndHold test to WPT
First add tests to cancelAndHoldAtTime for negative and non-finite
values to verify that the correct error is thrown.
Second, move the test to WPT. Manually verified that Safari passes
this test. Firefox fails because it doesn't have cancelAndHoldAtTime
yet.
Bug: 1212672
Change-Id: I0c2efdc0deacc6e1d12caa17d6993bd99fccb709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2912306
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886364}
--
wpt-commits: e888fa12c505ad2793fac96ab3158e42e861bf84
wpt-pr: 29092
Automatic update from web-platform-tests
cancelScheduledValues throws RangeError for negative values
The spec clearly states that cancelScheduledValues must throw a
RangeError for negative values. Make it so, and add a test for this.
We also add tests for NaN and Infinity.
Note, however, that the spec says RangeError is also thrown for
non-finite values. This is incorrect since cancelTime is a double,
not unrestricted double. (See
https://github.com/WebAudio/web-audio-api-v2/issues/127)
Thus, the test throws TypeError for NaN and Infinity.
Bug: 1212307
Change-Id: I750ab0f2b9f17f94d04cb2e9422b4f626252dfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2909615
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886277}
--
wpt-commits: 682303d8b58d63d4b5ec35f060adb27f2c6b2747
wpt-pr: 29091
Automatic update from web-platform-tests
Run mypy for tools/wptrunner/ (but still allow untyped defs) (#28942)
--
wpt-commits: a5e1bc0e5b25b7a55e5f58641b524415b63ea95c
wpt-pr: 28942
Automatic update from web-platform-tests
[css-fonts] Avoid SECURITY_DCHECK failure with system font in animations
r885715 added CSSPendingSystemFontValue in order to handle system fonts
at parse time, deferring the resolution until computed-value time.
The problem was that animations weren't using StyleBuilderConverter, so
these CSSPendingSystemFontValue would remain unresolved in e.g.
element.animate([{"font":"icon"}], {"duration": 1000});
Therefore, this patch makes CSSFontStretchInterpolationType and
CSSFontWeightInterpolationType use StyleBuilderConverter, just like
CSSFontVariationSettingsInterpolationType was already doing.
Bug: 1212321
TEST=external/wpt/css/css-fonts/animations/system-fonts.html
Some checks fail because the font-size of a system font interpolates
discretely. Worked well before r885715, I will fix it in a follow-up.
Change-Id: Ic20664cc7103c3f0a1fc6f7bb97a988f9326aa04
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2915713
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#886257}
--
wpt-commits: 758d40acbe094332663b5c915efcf53c59bf5b57
wpt-pr: 29096
Automatic update from web-platform-tests
Update hypothesis from 6.13.3 to 6.13.5
--
wpt-commits: 58c65dbff5ccec124faaf5850ce5172bc65b4208
wpt-pr: 29097
Automatic update from web-platform-tests
[top-level-await] Check the module is instantiated before checking if it is async
A v8::Module record could fail instantiation and return to
a kUninstantiated instead of a kErrored state due to the embedder
resolve callback.
Bug: chromium:1209777
Change-Id: I524256adc2865bf9556b6eb24cbf8afec039c337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2903690
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886164}
--
wpt-commits: f3891c922d4a02146deb8152b2dfa279c9c98a71
wpt-pr: 29054
Automatic update from web-platform-tests
MSE: Fix rare flaky changeType-play-* failures
Unless the app explicitly sets `mediaSource.duration`,
`HTMLMediaElement.duration` remains NaN until initial HAVE_METADATA is
reached, even if the attached mediaSource has already buffered media
well beyond the initialization segment(s) necessary to begin transition
to HAVE_METADATA. In Chromium, that transition is begun asynchronously,
letting thread hop through the pipeline thread complete while letting
the app continue. Eventually, the media element transitions, but in the
interim, its value for duration could still be NaN, even if mediaSource
has a duration value.
This change relaxes the changeType-play-* utility's reliance on strict
matching of mediaElement.duration and mediaSource.duration, instead
relying on the latter for use in trimming the buffered duration.
I've filed MSE spec issue #275 to discuss this behavior:
https://github.com/w3c/media-source/issues/275
This change also reports more details in changeType web-test assertion
failures, which also enabled finding the suspected root cause of the
tests' flakiness.
Bug: 1184745
Change-Id: I208cbfbbc60776366a16b6a3e79f52480df5be37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2906776
Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886148}
--
wpt-commits: 04c1391243b470ae1e0a0b9a7a53280c9fa66e57
wpt-pr: 29052
Automatic update from web-platform-tests
[baselines] Fix synthesising vertical baselines for flex.
Previously we always synthesized baselines (outsize an inline formatting
context) using the block-end edge.
This changes the behaviour to use the middle if in a vertical writing
mode. This isn't "complete" as it is still missing the text-orientation
logic, but significantly better.
Bug: 1076080
Change-Id: I14f5aea5adb4f3afcd9194b6f4f9b54addeb54ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2905738
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886062}
--
wpt-commits: 19c8f7524e1879825a03f5cd5d241c357906b021
wpt-pr: 29093
Automatic update from web-platform-tests
[GridNG] Synthesized baseline test updates
This change updates several CSS Grid alignment tests that were written
under the expectation that synthesized baselines could participate in
a baseline sharing group with vertical-RL aligned items.
The CSS alignment spec spec at
https://www.w3.org/TR/css-align-3/#baseline-export,
states "Otherwise, assume either horizontal-tb or vertical-lr
writing-mode, whichever is orthogonal to the box’s own writing-mode.",
which indicates that a synthesized baseline should not be assumed
to ever have vertical-rl alignment, and thus shouldn't be in a
baseline sharing group with other vertical-rl items, as these tests
were expecting.
This change also updates TestExpectations to move the SVG aspect
ratio tests that are currently marked as failing under GridNG to
their own section, as well as marking the CSS Grid align-content
tests as 'fail', so they are marked as failures under both grid
and GridNG.
Bug: 1045599
Change-Id: I052da46e1944c4b53eac15a11e9dadb09b669a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911520
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885844}
--
wpt-commits: 8022aa3172b0f43a59f38d87622e3c466adf338f
wpt-pr: 29081
Automatic update from web-platform-tests
[a11y] System font sizes should obey user's font size setting
Some form controls get assigned a system font in UA origin:
input, textarea, select, button {
font: -webkit-small-control;
}
The font size of that is supposed to be 2pt smaller than the default
font size. However, that "default" was hardcoded to 16px, without taking
into account that the user can change the actual default.
For example, someone with suboptimal vision may use a bigger default in
order to be able to read the text with ease. But form controls would
ignore that preference. This was bad for accessibility.
So this patch uses the actual default size when calculating the size
of system fonts.
Doing so requires a Document from which to retrieve the settings, but
CSSParserContext::GetDocument() is null for UA stylesheets. Therefore,
instead of resolving at parse time, the font longhands are set to a
CSSPendingSystemFontValue, and their resolution is deferred until
computed-value time, when we can use StyleResolverState::GetDocument().
Bug: 1054031
TEST=StyleEngineTest.SystemFontsObeyDefaultFontSize
TEST=external/wpt/css/css-fonts/system-fonts-serialization.tentative.html
TEST=fast/css/font-shorthand.html
Change-Id: I5e9b41a2baa45cea7f1a54190bf593e025153adb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2891582
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885715}
--
wpt-commits: 5b5b129bec0a6cf84c79bca04cef769dce5414ee
wpt-pr: 29078
Automatic update from web-platform-tests
[wpt] fix absolute table tests
I believe that absolute-tables-003.html tests 3 and 4 are incorrect. Basically:
<table style="width: 50px;writing-mode: vertical-lr;">
<td style="width: 100px">
is expected to be 50px wide. But table block size does not clamp row block size.
Similar problem happens in absolute-tables-005.html
Bug: 1211929
Change-Id: Ie3658b045581796795a142c8f77c5a30a2ffd45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2913056
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885685}
--
wpt-commits: 843c0fd3ca09418f80b7f89eedcdb69e0df51658
wpt-pr: 29076
Automatic update from web-platform-tests
Count mouse move events as "input" for hadRecentInput
We should not count the layout shift while doing resizing widgets, so we
want to add the mouse move events with the pressed button to the event
list that sets hadRecentInput == true and triggers the exclusion window,
so we do not add the cumulative layout shift score for mouse move drag
action.
Bug: 1166952
Change-Id: I41eefcb4cbce565ccf6eaecebac6d23b1b2309aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2893404
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885678}
--
wpt-commits: 7cff070de4f5c9e821fd6b6025c8ef3ae379c3fa
wpt-pr: 29049
Automatic update from web-platform-tests
Be consistent about supporting aliases in will-change.
The added test (which is a modified copy of the unprefixed perspective
test) fails without the patch and passes with it.
Change-Id: I361b8434d7c6419e19076b88b98d4000e215bb09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911178
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885635}
--
wpt-commits: 516bc779f2edce560d841f5de2c2f5e9fb3c29af
wpt-pr: 29074
Automatic update from web-platform-tests
[LayoutNG] OOF contained by inner multicol
An OOF contained by an inner multicol was not getting laid out because
we skipped propagating up out-of-flow descendants when we reached
an inner multicol (because if the containing block was somewhere inside
the inner multicol, we would lay out those OOFs once we reached the
outer multicol). However, we should not skip propagating the OOF
descendant if the inner multicol is the containing block.
Bug: 1211522
Change-Id: I00876c44eeaa415edd6a90d1d29712077a2ce24c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911733
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885562}
--
wpt-commits: b91bbe8621f60fc06f6da8eac060a90464f2f2a4
wpt-pr: 29069
Automatic update from web-platform-tests
[LayoutNG] Allow spanners inside a transform
Previously, CanContainSpannerInParentFragmentationContext() would not
allow spanners that are the descendant of a transform. However, the
containing block chain now goes directly from the column spanner
to the multicol container for an NG multicol. Thus, it is safe to
allow a spanner to be a true column spanner if it is a descendant of
a transform (in the case that the multicol is an NG object).
The web test that was added to test the old behavior has been removed
and a new test has been added to test the new behavior.
Bug: 1196727
Change-Id: I908d4fdfc6ce090187dedbc2d9488b1c09bfa989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2876245
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885554}
--
wpt-commits: b78f4000bde8da4e83963200026fa411923f8a2a
wpt-pr: 28882
Automatic update from web-platform-tests
Fast fail WebXR WebGL2 tests on platforms not supporting WebGL2. (#28454)
--
wpt-commits: 95de5db93fdf07039f6503434b1e605e554031b6
wpt-pr: 28454
Automatic update from web-platform-tests
Fix setting environment variables for wdspec tests
The previous patch set the variables too late, after the webdriver server was already
started. Pass them down into the server startup code instead
Differential Revision: https://phabricator.services.mozilla.com/D97665
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044
gecko-commit: d5f5359358fd630ea92da053211f7ca4c0527c82
gecko-reviewers: maja_zf, marionette-reviewers, whimboo
--
Use correct profile for wdspec tests
This ensures that we always pass a profile in the capabilitites. When
we're running with a single process it simply unpacks the profile to a
temporary folder and passes in that path as a firefox argument. When
we're running with multiple processes, that won't work. We could
invent a mechanism to get one profile per process, but for simplicity
we instead pass in the profile as a base64-encoded string.
Depends on D97665
Differential Revision: https://phabricator.services.mozilla.com/D99697
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044
gecko-commit: 0eeb2f14977007e8ac8e0a43c976c490db2661af
gecko-reviewers: webdriver-reviewers, whimboo
--
Switch to explicit profile cleanup rather than using __del
This requires passing the test_environment into the get_executor_kwargs function
so that in the firefox wdspec case we can add a cleanup function to the environment
when running wdspec tests. That seems reasonable since we were previously using
a variety of data in the environment to setup the kwargs anyway
Depends on D99698
Differential Revision: https://phabricator.services.mozilla.com/D101768
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044
gecko-commit: 5281b7443a899dcd538380b4f7c15c46300f9bdd
gecko-reviewers: webdriver-reviewers, whimboo
--
Unmaximize window before starting a new session
Otherwise it seems to interfere with the rest of the test.
Depends on D101768
Differential Revision: https://phabricator.services.mozilla.com/D101769
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044
gecko-commit: 023e75831c48ad93ecfb9252db552158a4aa85e9
gecko-reviewers: webdriver-reviewers, whimboo
--
Remove useless __init__ functions from webdriver_server
These appear to assume it's meaningful to set a default binary,
but in practice we always pass in one from the command line args.
It also fixes breakage from adding an extra argument to the
constructor.
--
Fix unit test
--
wpt-commits: 3af2c7c8f616165fb4172748ce74805193b4686c, 8c9153b890a8a33d370e2321418533ab087a231d, 3127e8302a3ee6e04518abebb6fc87ff5cb874fd, e648cd9913c680e91495c2da0415d232f0a283b3, 685b31abbf5fcd55f56ab6dcaca74a22396dbd90, 3634fd46fd84773885f222be2f77c60314e69544
wpt-pr: 28640
Automatic update from web-platform-tests
[LayoutNG] Writeback to legacy layout with no column set after spanner
In the case of external/wpt/css/css-multicol/multicol-span-all-016.html,
one column set is created before the spanner, but no column set is
created after the spanner. In NG, columns with content may be created
after the spanner, resulting in incorrect bounds when querying
legacy layout. To fix this, extend the last column set when building up
the flow thread in NGBlockNode::PlaceChildrenInFlowThread() to
encompass any content after the spanner.
Bug: 1210287
Change-Id: I7604de3645fb8874d4faf193614b5742dc64e17e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2898491
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#885350}
--
wpt-commits: 5ed2294415b70152d0d7d53cc0dd7338a8ccd007
wpt-pr: 29065
Automatic update from web-platform-tests
[GridNG] Baseline second pass
This change updates the GridNG alignment logic to allow for baseline
eligibility to change depending on the phase of grid layout algorithm.
This is accomplished with an optional fallback baseline on GridItemData,
along with some logic to handle baselines being indefinite, depending on
where the algorithm is.
There is a bit of a circular dependency with synthesized baselines - we
cannot determine whether baselines are synthesized without laying out the
item. So this change also separates the concept of baseline eligibility
and the ability to synthesize baselines via the 'CanLayoutGridItem'
helper.
Bug: 1045599
Change-Id: Ifd5f47599cf494faadb330705a638df8c012c95b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2873217
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885295}
--
wpt-commits: 357197316b6a94f94409a7947f036c288c07405a
wpt-pr: 28976
Automatic update from web-platform-tests
WindowProperties returns WindowProxy for named <iframe>s (#29063)
Follow-up of #27970.
--
wpt-commits: 75113f4a0087051b8065cc21ef7ef980ba10b265
wpt-pr: 29063
moz-wptsync-bot
Fredrik Söderqvist
Mattias Buelens
arthursonzogni
Aaron Krajeski
Rune Lillesveen
Manuel Rego Casasnovas
Ana SollanoKim
Matt Wolenetz
Mason Freed
Kurt Catti-Schmidt (SCHMIDT)
Alison Maher
Raymond Toy
Philip Jägenstedt
Oriol Brufau
pyup-bot
Shu-yu Guo
Olga Gerchikov
Ian Kilpatrick
Michael[tm] Smith
Aleks Totic
Lan Wei
L. David Baron
Imanol Fernandez
Tab Atkins Jr
Alexey Shvayka