Depending on the load, this.jsterm might not be
set when switching to the console panel, and can
cause a crash (blank tab).
This patch checks that this.jsterm exists before
taking further actions.
Differential Revision: https://phabricator.services.mozilla.com/D23511
--HG--
extra : moz-landing-system : lando
Summary:
Returning null here leaves us in an infinite loading state because null is treated as neither
success nor failure.
Reviewers: jlast
Bug #: 1534847
Differential Revision: https://phabricator.services.mozilla.com/D23453
Summary:
If users navigate while source text is loading, we need to ignore existing
cached promises because they may resolve and then not actually set the
resulting source, because the source was deleted from the source list.
We want to explicitly use a new cache entry if we have navigated.
Reviewers: jlast
Bug #: 1534847
Differential Revision: https://phabricator.services.mozilla.com/D23452
Summary:
Splitting up this logic makes us less likely to introduce code that would break
the caching behavior. If you look closely at these changes, you'll notice that
there actually one one early return in this code that would cause us to
exit without clearing the 'requests' cache meaning we could get stuck in
an infinite loading state.
Reviewers: jlast
Reviewed By: jlast
Bug #: 1534847
Differential Revision: https://phabricator.services.mozilla.com/D23451
The position of remote browser was not updated by resizing the window and
changing the align of viewport etc, although will be updated when the window
moves, the frame reflows and so on.
Thus, in this patch, update the position of remote browser before showing
context menu so as to locates at proper position.
I investigated though, when reflow and moving happens, the position is updated
by TabParent::UpdateDimensions()[1]. This patch as well is taking an approach
which update the position explicitly by TabParent::UpdateDimensions() before
showing context menu.
[1] https://searchfox.org/mozilla-central/source/dom/ipc/TabParent.cpp#729
Differential Revision: https://phabricator.services.mozilla.com/D23470
--HG--
extra : moz-landing-system : lando
Returning null here leaves us in an infinite loading state because null is treated as neither
success nor failure.
Differential Revision: https://phabricator.services.mozilla.com/D23453
--HG--
extra : moz-landing-system : lando
If users navigate while source text is loading, we need to ignore existing
cached promises because they may resolve and then not actually set the
resulting source, because the source was deleted from the source list.
We want to explicitly use a new cache entry if we have navigated.
Differential Revision: https://phabricator.services.mozilla.com/D23452
--HG--
extra : moz-landing-system : lando
Splitting up this logic makes us less likely to introduce code that would break
the caching behavior. If you look closely at these changes, you'll notice that
there actually one one early return in this code that would cause us to
exit without clearing the 'requests' cache meaning we could get stuck in
an infinite loading state.
Differential Revision: https://phabricator.services.mozilla.com/D23451
--HG--
extra : moz-landing-system : lando
This makes it possible to pass a third parameter which is a XPathResult constant.
Test cases are added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D23307
--HG--
extra : moz-landing-system : lando
Just set the RemoteType in the options object argument, instead of
doubling up the information.
Differential Revision: https://phabricator.services.mozilla.com/D23250
--HG--
extra : moz-landing-system : lando
This makes it possible to pass a third parameter which is a XPathResult constant.
Test cases are added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D21476
--HG--
extra : moz-landing-system : lando
Nicolas Chevobbe
arthur.iakab
Belén Albeza
Razvan Maries
Logan Smyth
Daisuke Akatsuka
David Walsh
Andreea Pavel
Jan Odvarko
Brian Hackett
Dorel Luca
Gabriel Luong
Csoregi Natalia
Dhruvi Butti
yulia
Edwin Gao
Kyle Machulis
lenka
Brindusan Cristian
Noemi Erli