f88647e545
Bug 554822 Caret should refer the actual text color instead of the value of CSS color property r=roc
2010-04-01 11:35:48 +09:00
37b847f135
Bug 554822 backout the previous patch
2010-04-01 02:31:06 +09:00
f1448bab60
Bug 554822 Caret should refer the actual text color instead of the value of CSS color property r=roc
2010-04-01 02:12:43 +09:00
afa4c872e5
Bug 253889: DeCOMtaminate nsIPresShell - IsPaintingSuppressed(). r=roc
...
--HG--
extra : rebase_source : 9ee8283e8bce33402893ae5316f89c9f699a1236
2010-03-31 08:43:49 -04:00
5278cfe428
Backed out changeset 4b8936ac4a31
2010-03-30 19:56:44 -04:00
61dba9a452
Bug 253889: More deCOMtamination of nsIPresShell. r=roc
2010-03-28 19:21:11 -04:00
355d7fd5b3
Bug 544852, part 4: Add nsCaret::GetGeometryForFrame. r=roc
2010-03-14 23:56:26 +01:00
a445269db2
Bug 544852, part 3: Merge UpdateHookRect into UpdateCaretRects. r=roc
2010-03-14 23:54:11 +01:00
06c0d583e4
Bug 544852, part 2: Use nsCaret::GetGeometry. r=roc
2010-03-14 23:52:45 +01:00
e5f8b2f7e8
Bug 544852, part 1: Remove nsCaret::GetCaretCoordinates. r=roc
2010-03-14 23:52:07 +01:00
aeff873bb5
Bug 539323. Position the caret at the content-edge of its container frame, not the border-edge. r=mats
2010-03-05 11:52:59 +13:00
29c9316331
Null-check the root pres context result. Unregister the plugin frame earlier, at Stop instead of Destroy time. b=521426 r=roc
2010-01-26 14:10:12 +01:00
bf02bb9929
Bug 526394. Part 24: Create sane nsCaret::GetGeometry API to obsolete nsCaret::GetCaretCoordinates. r=mats
2010-01-12 10:45:16 +13:00
a1e9364edb
Bug 526394. Part 20: Convert more code in caret and docshell. r=mats
2009-09-09 17:40:02 +12:00
032dc23c67
Flag nsCaret::mPendingDraw if the on-cycle draw was suppressed; update the caret when the pres shell tells us that painting is unsuppressed. b=520720 r=roc
2009-10-16 12:55:32 +02:00
d484947c23
Adjust the caret y-position for zero-height inlines. b=503531 r=roc
2009-09-29 23:07:05 +02:00
dea07412a1
Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc
2009-09-16 17:01:36 +02:00
2d683e020f
Bug 352093. Part 8: Fix view returned for eToplevelWindowCoordinates. r=bzbarsky
2009-07-22 12:45:07 +12:00
78a793c211
Fix for bug 308736 (Caret is invisible when entering an empty designmode field.). r/sr=roc.
...
--HG--
extra : rebase_source : ef79a8ef7cb96c0efcdccc967370fcdf8f07eba4
2009-06-19 18:31:49 +02:00
aa6dce5b49
Bug 406646. Make sure to only search *visible* popups for mouse event targets. r=enndeakin
...
--HG--
extra : rebase_source : bd0825d6a6469a10dcdd9e4ae9e9c91dcbafbe99
2009-02-24 21:25:25 +13:00
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
8231106b44
Fix compiler warnings in nsCaret.cpp. Bug 470574, r+sr=dbaron
2008-12-28 04:08:22 -08:00
890194181a
Make display of the directional hook on the caret dependent on the bidi.browser.ui pref. Bug 418513, r=uriber, sr=roc (for core) r=mano, gavin.sharp (for browser)
2008-12-14 01:05:39 -08:00
775dd33c74
Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron
2008-09-18 21:47:21 +12:00
87878e68eb
Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie)
2008-09-15 17:40:25 +02:00
862b8e5d2b
Bug 453826 - MOZ_XUL define required for nsCaret::IsMenuPopupHidingCaret. r+sr=roc
2008-09-08 15:23:38 +03:00
d504a8c50f
Bug 449955 – Remove #ifdef of nsCaret.cpp for IME r+sr=roc
2008-08-13 10:55:39 +09:00
b006229ae6
Bug 419532 – deCOMtaminate nsICaret. r+sr=roc
2008-07-16 12:52:01 +02:00
0eb449dd2a
Bug 409331. Instead of QIing to nsBlockFrame in various places, call an nsLayoutUtils method to do it. r+sr=roc
2008-07-14 10:10:23 +12:00
c6a1fd787c
Bug 118308, NS_THEME_TEXTFIELD_CARET implementation (GTK), r+sr=roc
2008-06-23 11:50:52 +03:00
9faa7d6380
Remove unnecessary argument from SetBidiEnabled. Bug 435856, r+sr=roc
2008-06-16 02:28:17 -07:00
4707993a0a
Bug 430785: Caret not visible with right-clicking on a text input, patch by Martijn Wargers <martijn.martijn@gmail.com>, r+sr=roc, a=damon
2008-04-30 09:54:16 -07:00
9fe63cd0b9
Bug 335359. Make the caret thicker when it's at a Kanji character. r+sr=mrbkap,a=damon
2008-04-22 20:13:55 -07:00
6eb1cd4a0c
Bug 420987. The caret size should be specified in CSS pixels and it should be rounded like borders --- rounding down to the nearest device pixel, but not down to zero. r+sr=mrbkap,a=schrep
2008-04-14 14:09:23 -07:00
52084d2065
Bug 427163 - "Crash [@ nsContentUtils::ContentIsDescendantOf] with contenteditable, right-clicking and document.write" (add null check) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a1.9=damons]
2008-04-08 23:16:09 -07:00
3ada7e2c40
Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-08 11:52:48 -07:00
e0e0118cf9
Bug 420499 - "Caret browsing mode wrongly engaged" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-01 01:35:11 -07:00
efc1d5a1dd
Bug 400057. Make nsBlockInFlowLineIterator useful for finding the line containing a frame, searching across block continuations and their overflow lines. Use it in various places, especially in textrun construction. r+sr=dbaron
2008-02-27 01:53:48 -08:00
0ac3599db4
Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r=peterv r+sr=roc a1.9=beltzner]
2008-02-26 17:49:46 -08:00
a0a74f16e7
Bug 368760, r=mats, sr=roc, a=blocking1.9+
2007-11-22 12:47:33 -08:00
1ff7b5c5fd
Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=cpearce r=peterv sr=roc a1.9=schrep]
2007-11-12 21:42:52 -08:00
2992eec22e
Bug 403048. Be more careful about looking for the line containing the caret. r+sr=mrbkap
2007-11-08 17:59:20 -08:00
788e2903bf
Bug 336408 - Allow the caret to be positioned at the end of trimmed whitespace, as if the whitespace wasn't trimmed [p=roc r=smontagu sr=mrbkap a=blocking1.9+]
2007-11-07 20:07:00 -08:00
8cf3fb1c90
Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron
2007-10-09 17:00:05 -07:00
f219b51c26
remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc
2007-10-01 16:20:37 -07:00
42675246db
Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron
2007-08-16 20:43:00 -07:00
f055907b89
Redragging over empty text field doesn't show drag caret, except for the last text field. bug 390228, r+sr=roc a=dbaron
2007-08-13 14:33:25 -07:00
dc890e2df6
Clamp the caret's position so that we always draw within the nearest scrollframe. Not doing this allows the scrollframe to clip the caret, causing it to not show up at all. bug 335560, r+sr=roc
2007-08-13 13:51:16 -07:00
f7dd41f11e
Fix for bug 387380 (No visible caret when caret browsing). r=smaug, sr=jst, a=dbaron.
2007-08-10 06:19:13 -07:00
ddf20f3ad6
Bug 390740: Pass lang-group into GetMetricsFor more consistently (general patch). r+sr=roc, a=dbaron
2007-08-07 12:07:43 -07:00
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
6662efd338
Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking.
2007-06-27 19:48:16 -07:00
90c374d7c3
Backing out to fix orange.
2007-06-27 16:21:05 -07:00
7bf2741259
Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking.
2007-06-27 15:29:45 -07:00
4862938c93
Bug 370379: Create views less frequently. Stops creating views for -moz-hidden-unscrollable, opacity, fixed backgrounds, and scrollbars, plus removes some unneeded methods from views and view managers. r+sr=roc.
2007-02-24 00:23:42 +00:00
76a64e5c22
Bug 177805: Fix the use of units in Gecko. r+sr=roc
2007-02-07 07:46:44 +00:00
a39ff30284
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
3c3be786ad
Bug 233348: BiDi marker is hidden when the caret is at the edge of a textarea. Patch by Haamed Gheibi <gheibi@gmail.com>. r=mrbkap sr=roc
2006-11-01 18:31:42 +00:00
38c1e056e9
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, plus some more related refactoring. bug=300131 r+sr=roc
2006-09-11 20:43:01 +00:00
0fa608ce5e
Backing out bug 300131 until I figure out how to deal with the bustage.
2006-09-11 08:03:28 +00:00
95b377fc13
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, and some related refactoring. bug=300131 r+sr=roc
2006-09-11 06:39:56 +00:00
8982c70f78
Moved mCaretBidiLevel and its accessors from nsPresShell to nsFrameSelection. Also added sBidiKeyboard as a static service to nsContentUtils. bug=346891 r+sr=roc
2006-08-08 05:14:52 +00:00
cee7609648
Enable PeekOffset to find the visual beginning/end of a line, and use use it for bidi caret positioning. bug=302051 r=smontagu sr=roc
2006-08-03 06:24:11 +00:00
ca2fdec000
Bug 345371: add null checks for weak pointers in nsCaret. r+sr=roc.
2006-07-20 23:26:05 +00:00
952a1a4a12
Only display a bidirectional caret on platforms that implement nsIBidiKeyboard. Bug 272096, r+sr=roc
2006-07-06 08:29:53 +00:00
9f87463b44
Only recalculate the caret's rect when we're not currently drawn in an attempt to avoid caret turds when we're being notified of the caret movement after the frame has already been marked dirty. bug 335834, r+sr=roc
2006-05-04 00:05:22 +00:00
695809a291
Update the caret position after reflows to avoid turds. bug 334649, r+sr=roc
2006-04-28 04:33:41 +00:00
4667a9b409
Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
2006-04-26 01:57:22 +00:00
8cde2f4313
Make the caret paint in the same color as the foreground so it's not always painted black. bug 334635, r+sr=roc
2006-04-21 19:13:58 +00:00
e27b36efcc
Draw the caret in the normal path of frame painting instead of doing it directly to the current view. bug 287813, r+sr=roc
2006-04-17 23:16:46 +00:00
5dcd0b1309
One-line descriptions of files, partly because they show up in LXR.
2006-03-30 05:56:38 +00:00
ba0d30b880
In nsTextEditRules::CheckBidiLevelForDeletion(), use nsSelection::GetPrevNextBidiLevels to determine bidi levels. bug=330460 r=smontagu sr=roc
2006-03-23 08:20:29 +00:00
d999b33cff
Bug 305798: Bidi: After deleting last character of reverse-direction text, arrow keys move caret incorrectly. Patch by Uri Bernstein <uriber@gmail.com, r=smontagu, sr=roc
2005-11-16 09:37:01 +00:00
045ce7774f
Bug 311399, Crash [@ SetOrigin] during rendering context destruction. Remove QD save/restore from rendering context, it was placed there as a workaround for scrollbar functional and aesthetic bugs. Add OS event handler to fix aesthetic problems, and check for bad states to work around functional problems. r=josh sr=smfr
2005-11-10 03:46:52 +00:00
e7ed3d82a7
Bug 313918 IME candidate list is positioned to wrong position if the caret is positioned non-root view r+sr=roc
2005-10-29 12:43:51 +00:00
344b4be95e
Bug 311152. Make DOM selection changes repaint the caret in the new position. r=mrbkap,sr=dbaron
2005-10-12 18:40:38 +00:00
fd97041e21
Bug 193316. Caret not visible in readonly fields (HTML or XUL). r=mrbkap, sr=smfr
2005-10-04 03:14:03 +00:00
f048b80534
Caret drawn at incorrect position after typing a single LTR character in a blank RTL input field (or vice versa) while caret is visible. b=307533 r=uriber sr=bzbarsky
2005-09-10 11:14:48 +00:00
5187e69f5f
bug 303399: Bidi: Problems with caret positioning on blank lines. Patch by Uri Bernstein <uriber@gmail.com>. r=mrbkap sr=roc
2005-08-24 17:44:28 +00:00
decb76621e
Erase caret if needed when content is removed. b=304383 r=mrbkap sr=bzbarsky
2005-08-22 00:25:20 +00:00
b3f31d48d4
Don't use a Frame pointer to remember where we last painted the caret, instead use Content+offset+hint. b=296464 r=mrbkap sr=roc a=cbeard
2005-08-11 03:44:16 +00:00
be6760da53
Windows CE build changes. This addresses most of the outstanding Windows
...
CE compilation issues.
This patch also fixes/removes CheckStackGrowthDirection assertions in
Javscript. This change is based on bug 242518. See comment 36.
This patch also removes the unused enum in transformiix . See bug
292118.
r/sr = dveditz/shaver
b = 291229
a = asa
2005-04-29 13:33:49 +00:00
a3c9fa1b01
Account for the view's origin not lining up with the widget's. b=190290 r=bzbarsky sr=roc
2005-03-26 14:50:09 +00:00
f01adb747a
Fix crashes in GTK1 builds due to reuse of rendering contexts for the caret.
...
Bug 254049, patch by Mark Banner <mark@standard8.demon.co.uk>, r=jst, sr=roc
2005-02-01 21:19:05 +00:00
f575a675b2
Remove nsIAutoCopy and fold the functionality into nsSelection.cpp (bug 231343). r+sr=roc.
2005-01-31 23:47:26 +00:00
d3197a9276
remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron
2004-12-26 19:48:54 +00:00
52ff1c323f
Prevent the right-to-left directional hook from overlapping the caret and make both directions thinner. Bug 264903, r=mkaply, aaronleventhal, sr=rbs.
2004-11-30 19:28:00 +00:00
a45fb5a046
Don't use QueryInterface to get a scrollable view from a view b=258521 r+sr=roc
2004-11-24 00:19:21 +00:00
903bd845ea
Try landing the fix for infamous Bug #98564 again -->
...
caret overlaps the last character in textfield (if positioned after the last char)
r=smontagu
sr=sfraser
We think this patch can land again because the regression it introduced was fixed by
Bug #216101 which does a better job of clearing out caret fragments.
2004-11-10 07:14:08 +00:00
cd89107e7e
Fixing bustage
2004-10-13 02:24:38 +00:00
ca0cd1c767
Bug 261054. Make caret consistently the same width throughout Gecko/Mozilla. Configurable through ui.caretWidth. r=glazou, sr=rbs
2004-10-13 01:12:14 +00:00
6a4f37de6b
Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc
2004-09-20 22:25:07 +00:00
d082d2bf5e
More nsIPresShell deCOMtamination:
...
- Made Get/SetAuthorStyleDisabled and ReconstructStyleData non-virtual when called internally.
- Inlined GetFrameSelection and renamed it to FrameSelection.
- Removed non-inline version of GetViewManager.
- Removed unused EnablePrefStyleRules and ArePrefStyleRulesEnabled.
Bug 253889, r+sr=roc.
2004-08-29 03:08:44 +00:00
180b0b7373
Remove refcounting version of nsIPresShell::GetPresContext. Bug 253889, r+sr=roc.
2004-08-20 20:34:37 +00:00
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
8f71882950
Bug 241507
...
Don't create new rendering contexts for each caret drawn on *nix platforms since there are no known issues with doing so. If issues crop up, I will undo this change.
r/sr=jst/bryner
2004-06-29 19:12:19 +00:00
ed766b9ccb
Bug 216101 Cleaing frame refs can leave caret fragments p=mnyromyr@tprac.de r/sr=roc
2004-06-25 09:57:35 +00:00
97a65f9548
Get rid of nsILanguageAtom and deCOMtaminate nsILanguageAtomService (bug 230603). Also, fix a bunch of atom double-addref leaks in nsFontMetricsXlib. r+sr=dbaron.
2004-06-08 23:53:59 +00:00
Masayuki Nakano
Craig Topper
Kyle Huey
Mats Palmgren
Robert O'Callahan
Peter Van der Beken
Benjamin Smedberg
Simon Montagu
Arpad Borsos
Oleg Romashin
John Daniels
Karuna (karunasagark@gmail.com)
Michael Ventnor
gavin@gavinsharp.com
roc+@cs.cmu.edu
reed@reedloden.com
Olli.Pettay@helsinki.fi
tglek@mozilla.com
joshmoz@gmail.com
philringnalda@gmail.com
mrbkap@gmail.com
sharparrow1@yahoo.com
jwalden@mit.edu
sharparrow1%yahoo.com
cvshook%sicking.cc
uriber%gmail.com
smontagu%smontagu.org
mrbkap%gmail.com
roc+%cs.cmu.edu
dbaron%dbaron.org
mark%moxienet.com
masayuki%d-toybox.com
aaronleventhal%moonset.net
mats.palmgren%bredband.net
dougt%meer.net
bzbarsky%mit.edu
bryner%brianryner.com
bmlk%gmx.de
neil%parkwaycc.co.uk
scott%scott-macgregor.org
caillon%redhat.com