ebf99d6f4f
Bug 1590948 - Properly inspect `context` param when handling `fxa_status` webchannel message. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D50408
--HG--
extra : moz-landing-system : lando
2019-10-25 00:23:09 +00:00
23c6504831
Bug 1590486 - Fix eslint failure. r=eslint-fix
2019-10-24 06:58:21 +03:00
274e0280b0
Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D50359
--HG--
extra : moz-landing-system : lando
2019-10-24 03:30:57 +00:00
4a5ba28d8a
Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D49805
--HG--
extra : source : b300b58faf473a242d4ed3428a97dec17bcd862c
2019-10-23 17:49:51 +00:00
68edcb2abb
Backed out changeset b300b58faf47 (bug 1588948) for browser chrome failures on test_basic_form_autocomplete.html.
2019-10-24 02:06:37 +03:00
291e0d381d
Backed out changeset c5503bc49a73 (bug 1590486) for xpc failures on test_web_channel.js.
2019-10-24 02:04:03 +03:00
8fff38140a
Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D49805
--HG--
extra : moz-landing-system : lando
2019-10-23 17:49:51 +00:00
75ea9bc416
Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D50359
--HG--
extra : moz-landing-system : lando
2019-10-23 21:21:23 +00:00
5033d599b4
Backed out changeset 3d7b77564cb7 (bug 1238810) for bc perma failures in browser_startup.js on a CLOSED TREE
2019-10-24 00:38:10 +03:00
b8fe187695
Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
...
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment
Differential Revision: https://phabricator.services.mozilla.com/D49166
--HG--
extra : moz-landing-system : lando
2019-10-15 22:57:58 +00:00
c7e19ee271
Bug 1579334 - Properly limit remote tab matches in the quantumbar. r=mak
...
This is a narrow patch that simply adds a `maxMatches` param to `PlacesRemoteTabsAutocompleteProvider.getMatches`.
Differential Revision: https://phabricator.services.mozilla.com/D50019
--HG--
extra : moz-landing-system : lando
2019-10-22 15:22:48 +00:00
12dd37165b
Bug 1574051 - make FxA's session/account status checking sane and understandable. r=rfkelly,mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D49689
--HG--
extra : moz-landing-system : lando
2019-10-22 00:58:36 +00:00
9a28c6748d
Bug 1574052 - only return public fields from fxAccounts.getSignedInUser(). r=rfkelly,eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D49525
--HG--
extra : moz-landing-system : lando
2019-10-22 00:57:27 +00:00
2b0d2dd8e7
Merge autoland to mozilla-central. a=merge
2019-10-22 00:50:23 +03:00
4c889635b4
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D49928
--HG--
extra : moz-landing-system : lando
2019-10-21 13:23:30 +00:00
716fe01e26
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D49605
--HG--
extra : moz-landing-system : lando
2019-10-17 14:34:51 +00:00
7b3edc3d02
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2019-10-21 18:00:38 +00:00
a0d2e56628
Bug 1588329 - Centralize array chunking in `PlacesUtils.chunkArray`. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D49072
--HG--
extra : moz-landing-system : lando
2019-10-15 21:23:07 +00:00
b6eeb7d5d3
Backed out changeset 35d4451f348d (bug 1588458) as requested by the dev
2019-10-15 19:04:22 +03:00
0f71aeba53
Bug 1588458 - Replace dxr by searchfox in the doc r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D49140
--HG--
extra : moz-landing-system : lando
2019-10-15 15:27:13 +00:00
9b996482ca
Bug 1567196 - Ignore invalid password date values. r=markh
...
Depends on D48941
Differential Revision: https://phabricator.services.mozilla.com/D49218
--HG--
extra : moz-landing-system : lando
2019-10-15 00:23:42 +00:00
0481284ac7
Bug 1583897 - Send a telemetry event for new sendtab. r=tcsc,eoger,lina
...
Differential Revision: https://phabricator.services.mozilla.com/D48153
--HG--
extra : moz-landing-system : lando
2019-10-14 22:17:28 +00:00
c7296e7825
Bug 1587769 - update the pref we watch to ensure we sync immediately after device name change. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D49102
--HG--
extra : moz-landing-system : lando
2019-10-14 16:30:27 +00:00
cbc7251ad9
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D49151
--HG--
extra : moz-landing-system : lando
2019-10-14 13:16:30 +00:00
5ac45f3f35
Bug 1588018 - Remove remaining event telemetry from the bookmarks mirror. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D49049
--HG--
extra : moz-landing-system : lando
2019-10-14 00:22:10 +00:00
1b362fb843
Bug 1587837 - better checking of the Firefox Account password changing. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D48936
--HG--
extra : moz-landing-system : lando
2019-10-11 16:41:44 +00:00
25eb2d60df
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D48410
--HG--
extra : moz-landing-system : lando
2019-10-11 17:06:57 +00:00
eb350d4f6b
Backed out changeset 4695136f7e82 (bug 1549049) for assertion failures at ErrorResult.h on a CLOSED TREE
2019-10-11 00:53:42 +03:00
136a86deed
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D48410
--HG--
extra : moz-landing-system : lando
2019-10-10 21:08:01 +00:00
b559ec6b1b
Bug 1587691 - Firefox Accounts webchannel message should allow login without engine choices. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D48797
--HG--
extra : moz-landing-system : lando
2019-10-10 16:57:42 +00:00
8d4072c53b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D48836
--HG--
extra : moz-landing-system : lando
2019-10-10 14:38:00 +00:00
79a871cd9c
Bug 1577690 - WebChannel support for optional Sync. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46316
--HG--
extra : moz-landing-system : lando
2019-10-08 15:19:23 +00:00
da3f0d0753
Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46517
--HG--
extra : moz-landing-system : lando
2019-10-08 15:45:06 +00:00
9c27546918
Backed out changeset 6852bdb8d8c5 (bug 1581709) for Linting failures. CLOSED TREE
2019-10-08 18:42:11 +03:00
1093781abc
Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46517
--HG--
extra : moz-landing-system : lando
2019-10-08 14:19:11 +00:00
44a0e91fcd
Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D48272
--HG--
extra : moz-landing-system : lando
2019-10-07 15:25:38 +00:00
5a0922f7cb
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D48342
--HG--
extra : moz-landing-system : lando
2019-10-07 13:11:07 +00:00
397d3a1156
Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
...
Instead of using the list of FxA devices from the Sync clients engine,
we now fetch the list of Send Tab devices from FxA. This works like
this:
* `FxAccountsDevice#getDeviceList` has been split up into
`recentDeviceList` and `refreshDeviceList`.
* `recentDeviceList` synchronously returns the last fetched list, so
that consumers like Send Tab can use it right away.
* `refreshDeviceList` is asynchronous, and refreshes the last fetched
list. Refreshes are limited to once every minute by default, matching
the minimum sync interval (Send Tab passes the `ignoreCached` option
to override the limit if the user clicks the "refresh" button).
Concurrent calls to `refreshDeviceList` are also serialized, to
ensure the list is only fetched once.
* The list is flagged as stale when a device is connected or
disconnected. It's still kept around, but the next call to
`refreshDeviceList` will fetch a new list from the server.
* The Send Tab UI refreshes FxA devices in the background. Matching FxA
devices to Sync client records is best effort; we don't do it if Sync
isn't configured or hasn't run yet. This only impacts the fallback
case if the target doesn't support FxA commands.
Differential Revision: https://phabricator.services.mozilla.com/D47521
--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:55 +00:00
51e03623ee
Bug 1583413 - Move device-related methods into `FxAccountsDevice.jsm`. r=eoger
...
This commit contains no functional changes, just moving code around to
make the next patch in this series easier to write.
Differential Revision: https://phabricator.services.mozilla.com/D47520
--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:41 +00:00
9238ced3bb
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D48055
--HG--
extra : moz-landing-system : lando
2019-10-03 13:40:24 +00:00
47380e1a34
Bug 1581980 - change the text of many Sync notifications so they aren't Sync specific. r=flod,eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D47853
--HG--
extra : moz-landing-system : lando
2019-10-03 05:52:58 +00:00
51a55ec4ba
Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D47861
--HG--
extra : moz-landing-system : lando
2019-10-03 01:18:09 +00:00
11b09d510c
Backed out changeset 961eac228e3e (bug 1585299) for ES Lint failures on FxAccounts.jsm && test_accounts.js CLOSED TREE
2019-10-02 09:41:37 +03:00
c0a71bf7f1
Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
...
Differential Revision: https://phabricator.services.mozilla.com/D47861
--HG--
extra : moz-landing-system : lando
2019-10-02 06:03:39 +00:00
499384cb8e
Bug 1585211 - Have TPS enable sync when the test user logs in. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D47714
--HG--
extra : moz-landing-system : lando
2019-10-01 00:32:01 +00:00
8a664f77d8
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D47597
--HG--
extra : moz-landing-system : lando
2019-09-30 13:11:37 +00:00
c9b081d8c9
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D47244
--HG--
extra : moz-landing-system : lando
2019-09-26 14:33:06 +00:00
4b629788b2
Bug 1570567 - update about:preferences#sync to reflect the decoupling of FxA and Sync. r=Gijs,eoger,flod,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D46574
--HG--
extra : moz-landing-system : lando
2019-09-26 10:48:22 +00:00
7ec2097ae8
Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
...
Differential Revision: https://phabricator.services.mozilla.com/D46572
--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
dcb380399e
Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
...
Most of these tests have been disabled for a long time; they run well
in the current test environment.
Differential Revision: https://phabricator.services.mozilla.com/D46642
--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
5431bbfab3
Bug 1547120 - Add a method to list attached clients. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D46838
--HG--
extra : moz-landing-system : lando
2019-09-23 20:43:56 +00:00
bdeece726d
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D46777
--HG--
extra : moz-landing-system : lando
2019-09-23 13:09:04 +00:00
7f39ae82a2
Bug 1582542 - Use getUserAccountData in FxA commands invoke. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46511
--HG--
extra : moz-landing-system : lando
2019-09-19 19:51:41 +00:00
959ff7f82f
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D46469
--HG--
extra : moz-landing-system : lando
2019-09-19 14:37:28 +00:00
3017be71f8
Bug 1582537 - Call getScopedKeys on keys field. r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D46509
--HG--
extra : moz-landing-system : lando
2019-09-19 19:28:48 +00:00
7531325c86
Bug 1582023 - Replace "sync disconnect" dialog and local data removal with simple confirmation dialog. r=eoger,flod,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D46253
--HG--
extra : moz-landing-system : lando
2019-09-19 05:59:51 +00:00
140dc3f765
Bug 1578217 - remove the sync 'yellow state' telemetry. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D45765
--HG--
extra : moz-landing-system : lando
2019-09-19 00:34:04 +00:00
1ba181f8bf
Bug 1581160 - Prepackage url-classifier-skip-urls into the binaries; r=leplatrem,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D45871
--HG--
extra : moz-landing-system : lando
2019-09-13 16:26:57 +00:00
a6c404619f
Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D44485
--HG--
extra : moz-landing-system : lando
2019-09-10 18:23:31 +00:00
926c5d067c
Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D44484
--HG--
extra : moz-landing-system : lando
2019-09-11 01:17:46 +00:00
5af1f73d04
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D45662
--HG--
extra : moz-landing-system : lando
2019-09-12 13:37:51 +00:00
0203cd1dd5
Bug 1574048 - Remove FxAccounts internal/external/Object.freeze()/ weirdness. r=lina,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D44083
--HG--
extra : moz-landing-system : lando
2019-09-12 02:08:50 +00:00
e074186422
Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D43897
--HG--
extra : moz-landing-system : lando
2019-09-11 01:37:50 +00:00
0f5e9e5206
Backed out changeset 93d2d4bbe263 (bug 1575921) for xpcshell failures on test_device.js CLOSED TREE
2019-09-10 04:42:15 +03:00
15535c9309
Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D43897
--HG--
extra : moz-landing-system : lando
2019-09-10 00:09:52 +00:00
426de7d9bd
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2019-09-02 09:00:31 +00:00
3b375c8b7b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D43967
--HG--
extra : moz-landing-system : lando
2019-08-29 13:14:59 +00:00
43084d5e54
Bug 1577218 - Upgrade kinto-offline-client to 12.7.0 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D43773
--HG--
extra : moz-landing-system : lando
2019-08-28 16:08:29 +00:00
d264b841c9
Bug 1576502 - Fix some wording issues r=mhoye
...
Differential Revision: https://phabricator.services.mozilla.com/D43363
--HG--
extra : moz-landing-system : lando
2019-08-27 15:38:58 +00:00
b2c8b8875b
Bug 1572711 - Record extensions.blocklist.useXML and services.blocklist.*.checked prefs into new telemetry scalars. r=janerik,leplatrem,Gijs
...
Depends on D41734
Differential Revision: https://phabricator.services.mozilla.com/D41735
--HG--
extra : moz-landing-system : lando
2019-08-22 16:32:19 +00:00
409e5b7a75
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D43052
--HG--
extra : moz-landing-system : lando
2019-08-22 13:43:50 +00:00
c2a3916396
Bug 1574382 - use yaml to parse TPS tests. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D42263
--HG--
extra : moz-landing-system : lando
2019-08-19 20:55:05 +00:00
9a123fb597
Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE
2019-08-19 13:00:44 +03:00
240771fa29
Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D40614
--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
b1970e6a2f
Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
...
These are raised as redeclares or unused variables by ESLint 6.
Differential Revision: https://phabricator.services.mozilla.com/D37268
--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
a17323e9d8
Bug 1573709 - Return an aborted watchdog for testing interrupted bookmark merges. a=testonly
...
Differential Revision: https://phabricator.services.mozilla.com/D41876
--HG--
extra : moz-landing-system : lando
2019-08-14 00:28:52 +00:00
65dfa84ccd
Bug 1573305 - Remove the check for unmerged synced bookmark changes. r=markh
...
When a local or remote item changed, we'd potentially scan three tables
(with an expensive `LEFT JOIN`!) to check if anything changed...then
scan the same tables again to build the local and remote trees. This
check was originally meant to avoid unnecessary merges. However, the
bottleneck isn't merging now; it's reading from the database.
Since the merger has been rewritten in Rust, is synchronous, doesn't
keep a transaction open for the entire merge (see the
`total_sync_changes` check), and only emits ops for items that actually
changed, it's more efficient to build and merge optimistically, and
bail before applying if nothing changed.
This commit also moves `validateLocalRoots` into Rust.
Differential Revision: https://phabricator.services.mozilla.com/D41690
--HG--
extra : moz-landing-system : lando
2019-08-13 22:58:16 +00:00
19557885f6
Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh
...
This commit introduces a new `Watchdog` class that signals an abort,
either after a delay or at shutdown, and wires up the buffered engine
to use it.
Differential Revision: https://phabricator.services.mozilla.com/D41311
--HG--
extra : moz-landing-system : lando
2019-08-13 18:48:25 +00:00
21d02cb6fe
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D41541
--HG--
extra : moz-landing-system : lando
2019-08-12 13:08:23 +00:00
41a012cce7
Bug 1572621 - Merge services-sync.js into all.js. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D41323
--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:41 +00:00
73d5a12400
Bug 1572621 - Merge services-common.js into all.js. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D41322
--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:27 +00:00
0d63b1e98f
Bug 1498073 - Use centisecond precision for modified times in Sync tests. a=testonly
...
Differential Revision: https://phabricator.services.mozilla.com/D41266
--HG--
extra : moz-landing-system : lando
2019-08-08 19:19:47 +00:00
22ae3511f6
Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D40878
--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:36 +00:00
844afcfb06
Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
...
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
9cf685253f
Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D40878
--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:51 +00:00
05df0254b8
Bug 1568353 - set the default rest.js timeout to be 5 minutes. r=rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D40927
--HG--
extra : moz-landing-system : lando
2019-08-07 05:25:49 +00:00
40d28c338b
Bug 1561762 - better handle concurrent requests for FxA oauth tokens. r=eoger,rfkelly
...
Differential Revision: https://phabricator.services.mozilla.com/D38036
--HG--
extra : moz-landing-system : lando
2019-08-06 15:25:05 +00:00
9320172d8f
Bug 1567238 - Refactor the bookmarks mirror merge triggers to do less work. r=tcsc,markh
...
This commit reduces the number of database writes and table scans
needed to merge synced bookmarks.
* Remove `fetchNew{Local, Remote}Contents`. Fetching the tree already
scans the table, so we can piggyback on it to fetch content info for
deduping.
* Store completion ops in temp tables to only update changed parts of
the local tree, and remove the `mergeStates` table and views.
* Replace the `itemsToMerge` view with an indexed `itemsToApply` temp
table.
* Replace the `updateGuidsAndSyncFlags` trigger with a `changeGuidOps`
table and a `changeGuids` trigger.
* Replace the `updateLocalItems` trigger with an `apply_remote_items`
function to bulk upsert new and updated items.
* Replace the `structureToMerge` view with an
`applyNewLocalStructureOps` table that holds parents and positions
for moved items, and an `applyNewLocalStructure` trigger to update
them.
* Remove tombstones for revived items, update change counters, and flag
mirror items as merged directly in `update_local_items_in_places`,
instead of indirecting through temp tables.
* Don't mark items flagged for reupload as merged, since we'll write
them back to the mirror after upload.
* Use a scalar subquery instead of a join in the `localTags` view to
look up the tags root ID.
* Replace `relatedIdsToReupload` with a `Store::prepare` method that
flags all bookmarks with keyword-URL mismatches for reupload.
* Trigger frecency updates for origins once, not for every item.
* Remove two extra scans on `itemsAdded` and `itemsChanged` when
recording observer notifications for changed keywords.
* Notify all `bookmark-added` listeners in a single batch.
This also fixes some edge cases:
* Update root positions correctly after deleting a non-syncable root
or item.
* Keyword-URL mismatches may reupload more items than before, but now
ensure that all bookmarks with the same URL have the same keyword.
* Only set items with deduped GUIDs to `SYNC_STATUS_NORMAL` after
merging.
* Bump the last modified time for modified items only.
Differential Revision: https://phabricator.services.mozilla.com/D39889
--HG--
extra : moz-landing-system : lando
2019-08-06 23:48:03 +00:00
6dfb6ea6a1
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D40198
--HG--
extra : moz-landing-system : lando
2019-08-01 13:24:01 +00:00
f172f95ac0
Bug 1568341 - Part 4: Pre-package the anti-tracking-url-decoration.json remote settings bucket for new profiles or fresh upgrades; r=leplatrem
...
Differential Revision: https://phabricator.services.mozilla.com/D39922
--HG--
extra : moz-landing-system : lando
2019-07-31 19:32:07 +00:00
940333a24b
Bug 1566591: catch and log RemoteSettings errors r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D39824
--HG--
extra : moz-landing-system : lando
2019-07-30 19:39:03 +00:00
68a314f460
Bug 1569894 - Upgrade kinto-http-client.js to 4.7.3 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D39852
--HG--
extra : moz-landing-system : lando
2019-07-30 13:32:45 +00:00
9ee911f801
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D39676
--HG--
extra : moz-landing-system : lando
2019-07-29 13:29:43 +00:00
b7828720b0
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D39331
--HG--
extra : moz-landing-system : lando
2019-07-25 13:20:25 +00:00
684e965f89
Bug 1556276 p2 - Build metrics-flow and legal FxA URLs. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D39033
--HG--
extra : moz-landing-system : lando
2019-07-25 01:12:31 +00:00
1c060fbfab
Bug 1556276 p1 - Allow extraParams to be passed when constructing FxA URLs. r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D39032
--HG--
extra : moz-landing-system : lando
2019-07-24 18:34:06 +00:00
5cb0d4bf75
Bug 1563180 - Prevent synchronization to be ran in parallel multiple times r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36921
--HG--
extra : moz-landing-system : lando
2019-07-22 13:50:04 +00:00
fb1ef8ec44
Bug 1567376 - remove support for the old custom FxA server prefs. r=eoger
...
Differential Revision: https://phabricator.services.mozilla.com/D38616
--HG--
extra : moz-landing-system : lando
2019-07-19 17:31:21 +00:00
28af937c05
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D38478
--HG--
extra : moz-landing-system : lando
2019-07-18 12:58:04 +00:00
60f4926fea
Bug 1564131 - re-enable syncing of builtin themes. r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D37837
--HG--
extra : moz-landing-system : lando
2019-07-18 01:25:50 +00:00
4ede446d10
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D38063
--HG--
extra : moz-landing-system : lando
2019-07-15 17:06:26 +00:00
55b47893cf
Bug 1541496 - Ensure storage.sync does sync the data for previously synced extensions without an active extension context. r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D37413
--HG--
extra : moz-landing-system : lando
2019-07-11 14:30:20 +00:00
7c0acde6a7
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D37716
--HG--
extra : moz-landing-system : lando
2019-07-11 12:55:28 +00:00
8478c8b076
Merge autoland to mozilla-central. a=merge
2019-07-09 06:43:17 +03:00
6ca9b306bd
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
2019-07-08 17:27:36 +00:00
6e3840ddec
Backed out changeset 7aa8180f36eb (bug 1563180) for ESlint failure
2019-07-06 19:43:30 +03:00
4039e268d2
Bug 1563180 - Prevent synchronization to be ran in parallel multiple times r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36921
--HG--
extra : moz-landing-system : lando
2019-07-06 16:05:12 +00:00
326c302870
Bug 1563213 - Upgrade kinto-http-client.js to 4.7.2 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36752
--HG--
extra : moz-landing-system : lando
2019-07-05 13:45:56 +00:00
31441f82ea
Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D35504
--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
18132fb6de
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D37242
--HG--
extra : moz-landing-system : lando
2019-07-08 12:47:22 +00:00
34c33b48c4
Bug 1561435 - Fix linting errors for services/, r=standard8
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35931
--HG--
extra : source : f441e31c307bc815c7f05e99c0cd8ee77344dc80
extra : intermediate-source : 7e366ab79479e3a9bbdf9e61f04cfa7b6c271990
2019-06-21 13:38:54 -07:00
9d673f1f0f
Bug 1561435 - Format services/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35930
--HG--
extra : source : 073567e8ded785e46382ba7e402d8da939a69d7b
2019-07-05 10:58:22 +02:00
b5a4cb3848
Bug 1558517 - Pre 3.0: Remove conflicting eslint rules, and turn on "curly: all" everywhere, r=standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D34535
--HG--
extra : source : 74ed7ee773393d305c4e948a57a1b1e32b1f12e8
extra : intermediate-source : 403d0757d61683e0a85d0bb07768eb39fbd0af72
2019-06-28 17:14:01 +02:00
56afa0ab7c
Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D35240
--HG--
extra : moz-landing-system : lando
2019-07-04 15:15:48 +00:00
c3dff17808
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D36908
--HG--
extra : moz-landing-system : lando
2019-07-04 13:06:12 +00:00
e661f9a03d
Bug 1558710 - Make sure clients never try to push local changes r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36718
--HG--
extra : moz-landing-system : lando
2019-07-03 13:41:21 +00:00
bba7a6fe2b
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D36484
--HG--
extra : moz-landing-system : lando
2019-07-01 13:15:39 +00:00
3e347218c9
Bug 1560451 - Fix duplicates in list of created on sync event r=glasserc
...
Depends on D36171
Differential Revision: https://phabricator.services.mozilla.com/D36182
--HG--
extra : moz-landing-system : lando
2019-06-27 13:40:24 +00:00
0cf601cfff
Bug 1559158 - Improve performance of sync for large collections r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D36171
--HG--
extra : moz-landing-system : lando
2019-06-27 13:25:57 +00:00
ab68b05adf
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D36187
--HG--
extra : moz-landing-system : lando
2019-06-27 12:57:42 +00:00
eb9461aa93
Bug 1508973 - Remove getAnnotationsForItem and unused bookmark annotations APIs. r=Standard8,lina
...
Differential Revision: https://phabricator.services.mozilla.com/D35009
--HG--
extra : moz-landing-system : lando
2019-06-25 15:21:53 +00:00
adf91feaf8
Bug 1538015 (part 2) - restrict when incoming synced prefs are applied. r=tcsc,pauljt,Gijs
...
Specifically, a "control pref" for a pref must already exist locally, or
a new preference, `services.sync.prefs.dangerously_allow_arbitrary` must
be set to true.
This also removes a few preferences from the set we sync by default based
due to potential harm which can be caused syncing inappropriate values.
Differential Revision: https://phabricator.services.mozilla.com/D29775
--HG--
extra : moz-landing-system : lando
2019-06-25 04:40:58 +00:00
e5bb9b8a73
Bug 1538015 (part 1) - test only change to tighten up the checks being made. r=tcsc
...
This is a test-only change to make the existing synced prefs tests more
explicit about values being checked and moves a couple of prefs around to make
things a bit clearer, which should make the test changes in part 2 clearer.
Differential Revision: https://phabricator.services.mozilla.com/D29774
--HG--
extra : moz-landing-system : lando
2019-06-25 04:40:41 +00:00
2e091fbe26
Backed out 2 changesets (bug 1559514) for failures in browser_CTP_plugins.js CLOSED TREE
...
Backed out changeset 157999f49345 (bug 1559514)
Backed out changeset f31cd670c9ac (bug 1559514)
2019-06-21 02:00:18 +03:00
4fcd8eaee9
Bug 1559514 - Emit sync event when up-to-date if JSON dump is loaded r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D35240
--HG--
extra : moz-landing-system : lando
2019-06-20 19:02:31 +00:00
5a828c9d6d
Bug 1559514 - Emit sync event when JSON dump is loaded from .get() r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D35239
--HG--
extra : moz-landing-system : lando
2019-06-20 20:45:55 +00:00
91d0636848
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D35423
--HG--
extra : moz-landing-system : lando
2019-06-20 15:37:06 +00:00
31482b455c
Bug 1559114 - Optimize signature verification of Remote Settings dumps r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D34879
--HG--
extra : moz-landing-system : lando
2019-06-18 23:17:50 +00:00
1d103e317f
Bug 1559114 - Improve debug logging of Remote Settings r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D34878
--HG--
extra : moz-landing-system : lando
2019-06-18 23:17:47 +00:00
b3eeba3ad1
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D35180
--HG--
extra : moz-landing-system : lando
2019-06-17 14:27:42 +00:00
6a9bae1546
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D34868
--HG--
extra : moz-landing-system : lando
2019-06-13 13:48:29 +00:00
c36f7aecc7
Bug 1550967 - ensure sync's username pref is set whenever FxA has a user. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D34309
--HG--
extra : moz-landing-system : lando
2019-06-13 01:32:07 +00:00
94be713565
Bug 1558812 - Upgrade kinto-offline-client to 12.4.3 r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D34715
--HG--
extra : moz-landing-system : lando
2019-06-12 14:20:59 +00:00
9de72a3ac6
Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
...
Differential Revision: https://phabricator.services.mozilla.com/D34196
--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
a102f01554
Bug 1543598 - Move OneCRL and Pinning blocklist clients out of services r=jcj,glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32297
--HG--
rename : services/common/tests/unit/test_blocklist_onecrl.js => security/manager/ssl/tests/unit/test_blocklist_onecrl.js
rename : services/common/tests/unit/test_blocklist_pinning.js => security/manager/ssl/tests/unit/test_blocklist_pinning.js
extra : moz-landing-system : lando
2019-06-11 10:14:40 +00:00
d70372dc0c
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D34344
--HG--
extra : moz-landing-system : lando
2019-06-10 13:57:19 +00:00
3f89105d67
Backed out changeset 4f2475241df7 (bug 1550473) on request from ckerschb. a=backou
...
--HG--
extra : rebase_source : 8297426f6df40a9dc94fccf514ba3f4efa88889e
2019-06-06 15:33:55 +02:00
d3751d4293
Bug 1555771 - Update Sync and FxA illustrations. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D33234
--HG--
extra : moz-landing-system : lando
2019-06-05 17:46:54 +00:00
ad6b27eaf9
Bug 1556761 - Stop logging 'Initialize remote settings' all the time r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D33692
--HG--
extra : moz-landing-system : lando
2019-06-05 08:05:43 +00:00
7d5f0874a4
Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/fxaccounts/ r=vladikoff
...
Differential Revision: https://phabricator.services.mozilla.com/D33348
--HG--
extra : moz-landing-system : lando
2019-06-05 03:59:55 +00:00
e7afdd4c3e
Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/sync/ r=markh,tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D33347
--HG--
extra : moz-landing-system : lando
2019-06-05 03:59:46 +00:00
ede2c0b68a
Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith
...
Before this commit, we used event telemetry to record timing and counts
for the different steps of a bookmark merge (fetching the local tree,
new local contents, remote tree, and new remote contents; merging;
applying; fetching outgoing records; and notifying observers).
This has several limitations. We need to store all numbers as strings,
include a "flow ID" to tag events from the same merge, and collect
failure reasons twice. We also can't correlate these events to the
existing engine telemetry, meaning we can't see other stats for that
engine, or for the entire sync. Finally, we need to run separate
queries on these events for analysis, instead of extending our
existing engine dashboards.
This approach also feels like an abuse of event telemetry, so this
commit adds a "steps" field for each engine in the Sync ping. Each step
has a name, time taken, and additional named counts, like the number of
items in the tree, or merged structure stats.
Currently, only the `buffered-bookmarks` engine records these steps.
Differential Revision: https://phabricator.services.mozilla.com/D33411
--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:07 +00:00
efa5e0cc06
Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc
...
Differential Revision: https://phabricator.services.mozilla.com/D33410
--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:51 +00:00
0c9500bf00
Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc
...
This commit introduces a `mozISyncedBookmarksMirrorProgressListener`
interface for capturing telemetry and updating shutdown blocker state
after each step of the merge, instead of waiting until the end. This
also means we can also record events for interrupted and failed merges,
and pass validation data through to the Sync ping.
Shutdown hang crash reports now have a `steps` field, indicating the
sequence of completed steps and when they were recorded. If the last
step in the hang report is `fetchLocalTree`, we know the merger is
blocked on `fetchNewLocalContents`. If the last step is
`fetchNewLocalContents`, the merger is stuck at `fetchRemoteTree`,
since that's the next step after `fetchNewLocalContents`.
This commit also implements `Driver::record_telemetry_event` to
dispatch progress callback runnables to the main thread.
Differential Revision: https://phabricator.services.mozilla.com/D31950
--HG--
extra : moz-landing-system : lando
2019-06-03 23:04:37 +00:00
598c42a9d2
Backed out changeset 8aca39389e35 (bug 1555771) for browser-chrome failures at browser/components/extensions/test/browser/browser_ext_tabs_events.js
2019-06-04 03:22:59 +03:00
6387709163
Bug 1555771 - Update Sync and FxA illustrations. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D33234
--HG--
extra : moz-landing-system : lando
2019-06-03 21:24:42 +00:00
7849b17acb
Backed out changeset 7f8884b7de4e (bug 1555771) for causing perma browser chrome failures in browser/base/content/test/sync/browser_sync.js CLOSED TREE
2019-06-03 22:14:42 +03:00
52eba7cee8
Bug 1555771 - Update Sync and FxA illustrations. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D33234
--HG--
extra : moz-landing-system : lando
2019-06-03 17:33:47 +00:00
80c3d0b5ca
Bug 1553831 - Fetch metadata on sync even if local data is up-to-date r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32769
--HG--
extra : moz-landing-system : lando
2019-06-03 10:02:13 +00:00
921d7af3d5
Bug 1553831 - Minor cleanups in Remote Settings client r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D32768
--HG--
extra : moz-landing-system : lando
2019-06-03 09:59:29 +00:00
rfkelly
Cosmin Sabou
Mark Hammond
lougenia
Oana Pop Rus
Thom Chiovoloni
Drew Willcoxon
Narcis Beleuzu
ffxbld
ffxbld
Lina Cambridge
Dorel Luca
Sylvestre Ledru
Sam Foster
Edouard Oger
Andreea Pavel
Razvan Maries
Bogdan Tara
Geoff Brown
Ehsan Akhgari
Mathieu Leplatre
Luca Greco
Ciure Andrei
Moritz Birghan
Mark Banner
Nicholas Nethercote
Jared Wein
Luke Crouch
Coroiu Cristina
Jonathan Kingston
Victor Porof
Marco Bonardo
Noemi Erli
Boris Zbarsky
Sebastian Hengst
Matthew Noorenberghe
shindli