For autofocus tooltips, we need to find a focusable item in order
to call focus() now that the tooltip content lives in the same
document as the toolbox. Updated the corresponding test and made
some superficial changes to HTMLTooltip.js.
MozReview-Commit-ID: L61eIxgFm3d
--HG--
extra : rebase_source : dae55ebb8c888638b902aec000cce2ef0631ca04
extra : source : c3ef26c17be6ef971f834c38d9aa69edc767d10c
Fixed regression from Bug 1168246 and added a unit test to loosely check that
the autocomplete popup moves along with autocompleted query.
MozReview-Commit-ID: H7t5WjkwBE4
--HG--
extra : rebase_source : d876338475ee1b1ae7ef30a9da8bea24c775c948
For now this is a 1 to 1 migration of the existing Tooltip
helper method from XUL to HTML.
MozReview-Commit-ID: 9YiJLgibV9h
--HG--
extra : rebase_source : af428055060a105d270d70b1e4694717e0869b2b
extra : source : d03cca0c048c9ba1f3062519650e37ae986d4bc7
With this changeset the tooltip's effective height can be smaller than
the height specified when calling setContent. If the tooltip content is
dynamic, this allows to display a small tooltip frame if the content is
collapsed, and a bigger tooltip frame when it is expanded.
MozReview-Commit-ID: 44vA0Rdz62m
--HG--
extra : rebase_source : 0e796f611e3462579f6e84a25671e5d44ed2314d
extra : source : 8583ea99abef8f25a1822178bab823f9fb7f2d01
The existing helper checking if a click occurred inside or outside a
HTMLTooltip container was failing if the click occurred in an iframe.
MozReview-Commit-ID: 9AIACOukYUF
--HG--
extra : rebase_source : e10ce05610e9a630ed1d9ba8a3f70b3344dffe9e
extra : source : 978c01749bdc4012f010db5fe09b0f8a402a9c0e
In order to have tooltips with a variable height, the tooltip container
should be allowed to resize itself on the fly, which cannot be achieved
with an iframe.
This changeset makes the HTMLTooltip rely on a HTML container inserted
in the XUL document directly. This allows to go back to a synchronous
API which also simplifies the implementation.
MozReview-Commit-ID: EDcsnVSKmeU
--HG--
extra : rebase_source : 80a22bc558468b69ff099602ab2364a55bcdd2f7
extra : source : 1794dbc179a093b26d06eadc18086c8f138dc008
Tooltip styles are scattered between common.css and panel-specific CSS
files (e.g. inspector.css). For the HTML tooltip, the panel specific CSS
files will not be applied since the tooltip container is appended to the
devtools top window.
This changeset creates a new tooltips.css file which is loaded by default
with devtools themes.
MozReview-Commit-ID: BnoRi9gLfD5
--HG--
extra : rebase_source : 3fee4731f65563c4b61371e3a3c51fb797d1a12b
extra : source : bd8878532e1f370fb49e0c50de0b2da267f7de8a
The function was trying to access `stylesheet` parameter's ownerNode property,
which is undefined when the parameter is a StyleSheetActor. In the latter case,
we use nodeHref and styleSheetIndex properties to match what is done when the
parameter is a StyleSheet.
MozReview-Commit-ID: 7FNoKasFYLL
Existing keyboard shortcuts have been reimplemented using the new shortcut-key
api.
A keypress handler was removed on the breadcrumbs buttons, it had no use
since a focused button is always selected.
MozReview-Commit-ID: JTSRxwQGSlh
--HG--
extra : rebase_source : 4466162a2cf2bd77cb50ee77ea5843c973ceb5b2
String.prototype.contains was removed from Firefox 48 completely after
it was renamed to String.prototype.includes. The test includes a
call to .contains() which is triggered whenever random JavaScript
error occurs during the test (hence the intermittency).
MozReview-Commit-ID: 7nbRm94JM7O
--HG--
extra : rebase_source : e969bc1ad46120509deec31066ea63ebbb7de9c9
- removed responsive.html/events.js
- added `isActiveForWindow` method to `ResponsiveUIManager`
- simplified how the check for RDM menu is done
- re-enabled tests for OS X debug in e10s
- refactored tests using `BrowserTestUtils`
MozReview-Commit-ID: 1TADh1dRVcU
Currently viewSourceInDebugger() only waits for a source to be shown if it is
not the selected one. If the requested source is selected by default, it might
already be selected when the isLoading check is made. However, the actual
source text might still be loading since it is loaded asynchronously.
In this case the method does not wait for the source to be shown meaning the
method resolves before the source is ready in the debugger. This causes
browser_toolbox_view_source_01.js to fail intermittently with wrong
line number since it looks at the focused line BEFORE the source text has
loaded and the correct line is selected.
This changeset modifies the behavior of viewSourceInDebugger() to also wait for
source shown event if the source is already selected but still loading.
MozReview-Commit-ID: JvxjJ5Yt19a
--HG--
extra : rebase_source : d4ed2e02bb8bfd734e23600e06accf3e34be16cc
The current name ShortLongString doesn't reflect the current usage of
this class. When looking at the few clients of this class, the reason
for using it is that the string is already accessible on the client
and does not need to be fetched from the server, while still keeping
the same interface as the LongStringFront.
MozReview-Commit-ID: 7MdgH8GzC7q
--HG--
extra : rebase_source : 71a7cbb69f9ccf4d46a6750ed93d8f0ee236177e
extra : histedit_source : 8bad387e697a8288d0ac651d52b8cf8ad9fb0bcb
moby
Nicolas Chevobbe
Wes Kocher
Andrea Marchesini
Julian Descottes
Eddy Bruel
Carsten "Tomcat" Book
Masatoshi Kimura
Eric Faust
Jarda Snajdr
Sami Jaktholm
Stephanie Ouillon
Florian Scholz
Yura Zenevich
Nick Fitzgerald
Matteo Ferretti
Raul Glogovetan
Jan Odvarko
Patrick Brosset