77062d8c94
Bug 559678 - Better errors for Storage transactions misuse. r=asuth
2010-04-16 14:31:18 +02:00
759e351de7
Bug 555124 - Intermittent "ASSERTION: AsyncStatementSpinner not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file .../mozilla/storage/test/test_true_async.cpp, line 162". null out references on the main thread to avoid destruction on the async thread. r=sdwilsh.
2010-03-29 10:54:41 -07:00
76eec45c74
Bug 550425: Bump up the timeout for expensive deadlock tests and print more info on failures. r=bsmedberg,sdwilsh
2010-03-24 19:12:32 -05:00
805fe0e096
Bug 507414 - Add a createAsyncStatement API on mozIStorageConnection. r=sdwilsh, sr=vlad.
...
--HG--
rename : storage/src/mozStorageStatementJSHelper.cpp => storage/src/mozStorageAsyncStatementJSHelper.cpp
rename : storage/src/mozStorageStatementJSHelper.h => storage/src/mozStorageAsyncStatementJSHelper.h
rename : storage/src/mozStorageStatementParams.cpp => storage/src/mozStorageAsyncStatementParams.cpp
rename : storage/src/mozStorageStatementParams.h => storage/src/mozStorageAsyncStatementParams.h
2010-03-24 00:32:40 -07:00
669c5430f9
Bug 536978 - Cookies should write to the database asynchronously.
...
This makes cookie insertion, updates, and deletions happen asynchronously off of
the main thread. The only I/O done on the main thread is the initial loading of
the database at each startup.
r=dwitte
2010-03-12 07:18:38 -08:00
3a38f90339
Bug 552092 - Expose a length property on mozIStorageBindingParamsArray
...
Expose the length so that consumers don't have to track if they added anything
to the array themselves.
r=asuth
sr=rob_strong
2010-03-15 10:23:39 -07:00
79cb4cb9fa
Bug 552003 - Passing an empty mozIStorageBindingParamsArray does not error
...
Throw instead of just asserting, which makes debugging this so much easier.
r=asuth
2010-03-15 10:23:39 -07:00
6b282c76f6
Backing out bug 536978, due to a Storage assertion causing orange. CLOSED TREE
2010-03-12 17:41:28 +01:00
5f9bed4706
Bug 536978 - Cookies should write to the database asynchronously.
...
This makes cookie insertion, updates, and deletions happen asynchronously off of
the main thread. The only I/O done on the main thread is the initial loading of
the database at each startup.
r=dwitte
2010-03-12 07:18:38 -08:00
8c6d857784
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
0f6caf5371
Fix regression in mozIStorageStatement.bindUTF8StringParameter such that it accepts arbitrary octets by
...
not converting string types. b=544496, r=sdwilsh
2010-02-22 13:57:45 -08:00
2fc408988c
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
585d440f02
Backed out changeset dc7a04be6904 on suspicion of causing bug 543034.
2010-01-29 18:50:46 -08:00
731c252671
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
8e6c7ce240
Backout patch from bug 489897 as the likely cause of pwmgr test failures.
2009-12-31 01:15:11 -06:00
d9b94920dd
Bug 489897 - implement StatementRow::NewEnumerate
...
for (let colName in stmt.row) now works!
r=sdwilsh
r=ddahl
sr=mrbkap
2009-10-12 17:49:00 -05:00
407f3e4e1e
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
6719a68ac1
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Make sure to release the database connection on the thread it was opened on, not
the background thread!
r=asuth
a=beltzner
2009-12-02 10:53:46 -08:00
97709adefd
Backed out changeset f91a016416d1 (bug 496019)
2009-12-01 15:05:52 -08:00
79d8f44604
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
a=dbaron
--HG--
extra : rebase_source : 8470e30ef4ca1e9fb516284cafb77b070e46fde3
2009-11-09 09:58:34 -08:00
fbf7a39eca
Check to make sure that sqlite has been compiled with SQLITE_SECURE_DELETE (Bug 445164); r=asuth
2009-11-23 18:46:39 -05:00
210879c30c
Backed out changeset 4a0bf3ffd767 due to test crashes.
2009-11-19 13:51:31 -08:00
528f812e53
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Release on the calling thread so when the connections destructor is called, it
is not on the background thread.
r=asuth
2009-11-19 11:49:20 -08:00
66bcafe3f5
Bug 528076 - Unsafe LIKE warning wrongly references mozIStorageConnection::escapeStringForLIKE. r=sdwilsh
2009-11-14 10:15:12 +01:00
89744c4f05
Backout of bug 496019 and bug 526601 due to window build bustage.
2009-11-09 12:16:39 -08:00
b35dae99b7
Bustage fix for windows.
2009-11-09 10:35:26 -08:00
020bb307a8
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
a0d4aaf78d
Bug 479730 - mozStorageConnection::Close logs closing improperly. r=vlad
2009-11-05 14:52:55 +01:00
6fb3a1a51c
Bug 524787 - crash [@mozStorageResultSet::GetNextRow(mozIStorageRow**) ]. r=sdwilsh
2009-10-31 11:38:31 +01:00
f4c4e9adf3
Bug 522157 Make -D__FUNCTION__=__func__ global for Sun Studio on Solaris r=benjamin
2009-10-26 14:25:40 +08:00
824e696346
Disable test_deadlock_detector for failing on OS X. (Bug 523378)
2009-10-20 20:26:04 -04:00
6084ceecd2
Bug 519326 - Variant.h(152) : warning C4244: '=' : conversion from 'PRInt64' to 'PRInt32', possible loss of data. r=sdwilsh
2009-10-09 22:15:19 +02:00
6386c8d29d
Bug 419893 - sort out PGO-triggered bugs (r=ted)
...
--HG--
extra : rebase_source : 028cd891e11df11abf768107f64b1d6bca541dca
2009-10-08 11:01:13 -07:00
082f716edb
Backed out changeset 59a6c227df86
2009-10-02 15:23:36 +10:00
967ffdcab4
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
--HG--
extra : rebase_source : 3f2f703274df0405bc395191dec8f522e5aa4e40
2009-07-22 15:18:33 -07:00
f9e43b71fe
Remove this test. It's not terribly useful (testing basic behavior of a
...
database which is covered by tests the SQLite group runs), and relies on a "bug"
that newer versions of SQLite fix. rs=mconnor
2009-09-30 14:38:43 -07:00
3ab01afc42
Test only change to make tests clean up better by using the free profile directory given to us. No bug. r="duh, why didn't we do this sooner"
2009-09-30 14:17:06 -07:00
85430c442e
Bug 518440 - Deprecate mozIStorageStatementWrapper & mozIStorageStatement.step() in IDL. r=sdwilsh
...
--HG--
extra : rebase_source : 0ede87a6eb9a34475d9efafa433809e571a104d3
2009-09-25 15:32:21 -07:00
a0119d2b00
Bug 507674 - Safer protection of AsyncExecuteStatements::mState and AsyncExecuteStatements::mCancelRequested
...
This is essentially a backout of bug 506805, followed by changing the locking
protection rules to only protect mCancelRequested writing on the calling thread,
and reading on the background thread.
--HG--
extra : rebase_source : 249a61e40c2fd140527f034e36e8c1a53518baac
2009-09-02 13:30:24 -07:00
20421b1d48
Bug 507199 - Fix race condition in finalizing asynchronous storage statements
...
(was "test_browserGlue_corrupt_nobackup_default.js, test_browserGlue_corrupt_nobackup.js, test_browserGlue_shutdown.js randomly crash")
Fixes a race condition with asynchronous statements that causes a crash. We do
not always have access to the background thread, so we should not assume we
always can get it.
2009-08-25 23:54:56 -07:00
ba372f3a4c
Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted
2009-08-25 08:59:31 -07:00
a778d6c4a5
Bug 507978 test_deadlock_detector.cpp failed to compile on Solaris r=bsmedberg
2009-08-11 14:56:58 +08:00
647310b4f6
Bug 505734 - mozStorageStatementParams.cpp compilation fails on MinGW. r=sdwilsh
2009-08-09 22:30:38 +02:00
ac821eca4a
Bug 433456 - mozIStorageFunction should be a [function]; r=sdwilsh
2009-08-06 20:00:39 +02:00
c2ac8daba2
Bug 506805 - Remove locking in AsyncExecuteStatements
...
This removes the use of the shared mutex in AsyncExecuteStatements. We now rely
on PR_AtomicSet and the volatile keyword. This results in zero lock contention
between the calling thread and the background thread if cancel is ever called.
r=asuth
r=bent
sr=vlad
2009-07-29 17:24:50 -07:00
3e8d79a831
Bug 506959 - AsyncExecuteStatements assumes ms, but calls functions that assume microseconds
...
This fixes the code to use functions that expect milliseconds instead of
microseconds, and updates to use the new TimeStamp and TimeDuration class.
r=asuth
2009-07-28 13:18:10 -07:00
ef61780206
Bug 506022 - Avoid obtaining the database mutex at all costs in Connection::ExecuteAsync
...
Stop calling any SQLite functions that would acquire the database mutex inside
Connection::ExecuteAsync. Additionally, do not actually bind parameters when
the binding functions are called, but rather when we execute (so for async
statements, that will happen on the background thread creating no mutex
contention with the main thread).
r=asuth
2009-07-28 10:21:03 -07:00
cbf6d8a79c
Merge places to mozilla-central.
2009-07-27 08:50:26 -07:00
0ac9a4e2a5
Bug 498938 - Add Levenshtein Edit Distance function to Sqlite so we can use it in queries. r=sdwilsh sr=vlad
2009-07-24 11:39:34 -04:00
3b8c5a49ad
Merge places to mozilla-central.
2009-07-23 13:10:26 -07:00
Marco Bonardo
Andrew Sutherland
Chris Jones
Shawn Wilsher
Dan Witte
Justin Lebar
Daniel Holbert
Reed Loden
David Dahl ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
Shawn Wilsher
L. David Baron
Blair McBride
Saint Wesonga
Ginn Chen
Dietrich Ayala
Robert O'Callahan
Paul O’Shannessy
Benjamin Smedberg
Jacek Caban
Akshay Gupta
Curtis Bartley