Thomas Nguyen
493ff90f5c
Bug 1315386 - Make Safe Browsing code more shutdown-aware. r=francois,gcp.
...
MozReview-Commit-ID: ATCVfh5YLZl
--HG--
extra : rebase_source : d87cfae3838f1a26dc67d2546264e47768011a63
2016-11-25 16:02:37 +08:00
Henry Chang
45d5eda33b
Bug 1312323 - Consider the "single encoded value" case and bubble the decoding error up. r=francois.
...
MozReview-Commit-ID: 1GNFkMQ1JoD
2016-10-26 10:03:49 +08:00
Henry
36fa608182
Bug 1307541 - ProtocolParserProtobuf to init and return update time properly. r=francois.
...
MozReview-Commit-ID: CmVWVKUeunJ
--HG--
extra : rebase_source : e8cd28a805b892fd26ca9bede3523a04f1bb5686
2016-10-18 14:45:21 +08:00
Henry Chang
dc3bbda5bd
Bug 1305484 - Save/load state and checksum to/from disk rather than prefs. r=dimi,francois
...
MozReview-Commit-ID: 4gmmrI9wY4c
--HG--
extra : rebase_source : f7f4462b7325bce9a92f747c54b448e2693e40ac
2016-10-13 15:22:08 +08:00
Henry Chang
b468335de9
Bug 1285848 - Part 2: Request and parse RICE encoded prefix by default. r=francois
...
MozReview-Commit-ID: Cd0lT5VTM7t
--HG--
extra : rebase_source : 08724d3c8039039b8c73f58230b1cdad94ccd786
extra : source : 3abd3bc8a0119433ef66864c8c7fd1394fb0cc14
2016-10-05 14:59:53 +08:00
Dimi Lee
3ef7d52f53
Bug 1305801 - Part 4: Store variable-length prefix to disk. r=francois, r=gcp
...
MozReview-Commit-ID: BMTGtgMuQdg
--HG--
extra : rebase_source : dc4975d9ac8d14ecfabf6fc1229fdb8e863cde46
2016-09-19 11:51:01 +08:00
Phil Ringnalda
35869db574
Backed out 5 changesets (bug 1305801) for ASan gtest bustage
...
Backed out changeset 0c95d5dec6d9 (bug 1305801)
Backed out changeset bca0e706dbc5 (bug 1305801)
Backed out changeset def8da367beb (bug 1305801)
Backed out changeset 56ceae52d847 (bug 1305801)
Backed out changeset 14457cc4c325 (bug 1305801)
2016-10-03 22:14:49 -07:00
Dimi Lee
f0aab4a2ce
Bug 1305801 - Part 4: Store variable-length prefix to disk. r=francois, r=gcp
...
MozReview-Commit-ID: BMTGtgMuQdg
--HG--
extra : rebase_source : 6f613883071de209f53596060b637e928f458978
2016-09-19 11:51:01 +08:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Henry Chang
f67032cc11
Bug 1287059 - Part 2: Save/get the list states to/from prefs temporarily. r=francois.
...
MozReview-Commit-ID: GaDExi2d0YX
--HG--
extra : rebase_source : 0b1ccc96dc4acffbb404b00747430cc462d047fa
2016-08-12 17:29:42 +08:00
Henry
db1a9a2ec6
Bug 1287059 - Part 1: Return all possible list names while converting from threat type. r=francois.
...
MozReview-Commit-ID: KgT4CrBzvu0
--HG--
extra : rebase_source : 6067f296fd820c6948bb418bf67371b56326338a
2016-08-16 17:30:11 +08:00
Henry Chang
4c1f039d17
Bug 1284204
- Parse SafeBrowsing V4 updates to TableUpdateV4. r=francois.
...
MozReview-Commit-ID: 88AEIbosxKl
--HG--
extra : rebase_source : 0cf1c60713a938a72c87d140869a63b2afa12e3f
extra : source : 13292c9abdce368d506d5c4ff79b4b14781e64ad
2016-08-12 11:55:48 +08:00
Henry Chang
40cb773d8f
Bug 1274112 - Part 2: Use protobuf API to parse v4 update response. r=francois
...
MozReview-Commit-ID: 3sjR3Feq4ua
--HG--
extra : rebase_source : 0c3ef1b0b0d564190c8e2e410a1201216cdbf53c
2016-08-04 18:10:12 +08:00
Ralph Giles
2d78dbf106
Bug 1275744 - Reference MOZ_LOG in toolkit comments. r=erahm
...
NSPR_LOG_MODULES is deprecated.
MozReview-Commit-ID: 2iZFe60Uxvi
--HG--
extra : rebase_source : 040671ce46a6d8b7d8503f4a05ff5ef04968a8aa
2016-05-26 11:14:47 -07:00
dimi
a90abcb1f6
Bug 1246301 - Incorrectly parsed value for update interval in shavar response. r=francois
...
MozReview-Commit-ID: Ks84KmA5uKJ
--HG--
extra : transplant_source : %80%9C%91%DE%F6%CEHa%28%22%B6%1A%0C%BA%B50%97%9Dy%CE
2016-03-25 09:50:44 +08:00
sajitk
2ed26c8df4
Bug 1219482: Replace PRLogModuleInfo with LazyLogModule in toolkit subdirectory.r=erahm
2016-01-28 10:37:00 -08:00
Wes Kocher
e060c6dced
Backed out changeset 24af6caa9bba (bug 1219482) to hopefully fix the intermittent hazard failures CLOSED TREE
...
--HG--
extra : commitid : ETz5wi5nzdH
2016-01-29 10:15:30 -08:00
sajitk
aff6f586b9
Bug 1219482 - Replace PRLogModuleInfo with LazyLogModule in toolkit subdirectory. r=erahm
...
--HG--
extra : rebase_source : 71c02b7294a95ecba7876b0372a0dee0ea05b4ed
2016-01-28 10:37:00 -05:00
Francois Marier
34937ffbe4
Bug 1213400 - Fix crash in broken Safe Browsing list updates. r=gcp
2015-11-30 12:44:28 -08:00
Francois Marier
3ae91b2ba9
Bug 1215396 - Log Safe Browsing prefixes as they are added to the local database. r=gcp
2015-10-19 14:13:49 -07:00
Francois Marier
ef41c4971f
Bug 1203347 - Increase Safe Browsing debug logging around downloads. r=gcp
2015-09-14 18:03:48 -07:00
Eric Rahm
75c4bebb79
Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
...
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
Eric Rahm
f50b813989
Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj
2015-06-03 15:22:28 -07:00
Carsten "Tomcat" Book
5471309381
Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
...
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)
--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
2015-06-02 13:05:56 +02:00
Eric Rahm
a9afd68cef
Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
...
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 22:17:33 -07:00
Eric Rahm
141e0ff4a2
Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj
2015-06-01 22:17:19 -07:00
Wes Kocher
4e9f80ed2e
Backed out 14 changesets (bug 1165515) for b2g mochitest-6 permafail CLOSED TREE
...
Backed out changeset 9b97e2aa2ed9 (bug 1165515)
Backed out changeset 150606c022a2 (bug 1165515)
Backed out changeset 4e875a488349 (bug 1165515)
Backed out changeset 467e7feeb546 (bug 1165515)
Backed out changeset d6b6cc373197 (bug 1165515)
Backed out changeset 0615265b593c (bug 1165515)
Backed out changeset fafd1dce9f08 (bug 1165515)
Backed out changeset d1df869245f9 (bug 1165515)
Backed out changeset 6876a7c63611 (bug 1165515)
Backed out changeset b7841c94a9a3 (bug 1165515)
Backed out changeset e5e3617f7c73 (bug 1165515)
Backed out changeset 39be3db95978 (bug 1165515)
Backed out changeset 0ec74176f8de (bug 1165515)
Backed out changeset 5b928dd10d71 (bug 1165515)
2015-06-01 17:57:58 -07:00
Eric Rahm
f82c0e7caf
Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
...
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 14:31:01 -07:00
Eric Rahm
dc090e3fe5
Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj
2015-06-01 14:31:00 -07:00
Eric Rahm
3925a960aa
Bug 1165515 - Part 1: Convert PR_LOG to MOZ_LOG. r=froydnj
2015-05-21 13:22:04 -07:00
Eric Rahm
4879ae86f4
Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj
2015-05-19 11:15:34 -07:00
Eric Rahm
bc7a3b2ae7
Bug 1164556 - Part 1: Remove instances of #ifdef PR_LOGGING in toolkit. r=froydnj
...
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-14 10:13:23 -07:00
Gian-Carlo Pascutto
479687ac1f
Bug 1134885 - ChunkSets should be fallible. r=mmc
2015-02-25 14:05:17 +01:00
Carsten "Tomcat" Book
ce2be86630
Backed out changeset bc7ca0aabb24 (bug 1134885) for bustage on a CLOSED TREE
2015-02-25 09:05:47 +01:00
Gian-Carlo Pascutto
9bf0036576
Bug 1134885 - ChunkSets should be fallible. r=mmc
2015-02-25 08:31:11 +01:00
Nicholas Nethercote
fd297089e6
Bug 1100219 - Avoid lots of unnecessary string copying in ProtocolParser. r=neil.
...
--HG--
extra : rebase_source : 7d063de7b5ec312724039c2bf6546758ebc0e2fe
2014-11-18 18:42:43 -08:00
Gian-Carlo Pascutto
2f0246c854
Bug 783047 - Remove MAC support from SafeBrowsing code. r=mmc,dcamp
2014-01-16 09:27:58 +01:00
Monica Chew
383e668837
Bug 904607: Add protocol parser for -digest256 lists (r=gcp).
2013-09-06 17:12:33 -07:00
Gian-Carlo Pascutto
0da033e962
Bug 825891 - Remove the code for per-client randomization in the url-classifier. r=dcamp
2013-01-08 16:43:33 +01:00
Isaac Aggrey
c984edf823
Bug 794510: Part 2: Use more stdint types instead of protypes.h types; r=ehsan
2012-10-11 18:38:04 -05:00
Randell Jesup
65539ef89c
Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg
2012-09-01 22:35:17 -04:00
Ehsan Akhgari
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Gian-Carlo Pascutto
328bf6ddf8
Bug 673470 - Update the new SafeBrowsing code to MPL 2.0. r=dcamp
2012-08-15 09:10:56 +02:00
Gian-Carlo Pascutto
37af20ab14
Bug 673470 - Don't resort if not needed. Fix comparator. Cleanups. r=dcamp
2012-08-15 09:08:37 +02:00
Gian-Carlo Pascutto
feef277a46
Bug 673470 - Fix wrong order of arguments to KeyedHash function. r=dcamp
2012-08-15 09:08:23 +02:00
Gian-Carlo Pascutto
52208070f2
Bug 768871 - Provide an option to disable per-client randomization. r=dcamp
2012-08-15 09:07:10 +02:00
Gian-Carlo Pascutto
2a38f23df4
Bug 729640 - Fix broken UrlClassifier assertion. r=dcamp
2012-08-15 09:05:32 +02:00
Gian-Carlo Pascutto
f6e66dd24e
Bug 673470 - Replace the sqlite safeb store with a flat file. r=dcamp
2012-08-15 09:04:19 +02:00
Gian-Carlo Pascutto
08beb49296
Backout 173f90d397a8 (Bug 673470). rs=dcamp a=mfinkle
2012-04-20 07:46:47 +02:00
Gian-Carlo Pascutto
dace6c811c
Backout f8bf3795b851 (Bug 729640). rs=dcamp a=mfinkle
2012-04-20 07:46:45 +02:00