Граф коммитов

138 Коммитов

Автор SHA1 Сообщение Дата
Ian Ling 162c7e96d6 Bug 1525350 - Check if window is private before saving search string. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D143224
2022-04-13 00:58:06 +00:00
Kagami Sascha Rosylight 1409f37ca3 Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-04-06 11:57:57 +00:00
criss 4eec7e25a3 Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight c8f12f94dc Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().

Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-03-29 13:11:00 +00:00
Shane Hughes 124293057e Bug 1752026 - Implement Accel + Up/Down shortcuts in findbar. r=mcheang,NeilDeakin
When the findbar input is focused, Up/Down keys scroll the page up or
down by one line. But pressing the Accel modifier doesn't modify the
behavior to scroll to the top/bottom of the document as it normally
does. It just produces a normal scroll. This patch fixes that.

Differential Revision: https://phabricator.services.mozilla.com/D137606
2022-02-19 00:07:00 +00:00
Mark Banner 14aedbb785 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 12:09:49 +00:00
Noemi Erli e0f4b9b5fe Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
2021-09-10 13:14:12 +03:00
Mark Banner 3cfdb5c41a Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 09:38:42 +00:00
Neil Deakin 46a12bc6f1 Bug 1690783, move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D104318
2021-02-11 14:12:29 +00:00
Mihai Alexandru Michis 1d92d113a2 Backed out changeset 5b31293f0b8d (bug 1690783) for causing bc failures in browser_findbar_marks.js
CLOSED TREE
2021-02-10 18:14:46 +02:00
Neil Deakin eb7ca8878c Bug 1690783, move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D104318
2021-02-10 14:08:44 +00:00
Neil Deakin 116ae26251 Bug 259640, update the scroll marks when a find in page highlight in completed, using the positions of the highlights as the marker points, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D100940
2021-02-03 17:58:44 +00:00
Kris Maglione ff7e9df6a0 Bug 1685801: Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
It's only used by the finder code, and can be much simpler.

Differential Revision: https://phabricator.services.mozilla.com/D101488
2021-01-28 21:35:39 +00:00
Mihai Alexandru Michis 040e2ea5d0 Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione 56bb7266d8 Bug 1685801: Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
It's only used by the finder code, and can be much simpler.

Differential Revision: https://phabricator.services.mozilla.com/D101488
2021-01-28 05:24:58 +00:00
Butkovits Atila 7decdccbdc Backed out 12 changesets (bug 1685801) for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Backed out changeset 0d7153110519 (bug 1685801)
Backed out changeset 5175062925c7 (bug 1685801)
Backed out changeset 2c1250e786f0 (bug 1685801)
Backed out changeset 0ce3c773ba74 (bug 1685801)
Backed out changeset 9d51c6e24dee (bug 1685801)
Backed out changeset 3f4dc6349441 (bug 1685801)
Backed out changeset a80de9abb9f8 (bug 1685801)
Backed out changeset 30786893a5e7 (bug 1685801)
Backed out changeset 8007b12d6e32 (bug 1685801)
Backed out changeset fa814f4b7125 (bug 1685801)
Backed out changeset 14e4e47ee99f (bug 1685801)
Backed out changeset d9f1feba9454 (bug 1685801)
2021-01-28 07:15:59 +02:00
Kris Maglione 7075843922 Bug 1685801: Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
It's only used by the finder code, and can be much simpler.

Differential Revision: https://phabricator.services.mozilla.com/D101488
2021-01-28 03:32:54 +00:00
Edgar Chen 0fd119dae0 Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws
Resetting focus would also clear selection on editable element, so get
current selected text before moving focus to findbar to make
prefill-with-selection work if the content is loaded in chrome process.

Differential Revision: https://phabricator.services.mozilla.com/D89557
2020-12-21 21:35:49 +00:00
Dorel Luca cbf69a75c1 Backed out changeset 2ac614e69ecb (bug 582459) for Mochitest failures in dom/tests/mochitest/chrome/test_focus.xhtml. CLOSED TREE 2020-12-16 03:44:13 +02:00
Edgar Chen f9b8ba2a7c Bug 582459 - Reset the focused element when a frame loses document focus; r=mikedeboer,NeilDeakin,hsivonen,jaws
Resetting focus would also clear selection on editable element, so get
current selected text before moving focus to findbar to make
prefill-with-selection work if the content is loaded in chrome process.

Differential Revision: https://phabricator.services.mozilla.com/D89557
2020-12-15 19:55:35 +00:00
DesWurstes 041dc6bfcd Bug 1020254 - PDFParent should set the find clipboard. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D85140
2020-08-21 07:37:19 +00:00
Kris Maglione 9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Neil Deakin 4e865e037b Bug 1628053, don't get the root window when adding the unload listener, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D71453
2020-05-11 10:33:28 +00:00
Masatoshi Kimura 3df19bc1d4 Bug 1623222 - Remove the charset parameter from nsITextToSubURI::UnEscapeURIForUI. r=hsivonen
Only 3 callers are using a non-UTF-8 charset as the first parameter.
* MediaDocument.cpp: This does not make sense because the "filename" part of
  URLs will always be encoded with UTF-8.
* nsContextMenu.js: This is wrong because "mailto:" URLs don't care about the
  document charset.
* Finder.jsm: This caused bug 1623222.

Differential Revision: https://phabricator.services.mozilla.com/D67386

--HG--
extra : moz-landing-system : lando
2020-03-19 10:45:28 +00:00
Neil Deakin e1685e02b7 Bug 1606392, pass along and update the match case, diacriticals and whole word state to the child for each find attempt, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D60010

--HG--
extra : moz-landing-system : lando
2020-02-12 12:09:01 +00:00
Neil Deakin afecaa4f3e Bug 1602033, typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D58378

--HG--
extra : moz-landing-system : lando
2020-01-06 23:41:22 +00:00
Andreea Pavel 1665a50205 Backed out changeset cf0698d83783 (bug 1602033) for causing bug 1607230 on a CLOSED TREE
--HG--
extra : rebase_source : 0625162bf7d9ffa986c851b78ebda4c29993cd3f
2020-01-06 18:11:36 +02:00
Neil Deakin e4d9f936e3 Bug 1602033, typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D58378

--HG--
extra : moz-landing-system : lando
2020-01-06 14:04:07 +00:00
Alex Henrie 00867c4809 Bug 202251 - Add an option to ignore diacritics when searching. r=fluent-reviewers,mikedeboer,jfkthame,flod
Differential Revision: https://phabricator.services.mozilla.com/D51841

--HG--
extra : moz-landing-system : lando
2019-12-09 19:26:40 +00:00
Brindusan Cristian 4b11b63400 Backed out changeset b89936db7178 (bug 202251) for bc failures at browser_misused_characters_in_strings.js. CLOSED TREE 2019-12-05 23:10:09 +02:00
Alex Henrie ca467c4b3f Bug 202251 - Add an option to ignore diacritics when searching. r=fluent-reviewers,mikedeboer,jfkthame,flod
Differential Revision: https://phabricator.services.mozilla.com/D51841

--HG--
extra : moz-landing-system : lando
2019-12-05 18:08:20 +00:00
Neil Deakin b6a3fc1ce5 Bug 1553384, remove old find/findAgain methods in typeaheadfind in favour of a single find method, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D41232

--HG--
extra : moz-landing-system : lando
2019-09-18 09:31:43 +00:00
Neil Deakin 9a9e65a7e5 Bug 1553384, find should iterate over each frame within a document in the parent process to allow out-of-process frames to be searched through, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D41224

--HG--
extra : moz-landing-system : lando
2019-09-17 23:28:41 +00:00
Neil Deakin 67ae7b2420 Bug 1553384, add a search subframes flag to the finder to opt in or out of subframe searching, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D41218

--HG--
extra : moz-landing-system : lando
2019-09-18 09:31:21 +00:00
Victor Porof b503616295 Bug 1561435 - Format toolkit/modules/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36056

--HG--
extra : source : 2616392f26053ee376b9126fbca696de5d4bb15b
2019-07-05 11:15:43 +02:00
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Tom Schuster 5a9d2a428c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201

--HG--
extra : moz-landing-system : lando
2018-11-20 16:59:56 +00:00
Csoregi Natalia df7483024d Backed out 6 changesets (bug 1493292) for bustage on /nsTransferable.cpp. CLOSED TREE
Backed out changeset f198bf91320b (bug 1493292)
Backed out changeset 6487aa307123 (bug 1493292)
Backed out changeset f2cabd69c568 (bug 1493292)
Backed out changeset 71430fceb4a3 (bug 1493292)
Backed out changeset 3a9b6d65d8c7 (bug 1493292)
Backed out changeset 55769869037c (bug 1493292)
2018-11-20 17:13:18 +02:00
Tom Schuster b292ec7c2c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201

--HG--
extra : moz-landing-system : lando
2018-11-20 14:47:02 +00:00
Mark Banner 691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Boris Zbarsky 0fcb24c18d Bug 1446940 part 1. Stop getting docshells from windows via getInterface in toolkit. r=gijs
The change to test_hiddenPrivateWindow.xul is to make sure we pass windows, not
docshells, to an API that expects windows.
2018-08-01 13:07:09 -04:00
Kris Maglione 02ba563399 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : source : 0d69b4fb1ed43751cfcbc0b4f2fe3b6a49bc0494
extra : histedit_source : d0ce31513ffaae2fd7f01f6567a97b6d2d96b797%2Cfff837de7a00fa90809d2c3e755097180dfd56d8
2018-05-20 18:10:16 -07:00
Narcis Beleuzu 561ccb2ceb Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
2018-07-29 03:55:23 +03:00
Kris Maglione 636f1839e5 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : rebase_source : 36565ef5e74360aad14062005e5bdab2939e888b
2018-05-20 18:10:16 -07:00
Boris Zbarsky 6e84b66899 Bug 1476145 part 6. Stop using getInterface(nsIDOMWindowUtils) in toolkit. r=mossop
This is not quite a mechanical change, because some places have a .top or
whatnot snuck in there, so please review carefully!
2018-07-24 19:47:42 -04:00
Boris Zbarsky 0cf65db1d3 Bug 1465875 part 2. Eliminate use of "instanceof nsIDOMNSEditablElement". r=qdot 2018-06-01 22:35:22 -04:00
Kris Maglione a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Florian Quèze 682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Sebastian Hengst f5e840425b merge mozilla-inbound to mozilla-central. a=merge 2018-02-10 00:26:50 +02:00
Boris Zbarsky fce30e834b Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00