0383c618f7
Bug 570529: mozIStorageStatement.execute() should reset itself even if an error occurs. r=sdwilsh
2010-06-07 15:06:56 -07:00
f3d67d3162
Bug 492625 - "Stop using underscores to start #defines" [r=vlad]
...
--HG--
extra : rebase_source : d685fb8bc375ba4fcf97742298e9361ebfe9b851
2010-06-01 08:38:00 -04:00
5ec929857e
Bug 518663 - ES5: Object.getOwnPropertyNames. r=jorendorff
2009-09-24 14:33:14 -07:00
a50cfc6399
Backed out changeset c60e3e48ea38
2010-06-24 19:56:14 -05:00
a591dc4cb0
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
2010-06-24 16:39:24 -07:00
28ec17d596
Bug 567254 - Crash in Connection::getFilename for memory-based databases; r=sdwilsh
...
--HG--
extra : rebase_source : 9fb1300af8c6b35a4e1aa229af032cd08a76e721
2010-05-20 20:21:09 -04:00
db9d404619
Bug 560647 - add startup timeline instrumentation; r=vlad
2010-05-19 19:22:19 -04:00
e94d4e8f48
b=566442; add memory reporters for sqlite; r=sdwilsh
2010-05-19 13:46:08 -07:00
839da6a299
Test for bug 562866. r=jorendorff r=asuth
...
--HG--
rename : storage/test/unit/test_js_helpers_enumerate.js => storage/test/unit/test_js_helpers.js
2010-05-11 14:14:54 -07:00
7f0a9916a3
Bug 562866 - StatementParams::NewResolve mishandles JSVAL_IS_STRING(aId). r=sdwilsh.
...
--HG--
extra : rebase_source : f9e1ea925fa38a26c806ba6dbddc52ef83646d55
2010-05-06 13:56:39 -05:00
d0096803e1
Bug 560383, part 2: (storage directory) Use "!!" for converting int to bool, to avoid MSVC compile warning. r=sdwilsh
2010-05-06 11:53:12 -07:00
979d0abc03
Bug 562787 - Fix getResultByName idl description to specify it needs an AS clause. r=asuth
2010-05-05 15:28:01 +02:00
0aeeef4bfa
Bug 562855 - hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() and sqlite3_shutdown(), r=asuth
...
--HG--
extra : rebase_source : 648695de6bf0b68965cea43b27c7f9c089d8b945
2010-05-02 01:57:00 -07:00
f544d71a9d
Bug 560095 - Use mozilla::services::GetObserverService(). r=biesi,dveditz,gavin,josh,jst,mrbkap,roc,sdwilsh,shaver,sicking,smontagu,surkov
2010-04-29 18:59:13 +02:00
cecf42574e
Bug 559678 - followup, make the warning less scarying. rs=sdwilsh
2010-04-22 14:53:56 +02:00
77062d8c94
Bug 559678 - Better errors for Storage transactions misuse. r=asuth
2010-04-16 14:31:18 +02:00
759e351de7
Bug 555124 - Intermittent "ASSERTION: AsyncStatementSpinner not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file .../mozilla/storage/test/test_true_async.cpp, line 162". null out references on the main thread to avoid destruction on the async thread. r=sdwilsh.
2010-03-29 10:54:41 -07:00
76eec45c74
Bug 550425: Bump up the timeout for expensive deadlock tests and print more info on failures. r=bsmedberg,sdwilsh
2010-03-24 19:12:32 -05:00
805fe0e096
Bug 507414 - Add a createAsyncStatement API on mozIStorageConnection. r=sdwilsh, sr=vlad.
...
--HG--
rename : storage/src/mozStorageStatementJSHelper.cpp => storage/src/mozStorageAsyncStatementJSHelper.cpp
rename : storage/src/mozStorageStatementJSHelper.h => storage/src/mozStorageAsyncStatementJSHelper.h
rename : storage/src/mozStorageStatementParams.cpp => storage/src/mozStorageAsyncStatementParams.cpp
rename : storage/src/mozStorageStatementParams.h => storage/src/mozStorageAsyncStatementParams.h
2010-03-24 00:32:40 -07:00
669c5430f9
Bug 536978 - Cookies should write to the database asynchronously.
...
This makes cookie insertion, updates, and deletions happen asynchronously off of
the main thread. The only I/O done on the main thread is the initial loading of
the database at each startup.
r=dwitte
2010-03-12 07:18:38 -08:00
3a38f90339
Bug 552092 - Expose a length property on mozIStorageBindingParamsArray
...
Expose the length so that consumers don't have to track if they added anything
to the array themselves.
r=asuth
sr=rob_strong
2010-03-15 10:23:39 -07:00
79cb4cb9fa
Bug 552003 - Passing an empty mozIStorageBindingParamsArray does not error
...
Throw instead of just asserting, which makes debugging this so much easier.
r=asuth
2010-03-15 10:23:39 -07:00
6b282c76f6
Backing out bug 536978, due to a Storage assertion causing orange. CLOSED TREE
2010-03-12 17:41:28 +01:00
5f9bed4706
Bug 536978 - Cookies should write to the database asynchronously.
...
This makes cookie insertion, updates, and deletions happen asynchronously off of
the main thread. The only I/O done on the main thread is the initial loading of
the database at each startup.
r=dwitte
2010-03-12 07:18:38 -08:00
8c6d857784
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
0f6caf5371
Fix regression in mozIStorageStatement.bindUTF8StringParameter such that it accepts arbitrary octets by
...
not converting string types. b=544496, r=sdwilsh
2010-02-22 13:57:45 -08:00
2fc408988c
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
585d440f02
Backed out changeset dc7a04be6904 on suspicion of causing bug 543034.
2010-01-29 18:50:46 -08:00
731c252671
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
8e6c7ce240
Backout patch from bug 489897 as the likely cause of pwmgr test failures.
2009-12-31 01:15:11 -06:00
d9b94920dd
Bug 489897 - implement StatementRow::NewEnumerate
...
for (let colName in stmt.row) now works!
r=sdwilsh
r=ddahl
sr=mrbkap
2009-10-12 17:49:00 -05:00
407f3e4e1e
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
6719a68ac1
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Make sure to release the database connection on the thread it was opened on, not
the background thread!
r=asuth
a=beltzner
2009-12-02 10:53:46 -08:00
97709adefd
Backed out changeset f91a016416d1 (bug 496019)
2009-12-01 15:05:52 -08:00
79d8f44604
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
a=dbaron
--HG--
extra : rebase_source : 8470e30ef4ca1e9fb516284cafb77b070e46fde3
2009-11-09 09:58:34 -08:00
fbf7a39eca
Check to make sure that sqlite has been compiled with SQLITE_SECURE_DELETE (Bug 445164); r=asuth
2009-11-23 18:46:39 -05:00
210879c30c
Backed out changeset 4a0bf3ffd767 due to test crashes.
2009-11-19 13:51:31 -08:00
528f812e53
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Release on the calling thread so when the connections destructor is called, it
is not on the background thread.
r=asuth
2009-11-19 11:49:20 -08:00
66bcafe3f5
Bug 528076 - Unsafe LIKE warning wrongly references mozIStorageConnection::escapeStringForLIKE. r=sdwilsh
2009-11-14 10:15:12 +01:00
89744c4f05
Backout of bug 496019 and bug 526601 due to window build bustage.
2009-11-09 12:16:39 -08:00
b35dae99b7
Bustage fix for windows.
2009-11-09 10:35:26 -08:00
020bb307a8
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
a0d4aaf78d
Bug 479730 - mozStorageConnection::Close logs closing improperly. r=vlad
2009-11-05 14:52:55 +01:00
6fb3a1a51c
Bug 524787 - crash [@mozStorageResultSet::GetNextRow(mozIStorageRow**) ]. r=sdwilsh
2009-10-31 11:38:31 +01:00
f4c4e9adf3
Bug 522157 Make -D__FUNCTION__=__func__ global for Sun Studio on Solaris r=benjamin
2009-10-26 14:25:40 +08:00
824e696346
Disable test_deadlock_detector for failing on OS X. (Bug 523378)
2009-10-20 20:26:04 -04:00
6084ceecd2
Bug 519326 - Variant.h(152) : warning C4244: '=' : conversion from 'PRInt64' to 'PRInt32', possible loss of data. r=sdwilsh
2009-10-09 22:15:19 +02:00
6386c8d29d
Bug 419893 - sort out PGO-triggered bugs (r=ted)
...
--HG--
extra : rebase_source : 028cd891e11df11abf768107f64b1d6bca541dca
2009-10-08 11:01:13 -07:00
082f716edb
Backed out changeset 59a6c227df86
2009-10-02 15:23:36 +10:00
967ffdcab4
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
--HG--
extra : rebase_source : 3f2f703274df0405bc395191dec8f522e5aa4e40
2009-07-22 15:18:33 -07:00
f9e43b71fe
Remove this test. It's not terribly useful (testing basic behavior of a
...
database which is covered by tests the SQLite group runs), and relies on a "bug"
that newer versions of SQLite fix. rs=mconnor
2009-09-30 14:38:43 -07:00
3ab01afc42
Test only change to make tests clean up better by using the free profile directory given to us. No bug. r="duh, why didn't we do this sooner"
2009-09-30 14:17:06 -07:00
85430c442e
Bug 518440 - Deprecate mozIStorageStatementWrapper & mozIStorageStatement.step() in IDL. r=sdwilsh
...
--HG--
extra : rebase_source : 0ede87a6eb9a34475d9efafa433809e571a104d3
2009-09-25 15:32:21 -07:00
a0119d2b00
Bug 507674 - Safer protection of AsyncExecuteStatements::mState and AsyncExecuteStatements::mCancelRequested
...
This is essentially a backout of bug 506805, followed by changing the locking
protection rules to only protect mCancelRequested writing on the calling thread,
and reading on the background thread.
--HG--
extra : rebase_source : 249a61e40c2fd140527f034e36e8c1a53518baac
2009-09-02 13:30:24 -07:00
20421b1d48
Bug 507199 - Fix race condition in finalizing asynchronous storage statements
...
(was "test_browserGlue_corrupt_nobackup_default.js, test_browserGlue_corrupt_nobackup.js, test_browserGlue_shutdown.js randomly crash")
Fixes a race condition with asynchronous statements that causes a crash. We do
not always have access to the background thread, so we should not assume we
always can get it.
2009-08-25 23:54:56 -07:00
ba372f3a4c
Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted
2009-08-25 08:59:31 -07:00
a778d6c4a5
Bug 507978 test_deadlock_detector.cpp failed to compile on Solaris r=bsmedberg
2009-08-11 14:56:58 +08:00
647310b4f6
Bug 505734 - mozStorageStatementParams.cpp compilation fails on MinGW. r=sdwilsh
2009-08-09 22:30:38 +02:00
ac821eca4a
Bug 433456 - mozIStorageFunction should be a [function]; r=sdwilsh
2009-08-06 20:00:39 +02:00
c2ac8daba2
Bug 506805 - Remove locking in AsyncExecuteStatements
...
This removes the use of the shared mutex in AsyncExecuteStatements. We now rely
on PR_AtomicSet and the volatile keyword. This results in zero lock contention
between the calling thread and the background thread if cancel is ever called.
r=asuth
r=bent
sr=vlad
2009-07-29 17:24:50 -07:00
3e8d79a831
Bug 506959 - AsyncExecuteStatements assumes ms, but calls functions that assume microseconds
...
This fixes the code to use functions that expect milliseconds instead of
microseconds, and updates to use the new TimeStamp and TimeDuration class.
r=asuth
2009-07-28 13:18:10 -07:00
ef61780206
Bug 506022 - Avoid obtaining the database mutex at all costs in Connection::ExecuteAsync
...
Stop calling any SQLite functions that would acquire the database mutex inside
Connection::ExecuteAsync. Additionally, do not actually bind parameters when
the binding functions are called, but rather when we execute (so for async
statements, that will happen on the background thread creating no mutex
contention with the main thread).
r=asuth
2009-07-28 10:21:03 -07:00
cbf6d8a79c
Merge places to mozilla-central.
2009-07-27 08:50:26 -07:00
0ac9a4e2a5
Bug 498938 - Add Levenshtein Edit Distance function to Sqlite so we can use it in queries. r=sdwilsh sr=vlad
2009-07-24 11:39:34 -04:00
3b8c5a49ad
Merge places to mozilla-central.
2009-07-23 13:10:26 -07:00
2b666b27ef
Merge places to mozilla-central.
2009-07-23 07:58:59 -07:00
015f42221e
Bug 491196 don't implement static functions in headers
...
r=sdwilsh
Moving JSValStorageStatementBinder to mozStoragePrivateHelpers as bindJSValue
storage/src/mozStorageStatementParams.h: At global scope:
storage/src/mozStorageStatementParams.h:78: warning: ‘PRBool mozilla::storage::JSValStorageStatementBinder(JSContext*, mozIStorageStatement*, int, jsval)’ defined but not used
storage/src/mozStorageStatementParams.h:78: warning: ‘PRBool mozilla::storage::JSValStorageStatementBinder(JSContext*, mozIStorageStatement*, int, jsval)’ defined but not used
You get this once for each file that includes a header that defines a static function which is not used in that file.
2009-07-22 17:31:03 -05:00
b3404e8eeb
Bug 505550 - Acquire the db's mutex when cloning statements in Connection::ExecuteAsync
...
Hold the lock around all our API calls so we don't lose so much to the
background thread.
r=asuth
2009-07-22 15:18:33 -07:00
a4d8d9f5d2
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
a1699525aa
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 1: Create helper objects to make using sqlite3_mutex safer and easier.
r=cjones
--HG--
rename : xpcom/tests/TestDeadlockDetector.cpp => storage/test/test_deadlock_detector.cpp
2009-07-22 15:18:33 -07:00
5cefb953b9
Backout of bug 494828 and bug 505550 due to orange.
2009-07-23 10:34:54 -07:00
577adb3056
Fix bustage again from bug 494828 by linking against libxpcomglue_s like we were, but continue to link against libxpcom_core also.
2009-07-23 12:18:12 -04:00
248219b23b
Fix bustage from bug 494828 by linking against libxpcom_core.so for tracemalloc symbols.
2009-07-23 11:42:32 -04:00
dd6c28f49f
Bug 505550 - Acquire the db's mutex when cloning statements in Connection::ExecuteAsync
...
Hold the lock around all our API calls so we don't lose so much to the
background thread.
r=asuth
2009-07-22 15:18:33 -07:00
d98ce2854a
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
4c6bbe05cc
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 1: Create helper objects to make using sqlite3_mutex safer and easier.
r=cjones
2009-07-22 15:18:33 -07:00
231a5ea0d6
Merge places to mozilla-central.
2009-07-19 18:21:55 -07:00
421808700f
Bug 455555 - Use asynchronous queries for places AutoComplete.
...
This changes the location bar's AutoComplete provider to use asynchronous
queries instead of synchronous ones. No more blocking the main thread FTW!
r=mak
r=Mardak
r=dietrich
2009-07-13 12:19:03 -07:00
1dbee03d3f
Bug 499990 - Locale-aware collation, r=sdwilsh, sr=vladimir
2009-07-15 10:49:05 -07:00
bf1ad75653
Bug 499268 - storage code for Symbian emulator. r=sdwilsh
2009-06-29 14:42:56 +09:00
f4f4bda576
Bug 497823. Fix compilation errors in Stroage on AIX. r=sdwilsh
...
--HG--
extra : rebase_source : 58bdecd2cec8b9a39be37514fa2465015addec42
2009-06-29 10:59:40 +12:00
3d3efc34e4
Bug 500750 - mDBConn is not set to NULL in release builds
...
r=asuth
2009-06-26 15:03:53 -07:00
3e203adfc2
Bug 490867 - Variant fixes: coerce null to empty string, GetIsNull should check correct type, variant base type should be void, r=sdwilsh
...
Adds a NullVariant derived class of Variant_base.
2009-06-24 15:04:49 -07:00
ac8e9eb3db
Test for bug 488148. r=asuth
2009-06-24 10:10:52 -07:00
57170806b5
Bug 490085 - Add ability to bind multiple sets of parameters and execute asynchronously
...
Improves the asynchronous API by allowing multiple parameters to be bound before
executing it. The statement is then executed with each set of parameters
asynchronously.
r=asuth
sr=vlad
2009-06-17 12:12:51 -07:00
71aaff31eb
Bug 488148 - Share the mutex used by AsyncExecuteStatements on Connection
...
Greatly reduces the number of mutexes used when using the asynchronous storage
API.
r=bent
r=asuth
2009-06-17 12:12:43 -07:00
f78be7c6b0
Backed out changeset 0997bcc75daf (bug 488148). Silly me - this patch is wrong!
2009-06-19 12:21:44 -07:00
2df095f854
Bug 488148 - Share the mutex used by AsyncExecuteStatements on Connection
...
Greatly reduces the number of mutexes used when using the asynchronous storage
API.
r=bent
r=asuth
2009-06-17 12:12:43 -07:00
9bebb41ad8
Bug 485107 - Do not throw in NewResolve
...
This changeset makes sure that we allow for properties to be defined on the
prototype chain for the JS language helpers in storage.
r=bent
2009-06-11 13:18:58 -07:00
d19b8e79ce
imported patch storage.remove-statement-state-checks
2009-06-11 13:18:58 -07:00
9251159638
Bug 492139 - Expose the Variant publicly so consumers can also use it
...
Actually makes this usable to things outside of the storage module.
r=bsmedberg
--HG--
rename : storage/src/Variant.cpp => storage/src/Variant_inl.h
2009-06-11 13:18:58 -07:00
7b03f6352e
Follow-up to bug 488175 with correct capitalization of makefile variable.
2009-05-19 11:20:20 -04:00
6df221580d
Bug 488175 - flatten dist/include and provide mechanism to install certain headers in namespaced subdirectories (e.g. #include "mozilla/XPCOM.h") r=ted
...
--HG--
rename : xpcom/ds/nsTimeStamp.cpp => xpcom/ds/TimeStamp.cpp
rename : xpcom/ds/nsTimeStamp.h => xpcom/ds/TimeStamp.h
2009-05-18 14:15:05 -04:00
4078a2e8c5
Bug 489481 - Get C++ tests for our C++ helper classes
...
This gets rid of the old, unused native code test file for storage. It adds two
more test files which test our C++ helper classes to ensure that they behave as
advertised. Also fixes a bug found in mozStorageTransaction that was uncovered
while writing these tests.
r=asuth
2009-05-13 12:53:57 -04:00
aaaa6a101b
Bug 490833 - mozIStorageStatement::getParameterIndex should only accept :-named parameters
...
This makes getParameterIndex only work properly with :-named parameters. This
simplifies the work callers actually have to do.
r=asuth
2009-05-08 20:29:57 -04:00
64702a4623
Bug 492139 - Expose the Variant publicly so consumers can also use it
...
This exposes the templated nsIVariant implementation that storage uses
internally so that consumers can use it as well.
r=bsmedberg
--HG--
rename : storage/src/mozStorageVariant.cpp => storage/src/Variant.cpp
rename : storage/src/mozStorageVariant.h => storage/src/Variant.h
2009-05-12 17:08:49 -04:00
831a3e736d
Backed out changeset b6f09258a505 (bug 490833).
2009-05-08 19:57:37 -07:00
7c59976c6e
Bug 490833 - mozIStorageStatement::getParameterIndex should only accept :-named parameters
...
This makes getParameterIndex only work properly with :-named parameters. This
simplifies the work callers actually have to do.
r=asuth
2009-05-08 20:29:57 -04:00
1d46153736
Bug 490084 - Add support for arrays in variantToSQLiteT
...
This adds support for blobs in variantToSQLiteT which means that functions can
no return blobs, as well as future consumers of variantToSQLiteT.
r=asuth
2009-05-08 20:29:57 -04:00
ec0d4b9cfb
Bug 490083 - Refactor VariantToSQLite3Result to be more abstract
...
This refactors this refactors a method currently only used by the Connection
object to be more abstract so we can use it in future work.
r=asuth
2009-05-08 20:29:57 -04:00
6b6f66b054
Bug 489702 - Update mozStorageStatement.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
7d4bb15698
Bug 489661 - Update mozStorageStatementWrapper.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
3c5f686280
Bug 489624 - Update mozStorageRow.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
ee1fec8b27
Bug 489617 - Update mozStorageResultSet.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
574cbe4cf7
Bug 489612 - Update mozStoragePrivateHelpers.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
24adedb3e9
Bug 489603 - Update mozStorageError.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:55 -04:00
bf7dd1c3fd
Bug 489257 - Rename and update mozStorageEvents.* to mozStorageAsyncStatementExecution.*
...
Renames the files to be more representative to what they actually contain. This
also updates the files to follow the storage style guidelines.
r=asuth
--HG--
rename : storage/src/mozStorageEvents.cpp => storage/src/mozStorageAsyncStatementExecution.cpp
rename : storage/src/mozStorageEvents.h => storage/src/mozStorageAsyncStatementExecution.h
2009-04-21 11:27:03 -04:00
2b997f4443
Bug 489030 - Rename mozStorageValueArray.* to mozStorageArgValueArray.*
...
Better reflects the contents of the file. Also updated the file to follow the
storage style guidelines.
r=asuth
--HG--
rename : storage/src/mozStorageValueArray.cpp => storage/src/mozStorageArgValueArray.cpp
rename : storage/src/mozStorageValueArray.h => storage/src/mozStorageArgValueArray.h
2009-04-20 08:01:51 -07:00
e9ac1028cf
Bug 489018 - Rename mozStorageUnicodeFunctions.* to mozStorageSQLFunctions.*
...
New filename better reflects current (and future) contents. Also updates the
files to follow the storage style guidelines.
r=asuth
--HG--
rename : storage/src/mozStorageUnicodeFunctions.cpp => storage/src/mozStorageSQLFunctions.cpp
rename : storage/src/mozStorageUnicodeFunctions.h => storage/src/mozStorageSQLFunctions.h
2009-04-20 07:59:52 -07:00
a37a46bf09
Bug 488379 - Update mozStorageConnection.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-04-17 17:19:31 -04:00
ae3d1fda12
Bug 487871 - Update vim modeline in style doc
...
Also updates the files that have already been updated.
r=asuth
2009-04-13 12:29:41 -04:00
c79541124a
Bug 487715 - Update mozStorageVariant.* to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-04-10 13:20:12 -04:00
2fdde783c2
Bug 461902 - Remove obsoleted 'CompletionNotifier::cancel()'
...
Removes some code that is no longer needed (or executed).
r=sdwilsh
2009-04-08 17:30:26 -04:00
f197fab806
Bug 487145 - Update language helpers to follow style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-04-08 12:24:25 -04:00
55e027800a
Bug 487230 - Remove dead code in mozStorageValueArray.*
...
Removes code that appears to have never been used...
r=asuth
2009-04-08 12:24:22 -04:00
383106f458
Bug 485628 - Clean up mozStorageService.* to match what is in the style guidelines
...
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-03-31 07:26:16 -07:00
7c61c1a906
Bug 485626 - Update style guidelines to reflect namespace discussions
...
r=asuth
2009-03-31 07:26:08 -07:00
a1680d86fb
Bug 485223 - Stop checking mDBConnection is non-null in mozStorageStatement, r=sdwilsh
2009-03-27 10:15:33 -07:00
5ea539378d
Bug 484717 - Assert that our lock is held when the precondition says it should be
...
Use the new NSPR assertion to assert that a given PRLock is held when entering
a function.
r=asuth
2009-03-26 16:33:35 -04:00
1c4fdb275c
Bug 485071 - implement mozStorageStatementParams::NewEnumerate
...
This allows for the enumeration of named parameters on the parameter JS helper
object.
r=asuth
r=bent
2009-03-26 16:33:35 -04:00
1771ccc676
bug 482085 - fix all xpcshell tests to not reference files from the srcdir. r=bsmedberg,waldo
...
--HG--
rename : toolkit/components/downloads/test/downloads.empty.sqlite => browser/components/privatebrowsing/test/unit/downloads.empty.sqlite
rename : dom/src/json/test/fail1.json => dom/src/json/test/unit/fail1.json
rename : dom/src/json/test/fail10.json => dom/src/json/test/unit/fail10.json
rename : dom/src/json/test/fail11.json => dom/src/json/test/unit/fail11.json
rename : dom/src/json/test/fail12.json => dom/src/json/test/unit/fail12.json
rename : dom/src/json/test/fail13.json => dom/src/json/test/unit/fail13.json
rename : dom/src/json/test/fail14.json => dom/src/json/test/unit/fail14.json
rename : dom/src/json/test/fail15.json => dom/src/json/test/unit/fail15.json
rename : dom/src/json/test/fail16.json => dom/src/json/test/unit/fail16.json
rename : dom/src/json/test/fail17.json => dom/src/json/test/unit/fail17.json
rename : dom/src/json/test/fail18.json => dom/src/json/test/unit/fail18.json
rename : dom/src/json/test/fail19.json => dom/src/json/test/unit/fail19.json
rename : dom/src/json/test/fail2.json => dom/src/json/test/unit/fail2.json
rename : dom/src/json/test/fail20.json => dom/src/json/test/unit/fail20.json
rename : dom/src/json/test/fail21.json => dom/src/json/test/unit/fail21.json
rename : dom/src/json/test/fail22.json => dom/src/json/test/unit/fail22.json
rename : dom/src/json/test/fail23.json => dom/src/json/test/unit/fail23.json
rename : dom/src/json/test/fail24.json => dom/src/json/test/unit/fail24.json
rename : dom/src/json/test/fail25.json => dom/src/json/test/unit/fail25.json
rename : dom/src/json/test/fail26.json => dom/src/json/test/unit/fail26.json
rename : dom/src/json/test/fail27.json => dom/src/json/test/unit/fail27.json
rename : dom/src/json/test/fail28.json => dom/src/json/test/unit/fail28.json
rename : dom/src/json/test/fail29.json => dom/src/json/test/unit/fail29.json
rename : dom/src/json/test/fail3.json => dom/src/json/test/unit/fail3.json
rename : dom/src/json/test/fail30.json => dom/src/json/test/unit/fail30.json
rename : dom/src/json/test/fail31.json => dom/src/json/test/unit/fail31.json
rename : dom/src/json/test/fail32.json => dom/src/json/test/unit/fail32.json
rename : dom/src/json/test/fail33.json => dom/src/json/test/unit/fail33.json
rename : dom/src/json/test/fail34.json => dom/src/json/test/unit/fail34.json
rename : dom/src/json/test/fail4.json => dom/src/json/test/unit/fail4.json
rename : dom/src/json/test/fail5.json => dom/src/json/test/unit/fail5.json
rename : dom/src/json/test/fail6.json => dom/src/json/test/unit/fail6.json
rename : dom/src/json/test/fail7.json => dom/src/json/test/unit/fail7.json
rename : dom/src/json/test/fail8.json => dom/src/json/test/unit/fail8.json
rename : dom/src/json/test/fail9.json => dom/src/json/test/unit/fail9.json
rename : dom/src/json/test/json2.js => dom/src/json/test/unit/json2.js
rename : dom/src/json/test/pass1.json => dom/src/json/test/unit/pass1.json
rename : dom/src/json/test/pass3.json => dom/src/json/test/unit/pass3.json
rename : testing/xpcshell/example/location_load.js => testing/xpcshell/example/unit/location_load.js
rename : toolkit/components/commandlines/test/unit/unix/test_bug410156.js => toolkit/components/commandlines/test/unit_unix/test_bug410156.js
rename : toolkit/components/commandlines/test/unit/win/test_bug410156.js => toolkit/components/commandlines/test/unit_win/test_bug410156.js
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug257155/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug257155/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_a_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_a_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_a_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_a_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_b_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_b_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_b_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_b_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_c_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_c_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_c_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_c_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_d_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_d_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_d_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_d_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_e_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_e_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_e_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_e_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_f_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_f_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_f_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_f_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_g_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_g_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_g_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_g_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_9/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug335238_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug335238_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug335238_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug335238_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_10/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_10/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_11/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_11/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_12/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_12/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_13/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_13/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_9/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug394300_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug394300_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug394300_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug394300_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_a_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_a_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_a_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_a_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_b_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_b_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_b_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_b_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_c_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_c_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_c_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_c_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_d_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_d_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_d_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_d_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug397778/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug397778/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug425657/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug425657/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_1/README => toolkit/mozapps/extensions/test/addons/test_bug428341_1/README
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_9/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug436207/install.js => toolkit/mozapps/extensions/test/addons/test_bug436207/install.js
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_9/install.rdf
2009-03-21 11:20:00 -04:00
74f617d3a6
Bug 483152 - Stop giving the ability to get the native sqlite3_stmt pointer
...
We don't really want to give this pointer out to consumers since we track some
state, and if they call SQLite functions on it, can cause our internal state to
be inaccurate.
r=asuth
2009-03-20 18:41:01 -04:00
78f0a0ec2e
Bug 483154 - mozStorageStatementParams should use mozIStorageStatement API
...
This makes us use the public API on mozIStorageStatement, which centralizes some
of our logic.
r=asuth
r=bent
2009-03-20 18:41:01 -04:00
3e20da65a1
Bug 483157 - mozStorageStatementRow needs to use mozIStorageStatement API
...
This makes our language helper use public API instead of calling SQLite
directly, which centralizes some of our logic.
r=asuth
r=bent
2009-03-20 18:41:01 -04:00
311505dbc1
Bug 483880 - Pull out implementation of mozStorageVariant_base so we can include it in more than one file
...
The current implementation means it can only be #included once, which makes it
not terribly useful for other consumers.
r=asuth
2009-03-20 16:28:16 -04:00
c1f550d335
Bug 482159 - Add support for nsCString in mozStorageVariant
...
r=asuth
r=bent
2009-03-20 16:28:16 -04:00
cb4b068b6d
Bug 481261 - Expose when queries are being inefficient in debug builds
...
Follow-up change to support suppressing the warning for a certain query, and
reducing the verbosity of the message.
r=asuth
2009-03-20 16:28:16 -04:00
d56775d13f
Bug 483739 - Establish style guidelines for storage
...
This adds style.txt to storage/ that indicates how new code should be styled.
Reviewers are expected to enforce this!
r=asuth
2009-03-20 16:28:16 -04:00
ad80aba6ea
Bug 479728 - Rename AsyncExecute.
...
This renames the class to AsyncExecuteStatement to be a bit more clear as to
what it does.
r=asuth
2009-03-13 16:32:19 -07:00
fda0936e59
Bug 481261 - Expose when queries are being inefficient in debug builds.
...
This adds a warning in debug builds about queries that do not use an index to
sort, which tend to be much much slower.
r=asuth
2009-03-12 14:30:15 -04:00
2b3e5b31d7
Bug 482614 - mozStorageVariant leaks its internal data due to non-virtual destructor
...
Most commonly seen when using executeAsync and having the results return a
string or blob.
r=sdwilsh
2009-03-10 18:54:24 -04:00
2d37f4bff0
Bug 479543 - mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements; r=sdwilsh
2009-03-01 18:23:26 +01:00
924eedb602
Bug 479729 - Unable to shutdown using async statements.
...
This changeset finalizes statements before we try to rollback a transaction with
the async storage API. This problem only came up when you canceled a statement.
r=asuth
2009-02-26 12:55:47 -05:00
f09ed272e1
merge for backout
2009-02-23 17:35:19 -05:00
84f5752621
Backed out changeset f8926cd4a7b2 (bug 479543) since it breaks unit tests in
...
debug builds.
2009-02-23 17:34:46 -05:00
bb0410d426
Bug 453781 - Merge TableExists and IndexExists, and replace nsCString with nsCAutoString
...
r=sdwilsh
2009-02-23 13:05:24 -05:00
c17c781352
Bug 479543 - mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements
...
r=sdwilsh
2009-02-22 00:11:57 -05:00
0103bf3664
Bug 473268 - We should use forget instead of swap in mozStorageService.cpp; r=sdwilsh
2009-02-03 15:42:28 +01:00
35d80445c3
Bug 463907 - mozStorageConnection::ExecuteAsync does not check that provided statements have not been finalized; r=sdwilsh
2009-02-03 15:42:22 +01:00
424883d380
Bug 466622. Replace nsCStringArray with nsTArray<nsCString> for more consistent code and fewer heap allocations. r+sr=roc,r=bsmedberg
...
--HG--
extra : rebase_source : b963bf5de9d9c445b14620479691482512e0faf2
2009-01-22 17:15:34 +13:00
d2ad3e3850
Add missing return (from bug 473845).
2009-01-21 17:12:41 -08:00
e68b436153
Bug 473845 - Break a potential cycle with XPConnect and mozStroageService
...
This changeset removes a cycle that gets created between XPConnect and the
storage service. This accomplishes this by releasing the cached reference to
XPConnect during xpcom-shutdown.
This was the last remaining leak of the browser-chrome test harness, so this
also sets the leak threshold to zero for that test.
r=bent
2009-01-21 16:52:16 -05:00
b984a21254
Bug 384954 - Get xpcshell tests for wrapped statements
...
r=sdwilsh
2009-01-21 14:26:07 -05:00
ada018a429
Bug 431473. Kill unused mozIStorageDataSet. r=sdwilsh
2009-01-19 21:44:31 +13:00
d8f1bff747
Bug 461047 - Replace nsStringArray with nsTArray<nsString>. r+sr=roc
2009-01-18 21:14:14 +01:00
804cc7ee91
Backed out changeset 8019a959aade
2009-01-16 22:20:33 +13:00
065bde22f3
Bug 461047. Replace nsStringArray with nsTArray<nsString>. r+sr=roc
...
--HG--
extra : rebase_source : 7a20af24c97867efbb28dafa6a70ea1b4cf00e58
2009-01-16 20:51:04 +13:00
a3688651e0
Bug 445525 - set SQLITE_CONFIG_MEMSTATUS to 0. v1.1 turn off SQLITE_CONFIG_MEMSTATUS at init-time. r=sdwilsh
2008-12-13 22:38:18 -08:00
ede141e1ac
Bug 463988 - Gloda: mozStorageConnection holds lock while calling outside its module leading to PR_ASSERT(lock->owner != me) on shutting down while indexing is active. v1 add flag that indicates async thread is shutting down, don't call nsIThread::Shutdown with a lock held. r=sdwilsh.
2008-12-13 18:59:17 -08:00
07b93ae9d5
Bug 467856 - Expose SQLITE_IOERR, r=sdwilsh
2008-12-09 21:39:32 +01:00
187f70f12f
fix for windows bustage
2008-12-08 17:36:20 -05:00
456c8b7594
Bug 462173 - We treat transaction errors as fatal when we should not
...
r=asuth
2008-12-08 17:14:14 -05:00
50794c8ae6
Bug 448114 - Notify about non-finalized statements in debug builds
...
r=asuth
2008-12-08 17:14:14 -05:00
adac41015b
Bug 462432 - Leak mAsyncExecutionMutex
...
r=sdwilsh
2008-11-27 12:34:40 -08:00
287ddd5ebc
Addressing review nit for bug 464202 that was improperly addressed in changeset 59d84ac24da2
...
original patch r=mrbkap, a=beltzner
2008-11-20 14:11:03 -05:00
26fa978b71
Address followup nit for bug 464202.
2008-11-19 11:54:29 -08:00
6017aa4aa8
Bug 457743 - Automatic wrapper creates cycles, and thus leaks. r=dcamp, r=asuth, a=beltzner for 1.9.1b2
2008-11-19 11:33:00 -08:00
14720845a3
Bug 464202 - nsGlobalWindow leak running browser-chrome Mochitests. r=mrbkap a=beltzner
2008-11-19 01:11:30 -05:00
deb7217ab3
Bug 461344 - abort if the version of sqlite we are using is not new enough
...
This adds a runtime check to ensure that the version of SQLite that is running
is the same as the one that we were compiled with. If the check fails, we will
display a prompt to the user, and abort.
r=bsmedberg
2008-10-31 20:38:58 -04:00
f653780142
Bug 451815 - Need a more reliable way to indicate SQLITE_BUSY
...
This changeset adds a new error result for storage (NS_ERROR_STORAGE_BUSY) that
maps directly to when SQLite would return SQLITE_BUSY.
r=asuth
--HG--
rename : storage/src/mozStorage.h => storage/src/mozStoragePrivateHelpers.h
2008-10-30 18:50:00 -04:00
801290a84c
Bug 462434 - Transaction semantics are bad
...
This propagates errors in starting and ending transactions.
r=asuth
2008-10-30 18:46:25 -04:00
da47747760
Bug 454740 - Asynchronous storage should batch/chunk results
...
This changeset batches results obtained by the async storage API so we are not
flooding the calling thread with so many events.
r=asuth
2008-10-29 13:13:32 -04:00
0430a4d084
Bustage fix (= missed additional change) for
...
Bug 460635 - There should be one async execution thread per mozStorageConnection connection; v1.2; r=(bugmail + sdwilsh)
2008-10-29 05:09:23 +01:00
2bb839d2b7
Bug 460635 - There should be one async execution thread per mozStorageConnection connection; v1.2; r=(bugmail + sdwilsh)
2008-10-29 04:53:19 +01:00
dd6c7ee933
Bug 458998 - AsyncExecute helper classes can complete() before they are added to mPendingEvents
...
This changeset also fixes a few issues where we were holding a lock while and
kills off a few other race conditions that were noticed in the course of fixing
this bug.
r=bent
2008-10-24 18:30:07 -04:00
18700696dc
Bug 461263 - Race condition exists with mozStorageTransaction
...
While the race was technically "safe", we could have possibly wrongly tried to
commit or rollback. This changeset makes us operate sanely in all conditions.
r=bent
2008-10-24 16:50:01 -04:00
d28587dd1d
Bug 458811 - Allow for multiple statements to be executed at in a transaction asynchronously
...
This changeset allows consumers to execute a series of statements, in order,
asynchronously in a transaction.
r=dcamp
sr=sicking
2008-10-13 18:45:40 -04:00
af33d57a63
Bug 458756 - Use raw sqlite3_stmt pointers instead of the mozStorageStatement object for async statements
...
This ends up saving us a bunch of work when we execute a statement
asynchronously, and makes bug 458811 easier to do.
r=dcamp
2008-10-10 17:41:31 -04:00
17a0817cd9
comment change to kick off new builds
...
rs=me
2008-10-09 20:29:14 -04:00
d29d8419b3
Bug 453722 - Do not need to safeguard more than one call to Init for storage service
...
Bug 449822 made it so services can not be initialized more than once when being
called from multiple threads. Storage used to protect against this, but no
longer needs to do this (which this changeset makes us do).
r=bent
2008-09-25 14:28:29 -04:00
1234432adf
Bug 456489 - WinCE Compiler keyword interface used in mozStorageRow.cpp. patch by wolfe, r=sdwilsh
2008-09-23 11:03:48 -07:00
7216b611ec
Bug 456471 - mozIStorageError IDL file needs ERROR undefined for WinCE / WinMobile. patch by wolfe, r=sdwilsh
2008-09-23 11:02:55 -07:00
65b3bb8092
Bug 455202 - executeAsync without listener/callback results in segfault when error encountered; test part; r=sdwilsh
2008-09-15 18:50:21 +02:00
8d86adfc37
Bug 455202 - executeAsync without listener/callback results in segfault when error encountered; fix part; r=sdwilsh
2008-09-15 18:49:18 +02:00
3d079626e8
Bustage fix - double semi-colon.
2008-09-12 17:40:55 -04:00
78e4ede55b
Bug 452897 - Automatically provide the wrapper for JavaScript
...
This changeset adds a language helper to mozStorageStatement so it gets the
attributes and methods that mozIStorageStatementWrapper has. We can now mark
the wrapper as depreciated.
r=vlad
r=mrbkap
--HG--
rename : storage/test/unit/test_storage_statement_wrapper.js => storage/test/unit/test_statement_wrapper_automatically.js
2008-09-12 17:30:41 -04:00
3e49f59cca
Bug 452897 - Automatically provide the wrapper for JS
...
This changeset has no code changes - it just separates three classes that were
all contained in one file into three files (with appropriate headers). This is
being done to make the actual code changes for the bug simpler.
rs=me
2008-09-12 17:30:37 -04:00
4c52e158c3
Bug 452836 - Optimize calls to sqlite3_prepare_v2
...
This changeset makes all calls pass -1 for length which indicates that the
string is null terminated.
r=Neil
2008-09-03 12:20:10 -04:00
6b5d53f655
Bug 407216 - DOM quick stubs - faster paths for top N DOM methods (r+sr=jst, security r=mrbkap, build r=bsmedberg)
...
* * *
* * *
* * *
2008-08-19 21:38:24 -05:00
6dea9a020c
Bug 452836 - Optimize calls to sqlite3_prepare_v2
...
This makes sqlite not copy the sql string when preparing it, saving us a string
copy every time.
r=bholley
2008-08-29 17:19:23 -04:00
cfba414480
Bug 452833 - Do not loop if we get SQLITE_SCHEMA
...
We used to have to try again if we got SQLITE_SCHEMA back from sqlite when we
prepare a statement. However, this isn't needed with the new v2 interface,
which we now use.
r=bholley
2008-08-29 17:17:01 -04:00
7132ee9652
Bug 451058 - Address post-review comments.
...
This addresses some comments that were brought up after the code had already
landed.
r=Neil
2008-08-29 16:46:14 -04:00
9b3a321600
Bug 452841 - Remove hack in mozStorageStatement::Initialize
...
This removes some code that was at one time needed to work around a sqlite but
that no longer exists.
r=vlad
2008-08-29 16:42:12 -04:00
97a796274f
Bug 451463 - mozStorageStatement needs threadsafe refcounting
...
This changeset makes mozStoageStatement use threadsafe refcounting. The class
is still not threadsafe, but JS consumers cannot create a statement off of the
main thread since it would be garbage collected on the main thread.
r=bent
2008-08-27 13:11:02 -04:00
d0e6e8b795
Bug 448607 - Includes and comments are not accurate in mozStorageBackground.*
...
This fixes some comments that are wrong and removes unneeded includes.
rs=me; there's really no change here.
2008-08-27 13:05:03 -04:00
abf12d8076
Backing out changeset cf6c811e1272 (bug 407216) due to debug assertions.
2008-08-19 22:28:26 -05:00
09f9ac1d0a
Bug 407216 - DOM quick stubs - faster paths for top N DOM methods (r+sr=jst, security r=mrbkap, build r=bsmedberg)
...
* * *
* * *
2008-08-19 21:38:24 -05:00
b4c01f2f50
Bug 450665: test_bug-365166.js creates file in /tmp instead of in build directory. r=sdwilsh
2008-08-16 16:17:47 +01:00
78b08dae0c
Make mozIStorageConnection threadsafe - bug 448476 r=robarnold
2008-08-12 17:50:25 -07:00
9a06360391
Avoid returning false without setting an exception. bug 429521, r=sdwilsh
2008-08-04 10:04:27 -07:00
31a2fea1d6
Test that the object has the right class, even when called from native code. bug 444233, r=shaver
2008-07-16 19:29:06 +02:00
9b3bae8da4
Bug 444821 - Re-enable test_storage_statement_executeAsync.js
...
This fixes the test to run properly on slower running systems (like the
tinderbox machines).
r=vlad
2008-07-15 11:04:52 -04:00
56be74f21c
Disable stupid test (stupidity is my own fault). Bug 444821 to fix it properly
...
and re-enable it.
2008-07-11 17:29:45 -04:00
a583d673c5
Bug 429986 - Provide an option for database to be asynchronous
...
This adds unit tests for the async storage work.
r=vlad
2008-07-11 15:47:38 -04:00
35ba2ed351
Bug 429986 - Provide an option for database access to be asynchronous.
...
This adds a method to mozIStorageStatement to allow for a statement to execute
asynchronously and report to a callback. For writes, this can move fsyncs,
which can be painful, off of the main thread.
r=vlad
sr=shaver
2008-07-11 15:47:33 -04:00
3da654e7c2
Bug 435994 - Implement ResultSet and Row for mozIStorageStatement::executeAsync
...
These creates the result set and row objects to be used with the async storage
API added in bug 429986.
r=vlad
sr=shaver
2008-07-11 15:47:28 -04:00
fb401724a9
Bug 435995 - Implement an nsIVariant object storage can use.
...
This creates a templated C++ class for storage to map SQLite data types to the
correct nsIVariant.
r=robarnold
r=vlad
2008-07-11 15:47:21 -04:00
3436da9283
Bug 444347 - Make NSPR logging a bit more useful
...
This adds additional NSPR logging to storage. Logging is now done when a sql
statement is prepared, a connection is opened, and a connection is closed.
Additionally, when sqlite3_trace is called, we also log the address of the
connection so you know what queries are running on which database. The address
is also logged at connection open so you can perform the mapping.
r=vlad
2008-07-11 15:00:58 -04:00
140f31f75e
Bug 434838 - mozStorageConnection uses nsDataHashtable when it should use nsInterfaceHashtable
...
This makes mozStorageConnection no longer manually AddRef and Release user
defined functions.
r=sdwilsh
r=bent
2008-07-08 18:38:25 -04:00
bad1189195
Bug 442762 - Annotate mozStorageStatementScoper with NS_STACK_CLASS, r=sdwilsh
2008-06-30 21:03:29 -04:00
Dave Townsend
Saint Wesonga
Jeff Walden
Chris Jones
Taras Glek
Ehsan Akhgari
Vladimir Vukicevic
Shawn Wilsher
timeless@mozdev.org, Jason Orendorff
Daniel Holbert
Marco Bonardo
timeless@mozdev.org
Mitchell Field
Andrew Sutherland
Dan Witte
Justin Lebar
Reed Loden
David Dahl ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
Shawn Wilsher
L. David Baron
Blair McBride
Ginn Chen
Dietrich Ayala
Robert O'Callahan
Paul O’Shannessy
Benjamin Smedberg
Jacek Caban
Akshay Gupta
Curtis Bartley
Drew Willcoxon
Makoto Kato
Shailen
Shawn Wilsher
Matthew Hayward
Ted Mielczarek
Ben Turner
Ryan VanderMeulen
Alex Gartrell
Nilay Vaish
Andrew Sutherland
Fred Jendrzejewski
Blake Kaplan
Robert Sesek
Marco Bonardo
Serge Gautherie
Doug Turner
Lukas Blakk
Arpad Borsos