3b9a109d82
353908: klocwork OOM crash in tdcache.c. r=nelson
2006-10-09 22:29:12 +00:00
4cc26433e6
353742: klocwork null ptr dereferences in pki3hack.c. r=nelson
2006-10-09 22:21:41 +00:00
a168b0dbcc
353375: Klocwork 76513 - Null ptr deref in nssCertificateList_DoCallback. r=nelson
2006-10-09 18:51:55 +00:00
a7edef3088
353371: Klocwork 91117 - Null Pointer Dereference in CERT_CertChainFromCert. r=nelson
2006-10-09 18:45:02 +00:00
d4df5484a3
Bug 354313. Fix leak in STAN_GetCERTCertificateName. r=julien,rrelyea
2006-10-01 05:37:24 +00:00
d64e3427a6
337013: OOM crash [@ nssArena_Destroy - nssTrustDomain_TraverseCertificatesBySubject][@ nssArena_Destroy - nssTrustDomain_TraverseCertificatesByNickname] Dereferencing possibly NULL "tmpArena". r=nelson, sr=julien
2006-08-30 17:57:20 +00:00
45f5a763d7
Fix for bug 225525 . Resolve race assigning NSSCertificate fields which leaked memory and slot reference. r=nelson
2006-08-22 22:54:11 +00:00
80a2861232
Fix race in CERT_NewTempCertificate. Bug 341323. r=julien,rrelyea
2006-08-22 03:30:14 +00:00
d5aa4d29c5
[Bug 337008] OOM crash [@ nssList_Add - STAN_InitTokenForSlotInfo - STAN_LoadDefaultNSS3TrustDomain][@ nssList_Clone - nssList_CreateIterator - STAN_LoadDefaultNSS3TrustDomain] Dereferencing possibly NULL "(td)->tokenList". r=nelson, sr=wtc
2006-06-13 21:36:29 +00:00
505671ed77
Eliminate a crash and plug a leak in the error path for function
...
nssSMIMEProfile_Create. Coverity bug 337101. r=alexei.volkov.
2006-05-18 23:29:19 +00:00
e05b17bc20
[Bug 337008] OOM crash [@ nssList_Add - STAN_InitTokenForSlotInfo - STAN_LoadDefaultNSS3TrustDomain][@ nssList_Clone - nssList_CreateIterator - STAN_LoadDefaultNSS3TrustDomain] Dereferencing possibly NULL "(td)->tokenList". r=nelson, sr=wtc
2006-05-18 21:00:58 +00:00
e1b759198c
[Bug 337009] OOM crash [@ nssList_Count - nssTrustDomain_GetCertsFromCache] Dereferencing possibly NULL "certList". r=nelson
2006-05-17 20:38:59 +00:00
2c62bf1d13
Bugzilla bug 334683: removed extraneous semicolons. r=alexei.volkov.
...
Modified files: cmd/certutil/certutil.c lib/pki/pkistore.h
2006-04-19 19:04:23 +00:00
7ceb91038f
Fix for bug 311164 . Initialize stan cert store object early to fix a race condition. r=nelson
2006-04-07 05:49:04 +00:00
6893edd94b
Bugzilla bug 300068: fixed the bug that "collection" is used uninitialized
...
if "td", "c", or "cc" is NULL. The patch is contributed by Wolfgang
Rosenauer <mozilla@rosenauer.org>. r=wtc.
2005-07-08 17:06:15 +00:00
9ee0623105
Bugzilla Bug 298962: Removed dead code: nssBestCertificate_SetArgs,
...
nssBestCertificate_Callback, and nssBestCertificateCB. r=jpierre,nelsonb.
Modified files: certificate.c pkitm.h
2005-06-28 17:55:29 +00:00
2a3bb9d1e0
Bugzilla Bug 295754: moved duplicate function subject_list_sort to
...
certificate.c and renamed it nssCertificate_SubjectListSort.
r=relyea,nelsonb.
Modified files: certificate.c pkim.h pkistore.c tdcache.c
2005-06-27 21:50:06 +00:00
dd3c6f24d1
Bugzilla Bug 295754: fixed a crash in subject_list_sort if a cert is not
...
decodable (e.g., it has unsupported critical extension). r=relyea,nelsonb.
Modified Files: pkistore.c tdcache.c
2005-06-24 00:33:28 +00:00
afed9f1c17
Fix for 283765. Fix for UMR in NSSUsage. r=julien
2005-03-04 04:32:04 +00:00
82b1183c84
Bugzilla Bug 267158: removed the $Name$ RCS keyword from our source files.
...
This keyword adds noise to the output of "ident libnss3.so | grep NSS"
on our debug build, and appears to cause spurious CVS conflicts. r=nelsonb.
2005-01-20 02:25:51 +00:00
69a7452f8e
Include nssrwlk.h for NSSRWLock_ funtions
2004-10-07 04:36:03 +00:00
e715f98c50
Bugzilla Bug 252702
...
NSS needs to handle better token insertion and removal.
Applied from patch to NSS 3.9
2004-07-29 23:38:14 +00:00
7e82fd4194
Bug 250687
...
NSS Crashes or leaks Cert references if bad certs are passed up by PKCS #11 modules.
r=nelson
sr=ian
2004-07-21 18:18:05 +00:00
be72ca16c5
bug 180268, reimplement ssl step-up for builtins
2004-05-17 20:08:38 +00:00
3634d4d94b
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-25 15:03:26 +00:00
c3a3521876
Enable a chain to validate when a perm cert has been issued by a
...
temp cert. Bug 233038. r=ian,relyea
2004-02-07 07:17:31 +00:00
fac46295ff
Bugzilla bug 228624: we need to call STAN_ForceCERTCertificateUpdate if
...
the cert's instances changed. r=relyea.
2003-12-19 22:33:12 +00:00
991ddf2ba6
Bugzilla bug 228624: made PK11_ListCertsInSlot reach into the Stan layer
...
to obtain the correct nicknames of the cert instances (pk11cert.c). Fixed
the bug that if a cert we want to add the the cache is already in the
cache, we should merge the instances of the cert before destroying the
duplicate cert (tdcache.c). r=jpierre,relyea.
2003-12-18 18:23:17 +00:00
e3cda94421
Bugzilla bug 228618: fixed an incorrect use of realloc. Fixed an unused
...
variable compiler warning. r=jpierre.
2003-12-16 04:24:57 +00:00
b904b47318
Detect empty emailAddr strings in CERTCertificates. Bugzilla bug 211540.
...
Modified Files:
cmd/dbck/dbck.c cmd/signtool/util.c lib/certdb/certdb.c
lib/certdb/stanpcertdb.c lib/pkcs7/p7decode.c lib/pki/certificate.c
lib/pki/pki3hack.c lib/smime/cmssiginfo.c lib/softoken/pkcs11u.c
2003-11-15 00:10:01 +00:00
d1e962a746
Workaround race. Reduce leaks. Not a real fix. Bugzilla bug 225525.
2003-11-13 03:41:32 +00:00
1b6811ad2b
Eliminate some leaks in Stan cert code.
...
Partial fix to bugscape bug 53573.
2003-11-11 21:46:53 +00:00
f56dde49b6
Bugzilla bug 217247: improved the memory leak fix for the appData nicknames
...
returned by PK11_ListCerts. Instead of allocating them from the heap first
and copying to the arena, allocate them from the arena directly. r=jpierre
Modified Files: certhigh.c pk11cert.c pki3hack.h pki3hack.c
2003-09-12 19:38:04 +00:00
b881a9a0c6
Bugzilla bug 72291: have PK11_ListCerts return all the cert instances on
...
tokens. The patch is Julien Pierre's, with changes by Wan-Teh Chang.
Modified Files: pk11wrap/pk11cert.c pki/pki3hack.c pki/pki3hack.h
2003-08-25 19:18:02 +00:00
f4184b8ca1
Bugzilla bug 214695: fixed incorrect use of PR_AtomicDecrement on reference
...
counts. The reference count should not be read "naked". Instead, we
should simply use the return value of PR_AtomicDecrement for the result of
the decrement.
Modified Files: dev/devmod.c dev/devslot.c dev/devtoken.c pki/certificate.c
pki/pkibase.c
2003-08-01 02:02:47 +00:00
788ad0837b
Bug 212112: we don't need to lock td->cache->lock while calling
...
STAN_ForceCERTCertificateUpdate. This fixed a recursive deadlock.
r=mcgreer.
2003-07-10 01:24:17 +00:00
f7e98250bc
Bug 204011: fixed the bug that nssPKIObjectCollection_AddInstances frees an
...
instance twice if add_object_instance fails. r=mcgreer.
2003-05-02 03:01:13 +00:00
ed4c7c9bc6
Fix for 199227 - keep enumerating certs in tokens even if one token fails. r=relyea
2003-04-01 00:07:05 +00:00
fbd8eb30c2
bug 174200, don't attempt to decode cert when destroying it, handle failure
...
to decode cert serial number
r=nelsonb
2003-02-18 20:53:14 +00:00
7f77163102
Fix for 190424 - don't query CKA_NETSCAPE_EMAIL attribute. r=wtc
2003-01-30 05:12:10 +00:00
da30938629
Fix for 190424 - don't query CKA_NETSCAPE_EMAIL attribute . r=wtc
2003-01-30 03:02:55 +00:00
ec08fd394a
Bug 187629: do not refresh a CERTCertificate if the same instance of a
...
cached cert is added to the collection.
2003-01-09 04:29:01 +00:00
39a4a9cc69
Bug 186586: If at NSS shutdown there are still certs in the cert caches,
...
cause NSS shutdown and the next NSS initialization to fail but do not
destroy the cert caches (and the crypto context and trust domain containing
them) to avoid a crash if the NSS client destroys the certs later. New
error codes needed to be added to indicate the failure of NSS shutdown and
NSS initialization due to this cause.
2003-01-08 21:58:29 +00:00
cd80470fa2
Bug 186586: If at NSS shutdown there are still certs in the cert caches,
...
cause NSS shutdown and the next NSS initialization to fail but do not
destroy the cert caches (and the crypto context and trust domain containing
them) to avoid a crash if the NSS client destroys the certs later. New
error codes needed to be added to indicate the failure of NSS shutdown and
NSS initialization due to this cause.
Modified Files:
base/errorval.c nss/nssinit.c pki/pki3hack.c pki/pki3hack.h
pki/pkistore.c pki/pkistore.h pki/tdcache.c pki/trustdomain.c
util/secerr.h
2003-01-08 21:48:47 +00:00
12860a5501
Bug 183612: added support for looking up a cert by subject key ID and
...
creating a CMS recipient info from a subject key ID. The patch was
contributed by Javi Delgadillo <javi@netscape.com>. r=relyea, wtc.
Modified Files:
certdb/cert.h certdb/certdb.c certdb/certdb.h certdb/certv3.c
certdb/stanpcertdb.c nss/nss.def nss/nssinit.c
pk11wrap/pk11cert.c pk11wrap/pk11func.h pk11wrap/secmod.h
pki/pki3hack.c smime/cms.h smime/cmslocal.h smime/cmspubkey.c
smime/cmsrecinfo.c smime/cmssiginfo.c smime/cmst.h
smime/smime.def
2002-12-17 01:39:46 +00:00
9ec0046baa
bug 177366, clean up refcounting
...
r=relyea
2002-11-06 18:53:55 +00:00
b9d29eefdc
bug 174634, fix handling of authorityCertIssuer in chain construction
2002-10-22 14:43:08 +00:00
5fd94ca1a9
Bug 164501. Return a proper error code from PK11_FindCrlByName() so the CRL
...
code can decide if there is a hw or system failure preventing the reading of a
CRL or if the CRL is just not there.
2002-10-10 20:30:19 +00:00
6199159d80
bug 171224, changes to path construction
...
r=nelsonb
2002-10-01 14:32:15 +00:00
22503c53a1
Bug 171422: removed unused (and incorrect) code. r=mcgreer.
2002-09-30 20:33:44 +00:00
alexei.volkov.bugs%sun.com
nelson%bolyard.com
julien.pierre.bugs%sun.com
wtchang%redhat.com
relyea%netscape.com
ian.mcgreer%sun.com
gerv%gerv.net
nelsonb%netscape.com
wchang0222%aol.com
wtc%netscape.com
jpierre%netscape.com