b834439797
Bug 864727 part 5. Make all the WrapObject methods take a handle for the scope object. r=ms2ger
2013-04-25 12:29:54 -04:00
47de9d3ebe
Bug 864727 part 4. Pass a handle for the scope object to all the various Wrap*Object stuff in BindingUtils. r=ms2ger
...
Note: The JS::Rooted in CGWrapWithCacheMethod is just there until we start passing a handle to Wrap().
2013-04-25 12:29:53 -04:00
73485c55dd
Bug 864727 part 3. Pass a handle for the parent object to WebIDL dictionary ToObject. r=ms2ger
2013-04-25 12:29:53 -04:00
395cf489d9
Bug 864727 part 2. Pass a handle for the scope object to union conversions. r=ms2ger,terrence
2013-04-25 12:29:52 -04:00
14a0aa1894
Bug 863880 - Take a less ad hoc approach to forward declarations in bindings generation. r=bz
2013-04-25 08:42:43 -07:00
ab223cc59f
Bug 863964 - clean up forward class declarations in codegen. r=bz
2013-04-25 08:42:43 -07:00
f760939bec
Bug 731746 part 4. When wrapping a JS-implemented webidl object, define the new object as a property on the implementing object. r=mccr8
2013-04-24 22:44:28 -04:00
45135ea107
Bug 731746 part 3. Change JS-implemented webidl codegen to always invoke the parent constructor if there is a parent interface. r=mccr8
2013-04-24 22:44:28 -04:00
529764fe78
Bug 731746 part 2. Change JS-implemented webidl codegen to pass an nsPIDOMWindow, not an nsISupports, to the object constructor. r=mccr8
2013-04-24 22:44:27 -04:00
4672697c11
Bug 862629 part 2. Remove the now-unused scope object bit in js-to-native conversions. r=peterv
2013-04-24 14:59:15 -04:00
f3f44cfa74
Bug 862629 part 1. Stop playing compartment games with WebIDL callbacks and just use the given object as-is. r=peterv
2013-04-24 14:59:15 -04:00
d7b1013b15
Bug 843264. Allow returning sequences of non-primitive types from callback methods. r=mccr8
2013-04-24 14:59:14 -04:00
d9ed7658f1
Bug 864535. Drop some comments from WebIDL proxy [[Delete]] implementations, since the spec has changed. r=waldo
2013-04-24 14:59:14 -04:00
0ba15d837e
Bug 856338 - Using sequence<foo>? as an argument type crashes when passing non-null value, p=Ms2ger+smaug,r=bz
...
--HG--
extra : rebase_source : fb54e52db051584333c9430b0b000ee052e5b2d7
2013-04-23 02:49:49 +03:00
bfcf81990d
Bug 852094 - Support Unforgeable on proxy-based DOM bindings. r=bz.
2012-12-20 10:56:11 +01:00
2693eed75f
Bug 863386. Add support for nullable enum arguments and return values. r=mccr8
...
This incidentally fixes bug 843355
2013-04-19 23:04:19 -04:00
fcdb506b78
Bug 857439 Part 3: Make sure to delete owned interfaces if wrapping fails r=bz
2013-04-19 04:49:21 -04:00
70c70c7290
Bug 857439 Part 2: Cleanup example codegen a bit r=bz
2013-04-19 04:49:21 -04:00
4352afa5a1
Bug 857439 Part 1: Disallow owned interfaces from having parents or children r=bz
2013-04-19 04:49:21 -04:00
935d63e47c
Bug 857439 Part 0: Allow creators to return raw pointers for owned objects r=bz
2013-04-19 04:49:20 -04:00
e086f4c1c6
Bug 863094 - Infinity/-Infinity/NaN defaults for unrestricted types, r=bz
...
--HG--
extra : rebase_source : c2495008be9b084656222e6a0773c72d5224e9cc
2013-04-18 19:58:01 +03:00
5508e4bd90
Bug 862610. When we have named constructors, make sure we managed to set up an interface object before looking for them. r=peterv
2013-04-18 01:21:46 -04:00
238dddc9f6
Bug 862991 - If dictionary member needs cx, so should dictionary itself, r=bz
...
--HG--
extra : rebase_source : a495d79df021e896d3b7695a7d11da8d52559c28
2013-04-17 23:40:54 +03:00
763718651b
Bug 858677 - Fix up code not built by SpiderMonkey to use the newly-changed deletion signatures. r=bholley, r=billm
2013-04-05 21:22:55 -07:00
b261dcddc5
Bug 861064. Root WebIDL dictionary Init. r=smaug,terrence
2013-04-12 23:34:22 -04:00
7fe9a1d13e
Bug 861032 - Fix -Wreinterpret-base-class warning on Codegen.py. r=bz
...
--HG--
extra : rebase_source : c05d51d8aeed182b85333a347f0b1dfb5d6b1ef9
2013-04-11 19:29:50 -07:00
a38774d086
Bug 854503 - Rename JS unwrapping functions. r=bholley
2013-04-11 11:50:18 -07:00
a364a66c5b
Bug 860551. Fix instanceof for prototype-less interface objects to be saner. r=dzbarsky
2013-04-11 14:31:06 -04:00
4351dd0aa6
Bug 860473 part 2. Root WebIDL dictionary ToObject. r=evilpie,smaug
2013-04-11 14:31:06 -04:00
3987fa669a
Bug 860473 part 1. Root WebIDL dictionary ParseJSON. r=evilpie, smaug
2013-04-11 14:31:05 -04:00
19bcd12b01
Bug 857417. Trigger a fatal assertion when wrapping a wrappercached and nsISupports WebIDL object which has the wrapper cache before the nsISupports in its object layout. r=khuey
2013-04-08 17:04:21 -04:00
dd2b8fecee
Backed out changeset d0d75e76d41f (bug 857417) for crashes during tests
2013-04-08 18:48:38 -04:00
147a9ec190
Bug 857417. Trigger a fatal assertion when wrapping a wrappercached and nsISupports WebIDL object which has the wrapper cache before the nsISupports in its object layout. r=khuey
2013-04-08 17:04:21 -04:00
0fb62d62f7
Bug 688691. Warn when LenientThis actually causes us to not throw. r=ms2ger
2013-04-08 17:04:21 -04:00
4df26dd5ac
Backed out changeset a85d21e394c0 (bug 854503) for bustage.
2013-04-06 14:37:33 -04:00
ab74228011
Bug 854503 - Rename JS unwrapping functions. r=bholley
2013-04-04 12:14:32 +02:00
2a3d90721f
Bug 857254 - add CGTemplatedType and use it everywhere; r=bz
2013-04-02 15:29:03 -04:00
5db1cc6540
Bug 857254 - use CGIfWrapper more consistently; r=bz
2013-04-02 15:09:16 -04:00
33622efb8b
Bug 856819 part 2. Sort js-implemented interfaces in a given file so that the declarations in C++ come in the right order. r=mccr8
2013-04-03 22:22:16 -04:00
7879480d35
Bug 856819 part 1. Refactor the dependency-sorting we do for dictionaries so that we can also use it for JS-implemented interfaces. r=mccr8
2013-04-03 22:22:16 -04:00
b6f5bb741b
Bug 856841. Don't pass in an implicit JSContext based on argument or return value types for JS-implemented interfaces. r=mccr8
2013-04-03 22:22:16 -04:00
48d68f9676
Bug 852219 part 6. Handle cases when the C++ class we want to actually inherit from is not the one that the WebIDL interface is mapped to. r=mccr8
2013-04-03 22:22:16 -04:00
94f45fb924
Bug 852219 part 4. Fix forward-declarations and includes for JS-implemented interfaces. r=mccr8
2013-04-03 22:22:15 -04:00
793e37ca3f
Bug 852219 part 3. Handle JS-implemented interfaces having a parent interface. r=mccr8
2013-04-03 22:22:15 -04:00
d21bd00b48
Bug 852219 part 2. Add an infallible constructor for CallbackObjects which are already in the right compartment and use this to simplify construction of the autogenerated implementation of a JS-implemented WebIDL binding. r=mccr8
2013-04-03 22:22:15 -04:00
38246c449e
Bug 852219 part 1. Don't mark JS-implemented interfaces with descendant interfaces as final. r=khuey,mccr8
2013-04-03 22:22:15 -04:00
142568ca7e
Bug 854532. Make _asInstance codegen always produce code in the same order. r=khuey
...
Also fixes whitespace in _hasInstance and makes sure the .pp files are always in the same order
2013-04-03 22:22:14 -04:00
203cd29378
Bug 855582 part 2. Make the bindings' various spec arrays const, and make the jitinfo structs static. r=khuey
2013-04-02 20:20:38 -04:00
60943bc7bb
Bug 856215. Fix conversion of sequences of sequences to JS to not screw up its indexing. r=khuey
2013-04-02 20:20:38 -04:00
f9be62fa75
Bug 841429. Fix callback codegen for optional arguments with default values. r=mccr8
...
The change to enum wrapping is just to fix an indentation bug I ran into while reading the generated code for some of these test methods.
2013-04-01 17:17:17 -04:00
6020a94656
Bug 855025. Always do Xrays for DOM interface objects. r=peterv
2013-03-27 22:47:25 -04:00
57ca2ed5ab
Bug 851162. Make the auto-generated WrapObject in JS-implemented WebIDL codegen MOZ_OVERRIDE. r=mccr8
2013-03-26 11:31:54 -04:00
a7eafe32dc
Bug 841059 - Do not use the ArenaHeader for getAllocKind on JSObject; r=billm
2013-02-14 14:51:07 -08:00
a1663a0e87
Bug 828462 - Root Proxy/Wrapper in the browser. r=terrence,bz
2013-03-21 23:23:48 +01:00
787f786f96
Bug 828462 - Root Proxy/Wrapper delete. r=terrence
2013-03-21 23:23:48 +01:00
b6725433ce
Bug 828462 - Root Proxy/Wrapper getOwnPropertyNames and keys. r=terrence
2013-03-21 23:23:47 +01:00
aaa3687e9b
Bug 828462 - Root Proxy/Wrapper defineProperty. r=terrence
2013-03-21 23:23:47 +01:00
950e87f7e8
Bug 828462 - Root Proxy/Wrapper get(Own)PropertyDescriptor. r=terrence
2013-03-21 23:23:47 +01:00
455f0cd757
[Bug 852843] SVGZoomAndPan interface object not being instantiated r=bz
2013-03-21 01:33:56 -04:00
9ece62c4ba
Bug 852350 - Support [Pref] decorator on interfaces. r=bz
...
Generate a check calling Preferences::GetBool() directly
from the binding's PrefEnabled so the wrapped class doesn't
need to implement it.
This allows defining the preference directly in webidl.
Assumes only one preference value is set. Also removes pointless
override methods which just call the superclass.
---
dom/bindings/Codegen.py | 37 +++++++++++++++++++++++++------------
1 file changed, 25 insertions(+), 12 deletions(-)
Generate a check calling Preferences::GetBool() directly
from the binding's PrefEnabled so the wrapped class doesn't
need to implement it.
This allows defining the preference directly in webidl.
Assumes only one preference value is set. Also removes pointless
override methods which just call the superclass.
---
dom/bindings/Codegen.py | 37 +++++++++++++++++++++++++------------
1 file changed, 25 insertions(+), 12 deletions(-)
2013-03-20 11:18:00 -07:00
a804a3767b
Bug 848386 part 1. Don't preserve our wrapper until we have one so unforgeable property setup won't try to preserve it. r=peterv
2013-03-20 12:22:26 -04:00
d0b977f25f
Bug 851584. Don't generate a Length() on our C++ example class to handle our indexed getter if we already have a 'length' attribute in the WebIDL. r=jst
2013-03-19 21:47:47 -04:00
4de0c7f60e
Merge m-c to inbound.
2013-03-19 18:01:10 -04:00
9843ac8fc6
Fix for bug 850847 (Fix dictionary in generated example for workers). r=bz.
...
--HG--
extra : rebase_source : 75117320f23b5af82eb0ee7648c3e0dd876fe19e
2012-12-17 15:32:10 +01:00
5db19d4269
Bug 812617 - Provide a JSBindingFinalized hook for the native classes using Web IDL bindings to know when their JS wrapper has been finalized; r=bzbarsky
...
--HG--
extra : rebase_source : bb5059a170f3c2f4aa977190fceea421b41b5e58
2013-03-17 21:47:12 -04:00
d4058ab34c
Bug 850958 - Implement instanceof without relying on nsIDOM interfaces r=bz
2013-03-18 19:14:39 -04:00
b605a583db
Bug 827486, part 6 - generate headers and code for JS implemented WebIDL classes. r=bz
2013-03-18 16:05:51 -07:00
45987003c3
Bug 827486, part 5: add the main JS impl code gen. r=bz
2013-03-18 16:05:38 -07:00
931c15530b
Bug 827486, part 4: copy parts of example generator to JS impl generator. r=bz
2013-03-18 16:05:23 -07:00
585f8be54d
Bug 827486, part 3 - add dependencies for CGBindingImplClass. r=bz
2013-03-18 16:05:06 -07:00
80a04eadae
Bug 827486, part 2 - Refactor example class codegen into common base class. r=bz
2013-03-18 16:04:46 -07:00
5a7ceaeb53
Back out Bug 827486 for PGO bustage. CLOSED TREE
2013-03-18 13:00:00 -07:00
b6112c1005
Bug 827486, part 6 - generate headers and code for JS implemented WebIDL classes. r=bz
2013-03-18 10:19:42 -07:00
f84f3b2688
Bug 827486, part 5: add the main JS impl code gen. r=bz
2013-03-18 10:19:42 -07:00
d93d2f6cc8
Bug 827486, part 4: copy parts of example generator to JS impl generator. r=bz
2013-03-18 10:19:41 -07:00
a810b1c341
Bug 827486, part 3 - add dependencies for CGBindingImplClass. r=bz
2013-03-18 10:19:41 -07:00
d97d8b5610
Bug 827486, part 2 - Refactor example class codegen into common base class. r=bz
2013-03-18 10:19:41 -07:00
8d356d6b0e
Back out 2ea5f267af77:218356c595fc (bug 827486) for Windows builds dying with an obscure "MemoryError"
...
CLOSED TREE
2013-03-17 16:40:54 -07:00
046b780f2e
Bug 827486, part 6 - generate headers and code for JS implemented WebIDL classes. r=bz
2013-03-17 09:56:13 -07:00
182c832b0b
Bug 827486, part 5: add the main JS impl code gen. r=bz
2013-03-17 09:56:05 -07:00
3fcbfc94da
Bug 827486, part 4: copy parts of example generator to JS impl generator. r=bz
2013-03-17 09:55:55 -07:00
0e5992d000
Bug 827486, part 3 - add dependencies for CGBindingImplClass. r=bz
2013-03-17 09:55:42 -07:00
3193b58d5e
Bug 827486, part 2 - Refactor example class codegen into common base class. r=bz
2013-03-17 09:55:29 -07:00
e9aaf10590
Back out f408dd29944c:db5c280d1907 (bug 827486) for probably having needed a clobber
...
CLOSED TREE
2013-03-16 18:16:37 -07:00
4ed2fd027f
Bug 827486, part 6 - generate headers and code for JS implemented WebIDL classes. r=bz
2013-03-16 16:22:23 -07:00
0c7cb96db4
Bug 827486, part 5: add the main JS impl code gen. r=bz
2013-03-16 16:22:22 -07:00
f4a6a8f0f7
Bug 827486, part 4: copy parts of example generator to JS impl generator. r=bz
2013-03-16 16:22:22 -07:00
8ae5c0b2fe
Bug 827486, part 3 - add dependencies for CGBindingImplClass. r=bz
2013-03-16 16:22:22 -07:00
cb69938131
Bug 827486, part 2 - Refactor example class codegen into common base class. r=bz
2013-03-16 16:22:22 -07:00
4d57b7da94
Bug 849307. When generating code for a WebIDL dictionary with interface members, include the relevant headers for those interfaces in the binding header file, not just the binding implementation file. r=peterv
...
An alternative would be using out-of-line constructors and destructors for such dictionaries.
2013-03-14 15:42:59 -04:00
2eed062df0
Bug 842201 - SVGUnitTypes interface object is not being instantiated r=bz
2013-03-13 14:07:49 -04:00
23ba391ec1
Bug 848339 - Remove the vestigial boolean outparam from nsWrapperCache::WrapObject. r=bz
2013-03-12 08:03:47 +09:00
a0a3f88913
Bug 848395 - GC: Move Rooted to JS namespace - rename js::Rooted to JS::Rooted outside SpiderMonkey r=terrence
...
--HG--
extra : rebase_source : 35cbf3cc4da4598c2e9e6975028ef397718849db
2013-03-06 16:41:43 +00:00
3a53c22824
Backed out changeset 28ef4bdff455 (bug 848395)
2013-03-07 13:03:35 +00:00
57f723252d
Bug 841801 - Allow proxies to be finalized in the background r=billm
...
--HG--
extra : rebase_source : 48da96daddf75f505bf90c8e2ce2cdd6daf04cc5
2013-02-21 10:19:17 +00:00
6a98a4532a
Bug 848395 - GC: Move Rooted to JS namespace - rename js::Rooted to JS::Rooted outside SpiderMonkey r=terrence
...
--HG--
extra : rebase_source : 866879df05e3ec3f8e93570eb3f6b71103636b41
2013-03-06 16:41:43 +00:00
0b2426e59c
Bug 841289 - Remove prefable option from WebIDL codegen. r=bz
2013-03-06 07:09:38 +09:00
5fa6e7d0ec
Bug 827158 part 9. Implement support for having a NewResolve hook in WebIDL. r=peterv
2013-03-04 14:08:24 -05:00
ed13d9dc98
Bug 827158 part 8. Implement legacycaller support in WebIDL. r=peterv
2013-03-04 14:08:24 -05:00
703f4bdd82
Fixing bug 852435. Make the bindings example generator use the native type name. r=bz
2013-03-16 01:39:56 -07:00
368d40c518
Bug 846955 - Codegen Argument definitions using .define() in ClassDestructor::define. r=bz
2013-03-01 16:32:24 -08:00
6149d2c515
Bug 845666. Add support for sequences containing other sequences (or dictionaries containing sequences) to WebIDL. r=peterv
...
This keeps simple sequence arguments and variadics using an auto array, while everything else uses a non-auto array.
2013-03-02 01:07:43 -05:00
025766cbf0
Fix for bug 842799 (|Document.prototype instanceof Node| inside <script> returns false). r=bz.
2013-02-22 10:25:24 +01:00
3988338337
Bug 843261. Add support for sequence<DOMString> arguments in WebIDL callbacks. r=peterv
...
This does allow people to accidentally hit the slower path through use
of non-const strings, but I think that's OK now that we're mostly
autogenerating this stuff
2013-02-28 12:56:41 -05:00
c952e87e03
Backed out 7 changesets (bug 832920, bug 776536, bug 843261) for mochitest-a11y assertions on a CLOSED TREE.
...
--HG--
rename : content/base/src/NodeIterator.cpp => content/base/src/nsNodeIterator.cpp
rename : content/base/src/NodeIterator.h => content/base/src/nsNodeIterator.h
rename : content/base/src/TreeWalker.cpp => content/base/src/nsTreeWalker.cpp
rename : content/base/src/TreeWalker.h => content/base/src/nsTreeWalker.h
2013-02-28 14:41:30 -05:00
1e89bd52ab
Bug 843261. Add support for sequence<DOMString> arguments in WebIDL callbacks. r=peterv
...
This does allow people to accidentally hit the slower path through use
of non-const strings, but I think that's OK now that we're mostly
autogenerating this stuff
2013-02-28 12:56:41 -05:00
0bc630a626
Bug 838686 part 2. Use NodeFilterHolder in treewalker and nodeiterator and start using WebIDL codegen for NodeFilter. r=peterv
2013-02-26 15:10:15 -05:00
da7352fc49
Back out changeset 1c851a5bbc9f (bug 838686) because it depends on a changeset gcc doesn't like
2013-02-26 15:34:25 -05:00
247b3cc18a
Bug 838686 part 2. Use NodeFilterHolder in treewalker and nodeiterator and start using WebIDL codegen for NodeFilter. r=peterv
2013-02-26 15:10:15 -05:00
07afde82fb
Fix for bug 844559 (Crash [@ mozilla::dom::XrayResolveNativeProperty]). r=bz.
...
--HG--
extra : rebase_source : 85b3d0ee270f24847b9425cda9f8b56a494f2546
2013-02-25 20:39:15 +01:00
2c8d7046c5
Bug 784812: Implement real dependencies for WebIDL bindings. r=bz,ted
2013-02-24 12:36:44 -08:00
cd3ba96b65
Back out cd8481cc4a32 (bug 784812) for make check failures
2013-02-24 14:10:48 -08:00
63884b088c
Bug 784812: Implement real dependencies for WebIDL bindings. r=bz,ted CLOSED TREE
2013-02-24 12:36:44 -08:00
41104cbff1
Backed out changeset a71766c2c85d
2013-02-24 12:33:36 -08:00
75d88ff353
Bug 784812: Implement real dependencies for WebIDL bindings. r=bz,ted
2013-02-24 12:03:03 -08:00
beb08b6c9d
Bug 842561. Assert that our inheritance chain is correct for WebIDL objects. r=peterv
...
We could drop the descriptor for Text if we changed nsIDocument::CreateTextNode
to return an already_AddRefed<Text>, but then we'd need more casting in
nsDocument.cpp for the XPCOM CreateTextNode. Not sure which way is better,
really.
2013-02-22 09:56:29 -05:00
b30facb288
Backed out 6 changesets (bug 832920, bug 825341, bug 838582, bug 842726, bug 629801, bug 842561) for Linux32 debug mochitest-2 and Windows/OSX mochitest-browser-chrome failures on a CLOSED TREE.
2013-02-22 15:30:06 -05:00
725363bffa
Bug 842561. Assert that our inheritance chain is correct for WebIDL objects. r=peterv
...
We could drop the descriptor for Text if we changed nsIDocument::CreateTextNode
to return an already_AddRefed<Text>, but then we'd need more casting in
nsDocument.cpp for the XPCOM CreateTextNode. Not sure which way is better,
really.
2013-02-22 09:56:29 -05:00
b17c86c836
Fix for bug 825628 (Implement NamedConstructor) - add codegen support for NamedConstructor. r=bz.
...
--HG--
extra : rebase_source : 8393995dca6f65cb49512874c1916ee745436638
2013-01-22 11:51:15 +01:00
e55647f4f1
Bug 838691 part 3. Switch touch event handler attributes to using a function to check whether they're enabled. r=peterv
2013-02-19 11:54:41 -05:00
75ae65a1d1
Bug 838691 part 2. Add codegen support for calling a function to determine whether a property should be exposed in a WebIDL binding. r=peterv
2013-02-19 11:54:40 -05:00
e6e9097009
Bug 838691 part 1. Add support in Prefable for calling a function to determine whether a property should be exposed in a WebIDL binding. r=peterv
2013-02-19 11:54:40 -05:00
0ae0788482
Bug 839088 part 3. Add a way for callers of callback methods to ask for any exceptions from the callback to be rethrown on the ErrorResult. r=peterv
2013-02-19 11:54:40 -05:00
624e0560d5
Bug 839088 part 2. Add way to indicate to a CallSetup that it should propagate any exceptions thrown during the call out to the ErrorResult for the call. r=peterv
2013-02-19 11:54:40 -05:00
ea45d30665
Bug 839088 part 1. Add a way to throw a JS::Value on an ErrorResult. r=peterv
2013-02-19 11:54:40 -05:00
83a7dcbda5
Bug 841404. Make sure that we treat dictionaries inside sequence and array members of a dictionary as dependencies for it. r=peterv
2013-02-17 11:22:11 -05:00
6ac60724ce
Fix for bug 838269 (Support cross-global |... instanceof DOMInterface|). r=bz.
...
--HG--
extra : rebase_source : e5ad1d7da8029394e3ecb38909eca406a675dbe9
2013-01-08 19:05:36 +01:00
2c2153865c
Bug 836850. Allow a single C++ class to implement multiple WebIDL interfaces. r=peterv
...
--HG--
rename : content/html/content/test/test_li_attributes_reflection.html => content/html/content/test/test_dl_attributes_reflection.html
rename : content/html/content/test/test_li_attributes_reflection.html => content/html/content/test/test_ul_attributes_reflection.html
2013-02-08 12:20:11 +00:00
ce4e224f4b
Fix for bug 838228 (toString on an Xray for an interface object should stringify like Function.prototype.toString). r=bz.
...
--HG--
rename : content/html/content/test/test_map_attributes_reflection.html => content/html/content/test/test_ol_attributes_reflection.html
extra : rebase_source : 9bd7efb927e4eac96569ed629ee230dbf555fb63
2013-02-01 15:33:58 +01:00
c68a618b49
Bug 837645. Support 'any' values in sequences and dictionaries. r=smaug,peterv
2013-02-06 14:23:45 +00:00
82c6f6b490
Bug 830992 part 2. Switch DOMTransaction to WebIDL codegen. r=wchen,peterv
2013-02-06 09:42:33 +00:00
67fcb56293
Bug 832788. Part 5: Add suffixes for large integer literals. r=bz
...
--HG--
extra : rebase_source : 9555960acea609a3e4a3deaacd468e64435f5ff2
2013-01-30 18:20:53 +13:00
afda50b640
Bug 835417 part 2. Implement WebIDL parser and codegen support for marking things pure. r=peterv
2013-01-29 17:53:53 -05:00
c2a3b9aca3
Bug 834877 part 2. Start using DOMString as the return value for strings. r=peterv
2013-01-29 09:42:14 -05:00
fe29b143cd
Bug 829252 part 3. When wrapping things with an nsISupports in XPCWrappedJS for WebIDL callback interfaces, use the aggregated version. r=peterv
2013-01-29 08:44:01 -05:00
c6638a677b
Bug 830099. Flag WebIDL dictionaries and callbacks with some information indicating whether we need main-thread and worker codegen for them and then use that information to skip unneccessary codegen. r=peterv
2013-01-28 23:30:17 -05:00
426c47cdf0
Back out c5238879470f and b3cabb259af7 (bug 830099) for bustage
2013-01-28 22:36:59 -08:00
719c7bf030
Bug 830099. Flag WebIDL dictionaries and callbacks with some information indicating whether we need main-thread and worker codegen for them and then use that information to skip unneccessary codegen. r=peterv
2013-01-28 23:30:17 -05:00
8ccc3897f4
Bug 795896. Speed up UnwrapProxy, since we know what we have there is either an Xray or our proxy. r=peterv
2013-01-28 23:29:25 -05:00
6146dcbc98
Backed out changeset 19b9f064d8eb (bug 795896) because of build bustage
2013-01-28 23:51:11 -05:00
728d7beaad
Backed out changeset 32786d29daf8 (bug 830099) because of build bustage
2013-01-28 23:51:03 -05:00
f5b233966e
Bug 830099. Flag WebIDL dictionaries and callbacks with some information indicating whether we need main-thread and worker codegen for them and then use that information to skip unneccessary codegen. r=peterv
2013-01-28 23:30:17 -05:00
22e57505d0
Bug 795896. Speed up UnwrapProxy, since we know what we have there is either an Xray or our proxy. r=peterv
2013-01-28 23:29:25 -05:00
c553f8a73e
Fix for bug 816088 (webIDL bindings try to extract nsISupports from the global object in static properties in workers). r=bz.
...
--HG--
extra : rebase_source : 5668d9e01bff0fe7831d98018428856e5940a620
2012-12-03 17:07:49 +01:00
2234eada00
Bug 822470 part 7. Use new callback codegen for conversion to and from JS. r=peterv
...
NodeFilter, EventListener, and DOMTransaction will be updated to use the new codegen once we've fixed the consumers.
2013-01-28 08:34:31 -05:00
a836dfc369
Bug 822470 part 6. Hook up callback interface codegen. r=peterv
2013-01-28 08:34:30 -05:00
a6ee53ef28
Bug 822470 part 5. Refactor callback codegen so it can be reused for callback interfaces too. r=peterv
2013-01-28 08:34:30 -05:00
c4cfde47b5
Bug 822470 part 3. Include headers as needed for callback interfaces. r=peterv
2013-01-28 08:34:30 -05:00
4d02c18a08
Bug 822470 part 1. Factor out the code that callback functions and callback interfaces will be able to share into a CallbackObject class. r=peterv
...
--HG--
rename : dom/bindings/CallbackFunction.cpp => dom/bindings/CallbackObject.cpp
rename : dom/bindings/CallbackFunction.h => dom/bindings/CallbackObject.h
2013-01-28 08:34:29 -05:00
9474e07ea6
Backout f3c145bd1dd2 & 5075690572a9 for OS X startup failures
2013-01-28 11:08:21 +00:00
6b094e2955
Fix for bug 816088 (webIDL bindings try to extract nsISupports from the global object in static properties in workers). r=bz.
...
--HG--
extra : rebase_source : 68e5630591f6209e2af9c5cd2321fed8edd3de24
2012-12-03 17:07:49 +01:00
9effec722d
Bug 828753 - jsid rooting, mostly in jsinfer.*. Also switch JSObject from struct to class. r=terrence
2012-12-31 12:40:21 -08:00
d8da3e7b9a
Backed out changeset fce4e0f8a553 (bug 828753) for breaking windows warnings-as-errors (stop adding JSObject forward decls, please!)
2013-01-18 13:20:21 -08:00
0dee2fb42d
Bug 828753 - jsid rooting, mostly in jsinfer.*. Also switch JSObject from struct to class. r=terrence
...
--HG--
extra : rebase_source : c8806b27677594925ad0e6b54c47af5cf17e1153
2012-12-31 12:40:21 -08:00
e1197ccff3
Bug 830614. Wrapping a wrappercached WebIDL object should watch out for reentry via WrapNativeParent. r=peterv
2013-01-15 14:04:24 -05:00
b7ae90666d
Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan
2013-01-15 13:22:03 +01:00
9eeab1abce
Bug 828000 - Don't generate the `isNull' local variable if it's not needed; r=bzbarsky
2013-01-08 16:29:52 -05:00
a127013839
Bug 826447 - Change all the proxy API signatures to take unsigned flags, rather than bool set, so that it's easier to find all tests of JSRESOLVE_ASSIGNING. r=bz
...
--HG--
extra : rebase_source : 3b88b411965087984d7973a90f8fa1b06457a6ce
2013-01-03 15:31:36 -06:00
8bd1686555
Bug 824823 part 7. Implement WebIDL CharacterData API on nsGenericDOMDataNode. r=peterv
2013-01-04 12:02:14 -05:00
4d733dc0e1
Bug 820665 part 3. WebIDL spec updates to changes in how callback interfaces work. r=khuey
...
Specifically, any object that's not a Date or RegExp can implement a callback interface.
2013-01-03 14:03:11 -05:00
248f730e6a
Bug 820665 part 2. WebIDL spec updates to changes in how callback functions work. r=khuey
...
Specifically, all callables can be converted to a callback, including
in overload resolution and union conversions. We already did this for
normal callback arguments, but not the overload/union case.
2013-01-03 14:03:06 -05:00
20d4a061d6
Bug 820665 part 1. More WebIDL spec updates to changes in how dictionaries work. r=khuey
...
Specifically, the following changes:
1) A union that includes a dictionary and is the last non-optional
argument must actually be marked optional, just like a dictionary
argument.
2) Disallow a union from containing both a nullable type and a dictionary.
3) Now all non-Date and non-RegExp objects can be used as dictionaries,
including from overload resolution and union conversion.
We don't support dictionaries inside unions yet, or unions as
distinguishing args, so the spec changes to do with converting null to
dictionaries inside a union or picking the union overload if there is
a union containing a dictionary and null is the distinguishing arg
value are not relevant to us so far.
2013-01-03 14:03:00 -05:00
1c97d54111
Bug 818050. Teach the JIT about DOM method and getter return types so that it doesn't have to type-guard when unboxing the boxed value in many cases. r=jandem,peterv
2013-01-03 14:02:52 -05:00
7edf1854ef
Bug 821177. [TreatNonCallableAsNull] should only affect attribute setters. r=khuey
2013-01-02 22:03:25 -05:00
eabd327329
Bug 819845. Update WebIDL bindings to spec change: sequences/arrays are no longer distinguishable from dictionaries, and conversion to a sequence works on arbitrary objects. r=khuey
2013-01-02 22:03:25 -05:00
b27f3c82dc
Bug 824247 - Part 2: Fix common source of warning span (dom/bindings). r=khuey
2013-01-03 00:55:55 +09:00
4bebfa7b67
Bug 824824. Add support for passing multiple touches as arguments to createTouchList. r=mbrubeck,peterv
2012-12-31 10:37:22 -08:00
6378ed05fd
Bug 825025. MaybeWrapValue should work with all gcthings. r=peterv
2012-12-29 22:13:26 -08:00
c4fadd1981
Bug 823283 - Remove all remaining uses of JSRESOLVE_QUALIFIED, and the few remaining tests (which were pretty much purely diagnostic). r=luke
...
--HG--
extra : rebase_source : 51e2ac7ccc76be84d12600baeb6d458c2927bea7
2012-09-15 11:19:55 -07:00
a3b4bd9774
Bug 816421. Make Document.visibilityState a WebIDL enum. r=peterv
...
A lot of the changes here are just so I can actually build after including DocumentBinding.h in nsIDocument.h
2012-12-25 14:00:15 -08:00
8dd150af35
Merge PGO-green changeset from inbound to m-c.
2012-12-22 12:06:37 +01:00
1e109fdaab
Bug 823088 - Add a static assertion that bindings with descriptor.nativeOwnership == 'nsisupports' inherit from nsISupports; r=bz
2012-12-22 09:18:11 +01:00
f11ed9361b
Bug 793151 - Change the length property of a WebIDL method to the mimimum number of arguments, instead of the maximum; r=bz
2012-12-22 09:04:17 +01:00
893e85fa56
Fix for bug 820577 (Support reparenting for new DOM binding objects). r=bholley/bz.
...
--HG--
extra : rebase_source : 66dad56b8f543790ffa7e595ccd684c4673403df
2012-09-26 16:17:46 +02:00
fd8f198826
Bug 822350 - Make generated bindings include mozilla/FloatingPoint.h directly if they use it. r=bz
...
--HG--
extra : rebase_source : 7271aea09f40dee8d418ddd17c8f43559262a0d2
2012-12-17 17:21:26 -05:00
a5b66f6cc6
Bug 820957 - Support object members in WebIDL dictionary. r=bz
2012-12-17 13:44:13 -08:00
c3b4bdb077
Bug 820544 - Prefix WebIDL dictionary native member names to avoid C++ keywords. r=bz
2012-12-17 13:44:04 -08:00
6f6a341ee2
Fix for bug 815149 (Add support for SOWs and XBL bindings in new DOM bindings). r=bz.
...
--HG--
extra : rebase_source : c24544fd3d1c99651e279e687a07a02c5b994323
2012-09-12 22:29:30 +02:00
0c1ffdfca7
Bug 821760. Properly handle compartments in WebIDL static operation bindings. r=peterv
2012-12-14 14:11:23 -05:00
916ce462a6
Bug 819904. Throw from WebIDL setters called with no arguments, per spec change. r=peterv
2012-12-14 14:10:49 -05:00
a1a7cade04
Bug 816375. Switch NodeFilter to WebIDL bindings. r=peterv
2012-12-14 14:10:49 -05:00
fbf6fab8e8
Backout 67d84be0cc83 (bug 820544) for bustage
2012-12-14 16:58:51 +00:00
45b4ea581a
Bug 820544 - Prefix webidl dictionary native members names to avoid C++ keywords. r=bz
2012-12-11 16:05:46 -08:00
aad442ab75
Bug 820862. JSJitInfo should say what sort of function it is. r=jandem
2012-12-13 17:08:43 -05:00
548f77a633
Bug 821317 - reduce the size of DOMClass.mInterfaceChain to something reasonable; r=bz
2012-12-13 11:01:00 -05:00
a25af0c2e0
Bug 821324 - actually return a success value from replaceFileIfChanged; r=bz
2012-12-13 11:26:33 -05:00
d4de9b2c67
Bug 815502. Implement support for variadic arguments in WebIDL. r=peterv
2012-12-11 17:50:56 -05:00
ea0c0a9788
Fix for bug 818219 (Replace HTMLElement quickstubs with new binding methods). r=bz.
...
--HG--
rename : layout/reftests/backgrounds/background-referrer-ref.html => image/test/reftest/generic/accept-image-catchall-ref.html
rename : layout/reftests/backgrounds/background-referrer.html => image/test/reftest/generic/accept-image-catchall.html
rename : layout/reftests/backgrounds/background-referrer.sjs => image/test/reftest/generic/check-header.sjs
rename : layout/reftests/backgrounds/background-referrer-image.png => image/test/reftest/generic/green.png
rename : toolkit/components/places/tests/browser/browser_favicon_setAndFetchFaviconForPage.js => toolkit/components/places/tests/favicons/test_setAndFetchFaviconForPage.js
extra : rebase_source : 45715d6abe3155a6bcd1d21e5cc3f7b048180eb6
2012-11-26 15:19:02 +01:00
f490c53f7d
Bug 815803. Now that JSSLOT_PROXY_PRIVATE == 0, simplify binding code that had to deal with different slot indices on proxy and non-proxy objects. r=peterv
2012-12-06 15:21:19 -05:00
90caf3e264
Bug 816376. Create vanilla objects for the interface object of callback interfaces. r=peterv
2012-12-06 15:21:18 -05:00
e484d3351f
Fix for bug 818219 (Replace HTMLElement quickstubs with new binding methods) - Add a constructor to callbacks to allow conversion between callback types. r=bz.
...
--HG--
extra : rebase_source : 6c55316f374ef1654f0b77b782500fc52a78881a
2012-12-06 11:41:14 +01:00
5d8ad95b2d
Fix for bug 818219 (Replace HTMLElement quickstubs with new binding methods) - Remove hardcoded interface list in workers. r=bz.
...
--HG--
extra : rebase_source : 87b106b79f8e5912f10a603e407da1c93be4ed5d
2012-12-06 11:41:14 +01:00
aeb1d53352
Fix for bug 818219 (Replace HTMLElement quickstubs with new binding methods) - Support castable types in unions. r=bz.
...
--HG--
extra : rebase_source : 633d2b350be0cf11ac0bb010a0ad427b10863ef4
2012-12-06 11:41:14 +01:00
8a1132df5e
Bug 816160. Don't require 'castable':False for prefable bindings with hasXPConnectImpls, and don't require hasXPConnectImpls bindings to be prefable. r=peterv
2012-12-03 11:46:03 -05:00
910e6a92cd
Merge m-c to m-i.
2012-12-02 11:32:57 +01:00
90dc2a2c97
Bug 802163 - Fix pyflakes warnings in bindings python; r=peterv
2012-12-02 09:59:08 +01:00
ede8ebce3e
Bug 816487 - Allow all ASCII characters for WebIDL enum. r=bz
2012-12-01 21:23:26 -05:00
b7633de200
Bug 816187 - make WebIDL accept nullable dictionary retvals; let getContextAttributes's retval be nullable - r=bz
2012-11-30 18:30:05 -05:00
5eab6d42fb
Bug 812783. Add support for flagging callbacks as worker-only. r=khuey
2012-11-29 11:14:40 -05:00
c4df170bbd
Bug 747289 - Part 1/2 - Update Paris bindings to expose DOM constants. r=bz
2012-11-28 16:28:36 -05:00
864866eb21
Fix up indentation of the generated code for event handler return values. No bug.
2012-11-28 02:33:50 -05:00
127a0152d5
Bug 767933 part 4. Make 'float' and 'double' types throw on non-finite values. r=khuey,ehsan,bas
2012-11-27 15:32:05 -05:00
4edad4b6bf
Bug 767933 part 2. Implement codegen for 'unrestricted float' and 'unrestricted double', as aliases for float and double for now. r=khuey
2012-11-27 15:32:05 -05:00
e248bf75cd
Bug 812742. Fix sequence codegen to not do AppendElement multiple times by accident. r=peterv
2012-11-27 15:20:40 -05:00
a8de827765
Bug 810641. Implement support for variadic callback arguments in WebIDL. r=peterv
2012-11-26 21:14:45 -05:00
9cfc646682
Bug 813623. Fix Xrays to actually work correctly for static methods and properties. r=peterv
2012-11-26 21:14:45 -05:00
dd5db5a970
Fix for bug 814022 (Make instanceof for new DOM bindings work across scopes). r=bz.
2012-11-19 11:59:13 +01:00
10928a1716
Bug 811057: Make DeferredFinalizeFunction take a uint32 instead of an int32 as its "slice" parameter. r=peterv
2012-11-21 10:20:32 -08:00
7c36e30523
Bug 800915 - Remove the cx parameter and simplify various APIs. r=sfink,bz
...
If callers want to throw, it's now their responsibility.
2012-11-14 09:56:26 -08:00
2f3202994d
Bug 810520. Correctly handle static methods and attributes in the NativeProperties structs that Xrays use. r=peterv
...
Note that at this point we actaully do Xrays for all of our various
property types, except in worker code. The real substantive change
here is the change to what usedForXrays returns. The rest is minor
cleanup.
2012-11-13 00:26:55 -08:00
5f0fd7aeda
Backed out de9fff3a523, c567df2244f5, 8e3d976d5dc5, and c7499faaec23 (bug 800915) for bustage.
...
--HG--
extra : rebase_source : c823063bfa31d59d32b3402bd4b458b84b703cd5
2012-11-12 21:43:39 -05:00
2e39ac86be
Bug 800915 - Remove the cx parameter and simplify various APIs. r=sfink,bz
...
If callers want to throw, it's now their responsibility.
2012-11-12 17:35:32 -08:00
1826aafc95
Bug 792090 - Ignore unused result in CGProxy...PresenceChecker. r=bz
2012-11-12 14:21:46 -08:00
dd34c2210e
Bug 809260. Example codegen should include ErrorResult.h in the header. r=mccr8
2012-11-09 08:24:32 -08:00
b1b218160a
Bug 808698. Set up example codegen for proxy bindings to work correctly. r=jst
2012-11-09 08:24:32 -08:00
8d6ac8d253
Bug 796983 followup to address peterv's comments. r=presumably-peterv
2012-11-09 08:24:32 -08:00
7ef67e09cd
Bug 807224 followup to address review comments. r=presumably-peterv
2012-11-09 08:24:31 -08:00
a6d1aea15e
Bug 807226 part 8. Remove the exceptions for EventHandler in WebIDL codegen. r=smaug
2012-11-09 08:00:25 -08:00
529460c9c6
Bug 807224. Implement native-to-JS conversion for WebIDL unions. r=peterv
2012-11-09 07:59:33 -08:00
969b8c6b33
Bug 779048 followup. Add a comment that explains why the assert about exceptionCode being default when invalidEnumValueFatal is false is an ok thing to assert. r=peterv, DONTBUILD
2012-11-09 07:58:33 -08:00
d8fee95886
Bug 779048 part 10. Start using the new callback codegen in argument and return value conversion. r=peterv,smaug
2012-11-09 07:43:58 -08:00
c2e7420950
Bug 779048 part 9. Give JS-to-native conversion an object pointer to work with so it can convert callback objects. r=peterv
2012-11-09 07:43:58 -08:00
272331140d
Bug 779048 part 8. Handling of arguments for callbacks. r=peterv
...
Note that we're now using the array object as the "obj" when wrapping
sequence members, because we don't have an 'obj' around in our
code... and every single existing sequence-of-interfaces consumer
relied on there being an 'obj' floating about.
Also note that I needed to rearrange the various wrapping helpers so
that we can wrap things that are hanging out in const smartpointers or
in const OwningNonNull or in plain object references.
2012-11-09 07:43:58 -08:00
a4a4a10299
Bug 779048 part 7. Make native-to-JS conversion support doing something other than "return false" on JS exceptions. r=peterv
2012-11-09 07:43:58 -08:00
1649f6c386
Bug 779048 part 6. Handling of return values for callbacks. r=peterv
2012-11-09 07:43:58 -08:00
4779ff59ef
Bug 779048 part 5. Make js-to-native conversion support doing something other than "return false" on JS exceptions. r=peterv
2012-11-09 07:43:58 -08:00
7752f218bb
Bug 779048 part 4. Implement basic codegen for callbacks, without handling of arguments or return values yet. r=peterv
2012-11-09 07:43:57 -08:00
a04350646a
Bug 779048 part 3. Refactor the code we use for generating example declarations a bit so we can reuse it for callbacks. r=peterv
2012-11-09 07:43:57 -08:00
c238a8e902
Bug 779048 part 2. Rearrange how we do our includes and forward-declares to actually work with callbacks and dictionaries sanely. r=peterv
2012-11-09 07:43:57 -08:00
f16bb7b8a1
Bug 808991. Named getters should get called for indexed properties on objects that don't support indexed properties. r=peterv
2012-11-08 23:48:42 -08:00
ab861f5738
Bug 792675. Part 1: Make the URL interface use WebIDL. r=bz
...
--HG--
extra : rebase_source : dbb7a3158b71446930400ad523a2896b6306de40
2012-09-25 15:24:43 +12:00
9a6a3bf063
Bug 792675. Part 0.6: Handle empty dictionary types in WebIDL bindings. r=bz
...
--HG--
extra : rebase_source : a38a2405d32b76bdef9095398c759346cfc28282
2012-11-07 17:56:55 -05:00
fbac0e8161
Bug 792765. Part 0.5: Fix WebIDL codegen to avoid emitting QueryInterface when there is no interface prototype object. r=bz
...
--HG--
extra : rebase_source : 7e1df198548d8a4f1b2f2a045f637412a5fe8450
2012-09-25 15:24:43 +12:00
84f0ae1e42
Bug 804738 part 2. Fix codegen for indexed operations to be consistent about the naming of the index argument. r=peterv
2012-11-06 08:01:49 -08:00
f7a97d85d7
Bug 804738 part 1. Fix codegen for named operations to be consistent about the naming of the string argument. r=peterv
2012-11-06 08:00:57 -08:00
f74ea18279
Bug 804635. Make codegen deal with Document not being an external interface but not available in workers even though XMLHttpRequest (which can return or accept Document) is available there. r=peterv
2012-11-05 11:58:04 -05:00
2f46bbb1cd
Bug 803519. Require indexed/named getters if we have creators/deleters/setters. r=peterv
2012-11-05 11:58:03 -05:00
750dec5380
Bug 772869. Make getOwnPropertyNames work correctly for WebIDL proxy bindings. r=peterv,ms2ger
2012-11-05 11:58:03 -05:00
8038e06ced
Bug 803306. Calling a named creator should not define an expando. r=peterv
2012-11-05 11:58:03 -05:00
b93a1ba901
Bug 788225. Implement WebIDL deleters. r=peterv
2012-11-05 11:58:02 -05:00
a5b199957d
Bug 749866 part 4. Generate slightly better code when we know we're null or undefined. r=khuey
2012-11-05 11:58:02 -05:00
5efe42ad3d
Bug 749866 part 3. Rejigger overload resolution a bit more so we can tell argument conversion that we know the argument is null or undefined. r=khuey
2012-11-05 11:58:02 -05:00
e3d33d83c4
Bug 749866 part 2. Simplify the code generated by overload resolution a bit when we have sequences or dates at our distinguishing index. r=khuey
2012-11-05 11:58:02 -05:00
677b9b7b1a
Bug 749866 part 1. Add support for failureCode for sequence unwrapping. r=khuey
2012-11-05 11:58:02 -05:00
4b7833d1f9
Bug 807034 - Fix WebIDL codegen for static readonly attributes. r=bz
2012-10-30 11:38:58 -07:00
661a8ea230
Bug 806184 - Can't use 'delete' method in WebIDL. r=bz
2012-10-31 13:36:20 +01:00
80ecd8538f
Fix for bug 763643 (Implement static operations and attributes for WebIDL). r=bz.
...
--HG--
extra : rebase_source : d9dd5450af5d2b1f3e7e3a738ec2efdc7f7053da
2012-10-19 09:34:28 +02:00
669602b5e0
Fix for bug 778152 (Content window does not have an XMLHttpRequest property when accessed via an Xray wrapper in a subscript). r=bz.
...
Switch from using the interface objects from the Xrays compartment to wrapping
interface objects and interface prototype objects in Xrays. Make dom binding
Xrays deal with both instance objects and interface and interface prototype
objects.
2012-10-09 20:50:27 +02:00
2412de3249
Fix for bug 785277 (Implement PutForwards in the new DOM bindings). r=bz.
...
--HG--
extra : rebase_source : 5153ebab17a9637946d0f0c322997c0c3d118190
2012-08-13 14:20:49 +02:00
2d58c35ce6
Fix for bug 778152 (Content window does not have an XMLHttpRequest property when accessed via an Xray wrapper in a subscript) - rename ProtoOrIfaceArray. r=bz.
...
--HG--
extra : rebase_source : c426270fc1ebee818629bd94dfc8d11af59bfc00
2012-10-09 20:50:27 +02:00
Boris Zbarsky
Andrew McCreight
Olli Pettay
Peter Van der Beken
David Zbarsky
Jeff Walden
Reuben Morais
Jacek Szpot
Ehsan Akhgari
Ryan VanderMeulen
Nathan Froyd
Terrence Cole
Tom Schuster
Ralph Giles
Kyle Huey
Phil Ringnalda
Masatoshi Kimura
Jon Coppeard
Ed Morley
Johnny Stenback
Robert O'Callahan
Steve Fink
Mats Palmgren
Ms2ger
William Chen
Benoit Jacob
Eric Faust
Daniel Holbert
Bobby Holley
Vendelin Ruzicka