b5d2263c26
Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig
...
Remove it and related functions, and update the callers.
Differential Revision: https://phabricator.services.mozilla.com/D226261
2024-10-22 09:38:16 +00:00
1e31a04af4
Bug 1882581: Implement `@scope` parsing. r=firefox-style-system-reviewers,saschanaz,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D203153
2024-03-19 13:36:48 +00:00
3db9556f81
Backed out 2 changesets (bug 1882581) for causing bustage on InspectorUtils.cpp. CLOSED TREE
...
Backed out changeset 9f390afd0df5 (bug 1882581)
Backed out changeset 4781bbc7324f (bug 1882581)
2024-03-19 05:38:08 +02:00
0ed15605fb
Bug 1882581: Implement `@scope` parsing. r=firefox-style-system-reviewers,saschanaz,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D203153
2024-03-18 18:31:18 +00:00
34cdfc4f86
Bug 1874226 - Use unique_ptr not Scoped in xpcom/*. r=xpcom-reviewers,necko-reviewers,valentin,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D200250
2024-02-07 18:30:22 +00:00
66d12d2fff
Backed out 2 changesets (bug 1874226) for causing bustages on dom/ContentParent.h. CLOSED TREE
...
Backed out changeset 3efd59369cd6 (bug 1874226)
Backed out changeset cd7b0bd12dae (bug 1874226)
2024-02-06 03:08:23 +02:00
c9e48e76b7
Bug 1874226 - Use unique_ptr not Scoped in xpcom/*. r=xpcom-reviewers,necko-reviewers,valentin,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D200250
2024-02-06 00:21:43 +00:00
4f71d79d17
Bug 1869606 - Improve StartupCache thread-safety annotations r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D196223
2023-12-12 22:08:46 +00:00
c54ac1d672
Bug 1846695 - Have a trivially move assignable and constructible StartupCacheEntry::KeyValuePair. r=xpcom-reviewers,emilio
...
Depends on D182731
Differential Revision: https://phabricator.services.mozilla.com/D185065
2023-12-12 08:44:40 +00:00
4c29c24344
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
1bd2e4bdf6
Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.5). r=aryx,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D189264
2023-09-29 11:38:53 +00:00
c458754592
Bug 1855134 - Move existing MOZ_TRY macros to a dedicated header file; r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D189226
2023-09-28 20:46:07 +00:00
a2f7e06013
Bug 1841660 - Fix potential deadlock waiting for StartupCache ThreadedPrefetch, r=jesup
...
In a previous change to this logic, we missed a hidden early return in
the `MMAP_FAULT_HANDLER_CATCH()` macro which can early return on both
Linux and Windows. If this is hit, we could end up blocking at various
points waiting for the StartupCache to be prefetched.
This patch changes the logic to notify to happen in a ScopeExit instead,
ensuring that it'll happen on all return paths.
In addition, there was another potential deadlock due to the
ThreadedPrefetch thread acquiring mTableLock. This was fixed by passing
in the pointers in the runnable instead. This should be OK as we are
making sure to block on ThreadedPrefetch before we clear the startup
data already.
Differential Revision: https://phabricator.services.mozilla.com/D182732
2023-07-04 19:05:06 +00:00
8219a5c503
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
50897e24f4
Bug 1724509: apply code formatting via Lando
...
# ignore-this-changeset
2023-05-17 20:06:03 +00:00
5061dadd5a
Bug 1724509: Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D122029
2023-05-17 20:03:19 +00:00
271058f7fc
Bug 1828265: Remove StartupCache temporary prefetch thread r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D175551
2023-04-22 13:58:06 +00:00
95f7a79d8e
Bug 1746447: StartupCache cleanup r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D138961
2023-04-22 13:58:05 +00:00
e6ba96df3d
Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D170124
2023-02-19 21:40:36 +00:00
d85572c196
Backed out 11 changesets (bug 1817309, bug 1817315, bug 1817313, bug 1817317, bug 1817310, bug 1817314, bug 1817308, bug 1817312, bug 1817311, bug 1817316, bug 1817318) for causing build bustages on nss_secutil.h CLOSED TREE
...
Backed out changeset 288b4848b023 (bug 1817308
2023-02-19 18:37:26 +02:00
137c5ce4e6
Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D170124
2023-02-19 15:33:55 +00:00
41e332d499
Backed out 11 changesets (bug 1817308, bug 1817311, bug 1817317, bug 1817310, bug 1817309, bug 1817314, bug 1817316, bug 1817318, bug 1817313, bug 1817312, bug 1817315) for causing hybrid bustage on WrapperFactory.cpp. CLOSED TREE
...
Backed out changeset 1fb2fdbeecec (bug 1817308
2023-02-18 01:58:57 +02:00
ca79bf4993
Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi
...
Depends on D170123
Differential Revision: https://phabricator.services.mozilla.com/D170124
2023-02-17 22:17:43 +00:00
e5c2ee72c8
Bug 1800050 - Use UniqueFreePtr in StartupCache::PutBuffer. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D163453
2022-12-01 10:46:34 +00:00
fac20df060
Bug 1796085 - Part 1: Define MOZ_BACKGROUNDTASKS macro globally r=smaug,necko-reviewers,application-update-reviewers,nalexander,valentin
...
There are 10+ separate macro definition for this, we can do it globally instead.
Differential Revision: https://phabricator.services.mozilla.com/D156911
2022-10-19 12:04:08 +00:00
0316dc51b9
Bug 1790614 - Part 2: Use {ASSERT,ENSURE}_NS_{SUCCEEEDED,FAILED} in gtests, r=ahal,necko-reviewers
...
These macros will produce better outputs when they fail than these existing
patterns using `ENSURE_TRUE(NS_SUCCEEDED(...))` or similar, so this is a bulk
rewrite of existing tests to use them.
It should also help with discoverability when people base their tests off of
other existing tests.
Differential Revision: https://phabricator.services.mozilla.com/D157214
2022-09-15 14:51:50 +00:00
c50cb528fc
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
3ccd75af8d
Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD
2022-08-03 18:55:00 +03:00
fdb7cb2ecd
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
89d63c91e6
Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE
2022-08-02 04:59:08 +03:00
0f4ac7ad97
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
997047e2a4
Bug 1772006 - Part 4: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret
...
This patch moves EqualsIgnoreCase to ns[T]StringObsolete, and removes
the aCount argument, instead migrating callers to use `StringBeginsWith`
with a case-insensitive comparator.
In addition, nsTStringRepr::Compare was removed and replaced with either
calls to methods like `StringBeginsWith` or the global `Compare` method.
These changes required some modifications at call-sites but should make
the behaviour less surprising and more consistent.
Differential Revision: https://phabricator.services.mozilla.com/D148299
2022-07-30 00:12:48 +00:00
1332af1b0d
Bug 1777486 - Part 8: Update testcase comments that mentions XPCOMUtils. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D151220
2022-07-12 04:21:37 +00:00
7738a75fdd
Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
...
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
6a043ab687
Bug 1777486 - Part 8: Update testcase comments that mentions XPCOMUtils. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D151220
2022-07-11 15:09:16 +00:00
c6b2c5db61
Backed out 9 changesets (bug 1772006) causing build bustages on nsTString.cpp. CLOSED TREE
...
Backed out changeset f17c7565707b (bug 1772006)
Backed out changeset c725fe1f5882 (bug 1772006)
Backed out changeset d19663161261 (bug 1772006)
Backed out changeset b6611ab002d9 (bug 1772006)
Backed out changeset 790f42b64af9 (bug 1772006)
Backed out changeset 79a734b4e4d9 (bug 1772006)
Backed out changeset 42730aae16ea (bug 1772006)
Backed out changeset b2542aef3054 (bug 1772006)
Backed out changeset 962bfea4a309 (bug 1772006)
2022-06-11 01:13:42 +03:00
1475267b8c
Bug 1772006 - Part 5: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret
...
In addition to moving these methods to a more appropriate file, they were
simplified to make them easier to maintain in the future.
nsTStringRepr::Compare was extended to also work on char16_t strings, and the
case insensitive and other options were removed as they aren't necessary. This
required some changes to callers in the tree.
The EqualsIgnoreCase method was also simplified by using `std::string_view`.
Differential Revision: https://phabricator.services.mozilla.com/D148299
2022-06-10 21:12:07 +00:00
4de0e49a0d
Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D143574
2022-04-13 14:08:06 +00:00
1d40b54278
Backed out 3 changesets (bug 1752209, bug 1752212) for causing build bustages on nsXULPrototypeCache.cpp. CLOSED TREE
...
Backed out changeset 8f10b666008a (bug 1752209)
Backed out changeset 557c428fb6bc (bug 1752212)
Backed out changeset e38fbd381ed3 (bug 1752212)
2022-04-13 16:09:50 +03:00
7f252a9982
Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D143574
2022-04-13 11:41:10 +00:00
057785b6d5
Bug 1519200 - Remove `NS_ERROR_FILE_TARGET_DOES_NOT_EXIST` in favor of `NS_ERROR_FILE_NOT_FOUND`. r=xpcom-reviewers,nika,dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D77575
2022-04-05 15:17:03 +00:00
c7b453b99a
Bug 1755181 - Allow live language reloading to invalidate the startup cache; r=dthayer
...
The startup cache essentially leaks memory here for the old startup cache
data. My assumption here is that there can be dangling pointers into this
data so it's not safe to delete these old tables. Live language switching
is a relatively rare event, so this leak should be acceptable compared to
adding locking mechanisms to the underlying data.
Differential Revision: https://phabricator.services.mozilla.com/D140968
2022-03-22 15:19:47 +00:00
c5917ed65a
Bug 1207753: Basic thread-safety annotations to quiet errors until real annotations land r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D141062
2022-03-17 18:39:15 +00:00
fcaf70841e
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
2390d257e6
Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE
2022-03-16 18:32:51 +02:00
4b033a5256
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
927ad62c6a
Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE
2022-03-16 14:38:14 +02:00
7d4b5fae04
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
64193785d4
Backed out 3 changesets (bug 1724509) for causing marionette failures. CLOSED TREE
...
Backed out changeset d47ffc49daff (bug 1724509)
Backed out changeset b267592b49db (bug 1724509)
Backed out changeset b34151a18850 (bug 1724509)
2021-10-06 03:57:57 +03:00
ad9c87880c
Bug 1724509: Part 2 - Don't load preloader caches when startup cache is being ignored. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D122029
2021-10-05 19:06:43 +00:00
Emilio Cobos Álvarez
David Shin
Natalia Csoregi
Kelsey Gilbert
Cosmin Sabou
Randell Jesup
Jens Stutte
Sylvestre Ledru
Joel Maher
Jan Varga
Nika Layzell
Mark Banner
Otto Länd
Kris Maglione
Randell Jesup
serge-sans-paille
Norisz Fay
Tooru Fujisawa
Kagami Sascha Rosylight
Fabrice Desré
Andreea Pavel
criss
Jan Rio Krause
Greg Tatum
Noemi Erli
Butkovits Atila
Iulian Moraru